[GitHub] michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml

2018-05-22 Thread GitBox
michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml URL: https://github.com/apache/maven/pull/163#issuecomment-390888715 @hboutemy , looks good to me. Did you have a chance to run the new IT on?

[GitHub] michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml

2018-05-21 Thread GitBox
michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml URL: https://github.com/apache/maven/pull/163#issuecomment-390731655 > I know that we have such a case with booleans, where we do not put the effective field type in the descriptor

[GitHub] michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml

2018-05-06 Thread GitBox
michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml URL: https://github.com/apache/maven/pull/163#issuecomment-386841740 As far as I understand this PR, you are interpolating the settings before it is fed to `SettingsXpp3Reader`?

[GitHub] michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml

2018-05-05 Thread GitBox
michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml URL: https://github.com/apache/maven/pull/163#issuecomment-386842019 Can you also provide an IT for that? @hboutemy, @rfscholte This is a very interesting case and I can confirm

[GitHub] michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml

2018-05-05 Thread GitBox
michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml URL: https://github.com/apache/maven/pull/163#issuecomment-386841740 As far as I understand this PR, you are interpolating the settings before it is fead to `SettingsXpp3Reader`?