[GitHub] michael-o commented on issue #4: [MJAVADOC-527] - detectLinks may pass invalid urls to javadoc

2019-01-04 Thread GitBox
michael-o commented on issue #4: [MJAVADOC-527] - detectLinks may pass invalid urls to javadoc URL: https://github.com/apache/maven-javadoc-plugin/pull/4#issuecomment-451463405 I have pushed branch MJAVADOC-527, take a look at the history. This what I have expected. I will now go on with

[GitHub] michael-o commented on issue #4: [MJAVADOC-527] - detectLinks may pass invalid urls to javadoc

2019-01-04 Thread GitBox
michael-o commented on issue #4: [MJAVADOC-527] - detectLinks may pass invalid urls to javadoc URL: https://github.com/apache/maven-javadoc-plugin/pull/4#issuecomment-451459020 Thank you, I will take a look at it. This is

[GitHub] michael-o commented on issue #4: [MJAVADOC-527] - detectLinks may pass invalid urls to javadoc

2019-01-03 Thread GitBox
michael-o commented on issue #4: [MJAVADOC-527] - detectLinks may pass invalid urls to javadoc URL: https://github.com/apache/maven-javadoc-plugin/pull/4#issuecomment-451214924 I cannot see that anything has been rebased or I am blind. I can only see merge commits: * commit

[GitHub] michael-o commented on issue #4: [MJAVADOC-527] - detectLinks may pass invalid urls to javadoc

2019-01-02 Thread GitBox
michael-o commented on issue #4: [MJAVADOC-527] - detectLinks may pass invalid urls to javadoc URL: https://github.com/apache/maven-javadoc-plugin/pull/4#issuecomment-450820038 Something is still fishy about this: mosipov@mikaw10 MINGW64

[GitHub] michael-o commented on issue #4: [MJAVADOC-527] - detectLinks may pass invalid urls to javadoc

2018-12-26 Thread GitBox
michael-o commented on issue #4: [MJAVADOC-527] - detectLinks may pass invalid urls to javadoc URL: https://github.com/apache/maven-javadoc-plugin/pull/4#issuecomment-449958130 The change looks mostly fine to me. Please rebase again and drop unrelated changes.