mbenson commented on PR #1446:
URL: https://github.com/apache/maven/pull/1446#issuecomment-2090633311
@gnodet again, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
gnodet merged PR #1446:
URL: https://github.com/apache/maven/pull/1446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gnodet commented on code in PR #1446:
URL: https://github.com/apache/maven/pull/1446#discussion_r1581850909
##
maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java:
##
@@ -897,69 +904,91 @@ private List
interpolateActivations(
gnodet commented on PR #1446:
URL: https://github.com/apache/maven/pull/1446#issuecomment-2079833746
> hi @gnodet ... so with the implementation having been largely duplicated
from model-builder into api-impl, would the similar code remain in both places
indefinitely, or will the
mbenson commented on PR #1446:
URL: https://github.com/apache/maven/pull/1446#issuecomment-2079675232
hi @gnodet ... so with the implementation having been largely duplicated
from model-builder into api-impl, would the similar code remain in both places
indefinitely, or will the
gnodet commented on PR #1446:
URL: https://github.com/apache/maven/pull/1446#issuecomment-2073420753
@mbenson I've rebased the PR and ported it to the new v4 model builder,
please have a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please
mbenson commented on PR #1446:
URL: https://github.com/apache/maven/pull/1446#issuecomment-2052059016
@gnodet do you have any thoughts on the best way to backport this feature to
Maven 3? https://github.com/apache/maven/pull/1447 is my original PR, but a
wildly divergent implementation may
gnodet commented on PR #1446:
URL: https://github.com/apache/maven/pull/1446#issuecomment-2049984725
> Thanks @gnodet and @rmannibucau for the approvals! What is the next step?
I'm nearly done with http://github.com/apache/maven/pull/1457, so as soon as
that one is merged, we'll be
mbenson commented on PR #1446:
URL: https://github.com/apache/maven/pull/1446#issuecomment-2022889587
Thanks @gnodet and @rmannibucau for the approvals! What is the next step?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
mbenson commented on PR #1446:
URL: https://github.com/apache/maven/pull/1446#issuecomment-2021625025
By way of [some] testing, I went ahead and expanded the profile activation
model validation to consider the whole activation, similarly to how we are now
interpolating the whole
gnodet commented on code in PR #1446:
URL: https://github.com/apache/maven/pull/1446#discussion_r1538325712
##
maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java:
##
@@ -897,69 +904,89 @@ private List
interpolateActivations(
mbenson commented on PR #1446:
URL: https://github.com/apache/maven/pull/1446#issuecomment-2015691625
Here is the version that enhances `DefaultModelBuilder`. Can anyone offer
ideas on the likely shape of unit tests for this approach?
--
This is an automated message from the Apache Git
mbenson commented on PR #1446:
URL: https://github.com/apache/maven/pull/1446#issuecomment-2014937249
That is possible, sure. I'll take a look in a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
gnodet commented on PR #1446:
URL: https://github.com/apache/maven/pull/1446#issuecomment-2014819431
> From email thread:
>
> Guillaume Nodet [gno...@apache.org](mailto:gno...@apache.org) wrote:
>
> > I thought you were referring to having a small language in the
> >
mbenson commented on PR #1446:
URL: https://github.com/apache/maven/pull/1446#issuecomment-2012419183
From email thread:
Guillaume Nodet wrote:
> I thought you were referring to having a small language in the
property activation...
I hadn't noted the discussion when it
mbenson commented on PR #1446:
URL: https://github.com/apache/maven/pull/1446#issuecomment-2011019881
> > That was what I originally considered, but I quickly came to the opinion
that as soon as we did it that way, someone would want to use some such
property to match a Java version, etc.,
gnodet commented on PR #1446:
URL: https://github.com/apache/maven/pull/1446#issuecomment-2010621686
> That was what I originally considered, but I quickly came to the opinion
that as soon as we did it that way, someone would want to use some such
property to match a Java version, etc.,
mbenson commented on PR #1446:
URL: https://github.com/apache/maven/pull/1446#issuecomment-2010580914
That was what I originally considered, but I quickly came to the opinion
that as soon as we did it that way, someone would want to use some such
property to match a Java version, etc., and
gnodet commented on PR #1446:
URL: https://github.com/apache/maven/pull/1446#issuecomment-2010577651
> > @mbenson well a mini language got rejected multiple times on the list -
this is where this sh solution comes from. ultimately I'm for having a
multipass filtering to filter as much as
gnodet commented on PR #1446:
URL: https://github.com/apache/maven/pull/1446#issuecomment-2010564585
> @mbenson well a mini language got rejected multiple times on the list -
this is where this sh solution comes from. ultimately I'm for having a
multipass filtering to filter as much as we
20 matches
Mail list logo
