Re: [PR] [MNG-8084] Move ModelBuilder and resolver provider to v4 api [maven]

2024-05-13 Thread via GitHub
desruisseaux commented on PR #1457: URL: https://github.com/apache/maven/pull/1457#issuecomment-2107269631 A few more changes seem to be necessary for allowing `maven-plugin-tools` and `maven-plugin-testing` to compile. I created a commit there, but no pull request yet because I'm not sure

Re: [PR] [MNG-8084] Move ModelBuilder and resolver provider to v4 api [maven]

2024-04-12 Thread via GitHub
gnodet merged PR #1457: URL: https://github.com/apache/maven/pull/1457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

Re: [PR] [MNG-8084] Move ModelBuilder and resolver provider to v4 api [maven]

2024-04-11 Thread via GitHub
cstamas commented on code in PR #1457: URL: https://github.com/apache/maven/pull/1457#discussion_r1560604618 ## api/maven-api-core/src/main/java/org/apache/maven/api/services/ModelBuilderResult.java: ## @@ -54,22 +54,28 @@ public interface ModelBuilderResult { Model getFile

Re: [PR] [MNG-8084] Move ModelBuilder and resolver provider to v4 api [maven]

2024-04-02 Thread via GitHub
cstamas commented on PR #1457: URL: https://github.com/apache/maven/pull/1457#issuecomment-2032000986 I think you are right: mvn4 scopes are "superset" of those of mvn3, plus, if you compare their ordering, they remain in same place (ordering by "width"), this is the two config "dump" outpu

Re: [PR] [MNG-8084] Move ModelBuilder and resolver provider to v4 api [maven]

2024-03-29 Thread via GitHub
gnodet commented on PR #1457: URL: https://github.com/apache/maven/pull/1457#issuecomment-2027037497 > By project model version? > > There is an important distinction: [mvn3](https://github.com/apache/maven/blob/master/maven-resolver-provider/src/main/java/org/apache/maven/repository/

Re: [PR] [MNG-8084] Move ModelBuilder and resolver provider to v4 api [maven]

2024-03-29 Thread via GitHub
cstamas commented on PR #1457: URL: https://github.com/apache/maven/pull/1457#issuecomment-2027026565 By project model version? There is an important distinction: [mvn3](https://github.com/apache/maven/blob/master/maven-resolver-provider/src/main/java/org/apache/maven/repository/in

Re: [PR] [MNG-8084] Move ModelBuilder and resolver provider to v4 api [maven]

2024-03-29 Thread via GitHub
gnodet commented on PR #1457: URL: https://github.com/apache/maven/pull/1457#issuecomment-2027019382 > Maybe "v3 mode" should use old stuff, and "v4 mode" should use this new stuff? As we also have "v3 scopes vs v4" scopes, and v4 scopes should not be used with v3 modes... How would

Re: [PR] [MNG-8084] Move ModelBuilder and resolver provider to v4 api [maven]

2024-03-29 Thread via GitHub
cstamas commented on PR #1457: URL: https://github.com/apache/maven/pull/1457#issuecomment-2026928884 Maybe "v3 mode" should use old stuff, and "v4 mode" should use this new stuff? As we also have "v3 scopes vs v4" scopes, and v4 scopes should not be used with v3 modes... -- This is an a