Re: [PR] [MSHADE-452]Fix ServiceResourceTransformer not correct issue. [maven-shade-plugin]

2024-05-23 Thread via GitHub
hk-lrzy commented on PR #193: URL: https://github.com/apache/maven-shade-plugin/pull/193#issuecomment-2126515899 > Hi @hk-lrzy , sorry for the delay (guess the PR popped during holidays). From my window this PR has the risk to revert some of the fixes done before. Long story short shade

Re: [PR] [MSHADE-452]Fix ServiceResourceTransformer not correct issue. [maven-shade-plugin]

2024-02-18 Thread via GitHub
rmannibucau commented on PR #193: URL: https://github.com/apache/maven-shade-plugin/pull/193#issuecomment-1951344405 Hi @hk-lrzy , sorry for the delay (guess the PR popped during holidays). From my window this PR has the risk to revert some of the fixes done before. Long story short