[
https://issues.apache.org/jira/browse/MPLUGIN-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hervé Boutemy closed MPLUGIN-330.
---------------------------------
Resolution: Fixed
Assignee: Hervé Boutemy
fixed in
https://gitbox.apache.org/repos/asf?p=maven-plugin-tools.git&a=commit&h=0b377fba6408bb45c79e0d9b2ed02c84923c07e7
this was a typo that had no visible impact: the global result is the same
(having no dependencies in a null collection or an empty collection)
the CI failure is a false positive caused by a slave node not being able to git
clone...
> If and else-if branches has the same condition
> ----------------------------------------------
>
> Key: MPLUGIN-330
> URL: https://issues.apache.org/jira/browse/MPLUGIN-330
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
> Affects Versions: 3.5
> Reporter: songwanging
> Assignee: Hervé Boutemy
> Priority: Minor
> Fix For: 3.5.1
>
>
> Our tool DeepTect has detected a piece of buggy code snippet, in which the if
> and else branches has the same condition.
> Path:
> maven-plugin-tools/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java
> {code:java}
> public void execute(){
> ...
> Set<Artifact> requestDependencies;
> if ( mojoDependencies == null )
> {
> requestDependencies = dependencies;
> }
> else if ( mojoDependencies == null )
> {
> requestDependencies = null;
> }
> ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
