[ 
https://issues.apache.org/jira/browse/MSHADE-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16999086#comment-16999086
 ] 

Elliotte Rusty Harold commented on MSHADE-196:
----------------------------------------------

seems right

> Must not attempt to unzip unfamiliar dependency type
> ----------------------------------------------------
>
>                 Key: MSHADE-196
>                 URL: https://issues.apache.org/jira/browse/MSHADE-196
>             Project: Maven Shade Plugin
>          Issue Type: Bug
>    Affects Versions: 2.3
>            Reporter: Markus Karg
>            Priority: Major
>              Labels: dll
>
> When adding dependencies to rather unconventional package types, like "dll" 
> or "pdf", we noticed that the share plugin by default tries to unzip them. 
> This is weird, as obviously this attempt will fail in almost any case. A user 
> is forced to add explicit exceptions, which is tedious, error prone, and 
> breaks CoC.
> The solution is rather obvious: The shade plugin must only unzip those 
> package types which it is familiar with. This namely is e. g. JAR, ZIP, BZIP, 
> GZIP etc. but certainly not anything unknown.
> The result of this change will be a simplification of the pom.xml, and shade 
> plugin's behaviour will be more like a user expects it to work: Don't touch 
> unkown stuff!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to