[ http://jira.codehaus.org/browse/MNG-2161?page=all ] Milos Kleint closed MNG-2161: -----------------------------
Resolution: Fixed Fix Version: 2.1 done. > [maven-embedder-refactor] values from settings.xml never used > ------------------------------------------------------------- > > Key: MNG-2161 > URL: http://jira.codehaus.org/browse/MNG-2161 > Project: Maven 2 > Type: Bug > Components: Embedding > Versions: 2.1 > Environment: jason's embedder refactor branch > Reporter: Milos Kleint > Assignee: Milos Kleint > Fix For: 2.1 > Attachments: settings.patch > > > The CommonMavenObjectFactory create Settings object based on the parameters > like settings locations, that fine, but also takes the offline state and > usage of plugin regisry as parameters. However these values are also defined > in the settings.xml file. 1. It turns into a Chicken-Egg problem, because I > need the settings parsed to know the value (if user doens't specify on > command line). 2. Or I can go with some defaults + user command line input.. > Then the settings values are never used. > patch containing alternate method included. Old one kept. Should be also > exposed via the MavenEmbedder class o the outside. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira