Re: [PR] Align mvnd m39 with Maven 3.9.x re config interpolation [maven-mvnd]

2024-04-20 Thread via GitHub
wendigo commented on PR #933: URL: https://github.com/apache/maven-mvnd/pull/933#issuecomment-2067648142 Adding `-Dmodernizer.violationsFile=${session.rootDirectory}/.mvn/modernizer/violations.xml` to the `.mvn/maven.config` ends with the exception: ``` [ERROR] Failed to execute

Re: [PR] Align mvnd m39 with Maven 3.9.x re config interpolation [maven-mvnd]

2024-04-20 Thread via GitHub
wendigo commented on PR #933: URL: https://github.com/apache/maven-mvnd/pull/933#issuecomment-2067647836 @cstamas unfortunately still doesn't work for our case. I've tried reapplying: https://github.com/trinodb/trino/commit/ff1cddbd31d70610952922b19c13bd957e33f00f and that works in mvn

Re: [PR] Align mvnd m39 with Maven 3.9.x re config interpolation [maven-mvnd]

2024-04-20 Thread via GitHub
wendigo commented on PR #933: URL: https://github.com/apache/maven-mvnd/pull/933#issuecomment-2067628962 Will do @cstamas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Align mvnd m39 with Maven 3.9.x re config interpolation [maven-mvnd]

2024-04-20 Thread via GitHub
cstamas commented on PR #933: URL: https://github.com/apache/maven-mvnd/pull/933#issuecomment-2067628217 @wendigo Would be grateful if you build mvnd locally and try it with Trino build, it should now work OOTB. No need for native and all that, just `mvn clean install` and use it on Trino

Re: [PR] Align mvnd m39 with Maven 3.9.x re config interpolation [maven-mvnd]

2024-04-19 Thread via GitHub
cstamas merged PR #933: URL: https://github.com/apache/maven-mvnd/pull/933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Align mvnd m39 with Maven 3.9.x re config interpolation [maven-mvnd]

2024-04-18 Thread via GitHub
cstamas commented on PR #933: URL: https://github.com/apache/maven-mvnd/pull/933#issuecomment-2063634024 @wendigo ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To