[jira] [Commented] (MNG-6148) Can't package and assemble with JDK9/Jigsaw
[ https://issues.apache.org/jira/browse/MNG-6148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127770#comment-16127770 ] Hudson commented on MNG-6148: - SUCCESS: Integrated in Jenkins build maven-3.x #1662 (See [https://builds.apache.org/job/maven-3.x/1662/]) [MNG-6148] Can't package and assemble with JDK9/Jigsaw (rfscholte: [http://git-wip-us.apache.org/repos/asf/?p=maven.git=commit=842db371f0fcaf4e930b99395fb6a8bb442684d6]) * (edit) pom.xml > Can't package and assemble with JDK9/Jigsaw > --- > > Key: MNG-6148 > URL: https://issues.apache.org/jira/browse/MNG-6148 > Project: Maven > Issue Type: Bug >Reporter: Robert Scholte >Assignee: Robert Scholte >Priority: Minor > Fix For: 3.5.1-candidate > > > Rootcause is project verona: Here are the related plugins with their fixed > versions: > * maven-assembly-plugin:3.0.0 > * maven-jar-plugin:3.0.0 > * maven-javadoc-plugin:2.10.4 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MNG-6127) Fix plugin execution configuration interference
[ https://issues.apache.org/jira/browse/MNG-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127838#comment-16127838 ] ASF GitHub Bot commented on MNG-6127: - Github user mkrizmanic commented on the issue: https://github.com/apache/maven-integration-testing/pull/21 already merged > Fix plugin execution configuration interference > --- > > Key: MNG-6127 > URL: https://issues.apache.org/jira/browse/MNG-6127 > Project: Maven > Issue Type: Bug > Components: core >Affects Versions: 3.3.9 >Reporter: Mario Krizmanic >Assignee: Robert Scholte > Fix For: 3.5.1 > > > The plugin execution configuration may interfere across maven modules > included in a build in case a plugin extension provides a default > configuration. > Because the custom plugin configuration defined in the maven modules is > merged to the plugin execution configuration and the merged configuration is > re-used during building the other included maven modules, so the other maven > modules may be build using the invalid configuration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MNG-6127) Fix plugin execution configuration interference
[ https://issues.apache.org/jira/browse/MNG-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127837#comment-16127837 ] ASF GitHub Bot commented on MNG-6127: - Github user mkrizmanic closed the pull request at: https://github.com/apache/maven-integration-testing/pull/21 > Fix plugin execution configuration interference > --- > > Key: MNG-6127 > URL: https://issues.apache.org/jira/browse/MNG-6127 > Project: Maven > Issue Type: Bug > Components: core >Affects Versions: 3.3.9 >Reporter: Mario Krizmanic >Assignee: Robert Scholte > Fix For: 3.5.1 > > > The plugin execution configuration may interfere across maven modules > included in a build in case a plugin extension provides a default > configuration. > Because the custom plugin configuration defined in the maven modules is > merged to the plugin execution configuration and the merged configuration is > re-used during building the other included maven modules, so the other maven > modules may be build using the invalid configuration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (MNG-6127) Fix plugin execution configuration interference
[ https://issues.apache.org/jira/browse/MNG-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MNG-6127. --- Resolution: Fixed Assignee: Robert Scholte Fix Version/s: (was: 3.5.1-candidate) (was: needing-scrub-3.4.0-fallout) 3.5.1 > Fix plugin execution configuration interference > --- > > Key: MNG-6127 > URL: https://issues.apache.org/jira/browse/MNG-6127 > Project: Maven > Issue Type: Bug > Components: core >Affects Versions: 3.3.9 >Reporter: Mario Krizmanic >Assignee: Robert Scholte > Fix For: 3.5.1 > > > The plugin execution configuration may interfere across maven modules > included in a build in case a plugin extension provides a default > configuration. > Because the custom plugin configuration defined in the maven modules is > merged to the plugin execution configuration and the merged configuration is > re-used during building the other included maven modules, so the other maven > modules may be build using the invalid configuration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (MNG-6148) Can't package and assemble with JDK9/Jigsaw
[ https://issues.apache.org/jira/browse/MNG-6148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MNG-6148. --- Resolution: Fixed Fix Version/s: (was: 3.5.1-candidate) 3.5.1 > Can't package and assemble with JDK9/Jigsaw > --- > > Key: MNG-6148 > URL: https://issues.apache.org/jira/browse/MNG-6148 > Project: Maven > Issue Type: Bug >Reporter: Robert Scholte >Assignee: Robert Scholte >Priority: Minor > Fix For: 3.5.1 > > > Rootcause is project verona: Here are the related plugins with their fixed > versions: > * maven-assembly-plugin:3.0.0 > * maven-jar-plugin:3.0.0 > * maven-javadoc-plugin:2.10.4 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (MNG-6220) Add CLI options to control color output
[
https://issues.apache.org/jira/browse/MNG-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte closed MNG-6220.
---
Resolution: Fixed
Assignee: Robert Scholte
Fix Version/s: (was: 3.5.1-candidate)
3.5.1
> Add CLI options to control color output
> ---
>
> Key: MNG-6220
> URL: https://issues.apache.org/jira/browse/MNG-6220
> Project: Maven
> Issue Type: New Feature
>Reporter: Manuel Ryan
>Assignee: Robert Scholte
> Fix For: 3.5.1
>
>
> Currently, the only way to enable/disable color output is to use the
> batch-mode or log-file options.
> If a user wants colored output but no interactivity (ie: jenkins environment
> with the ansicolor plugin), there is no CLI option combination to support the
> use-case.
> I propose to add an option to control output coloring directly.
> {noformat}
> --color=enabled <- color output always enabled
> --color=disabled <- color output always disabled
> --color=auto <- current behavior (default)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Closed] (MCOMPILER-283) JDK9+b151 Failure Running IT's
[
https://issues.apache.org/jira/browse/MCOMPILER-283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise closed MCOMPILER-283.
-
Resolution: Implemented
Assignee: Karl Heinz Marbaise
superseded by newer releases of the maven-compiler-plugin.
> JDK9+b151 Failure Running IT's
> --
>
> Key: MCOMPILER-283
> URL: https://issues.apache.org/jira/browse/MCOMPILER-283
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.6.0
> Environment: ~/Downloads/maven-compiler-plugin-3.6.0$ mvn --version
> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> 2015-11-10T17:41:47+01:00)
> Maven home: /usr/local/maven
> Java version: 9-ea, vendor: Oracle Corporation
> Java home: /Library/Java/JavaVirtualMachines/jdk1.9.0_ea+138.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.11.6", arch: "x86_64", family: "mac"
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
> Attachments: build.log, build.log, build.log
>
>
> {code}
> [INFO] --- maven-invoker-plugin:2.0.0:verify (integration-test) @
> maven-compiler-plugin ---
> [INFO] -
> [INFO] Build Summary:
> [INFO] Passed: 19, Failed: 10, Errors: 0, Skipped: 0
> [INFO] -
> [ERROR] The following builds failed:
> [ERROR] * error-prone-compiler\pom.xml
> [ERROR] * groovy-project-with-new-plexus-compiler\pom.xml
> [ERROR] * jdk16-annotation\pom.xml
> [ERROR] * MCOMPILER-157\pom.xml
> [ERROR] * mcompiler-182\pom.xml
> [ERROR] * MCOMPILER-197\pom.xml
> [ERROR] * MCOMPILER-203-processorpath\pom.xml
> [ERROR] * mcompiler-21_class-remove\pom.xml
> [ERROR] * mcompiler-21_methodname-change\pom.xml
> [ERROR] * MCOMPILER-224\pom.xml
> [INFO] -
> {code}
> [UPDATE] Probably the #AwkwardStrongEncapsulation made even more tests fail.
> E.g. scripts are waiting for groovy 2.4.8
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (MASSEMBLY-866) poor performance of jar-with-dependencies when run in same run as docbook
[
https://issues.apache.org/jira/browse/MASSEMBLY-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120192#comment-16120192
]
John Vines edited comment on MASSEMBLY-866 at 8/15/17 7:50 PM:
---
-Maven - seen on both 3.3.9 and 3.5.0-
-JDK - Openjdk 1.7.0.141, oracle 1.7.0_75, oracle 1.7.0_67-
-Yes, we are doing a maven job in jenkins-
-Running test with 2.6 now ( will also run test with those overrides, wasn't
sure if I could override plugins like that)-
-228M-
-Which flags would you like?-
Ugh, I apologize, I thought I had narrowed it down to my two modules (i.e.
docbook + assembly) but turns out I had screwed up something context switching.
It is slow, but it is under certain conditions that are not the ones laid out
above, as well as those versions above.
I can state for certain I've seen it occuring on
{code}Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T11:41:47-05:00)
Maven home: /usr/share/maven
Java version: 1.7.0_141, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-1.7.0-openjdk-1.7.0.141-2.6.10.1.el7_3.x86_64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "3.10.0-514.16.1.el7.x86_64", arch: "amd64", family:
"unix"
{code} and {code}Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426;
2017-04-03T15:39:06-04:00)
Maven home: /usr/local/Cellar/maven/3.5.0/libexec
Java version: 1.7.0_67, vendor: Oracle Corporation
Java home: /Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.12.3", arch: "x86_64", family: "mac"
{code}
I'm slowly going through iterations so I don't screw up my analysis again
was (Author: vines):
-Maven - seen on both 3.3.9 and 3.5.0
JDK - Openjdk 1.7.0.141, oracle 1.7.0_75, oracle 1.7.0_67
Yes, we are doing a maven job in jenkins
Running test with 2.6 now ( will also run test with those overrides, wasn't
sure if I could override plugins like that)
228M
Which flags would you like?
-
Ugh, I apologize, I thought I had narrowed it down to my two modules (i.e.
docbook + assembly) but turns out I had screwed up something context switching.
It is slow, but it is under certain conditions that are not the ones laid out
above, as well as those versions above.
I can state for certain I've seen it occuring on
{code}Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T11:41:47-05:00)
Maven home: /usr/share/maven
Java version: 1.7.0_141, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-1.7.0-openjdk-1.7.0.141-2.6.10.1.el7_3.x86_64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "3.10.0-514.16.1.el7.x86_64", arch: "amd64", family:
"unix"
{code} and {code}Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426;
2017-04-03T15:39:06-04:00)
Maven home: /usr/local/Cellar/maven/3.5.0/libexec
Java version: 1.7.0_67, vendor: Oracle Corporation
Java home: /Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.12.3", arch: "x86_64", family: "mac"
{code}
I'm slowly going through iterations so I don't screw up my analysis again
> poor performance of jar-with-dependencies when run in same run as docbook
> -
>
> Key: MASSEMBLY-866
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-866
> Project: Maven Assembly Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: John Vines
> Labels: performance
>
> I apologize for the lack of information, but we have a large build
> environment which I cannot share, but I'll try to explain things as best I
> can.
> In our full build path, we have 2 components that I've found have side
> effects. One is a doc build which uses the docbkx-maven-plugin
> (https://github.com/mimil/docbkx-tools) to generate documentation (and
> usually takes a while, ~27 minutes) and another which builds a
> jar-with-depends for our UI. Prior to upgrade the assembly plugin to 3.0.0
> from 2.3 or 2.5 (I cannot recall) everything ran fine. After upgrading we
> found our jenkins builds taking about 40 more minutes, most of this change
> was in maven-assembly-plugin for that UI jar-with-dependencies
> {code}assembly-plugin:3.0.0:single (make-assembly) @ sqrrl-web-dist-ui ---
> 16:17:37 [INFO] Reading assembly descriptor: src/main/assembly/dist-ui.xml
> 16:17:40 [INFO] Building jar:
> /var/lib/jenkins/workspace/sqrrl-master-build/web/dist-ui/target/sqrrl-web-dist-ui-2.8.0-SNAPSHOT-jar-with-dependencies.jar
> 17:01:54 [INFO] {code}
> Eventually I isolated to a case where just that doc and that jar-with-deps
> being built would cause the jar-with-deps to take ~40 minutes, but if I built
> it by
[jira] [Comment Edited] (MASSEMBLY-866) poor performance of jar-with-dependencies when run in same run as docbook
[
https://issues.apache.org/jira/browse/MASSEMBLY-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120192#comment-16120192
]
John Vines edited comment on MASSEMBLY-866 at 8/15/17 7:50 PM:
---
-Maven - seen on both 3.3.9 and 3.5.0
JDK - Openjdk 1.7.0.141, oracle 1.7.0_75, oracle 1.7.0_67
Yes, we are doing a maven job in jenkins
Running test with 2.6 now ( will also run test with those overrides, wasn't
sure if I could override plugins like that)
228M
Which flags would you like?
-
Ugh, I apologize, I thought I had narrowed it down to my two modules (i.e.
docbook + assembly) but turns out I had screwed up something context switching.
It is slow, but it is under certain conditions that are not the ones laid out
above, as well as those versions above.
I can state for certain I've seen it occuring on
{code}Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T11:41:47-05:00)
Maven home: /usr/share/maven
Java version: 1.7.0_141, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-1.7.0-openjdk-1.7.0.141-2.6.10.1.el7_3.x86_64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "3.10.0-514.16.1.el7.x86_64", arch: "amd64", family:
"unix"
{code} and {code}Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426;
2017-04-03T15:39:06-04:00)
Maven home: /usr/local/Cellar/maven/3.5.0/libexec
Java version: 1.7.0_67, vendor: Oracle Corporation
Java home: /Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.12.3", arch: "x86_64", family: "mac"
{code}
I'm slowly going through iterations so I don't screw up my analysis again
was (Author: vines):
Maven - seen on both 3.3.9 and 3.5.0
JDK - Openjdk 1.7.0.141, oracle 1.7.0_75, oracle 1.7.0_67
Yes, we are doing a maven job in jenkins
Running test with 2.6 now ( will also run test with those overrides, wasn't
sure if I could override plugins like that)
228M
Which flags would you like?
> poor performance of jar-with-dependencies when run in same run as docbook
> -
>
> Key: MASSEMBLY-866
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-866
> Project: Maven Assembly Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: John Vines
> Labels: performance
>
> I apologize for the lack of information, but we have a large build
> environment which I cannot share, but I'll try to explain things as best I
> can.
> In our full build path, we have 2 components that I've found have side
> effects. One is a doc build which uses the docbkx-maven-plugin
> (https://github.com/mimil/docbkx-tools) to generate documentation (and
> usually takes a while, ~27 minutes) and another which builds a
> jar-with-depends for our UI. Prior to upgrade the assembly plugin to 3.0.0
> from 2.3 or 2.5 (I cannot recall) everything ran fine. After upgrading we
> found our jenkins builds taking about 40 more minutes, most of this change
> was in maven-assembly-plugin for that UI jar-with-dependencies
> {code}assembly-plugin:3.0.0:single (make-assembly) @ sqrrl-web-dist-ui ---
> 16:17:37 [INFO] Reading assembly descriptor: src/main/assembly/dist-ui.xml
> 16:17:40 [INFO] Building jar:
> /var/lib/jenkins/workspace/sqrrl-master-build/web/dist-ui/target/sqrrl-web-dist-ui-2.8.0-SNAPSHOT-jar-with-dependencies.jar
> 17:01:54 [INFO] {code}
> Eventually I isolated to a case where just that doc and that jar-with-deps
> being built would cause the jar-with-deps to take ~40 minutes, but if I built
> it by itself (all other maven options being equal) it would take about 1.5
> minutes.
> I'm honestly not too familiar with the inner workings of this plugin, nor the
> maven docbook plugin, but my hunch was that the docbook plugin was
> 'corrupting' or otherwise altering the main maven jvm in such a way to cause
> this. It does use some really old plexus plugins, among others, afterall.
> However, I stumbled across MASSEMBLY-424 and tested forking
> maven-assembly-plugin:3.0.0 and updating plexus-archiver to 3.5, plexus-io to
> 3.0.0 and plexus-utils to 3.1.0 and ran my 2 module build with the custom
> plugin and it ran just as quick as being run standalone (1.5minutes). (To
> build it with those plugins I had to disable checkstyle and enforcer though
> since at least one of those plugins versions was java7)
> One last datapoint is that in our jar-with-deps we are including
> bouncycastle's bcpix and bcprov and explicitly excluding them from the
> jar-with-depends also made that 2 module build faster (but not as fast), so
> I'm not 100% sure it's the docbook plugin was the catalyst there.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MNG-6127) Fix plugin execution configuration interference
[ https://issues.apache.org/jira/browse/MNG-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127787#comment-16127787 ] Hudson commented on MNG-6127: - SUCCESS: Integrated in Jenkins build maven-3.x #1663 (See [https://builds.apache.org/job/maven-3.x/1663/]) [MNG-6127] Fix plugin execution configuration interference (rfscholte: [http://git-wip-us.apache.org/repos/asf/?p=maven.git=commit=f1ed6592b1c701834d1377fade6cdb382a63bbf4]) * (edit) maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultLifecyclePluginAnalyzer.java > Fix plugin execution configuration interference > --- > > Key: MNG-6127 > URL: https://issues.apache.org/jira/browse/MNG-6127 > Project: Maven > Issue Type: Bug > Components: core >Affects Versions: 3.3.9 >Reporter: Mario Krizmanic >Assignee: Robert Scholte > Fix For: 3.5.1 > > > The plugin execution configuration may interfere across maven modules > included in a build in case a plugin extension provides a default > configuration. > Because the custom plugin configuration defined in the maven modules is > merged to the plugin execution configuration and the merged configuration is > re-used during building the other included maven modules, so the other maven > modules may be build using the invalid configuration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MNG-6220) Add CLI options to control color output
[
https://issues.apache.org/jira/browse/MNG-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127788#comment-16127788
]
Hudson commented on MNG-6220:
-
SUCCESS: Integrated in Jenkins build maven-3.x #1663 (See
[https://builds.apache.org/job/maven-3.x/1663/])
[MNG-6220] Add CLI options to control color output Introduce (rfscholte:
[http://git-wip-us.apache.org/repos/asf/?p=maven.git=commit=785bad693c60ad60d7b307af8fab9e9234ff57bd])
* (edit) maven-embedder/pom.xml
* (edit) maven-embedder/src/test/java/org/apache/maven/cli/MavenCliTest.java
* (edit) maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
> Add CLI options to control color output
> ---
>
> Key: MNG-6220
> URL: https://issues.apache.org/jira/browse/MNG-6220
> Project: Maven
> Issue Type: New Feature
>Reporter: Manuel Ryan
>Assignee: Robert Scholte
> Fix For: 3.5.1
>
>
> Currently, the only way to enable/disable color output is to use the
> batch-mode or log-file options.
> If a user wants colored output but no interactivity (ie: jenkins environment
> with the ansicolor plugin), there is no CLI option combination to support the
> use-case.
> I propose to add an option to control output coloring directly.
> {noformat}
> --color=enabled <- color output always enabled
> --color=disabled <- color output always disabled
> --color=auto <- current behavior (default)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MNG-6220) Add CLI options to control color output
[
https://issues.apache.org/jira/browse/MNG-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127786#comment-16127786
]
Robert Scholte commented on MNG-6220:
-
Fixed in
[785bad693c60ad60d7b307af8fab9e9234ff57bd|http://git-wip-us.apache.org/repos/asf/maven/commit/785bad69]
> Add CLI options to control color output
> ---
>
> Key: MNG-6220
> URL: https://issues.apache.org/jira/browse/MNG-6220
> Project: Maven
> Issue Type: New Feature
>Reporter: Manuel Ryan
>Assignee: Robert Scholte
> Fix For: 3.5.1
>
>
> Currently, the only way to enable/disable color output is to use the
> batch-mode or log-file options.
> If a user wants colored output but no interactivity (ie: jenkins environment
> with the ansicolor plugin), there is no CLI option combination to support the
> use-case.
> I propose to add an option to control output coloring directly.
> {noformat}
> --color=enabled <- color output always enabled
> --color=disabled <- color output always disabled
> --color=auto <- current behavior (default)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127342#comment-16127342
]
Hudson commented on SUREFIRE-1403:
--
FAILURE: Integrated in Jenkins build maven-surefire-dev #48 (See
[https://builds.apache.org/job/maven-surefire-dev/48/])
[SUREFIRE-1403] [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to (tibor17:
[http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=cdc7b64c3dc295c92d4bbc3a150ad0d6de31a764])
* (edit) maven-failsafe-plugin/pom.xml
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/FailsafeSummaryXmlUtils.java
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java
* (add) surefire-setup-integration-tests/src/main/resources/toolchains.xml
* (edit) surefire-integration-tests/pom.xml
* (edit)
surefire-booter/src/test/java/org/apache/maven/surefire/booter/SystemUtilsTest.java
* (add) surefire-booter/src/test/resources/jdk8-oracle/release
* (delete) maven-surefire-plugin/src/site/resources/xsd/failsafe-summary.xjb
* (edit) pom.xml
* (edit)
surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemUtils.java
* (edit)
maven-failsafe-plugin/src/test/java/org/apache/maven/plugin/failsafe/MarshallerUnmarshallerTest.java
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java
* (edit) README.md
* (add)
surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9IT.java
* (add) surefire-booter/src/test/resources/jdk8-IBM/release
* (add) surefire-booter/src/test/resources/jdk9-oracle/release
* (edit)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1265Java9IT.java
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/AbstractJigsawIT.java
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerProviderConfigurationTest.java
* (add) surefire-integration-tests/src/test/resources/java9-full-api/pom.xml
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
* (add) surefire-booter/src/test/resources/jdk/bin/java
* (add) surefire-booter/src/test/resources/jdk/jre/bin/java
* (delete)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/JAXB.java
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
* (edit) maven-surefire-plugin/src/site/site.xml
* (add)
surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9Test.java
* (edit) maven-surefire-common/pom.xml
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/ForkConfigurationTest.java
* (edit) surefire-booter/pom.xml
* (edit)
maven-failsafe-plugin/src/test/resources/org/apache/maven/plugin/failsafe/failsafe-summary.xml
* (add)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/JdkAttributes.java
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerStartupConfigurationTest.java
* (add) maven-surefire-plugin/src/site/markdown/java9.md
* (edit) surefire-setup-integration-tests/pom.xml
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java
* (edit) surefire-api/pom.xml
* (edit) maven-surefire-plugin/pom.xml
* (edit)
maven-failsafe-plugin/src/test/java/org/apache/maven/plugin/failsafe/RunResultTest.java
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: surefire-1403.zip
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SCM-777) Maven plugin's scm:validate ignores scmCheckWorkingDirectoryUrl configuration in favor of system property
[
https://issues.apache.org/jira/browse/SCM-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126979#comment-16126979
]
Andreas Schaller commented on SCM-777:
--
In ValidateMojo, the field that gets the configuration value injected is
described as unused:
{code:java}
@Parameter( property = "scmCheckWorkingDirectoryUrl", defaultValue =
"false" )
// Actually unused in the code here. Present for doc purpose,
// see
org.apache.maven.scm.provider.svn.AbstractSvnScmProvider.CHECK_WORKING_DIRECTORY_URL
private boolean scmCheckWorkingDirectoryUrl;
{code}
In the validateConnection-method however, the field is used to store the
current working directory as system property.
Wouldn't it be sufficient to also store the value of
scmCheckWorkingDirectoryUrl as system propety at this point so that it can be
used in AbstractSvnScmProvider?
Not nice but should work
> Maven plugin's scm:validate ignores scmCheckWorkingDirectoryUrl configuration
> in favor of system property
> -
>
> Key: SCM-777
> URL: https://issues.apache.org/jira/browse/SCM-777
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-plugin
>Affects Versions: 1.9.1
> Environment: Java 7 x64 on Windows 7
>Reporter: Mark Herman
>
> org.apache.maven.scm.manager.AbstractScmManager.checkWorkingDirectoryUrl()
> uses... {code} Boolean.getBoolean( CHECK_WORKING_DIRECTORY_URL ) {code}
> ...in order to check if it should check the repository on scm:validate. This
> will only react to the system property, and not to the maven configuration.
> *Result:* no maven config will enable the check working directory option,
> only passing it in as a jvm argument.
> *Expected:* this should work:
> {code}
>
> org.apache.maven.plugins
> maven-scm-plugin
>
> true
>
>
>
> validate
>
> true
>
>
>
> validate
>
>
>
>
> {code}
> *Workaround:* Use section. Tried
> and for some reason that didn't appear to work.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Closed] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana closed SUREFIRE-1403.
--
Resolution: Fixed
https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=578ada73b724151f0cbce3b6ae39e55d242ef430
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: surefire-1403.zip
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127282#comment-16127282
]
Hudson commented on SUREFIRE-1403:
--
FAILURE: Integrated in Jenkins build maven-surefire #1752 (See
[https://builds.apache.org/job/maven-surefire/1752/])
[SUREFIRE-1403] [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to (tibor17:
[http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=578ada73b724151f0cbce3b6ae39e55d242ef430])
* (add) surefire-booter/src/test/resources/jdk9-oracle/release
* (delete)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/JAXB.java
* (edit) maven-failsafe-plugin/pom.xml
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
* (add)
surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9IT.java
* (add)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/JdkAttributes.java
* (edit) surefire-booter/pom.xml
* (add) surefire-integration-tests/src/test/resources/java9-full-api/pom.xml
* (add) maven-surefire-plugin/src/site/markdown/java9.md
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java
* (add) surefire-booter/src/test/resources/jdk/jre/bin/java
* (add) surefire-booter/src/test/resources/jdk8-IBM/release
* (edit) maven-surefire-common/pom.xml
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/ForkConfigurationTest.java
* (edit) pom.xml
* (edit)
surefire-booter/src/test/java/org/apache/maven/surefire/booter/SystemUtilsTest.java
* (edit)
maven-failsafe-plugin/src/test/resources/org/apache/maven/plugin/failsafe/failsafe-summary.xml
* (add) surefire-setup-integration-tests/src/main/resources/toolchains.xml
* (edit) surefire-api/pom.xml
* (edit)
maven-failsafe-plugin/src/test/java/org/apache/maven/plugin/failsafe/RunResultTest.java
* (edit) README.md
* (edit) maven-surefire-plugin/pom.xml
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerProviderConfigurationTest.java
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerStartupConfigurationTest.java
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java
* (add)
surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9Test.java
* (add) surefire-booter/src/test/resources/jdk8-oracle/release
* (edit) surefire-setup-integration-tests/pom.xml
* (edit) surefire-integration-tests/pom.xml
* (delete) maven-surefire-plugin/src/site/resources/xsd/failsafe-summary.xjb
* (add) surefire-booter/src/test/resources/jdk/bin/java
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/AbstractJigsawIT.java
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/FailsafeSummaryXmlUtils.java
* (edit)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1265Java9IT.java
* (edit)
maven-failsafe-plugin/src/test/java/org/apache/maven/plugin/failsafe/MarshallerUnmarshallerTest.java
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java
* (edit)
surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemUtils.java
* (edit) maven-surefire-plugin/src/site/site.xml
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: surefire-1403.zip
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Issue Comment Deleted] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
[
https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1403:
---
Comment: was deleted
(was: SUCCESS: Integrated in Jenkins build maven-surefire-dev #46 (See
[https://builds.apache.org/job/maven-surefire-dev/46/])
[SUREFIRE-1403] [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to (tibor17:
[http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=622185be8b495c9f0d8ac0c9b628be4a92e1438c])
* (edit)
maven-failsafe-plugin/src/test/java/org/apache/maven/plugin/failsafe/RunResultTest.java
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerStartupConfigurationTest.java
* (edit)
surefire-booter/src/test/java/org/apache/maven/surefire/booter/SystemUtilsTest.java
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java
* (delete) maven-surefire-plugin/src/site/resources/xsd/failsafe-summary.xjb
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
* (add)
surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9Test.java
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/AbstractJigsawIT.java
* (edit) maven-surefire-plugin/src/site/site.xml
* (add) surefire-booter/src/test/resources/jdk/jre/bin/java
* (add) maven-surefire-plugin/src/site/markdown/java9.md
* (add) surefire-booter/src/test/resources/jdk9-oracle/release
* (edit) surefire-integration-tests/pom.xml
* (add) surefire-booter/src/test/resources/jdk8-oracle/release
* (edit)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1265Java9IT.java
* (edit)
surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemUtils.java
* (edit) surefire-api/pom.xml
* (add) surefire-booter/src/test/resources/jdk8-IBM/release
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/FailsafeSummaryXmlUtils.java
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java
* (delete)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/JAXB.java
* (add)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/JdkAttributes.java
* (edit) pom.xml
* (add) surefire-booter/src/test/resources/jdk/bin/java
* (edit) maven-failsafe-plugin/pom.xml
* (edit)
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java
* (edit) surefire-setup-integration-tests/pom.xml
* (edit) maven-surefire-plugin/pom.xml
* (add) surefire-integration-tests/src/test/resources/java9-full-api/pom.xml
* (edit)
maven-failsafe-plugin/src/test/java/org/apache/maven/plugin/failsafe/MarshallerUnmarshallerTest.java
* (edit) surefire-booter/pom.xml
* (add) surefire-setup-integration-tests/src/main/resources/toolchains.xml
* (edit)
maven-failsafe-plugin/src/test/resources/org/apache/maven/plugin/failsafe/failsafe-summary.xml
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerProviderConfigurationTest.java
* (edit)
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
* (edit) README.md
* (edit)
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/ForkConfigurationTest.java
* (edit) maven-surefire-common/pom.xml
* (add)
surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9IT.java
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java
)
> [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to forked CLI argument
> ---
>
> Key: SUREFIRE-1403
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: surefire-1403.zip
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not
> help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{--add-modules ALL-SYSTEM}}
> The fix would be to add "--add-modules ALL-SYSTEM" if {{--add-modules}} is
> not specified by user at Java 9+.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
