[jira] [Commented] (MJAVADOC-538) JVM "JAVA_TOOL_OPTIONS" or "_JAVA_OPTIONS" message detected as javadoc warning, triggers failure
[
https://issues.apache.org/jira/browse/MJAVADOC-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690798#comment-16690798
]
ASF GitHub Bot commented on MJAVADOC-538:
-
risdenk commented on issue #11: [MJAVADOC-538] Filter out 'Picked up'
URL:
https://github.com/apache/maven-javadoc-plugin/pull/11#issuecomment-439667626
Added integration test.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> JVM "JAVA_TOOL_OPTIONS" or "_JAVA_OPTIONS" message detected as javadoc
> warning, triggers failure
> -
>
> Key: MJAVADOC-538
> URL: https://issues.apache.org/jira/browse/MJAVADOC-538
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.0.1
> Environment: Maven 3.5.4
> Java 1.8.0_181
>Reporter: Yoann Rodière
>Priority: Major
>
> When an environment variable {{_JAVA_OPTIONS}} or {{JAVA_TOOL_OPTIONS}} is
> defined, every JVM that starts will output a message to inform users of these
> options being picked up:
> {noformat}
> $ export JAVA_TOOL_OPTIONS=-Dfoo
> $ java -version
> Picked up JAVA_TOOL_OPTIONS: -Dfoo
> java version "1.8.0_181"
> Java(TM) SE Runtime Environment (build 1.8.0_181-b13)
> Java HotSpot(TM) 64-Bit Server VM (build 25.181-b13, mixed mode){noformat}
> Apparently this message cannot be suppressed, that's on purpose an won't
> change: [https://bugs.openjdk.java.net/browse/JDK-8039152]
>
> Unfortunately, this message seems to be interpreted by the
> maven-javadoc-plugin as a warning:
> {noformat}
> [INFO] --- maven-javadoc-plugin:3.0.1:javadoc-no-fork (generate-javadoc) @
> hibernate-search-util-internal-common ---
> [INFO] The goal 'org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:javadoc'
> has not been previously called for the module:
> 'org.hibernate.search:hibernate-search-util-internal-test:jar:6.0.0-SNAPSHOT'.
> Trying to invoke it...
> [WARN] Maven will be executed in interactive mode, but no input stream has
> been configured for this MavenInvoker instance.
> Picked up JAVA_TOOL_OPTIONS: -Dfoo
> [WARNING] Creating fake javadoc directory to prevent repeated invocations:
> /home/yrodiere/workspaces/main/hibernate-search-parent/util/internal/test/target/site/apidocs
> [ERROR] Error fetching link:
> /home/yrodiere/workspaces/main/hibernate-search-parent/util/internal/test/target/site/apidocs/package-list.
> Ignored it.
> [WARNING] Javadoc Warnings
> [WARNING] Picked up JAVA_TOOL_OPTIONS: -Dfoo
> {noformat}
> (see the last line, the message appears in the list of warnings)
> No big deal... until you enable the
> [failOnWarnings|https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-no-fork-mojo.html#failOnWarnings]
> option. Then the whole build will fail just because some JVM detected an
> environment variable...
> I couldn't find any workaround, except disabling the {{failOnWarnings}}
> options, but that's more a surrender than a workaround.
> Note that the definition of {{_JAVA_OPTIONS}} or {{JAVA_TOOL_OPTIONS}} is not
> exactly an exotic use case, especially on Continuous Integration platforms.
> [Travis CI uses {{_JAVA_OPTIONS}}
> |https://docs.travis-ci.com/user/build-environment-updates/2017-09-06/#added]
> to set JVM memory limits in its containerized environments, and [the Jenkins
> CI Pipeline Maven plugin uses
> {{JAVA_TOOL_OPTIONS}}|https://wiki.jenkins.io/display/JENKINS/Pipeline+Maven+Plugin#PipelineMavenPlugin-WhydoIseemessages%22[WARNING]PickedupJAVA_TOOL_OPTIONS...%22inthebuildlogs?]
> to pass options to Maven processes transparently.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] risdenk commented on issue #11: [MJAVADOC-538] Filter out 'Picked up'
risdenk commented on issue #11: [MJAVADOC-538] Filter out 'Picked up' URL: https://github.com/apache/maven-javadoc-plugin/pull/11#issuecomment-439667626 Added integration test. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MJAVADOC-538) JVM "JAVA_TOOL_OPTIONS" or "_JAVA_OPTIONS" message detected as javadoc warning, triggers failure
[
https://issues.apache.org/jira/browse/MJAVADOC-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690791#comment-16690791
]
Kevin Risden commented on MJAVADOC-538:
---
Yup I can take a look at adding a test for this.
> JVM "JAVA_TOOL_OPTIONS" or "_JAVA_OPTIONS" message detected as javadoc
> warning, triggers failure
> -
>
> Key: MJAVADOC-538
> URL: https://issues.apache.org/jira/browse/MJAVADOC-538
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.0.1
> Environment: Maven 3.5.4
> Java 1.8.0_181
>Reporter: Yoann Rodière
>Priority: Major
>
> When an environment variable {{_JAVA_OPTIONS}} or {{JAVA_TOOL_OPTIONS}} is
> defined, every JVM that starts will output a message to inform users of these
> options being picked up:
> {noformat}
> $ export JAVA_TOOL_OPTIONS=-Dfoo
> $ java -version
> Picked up JAVA_TOOL_OPTIONS: -Dfoo
> java version "1.8.0_181"
> Java(TM) SE Runtime Environment (build 1.8.0_181-b13)
> Java HotSpot(TM) 64-Bit Server VM (build 25.181-b13, mixed mode){noformat}
> Apparently this message cannot be suppressed, that's on purpose an won't
> change: [https://bugs.openjdk.java.net/browse/JDK-8039152]
>
> Unfortunately, this message seems to be interpreted by the
> maven-javadoc-plugin as a warning:
> {noformat}
> [INFO] --- maven-javadoc-plugin:3.0.1:javadoc-no-fork (generate-javadoc) @
> hibernate-search-util-internal-common ---
> [INFO] The goal 'org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:javadoc'
> has not been previously called for the module:
> 'org.hibernate.search:hibernate-search-util-internal-test:jar:6.0.0-SNAPSHOT'.
> Trying to invoke it...
> [WARN] Maven will be executed in interactive mode, but no input stream has
> been configured for this MavenInvoker instance.
> Picked up JAVA_TOOL_OPTIONS: -Dfoo
> [WARNING] Creating fake javadoc directory to prevent repeated invocations:
> /home/yrodiere/workspaces/main/hibernate-search-parent/util/internal/test/target/site/apidocs
> [ERROR] Error fetching link:
> /home/yrodiere/workspaces/main/hibernate-search-parent/util/internal/test/target/site/apidocs/package-list.
> Ignored it.
> [WARNING] Javadoc Warnings
> [WARNING] Picked up JAVA_TOOL_OPTIONS: -Dfoo
> {noformat}
> (see the last line, the message appears in the list of warnings)
> No big deal... until you enable the
> [failOnWarnings|https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-no-fork-mojo.html#failOnWarnings]
> option. Then the whole build will fail just because some JVM detected an
> environment variable...
> I couldn't find any workaround, except disabling the {{failOnWarnings}}
> options, but that's more a surrender than a workaround.
> Note that the definition of {{_JAVA_OPTIONS}} or {{JAVA_TOOL_OPTIONS}} is not
> exactly an exotic use case, especially on Continuous Integration platforms.
> [Travis CI uses {{_JAVA_OPTIONS}}
> |https://docs.travis-ci.com/user/build-environment-updates/2017-09-06/#added]
> to set JVM memory limits in its containerized environments, and [the Jenkins
> CI Pipeline Maven plugin uses
> {{JAVA_TOOL_OPTIONS}}|https://wiki.jenkins.io/display/JENKINS/Pipeline+Maven+Plugin#PipelineMavenPlugin-WhydoIseemessages%22[WARNING]PickedupJAVA_TOOL_OPTIONS...%22inthebuildlogs?]
> to pass options to Maven processes transparently.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MJAR-260) Warn about invalid 'Automatic-Module-Name' in MANIFEST
[ https://issues.apache.org/jira/browse/MJAR-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690442#comment-16690442 ] Christian Stein commented on MJAR-260: -- New PR at https://github.com/apache/maven-archiver/pull/1 > Warn about invalid 'Automatic-Module-Name' in MANIFEST > -- > > Key: MJAR-260 > URL: https://issues.apache.org/jira/browse/MJAR-260 > Project: Maven JAR Plugin > Issue Type: Improvement >Reporter: Christian Stein >Assignee: Christian Stein >Priority: Minor > > The Maven JAR Plugin should warn or even fail when an invalid name is > detected within the `META-INF/MANIFEST.MF` file. > For details see > https://sormuras.github.io/blog/2018-11-16-invalid-automatic-module-names -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNGSITE-328) How to get rid of .md5's in www.a.o/dist/ ?
[ https://issues.apache.org/jira/browse/MNGSITE-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690446#comment-16690446 ] Hudson commented on MNGSITE-328: Build succeeded in Jenkins: Maven TLP » maven-archiver » MSHARED-726 #16 See https://builds.apache.org/job/maven-box/job/maven-archiver/job/MSHARED-726/16/ > How to get rid of .md5's in www.a.o/dist/ ? > --- > > Key: MNGSITE-328 > URL: https://issues.apache.org/jira/browse/MNGSITE-328 > Project: Maven Project Web Site > Issue Type: Wish >Reporter: Henk Penning >Assignee: Hervé Boutemy >Priority: Major > > ASF policy (strongly) recommends not to publish .md5's in > [www.apache.org/dist/,|http://www.a.o/dist/,] > that is : [https://dist.apache.org/repos/dist/release/] > -- How can maven users achieve this ? > -- Is it possible (and sensible) to add something to maven, to make it easy > (or easier) ? > I must confess I don't know the first thing about maven etc ; hope my > question makes sense. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSHARED-747) Upgrade maven-plugins parent to version 32
[ https://issues.apache.org/jira/browse/MSHARED-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690448#comment-16690448 ] Hudson commented on MSHARED-747: Build succeeded in Jenkins: Maven TLP » maven-archiver » MSHARED-726 #16 See https://builds.apache.org/job/maven-box/job/maven-archiver/job/MSHARED-726/16/ > Upgrade maven-plugins parent to version 32 > -- > > Key: MSHARED-747 > URL: https://issues.apache.org/jira/browse/MSHARED-747 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.2.1 >Reporter: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-archiver-3.2.1 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNGSITE-341) Download pages must use HTTPS for sigs, hashes, KEYS
[ https://issues.apache.org/jira/browse/MNGSITE-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690449#comment-16690449 ] Hudson commented on MNGSITE-341: Build succeeded in Jenkins: Maven TLP » maven-archiver » MSHARED-726 #16 See https://builds.apache.org/job/maven-box/job/maven-archiver/job/MSHARED-726/16/ > Download pages must use HTTPS for sigs, hashes, KEYS > > > Key: MNGSITE-341 > URL: https://issues.apache.org/jira/browse/MNGSITE-341 > Project: Maven Project Web Site > Issue Type: Bug >Reporter: Sebb >Assignee: Hervé Boutemy >Priority: Major > > The download page is generally fine. > However the links to the KEYS, sigs (PGP) and hashes use http; they should > use https. > http://www.apache.org/dev/release-publishing.html#distribution_dist -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSHARED-726) Upgrade plexus-archiver to 3.6.0
[ https://issues.apache.org/jira/browse/MSHARED-726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690451#comment-16690451 ] Hudson commented on MSHARED-726: Build succeeded in Jenkins: Maven TLP » maven-archiver » MSHARED-726 #16 See https://builds.apache.org/job/maven-box/job/maven-archiver/job/MSHARED-726/16/ > Upgrade plexus-archiver to 3.6.0 > > > Key: MSHARED-726 > URL: https://issues.apache.org/jira/browse/MSHARED-726 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.2.1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Critical > Fix For: maven-archiver-3.2.1 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSHARED-727) Upgrade mave-surefire/failsafe-plugin 2.21.0
[ https://issues.apache.org/jira/browse/MSHARED-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690447#comment-16690447 ] Hudson commented on MSHARED-727: Build succeeded in Jenkins: Maven TLP » maven-archiver » MSHARED-726 #16 See https://builds.apache.org/job/maven-box/job/maven-archiver/job/MSHARED-726/16/ > Upgrade mave-surefire/failsafe-plugin 2.21.0 > > > Key: MSHARED-727 > URL: https://issues.apache.org/jira/browse/MSHARED-727 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.2.1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Blocker > Fix For: maven-archiver-3.2.1 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MPOM-205) create SHA-512 checksum for source-release archive(s) in target/checkout/target/ during release
[ https://issues.apache.org/jira/browse/MPOM-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690450#comment-16690450 ] Hudson commented on MPOM-205: - Build succeeded in Jenkins: Maven TLP » maven-archiver » MSHARED-726 #16 See https://builds.apache.org/job/maven-box/job/maven-archiver/job/MSHARED-726/16/ > create SHA-512 checksum for source-release archive(s) in > target/checkout/target/ during release > --- > > Key: MPOM-205 > URL: https://issues.apache.org/jira/browse/MPOM-205 > Project: Maven POMs > Issue Type: New Feature > Components: asf >Affects Versions: ASF-20 >Reporter: Hervé Boutemy >Assignee: Hervé Boutemy >Priority: Major > Fix For: ASF-21 > > > currently, during Apache release, checksums are not created in target/ > directory: checksums are created on the fly during deploy to the Maven > repository (for absolutely every artifact, be it "normal" artifacts or source > release) > while source release archive and its signature are available in target/ (or > target/checkout/target during release with Maven Release Plugin), checksums > are not there: this gives people the bad habit to download everything (not > only checksums) from Apache Nexus repository after deploy to copy to Apache > /dist/ > it would be useful to have the checksums for source release available in > target/ (then in target/checkout/target during release) > this would also prepare having new Apache checksums requirements for Apache > mirroring: http://www.apache.org/dev/release-distribution#sigs-and-sums > sha256 and sha512 are not used for Maven repositories, but they are required > for Apache source release distribution > Notice: .sha256 and .sha512 files are not only not supported for Maven > repositories, but even not supported: they are considered as artifacts, not > checksums, then require md5 and sha1 checksum files and .asc detached > signature... > Then the .sha512 file is not to be deployed to the Maven repository, only > Apache /dist/ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MJAVADOC-538) JVM "JAVA_TOOL_OPTIONS" or "_JAVA_OPTIONS" message detected as javadoc warning, triggers failure
[
https://issues.apache.org/jira/browse/MJAVADOC-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690477#comment-16690477
]
Robert Scholte commented on MJAVADOC-538:
-
Nice, would love to see a small integration test as well to ensure we won't get
any regression in the future. Can you add that too?
> JVM "JAVA_TOOL_OPTIONS" or "_JAVA_OPTIONS" message detected as javadoc
> warning, triggers failure
> -
>
> Key: MJAVADOC-538
> URL: https://issues.apache.org/jira/browse/MJAVADOC-538
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.0.1
> Environment: Maven 3.5.4
> Java 1.8.0_181
>Reporter: Yoann Rodière
>Priority: Major
>
> When an environment variable {{_JAVA_OPTIONS}} or {{JAVA_TOOL_OPTIONS}} is
> defined, every JVM that starts will output a message to inform users of these
> options being picked up:
> {noformat}
> $ export JAVA_TOOL_OPTIONS=-Dfoo
> $ java -version
> Picked up JAVA_TOOL_OPTIONS: -Dfoo
> java version "1.8.0_181"
> Java(TM) SE Runtime Environment (build 1.8.0_181-b13)
> Java HotSpot(TM) 64-Bit Server VM (build 25.181-b13, mixed mode){noformat}
> Apparently this message cannot be suppressed, that's on purpose an won't
> change: [https://bugs.openjdk.java.net/browse/JDK-8039152]
>
> Unfortunately, this message seems to be interpreted by the
> maven-javadoc-plugin as a warning:
> {noformat}
> [INFO] --- maven-javadoc-plugin:3.0.1:javadoc-no-fork (generate-javadoc) @
> hibernate-search-util-internal-common ---
> [INFO] The goal 'org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:javadoc'
> has not been previously called for the module:
> 'org.hibernate.search:hibernate-search-util-internal-test:jar:6.0.0-SNAPSHOT'.
> Trying to invoke it...
> [WARN] Maven will be executed in interactive mode, but no input stream has
> been configured for this MavenInvoker instance.
> Picked up JAVA_TOOL_OPTIONS: -Dfoo
> [WARNING] Creating fake javadoc directory to prevent repeated invocations:
> /home/yrodiere/workspaces/main/hibernate-search-parent/util/internal/test/target/site/apidocs
> [ERROR] Error fetching link:
> /home/yrodiere/workspaces/main/hibernate-search-parent/util/internal/test/target/site/apidocs/package-list.
> Ignored it.
> [WARNING] Javadoc Warnings
> [WARNING] Picked up JAVA_TOOL_OPTIONS: -Dfoo
> {noformat}
> (see the last line, the message appears in the list of warnings)
> No big deal... until you enable the
> [failOnWarnings|https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-no-fork-mojo.html#failOnWarnings]
> option. Then the whole build will fail just because some JVM detected an
> environment variable...
> I couldn't find any workaround, except disabling the {{failOnWarnings}}
> options, but that's more a surrender than a workaround.
> Note that the definition of {{_JAVA_OPTIONS}} or {{JAVA_TOOL_OPTIONS}} is not
> exactly an exotic use case, especially on Continuous Integration platforms.
> [Travis CI uses {{_JAVA_OPTIONS}}
> |https://docs.travis-ci.com/user/build-environment-updates/2017-09-06/#added]
> to set JVM memory limits in its containerized environments, and [the Jenkins
> CI Pipeline Maven plugin uses
> {{JAVA_TOOL_OPTIONS}}|https://wiki.jenkins.io/display/JENKINS/Pipeline+Maven+Plugin#PipelineMavenPlugin-WhydoIseemessages%22[WARNING]PickedupJAVA_TOOL_OPTIONS...%22inthebuildlogs?]
> to pass options to Maven processes transparently.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] Tibor17 commented on issue #189: [SUREFIRE-1531] Option to disable Java 9 modules
Tibor17 commented on issue #189: [SUREFIRE-1531] Option to disable Java 9 modules URL: https://github.com/apache/maven-surefire/pull/189#issuecomment-439598184 @lukas-krecan I had to slightly modify your code but kept you as an author and created a branch: https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=shortlog;h=refs/heads/SUREFIRE-1531 You can review it. I want to push it and close Jira. Then pls close this PR if you have no objections. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SUREFIRE-1531) Option to switch-off Java 9 modules
[
https://issues.apache.org/jira/browse/SUREFIRE-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690435#comment-16690435
]
ASF GitHub Bot commented on SUREFIRE-1531:
--
Tibor17 commented on issue #189: [SUREFIRE-1531] Option to disable Java 9
modules
URL: https://github.com/apache/maven-surefire/pull/189#issuecomment-439598184
@lukas-krecan
I had to slightly modify your code but kept you as an author and created a
branch:
https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=shortlog;h=refs/heads/SUREFIRE-1531
You can review it. I want to push it and close Jira. Then pls close this PR
if you have no objections.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Option to switch-off Java 9 modules
> ---
>
> Key: SUREFIRE-1531
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1531
> Project: Maven Surefire
> Issue Type: Improvement
> Components: Maven Surefire Plugin
>Affects Versions: 2.22.0
>Reporter: Lukáš Křečan
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M2
>
>
> I am working on a library and I am adding support for Java 9 modules.
> Surefire 2.21.0 by default executes tests with Java 9 modules switched-on if
> it detects module-info.java While it may make sense in some cases, in my case
> I'd like the switch it off.
> The reason is simple. I am using Mockito to mock an interface that extends a
> Spring interface. Mockito has to create an implementation of this interface
> (proxy or subclass) and for this it needs to have access to the Spring
> interfaces. If Java 9 modules are enabled for the tests I have to manually
> add each such dependencies to Surefire configuration, which does not make
> much sense. To makes things worse, the interface actually extends two Spring
> interfaces form two different Spring modules so the configuration is almost
> impossible to get right.
> So far I am at ( and I am still getting IllegalAccessErrors)
> {code:java}
> --add-exports spring.context/org.springframework.scheduling=org.mockito
> --add-exports spring.beans/org.springframework.beans.factory=org.mockito
> {code}
> I would prefer to switch-off the Java 9 modules for the test module
> altogether (same behavior as pre 2.21.0)
>
> The test is here
> [https://github.com/lukas-krecan/ShedLock/blob/java9/shedlock-spring/src/test/java/net/javacrumbs/shedlock/spring/CleanupTest.java]
>
> If you want, I can send a pull request.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (MSHARED-721) Upgrade maven-shared-utils to 3.2.1
[ https://issues.apache.org/jira/browse/MSHARED-721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MSHARED-721. --- Resolution: Done > Upgrade maven-shared-utils to 3.2.1 > --- > > Key: MSHARED-721 > URL: https://issues.apache.org/jira/browse/MSHARED-721 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.2.1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-archiver-3.2.1 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MSHARED-774) Upgrade maven-plugins parent to version 33
[ https://issues.apache.org/jira/browse/MSHARED-774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MSHARED-774. --- Resolution: Done > Upgrade maven-plugins parent to version 33 > -- > > Key: MSHARED-774 > URL: https://issues.apache.org/jira/browse/MSHARED-774 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.2.1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-archiver-3.2.1 > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1593) 3.0.0-M1 produces invalid code sources on Windows
[
https://issues.apache.org/jira/browse/SUREFIRE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690519#comment-16690519
]
ASF GitHub Bot commented on SUREFIRE-1593:
--
rfscholte closed pull request #198: [SUREFIRE-1593] Correcting relativization
logic to produce valid URIs on Windows
URL: https://github.com/apache/maven-surefire/pull/198
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
b/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
index 70f95d953..25f55066e 100644
---
a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
+++
b/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
@@ -33,7 +33,7 @@
import java.io.IOException;
import java.net.URI;
import java.net.URISyntaxException;
-import java.nio.file.Path;
+import java.nio.file.Paths;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
@@ -101,7 +101,7 @@ private File createJar( @Nonnull List classPath,
@Nonnull String startCl
{
file.deleteOnExit();
}
-Path parent = file.getParentFile().toPath();
+String parent = file.getParent();
FileOutputStream fos = new FileOutputStream( file );
try ( JarOutputStream jos = new JarOutputStream( fos ) )
{
@@ -116,10 +116,10 @@ private File createJar( @Nonnull List classPath,
@Nonnull String startCl
StringBuilder cp = new StringBuilder();
for ( Iterator it = classPath.iterator(); it.hasNext(); )
{
-File classPathElement = new File( it.next() );
+String classPathElement = it.next();
String uri = toClasspathElementUri( parent, classPathElement,
dumpLogDirectory );
cp.append( uri );
-if ( classPathElement.isDirectory() && !uri.endsWith( "/" ) )
+if ( new File( classPathElement ).isDirectory() &&
!uri.endsWith( "/" ) )
{
cp.append( '/' );
}
@@ -143,24 +143,34 @@ private File createJar( @Nonnull List classPath,
@Nonnull String startCl
}
}
-private static String toClasspathElementUri( @Nonnull Path parent,
- @Nonnull File
classPathElement,
- @Nonnull File
dumpLogDirectory )
+static String relativize( @Nonnull String parent, @Nonnull String child )
+throws IllegalArgumentException
+{
+return Paths.get( parent ).relativize( Paths.get( child ) ).toString();
+}
+
+static String absoluteUri( @Nonnull String file )
+{
+return Paths.get( file ).toUri().toASCIIString();
+}
+
+static String toClasspathElementUri( @Nonnull String parent,
+ @Nonnull String classPathElement,
+ @Nonnull File dumpLogDirectory )
throws IOException
{
try
{
-return new URI( null, parent.relativize( classPathElement.toPath()
).toString(), null )
-.toASCIIString();
+String uriPath = relativize( parent, classPathElement ).replace(
'\\', '/' );
+return new URI( null, uriPath, null ).toASCIIString();
}
catch ( IllegalArgumentException e )
{
-String error = "Boot Manifest-JAR contains absolute paths in
classpath " + classPathElement.getPath();
+String error = "Boot Manifest-JAR contains absolute paths in
classpath " + classPathElement;
InPluginProcessDumpSingleton.getSingleton()
.dumpException( e, error, dumpLogDirectory );
-return classPathElement.toURI()
-.toASCIIString();
+return absoluteUri( classPathElement );
}
catch ( URISyntaxException e )
{
diff --git
a/maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfigurationTest.java
b/maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfigurationTest.java
new file mode 100644
index 0..7e25e7fee
--- /dev/null
+++
b/maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfigurationTest.java
@@ -0,0 +1,119 @@
+package
[jira] [Commented] (MSHARED-774) Upgrade maven-plugins parent to version 33
[ https://issues.apache.org/jira/browse/MSHARED-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690518#comment-16690518 ] Karl Heinz Marbaise commented on MSHARED-774: - Done in [4491b7f607768e5d45d8bf8f69f730624277d30f|https://gitbox.apache.org/repos/asf?p=maven-archiver.git;a=commitdiff;h=4491b7f607768e5d45d8bf8f69f730624277d30f] > Upgrade maven-plugins parent to version 33 > -- > > Key: MSHARED-774 > URL: https://issues.apache.org/jira/browse/MSHARED-774 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.2.1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-archiver-3.2.1 > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MSHARED-775) Upgrade plexus-interpolation to 1.25
Karl Heinz Marbaise created MSHARED-775: --- Summary: Upgrade plexus-interpolation to 1.25 Key: MSHARED-775 URL: https://issues.apache.org/jira/browse/MSHARED-775 Project: Maven Shared Components Issue Type: Dependency upgrade Components: maven-archiver Affects Versions: maven-archiver-3.2.1 Reporter: Karl Heinz Marbaise Fix For: maven-archiver-3.2.1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MSHARED-775) Upgrade plexus-interpolation to 1.25
[ https://issues.apache.org/jira/browse/MSHARED-775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise reassigned MSHARED-775: --- Assignee: Karl Heinz Marbaise > Upgrade plexus-interpolation to 1.25 > > > Key: MSHARED-775 > URL: https://issues.apache.org/jira/browse/MSHARED-775 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.2.1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-archiver-3.2.1 > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSHARED-776) Upgrade maven-shared-components to 33
[ https://issues.apache.org/jira/browse/MSHARED-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690531#comment-16690531 ] Hudson commented on MSHARED-776: Build succeeded in Jenkins: Maven TLP » maven-dependency-analyzer » master #51 See https://builds.apache.org/job/maven-box/job/maven-dependency-analyzer/job/master/51/ > Upgrade maven-shared-components to 33 > - > > Key: MSHARED-776 > URL: https://issues.apache.org/jira/browse/MSHARED-776 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-dependency-analyzer >Affects Versions: maven-dependency-analyzer-1.11.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-dependency-analyzer-1.11.0 > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (MSHARED-773) Fail on invalid 'Automatic-Module-Name' in MANIFEST
[ https://issues.apache.org/jira/browse/MSHARED-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Stein resolved MSHARED-773. - Resolution: Fixed > Fail on invalid 'Automatic-Module-Name' in MANIFEST > --- > > Key: MSHARED-773 > URL: https://issues.apache.org/jira/browse/MSHARED-773 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-archiver >Reporter: Christian Stein >Assignee: Christian Stein >Priority: Minor > > The Maven Archiver should fail when an invalid name is detected within the > `META-INF/MANIFEST.MF` file. > For details see > [https://sormuras.github.io/blog/2018-11-16-invalid-automatic-module-names] > This issue blocks https://issues.apache.org/jira/browse/MJAR-260 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSHARED-773) Fail on invalid 'Automatic-Module-Name' in MANIFEST
[ https://issues.apache.org/jira/browse/MSHARED-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690538#comment-16690538 ] Christian Stein commented on MSHARED-773: - Done via https://github.com/apache/maven-archiver/commit/347d7d3334417598c7bc8584729cda0c7e1c > Fail on invalid 'Automatic-Module-Name' in MANIFEST > --- > > Key: MSHARED-773 > URL: https://issues.apache.org/jira/browse/MSHARED-773 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-archiver >Reporter: Christian Stein >Assignee: Christian Stein >Priority: Minor > > The Maven Archiver should fail when an invalid name is detected within the > `META-INF/MANIFEST.MF` file. > For details see > [https://sormuras.github.io/blog/2018-11-16-invalid-automatic-module-names] > This issue blocks https://issues.apache.org/jira/browse/MJAR-260 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSHARED-773) Fail on invalid 'Automatic-Module-Name' in MANIFEST
[ https://issues.apache.org/jira/browse/MSHARED-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690536#comment-16690536 ] Hudson commented on MSHARED-773: Build succeeded in Jenkins: Maven TLP » maven-archiver » master #35 See https://builds.apache.org/job/maven-box/job/maven-archiver/job/master/35/ > Fail on invalid 'Automatic-Module-Name' in MANIFEST > --- > > Key: MSHARED-773 > URL: https://issues.apache.org/jira/browse/MSHARED-773 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-archiver >Reporter: Christian Stein >Assignee: Christian Stein >Priority: Minor > > The Maven Archiver should fail when an invalid name is detected within the > `META-INF/MANIFEST.MF` file. > For details see > [https://sormuras.github.io/blog/2018-11-16-invalid-automatic-module-names] > This issue blocks https://issues.apache.org/jira/browse/MJAR-260 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (MSHARED-773) Fail on invalid 'Automatic-Module-Name' in MANIFEST
[ https://issues.apache.org/jira/browse/MSHARED-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690538#comment-16690538 ] Karl Heinz Marbaise edited comment on MSHARED-773 at 11/17/18 1:07 PM: --- Done via [347d7d3334417598c7bc8584729cda0c7e1c|https://gitbox.apache.org/repos/asf?p=maven-archiver.git;a=commitdiff;h=347d7d3334417598c7bc8584729cda0c7e1c] was (Author: sor): Done via https://github.com/apache/maven-archiver/commit/347d7d3334417598c7bc8584729cda0c7e1c > Fail on invalid 'Automatic-Module-Name' in MANIFEST > --- > > Key: MSHARED-773 > URL: https://issues.apache.org/jira/browse/MSHARED-773 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-archiver >Reporter: Christian Stein >Assignee: Christian Stein >Priority: Minor > Fix For: maven-archiver-3.2.1 > > > The Maven Archiver should fail when an invalid name is detected within the > `META-INF/MANIFEST.MF` file. > For details see > [https://sormuras.github.io/blog/2018-11-16-invalid-automatic-module-names] > This issue blocks https://issues.apache.org/jira/browse/MJAR-260 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] fabcipriano opened a new pull request #192: [MNG-6261] - using java File api to compare
fabcipriano opened a new pull request #192: [MNG-6261] - using java File api to compare URL: https://github.com/apache/maven/pull/192 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-6261) Relative parent POM resolution failing in 3.5.0 with complex multimodule builds
[
https://issues.apache.org/jira/browse/MNG-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690568#comment-16690568
]
ASF GitHub Bot commented on MNG-6261:
-
fabcipriano opened a new pull request #192: [MNG-6261] - using java File api to
compare
URL: https://github.com/apache/maven/pull/192
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Relative parent POM resolution failing in 3.5.0 with complex multimodule
> builds
> ---
>
> Key: MNG-6261
> URL: https://issues.apache.org/jira/browse/MNG-6261
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Dawid Weiss
>Priority: Minor
> Labels: up-for-grabs
> Fix For: 3.6.x-candidate
>
> Attachments: capture-6.png, repro.zip
>
>
> In my effort to upgrade an existing (fairly complex) Maven build to Java
> 1.9.0 I updated Maven to 3.5.0 (from 3.3.9). Unfortunately I get errors when
> the project's modules are resolved:
> {noformat}
> > mvn validate
> [FATAL] Non-resolvable parent POM for
> com.carrotsearch.lingo4g:lingo4g-public-bom:[unknown-version]: Could not find
> artifact com.carrotsearch.lingo4g:lingo4g-public:pom:1.6.0-SNAPSHOT and
> 'parent.relativePath' points at wrong local POM @ line 5, column 11
> ...
> (and many follow).
> {noformat}
> This build has a correct pom parent-structure (a tree), but is fairly complex
> -- the submodule hierarchy is not aligned with parent-child pom hierarchy
> (it's best to look at the repro code to understand how it's structured).
> However, it's been working correctly with all prior Maven versions and I
> wonder if it's a regression bug or maybe underspecified Maven requirement
> (that should be enforced with a warning and not lead to this odd runtime
> message).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6261) Relative parent POM resolution failing in 3.5.0 with complex multimodule builds
[
https://issues.apache.org/jira/browse/MNG-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690579#comment-16690579
]
ASF GitHub Bot commented on MNG-6261:
-
rfscholte commented on a change in pull request #192: [MNG-6261] - using java
File api to compare
URL: https://github.com/apache/maven/pull/192#discussion_r234410239
##
File path:
maven-model-builder/src/test/java/org/apache/maven/model/building/FileModelSourceTest.java
##
@@ -0,0 +1,52 @@
+package org.apache.maven.model.building;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+import junit.framework.TestCase;
+
+/**
+ *
+ * @author fabiano
+ */
+public class FileModelSourceTest
+extends TestCase
+{
+
+public FileModelSourceTest() {
+}
+
+/**
+ * Test of equals method, of class FileModelSource.
+ */
+public void testEquals()
+throws Exception
+{
+File tempFile = File.createTempFile("pomTest-", ".xml");
+tempFile.deleteOnExit();
+FileModelSource instance = new FileModelSource( tempFile );
+
+assertFalse( instance.equals( null ) );
+assertFalse( instance.equals( new Object() ) );
+assertTrue( instance.equals( instance ) );
+assertTrue( instance.equals( new FileModelSource( tempFile ) ) );
+}
+
Review comment:
There's no test here that reflects MNG-6261, that is comparing files with a
lowercase and uppercase (which should be the same on Windows).
You can use Junit4 Annotations here if you like, makes it easier to do
assumptions.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Relative parent POM resolution failing in 3.5.0 with complex multimodule
> builds
> ---
>
> Key: MNG-6261
> URL: https://issues.apache.org/jira/browse/MNG-6261
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Dawid Weiss
>Priority: Minor
> Labels: up-for-grabs
> Fix For: 3.6.x-candidate
>
> Attachments: capture-6.png, repro.zip
>
>
> In my effort to upgrade an existing (fairly complex) Maven build to Java
> 1.9.0 I updated Maven to 3.5.0 (from 3.3.9). Unfortunately I get errors when
> the project's modules are resolved:
> {noformat}
> > mvn validate
> [FATAL] Non-resolvable parent POM for
> com.carrotsearch.lingo4g:lingo4g-public-bom:[unknown-version]: Could not find
> artifact com.carrotsearch.lingo4g:lingo4g-public:pom:1.6.0-SNAPSHOT and
> 'parent.relativePath' points at wrong local POM @ line 5, column 11
> ...
> (and many follow).
> {noformat}
> This build has a correct pom parent-structure (a tree), but is fairly complex
> -- the submodule hierarchy is not aligned with parent-child pom hierarchy
> (it's best to look at the repro code to understand how it's structured).
> However, it's been working correctly with all prior Maven versions and I
> wonder if it's a regression bug or maybe underspecified Maven requirement
> (that should be enforced with a warning and not lead to this odd runtime
> message).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] rfscholte commented on a change in pull request #192: [MNG-6261] - using java File api to compare
rfscholte commented on a change in pull request #192: [MNG-6261] - using java
File api to compare
URL: https://github.com/apache/maven/pull/192#discussion_r234410239
##
File path:
maven-model-builder/src/test/java/org/apache/maven/model/building/FileModelSourceTest.java
##
@@ -0,0 +1,52 @@
+package org.apache.maven.model.building;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+import junit.framework.TestCase;
+
+/**
+ *
+ * @author fabiano
+ */
+public class FileModelSourceTest
+extends TestCase
+{
+
+public FileModelSourceTest() {
+}
+
+/**
+ * Test of equals method, of class FileModelSource.
+ */
+public void testEquals()
+throws Exception
+{
+File tempFile = File.createTempFile("pomTest-", ".xml");
+tempFile.deleteOnExit();
+FileModelSource instance = new FileModelSource( tempFile );
+
+assertFalse( instance.equals( null ) );
+assertFalse( instance.equals( new Object() ) );
+assertTrue( instance.equals( instance ) );
+assertTrue( instance.equals( new FileModelSource( tempFile ) ) );
+}
+
Review comment:
There's no test here that reflects MNG-6261, that is comparing files with a
lowercase and uppercase (which should be the same on Windows).
You can use Junit4 Annotations here if you like, makes it easier to do
assumptions.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (MNG-6261) Relative parent POM resolution failing in 3.5.0 with complex multimodule builds
[
https://issues.apache.org/jira/browse/MNG-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690578#comment-16690578
]
ASF GitHub Bot commented on MNG-6261:
-
rfscholte commented on a change in pull request #192: [MNG-6261] - using java
File api to compare
URL: https://github.com/apache/maven/pull/192#discussion_r234410160
##
File path:
maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
##
@@ -852,10 +852,11 @@ private ModelData readParent( Model childModel,
ModelSource childSource, ModelBu
File pomFile = parentData.getModel().getPomFile();
if ( pomFile != null )
{
+FileModelSource pomFileModel = new FileModelSource(
pomFile );
ModelSource expectedParentSource = getParentPomFile(
childModel, childSource );
if ( expectedParentSource == null || (
expectedParentSource instanceof ModelSource2
-&& !pomFile.toURI().equals( ( (ModelSource2)
expectedParentSource ).getLocationURI() ) ) )
+&& !pomFileModel.equals( expectedParentSource ) ) )
Review comment:
At first the comparison looked weird, i.e. comparing a Model with a Source.
The comparison is good, just need to improve the name of the variables.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Relative parent POM resolution failing in 3.5.0 with complex multimodule
> builds
> ---
>
> Key: MNG-6261
> URL: https://issues.apache.org/jira/browse/MNG-6261
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Dawid Weiss
>Priority: Minor
> Labels: up-for-grabs
> Fix For: 3.6.x-candidate
>
> Attachments: capture-6.png, repro.zip
>
>
> In my effort to upgrade an existing (fairly complex) Maven build to Java
> 1.9.0 I updated Maven to 3.5.0 (from 3.3.9). Unfortunately I get errors when
> the project's modules are resolved:
> {noformat}
> > mvn validate
> [FATAL] Non-resolvable parent POM for
> com.carrotsearch.lingo4g:lingo4g-public-bom:[unknown-version]: Could not find
> artifact com.carrotsearch.lingo4g:lingo4g-public:pom:1.6.0-SNAPSHOT and
> 'parent.relativePath' points at wrong local POM @ line 5, column 11
> ...
> (and many follow).
> {noformat}
> This build has a correct pom parent-structure (a tree), but is fairly complex
> -- the submodule hierarchy is not aligned with parent-child pom hierarchy
> (it's best to look at the repro code to understand how it's structured).
> However, it's been working correctly with all prior Maven versions and I
> wonder if it's a regression bug or maybe underspecified Maven requirement
> (that should be enforced with a warning and not lead to this odd runtime
> message).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] rfscholte commented on a change in pull request #192: [MNG-6261] - using java File api to compare
rfscholte commented on a change in pull request #192: [MNG-6261] - using java
File api to compare
URL: https://github.com/apache/maven/pull/192#discussion_r234410160
##
File path:
maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
##
@@ -852,10 +852,11 @@ private ModelData readParent( Model childModel,
ModelSource childSource, ModelBu
File pomFile = parentData.getModel().getPomFile();
if ( pomFile != null )
{
+FileModelSource pomFileModel = new FileModelSource(
pomFile );
ModelSource expectedParentSource = getParentPomFile(
childModel, childSource );
if ( expectedParentSource == null || (
expectedParentSource instanceof ModelSource2
-&& !pomFile.toURI().equals( ( (ModelSource2)
expectedParentSource ).getLocationURI() ) ) )
+&& !pomFileModel.equals( expectedParentSource ) ) )
Review comment:
At first the comparison looked weird, i.e. comparing a Model with a Source.
The comparison is good, just need to improve the name of the variables.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (MSHARED-726) Upgrade plexus-archiver to 3.6.0
[ https://issues.apache.org/jira/browse/MSHARED-726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690514#comment-16690514 ] Hudson commented on MSHARED-726: Build succeeded in Jenkins: Maven TLP » maven-archiver » master #32 See https://builds.apache.org/job/maven-box/job/maven-archiver/job/master/32/ > Upgrade plexus-archiver to 3.6.0 > > > Key: MSHARED-726 > URL: https://issues.apache.org/jira/browse/MSHARED-726 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.2.1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Critical > Fix For: maven-archiver-3.2.1 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MSHARED-726) Upgrade plexus-archiver to 3.6.0
[ https://issues.apache.org/jira/browse/MSHARED-726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MSHARED-726. --- Resolution: Done > Upgrade plexus-archiver to 3.6.0 > > > Key: MSHARED-726 > URL: https://issues.apache.org/jira/browse/MSHARED-726 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.2.1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Critical > Fix For: maven-archiver-3.2.1 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSHARED-726) Upgrade plexus-archiver to 3.6.0
[ https://issues.apache.org/jira/browse/MSHARED-726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690513#comment-16690513 ] Karl Heinz Marbaise commented on MSHARED-726: - Done in [b438bdd762c085c7ce8ec72adb40c9768ab591f9|https://gitbox.apache.org/repos/asf?p=maven-archiver.git;a=commitdiff;h=b438bdd762c085c7ce8ec72adb40c9768ab591f9] > Upgrade plexus-archiver to 3.6.0 > > > Key: MSHARED-726 > URL: https://issues.apache.org/jira/browse/MSHARED-726 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.2.1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Critical > Fix For: maven-archiver-3.2.1 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSHARED-774) Upgrade maven-plugins parent to version 33
[ https://issues.apache.org/jira/browse/MSHARED-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690521#comment-16690521 ] Hudson commented on MSHARED-774: Build succeeded in Jenkins: Maven TLP » maven-archiver » master #33 See https://builds.apache.org/job/maven-box/job/maven-archiver/job/master/33/ > Upgrade maven-plugins parent to version 33 > -- > > Key: MSHARED-774 > URL: https://issues.apache.org/jira/browse/MSHARED-774 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.2.1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-archiver-3.2.1 > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MSHARED-776) Upgrade maven-shared-components to 33
Karl Heinz Marbaise created MSHARED-776: --- Summary: Upgrade maven-shared-components to 33 Key: MSHARED-776 URL: https://issues.apache.org/jira/browse/MSHARED-776 Project: Maven Shared Components Issue Type: Dependency upgrade Components: maven-dependency-analyzer Affects Versions: maven-dependency-analyzer-1.11.0 Reporter: Karl Heinz Marbaise Fix For: maven-dependency-analyzer-1.11.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MSHARED-776) Upgrade maven-shared-components to 33
[ https://issues.apache.org/jira/browse/MSHARED-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise reassigned MSHARED-776: --- Assignee: Karl Heinz Marbaise > Upgrade maven-shared-components to 33 > - > > Key: MSHARED-776 > URL: https://issues.apache.org/jira/browse/MSHARED-776 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-dependency-analyzer >Affects Versions: maven-dependency-analyzer-1.11.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-dependency-analyzer-1.11.0 > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (MSHARED-772) maven-dependency-analyzer not working on OpenJDK 11
[
https://issues.apache.org/jira/browse/MSHARED-772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise reopened MSHARED-772:
-
> maven-dependency-analyzer not working on OpenJDK 11
>
>
> Key: MSHARED-772
> URL: https://issues.apache.org/jira/browse/MSHARED-772
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-dependency-analyzer
>Reporter: khalid el boukhari
>Assignee: Karl Heinz Marbaise
>Priority: Blocker
>
> Hi,
> Maven-dependency-analyzer is not supporting java 11.
> Here is my conf :
> {code:xml}
>
> maven-compiler-plugin
>
>
> org.ow2.asm
> asm
> 7.0
>
>
>
> 11
>
>
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-776) Upgrade maven-shared-components to 33
[ https://issues.apache.org/jira/browse/MSHARED-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690530#comment-16690530 ] Karl Heinz Marbaise commented on MSHARED-776: - Done in [d1dae3dc5b235b90ebd7aed834c7fd94879bb9af|https://gitbox.apache.org/repos/asf?p=maven-dependency-analyzer.git;a=commitdiff;h=d1dae3dc5b235b90ebd7aed834c7fd94879bb9af] > Upgrade maven-shared-components to 33 > - > > Key: MSHARED-776 > URL: https://issues.apache.org/jira/browse/MSHARED-776 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-dependency-analyzer >Affects Versions: maven-dependency-analyzer-1.11.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-dependency-analyzer-1.11.0 > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MSHARED-776) Upgrade maven-shared-components to 33
[ https://issues.apache.org/jira/browse/MSHARED-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MSHARED-776. --- Resolution: Done > Upgrade maven-shared-components to 33 > - > > Key: MSHARED-776 > URL: https://issues.apache.org/jira/browse/MSHARED-776 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-dependency-analyzer >Affects Versions: maven-dependency-analyzer-1.11.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-dependency-analyzer-1.11.0 > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MSHARED-773) Fail on invalid 'Automatic-Module-Name' in MANIFEST
[ https://issues.apache.org/jira/browse/MSHARED-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MSHARED-773: Fix Version/s: maven-archiver-3.2.1 > Fail on invalid 'Automatic-Module-Name' in MANIFEST > --- > > Key: MSHARED-773 > URL: https://issues.apache.org/jira/browse/MSHARED-773 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-archiver >Reporter: Christian Stein >Assignee: Christian Stein >Priority: Minor > Fix For: maven-archiver-3.2.1 > > > The Maven Archiver should fail when an invalid name is detected within the > `META-INF/MANIFEST.MF` file. > For details see > [https://sormuras.github.io/blog/2018-11-16-invalid-automatic-module-names] > This issue blocks https://issues.apache.org/jira/browse/MJAR-260 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6261) Relative parent POM resolution failing in 3.5.0 with complex multimodule builds
[
https://issues.apache.org/jira/browse/MNG-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690569#comment-16690569
]
Fabiano Cipriano de Oliveira commented on MNG-6261:
---
Robert I did the changes that you suggest in the PR. I verified that MNG-6503
is fixed with this patch too. Maybe a integration test to confirm this ?
> Relative parent POM resolution failing in 3.5.0 with complex multimodule
> builds
> ---
>
> Key: MNG-6261
> URL: https://issues.apache.org/jira/browse/MNG-6261
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Dawid Weiss
>Priority: Minor
> Labels: up-for-grabs
> Fix For: 3.6.x-candidate
>
> Attachments: capture-6.png, repro.zip
>
>
> In my effort to upgrade an existing (fairly complex) Maven build to Java
> 1.9.0 I updated Maven to 3.5.0 (from 3.3.9). Unfortunately I get errors when
> the project's modules are resolved:
> {noformat}
> > mvn validate
> [FATAL] Non-resolvable parent POM for
> com.carrotsearch.lingo4g:lingo4g-public-bom:[unknown-version]: Could not find
> artifact com.carrotsearch.lingo4g:lingo4g-public:pom:1.6.0-SNAPSHOT and
> 'parent.relativePath' points at wrong local POM @ line 5, column 11
> ...
> (and many follow).
> {noformat}
> This build has a correct pom parent-structure (a tree), but is fairly complex
> -- the submodule hierarchy is not aligned with parent-child pom hierarchy
> (it's best to look at the repro code to understand how it's structured).
> However, it's been working correctly with all prior Maven versions and I
> wonder if it's a regression bug or maybe underspecified Maven requirement
> (that should be enforced with a warning and not lead to this odd runtime
> message).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6511) Option -pl ! foo should not fail if foo does not exist
[
https://issues.apache.org/jira/browse/MNG-6511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690507#comment-16690507
]
Robert Scholte commented on MNG-6511:
-
A {{?}} is also valid in an ANT-expression, so that will complicate things when
combining these. Better stick to explicit names for stability.
> Option -pl ! foo should not fail if foo does not exist
> --
>
> Key: MNG-6511
> URL: https://issues.apache.org/jira/browse/MNG-6511
> Project: Maven
> Issue Type: Improvement
> Components: Command Line
>Affects Versions: 3.3.9, 3.6.0
>Reporter: Falko Modler
>Priority: Major
>
> While I completely understand why Maven throws an error when
> {{\-pl/--projects}} defines/contains a non-existing project, I don't really
> see why the negation of a non-existing project yields the same error, e.g.:
> {noformat}
> c:\_dev\git\gitflow-incremental-builder>mvn -pl !foo
> [INFO] Scanning for projects...
> [ERROR] [ERROR] Could not find the selected project in the reactor: foo @
> [ERROR] Could not find the selected project in the reactor: foo -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MavenExecutionException
> {noformat}
> I'd say that at most this should be a warning, not an error.
> This change would come in handy to reuse scripts with certain default options
> (e.g. quickly build everything without tests, checkstyle, _exclude moduleX_,
> etc.) on different hierarchy levels of larger multi module project.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (MSHARED-720) Upgrade mave-surefire/failsafe-plugin 2.21.0
[ https://issues.apache.org/jira/browse/MSHARED-720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MSHARED-720: Fix Version/s: (was: maven-archiver-3.2.1) > Upgrade mave-surefire/failsafe-plugin 2.21.0 > > > Key: MSHARED-720 > URL: https://issues.apache.org/jira/browse/MSHARED-720 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.2.1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] rfscholte closed pull request #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows
rfscholte closed pull request #198: [SUREFIRE-1593] Correcting relativization
logic to produce valid URIs on Windows
URL: https://github.com/apache/maven-surefire/pull/198
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
b/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
index 70f95d953..25f55066e 100644
---
a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
+++
b/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
@@ -33,7 +33,7 @@
import java.io.IOException;
import java.net.URI;
import java.net.URISyntaxException;
-import java.nio.file.Path;
+import java.nio.file.Paths;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
@@ -101,7 +101,7 @@ private File createJar( @Nonnull List classPath,
@Nonnull String startCl
{
file.deleteOnExit();
}
-Path parent = file.getParentFile().toPath();
+String parent = file.getParent();
FileOutputStream fos = new FileOutputStream( file );
try ( JarOutputStream jos = new JarOutputStream( fos ) )
{
@@ -116,10 +116,10 @@ private File createJar( @Nonnull List classPath,
@Nonnull String startCl
StringBuilder cp = new StringBuilder();
for ( Iterator it = classPath.iterator(); it.hasNext(); )
{
-File classPathElement = new File( it.next() );
+String classPathElement = it.next();
String uri = toClasspathElementUri( parent, classPathElement,
dumpLogDirectory );
cp.append( uri );
-if ( classPathElement.isDirectory() && !uri.endsWith( "/" ) )
+if ( new File( classPathElement ).isDirectory() &&
!uri.endsWith( "/" ) )
{
cp.append( '/' );
}
@@ -143,24 +143,34 @@ private File createJar( @Nonnull List classPath,
@Nonnull String startCl
}
}
-private static String toClasspathElementUri( @Nonnull Path parent,
- @Nonnull File
classPathElement,
- @Nonnull File
dumpLogDirectory )
+static String relativize( @Nonnull String parent, @Nonnull String child )
+throws IllegalArgumentException
+{
+return Paths.get( parent ).relativize( Paths.get( child ) ).toString();
+}
+
+static String absoluteUri( @Nonnull String file )
+{
+return Paths.get( file ).toUri().toASCIIString();
+}
+
+static String toClasspathElementUri( @Nonnull String parent,
+ @Nonnull String classPathElement,
+ @Nonnull File dumpLogDirectory )
throws IOException
{
try
{
-return new URI( null, parent.relativize( classPathElement.toPath()
).toString(), null )
-.toASCIIString();
+String uriPath = relativize( parent, classPathElement ).replace(
'\\', '/' );
+return new URI( null, uriPath, null ).toASCIIString();
}
catch ( IllegalArgumentException e )
{
-String error = "Boot Manifest-JAR contains absolute paths in
classpath " + classPathElement.getPath();
+String error = "Boot Manifest-JAR contains absolute paths in
classpath " + classPathElement;
InPluginProcessDumpSingleton.getSingleton()
.dumpException( e, error, dumpLogDirectory );
-return classPathElement.toURI()
-.toASCIIString();
+return absoluteUri( classPathElement );
}
catch ( URISyntaxException e )
{
diff --git
a/maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfigurationTest.java
b/maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfigurationTest.java
new file mode 100644
index 0..7e25e7fee
--- /dev/null
+++
b/maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfigurationTest.java
@@ -0,0 +1,119 @@
+package org.apache.maven.plugin.surefire.booterclient;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.
[jira] [Commented] (MJAR-260) Warn about invalid 'Automatic-Module-Name' in MANIFEST
[ https://issues.apache.org/jira/browse/MJAR-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690517#comment-16690517 ] Robert Scholte commented on MJAR-260: - Solving this in Archiver is nice, PR looks good to me. > Warn about invalid 'Automatic-Module-Name' in MANIFEST > -- > > Key: MJAR-260 > URL: https://issues.apache.org/jira/browse/MJAR-260 > Project: Maven JAR Plugin > Issue Type: Improvement >Reporter: Christian Stein >Assignee: Christian Stein >Priority: Minor > > The Maven JAR Plugin should warn or even fail when an invalid name is > detected within the `META-INF/MANIFEST.MF` file. > For details see > https://sormuras.github.io/blog/2018-11-16-invalid-automatic-module-names -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MSHARED-720) Upgrade mave-surefire/failsafe-plugin 2.21.0
[ https://issues.apache.org/jira/browse/MSHARED-720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MSHARED-720. --- Resolution: Implemented superseded by MSHARED-774 > Upgrade mave-surefire/failsafe-plugin 2.21.0 > > > Key: MSHARED-720 > URL: https://issues.apache.org/jira/browse/MSHARED-720 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.2.1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Major > Fix For: maven-archiver-3.2.1 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSHARED-721) Upgrade maven-shared-utils to 3.2.1
[ https://issues.apache.org/jira/browse/MSHARED-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690510#comment-16690510 ] Karl Heinz Marbaise commented on MSHARED-721: - Done in [ebfb3da229ab5441aed442feb7c8127066bb3ed9|https://gitbox.apache.org/repos/asf?p=maven-archiver.git;a=commitdiff;h=ebfb3da229ab5441aed442feb7c8127066bb3ed9] > Upgrade maven-shared-utils to 3.2.1 > --- > > Key: MSHARED-721 > URL: https://issues.apache.org/jira/browse/MSHARED-721 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.2.1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-archiver-3.2.1 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MSHARED-774) Upgrade maven-plugins parent to version 33
[ https://issues.apache.org/jira/browse/MSHARED-774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise reassigned MSHARED-774: --- Assignee: Karl Heinz Marbaise > Upgrade maven-plugins parent to version 33 > -- > > Key: MSHARED-774 > URL: https://issues.apache.org/jira/browse/MSHARED-774 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.2.1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-archiver-3.2.1 > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MJAR-260) Warn about invalid 'Automatic-Module-Name' in MANIFEST
[ https://issues.apache.org/jira/browse/MJAR-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690539#comment-16690539 ] Christian Stein commented on MJAR-260: -- Solved in Archiver via [https://github.com/apache/maven-archiver/commit/347d7d3334417598c7bc8584729cda0c7e1c] – now waiting for an Archiver release to update this issue/PR. > Warn about invalid 'Automatic-Module-Name' in MANIFEST > -- > > Key: MJAR-260 > URL: https://issues.apache.org/jira/browse/MJAR-260 > Project: Maven JAR Plugin > Issue Type: Improvement >Reporter: Christian Stein >Assignee: Christian Stein >Priority: Minor > > The Maven JAR Plugin should warn or even fail when an invalid name is > detected within the `META-INF/MANIFEST.MF` file. > For details see > https://sormuras.github.io/blog/2018-11-16-invalid-automatic-module-names -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MSHARED-773) Fail on invalid 'Automatic-Module-Name' in MANIFEST
[ https://issues.apache.org/jira/browse/MSHARED-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MSHARED-773: Description: The Maven Archiver should fail when an invalid name is detected within the `META-INF/MANIFEST.MF` file. For details see [https://sormuras.github.io/blog/2018-11-16-invalid-automatic-module-names] was: The Maven Archiver should fail when an invalid name is detected within the `META-INF/MANIFEST.MF` file. For details see [https://sormuras.github.io/blog/2018-11-16-invalid-automatic-module-names] This issue blocks https://issues.apache.org/jira/browse/MJAR-260 > Fail on invalid 'Automatic-Module-Name' in MANIFEST > --- > > Key: MSHARED-773 > URL: https://issues.apache.org/jira/browse/MSHARED-773 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-archiver >Reporter: Christian Stein >Assignee: Christian Stein >Priority: Minor > Fix For: maven-archiver-3.2.1 > > > The Maven Archiver should fail when an invalid name is detected within the > `META-INF/MANIFEST.MF` file. > For details see > [https://sormuras.github.io/blog/2018-11-16-invalid-automatic-module-names] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSHARED-721) Upgrade maven-shared-utils to 3.2.1
[ https://issues.apache.org/jira/browse/MSHARED-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690511#comment-16690511 ] Hudson commented on MSHARED-721: Build succeeded in Jenkins: Maven TLP » maven-archiver » master #31 See https://builds.apache.org/job/maven-box/job/maven-archiver/job/master/31/ > Upgrade maven-shared-utils to 3.2.1 > --- > > Key: MSHARED-721 > URL: https://issues.apache.org/jira/browse/MSHARED-721 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.2.1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-archiver-3.2.1 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MSHARED-774) Upgrade maven-plugins parent to version 33
Karl Heinz Marbaise created MSHARED-774: --- Summary: Upgrade maven-plugins parent to version 33 Key: MSHARED-774 URL: https://issues.apache.org/jira/browse/MSHARED-774 Project: Maven Shared Components Issue Type: Dependency upgrade Components: maven-archiver Affects Versions: maven-archiver-3.2.1 Reporter: Karl Heinz Marbaise Fix For: maven-archiver-3.2.1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MSHARED-775) Upgrade plexus-interpolation to 1.25
[ https://issues.apache.org/jira/browse/MSHARED-775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MSHARED-775. --- Resolution: Done > Upgrade plexus-interpolation to 1.25 > > > Key: MSHARED-775 > URL: https://issues.apache.org/jira/browse/MSHARED-775 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.2.1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-archiver-3.2.1 > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSHARED-775) Upgrade plexus-interpolation to 1.25
[ https://issues.apache.org/jira/browse/MSHARED-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690522#comment-16690522 ] Karl Heinz Marbaise commented on MSHARED-775: - Done in [b687d1b2262068da3f59e19c13ad8c879c57b6ff|https://gitbox.apache.org/repos/asf?p=maven-archiver.git;a=commitdiff;h=b687d1b2262068da3f59e19c13ad8c879c57b6ff] > Upgrade plexus-interpolation to 1.25 > > > Key: MSHARED-775 > URL: https://issues.apache.org/jira/browse/MSHARED-775 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.2.1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-archiver-3.2.1 > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSHARED-775) Upgrade plexus-interpolation to 1.25
[ https://issues.apache.org/jira/browse/MSHARED-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690524#comment-16690524 ] Hudson commented on MSHARED-775: Build succeeded in Jenkins: Maven TLP » maven-archiver » master #34 See https://builds.apache.org/job/maven-box/job/maven-archiver/job/master/34/ > Upgrade plexus-interpolation to 1.25 > > > Key: MSHARED-775 > URL: https://issues.apache.org/jira/browse/MSHARED-775 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.2.1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-archiver-3.2.1 > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MSHARED-747) Upgrade maven-plugins parent to version 32
[ https://issues.apache.org/jira/browse/MSHARED-747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise reassigned MSHARED-747: --- Assignee: Karl Heinz Marbaise > Upgrade maven-plugins parent to version 32 > -- > > Key: MSHARED-747 > URL: https://issues.apache.org/jira/browse/MSHARED-747 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.2.1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-archiver-3.2.1 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MJAR-260) Warn about invalid 'Automatic-Module-Name' in MANIFEST
[ https://issues.apache.org/jira/browse/MJAR-260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MJAR-260: - Fix Version/s: 3.1.1 > Warn about invalid 'Automatic-Module-Name' in MANIFEST > -- > > Key: MJAR-260 > URL: https://issues.apache.org/jira/browse/MJAR-260 > Project: Maven JAR Plugin > Issue Type: Improvement >Reporter: Christian Stein >Assignee: Christian Stein >Priority: Minor > Fix For: 3.1.1 > > > The Maven JAR Plugin should warn or even fail when an invalid name is > detected within the `META-INF/MANIFEST.MF` file. > For details see > https://sormuras.github.io/blog/2018-11-16-invalid-automatic-module-names -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6261) Relative parent POM resolution failing in 3.5.0 with complex multimodule builds
[
https://issues.apache.org/jira/browse/MNG-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690581#comment-16690581
]
Robert Scholte commented on MNG-6261:
-
Almost there. In this case the unittest should be good enough. An explicit IT
could be nice but is not necessary here.
> Relative parent POM resolution failing in 3.5.0 with complex multimodule
> builds
> ---
>
> Key: MNG-6261
> URL: https://issues.apache.org/jira/browse/MNG-6261
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Dawid Weiss
>Priority: Minor
> Labels: up-for-grabs
> Fix For: 3.6.x-candidate
>
> Attachments: capture-6.png, repro.zip
>
>
> In my effort to upgrade an existing (fairly complex) Maven build to Java
> 1.9.0 I updated Maven to 3.5.0 (from 3.3.9). Unfortunately I get errors when
> the project's modules are resolved:
> {noformat}
> > mvn validate
> [FATAL] Non-resolvable parent POM for
> com.carrotsearch.lingo4g:lingo4g-public-bom:[unknown-version]: Could not find
> artifact com.carrotsearch.lingo4g:lingo4g-public:pom:1.6.0-SNAPSHOT and
> 'parent.relativePath' points at wrong local POM @ line 5, column 11
> ...
> (and many follow).
> {noformat}
> This build has a correct pom parent-structure (a tree), but is fairly complex
> -- the submodule hierarchy is not aligned with parent-child pom hierarchy
> (it's best to look at the repro code to understand how it's structured).
> However, it's been working correctly with all prior Maven versions and I
> wonder if it's a regression bug or maybe underspecified Maven requirement
> (that should be enforced with a warning and not lead to this odd runtime
> message).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MDEP-613) Analyze failed: Unsupported class file major version 55 (Java 11)
[
https://issues.apache.org/jira/browse/MDEP-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690625#comment-16690625
]
Anish V. Abraham commented on MDEP-613:
---
Is there a snapshot version of the plugin where the fix has been applied and
can be tested?
> Analyze failed: Unsupported class file major version 55 (Java 11)
> -
>
> Key: MDEP-613
> URL: https://issues.apache.org/jira/browse/MDEP-613
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: analyze
>Affects Versions: 3.1.0
>Reporter: Mincong Huang
>Assignee: Karl Heinz Marbaise
>Priority: Major
> Labels: up-for-grabs
> Fix For: 3.1.2
>
> Attachments: log.txt
>
>
> Class file of major version 55 (Java 11) is not yet supported by Maven
> Dependency Plugin. So when running command {{mvn dependency:analysis}} on
> classes created by Java 11, il failed. See {{log.txt}} for the full log trace.
> This is caused by ASM, which does not support major version 55 (Java 11) yet.
> However, their HEAD contains already the solution, so using the SNAPSHOT
> version will work. This support will be included in the next release 6.2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WAGON-538) Basic authentication fails if the password contains non-ASCII characters
[
https://issues.apache.org/jira/browse/WAGON-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690659#comment-16690659
]
Michael Osipov commented on WAGON-538:
--
OK, great. I will continue with the merge. The parameter is pointless as I have
pointed out.
> Basic authentication fails if the password contains non-ASCII characters
>
>
> Key: WAGON-538
> URL: https://issues.apache.org/jira/browse/WAGON-538
> Project: Maven Wagon
> Issue Type: Bug
> Components: wagon-http
>Affects Versions: 3.2.0
>Reporter: Aleksander Gjermundsen
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.3.0
>
>
> If the username and/or password used to authenticate to Nexus contains
> non-ascii characters, the authentication fails with an access denied error.
> After using Wireshark to investigate the headers being sent (in my case "Ø",
> any non-ascii characters are replaced with "?".
> To test, I have used the following configuration:
> {code:java}
> http://maven.apache.org/SETTINGS/1.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0
> http://maven.apache.org/xsd/settings-1.0.0.xsd;>
> ...
>
>
> artifactory
> userØ
> userØ
>
>
> ...
>
>
> nexus
> *
> Local Nexus
> http://localhost:8081/repository/maven-public
>
>
> ...
> {code}
> The settings.xml file is saved using UTF-8 encoding and it appears that Maven
> reads the username and passwords correctly into strings, but Apache
> HttpClient do not encode the UTF-8 characters when encoding them into base64.
> I did a quick patch of Wagon to make it work for my use case, where
> HttpClient is configured to encode as UTF-8. As is mentioned in MNG-5917, it
> is not completely clear from the standards how these characters are supposed
> to be handled, but on my system both wget and the Chrome web browser encode
> the characters the same way as after my patch and are able to download files
> from Nexus.
> Since Artifactory was used in MNG-5917, I also tested against that, but in
> contrast to Maven it was not able to decode the username and password
> correctly, however it would be broken without the patch anyway.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (SUREFIRE-1531) Option to switch-off Java 9 modules
[
https://issues.apache.org/jira/browse/SUREFIRE-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana closed SUREFIRE-1531.
--
Resolution: Fixed
https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=f333b7d9e89ddfe086fd1cb930df0f77a0edbc96
> Option to switch-off Java 9 modules
> ---
>
> Key: SUREFIRE-1531
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1531
> Project: Maven Surefire
> Issue Type: Improvement
> Components: Maven Surefire Plugin
>Affects Versions: 2.22.0
>Reporter: Lukáš Křečan
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M2
>
>
> I am working on a library and I am adding support for Java 9 modules.
> Surefire 2.21.0 by default executes tests with Java 9 modules switched-on if
> it detects module-info.java While it may make sense in some cases, in my case
> I'd like the switch it off.
> The reason is simple. I am using Mockito to mock an interface that extends a
> Spring interface. Mockito has to create an implementation of this interface
> (proxy or subclass) and for this it needs to have access to the Spring
> interfaces. If Java 9 modules are enabled for the tests I have to manually
> add each such dependencies to Surefire configuration, which does not make
> much sense. To makes things worse, the interface actually extends two Spring
> interfaces form two different Spring modules so the configuration is almost
> impossible to get right.
> So far I am at ( and I am still getting IllegalAccessErrors)
> {code:java}
> --add-exports spring.context/org.springframework.scheduling=org.mockito
> --add-exports spring.beans/org.springframework.beans.factory=org.mockito
> {code}
> I would prefer to switch-off the Java 9 modules for the test module
> altogether (same behavior as pre 2.21.0)
>
> The test is here
> [https://github.com/lukas-krecan/ShedLock/blob/java9/shedlock-spring/src/test/java/net/javacrumbs/shedlock/spring/CleanupTest.java]
>
> If you want, I can send a pull request.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1531) Option to switch-off Java 9 modules
[
https://issues.apache.org/jira/browse/SUREFIRE-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690667#comment-16690667
]
Tibor Digana commented on SUREFIRE-1531:
https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=2ccba319efc4248197ce307515540f1c56faa9c5
> Option to switch-off Java 9 modules
> ---
>
> Key: SUREFIRE-1531
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1531
> Project: Maven Surefire
> Issue Type: Improvement
> Components: Maven Surefire Plugin
>Affects Versions: 2.22.0
>Reporter: Lukáš Křečan
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M2
>
>
> I am working on a library and I am adding support for Java 9 modules.
> Surefire 2.21.0 by default executes tests with Java 9 modules switched-on if
> it detects module-info.java While it may make sense in some cases, in my case
> I'd like the switch it off.
> The reason is simple. I am using Mockito to mock an interface that extends a
> Spring interface. Mockito has to create an implementation of this interface
> (proxy or subclass) and for this it needs to have access to the Spring
> interfaces. If Java 9 modules are enabled for the tests I have to manually
> add each such dependencies to Surefire configuration, which does not make
> much sense. To makes things worse, the interface actually extends two Spring
> interfaces form two different Spring modules so the configuration is almost
> impossible to get right.
> So far I am at ( and I am still getting IllegalAccessErrors)
> {code:java}
> --add-exports spring.context/org.springframework.scheduling=org.mockito
> --add-exports spring.beans/org.springframework.beans.factory=org.mockito
> {code}
> I would prefer to switch-off the Java 9 modules for the test module
> altogether (same behavior as pre 2.21.0)
>
> The test is here
> [https://github.com/lukas-krecan/ShedLock/blob/java9/shedlock-spring/src/test/java/net/javacrumbs/shedlock/spring/CleanupTest.java]
>
> If you want, I can send a pull request.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6261) Relative parent POM resolution failing in 3.5.0 with complex multimodule builds
[
https://issues.apache.org/jira/browse/MNG-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690684#comment-16690684
]
ASF GitHub Bot commented on MNG-6261:
-
fabcipriano commented on a change in pull request #192: [MNG-6261] - using java
File api to compare
URL: https://github.com/apache/maven/pull/192#discussion_r234419499
##
File path:
maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
##
@@ -852,10 +852,11 @@ private ModelData readParent( Model childModel,
ModelSource childSource, ModelBu
File pomFile = parentData.getModel().getPomFile();
if ( pomFile != null )
{
+FileModelSource pomFileModel = new FileModelSource(
pomFile );
ModelSource expectedParentSource = getParentPomFile(
childModel, childSource );
if ( expectedParentSource == null || (
expectedParentSource instanceof ModelSource2
-&& !pomFile.toURI().equals( ( (ModelSource2)
expectedParentSource ).getLocationURI() ) ) )
+&& !pomFileModel.equals( expectedParentSource ) ) )
Review comment:
changed
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Relative parent POM resolution failing in 3.5.0 with complex multimodule
> builds
> ---
>
> Key: MNG-6261
> URL: https://issues.apache.org/jira/browse/MNG-6261
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Dawid Weiss
>Priority: Minor
> Labels: up-for-grabs
> Fix For: 3.6.x-candidate
>
> Attachments: capture-6.png, repro.zip
>
>
> In my effort to upgrade an existing (fairly complex) Maven build to Java
> 1.9.0 I updated Maven to 3.5.0 (from 3.3.9). Unfortunately I get errors when
> the project's modules are resolved:
> {noformat}
> > mvn validate
> [FATAL] Non-resolvable parent POM for
> com.carrotsearch.lingo4g:lingo4g-public-bom:[unknown-version]: Could not find
> artifact com.carrotsearch.lingo4g:lingo4g-public:pom:1.6.0-SNAPSHOT and
> 'parent.relativePath' points at wrong local POM @ line 5, column 11
> ...
> (and many follow).
> {noformat}
> This build has a correct pom parent-structure (a tree), but is fairly complex
> -- the submodule hierarchy is not aligned with parent-child pom hierarchy
> (it's best to look at the repro code to understand how it's structured).
> However, it's been working correctly with all prior Maven versions and I
> wonder if it's a regression bug or maybe underspecified Maven requirement
> (that should be enforced with a warning and not lead to this odd runtime
> message).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] fabcipriano commented on a change in pull request #192: [MNG-6261] - using java File api to compare
fabcipriano commented on a change in pull request #192: [MNG-6261] - using java
File api to compare
URL: https://github.com/apache/maven/pull/192#discussion_r234419499
##
File path:
maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
##
@@ -852,10 +852,11 @@ private ModelData readParent( Model childModel,
ModelSource childSource, ModelBu
File pomFile = parentData.getModel().getPomFile();
if ( pomFile != null )
{
+FileModelSource pomFileModel = new FileModelSource(
pomFile );
ModelSource expectedParentSource = getParentPomFile(
childModel, childSource );
if ( expectedParentSource == null || (
expectedParentSource instanceof ModelSource2
-&& !pomFile.toURI().equals( ( (ModelSource2)
expectedParentSource ).getLocationURI() ) ) )
+&& !pomFileModel.equals( expectedParentSource ) ) )
Review comment:
changed
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (MNG-6261) Relative parent POM resolution failing in 3.5.0 with complex multimodule builds
[
https://issues.apache.org/jira/browse/MNG-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690686#comment-16690686
]
ASF GitHub Bot commented on MNG-6261:
-
fabcipriano commented on a change in pull request #192: [MNG-6261] - using java
File api to compare
URL: https://github.com/apache/maven/pull/192#discussion_r234419551
##
File path:
maven-model-builder/src/test/java/org/apache/maven/model/building/FileModelSourceTest.java
##
@@ -0,0 +1,52 @@
+package org.apache.maven.model.building;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+import junit.framework.TestCase;
+
+/**
+ *
+ * @author fabiano
+ */
+public class FileModelSourceTest
+extends TestCase
+{
+
+public FileModelSourceTest() {
+}
+
+/**
+ * Test of equals method, of class FileModelSource.
+ */
+public void testEquals()
+throws Exception
+{
+File tempFile = File.createTempFile("pomTest-", ".xml");
+tempFile.deleteOnExit();
+FileModelSource instance = new FileModelSource( tempFile );
+
+assertFalse( instance.equals( null ) );
+assertFalse( instance.equals( new Object() ) );
+assertTrue( instance.equals( instance ) );
+assertTrue( instance.equals( new FileModelSource( tempFile ) ) );
+}
+
Review comment:
I did a test case for windows path like you mention
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Relative parent POM resolution failing in 3.5.0 with complex multimodule
> builds
> ---
>
> Key: MNG-6261
> URL: https://issues.apache.org/jira/browse/MNG-6261
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Dawid Weiss
>Priority: Minor
> Labels: up-for-grabs
> Fix For: 3.6.x-candidate
>
> Attachments: capture-6.png, repro.zip
>
>
> In my effort to upgrade an existing (fairly complex) Maven build to Java
> 1.9.0 I updated Maven to 3.5.0 (from 3.3.9). Unfortunately I get errors when
> the project's modules are resolved:
> {noformat}
> > mvn validate
> [FATAL] Non-resolvable parent POM for
> com.carrotsearch.lingo4g:lingo4g-public-bom:[unknown-version]: Could not find
> artifact com.carrotsearch.lingo4g:lingo4g-public:pom:1.6.0-SNAPSHOT and
> 'parent.relativePath' points at wrong local POM @ line 5, column 11
> ...
> (and many follow).
> {noformat}
> This build has a correct pom parent-structure (a tree), but is fairly complex
> -- the submodule hierarchy is not aligned with parent-child pom hierarchy
> (it's best to look at the repro code to understand how it's structured).
> However, it's been working correctly with all prior Maven versions and I
> wonder if it's a regression bug or maybe underspecified Maven requirement
> (that should be enforced with a warning and not lead to this odd runtime
> message).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] fabcipriano commented on a change in pull request #192: [MNG-6261] - using java File api to compare
fabcipriano commented on a change in pull request #192: [MNG-6261] - using java
File api to compare
URL: https://github.com/apache/maven/pull/192#discussion_r234419551
##
File path:
maven-model-builder/src/test/java/org/apache/maven/model/building/FileModelSourceTest.java
##
@@ -0,0 +1,52 @@
+package org.apache.maven.model.building;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+import junit.framework.TestCase;
+
+/**
+ *
+ * @author fabiano
+ */
+public class FileModelSourceTest
+extends TestCase
+{
+
+public FileModelSourceTest() {
+}
+
+/**
+ * Test of equals method, of class FileModelSource.
+ */
+public void testEquals()
+throws Exception
+{
+File tempFile = File.createTempFile("pomTest-", ".xml");
+tempFile.deleteOnExit();
+FileModelSource instance = new FileModelSource( tempFile );
+
+assertFalse( instance.equals( null ) );
+assertFalse( instance.equals( new Object() ) );
+assertTrue( instance.equals( instance ) );
+assertTrue( instance.equals( new FileModelSource( tempFile ) ) );
+}
+
Review comment:
I did a test case for windows path like you mention
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
