[GitHub] [maven-indexer] eolivelli commented on issue #39: Add getName() to Record.EntryKey

2019-08-20 Thread GitBox
eolivelli commented on issue #39: Add getName() to Record.EntryKey URL: https://github.com/apache/maven-indexer/pull/39#issuecomment-522875415 No need to rename the branch. This is an automated message from the Apache Git

[GitHub] [maven] michael-o commented on issue #262: [MNG-6695] Improve speed in collection merging

2019-08-20 Thread GitBox
michael-o commented on issue #262: [MNG-6695] Improve speed in collection merging URL: https://github.com/apache/maven/pull/262#issuecomment-522902969 We have all have invested a lot of time into this. Since we don't have any objections, I will rebase and merge by Thursday.

[jira] [Comment Edited] (MPIR-373) Upgrade from 2.9 to 3.0.0 introduces additional warning

2019-08-20 Thread Jira
[ https://issues.apache.org/jira/browse/MPIR-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911029#comment-16911029 ] Hervé Boutemy edited comment on MPIR-373 at 8/20/19 6:25 AM: - this PR is a

[jira] [Commented] (MPIR-373) Upgrade from 2.9 to 3.0.0 introduces additional warning

2019-08-20 Thread Jira
[ https://issues.apache.org/jira/browse/MPIR-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911029#comment-16911029 ] Hervé Boutemy commented on MPIR-373: this PR is a workaround to make the issue less visible: nice to

[jira] [Commented] (MPIR-373) Upgrade from 2.9 to 3.0.0 introduces additional warning

2019-08-20 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MPIR-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911067#comment-16911067 ] Robert Scholte commented on MPIR-373: - All I remember that the ModelBuilder is the preferred way to

[GitHub] [maven-project-info-reports-plugin] asfgit closed pull request #11: [MPIR-373][MPIR-374] Log Warning of incorrect dependency only on debug and add info otherw…

2019-08-20 Thread GitBox
asfgit closed pull request #11: [MPIR-373][MPIR-374] Log Warning of incorrect dependency only on debug and add info otherw… URL: https://github.com/apache/maven-project-info-reports-plugin/pull/11 This is an automated

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-08-20 Thread GitBox
Tibor17 commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#discussion_r315607380 ## File path:

[GitHub] [maven-surefire] Tibor17 edited a comment on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-08-20 Thread GitBox
Tibor17 edited a comment on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-522944865 @jon-bell Generally, it looks good. I have left only few comments. Pls open the MOJO classes. You will

[jira] [Commented] (MASSEMBLY-907) Dependencies are not included when run with mvn install

2019-08-20 Thread Mark Symons (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911189#comment-16911189 ] Mark Symons commented on MASSEMBLY-907: --- Is there any progress on this? Our teams ran into

[jira] [Created] (MNG-6740) Provide a way to override properties of a polyglot build

2019-08-20 Thread Jira
Christoph Läubrich created MNG-6740: --- Summary: Provide a way to override properties of a polyglot build Key: MNG-6740 URL: https://issues.apache.org/jira/browse/MNG-6740 Project: Maven

[jira] [Updated] (MNG-6740) Provide a way to override properties of a polyglot build

2019-08-20 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-6740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christoph Läubrich updated MNG-6740: Description: polyglot allows to generate maven models out of other metadata that pom.xml via

[jira] [Commented] (MNG-6740) Provide a way to override properties of a polyglot build

2019-08-20 Thread Mickael Istria (Jira)
[ https://issues.apache.org/jira/browse/MNG-6740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911209#comment-16911209 ] Mickael Istria commented on MNG-6740: - +1 for this feature in Maven. Most polyglot extensions will have

[jira] [Created] (MDEP-659) dependency:unpack / needs the option of unpacking sub-directory AND ignoring parent folders

2019-08-20 Thread Jasper Teng (Jira)
Jasper Teng created MDEP-659: Summary: dependency:unpack / needs the option of unpacking sub-directory AND ignoring parent folders Key: MDEP-659 URL: https://issues.apache.org/jira/browse/MDEP-659

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-08-20 Thread GitBox
Tibor17 commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#discussion_r315600822 ## File path:

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-08-20 Thread GitBox
Tibor17 commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#discussion_r315600822 ## File path:

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-08-20 Thread GitBox
Tibor17 commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#discussion_r315601476 ## File path:

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-08-20 Thread GitBox
Tibor17 commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#discussion_r315603657 ## File path:

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-08-20 Thread GitBox
Tibor17 commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#discussion_r315605236 ## File path:

[GitHub] [maven] boohoo555 commented on issue #270: [MNG-3699] - Lift JDK minimum to JDK 8

2019-08-20 Thread GitBox
boohoo555 commented on issue #270: [MNG-3699] - Lift JDK minimum to JDK 8 URL: https://github.com/apache/maven/pull/270#issuecomment-522874039 Duplicate of # This is an automated message from the Apache Git Service. To

[GitHub] [maven-indexer] eolivelli commented on issue #38: Change indexer-reader's Utils to call read() once

2019-08-20 Thread GitBox
eolivelli commented on issue #38: Change indexer-reader's Utils to call read() once URL: https://github.com/apache/maven-indexer/pull/38#issuecomment-522878603 Let's wait for CI https://builds.apache.org/job/maven-box/job/maven-indexer/job/MNINDEXER-123/

[GitHub] [maven-indexer] eolivelli commented on issue #39: Add getName() to Record.EntryKey

2019-08-20 Thread GitBox
eolivelli commented on issue #39: Add getName() to Record.EntryKey URL: https://github.com/apache/maven-indexer/pull/39#issuecomment-522878539 Let's wait for CI https://builds.apache.org/job/maven-box/job/maven-indexer/job/MINDEXER-122/

[jira] [Closed] (MPIR-373) Upgrade from 2.9 to 3.0.0 introduces additional warning

2019-08-20 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MPIR-373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MPIR-373. --- Resolution: Fixed Fixed with

[GitHub] [maven-project-info-reports-plugin] michael-o commented on issue #7: [MPIR-375] add plugin excludes feature for plugin-management report

2019-08-20 Thread GitBox
michael-o commented on issue #7: [MPIR-375] add plugin excludes feature for plugin-management report URL: https://github.com/apache/maven-project-info-reports-plugin/pull/7#issuecomment-522893905 Merged with 82f4bf23b79fe87d2e414c70ab2058e8f1b4146b-

[GitHub] [maven-project-info-reports-plugin] michael-o edited a comment on issue #7: [MPIR-375] add plugin excludes feature for plugin-management report

2019-08-20 Thread GitBox
michael-o edited a comment on issue #7: [MPIR-375] add plugin excludes feature for plugin-management report URL: https://github.com/apache/maven-project-info-reports-plugin/pull/7#issuecomment-522893905 Merged with 82f4bf23b79fe87d2e414c70ab2058e8f1b4146b.

[GitHub] [maven-project-info-reports-plugin] michael-o closed pull request #7: [MPIR-375] add plugin excludes feature for plugin-management report

2019-08-20 Thread GitBox
michael-o closed pull request #7: [MPIR-375] add plugin excludes feature for plugin-management report URL: https://github.com/apache/maven-project-info-reports-plugin/pull/7 This is an automated message from the Apache Git

[GitHub] [maven-surefire] Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-08-20 Thread GitBox
Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-522944865 @jon-bell Generally, it looks good. I have left only few comments. Pls open the MOJO classes. You will see

[jira] [Assigned] (MPIR-376) LightweightHttpsWagon is always used

2019-08-20 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MPIR-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MPIR-376: --- Assignee: Michael Osipov > LightweightHttpsWagon is always used >

[jira] [Commented] (MPIR-373) Upgrade from 2.9 to 3.0.0 introduces additional warning

2019-08-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MPIR-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1691#comment-1691 ] Hudson commented on MPIR-373: - Build succeeded in Jenkins: Maven TLP » maven-project-info-reports-plugin »

[jira] [Commented] (MPIR-376) LightweightHttpsWagon is always used

2019-08-20 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MPIR-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1692#comment-1692 ] Michael Osipov commented on MPIR-376: - [~rfscholte], all ITs pass on Jenkins. I am going to merge this

[GitHub] [maven] eolivelli commented on issue #262: [MNG-6695] Improve speed in collection merging

2019-08-20 Thread GitBox
eolivelli commented on issue #262: [MNG-6695] Improve speed in collection merging URL: https://github.com/apache/maven/pull/262#issuecomment-522973062 +1 @michel-o This is an automated message from the Apache Git

[GitHub] [maven] eolivelli edited a comment on issue #262: [MNG-6695] Improve speed in collection merging

2019-08-20 Thread GitBox
eolivelli edited a comment on issue #262: [MNG-6695] Improve speed in collection merging URL: https://github.com/apache/maven/pull/262#issuecomment-522973062 +1 @michael-o This is an automated message from the Apache Git

[jira] [Created] (MNG-6741) Modules aggregation from parent does not work

2019-08-20 Thread Thomas Lehmann (Jira)
Thomas Lehmann created MNG-6741: Summary: Modules aggregation from parent does not work Key: MNG-6741 URL: https://issues.apache.org/jira/browse/MNG-6741 Project: Maven Issue Type: Bug

[GitHub] [maven] Tibor17 commented on issue #262: [MNG-6695] Improve speed in collection merging

2019-08-20 Thread GitBox
Tibor17 commented on issue #262: [MNG-6695] Improve speed in collection merging URL: https://github.com/apache/maven/pull/262#issuecomment-522974362 @michael-o In the afternoon I will show you what I mean in another commit. Maybe I will have the answer from the author.

[jira] [Commented] (MNG-6741) Modules aggregation from parent does not work

2019-08-20 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911249#comment-16911249 ] Michael Osipov commented on MNG-6741: - Please provide a sample project for this. > Modules aggregation

[jira] [Created] (MNG-6742) org.sonatype.maven.polyglot.TeslaModelProcessor.locatePom(File) ignores files ending in.xml

2019-08-20 Thread Jira
Christoph Läubrich created MNG-6742: --- Summary: org.sonatype.maven.polyglot.TeslaModelProcessor.locatePom(File) ignores files ending in.xml Key: MNG-6742 URL: https://issues.apache.org/jira/browse/MNG-6742

[GitHub] [maven-surefire] Col-E commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-08-20 Thread GitBox
Col-E commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#discussion_r315834218 ## File path:

[GitHub] [maven-surefire] Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-08-20 Thread GitBox
Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-523138627 @jon-bell Additionally, we have to update the chart

[GitHub] [maven-surefire] Tibor17 edited a comment on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-08-20 Thread GitBox
Tibor17 edited a comment on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-523143928 > (JUnit 4+ providers and JUnit 5+ providers since 3.0.0-M4) > Is the remark for clarifying support as of

[GitHub] [maven-surefire] Col-E commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-08-20 Thread GitBox
Col-E commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-523144813 Ok, all suggestions have been addressed except for the usage of `toClassMethodNameWithoutPlan`, which I responded to

[GitHub] [maven-dependency-plugin] pmoerenhout commented on issue #18: [MDEP-579] - Add mirrors, proxies and authentication for remote repos…

2019-08-20 Thread GitBox
pmoerenhout commented on issue #18: [MDEP-579] - Add mirrors, proxies and authentication for remote repos… URL: https://github.com/apache/maven-dependency-plugin/pull/18#issuecomment-523212499 Superceded by new pull request https://github.com/apache/maven-dependency-plugin/pull/19

[jira] [Commented] (MPIR-373) Upgrade from 2.9 to 3.0.0 introduces additional warning

2019-08-20 Thread Maxim Solodovnik (Jira)
[ https://issues.apache.org/jira/browse/MPIR-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911913#comment-16911913 ] Maxim Solodovnik commented on MPIR-373: --- [~rfscholte] would it be possible to release this new

[GitHub] [maven-resolver] suztomo commented on a change in pull request #39: [MRESOLVER-93] - PathRecordingDependencyVisitor to handle 3 cycles

2019-08-20 Thread GitBox
suztomo commented on a change in pull request #39: [MRESOLVER-93] - PathRecordingDependencyVisitor to handle 3 cycles URL: https://github.com/apache/maven-resolver/pull/39#discussion_r315974988 ## File path:

[GitHub] [maven-resolver] belingueres commented on a change in pull request #39: [MRESOLVER-93] - PathRecordingDependencyVisitor to handle 3 cycles

2019-08-20 Thread GitBox
belingueres commented on a change in pull request #39: [MRESOLVER-93] - PathRecordingDependencyVisitor to handle 3 cycles URL: https://github.com/apache/maven-resolver/pull/39#discussion_r315972295 ## File path:

[GitHub] [maven-surefire] Col-E commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-08-20 Thread GitBox
Col-E commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-523128544 > Pls open the MOJO classes. You will see `rerunFailingTestsCount`. Extend the JavaDoc and add a new support for JUnit5

[GitHub] [maven-surefire] Col-E commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-08-20 Thread GitBox
Col-E commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#discussion_r315820300 ## File path:

[GitHub] [maven-surefire] Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-08-20 Thread GitBox
Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-523143928 > (JUnit 4+ providers and JUnit 5+ providers since 3.0.0-M4) > Is the remark for clarifying support as of 3.0.0-M4?

[jira] [Commented] (MNG-6740) Provide a way to override properties of a polyglot build

2019-08-20 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-6740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911577#comment-16911577 ] Christoph Läubrich commented on MNG-6740: - migrated to

[GitHub] [maven-surefire] Col-E commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-08-20 Thread GitBox
Col-E commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#discussion_r315820300 ## File path:

[GitHub] [maven-surefire] Tibor17 edited a comment on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-08-20 Thread GitBox
Tibor17 edited a comment on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-523138627 @Col-E Additionally, we have to update the chart

[GitHub] [maven-surefire] Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-08-20 Thread GitBox
Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-523145553 The diff in Github is not enough for me, so I have to see the entire class for `toClassMethodNameWithoutPlan` and

[GitHub] [maven-surefire] Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-08-20 Thread GitBox
Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-523136911 > > > > Pls open the MOJO classes. You will see `rerunFailingTestsCount`. Extend the JavaDoc and add a new

[jira] [Commented] (MNGSITE-372) Profile activation documentation is out of date

2019-08-20 Thread Mirko Sertic (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911653#comment-16911653 ] Mirko Sertic commented on MNGSITE-372: -- I created one:) > Profile activation documentation is out

[GitHub] [maven-resolver] Tibor17 commented on issue #39: [MRESOLVER-93] - PathRecordingDependencyVisitor to handle 3 cycles

2019-08-20 Thread GitBox
Tibor17 commented on issue #39: [MRESOLVER-93] - PathRecordingDependencyVisitor to handle 3 cycles URL: https://github.com/apache/maven-resolver/pull/39#issuecomment-523154372 I expect more developers to join , but we may add one more commit later on. So that the line `paths.add(

[GitHub] [maven-surefire] Col-E commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-08-20 Thread GitBox
Col-E commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-523142533 > We of course have to mention JUnit 5 in JavaDoc. You can see the practice in another parameters that we say `Since

[jira] [Updated] (MRESOLVER-93) PathRecordingDependencyVisitor to handle 3 cycles

2019-08-20 Thread Tomo Suzuki (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomo Suzuki updated MRESOLVER-93: - Description: PathRecordingDependencyVisitor cannot handle dependency graphs that have 3 or

[jira] [Created] (MRESOLVER-93) PathRecordingDependencyVisitor to handle 3 cycles

2019-08-20 Thread Tomo Suzuki (Jira)
Tomo Suzuki created MRESOLVER-93: Summary: PathRecordingDependencyVisitor to handle 3 cycles Key: MRESOLVER-93 URL: https://issues.apache.org/jira/browse/MRESOLVER-93 Project: Maven Resolver

[jira] [Commented] (MNG-6741) Modules aggregation from parent does not work

2019-08-20 Thread Thomas Lehmann (Jira)
[ https://issues.apache.org/jira/browse/MNG-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911325#comment-16911325 ] Thomas Lehmann commented on MNG-6741: -- [^demo-maven-modules.zip] > Modules aggregation from parent

[jira] [Updated] (MNG-6741) Modules aggregation from parent does not work

2019-08-20 Thread Thomas Lehmann (Jira)
[ https://issues.apache.org/jira/browse/MNG-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Lehmann updated MNG-6741: Attachment: demo-maven-modules.zip > Modules aggregation from parent does not work >

[GitHub] [maven-dependency-plugin] Tibor17 commented on a change in pull request #19: [MDEP-579] - Add mirrors, proxies and authentication for remote repositories.

2019-08-20 Thread GitBox
Tibor17 commented on a change in pull request #19: [MDEP-579] - Add mirrors, proxies and authentication for remote repositories. URL: https://github.com/apache/maven-dependency-plugin/pull/19#discussion_r315694310 ## File path:

[jira] [Updated] (MRESOLVER-93) PathRecordingDependencyVisitor to handle 3 cycles

2019-08-20 Thread Tomo Suzuki (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomo Suzuki updated MRESOLVER-93: - Description: PathRecordingDependencyVisitor cannot handle dependency graphs that have 3 or

[GitHub] [maven-resolver] Tibor17 commented on issue #39: [MRESOLVER-93] - PathRecordingDependencyVisitor to handle 3 cycles

2019-08-20 Thread GitBox
Tibor17 commented on issue #39: [MRESOLVER-93] - PathRecordingDependencyVisitor to handle 3 cycles URL: https://github.com/apache/maven-resolver/pull/39#issuecomment-523064813 @suztomo In Jira the affect version is 1.4.1. We did not change this class. Was it the same issue in previous

[GitHub] [maven] Tibor17 commented on issue #262: [MNG-6695] Improve speed in collection merging

2019-08-20 Thread GitBox
Tibor17 commented on issue #262: [MNG-6695] Improve speed in collection merging URL: https://github.com/apache/maven/pull/262#issuecomment-523044018 We have to squash the commits and trigger the build last time before pushing to master.

[jira] [Updated] (MRESOLVER-93) PathRecordingDependencyVisitor to handle 3 cycles

2019-08-20 Thread Tomo Suzuki (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomo Suzuki updated MRESOLVER-93: - Description: PathRecordingDependencyVisitor cannot handle dependency graphs that have 3 or

[GitHub] [maven-dependency-plugin] pmoerenhout commented on a change in pull request #19: [MDEP-579] - Add mirrors, proxies and authentication for remote repositories.

2019-08-20 Thread GitBox
pmoerenhout commented on a change in pull request #19: [MDEP-579] - Add mirrors, proxies and authentication for remote repositories. URL: https://github.com/apache/maven-dependency-plugin/pull/19#discussion_r315763130 ## File path:

[GitHub] [maven-dependency-plugin] pmoerenhout commented on a change in pull request #19: [MDEP-579] - Add mirrors, proxies and authentication for remote repositories.

2019-08-20 Thread GitBox
pmoerenhout commented on a change in pull request #19: [MDEP-579] - Add mirrors, proxies and authentication for remote repositories. URL: https://github.com/apache/maven-dependency-plugin/pull/19#discussion_r315762920 ## File path:

[GitHub] [maven-dependency-plugin] pmoerenhout commented on a change in pull request #19: [MDEP-579] - Add mirrors, proxies and authentication for remote repositories.

2019-08-20 Thread GitBox
pmoerenhout commented on a change in pull request #19: [MDEP-579] - Add mirrors, proxies and authentication for remote repositories. URL: https://github.com/apache/maven-dependency-plugin/pull/19#discussion_r315763022 ## File path:

[GitHub] [maven-dependency-plugin] pmoerenhout commented on a change in pull request #19: [MDEP-579] - Add mirrors, proxies and authentication for remote repositories.

2019-08-20 Thread GitBox
pmoerenhout commented on a change in pull request #19: [MDEP-579] - Add mirrors, proxies and authentication for remote repositories. URL: https://github.com/apache/maven-dependency-plugin/pull/19#discussion_r315763348 ## File path: src/test/resources/unit/get-test/realm.properties

[GitHub] [maven-dependency-plugin] Tibor17 commented on a change in pull request #19: [MDEP-579] - Add mirrors, proxies and authentication for remote repositories.

2019-08-20 Thread GitBox
Tibor17 commented on a change in pull request #19: [MDEP-579] - Add mirrors, proxies and authentication for remote repositories. URL: https://github.com/apache/maven-dependency-plugin/pull/19#discussion_r315693715 ## File path:

[jira] [Closed] (MNG-6742) org.sonatype.maven.polyglot.TeslaModelProcessor.locatePom(File) ignores files ending in.xml

2019-08-20 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MNG-6742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MNG-6742. --- Assignee: Robert Scholte Resolution: Invalid As mentioned by [~mickael.istria], this is a

[GitHub] [maven-dependency-plugin] pmoerenhout opened a new pull request #19: [MDEP-579] - Add mirrors, proxies and authentication for remote repositories.

2019-08-20 Thread GitBox
pmoerenhout opened a new pull request #19: [MDEP-579] - Add mirrors, proxies and authentication for remote repositories. URL: https://github.com/apache/maven-dependency-plugin/pull/19 - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January

[GitHub] [maven-dependency-plugin] Tibor17 commented on a change in pull request #19: [MDEP-579] - Add mirrors, proxies and authentication for remote repositories.

2019-08-20 Thread GitBox
Tibor17 commented on a change in pull request #19: [MDEP-579] - Add mirrors, proxies and authentication for remote repositories. URL: https://github.com/apache/maven-dependency-plugin/pull/19#discussion_r315697110 ## File path:

[GitHub] [maven-dependency-plugin] Tibor17 commented on a change in pull request #19: [MDEP-579] - Add mirrors, proxies and authentication for remote repositories.

2019-08-20 Thread GitBox
Tibor17 commented on a change in pull request #19: [MDEP-579] - Add mirrors, proxies and authentication for remote repositories. URL: https://github.com/apache/maven-dependency-plugin/pull/19#discussion_r315697889 ## File path: src/test/resources/unit/get-test/realm.properties

[GitHub] [maven-dependency-plugin] Tibor17 commented on a change in pull request #19: [MDEP-579] - Add mirrors, proxies and authentication for remote repositories.

2019-08-20 Thread GitBox
Tibor17 commented on a change in pull request #19: [MDEP-579] - Add mirrors, proxies and authentication for remote repositories. URL: https://github.com/apache/maven-dependency-plugin/pull/19#discussion_r315697595 ## File path:

[jira] [Created] (SUREFIRE-1688) Junit Platform test with failing @BeforeAll does not fail the build

2019-08-20 Thread Guy Brand (Jira)
Guy Brand created SUREFIRE-1688: --- Summary: Junit Platform test with failing @BeforeAll does not fail the build Key: SUREFIRE-1688 URL: https://issues.apache.org/jira/browse/SUREFIRE-1688 Project: Maven

[jira] [Updated] (MRESOLVER-93) PathRecordingDependencyVisitor to handle 3 cycles

2019-08-20 Thread Tomo Suzuki (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomo Suzuki updated MRESOLVER-93: - Attachment: IMG_0266.jpg IMG_0265.jpg IMG_0264.jpg

[GitHub] [maven-resolver] suztomo commented on issue #39: [MRESOLVER-93] - PathRecordingDependencyVisitor to handle 3 cycles

2019-08-20 Thread GitBox
suztomo commented on issue #39: [MRESOLVER-93] - PathRecordingDependencyVisitor to handle 3 cycles URL: https://github.com/apache/maven-resolver/pull/39#issuecomment-523063825 @Tibor17 I've added illustration on why visited set does not work as expected in

[jira] [Commented] (MNG-6716) relative testSourceDirectory on macos throw duplicate class error

2019-08-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-6716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911485#comment-16911485 ] Hudson commented on MNG-6716: - Build succeeded in Jenkins: Maven TLP » maven » master #277 See

[jira] [Updated] (MRESOLVER-93) PathRecordingDependencyVisitor to handle 3 cycles

2019-08-20 Thread Tomo Suzuki (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomo Suzuki updated MRESOLVER-93: - Description: PathRecordingDependencyVisitor cannot handle dependency graphs that have 3 or

[jira] [Closed] (MPIR-376) LightweightHttpsWagon is always used

2019-08-20 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MPIR-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MPIR-376. --- Resolution: Fixed Fixed with

[jira] [Commented] (MNG-6742) org.sonatype.maven.polyglot.TeslaModelProcessor.locatePom(File) ignores files ending in.xml

2019-08-20 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-6742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911390#comment-16911390 ] Christoph Läubrich commented on MNG-6742: - okay, sorry for confusion, I opened

[jira] [Updated] (MRESOLVER-93) PathRecordingDependencyVisitor to handle 3 cycles

2019-08-20 Thread Tomo Suzuki (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomo Suzuki updated MRESOLVER-93: - Description: PathRecordingDependencyVisitor cannot handle dependency graphs that have 3 or

[jira] [Updated] (MRESOLVER-93) PathRecordingDependencyVisitor to handle 3 cycles

2019-08-20 Thread Tomo Suzuki (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomo Suzuki updated MRESOLVER-93: - Affects Version/s: 1.3.3 1.4.0 > PathRecordingDependencyVisitor to

[GitHub] [maven-resolver] suztomo commented on issue #39: [MRESOLVER-93] - PathRecordingDependencyVisitor to handle 3 cycles

2019-08-20 Thread GitBox
suztomo commented on issue #39: [MRESOLVER-93] - PathRecordingDependencyVisitor to handle 3 cycles URL: https://github.com/apache/maven-resolver/pull/39#issuecomment-523065669 (I picked up the highest version) I just updated to include 1.4.0 and 1.3.3 to mean the problem should be there

[jira] [Commented] (MNG-6742) org.sonatype.maven.polyglot.TeslaModelProcessor.locatePom(File) ignores files ending in.xml

2019-08-20 Thread Mickael Istria (Jira)
[ https://issues.apache.org/jira/browse/MNG-6742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911308#comment-16911308 ] Mickael Istria commented on MNG-6742: - Shouldn't it be reported to

[jira] [Commented] (MNG-6740) Provide a way to override properties of a polyglot build

2019-08-20 Thread Mickael Istria (Jira)
[ https://issues.apache.org/jira/browse/MNG-6740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911359#comment-16911359 ] Mickael Istria commented on MNG-6740: - Actually, it also looks like something that's not in Maven Core,

[jira] [Updated] (MRESOLVER-93) PathRecordingDependencyVisitor to handle 3 cycles

2019-08-20 Thread Tomo Suzuki (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomo Suzuki updated MRESOLVER-93: - Description: PathRecordingDependencyVisitor cannot handle dependency graphs that have 3 or

[jira] [Updated] (MRESOLVER-93) PathRecordingDependencyVisitor to handle 3 cycles

2019-08-20 Thread Tomo Suzuki (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomo Suzuki updated MRESOLVER-93: - Description: PathRecordingDependencyVisitor cannot handle dependency graphs that have 3 or

[jira] [Comment Edited] (MPIR-383) Error when generation site with dependency build with Java 9+

2019-08-20 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MPIR-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911518#comment-16911518 ] Michael Osipov edited comment on MPIR-383 at 8/20/19 4:26 PM: -- [~agaengel],

[jira] [Commented] (MPIR-383) Error when generation site with dependency build with Java 9+

2019-08-20 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MPIR-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911518#comment-16911518 ] Michael Osipov commented on MPIR-383: - [~agaengel], update the plugin dependency inline in your POM.

[GitHub] [maven-dependency-plugin] Tibor17 commented on a change in pull request #19: [MDEP-579] - Add mirrors, proxies and authentication for remote repositories.

2019-08-20 Thread GitBox
Tibor17 commented on a change in pull request #19: [MDEP-579] - Add mirrors, proxies and authentication for remote repositories. URL: https://github.com/apache/maven-dependency-plugin/pull/19#discussion_r315696215 ## File path:

[GitHub] [maven-resolver] suztomo opened a new pull request #39: [MRESOLVER-93] - PathRecordingDependencyVisitor to handle 3 cycles

2019-08-20 Thread GitBox
suztomo opened a new pull request #39: [MRESOLVER-93] - PathRecordingDependencyVisitor to handle 3 cycles URL: https://github.com/apache/maven-resolver/pull/39 Among 3 solutions I came up with for https://issues.apache.org/jira/browse/MRESOLVER-93, I choose the simplest solution of

[jira] [Updated] (MRESOLVER-93) PathRecordingDependencyVisitor to handle 3 cycles

2019-08-20 Thread Tomo Suzuki (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomo Suzuki updated MRESOLVER-93: - Description: PathRecordingDependencyVisitor cannot handle dependency graphs that have 3 or

[jira] [Commented] (MNG-6742) org.sonatype.maven.polyglot.TeslaModelProcessor.locatePom(File) ignores files ending in.xml

2019-08-20 Thread Mickael Istria (Jira)
[ https://issues.apache.org/jira/browse/MNG-6742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911283#comment-16911283 ] Mickael Istria commented on MNG-6742: - This is blocking

[jira] [Updated] (MRESOLVER-93) PathRecordingDependencyVisitor to handle 3 cycles

2019-08-20 Thread Tomo Suzuki (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomo Suzuki updated MRESOLVER-93: - Description: PathRecordingDependencyVisitor cannot handle dependency graphs that have 3 or

[GitHub] [maven-dependency-plugin] pmoerenhout commented on a change in pull request #19: [MDEP-579] - Add mirrors, proxies and authentication for remote repositories.

2019-08-20 Thread GitBox
pmoerenhout commented on a change in pull request #19: [MDEP-579] - Add mirrors, proxies and authentication for remote repositories. URL: https://github.com/apache/maven-dependency-plugin/pull/19#discussion_r315761851 ## File path: