[GitHub] [maven-resolver] caiwei-ebay edited a comment on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

2022-03-16 Thread GitBox
caiwei-ebay edited a comment on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1068901110 @michael-o @jebeaudet @cstamas With the skip solution, there will be less poms or jars, but not that much. As the skip solution just skip for version

[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #102: [MCOMPILER-402] Pass `implicit` configuration down to compiler

2022-03-16 Thread GitBox
pzygielo commented on pull request #102: URL: https://github.com/apache/maven-compiler-plugin/pull/102#issuecomment-1068851030 @olamy - thanks for checking (and pushing `plexus-*`es). This has now completed GH workflow and is marked as ready for review. I added

[GitHub] [maven-resolver] caiwei-ebay edited a comment on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

2022-03-16 Thread GitBox
caiwei-ebay edited a comment on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1068901110 @michael-o @jebeaudet @cstamas With the skip solution, there will be less poms or jars, but not that much. As the skip solution just skip for version

[GitHub] [maven-surefire] Tibor17 commented on pull request #490: [SUREFIRE-1964] Support for method filtering on excludesFile and includesFile

2022-03-16 Thread GitBox
Tibor17 commented on pull request #490: URL: https://github.com/apache/maven-surefire/pull/490#issuecomment-1068919541 @imonteroperez yes, exactly, I could not add your name to the reviewers because the combobox box provides only ASF staff. So I had only one option to ping you

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #490: [SUREFIRE-1964] Support for method filtering on excludesFile and includesFile

2022-03-16 Thread GitBox
Tibor17 edited a comment on pull request #490: URL: https://github.com/apache/maven-surefire/pull/490#issuecomment-1068919541 @imonteroperez yes, exactly, I could not add your name to the reviewers because the combobox box provides only ASF staff. So I had only one option to ping you

[jira] [Commented] (MCOMPILER-402) Not possible to exclude module-info with 'excludes'

2022-03-16 Thread Piotr Zygielo (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507407#comment-17507407 ] Piotr Zygielo commented on MCOMPILER-402: - {quote} essentially in the same way as described in

[jira] [Comment Edited] (MCOMPILER-402) Not possible to exclude module-info with 'excludes'

2022-03-16 Thread Piotr Zygielo (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507407#comment-17507407 ] Piotr Zygielo edited comment on MCOMPILER-402 at 3/16/22, 8:41 AM: ---

[GitHub] [maven-resolver] caiwei-ebay commented on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

2022-03-16 Thread GitBox
caiwei-ebay commented on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1068901110 @michael-o @jebeaudet @cstamas With the skip solution, there will be less poms or jars, but not that much. As the skip solution just skip for version conflict

[GitHub] [maven-resolver] caiwei-ebay edited a comment on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

2022-03-16 Thread GitBox
caiwei-ebay edited a comment on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1068901110 @michael-o @jebeaudet @cstamas With the skip solution, there will be less poms or jars, but not that much. As the skip solution just skip for version

[GitHub] [maven-surefire] Tibor17 commented on pull request #489: Stage site on GH actions

2022-03-16 Thread GitBox
Tibor17 commented on pull request #489: URL: https://github.com/apache/maven-surefire/pull/489#issuecomment-1068960752 @slawekjaranowski I understand `site:stage` but I want to ask you what benefit I should have. It would be great to see the HTML web content in GH project and check

[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #102: [MCOMPILER-402] Pass `implicit` configuration down to compiler

2022-03-16 Thread GitBox
pzygielo commented on pull request #102: URL: https://github.com/apache/maven-compiler-plugin/pull/102#issuecomment-1068875228 Changed my mind about updating example to _not needed_. Also - I think it was my mistake to use this ticket. Perhaps it would be better to have new _New

[GitHub] [maven-verifier] slawekjaranowski closed pull request #19: Bump maven-compat from 3.8.4 to 3.8.5

2022-03-16 Thread GitBox
slawekjaranowski closed pull request #19: URL: https://github.com/apache/maven-verifier/pull/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-verifier] dependabot[bot] commented on pull request #19: Bump maven-compat from 3.8.4 to 3.8.5

2022-03-16 Thread GitBox
dependabot[bot] commented on pull request #19: URL: https://github.com/apache/maven-verifier/pull/19#issuecomment-1068771077 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or

[GitHub] [maven-verifier] dependabot[bot] commented on pull request #18: Bump maven-resolver-connector-basic from 1.6.3 to 1.7.3

2022-03-16 Thread GitBox
dependabot[bot] commented on pull request #18: URL: https://github.com/apache/maven-verifier/pull/18#issuecomment-1068770893 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or

[GitHub] [maven-verifier] slawekjaranowski closed pull request #18: Bump maven-resolver-connector-basic from 1.6.3 to 1.7.3

2022-03-16 Thread GitBox
slawekjaranowski closed pull request #18: URL: https://github.com/apache/maven-verifier/pull/18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-resolver] caiwei-ebay edited a comment on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

2022-03-16 Thread GitBox
caiwei-ebay edited a comment on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1068901110 @michael-o @jebeaudet @cstamas With the skip solution, there will be less poms or jars, but not that much. As the skip solution just skip for version

[GitHub] [maven-pdf-plugin] dependabot[bot] opened a new pull request #21: Bump mavenVersion from 3.1.1 to 3.8.5

2022-03-16 Thread GitBox
dependabot[bot] opened a new pull request #21: URL: https://github.com/apache/maven-pdf-plugin/pull/21 Bumps `mavenVersion` from 3.1.1 to 3.8.5. Updates `maven-core` from 3.1.1 to 3.8.5 Release notes Sourced from https://github.com/apache/maven/releases;>maven-core's releases.

[GitHub] [maven-plugin-tools] dependabot[bot] opened a new pull request #76: Bump plexus-compiler-manager from 2.8.8 to 2.11.1

2022-03-16 Thread GitBox
dependabot[bot] opened a new pull request #76: URL: https://github.com/apache/maven-plugin-tools/pull/76 Bumps [plexus-compiler-manager](https://github.com/codehaus-plexus/plexus-compiler) from 2.8.8 to 2.11.1. Release notes Sourced from

[GitHub] [maven-plugin-tools] dependabot[bot] commented on pull request #70: Bump plexus-compiler-manager from 2.8.8 to 2.10.0

2022-03-16 Thread GitBox
dependabot[bot] commented on pull request #70: URL: https://github.com/apache/maven-plugin-tools/pull/70#issuecomment-1069151092 Superseded by #76. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven-plugin-tools] dependabot[bot] closed pull request #70: Bump plexus-compiler-manager from 2.8.8 to 2.10.0

2022-03-16 Thread GitBox
dependabot[bot] closed pull request #70: URL: https://github.com/apache/maven-plugin-tools/pull/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [maven-surefire] Tibor17 commented on pull request #489: Stage site on GH actions

2022-03-16 Thread GitBox
Tibor17 commented on pull request #489: URL: https://github.com/apache/maven-surefire/pull/489#issuecomment-1069204717 @slawekjaranowski I understand that zipping the web content is the first try which requires some extra work to check it. There is one more comfortable way with an

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #489: Stage site on GH actions

2022-03-16 Thread GitBox
Tibor17 edited a comment on pull request #489: URL: https://github.com/apache/maven-surefire/pull/489#issuecomment-1069204717 @slawekjaranowski I understand that zipping the web content is the first try which requires some extra work to check it. There is one more comfortable way

[GitHub] [maven-surefire] slawekjaranowski commented on pull request #489: Stage site on GH actions

2022-03-16 Thread GitBox
slawekjaranowski commented on pull request #489: URL: https://github.com/apache/maven-surefire/pull/489#issuecomment-1069026240 @Tibor17 Content of `target/stage` is uploaded as GH artifact ... please look at action result for this PR, there is:

[GitHub] [maven-plugin-tools] dependabot[bot] closed pull request #71: Bump mockito-core from 2.28.2 to 4.3.1

2022-03-16 Thread GitBox
dependabot[bot] closed pull request #71: URL: https://github.com/apache/maven-plugin-tools/pull/71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [maven-plugin-tools] dependabot[bot] opened a new pull request #75: Bump mockito-core from 2.28.2 to 4.4.0

2022-03-16 Thread GitBox
dependabot[bot] opened a new pull request #75: URL: https://github.com/apache/maven-plugin-tools/pull/75 Bumps [mockito-core](https://github.com/mockito/mockito) from 2.28.2 to 4.4.0. Release notes Sourced from https://github.com/mockito/mockito/releases;>mockito-core's

[GitHub] [maven-plugin-tools] dependabot[bot] commented on pull request #71: Bump mockito-core from 2.28.2 to 4.3.1

2022-03-16 Thread GitBox
dependabot[bot] commented on pull request #71: URL: https://github.com/apache/maven-plugin-tools/pull/71#issuecomment-1069144672 Superseded by #75. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (MNG-7431) Maven failed to download the plug-in

2022-03-16 Thread Delany (Jira)
[ https://issues.apache.org/jira/browse/MNG-7431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507566#comment-17507566 ] Delany commented on MNG-7431: - [~Tianci] send an email to us...@maven.apache.org > Maven failed to download

[jira] [Created] (MWRAPPER-61) let mvnw call mvn directly

2022-03-16 Thread James Z.M. Gao (Jira)
James Z.M. Gao created MWRAPPER-61: -- Summary: let mvnw call mvn directly Key: MWRAPPER-61 URL: https://issues.apache.org/jira/browse/MWRAPPER-61 Project: Maven Wrapper Issue Type:

[GitHub] [maven-wrapper] gzm55 opened a new pull request #33: MWRAPPER-61 Try to skip maven-wrapper.jar, call mvn directly from mvnw.

2022-03-16 Thread GitBox
gzm55 opened a new pull request #33: URL: https://github.com/apache/maven-wrapper/pull/33 1. most behavior is the same as maven-wrapper. 2. dists path pattern is shorten to `~/.m2/wrapper/dists/apache-maven-/` 3. follow posix shell, test on macos, centos 6/7/8, alpine with bash

[jira] [Commented] (MWRAPPER-61) let mvnw call mvn directly

2022-03-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507795#comment-17507795 ] ASF GitHub Bot commented on MWRAPPER-61: gzm55 opened a new pull request #33: URL:

[GitHub] [maven-resolver] cstamas commented on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

2022-03-16 Thread GitBox
cstamas commented on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1069252973 Tested on project w/ 134 modules (is not public), UTs/ITs were skipped: `mvn clean package -Dtest=void -Dit.test=void -s settings.xml` (settings: mirrorOf points to

[GitHub] [maven-filtering] dependabot[bot] opened a new pull request #30: Bump mockito-core from 2.28.2 to 4.4.0

2022-03-16 Thread GitBox
dependabot[bot] opened a new pull request #30: URL: https://github.com/apache/maven-filtering/pull/30 Bumps [mockito-core](https://github.com/mockito/mockito) from 2.28.2 to 4.4.0. Release notes Sourced from https://github.com/mockito/mockito/releases;>mockito-core's releases.

[GitHub] [maven] slawekjaranowski commented on a change in pull request #285: [MNG-5222] - Maven 3 no longer logs warnings about deprecated parameter in plugin

2022-03-16 Thread GitBox
slawekjaranowski commented on a change in pull request #285: URL: https://github.com/apache/maven/pull/285#discussion_r828223482 ## File path: maven-core/src/main/java/org/apache/maven/plugin/internal/ValidatingConfigurationListener.java ## @@ -68,21 +75,31 @@ public

[GitHub] [maven-surefire] slawekjaranowski commented on pull request #489: Stage site on GH actions

2022-03-16 Thread GitBox
slawekjaranowski commented on pull request #489: URL: https://github.com/apache/maven-surefire/pull/489#issuecomment-1069249942 GITHUB_TOKEN for PR build from fork has read-only access so will be not possible to store something in repo. Additionally we should manage many pages for

[GitHub] [maven-surefire] slawekjaranowski merged pull request #489: Stage site on GH actions

2022-03-16 Thread GitBox
slawekjaranowski merged pull request #489: URL: https://github.com/apache/maven-surefire/pull/489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MWRAPPER-61) let mvnw call mvn directly

2022-03-16 Thread James Z.M. Gao (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507743#comment-17507743 ] James Z.M. Gao commented on MWRAPPER-61: pr is here

[jira] [Commented] (MNG-7316) MavenProject.getAttachedArtifacts() regression with 3.8.1

2022-03-16 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/MNG-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507782#comment-17507782 ] Gary D. Gregory commented on MNG-7316: -- Hi Maven, The hack I went for is to call

[jira] [Commented] (MWRAPPER-59) Inline MavenWrapperDownloader.java into mvnw

2022-03-16 Thread James Z.M. Gao (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507694#comment-17507694 ] James Z.M. Gao commented on MWRAPPER-59: inline MavenWrapperDownloader.java and compile it on

[GitHub] [maven] slawekjaranowski commented on a change in pull request #285: [MNG-5222] - Maven 3 no longer logs warnings about deprecated parameter in plugin

2022-03-16 Thread GitBox
slawekjaranowski commented on a change in pull request #285: URL: https://github.com/apache/maven/pull/285#discussion_r828208205 ## File path: maven-core/src/main/java/org/apache/maven/plugin/internal/ValidatingConfigurationListener.java ## @@ -39,14 +43,17 @@ private

[jira] [Commented] (MNG-7316) MavenProject.getAttachedArtifacts() regression with 3.8.1

2022-03-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507819#comment-17507819 ] Michael Osipov commented on MNG-7316: - The main question has not been answered: Why attach and detach?

[GitHub] [maven-filtering] dependabot[bot] commented on pull request #27: Bump mockito-core from 2.28.2 to 4.3.1

2022-03-16 Thread GitBox
dependabot[bot] commented on pull request #27: URL: https://github.com/apache/maven-filtering/pull/27#issuecomment-1069398811 Superseded by #30. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-resolver] cstamas commented on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

2022-03-16 Thread GitBox
cstamas commented on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1069591342 Am getting consistently slower results (2nd, 3rd run), but unsure is it skipper or BFS that is on master? @caiwei-ebay could you tell more about those projects you

[GitHub] [maven-wrapper] hboutemy opened a new pull request #34: add NOTICE file with attribution of initial maven-wrapper module

2022-03-16 Thread GitBox
hboutemy opened a new pull request #34: URL: https://github.com/apache/maven-wrapper/pull/34 see initial commit from 2013 https://github.com/apache/maven-wrapper/commit/fa267d489f0950daf6825dcdd17ddb4de9ad9a20 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [maven-surefire] aslakhellesoy commented on pull request #169: [SUREFIRE-1405] Allows user to extend RunOrder & RunOrderCalculator

2022-03-16 Thread GitBox
aslakhellesoy commented on pull request #169: URL: https://github.com/apache/maven-surefire/pull/169#issuecomment-1069639021 @Tibor17 I'm interested in helping out to move this forward. Given that the master branch has moved on significantly since this @dipak-pawar submitted this

[GitHub] [maven-resolver] cstamas commented on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

2022-03-16 Thread GitBox
cstamas commented on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1069570376 Project: maven master 31193cbf0c93205a63c8c7b372b09200f60e69f4 As before (3 runs, 1st run with empty repo) but now not using local repoMan, going directly for Maven

[GitHub] [maven-resolver] cstamas edited a comment on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

2022-03-16 Thread GitBox
cstamas edited a comment on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1069591342 Am getting consistently slower results (2nd, 3rd run), but unsure is it skipper or BFS that is on master? @caiwei-ebay could you tell more about those

[jira] [Commented] (MRELEASE-1081) Update plexus-interactivity to version 1.1

2022-03-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507862#comment-17507862 ] Michael Osipov commented on MRELEASE-1081: -- That was rather a note to myself that Plexus

[GitHub] [maven-resolver] caiwei-ebay edited a comment on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

2022-03-16 Thread GitBox
caiwei-ebay edited a comment on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1069797740 > Am getting consistently slower results (2nd, 3rd run), but unsure is it skipper or BFS that is on master? > > @caiwei-ebay could you tell more about

[GitHub] [maven-jlink-plugin] dependabot[bot] opened a new pull request #101: Bump maven-project-info-reports-plugin from 3.1.2 to 3.2.2

2022-03-16 Thread GitBox
dependabot[bot] opened a new pull request #101: URL: https://github.com/apache/maven-jlink-plugin/pull/101 Bumps [maven-project-info-reports-plugin](https://github.com/apache/maven-project-info-reports-plugin) from 3.1.2 to 3.2.2. Commits

[GitHub] [maven-apache-parent] dependabot[bot] opened a new pull request #74: Bump maven-compiler-plugin from 3.10.0 to 3.10.1

2022-03-16 Thread GitBox
dependabot[bot] opened a new pull request #74: URL: https://github.com/apache/maven-apache-parent/pull/74 Bumps [maven-compiler-plugin](https://github.com/apache/maven-compiler-plugin) from 3.10.0 to 3.10.1. Release notes Sourced from

[GitHub] [maven-jlink-plugin] dependabot[bot] closed pull request #94: Bump maven-project-info-reports-plugin from 3.1.2 to 3.2.1

2022-03-16 Thread GitBox
dependabot[bot] closed pull request #94: URL: https://github.com/apache/maven-jlink-plugin/pull/94 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [maven-jlink-plugin] dependabot[bot] commented on pull request #94: Bump maven-project-info-reports-plugin from 3.1.2 to 3.2.1

2022-03-16 Thread GitBox
dependabot[bot] commented on pull request #94: URL: https://github.com/apache/maven-jlink-plugin/pull/94#issuecomment-1070307506 Superseded by #101. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Created] (MNG-7433) multiple maven instances working same source tree can lock each other

2022-03-16 Thread Dan Tran (Jira)
Dan Tran created MNG-7433: - Summary: multiple maven instances working same source tree can lock each other Key: MNG-7433 URL: https://issues.apache.org/jira/browse/MNG-7433 Project: Maven Issue

[GitHub] [maven-indexer] dependabot[bot] opened a new pull request #188: Bump maven-parent from 34 to 35

2022-03-16 Thread GitBox
dependabot[bot] opened a new pull request #188: URL: https://github.com/apache/maven-indexer/pull/188 Bumps [maven-parent](https://github.com/apache/maven-parent) from 34 to 35. Commits See full diff in https://github.com/apache/maven-parent/commits;>compare view

[jira] [Commented] (ARCHETYPE-505) archetype:create-from-project,the .gitignore file not copy to archetype-resources

2022-03-16 Thread George Snyder Fedins (Jira)
[ https://issues.apache.org/jira/browse/ARCHETYPE-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507855#comment-17507855 ] George Snyder Fedins commented on ARCHETYPE-505: To provide another workaround, I am

[GitHub] [maven-dependency-plugin] dependabot[bot] opened a new pull request #208: Bump org.eclipse.sisu.plexus from 0.0.0.M5 to 0.3.5

2022-03-16 Thread GitBox
dependabot[bot] opened a new pull request #208: URL: https://github.com/apache/maven-dependency-plugin/pull/208 Bumps org.eclipse.sisu.plexus from 0.0.0.M5 to 0.3.5. [![Dependabot compatibility

[GitHub] [maven-resolver] caiwei-ebay edited a comment on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

2022-03-16 Thread GitBox
caiwei-ebay edited a comment on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1069797740 > Am getting consistently slower results (2nd, 3rd run), but unsure is it skipper or BFS that is on master? > > @caiwei-ebay could you tell more about

[GitHub] [maven-surefire] Tibor17 commented on pull request #169: [SUREFIRE-1405] Allows user to extend RunOrder & RunOrderCalculator

2022-03-16 Thread GitBox
Tibor17 commented on pull request #169: URL: https://github.com/apache/maven-surefire/pull/169#issuecomment-1069739881 @aslakhellesoy It should be taken very carefully because there is another similar requirement with run order in #348. It would be nice if you would agree with

[GitHub] [maven-surefire] olamy commented on pull request #490: [SUREFIRE-1964] Support for method filtering on excludesFile and includesFile

2022-03-16 Thread GitBox
olamy commented on pull request #490: URL: https://github.com/apache/maven-surefire/pull/490#issuecomment-1069812853 > LGTM as long as @imonteroperez is happy with that I'm happy too. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [maven-resolver] caiwei-ebay edited a comment on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

2022-03-16 Thread GitBox
caiwei-ebay edited a comment on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1069797740 > Am getting consistently slower results (2nd, 3rd run), but unsure is it skipper or BFS that is on master? > > @caiwei-ebay could you tell more about

[GitHub] [maven-mvnd] Gaming32 commented on issue #607: `mvnd.exe` gives error about DLL

2022-03-16 Thread GitBox
Gaming32 commented on issue #607: URL: https://github.com/apache/maven-mvnd/issues/607#issuecomment-1069754471 Go here and scroll down a little for a fix: https://github.com/apache/maven-mvnd#install-manually. -- This is an automated message from the Apache Git Service. To respond to

[jira] (MWRAPPER-61) let mvnw call mvn directly

2022-03-16 Thread James Z.M. Gao (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-61 ] James Z.M. Gao deleted comment on MWRAPPER-61: was (Author: gzm55): pr is here https://github.com/apache/maven-wrapper/pull/33 > let mvnw call mvn directly > --

[GitHub] [maven-compiler-plugin] olamy commented on pull request #102: [MCOMPILER-402] Pass `implicit` configuration down to compiler

2022-03-16 Thread GitBox
olamy commented on pull request #102: URL: https://github.com/apache/maven-compiler-plugin/pull/102#issuecomment-1069887523 > Changed my mind about updating example to _not needed_. > > Also - I think it was my mistake to use this ticket. Perhaps it would be better to have new _New

[GitHub] [maven-compiler-plugin] olamy edited a comment on pull request #102: [MCOMPILER-402] Pass `implicit` configuration down to compiler

2022-03-16 Thread GitBox
olamy edited a comment on pull request #102: URL: https://github.com/apache/maven-compiler-plugin/pull/102#issuecomment-1069887523 > Changed my mind about updating example to _not needed_. > > Also - I think it was my mistake to use this ticket. Perhaps it would be better to have

[GitHub] [maven-surefire] Tibor17 commented on pull request #169: [SUREFIRE-1405] Allows user to extend RunOrder & RunOrderCalculator

2022-03-16 Thread GitBox
Tibor17 commented on pull request #169: URL: https://github.com/apache/maven-surefire/pull/169#issuecomment-1069741527 Additionally, we should not use `Collection> scannedClasses` because the JUnit5 has abstract description of test and they can be also scripts, so the time has changed and

[GitHub] [maven-resolver] caiwei-ebay commented on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

2022-03-16 Thread GitBox
caiwei-ebay commented on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1069797740 > Am getting consistently slower results (2nd, 3rd run), but unsure is it skipper or BFS that is on master? > > @caiwei-ebay could you tell more about those

[GitHub] [maven-resolver] caiwei-ebay edited a comment on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

2022-03-16 Thread GitBox
caiwei-ebay edited a comment on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1068901110 @michael-o @jebeaudet @cstamas With the skip solution, there will be less poms or jars, but not that much. As the skip solution just skip for version

[GitHub] [maven] belingueres commented on a change in pull request #285: [MNG-5222] - Maven 3 no longer logs warnings about deprecated parameter in plugin

2022-03-16 Thread GitBox
belingueres commented on a change in pull request #285: URL: https://github.com/apache/maven/pull/285#discussion_r828724258 ## File path: maven-core/src/main/java/org/apache/maven/plugin/internal/ValidatingConfigurationListener.java ## @@ -39,14 +43,17 @@ private final