[jira] [Commented] (SUREFIRE-1372) Rerunning failing tests fails in combination with Description#createSuiteDescription

2017-12-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302590#comment-16302590 ] ASF GitHub Bot commented on SUREFIRE-1372: -- Github user Tibor17 commented on a diff in the

[GitHub] maven-surefire pull request #150: SUREFIRE-1372 Filter tests to be rerun by ...

2017-12-23 Thread Tibor17
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/150#discussion_r158589504 --- Diff: surefire-providers/surefire-junit4/src/main/java/org/apache/maven/surefire/junit4/JUnit4Provider.java --- @@ -55,7 +53,8 @@ import

[jira] [Commented] (SUREFIRE-1372) Rerunning failing tests fails in combination with Description#createSuiteDescription

2017-12-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302586#comment-16302586 ] ASF GitHub Bot commented on SUREFIRE-1372: -- Github user mpkorstanje commented on the issue:

[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...

2017-12-23 Thread mpkorstanje
Github user mpkorstanje commented on the issue: https://github.com/apache/maven-surefire/pull/150 @Tibor17 `MatchDescriptions` uses `Filter.matchMethodDescription` which does not exist in junit4. It would make the junit 4 version of `MatchDescriptions` divergent enough to

[jira] [Commented] (SUREFIRE-1372) Rerunning failing tests fails in combination with Description#createSuiteDescription

2017-12-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302584#comment-16302584 ] ASF GitHub Bot commented on SUREFIRE-1372: -- Github user Tibor17 commented on the issue:

[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...

2017-12-23 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/150 The fast way would be to give it a try in a copy of your project apart and run the local build "mvn install -P run-its -Dcheckstyle.skip=true". Even if you copied FilterFactory

[jira] [Commented] (SUREFIRE-1372) Rerunning failing tests fails in combination with Description#createSuiteDescription

2017-12-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302577#comment-16302577 ] ASF GitHub Bot commented on SUREFIRE-1372: -- Github user mpkorstanje commented on the issue:

[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...

2017-12-23 Thread mpkorstanje
Github user mpkorstanje commented on the issue: https://github.com/apache/maven-surefire/pull/150 > Can you write the documentation? Done. >Fix the checkstyle in your integration test and the classes FlakeCucumberTest. I seem to be unable to get checkstyle to

[jira] [Commented] (SUREFIRE-1372) Rerunning failing tests fails in combination with Description#createSuiteDescription

2017-12-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302574#comment-16302574 ] ASF GitHub Bot commented on SUREFIRE-1372: -- Github user mpkorstanje commented on the issue:

[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...

2017-12-23 Thread mpkorstanje
Github user mpkorstanje commented on the issue: https://github.com/apache/maven-surefire/pull/150 @Tibor17 that should be doable. Replacing the inner most loop in the `JUnit4Provider.executeWithRerun` with the code below should do it. This would require the `FilterFactory` to be

[jira] [Commented] (SUREFIRE-1372) Rerunning failing tests fails in combination with Description#createSuiteDescription

2017-12-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302545#comment-16302545 ] ASF GitHub Bot commented on SUREFIRE-1372: -- Github user Tibor17 commented on the issue:

[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...

2017-12-23 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/150 @mpkorstanje After seen the code of junit4 provider I have realized that `Filter` also exists in JUnit4. Therefore maybe using a combination of class/method and using JUnit's Request

[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...

2017-12-23 Thread mpkorstanje
Github user mpkorstanje commented on the issue: https://github.com/apache/maven-surefire/pull/150 > Then try to alter the behavior of the integration test with Maven profile (junit4 and junit47). We are already doing it, see addGoal( "-P junit4" ), addGoal( "-P junit47" ). >

[jira] [Commented] (SUREFIRE-1372) Rerunning failing tests fails in combination with Description#createSuiteDescription

2017-12-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302531#comment-16302531 ] ASF GitHub Bot commented on SUREFIRE-1372: -- Github user mpkorstanje commented on the issue:

[jira] [Commented] (MSHARED-668) plexus-utils 3.0.24 to 3.1.0

2017-12-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MSHARED-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302516#comment-16302516 ] Hudson commented on MSHARED-668: Build unstable in Jenkins: Maven TLP » maven-archiver » master #4 See

[jira] [Commented] (MSHARED-667) plexus-utils 3.0.24 to 3.1.0

2017-12-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MSHARED-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302515#comment-16302515 ] Hudson commented on MSHARED-667: Build succeeded in Jenkins: Maven TLP » maven-filtering » master #2 See

[jira] [Created] (MSHARED-668) plexus-utils 3.0.24 to 3.1.0

2017-12-23 Thread Karl Heinz Marbaise (JIRA)
Karl Heinz Marbaise created MSHARED-668: --- Summary: plexus-utils 3.0.24 to 3.1.0 Key: MSHARED-668 URL: https://issues.apache.org/jira/browse/MSHARED-668 Project: Maven Shared Components

[jira] [Created] (MSHARED-667) plexus-utils 3.0.24 to 3.1.0

2017-12-23 Thread Karl Heinz Marbaise (JIRA)
Karl Heinz Marbaise created MSHARED-667: --- Summary: plexus-utils 3.0.24 to 3.1.0 Key: MSHARED-667 URL: https://issues.apache.org/jira/browse/MSHARED-667 Project: Maven Shared Components

[jira] [Commented] (MSITE-791) upgrade Doxia to 1.8 to benefit from new Markdown parser (require Java 7)

2017-12-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MSITE-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302369#comment-16302369 ] Hudson commented on MSITE-791: -- Build succeeded in Jenkins: Maven TLP » maven-site-plugin » master #16 See

[jira] [Created] (MRELEASE-995) prepare-with-pom doesn't copy comments like license header

2017-12-23 Thread Robert Scholte (JIRA)
Robert Scholte created MRELEASE-995: --- Summary: prepare-with-pom doesn't copy comments like license header Key: MRELEASE-995 URL: https://issues.apache.org/jira/browse/MRELEASE-995 Project: Maven

[jira] [Commented] (MPMD-249) The plugin documentation point to old (deprecated) rulesets

2017-12-23 Thread JIRA
[ https://issues.apache.org/jira/browse/MPMD-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302347#comment-16302347 ] Hervé Boutemy commented on MPMD-249: this link is taken from java source: it won't be easy to update it

[jira] [Commented] (MRESOLVER-39) deadlock during multithreaded dependency resolution

2017-12-23 Thread Robert Scholte (JIRA)
[ https://issues.apache.org/jira/browse/MRESOLVER-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302316#comment-16302316 ] Robert Scholte commented on MRESOLVER-39: - Great work! Now looking at it, that commit contains