[jira] [Updated] (MCHANGES-388) Add option to include issues using the -SNAPSHOT suffix for version/milestone

2018-05-12 Thread Marcelo Riss (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MCHANGES-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcelo Riss updated MCHANGES-388:
--
Attachment: pom.xml

> Add option to include issues using the -SNAPSHOT suffix for version/milestone
> -
>
> Key: MCHANGES-388
> URL: https://issues.apache.org/jira/browse/MCHANGES-388
> Project: Maven Changes Plugin
>  Issue Type: Wish
>  Components: github
>Reporter: Marcelo Riss
>Priority: Minor
> Attachments: pom.xml
>
>
> I have a use case where the version id/name at the issue tracking system 
> (GHE) will have the -SNAPSHOT suffix. Currently, when setting GHE as issue 
> tracking system and the parameter 
> *[onlyCurrentVersion|http://maven.apache.org/plugins/maven-changes-plugin/github-report-mojo.html#onlyCurrentVersion]*
>  to true, the -SNAPSHOT suffix is removed when filtering the issues. My 
> suggestion is to add a configuration parameter allowing to consider or not 
> the -SNAPSHOT suffix as the version id/name when searching for issues. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MCHANGES-388) Add option to include issues using the -SNAPSHOT suffix for version/milestone

2018-05-12 Thread Marcelo Riss (JIRA) 

[ 
https://issues.apache.org/jira/browse/MCHANGES-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473306#comment-16473306
 ] 

Marcelo Riss commented on MCHANGES-388:
---

Adding a sample pom.xm file, showing how this flag is intended to be used. For 
snapshots, we manually call {{mvn -P snapshot,announcement clean install}}. For 
official releases, the {{announcement}} and {{release}} profiles are 
automatically added to the {{}} configuration section at maven 
release plugin.

> Add option to include issues using the -SNAPSHOT suffix for version/milestone
> -
>
> Key: MCHANGES-388
> URL: https://issues.apache.org/jira/browse/MCHANGES-388
> Project: Maven Changes Plugin
>  Issue Type: Wish
>  Components: github
>Reporter: Marcelo Riss
>Priority: Minor
>
> I have a use case where the version id/name at the issue tracking system 
> (GHE) will have the -SNAPSHOT suffix. Currently, when setting GHE as issue 
> tracking system and the parameter 
> *[onlyCurrentVersion|http://maven.apache.org/plugins/maven-changes-plugin/github-report-mojo.html#onlyCurrentVersion]*
>  to true, the -SNAPSHOT suffix is removed when filtering the issues. My 
> suggestion is to add a configuration parameter allowing to consider or not 
> the -SNAPSHOT suffix as the version id/name when searching for issues. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6411) Improve readability of project list returned when resume from flag is invalid

2018-05-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/MNG-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473300#comment-16473300
 ] 

ASF GitHub Bot commented on MNG-6411:
-

michael-o commented on a change in pull request #164: [MNG-6411] Improve 
readability of project list for resume option.
URL: https://github.com/apache/maven/pull/164#discussion_r187785443
 
 

 ##
 File path: 
maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
 ##
 @@ -311,13 +311,29 @@ else if ( StringUtils.isNotEmpty( 
request.getMakeBehavior() ) )
 if ( !resumed )
 {
 throw new MavenExecutionException( "Could not find project to 
resume reactor build from: " + selector
-+ " vs " + projects, request.getPom() );
++ " vs " + formatProjects( projects ), request.getPom() );
 }
 }
 
 return result;
 }
 
+private String formatProjects( List projects )
+{
+StringBuilder projectNames = new StringBuilder();
+for ( int index = 0, size = projects.size(); index < size; index++ )
+{
+MavenProject project = projects.get( index );
 
 Review comment:
   Don't iterate lists with indexes, use foreach or iterators instead.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improve readability of project list returned when resume from flag is invalid
> -
>
> Key: MNG-6411
> URL: https://issues.apache.org/jira/browse/MNG-6411
> Project: Maven
>  Issue Type: Improvement
>Affects Versions: 3.5.3
>Reporter: Łukasz Dywicki
>Priority: Minor
> Fix For: 3.5.4-candidate
>
>
> When value passed for {{-rf}} option is invalid a full list of details of all 
> projects in build is returned.
> This list contains too much information. For every project it includes 
> groupId, artifactId, version and pom location. While it is useful for 
> debugging purposes many, if not most, developers are interested in specific 
> coordinate (groupId:artifactId) which should be passed to next execution, and 
> which is valid {{-rf}} optiona value.
> Note tat below outputs contain new lines for ease of read. This could be also 
> added to exception message to make it more readable.
> Assuming, that I've passed -rf :x Current output in case of failure:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
>   MavenProject: com.example:foobar:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/pom.xml,
>   MavenProject: com.example.foobar:parent:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/parent/pom.xml,
>   MavenProject: com.example.foobar:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/api/pom.xml,
>   MavenProject: com.example.foobar:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/model/pom.xml,
>   MavenProject: com.example.foobar:csv:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/pom.xml,
>   MavenProject: com.example.foobar.csv:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/model/pom.xml,
>   MavenProject: com.example.foobar.csv:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/api/pom.xml,
>   MavenProject: com.example.foobar:json:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/pom.xml,
>   MavenProject: com.example.foobar.json:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/model/pom.xml,
>   MavenProject: com.example.foobar.json:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/api/pom.xml,
>   MavenProject: com.example.foobar.json:core:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/core/pom.xml,
>   MavenProject: com.example.foobar:fax:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/pom.xml,
>   MavenProject: com.example.foobar.fax:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/api/pom.xml,
>   MavenProject: com.example.foobar.fax:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/model/pom.xml,
>   MavenProject: com.example.foobar.fax:web:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/pom.xml,
>   MavenProject: com.example.foobar.fax.web:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/api/pom.xml,
>   MavenProject: com.example.foobar.fax.web:core:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/core/pom.xml] -> [Help 1]
> {noformat}
> Additional information about pom locations is irrelevant from message point 
> of view, because valid input for -rf option is presented below:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
>   com.example:foobar,
>   com.example.foobar:parent,
>   com.example.foobar:api,
>

[GitHub] michael-o commented on a change in pull request #164: [MNG-6411] Improve readability of project list for resume option.

2018-05-12 Thread GitBox 
michael-o commented on a change in pull request #164: [MNG-6411] Improve 
readability of project list for resume option.
URL: https://github.com/apache/maven/pull/164#discussion_r187785443
 
 

 ##
 File path: 
maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
 ##
 @@ -311,13 +311,29 @@ else if ( StringUtils.isNotEmpty( 
request.getMakeBehavior() ) )
 if ( !resumed )
 {
 throw new MavenExecutionException( "Could not find project to 
resume reactor build from: " + selector
-+ " vs " + projects, request.getPom() );
++ " vs " + formatProjects( projects ), request.getPom() );
 }
 }
 
 return result;
 }
 
+private String formatProjects( List projects )
+{
+StringBuilder projectNames = new StringBuilder();
+for ( int index = 0, size = projects.size(); index < size; index++ )
+{
+MavenProject project = projects.get( index );
 
 Review comment:
   Don't iterate lists with indexes, use foreach or iterators instead.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MCOMPILER-341) Compile module-info.java files located in test sources

2018-05-12 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/MCOMPILER-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473299#comment-16473299
 ] 

Hudson commented on MCOMPILER-341:
--

Build succeeded in Jenkins: Maven TLP » maven-compiler-plugin » MCOMPILER-341 #4

See 
https://builds.apache.org/job/maven-box/job/maven-compiler-plugin/job/MCOMPILER-341/4/

> Compile module-info.java files located in test sources
> --
>
> Key: MCOMPILER-341
> URL: https://issues.apache.org/jira/browse/MCOMPILER-341
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Affects Versions: 3.7.0
>Reporter: Christian Stein
>Priority: Minor
>  Labels: pull-request-available
>
> Support compilation of projects with test sources containing modules – along 
> with explicit module descriptors ({{module-info.java}} files).
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-886) Tests with checkin rely on global git config

2018-05-12 Thread Michael Osipov (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473296#comment-16473296
 ] 

Michael Osipov commented on SCM-886:


I can reproduce this now:

{noformat}
Failed tests:
  
GitExeBlameCommandTckTest.testBlameCommand:44->BlameCommandTckTest.testBlameCommand:73
 Unable to checkin changes to the repository
  
GitExeBranchCommandTckTest>BranchCommandTckTest.testBranchCommandTest:73->ScmTestCase.assertResultIsSuccess:208
 The check out result success flag was false.
  GitExeChangeLogCommandTckTest>ChangeLogCommandTckTest.testChangeLogCommand:76 
Unable to checkin changes to the repository
  
GitCheckInCommandNoBranchTest.testCheckinNoBranch:75->ScmTestCase.assertResultIsSuccess:208
 The check out result success flag was false.
  
GitCheckInCommandTest.testCheckinAfterRename:113->ScmTestCase.assertResultIsSuccess:208
 The check out result success flag was false.
  
GitExeCheckInCommandTckTest>CheckInCommandTckTest.testCheckInCommandPartialFileset:149->ScmTestCase.assertResultIsSuccess:208
 The check out result success flag was false.
  
GitExeCheckInCommandTckTest>CheckInCommandTckTest.testCheckInCommandTest:78->ScmTestCase.assertResultIsSuccess:208
 The check out result success flag was false.
  
GitExeStatusCommandTckTest>StatusCommandTckTest.testStatusCommand:102->StatusCommandTckTest.commit:64
 Check result was successful, output:
*** Please tell me who you are.

Run

  git config --global user.email "y...@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: no email was given and auto-detection is disabled

  
GitExeTagCommandTckTest>TagCommandTckTest.testTagCommandTest:58->ScmTestCase.assertResultIsSuccess:208
 The check out result success flag was false.
  
GitExeUpdateCommandTckTest>UpdateCommandTckTest.testUpdateCommand:131->UpdateCommandTckTest.commit:67
 Check result was successful, output:
*** Please tell me who you are.

Run

  git config --global user.email "y...@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: no email was given and auto-detection is disabled


Tests run: 82, Failures: 10, Errors: 0, Skipped: 1
{noformat}

Do you think you could provide a fix? I guess a static {{.git/config}} in the 
test repo shall be enough.

> Tests with checkin rely on global git config
> 
>
> Key: SCM-886
> URL: https://issues.apache.org/jira/browse/SCM-886
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Priority: Major
>
> Inside maven-scm-provider-gitexe project, the two following tests 
> `GitCheckInCommandNoBranchTest.testCheckinNoBranch` and 
> `GitCheckInCommandTest.testCheckinAfterRename` expect a global user.name and 
> user.email to be set.
> On installations where .gitconfig contains the following:
> {{[user]}}
> {{useConfigOnly = true}}
> The tests will fail.
> It would be better after repository creation to configure a user name & email 
> at project level.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set

2018-05-12 Thread Matthieu Brouillard (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473232#comment-16473232
 ] 

Matthieu Brouillard commented on SCM-885:
-

With the patch it is clear that calling GitChangeLogCommand#createCommandLine() 
with a null startVersion will not result anymore in issuing the git log command 
`..EndVersion` and thus will not result anymore in being interpreted by 
`HEAD..EndVersion`.

But still, the ones who will want to retrieve the log between HEAD and 
EndVersion will be able to do so by explicitly use "HEAD" as the start version. 
Additionaly the ones, like me, expecting to be able to query the log between 
the initial commit (unknown/null startVersion) of a repository and a given 
commit (even HEAD) can do it.

Instead of changing the interpretation like the patch does perhaps that you 
prefer a new API to allow to query from the origin(first commit). This way the 
enhancement will be backward compatible (even if non intuitive IMHO).

The use case for me is that we have a maven-plugin (that delegates to maven-scm 
API) to compute between two calls what has changed in term of commits on a 
project. But the first time we query the log we have no initial commit (thus 
starVersion null) and we want the log between the inital commit and HEAD.

> GitChangeLogCommand is wrong when only endVersion is set
> 
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has 
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso  ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso  END_REVISION_SHA1 -- PROJECT_PATH}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-886) Tests with checkin rely on global git config

2018-05-12 Thread Matthieu Brouillard (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473216#comment-16473216
 ] 

Matthieu Brouillard commented on SCM-886:
-

Make sure that you also do not have already launched a `git config user.email` 
and `git config user.name` on the working repository.

I saw the error because on my setup I have globally

[user]
useConfigOnly = true
name = Matthieu Brouillard

Notice that the `user.email` is missing globally. This prevents me to commit on 
repositories without configuring correctly the email I want for the particular 
repository. So in order to commit to any repository, I need to do a `git config 
user.email` at the repository level ; which I had not done on maven-scm project 
and that implied some tests to fail (then ones doing commits).

> Tests with checkin rely on global git config
> 
>
> Key: SCM-886
> URL: https://issues.apache.org/jira/browse/SCM-886
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Priority: Major
>
> Inside maven-scm-provider-gitexe project, the two following tests 
> `GitCheckInCommandNoBranchTest.testCheckinNoBranch` and 
> `GitCheckInCommandTest.testCheckinAfterRename` expect a global user.name and 
> user.email to be set.
> On installations where .gitconfig contains the following:
> {{[user]}}
> {{useConfigOnly = true}}
> The tests will fail.
> It would be better after repository creation to configure a user name & email 
> at project level.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] sormuras commented on a change in pull request #4: Introduce white-box testing modules

2018-05-12 Thread GitBox 
sormuras commented on a change in pull request #4: Introduce white-box testing 
modules
URL: 
https://github.com/apache/maven-compiler-plugin/pull/4#discussion_r187774737
 
 

 ##
 File path: src/it/jpms_compile-test-modules/verify.groovy
 ##
 @@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ * 
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+def jpmsArgs = new File( basedir, 'target/test-classes/META-INF/jpms.args' )
+def lines = jpmsArgs.readLines()
+assert lines[0] == "--patch-module" // TODO --patch-module is not required 
here!
+assert lines[1] == "foo="
 
 Review comment:
   `foo=` points to an empty value. It shoud point to the `src/main/java` 
directory.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sormuras commented on a change in pull request #4: Introduce white-box testing modules

2018-05-12 Thread GitBox 
sormuras commented on a change in pull request #4: Introduce white-box testing 
modules
URL: 
https://github.com/apache/maven-compiler-plugin/pull/4#discussion_r187774737
 
 

 ##
 File path: src/it/jpms_compile-test-modules/verify.groovy
 ##
 @@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ * 
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+def jpmsArgs = new File( basedir, 'target/test-classes/META-INF/jpms.args' )
+def lines = jpmsArgs.readLines()
+assert lines[0] == "--patch-module" // TODO --patch-module is not required 
here!
+assert lines[1] == "foo="
 
 Review comment:
   `foo=` shouldn't point to an empty value. It points to the `src/main/java` 
directory.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sormuras commented on a change in pull request #4: Introduce white-box testing modules

2018-05-12 Thread GitBox 
sormuras commented on a change in pull request #4: Introduce white-box testing 
modules
URL: 
https://github.com/apache/maven-compiler-plugin/pull/4#discussion_r187774685
 
 

 ##
 File path: src/it/jpms_compile-test-modules/src/test/java/foo/FooTests.java
 ##
 @@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package foo;
+
+import org.junit.jupiter.api.*;
+
+class FooTests
+{
+@Test
+void constructor()
+{
+Assertions.assertNotNull( new Foo() );
+}
+
+@Test
+void moduleNameIsFoo()
+{
+Assumptions.assumeTrue( Foo.class.getModule().isNamed(), "Calculator 
resides in a named module" );
 
 Review comment:
   Fix copy and paste error: `Foo` it is, not `Calculator`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MCOMPILER-341) Compile module-info.java files located in test sources

2018-05-12 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/MCOMPILER-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473109#comment-16473109
 ] 

Hudson commented on MCOMPILER-341:
--

Build succeeded in Jenkins: Maven TLP » maven-compiler-plugin » MCOMPILER-341 #3

See 
https://builds.apache.org/job/maven-box/job/maven-compiler-plugin/job/MCOMPILER-341/3/

> Compile module-info.java files located in test sources
> --
>
> Key: MCOMPILER-341
> URL: https://issues.apache.org/jira/browse/MCOMPILER-341
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Affects Versions: 3.7.0
>Reporter: Christian Stein
>Priority: Minor
>  Labels: pull-request-available
>
> Support compilation of projects with test sources containing modules – along 
> with explicit module descriptors ({{module-info.java}} files).
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MSHARED-695) Move checksum creation from install part to deploy part

2018-05-12 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/MSHARED-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473086#comment-16473086
 ] 

Hudson commented on MSHARED-695:


Build succeeded in Jenkins: Maven TLP » maven-deploy-plugin » MSHARED-695 #5

See 
https://builds.apache.org/job/maven-box/job/maven-deploy-plugin/job/MSHARED-695/5/

> Move checksum creation from install part to deploy part
> ---
>
> Key: MSHARED-695
> URL: https://issues.apache.org/jira/browse/MSHARED-695
> Project: Maven Shared Components
>  Issue Type: Improvement
>  Components: maven-artifact-transfer
>Affects Versions: maven-artifact-transfer-0.10.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Blocker
> Fix For: maven-artifact-transfer-0.10.0
>
>
> We should remove the checksum generation from install parts and move them 
> consistently to the deploy part instead



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MCOMPILER-341) Compile module-info.java files located in test sources

2018-05-12 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/MCOMPILER-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473071#comment-16473071
 ] 

Hudson commented on MCOMPILER-341:
--

Build unstable in Jenkins: Maven TLP » maven-compiler-plugin » MCOMPILER-341 #2

See 
https://builds.apache.org/job/maven-box/job/maven-compiler-plugin/job/MCOMPILER-341/2/

> Compile module-info.java files located in test sources
> --
>
> Key: MCOMPILER-341
> URL: https://issues.apache.org/jira/browse/MCOMPILER-341
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Affects Versions: 3.7.0
>Reporter: Christian Stein
>Priority: Minor
>  Labels: pull-request-available
>
> Support compilation of projects with test sources containing modules – along 
> with explicit module descriptors ({{module-info.java}} files).
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1004) Enhance pattern/wildcard capabilities for dependenciesToScan to GAVT

2018-05-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473068#comment-16473068
 ] 

ASF GitHub Bot commented on SUREFIRE-1004:
--

Tibor17 commented on issue #173: [SUREFIRE-1004] Support full gavtc format for 
dependenciesToScan
URL: https://github.com/apache/maven-surefire/pull/173#issuecomment-388550148
 
 
   @bindul 
   We want to make release in May. Would you have spare time to continue on 
this PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Enhance pattern/wildcard capabilities for dependenciesToScan to GAVT
> 
>
> Key: SUREFIRE-1004
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1004
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Affects Versions: 2.15
>Reporter: Andreas Gudian
>Priority: Major
>
> * Enhance what has been built with SUREFIRE-569 to support patterns as in 
> maven-shade-plugin. Use maven-common-artifact-filters for that.
> * Add/Adapt documentation and examples.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] Tibor17 commented on issue #173: [SUREFIRE-1004] Support full gavtc format for dependenciesToScan

2018-05-12 Thread GitBox 
Tibor17 commented on issue #173: [SUREFIRE-1004] Support full gavtc format for 
dependenciesToScan
URL: https://github.com/apache/maven-surefire/pull/173#issuecomment-388550148
 
 
   @bindul 
   We want to make release in May. Would you have spare time to continue on 
this PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (MCOMPILER-341) Compile module-info.java files located in test sources

2018-05-12 Thread Christian Stein (JIRA) 
Christian Stein created MCOMPILER-341:
-

 Summary: Compile module-info.java files located in test sources
 Key: MCOMPILER-341
 URL: https://issues.apache.org/jira/browse/MCOMPILER-341
 Project: Maven Compiler Plugin
  Issue Type: Improvement
Affects Versions: 3.7.0
Reporter: Christian Stein


Support compilation of projects with test sources containing modules – along 
with explicit module descriptors ({{module-info.java}} files).

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (MNG-6028) When a reactor build fails maven should include current goals in resume suggestion

2018-05-12 Thread JIRA 

 [ 
https://issues.apache.org/jira/browse/MNG-6028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MNG-6028:
---
Fix Version/s: 3.5.4-candidate

> When a reactor build fails maven should include current goals in resume 
> suggestion
> --
>
> Key: MNG-6028
> URL: https://issues.apache.org/jira/browse/MNG-6028
> Project: Maven
>  Issue Type: Improvement
>Affects Versions: 3.3.9
>Reporter: Axel Fontaine
>Priority: Major
> Fix For: 3.5.4-candidate
>
>
> Start multiproject build at root with mvn clean install
> if module-a fails you currently get
> {noformat}[ERROR] After correcting the problems, you can resume the build 
> with the command
> [ERROR]   mvn  -rf :module-a{noformat}
> to be able to easily copy-paste this it would be much nicer if the goals were 
> already filled in:
> {noformat}[ERROR] After correcting the problems, you can resume the build 
> with the command
> [ERROR]   mvn clean install -rf :module-a{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (MNG-6411) Improve readability of project list returned when resume from flag is invalid

2018-05-12 Thread JIRA 

 [ 
https://issues.apache.org/jira/browse/MNG-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MNG-6411:
---
Fix Version/s: 3.5.4-candidate

> Improve readability of project list returned when resume from flag is invalid
> -
>
> Key: MNG-6411
> URL: https://issues.apache.org/jira/browse/MNG-6411
> Project: Maven
>  Issue Type: Improvement
>Affects Versions: 3.5.3
>Reporter: Łukasz Dywicki
>Priority: Minor
> Fix For: 3.5.4-candidate
>
>
> When value passed for {{-rf}} option is invalid a full list of details of all 
> projects in build is returned.
> This list contains too much information. For every project it includes 
> groupId, artifactId, version and pom location. While it is useful for 
> debugging purposes many, if not most, developers are interested in specific 
> coordinate (groupId:artifactId) which should be passed to next execution, and 
> which is valid {{-rf}} optiona value.
> Note tat below outputs contain new lines for ease of read. This could be also 
> added to exception message to make it more readable.
> Assuming, that I've passed -rf :x Current output in case of failure:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
>   MavenProject: com.example:foobar:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/pom.xml,
>   MavenProject: com.example.foobar:parent:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/parent/pom.xml,
>   MavenProject: com.example.foobar:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/api/pom.xml,
>   MavenProject: com.example.foobar:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/model/pom.xml,
>   MavenProject: com.example.foobar:csv:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/pom.xml,
>   MavenProject: com.example.foobar.csv:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/model/pom.xml,
>   MavenProject: com.example.foobar.csv:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/api/pom.xml,
>   MavenProject: com.example.foobar:json:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/pom.xml,
>   MavenProject: com.example.foobar.json:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/model/pom.xml,
>   MavenProject: com.example.foobar.json:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/api/pom.xml,
>   MavenProject: com.example.foobar.json:core:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/core/pom.xml,
>   MavenProject: com.example.foobar:fax:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/pom.xml,
>   MavenProject: com.example.foobar.fax:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/api/pom.xml,
>   MavenProject: com.example.foobar.fax:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/model/pom.xml,
>   MavenProject: com.example.foobar.fax:web:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/pom.xml,
>   MavenProject: com.example.foobar.fax.web:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/api/pom.xml,
>   MavenProject: com.example.foobar.fax.web:core:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/core/pom.xml] -> [Help 1]
> {noformat}
> Additional information about pom locations is irrelevant from message point 
> of view, because valid input for -rf option is presented below:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
>   com.example:foobar,
>   com.example.foobar:parent,
>   com.example.foobar:api,
>   com.example.foobar:model,
>   com.example.foobar:csv,
>   com.example.foobar.csv:model,
>   com.example.foobar.csv:api,
>   com.example.foobar:json,
>   com.example.foobar.json:model,
>   com.example.foobar.json:api,
>   com.example.foobar.json:core,
>   com.example.foobar:fax,
>   com.example.foobar.fax:api,
>   com.example.foobar.fax:model,
>   com.example.foobar.fax:web,
>   com.example.foobar.fax.web:api,
>   com.example.foobar.fax.web:core] -> [Help 1]
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (MNG-6410) When a reactor build fails on an artifactId which is not unique, Maven should provide the groupId when suggesting where build should restart from

2018-05-12 Thread JIRA 

 [ 
https://issues.apache.org/jira/browse/MNG-6410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MNG-6410:
---
Fix Version/s: 3.5.4-candidate

> When a reactor build fails on an artifactId which is not unique, Maven should 
> provide the groupId when suggesting where build should restart from
> -
>
> Key: MNG-6410
> URL: https://issues.apache.org/jira/browse/MNG-6410
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.5.3
>Reporter: Łukasz Dywicki
>Priority: Minor
> Fix For: 3.5.4-candidate
>
>
> In multi module builds same artifact id can be repeated with different group 
> id. For example if project strategy is to use nesting of modules, instead of 
> using long artifact names, {{ap}} or {{model}} module can occur multiple 
> times with different group id.
> By default maven, upon failed build, prints out only {{-rf :artifactId}}. 
> When developer will copy given suggestion and run build again then his build 
> will be started from first module which have given artifact id.
> While severity of this bug is quite low, it affects productivity in bigger 
> projects big time. To improve usability of returned message a Maven should 
> return {{-rf groupId:artifactId}} once artifact id is not unique.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (MNG-3344) Provide new POM element to configure site directory (e.g. "src/site")

2018-05-12 Thread JIRA 

 [ 
https://issues.apache.org/jira/browse/MNG-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MNG-3344:
---
Description: 
As requested in MSITE-91 and its various duplicates, the input location for the 
site generation should be configurable. Currently, this is realized by a 
configuration parameter (siteDirectory) for the maven-site-plugin itself but I 
argue that this is not sufficient/robust for all cases. The problem is that the 
plugin cannot access its configuration in ancestor POMs and hence can only 
guess.

For example, take the following multi-module scenario:
{noformat}  project-parent/
doc/
  site.xml
project-module/
  src/
site/
  site.xml{noformat}
Let us ignore the fact that such is layout is unusual, weird, bad-practice or 
whatever you would like to call it. The point is, it should be possible. The 
important aspect of the example is that both POMs will need to use a different 
configuration of the maven-site-plugin to find the site descriptor (and related 
files). The parent POM will have siteDirectory=doc while the module POM will 
have siteDirectory=src/site.

Now consider the plugin's steps when building the site for project-module. 
>From the plugin configuration in "project-module/pom.xml", it knows to search 
the site descriptor for the sub project in "src/site". To apply inheritance, 
the plugin then needs to locate the site descriptor of the parent project. Ups. 
The plugin cannot access the corresponding plugin configuration in 
"project-parent/pom.xml". So it can only assume that the parent uses the same 
directory layout for the site as the current sub module.

Having a dedicated POM element for the site files, e.g. 
${project.reporting.siteDirectory}, would allow the maven-site-plugin to 
properly determine the location of the site descriptor of any ancestor project. 
The super POM can default this element to "src/site" to get the usual behavior.

  was:
As requested in MSITE-91 and its various duplicates, the input location for the 
site generation should be configurable. Currently, this is realized by a 
configuration parameter (siteDirectory) for the maven-site-plugin itself but I 
argue that this is not sufficient/robust for all cases. The problem is that the 
plugin cannot access its configuration in ancestor POMs and hence can only 
guess.

For example, take the following multi-module scenario:
  project-parent/
doc/
  site.xml
project-module/
  src/
site/
  site.xml
Let us ignore the fact that such is layout is unusual, weird, bad-practice or 
whatever you would like to call it. The point is, it should be possible. The 
important aspect of the example is that both POMs will need to use a different 
configuration of the maven-site-plugin to find the site descriptor (and related 
files). The parent POM will have siteDirectory=doc while the module POM will 
have siteDirectory=src/site.

Now consider the plugin's steps when building the site for project-module. 
>From the plugin configuration in "project-module/pom.xml", it knows to search 
the site descriptor for the sub project in "src/site". To apply inheritance, 
the plugin then needs to locate the site descriptor of the parent project. Ups. 
The plugin cannot access the corresponding plugin configuration in 
"project-parent/pom.xml". So it can only assume that the parent uses the same 
directory layout for the site as the current sub module.

Having a dedicated POM element for the site files, e.g. 
${project.reporting.siteDirectory}, would allow the maven-site-plugin to 
properly determine the location of the site descriptor of any ancestor project. 
The super POM can default this element to "src/site" to get the usual behavior.


> Provide new POM element to configure site directory (e.g. "src/site")
> -
>
> Key: MNG-3344
> URL: https://issues.apache.org/jira/browse/MNG-3344
> Project: Maven
>  Issue Type: New Feature
>  Components: POM
>Affects Versions: 2.0.8
>Reporter: Benjamin Bentmann
>Priority: Major
>
> As requested in MSITE-91 and its various duplicates, the input location for 
> the site generation should be configurable. Currently, this is realized by a 
> configuration parameter (siteDirectory) for the maven-site-plugin itself but 
> I argue that this is not sufficient/robust for all cases. The problem is that 
> the plugin cannot access its configuration in ancestor POMs and hence can 
> only guess.
> For example, take the following multi-module scenario:
> {noformat}  project-parent/
> doc/
>   site.xml
> project-module/
>   src/
> site/
>   site.xml{noformat}
> Let us ignore the fact that such is layout is unusual, weird, bad-practice or 
> whatever you would like to call

[jira] [Created] (MPLUGIN-337) Try to derive JDK requirements also from target parameter

2018-05-12 Thread Konrad Windszus (JIRA) 
Konrad Windszus created MPLUGIN-337:
---

 Summary: Try to derive JDK requirements also from target parameter
 Key: MPLUGIN-337
 URL: https://issues.apache.org/jira/browse/MPLUGIN-337
 Project: Maven Plugin Tools
  Issue Type: Bug
  Components: Plugin Plugin
Affects Versions: 3.5.1
Reporter: Konrad Windszus


Currently the JDK requirements are extracted 
(https://github.com/apache/maven-plugin-tools/blob/1087f55e8cdfd8c1fec605a7cb9004efaee4e592/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/PluginReport.java#L759)
 from either
# the explicitly set requirement (via plugin configuration parameter)
# or by evaluating the maven-compiler-plugin's {{target}} parameter

With Java 9 it is pretty common to use {{release}} instead 
(https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#release).
 Therefore this parameter should be evaluated as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (MSHARED-728) Upgrade maven-shared-utils to 3.2.1

2018-05-12 Thread Karl Heinz Marbaise (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MSHARED-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed MSHARED-728.
---
Resolution: Done

Done in 
[d40b7330c13ce23f2347a87c7c553584b5965f17|https://gitbox.apache.org/repos/asf?p=maven-invoker.git;a=commitdiff;h=d40b7330c13ce23f2347a87c7c553584b5965f17]

> Upgrade maven-shared-utils to 3.2.1
> ---
>
> Key: MSHARED-728
> URL: https://issues.apache.org/jira/browse/MSHARED-728
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-invoker
>Affects Versions: maven-invoker-3.0.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: maven-invoker-3.0.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (MINVOKER-238) Upgrade maven-invoker to 3.0.1

2018-05-12 Thread Karl Heinz Marbaise (JIRA) 
Karl Heinz Marbaise created MINVOKER-238:


 Summary: Upgrade maven-invoker to 3.0.1
 Key: MINVOKER-238
 URL: https://issues.apache.org/jira/browse/MINVOKER-238
 Project: Maven Invoker Plugin
  Issue Type: Dependency upgrade
Affects Versions: 3.1.0
Reporter: Karl Heinz Marbaise
 Fix For: 3.1.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1521) Replace PowerMock usage

2018-05-12 Thread Christian Stein (JIRA) 

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472985#comment-16472985
 ] 

Christian Stein commented on SUREFIRE-1521:
---

Perhaps use Mockito 2 support for mocking `final` classes?

_"Redesign your code, or use Powermock. And the latter is almost never a good 
thing."_

Source: [https://igorski.co/java/testing/mock-final-classes-mockito/] 

> Replace PowerMock usage
> ---
>
> Key: SUREFIRE-1521
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1521
> Project: Maven Surefire
>  Issue Type: Task
>Reporter: Christian Stein
>Priority: Minor
> Attachments: image-2018-05-08-20-03-42-257.png
>
>
> PowerMock seems not actively maintained. With the upcoming release of Java 11 
> this will lead to problems. As can be seen here: 
> https://github.com/powermock/powermock/issues/904
> We should replace the usage of it in only *4* of Surefires' tests by using 
> `mockito`, if possible. Or don't mock here at all and achieve the same test 
> goals by using the real domain model types. 
>  
> !image-2018-05-08-20-03-42-257.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MSHARED-728) Upgrade maven-shared-utils to 3.2.1

2018-05-12 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/MSHARED-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472983#comment-16472983
 ] 

Hudson commented on MSHARED-728:


Build succeeded in Jenkins: Maven TLP » maven-invoker » master #16

See https://builds.apache.org/job/maven-box/job/maven-invoker/job/master/16/

> Upgrade maven-shared-utils to 3.2.1
> ---
>
> Key: MSHARED-728
> URL: https://issues.apache.org/jira/browse/MSHARED-728
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-invoker
>Affects Versions: maven-invoker-3.0.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: maven-invoker-3.0.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MSHARED-728) Upgrade maven-shared-utils to 3.2.1

2018-05-12 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/MSHARED-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472976#comment-16472976
 ] 

Hudson commented on MSHARED-728:


Build succeeded in Jenkins: Maven TLP » maven-invoker » MSHARED-728 #4

See https://builds.apache.org/job/maven-box/job/maven-invoker/job/MSHARED-728/4/

> Upgrade maven-shared-utils to 3.2.1
> ---
>
> Key: MSHARED-728
> URL: https://issues.apache.org/jira/browse/MSHARED-728
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-invoker
>Affects Versions: maven-invoker-3.0.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: maven-invoker-3.0.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (MSHARED-718) Upgrade asm to most recent version 6.1.1

2018-05-12 Thread Karl Heinz Marbaise (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MSHARED-718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed MSHARED-718.
---
Resolution: Fixed

Fixed in 
[92eb1f9c3c7140a242b1bb2470e635bd8859f0d3|https://gitbox.apache.org/repos/asf?p=maven-dependency-analyzer.git;a=commitdiff;h=92eb1f9c3c7140a242b1bb2470e635bd8859f0d3]

> Upgrade asm to most recent version 6.1.1
> 
>
> Key: MSHARED-718
> URL: https://issues.apache.org/jira/browse/MSHARED-718
> Project: Maven Shared Components
>  Issue Type: Task
>Affects Versions: maven-dependency-analyzer-1.9
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Critical
> Fix For: maven-dependency-analyzer-1.10
>
>
> Based on the upgrade of asm to 6.1.1 it is also required to upgrade 
> commons-lang3 to version 3.7 which requires a JDK minimum upgrade to 7.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-12 Thread GitBox 
Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-388533788
 
 
   I saw this error too and it happened because I triggered the branch 1338
   and master in parallel:
   
   java.io.IOException: Failed to mkdirs:
   
/home/jenkins/jenkins-slave/workspace/ven-box_maven-surefire_1330-TSMLOBV5ENRMCK6YV52ANAULUWOG4OYEMBRTFOGSINEWTK45IYLQ
at hudson.FilePath.mkdirs(FilePath.java:1170)
at 
org.jenkinsci.plugins.workflow.steps.CoreStep$Execution.run(CoreStep.java:79)
   
   
   
   On Sat, May 12, 2018 at 6:34 AM, Christian Stein 
   wrote:
   
   > What happend on the linux-jdk7-maven3.5.x
   > 
   > build?
   >
   > [linux-jdk7-maven3.5.x] Tests run: 58, Failures: 0, Errors: 0, Skipped: 0, 
Time elapsed: 2.858 sec
   > [linux-jdk7-maven3.5.x]
   > [linux-jdk7-maven3.5.x] Results :
   > [linux-jdk7-maven3.5.x]
   > [linux-jdk7-maven3.5.x] Tests run: 58, Failures: 0, Errors: 0, Skipped: 0
   > [linux-jdk7-maven3.5.x]
   > [linux-jdk7-maven3.5.x] [INFO]
   > [linux-jdk7-maven3.5.x] [INFO] --- maven-jar-plugin:3.0.0:jar 
(default-jar) @ surefire-booter ---
   > [linux-jdk7-maven3.5.x] [INFO] Building jar: 
/home/jenkins/jenkins-slave/workspace/ven-box_maven-surefire_1330-TSMLOBV5ENRMCK6YV52ANAULUWOG4OYEMBRTFOGSINEWTK45IYLQ/surefire-booter/target/surefire-booter-3.0.0-SNAPSHOT.jar
   > [linux-jdk7-maven3.5.x] [INFO]
   > [linux-jdk7-maven3.5.x] [INFO] --- maven-site-plugin:3.4:attach-descriptor 
(attach-descriptor) @ surefire-booter ---
   > [linux-jdk7-maven3.5.x] [INFO]
   > [linux-jdk7-maven3.5.x] [INFO] --- maven-shade-plugin:3.1.0:shade 
(default) @ surefire-booter ---
   > [linux-jdk7-maven3.5.x] [INFO] Excluding 
org.apache.maven.surefire:surefire-api:jar:3.0.0-SNAPSHOT from the shaded jar.
   > [linux-jdk7-maven3.5.x] [INFO] Excluding 
org.apache.maven.surefire:surefire-logger-api:jar:3.0.0-SNAPSHOT from the 
shaded jar.
   > [linux-jdk7-maven3.5.x] [INFO] Including 
org.apache.commons:commons-lang3:jar:3.5 in the shaded jar.
   > [linux-jdk7-maven3.5.x] [INFO] Including commons-io:commons-io:jar:2.5 in 
the shaded jar.
   > [linux-jdk7-maven3.5.x] [INFO] Minimizing jar 
org.apache.maven.surefire:surefire-booter:jar:3.0.0-SNAPSHOT
   > [linux-jdk7-maven3.5.x] [INFO] 

   > [linux-jdk7-maven3.5.x] [INFO] Reactor Summary:
   > [linux-jdk7-maven3.5.x] [INFO]
   > [linux-jdk7-maven3.5.x] [INFO] Apache Maven Surefire 
.. SUCCESS [ 13.605 s]
   > [linux-jdk7-maven3.5.x] [INFO] SureFire Logger API 
 SUCCESS [  3.933 s]
   > [linux-jdk7-maven3.5.x] [INFO] SureFire API 
... SUCCESS [ 12.695 s]
   > [linux-jdk7-maven3.5.x] [INFO] ShadeFire JUnit3 Provider 
.. SUCCESS [  1.921 s]
   > [linux-jdk7-maven3.5.x] [INFO] SureFire Booter 
 FAILURE [ 10.408 s]
   > [linux-jdk7-maven3.5.x] [INFO] Maven Surefire Test-Grouping Support 
... SKIPPED
   > [...]
   >
   > windows-jdk7-maven3.5.x build was doing fine.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > ,
   > or mute the thread
   > 

   > .
   >
   
   
   
   -- 
   Cheers
   Tibor
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-12 Thread GitBox 
Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-388533551
 
 
   See the log again. There must be a reason.
   Last days the compiler failed on linux and it was not our problem:
   TestsToRunTest.java:[113,4] error: error while writing TestsToRunTest.T1:
   could not create parent directories
   
   On Sat, May 12, 2018 at 8:16 AM, Christian Stein 
   wrote:
   
   > Restarting the build didn't help...
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > ,
   > or mute the thread
   > 

   > .
   >
   
   
   
   -- 
   Cheers
   Tibor
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-12 Thread GitBox 
sormuras commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-388533450
 
 
   Restarting the build didn't help...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services