[jira] [Commented] (MDEP-579) Regression: get goal does not pass server credentials to BasicRepositoryConnector
[
https://issues.apache.org/jira/browse/MDEP-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907849#comment-16907849
]
Pim Moerenhout commented on MDEP-579:
-
Hi [~kentgran],
I have setup the setup you've described, using a Nexus docker image as mirror
of public with authentication, together with a private repository. However, I
did change the mirrorOf property of the nexus mirror to *,!internal-repo-id, as
this property must contain the id. See [Settings
reference|https://maven.apache.org/settings.html#Mirrors].
With the setup described, the artifact could be get, from the internal
repository, with the correct authentication. Before the get, I delete the
artifact from the local repository in the .m2/repo folder.
In the failure log, the message is _Could not find artifact
com.test.note:note-docker:zip:4.1 in nexus_. It's not mentioning that the
authentication failed.
Could you verify in the real setup how the mirrorOf is specified ?
If it still fails, I could setup the docker image to hold the 2 repositories,
as next step.
> Regression: get goal does not pass server credentials to
> BasicRepositoryConnector
> -
>
> Key: MDEP-579
> URL: https://issues.apache.org/jira/browse/MDEP-579
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: get
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Richard W. Eggert II
>Priority: Critical
> Labels: credentials
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The {{get}} goal does not pass the server credentials from {{settings.xml}}
> to the {{BasicRepositoryConnector}} in version 3.0.1 (and, presumably 3.0.0),
> resulting in {{NotAuthorized}} errors when resolving artifacts against
> repositories that require authentication. It works correctly in version 2.9.
> Background: I discovered this in the course of debugging a Jenkins job in
> which I'm using the {{get}} and {{copy}} goals from the command line (with no
> POM) to download artifacts to deploy. After spending several hours thinking
> that Jenkins was not properly configuring {{settings.xml}}, I noticed from
> the Maven debug output that the credentials were being passed when resolving
> the maven-dependency-plugin and its dependencies, but not being passed when
> resolving the artifact I requested. On a hunch I downgraded from
> maven-dependency-plugin version 3.0.1 to 2.9, and suddenly everything
> magically worked.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (SUREFIRE-1464) Failsafe plugin exposes slf4j-jdk14 dependency
[
https://issues.apache.org/jira/browse/SUREFIRE-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907667#comment-16907667
]
Jonathan Bell commented on SUREFIRE-1464:
-
Hi,
FYI, this was merged in as of 2.20.1, as reported here ->
[https://issues.apache.org/jira/browse/SUREFIRE-1396]
I come here only because 2 years after patching that I came across the same
darn bug, forgot about it, googled it, found this issue, which then reminded me
that this had been merged.
> Failsafe plugin exposes slf4j-jdk14 dependency
> --
>
> Key: SUREFIRE-1464
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1464
> Project: Maven Surefire
> Issue Type: Bug
> Components: classloading, JUnit 5.x support, Maven Failsafe Plugin
>Affects Versions: 2.19.1
> Environment: Windows 10 Pro
> Oracle Java(TM) SE Runtime Environment (build 1.8.0_152-b16)
> Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d;
> 2017-10-18T09:58:13+02:00)
>Reporter: Frank Seidinger
>Priority: Major
>
> I'm testing a spring-boot application using current spring-boot-startet
> When running the integration tests I get the following output from SLF4J:
> {{SLF4J: The requested version 1.5.6 by your slf4j binding is not compatible
> with [1.6, 1.7]}}
> And afterwords a lot of {{AbstracMethodError}} failures. Here is one example:
> {noformat}
> java.lang.AbstractMethodError:
> org.slf4j.impl.JDK14LoggerAdapter.log(Lorg/slf4j/Marker;Ljava/lang/String;ILjava/lang/String;[Ljava/lang/Object;Ljava/lang/Throwable;)V
> {noformat}
> The version 1.5.6 reported by SLF4J is not any dependency of my project but a
> direct dependency of the maven-failsafe-plugin, whereas my project uses slf4j
> 1.7.22.
> The relevant dependencies reported by {{mvn dependency:tree -Dverbose
> -Dscope=test}} are:
> {noformat}
> [INFO] +- org.axonframework:axon-core:jar:3.1:compile
> [INFO] | +- (org.slf4j:slf4j-api:jar:1.7.25:compile - version managed from
> 1.7.22; omitted for duplicate)
> [INFO] | +- com.thoughtworks.xstream:xstream:jar:1.4.9:compile
> [INFO] | \- xpp3:xpp3:jar:1.1.4c:compile
> [INFO] +- org.springframework:spring-core:jar:4.3.13.RELEASE:compile
> [INFO] | \- commons-logging:commons-logging:jar:1.2:compile
> [INFO] +-
> org.springframework.boot:spring-boot-starter-data-jpa:jar:1.5.9.RELEASE:compile
> [INFO] | +-
> org.springframework.boot:spring-boot-starter:jar:1.5.9.RELEASE:compile
> [INFO] | | +- org.springframework.boot:spring-boot:jar:1.5.9.RELEASE:compile
> [INFO] | | | +-
> (org.springframework:spring-core:jar:4.3.13.RELEASE:compile - omitted for
> duplicate)
> [INFO] | | | \-
> (org.springframework:spring-context:jar:4.3.13.RELEASE:compile - omitted for
> duplicate)
> [INFO] | | +-
> org.springframework.boot:spring-boot-autoconfigure:jar:1.5.9.RELEASE:compile
> [INFO] | | | \-
> (org.springframework.boot:spring-boot:jar:1.5.9.RELEASE:compile - omitted for
> duplicate)
> [INFO] | | +-
> org.springframework.boot:spring-boot-starter-logging:jar:1.5.9.RELEASE:compile
> [INFO] | | | +- ch.qos.logback:logback-classic:jar:1.1.11:compile
> [INFO] | | | | +- ch.qos.logback:logback-core:jar:1.1.11:compile
> [INFO] | | | | \- (org.slf4j:slf4j-api:jar:1.7.25:compile - version
> managed from 1.7.22; omitted for duplicate)
> [INFO] | | | +- org.slf4j:jcl-over-slf4j:jar:1.7.25:compile
> [INFO] | | | | \- (org.slf4j:slf4j-api:jar:1.7.25:compile - version
> managed from 1.7.22; omitted for duplicate)
> [INFO] | | | +- org.slf4j:jul-to-slf4j:jar:1.7.25:compile
> [INFO] | | | | \- (org.slf4j:slf4j-api:jar:1.7.25:compile - version
> managed from 1.7.22; omitted for duplicate)
> [INFO] | | | \- org.slf4j:log4j-over-slf4j:jar:1.7.25:compile
> [INFO] | | | \- (org.slf4j:slf4j-api:jar:1.7.25:compile - version
> managed from 1.7.22; omitted for duplicate)
> [INFO] | | +- (org.springframework:spring-core:jar:4.3.13.RELEASE:compile -
> omitted for duplicate)
> [INFO] | | \- org.yaml:snakeyaml:jar:1.17:runtime
> [INFO] | +-
> org.springframework.data:spring-data-jpa:jar:1.11.9.RELEASE:compile
> [INFO] | | +-
> org.springframework.data:spring-data-commons:jar:1.13.9.RELEASE:compile
> [INFO] | | | +-
> (org.springframework:spring-core:jar:4.3.13.RELEASE:compile - omitted for
> duplicate)
> [INFO] | | | +-
> (org.springframework:spring-beans:jar:4.3.13.RELEASE:compile - omitted for
> duplicate)
> [INFO] | | | +- (org.slf4j:slf4j-api:jar:1.7.25:compile - version managed
> from 1.7.22; omitted for duplicate)
> [INFO] | | | \- (org.slf4j:jcl-over-slf4j:jar:1.7.25:runtime - omitted for
> duplicate)
> [INFO] | | +- org.springframework:spring-orm:jar:4.3.13.RELEASE:compile
> [INFO] | | | +-
> (org.springframework:spring-beans:jar:4.3.13.RELEASE:comp
[jira] [Updated] (MNG-6368) Maven 3.5.2 breaks the Maven Invoker Plugin on Windows
[
https://issues.apache.org/jira/browse/MNG-6368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-6368:
Fix Version/s: wontfix-candidate
> Maven 3.5.2 breaks the Maven Invoker Plugin on Windows
> --
>
> Key: MNG-6368
> URL: https://issues.apache.org/jira/browse/MNG-6368
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.5.2
> Environment: Windows 7
> run from cygwin with January 2017 updates
>Reporter: Gene Smith
>Priority: Minor
> Fix For: waiting-for-feedback, wontfix-candidate
>
> Attachments: test-maven-invoker-plugin.zip
>
>
> *I found a work around (credit Robert Scholte's quetion for the clue)..*
> * *make sure all files in $MAVEN_HOME/bin are executable***
> Maven 3.5.2 will not tell you why maven-invoker-fails if it can't find an
> executable.
> ...
> With Maven 3.5.2 on Windows 7,. the Maven Invoker Plugin breaks:
> * reporting
> _The Maven invocation failed. Error while executing process._
> * leaving empty log files, and streaming nothing from the invoked process
> I have multiple uses in a large project, which have has been working for us
> through many version of Maven. They all break, *on Windows with:*
> * a simple clean attempt to upgrade to Maven 3.5.2.
> (without changing any plugin versions)
> * a complex upgrade attempt, advancing forward as many plugin versions as
> can be pushed.
> The complex upgrade attempt works with Maven 3.5.0.
> And on testing to isolate it, Maven 3.5.2 + Maven Invoker Plugin 2+ breaks
> even in simplest form invoking:
> * an empty jar project with no inheritance
> * an empty pom project with no inheritance
> * an empty jar project with direct inheritance from the invoker
> * an empty pom project with direct inheritance from the invoker
> The attached zip very simple test project, which
> * works with:
> ** Maven 3.0.5, 3.1.1, 3.2.1, 3.3.3, 3.3.9
> *** maven-invoker-plugin 1.6, 1.7, 1.8, 1.9, 2.0.0, 3.0.0, 3.0.1
> ** Maven 3.5.0
> *** maven-invoker-plugin 2.0.0, 3.0.0, 3.0.1
> * *breaks with:*
> ** Maven 3.5.2
> *** maven-invoker-plugin 1.6, 1.7, 1.8, 1.9, 2.0.0, 3.0.0, 3.0.1
> I looked through sources and was able to test with this built locally (but my
> task is timeboxed and I have not been able to get Maven built from sources in
> the time I have):
> *
> [http://svn.apache.org/repos/asf/maven/plugins/tags/maven-invoker-plugin-3.0.1]
> and traced it as far as the call to:
> * org.apache.maven.shared.invoker.Invoker
> try
>
> { result = invoker.execute( request ); }
> catch ( final MavenInvocationException e )
>
> { getLog().debug( "Error invoking Maven: " +
> e.getMessage(), e ); throw new RunFailureException(
> "Maven invocation failed. " + e.getMessage(),
> BuildJob.Result.FAILURE_BUILD ); }
> but it invoker hides all trace, and I do not have time (I am time boxed this
> week) to get Maven built from sources to trace it into the Invoker.
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (MNG-5857) Arguments from command line should override those in .mvn/maven.config
[ https://issues.apache.org/jira/browse/MNG-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-5857: Fix Version/s: (was: 3.x / Backlog) > Arguments from command line should override those in .mvn/maven.config > -- > > Key: MNG-5857 > URL: https://issues.apache.org/jira/browse/MNG-5857 > Project: Maven > Issue Type: Bug >Reporter: Dave Syer >Priority: Major > Fix For: waiting-for-feedback > > > Because of the way the command line args are added at the *start* of the list > here: > [MavenCli#410|https://gitbox.apache.org/repos/asf?p=maven.git;a=blob;f=maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java;h=4d142ee4c9a7f4f1c6311fcc87aacb59ba14fc23;hb=HEAD#l410], > they get overwritten by the settings in .mvn/maven.config. I would have > thought this should be the other way round. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (MNG-6356) property from list element in pom model
[
https://issues.apache.org/jira/browse/MNG-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-6356:
Fix Version/s: wontfix-candidate
> property from list element in pom model
> ---
>
> Key: MNG-6356
> URL: https://issues.apache.org/jira/browse/MNG-6356
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.5.2
> Environment: linux
>Reporter: Ernst Reissner
>Priority: Major
> Fix For: waiting-for-feedback, wontfix-candidate
>
>
> I tried to filter ${project.developers[0].email}
> Although mvn help:evaluate finds the correct answer, filtering does not work
> else.
> Even if i havein the properties section of the pom one of the three
> ernst.reiss...@simuline.eu
> ${project.organization.name}
> ${project.developers[0].email}
> the latter is not replaced and just comes litterally.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (MNG-5857) Arguments from command line should override those in .mvn/maven.config
[ https://issues.apache.org/jira/browse/MNG-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-5857: Fix Version/s: 3.7.0-candidate > Arguments from command line should override those in .mvn/maven.config > -- > > Key: MNG-5857 > URL: https://issues.apache.org/jira/browse/MNG-5857 > Project: Maven > Issue Type: Bug >Reporter: Dave Syer >Priority: Major > Fix For: 3.7.0-candidate, waiting-for-feedback > > > Because of the way the command line args are added at the *start* of the list > here: > [MavenCli#410|https://gitbox.apache.org/repos/asf?p=maven.git;a=blob;f=maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java;h=4d142ee4c9a7f4f1c6311fcc87aacb59ba14fc23;hb=HEAD#l410], > they get overwritten by the settings in .mvn/maven.config. I would have > thought this should be the other way round. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (MNG-5875) [regression] Repositories discovered in dependency POMs are not subject to mirroring
[ https://issues.apache.org/jira/browse/MNG-5875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-5875: Fix Version/s: wontfix-candidate > [regression] Repositories discovered in dependency POMs are not subject to > mirroring > > > Key: MNG-5875 > URL: https://issues.apache.org/jira/browse/MNG-5875 > Project: Maven > Issue Type: Bug > Components: Artifacts and Repositories >Affects Versions: 3.3.3 >Reporter: Hilbert Schraal >Assignee: Benjamin Bentmann >Priority: Major > Fix For: waiting-for-feedback, wontfix-candidate > > > Build logs revealed that trunk does not use mirrors for those repositories > that are contributed by POMs of dependencies during transitive dependency > resolution. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (MNG-6731) Jetty getLocalPort() returns -1 resulting in build failures
[
https://issues.apache.org/jira/browse/MNG-6731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907648#comment-16907648
]
Hudson commented on MNG-6731:
-
Build succeeded in Jenkins: Maven TLP » maven » master #275
See https://builds.apache.org/job/maven-box/job/maven/job/master/275/
> Jetty getLocalPort() returns -1 resulting in build failures
> ---
>
> Key: MNG-6731
> URL: https://issues.apache.org/jira/browse/MNG-6731
> Project: Maven
> Issue Type: Bug
> Components: Integration Tests
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.6.2, 3.6.x-candidate
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> We observed sporadic errors [1] fir the project {{core-its}} on Jenkins.
> So I started haveing a look and I say the JavaDoc of the method
> {{getlocalPort}} saying that {{-1}} is returned if the connector is not open.
> So I decided to use [2] and wait until the server is up. This was of course
> wrong because the status of the server is set to {{STARTED}} immediatelly
> after the method {{Server.start()}}. So therefore I was googling a little bit
> and I found that Hadoop [3] had this problem too in 2010. Whole problem was
> with a bug in Jetty server which is {{race condition}}. The article has a
> link to Jetty's Jira with reported bug {{JETTY-748}}. According to the
> annoucements [4] from Eclipse/Jetty, the bug "{{JETTY-748 Prevent race close
> of socket by old acceptor threads}}" was fixed in the version
> {{jetty-7.2.1.v2010}}. So I decided to use that version but I found that
> the class {{HashUserRealm}} was deleted and there is no support and no
> further development of {{org.mortbay}}. Eclipse continues with the
> development of Jerry 9.
> All I did in this issue was to rewrite 38 integration tests to Jetty 9 API
> and the fix for {{JETTY-748}} is right there.
> [1]:
> Error message in logs: [WARNING] Could not transfer metadata
> org.apache.maven.its.mng4554/maven-metadata.xml from/to central
> (http://localhost:-1/repo-1): Connect to localhost:80 [localhost/127.0.0.1,
> localhost/0:0:0:0:0:0:0:1] failed: Connection refused: connect
> [2]:
> {code:java}
> while ( !server.isRunning() || !server.isStarted() )
> {
> if ( server.isFailed() )
> {
> fail( "Couldn't bind the server socket to a free port!" );
> }
> Thread.sleep( 100L );
> }
> {code}
> [3]:
> https://www.bountysource.com/issues/987313-jetty-returns-1-resulting-in-hadoop-masters-slaves-to-fail-during-startup
> [4]:
> https://www.eclipse.org/lists/jetty-dev/msg00537.html
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (MNG-5872) Maven results are wrong after rerun test cases by RetryListeners
[
https://issues.apache.org/jira/browse/MNG-5872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-5872:
Fix Version/s: wontfix-candidate
> Maven results are wrong after rerun test cases by RetryListeners
>
>
> Key: MNG-5872
> URL: https://issues.apache.org/jira/browse/MNG-5872
> Project: Maven
> Issue Type: Bug
> Components: Errors
>Reporter: Vishnu
>Priority: Major
> Fix For: waiting-for-feedback, wontfix-candidate
>
>
> I am getting wrong result count after re-run the failed test case using
> RetryListener.
> Environment details:
> Java,
> Selenium with TestNG
> Chrome browser
> Maven mode execution
> Total Running Test case : 1
> Simulation:
> 1. Have added Listener class in TestNG and running test case using maven
>
>
>
> 2. Made test case failed and it invoked failed test case and 2nd time, it got
> passed. The results would be as follows;
> Expected Results ==> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> (Correct)
> Actual Results ==> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0 (Wrong)
> I've used below classes for Listeners and calling RetryListener class from
> TestNG.xml and executing them from Maven mode.
> IRetryAnalyzer class:
> public class RetryAnalyzer implements IRetryAnalyzer {
> private int retryCount = 0;
> private int retryMaxCount = 1;
>
> public RetryAnalyzer() {
> setCount(retryMaxCount);
> }
>@Override
> public boolean retry(ITestResult result) {
> if (!result.isSuccess()) {
> if (retryCount < retryMaxCount) {
> retryCount++;
> result.setStatus(ITestResult.SUCCESS);
> String message = Thread.currentThread().getName() + ": Error in
> " + result.getName() + " Retrying "
> + (retryMaxCount + 1 - retryCount) + " more time(s)";
> System.out.println(message);
> Reporter.log(message);
> return true;
> } else {
> result.setStatus(ITestResult.FAILURE);
> }
> }
> return false;
> }
>
> public void setCount(int count) {
> retryMaxCount = count;
> }
> RetryLister Class:
> public class RetryListener implements IAnnotationTransformer {
> @SuppressWarnings("rawtypes")
> @Override
> public void transform(ITestAnnotation arg0, Class arg1, Constructor
> arg2,
> Method arg3) {
> IRetryAnalyzer retry = arg0.getRetryAnalyzer();
> if (retry == null) {
> arg0.setRetryAnalyzer(RetryAnalyzer.class);
> }
> }
>
> public void onFinish(ITestContext context) {
>Iterator failedTestCases
> =context.getFailedTests().getAllResults().iterator();
> while (failedTestCases.hasNext()) {
> System.out.println("failedTestCases");
> ITestResult failedTestCase = failedTestCases.next();
> ITestNGMethod method = failedTestCase.getMethod();
> if (context.getFailedTests().getResults(method).size() > 1) {
> System.out.println("failed test case remove as dup:" +
> failedTestCase.getTestClass().toString());
> failedTestCases.remove();
> } else {
> if (context.getPassedTests().getResults(method).size() > 0)
> {
> System.out.println("failed test case remove as pass
> retry:" + failedTestCase.getTestClass().toString());
> failedTestCases.remove();
> }
> }
> }
> }
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (MNG-5843) Inappropriate version resolution for version range with relocation
[
https://issues.apache.org/jira/browse/MNG-5843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-5843:
Fix Version/s: wontfix-candidate
> Inappropriate version resolution for version range with relocation
> --
>
> Key: MNG-5843
> URL: https://issues.apache.org/jira/browse/MNG-5843
> Project: Maven
> Issue Type: Bug
> Components: Dependencies
>Reporter: Stefan Birkner
>Priority: Major
> Fix For: waiting-for-feedback, wontfix-candidate
>
>
> I have a dependency with a version range like
> {code:xml}
>
> junit
> junit-dep
> [4,5)
> test
>
> {code}
> and I want the newest version according to the version range. In this case it
> is junit-dep 4.11, but I get 4.11-beta-1.
> This is because the dependency junit-dep has a relocation defined like
> {code:xml}
>
>
> junit
> ...
>
>
> {code}
> Maven takes the first version that has a relocation defined instead of the
> newest version (4.10 was the last without relocation).
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (MNG-5309) InputLocation missing for Xpp3Dom configuration elements
[ https://issues.apache.org/jira/browse/MNG-5309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-5309: Fix Version/s: wontfix-candidate > InputLocation missing for Xpp3Dom configuration elements > > > Key: MNG-5309 > URL: https://issues.apache.org/jira/browse/MNG-5309 > Project: Maven > Issue Type: Bug > Components: Embedding, IDEs, Inheritance and Interpolation, POM >Affects Versions: 3.0.4 >Reporter: Milos Kleint >Assignee: Milos Kleint >Priority: Major > Fix For: waiting-for-feedback, Issues to be reviewed for 4.x, > wontfix-candidate > > Attachments: 2012-07-06_1548.png, mng_configuration.patch > > > I'm trying to create a view over a pom.xml file that displays current > effective pom, along with showing which line came from which pom. Works more > or less ok, with the provided InputLocations with one significant exception. > element in . See screenshot. > The idea in the patch is to have the InputLocation tree mimic the tree of > Xpp3Dom objects. All the merges of Xpp3Dom then manipulate the tree of > InputLocations as well. > The patch included is not complete, just proof of concept, needs to have > proper InputLocation creating in Xpp3DomMavenReaderExt file (I've replaced > that by some quick post processing, changing modello plugins to generate > something else is error prone slow to to start with). Additionally the > default Xpp3Dom merging from plexus-utils is replaced by maven's own version > of merge code. Not sure there if it's possible/practical to move that code > down to the dependency. > also some additional tests are required to be written -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (MNG-5758) Profile activeByDefault in settings.xml is not deactivated when an explicit profile is specified
[ https://issues.apache.org/jira/browse/MNG-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-5758: Fix Version/s: wontfix-candidate > Profile activeByDefault in settings.xml is not deactivated when an explicit > profile is specified > > > Key: MNG-5758 > URL: https://issues.apache.org/jira/browse/MNG-5758 > Project: Maven > Issue Type: Bug > Components: Profiles >Affects Versions: 3.2.5 > Environment: Windows 7 >Reporter: Franck Mangin >Priority: Major > Fix For: waiting-for-feedback, wontfix-candidate > > > If a profile "Def" is defined with activeByDefaut=true in both pom.xml and > settings.xml, and another "Other" profile is defined in pom.xml, running > mvn -POther help:active-profiles > reports > - Def (source: external) > - Other (source: pom.xml) > The expected behavior would be for Def to not be activated. Running without > the -P argument reports Def twice (external and pom.xml), so the automatic > deactivation behavior is inconsistent. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (MNG-5180) Versioning's snapshot version list is not included in metadata merge
[ https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-5180: Fix Version/s: wontfix-candidate > Versioning's snapshot version list is not included in metadata merge > -- > > Key: MNG-5180 > URL: https://issues.apache.org/jira/browse/MNG-5180 > Project: Maven > Issue Type: Bug >Affects Versions: 3.0.3 >Reporter: Noam Y. Tenne >Priority: Major > Fix For: waiting-for-feedback, wontfix-candidate > > Attachments: MavenMetadataSnapshotVersionsMergeTest.java > > > Versioning#snapshotVersions is not being merged when using Metadata#merge. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Closed] (MNG-6587) Display full OS version for 'mvn -version'
[
https://issues.apache.org/jira/browse/MNG-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-6587.
---
Resolution: Won't Fix
Fix Version/s: (was: waiting-for-feedback)
This isn't something we can or will deliver anytime soon.
> Display full OS version for 'mvn -version'
> --
>
> Key: MNG-6587
> URL: https://issues.apache.org/jira/browse/MNG-6587
> Project: Maven
> Issue Type: Improvement
> Components: Command Line
>Reporter: Gary Gregory
>Priority: Minor
>
> Display full OS version for 'mvn -version'
> For example, on Windows 10, display {{10.0.16299.904}} instead of {{10.0}}.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (MNG-6725) Skip '.mavenrc' via MAVEN_SKIP_RC=1 and '-Dmaven.skip.rc=true' on child ITs (by default on Jenkins CI).
[
https://issues.apache.org/jira/browse/MNG-6725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated MNG-6725:
--
Fix Version/s: (was: 3.6.x-candidate)
> Skip '.mavenrc' via MAVEN_SKIP_RC=1 and '-Dmaven.skip.rc=true' on child ITs
> (by default on Jenkins CI).
> ---
>
> Key: MNG-6725
> URL: https://issues.apache.org/jira/browse/MNG-6725
> Project: Maven
> Issue Type: Task
> Components: Integration Tests
> Environment: ASF Jenkins CI
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
>
> This is related to the problem with MAVEN_OPTS.
> If Jenkins has global '.mavenrc' then the environment variables are merged
> with local ones and applied in Maven JVM which is controlled by
> $MVN_HOME/bin/mvn
> If you want to isolate the JVM from global '.mavenrc', you have to set
> environment variable to non-zero length value, i.e. MAVEN_SKIP_RC=1.
> This commit controls skipping '.mavenrc' in
> {{AbstractMavenIntegrationTestCase}}.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Closed] (MNG-6379) Repositories and pluginRepositories from the POM in the import scope should be included in the project
[ https://issues.apache.org/jira/browse/MNG-6379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-6379. --- Resolution: Won't Fix Fix Version/s: (was: wontfix-candidate) (was: waiting-for-feedback) No feedback received on the comments. > Repositories and pluginRepositories from the POM in the import scope should > be included in the project > -- > > Key: MNG-6379 > URL: https://issues.apache.org/jira/browse/MNG-6379 > Project: Maven > Issue Type: Improvement >Reporter: Jakub Kubrynski >Priority: Major > > When I import the POM in the dependencyManagement section and it contains > repositories and pluginRepositories it should be taken into account during > resolution of the project -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (MNG-6268) When a reactor build fails Maven should include -f (if used) in command line suggestion
[
https://issues.apache.org/jira/browse/MNG-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907645#comment-16907645
]
Michael Osipov commented on MNG-6268:
-
[~sewe], any proposals?
> When a reactor build fails Maven should include -f (if used) in command line
> suggestion
> ---
>
> Key: MNG-6268
> URL: https://issues.apache.org/jira/browse/MNG-6268
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.5.0
>Reporter: Andreas Sewe
>Priority: Trivial
> Fix For: wontfix-candidate
>
>
> When a reactor build fails, Maven prints out a helpful suggestion on how to
> resume.
> {noformat}
> [ERROR] After correcting the problems, you can resume the build with the
> command
> [ERROR] mvn -rf :example
> {noformat}
> Unfortunately, when running {{mvn}} with {{-f}}, this suggestion is wrong;
> Maven will either pick the wrong {{pom.xml}} or simply won’t find any; in
> either case, the {{pom.xml}} specified with {{-f}} is *crucial* information
> that was left out of the suggestion.
> FYI, this is related to MNG-6028, but covers a different bit of info that
> IMHO should be part of the suggestion. Hence this separate issue.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [maven] michael-o commented on issue #165: [MNG-6028] Include current goals in resume suggestion
michael-o commented on issue #165: [MNG-6028] Include current goals in resume suggestion URL: https://github.com/apache/maven/pull/165#issuecomment-521428462 @splatch, if we cannot agree on something let's make it general with `` otherwise we have goals, phases, options and properties. @hboutemy @rfscholte WDYT? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] michael-o removed a comment on issue #165: [MNG-6028] Include current goals in resume suggestion
michael-o removed a comment on issue #165: [MNG-6028] Include current goals in resume suggestion URL: https://github.com/apache/maven/pull/165#issuecomment-502388387 @hboutemy if we cannot agree on something let's make it general with `` otherwise we have goals, phases, options and properties. @hboutemy @rfscholte WDYT? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] michael-o removed a comment on issue #165: [MNG-6028] Include current goals in resume suggestion
michael-o removed a comment on issue #165: [MNG-6028] Include current goals in resume suggestion URL: https://github.com/apache/maven/pull/165#issuecomment-521428019 @splatch, I think we won't come to a conclusion here. Since `` is incomplete right now, let's rename to `` for now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] michael-o edited a comment on issue #165: [MNG-6028] Include current goals in resume suggestion
michael-o edited a comment on issue #165: [MNG-6028] Include current goals in resume suggestion URL: https://github.com/apache/maven/pull/165#issuecomment-502388387 @hboutemy if we cannot agree on something let's make it general with `` otherwise we have goals, phases, options and properties. @hboutemy @rfscholte WDYT? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] michael-o commented on issue #165: [MNG-6028] Include current goals in resume suggestion
michael-o commented on issue #165: [MNG-6028] Include current goals in resume suggestion URL: https://github.com/apache/maven/pull/165#issuecomment-521428019 @splatch, I think we won't come to a conclusion here. Since `` is incomplete right now, let's rename to `` for now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (MNG-6432) Space in silently disables mirror
[
https://issues.apache.org/jira/browse/MNG-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-6432.
---
Resolution: Later
Assignee: Michael Osipov
Fix Version/s: (was: wontfix-candidate)
Closing this -- as it would require to trim everywhere to make this consistent.
It has been documented and may be fixed in 4.x.
> Space in silently disables mirror
> --
>
> Key: MNG-6432
> URL: https://issues.apache.org/jira/browse/MNG-6432
> Project: Maven
> Issue Type: Bug
> Components: Settings
>Affects Versions: 3.0.5, 3.3.9, 3.5.2
> Environment: Maven 3.5.2 (Red Hat 3.5.2-5 on Fedora 28).
> and
> Maven 3.0.5 (Red Hat 3.0.5-17 on RHEL 7.5)
> and
> Maven 3.3.9 on RHEL 7.5
>Reporter: Elias Elmqvist Wulcan
>Assignee: Michael Osipov
>Priority: Minor
> Labels: newbie
> Attachments: Possible list of hits.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
>
> Maven silently ignores mirror configuration when there is a space in
> mirrorOf. This could be a major problem if the developer's mirror
> configuration is critical and this causes her to not notice that the mirror
> is disabled.
> Without space inside mirrorOf, the mirror setting is respected.
> {code:java}
>
>
>
> loopback
> loopback
> http://127.0.0.1
> !my-repo,*
>
>
>
> {code}
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
>
> [INFO] Building mirrorOf-test 1
> [INFO]
>
> Downloading from loopback:
> http://127.0.0.1/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom
> {noformat}
>
> With a space after the comma in mirrorOf, the mirror is ignored without
> warning.
> {code:java}
>
>
>
> loopback
> loopback
> http://127.0.0.1
> !my-repo, *
>
>
>
> {code}
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
>
> [INFO] Building mirrorOf-test 1
> [INFO]
>
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom
> ...
> {noformat}
>
> The problem is reproducible with minimal pom.xm
> {code:java}
>
> 4.0.0
> com.example
> mirrorOf-test
> 1
>
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Closed] (MNG-6469) Upload to Nexus hangs
[
https://issues.apache.org/jira/browse/MNG-6469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-6469.
---
Resolution: Cannot Reproduce
Assignee: Michael Osipov (was: Sylwester Lachiewicz)
Fix Version/s: (was: wontfix-candidate)
Sorry, I have tried hard, but simply cannot reproduce this one. No one was able
to provide a reproducer.
> Upload to Nexus hangs
> -
>
> Key: MNG-6469
> URL: https://issues.apache.org/jira/browse/MNG-6469
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.5.4
> Environment: macOS High Sierra 10.13.6
>Reporter: Haotian Wu
>Assignee: Michael Osipov
>Priority: Minor
> Attachments: maven_3.5.3.log, maven_3.5.4.log
>
>
> I am able to upload my project to Nexus staging successfully using Maven
> 3.3.9. But if I switch to maven 3.5.4 to upload the same project the upload
> will just hang forever during the uploading process. I have to use -X to see
> the actual stack trace:
> {noformat}
> [DEBUG] Failed to dispatch transfer event 'PUT PROGRESSED
> http://oss.sonatype.org/service/local/staging/deploy/maven2/myProject.pom <>
> /Users/haotianw/workplace/myProject/pom.xml' to
> org.apache.maven.cli.transfer.ConsoleMavenTransferListener
> java.lang.IllegalArgumentException: progressed file size cannot be greater
> than size: 6984 > 4936
> at org.apache.commons.lang3.Validate.isTrue (Validate.java:158)
> at
> org.apache.maven.cli.transfer.AbstractMavenTransferListener$FileSizeFormat.formatProgress
> (AbstractMavenTransferListener.java:195)
> at org.apache.maven.cli.transfer.ConsoleMavenTransferListener.getStatus
> (ConsoleMavenTransferListener.java:117)
> at
> org.apache.maven.cli.transfer.ConsoleMavenTransferListener.transferProgressed
> (ConsoleMavenTransferListener.java:90)
> at org.eclipse.aether.internal.impl.SafeTransferListener.transferProgressed
> (SafeTransferListener.java:114)
> at
> org.eclipse.aether.connector.basic.TransferTransportListener.transportProgressed
> (TransferTransportListener.java:95)
> at org.eclipse.aether.transport.wagon.WagonTransferListener.transferProgress
> (WagonTransferListener.java:64)
> at org.apache.maven.wagon.events.TransferEventSupport.fireTransferProgress
> (TransferEventSupport.java:121)
> at org.apache.maven.wagon.AbstractWagon.fireTransferProgress
> (AbstractWagon.java:594)
> at
> org.apache.maven.wagon.providers.http.wagon.shared.AbstractHttpClientWagon.access$100
> (AbstractHttpClientWagon.java:96)
> at
> org.apache.maven.wagon.providers.http.wagon.shared.AbstractHttpClientWagon$RequestEntityImplementation.writeTo
> (AbstractHttpClientWagon.java:194)
> at
> org.apache.maven.wagon.providers.http.httpclient.impl.DefaultBHttpClientConnection.sendRequestEntity
> (DefaultBHttpClientConnection.java:156)
> at
> org.apache.maven.wagon.providers.http.httpclient.impl.conn.CPoolProxy.sendRequestEntity
> (CPoolProxy.java:160)
> at
> org.apache.maven.wagon.providers.http.httpclient.protocol.HttpRequestExecutor.doSendRequest
> (HttpRequestExecutor.java:238)
> at
> org.apache.maven.wagon.providers.http.httpclient.protocol.HttpRequestExecutor.execute
> (HttpRequestExecutor.java:123)
> at
> org.apache.maven.wagon.providers.http.httpclient.impl.execchain.MainClientExec.execute
> (MainClientExec.java:272)
> at
> org.apache.maven.wagon.providers.http.httpclient.impl.execchain.ProtocolExec.execute
> (ProtocolExec.java:185)
> at
> org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec.execute
> (RetryExec.java:89)
> at
> org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RedirectExec.execute
> (RedirectExec.java:111)
> at
> org.apache.maven.wagon.providers.http.httpclient.impl.client.InternalHttpClient.doExecute
> (InternalHttpClient.java:185)
> at
> org.apache.maven.wagon.providers.http.httpclient.impl.client.CloseableHttpClient.execute
> (CloseableHttpClient.java:83)
> at
> org.apache.maven.wagon.providers.http.wagon.shared.AbstractHttpClientWagon.execute
> (AbstractHttpClientWagon.java:825)
> at
> org.apache.maven.wagon.providers.http.wagon.shared.AbstractHttpClientWagon.put
> (AbstractHttpClientWagon.java:587)
> at
> org.apache.maven.wagon.providers.http.wagon.shared.AbstractHttpClientWagon.put
> (AbstractHttpClientWagon.java:544)
> at
> org.apache.maven.wagon.providers.http.wagon.shared.AbstractHttpClientWagon.put
> (AbstractHttpClientWagon.java:608)
> at
> org.apache.maven.wagon.providers.http.wagon.shared.AbstractHttpClientWagon.put
> (AbstractHttpClientWagon.java:544)
> at
> org.apache.maven.wagon.providers.http.wagon.shared.AbstractHttpClientWagon.put
> (AbstractHttpClientWagon.java:526)
> at
> org.apache.maven.wagon.providers.http.wagon.shared.AbstractHttpClientWagon.put
> (AbstractHttpClientWagon.java:
[jira] [Commented] (MNG-6725) Skip '.mavenrc' via MAVEN_SKIP_RC=1 and '-Dmaven.skip.rc=true' on child ITs (by default on Jenkins CI).
[
https://issues.apache.org/jira/browse/MNG-6725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907634#comment-16907634
]
Michael Osipov commented on MNG-6725:
-
Can we drop the release version? Nothing has been fixed in {{maven.git}}, but
solely on the ITs.
> Skip '.mavenrc' via MAVEN_SKIP_RC=1 and '-Dmaven.skip.rc=true' on child ITs
> (by default on Jenkins CI).
> ---
>
> Key: MNG-6725
> URL: https://issues.apache.org/jira/browse/MNG-6725
> Project: Maven
> Issue Type: Task
> Components: Integration Tests
> Environment: ASF Jenkins CI
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.6.x-candidate
>
>
> This is related to the problem with MAVEN_OPTS.
> If Jenkins has global '.mavenrc' then the environment variables are merged
> with local ones and applied in Maven JVM which is controlled by
> $MVN_HOME/bin/mvn
> If you want to isolate the JVM from global '.mavenrc', you have to set
> environment variable to non-zero length value, i.e. MAVEN_SKIP_RC=1.
> This commit controls skipping '.mavenrc' in
> {{AbstractMavenIntegrationTestCase}}.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (MNG-6731) Jetty getLocalPort() returns -1 resulting in build failures
[
https://issues.apache.org/jira/browse/MNG-6731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907633#comment-16907633
]
Michael Osipov commented on MNG-6731:
-
Can we drop the release version? Nothing has been fixed in {{maven.git}}, but
solely on the ITs.
> Jetty getLocalPort() returns -1 resulting in build failures
> ---
>
> Key: MNG-6731
> URL: https://issues.apache.org/jira/browse/MNG-6731
> Project: Maven
> Issue Type: Bug
> Components: Integration Tests
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.6.2, 3.6.x-candidate
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> We observed sporadic errors [1] fir the project {{core-its}} on Jenkins.
> So I started haveing a look and I say the JavaDoc of the method
> {{getlocalPort}} saying that {{-1}} is returned if the connector is not open.
> So I decided to use [2] and wait until the server is up. This was of course
> wrong because the status of the server is set to {{STARTED}} immediatelly
> after the method {{Server.start()}}. So therefore I was googling a little bit
> and I found that Hadoop [3] had this problem too in 2010. Whole problem was
> with a bug in Jetty server which is {{race condition}}. The article has a
> link to Jetty's Jira with reported bug {{JETTY-748}}. According to the
> annoucements [4] from Eclipse/Jetty, the bug "{{JETTY-748 Prevent race close
> of socket by old acceptor threads}}" was fixed in the version
> {{jetty-7.2.1.v2010}}. So I decided to use that version but I found that
> the class {{HashUserRealm}} was deleted and there is no support and no
> further development of {{org.mortbay}}. Eclipse continues with the
> development of Jerry 9.
> All I did in this issue was to rewrite 38 integration tests to Jetty 9 API
> and the fix for {{JETTY-748}} is right there.
> [1]:
> Error message in logs: [WARNING] Could not transfer metadata
> org.apache.maven.its.mng4554/maven-metadata.xml from/to central
> (http://localhost:-1/repo-1): Connect to localhost:80 [localhost/127.0.0.1,
> localhost/0:0:0:0:0:0:0:1] failed: Connection refused: connect
> [2]:
> {code:java}
> while ( !server.isRunning() || !server.isStarted() )
> {
> if ( server.isFailed() )
> {
> fail( "Couldn't bind the server socket to a free port!" );
> }
> Thread.sleep( 100L );
> }
> {code}
> [3]:
> https://www.bountysource.com/issues/987313-jetty-returns-1-resulting-in-hadoop-masters-slaves-to-fail-during-startup
> [4]:
> https://www.eclipse.org/lists/jetty-dev/msg00537.html
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (MRESOLVER-7) Download dependency POMs in parallel
[ https://issues.apache.org/jira/browse/MRESOLVER-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907627#comment-16907627 ] Hudson commented on MRESOLVER-7: Build succeeded in Jenkins: Maven TLP » maven-resolver » master #30 See https://builds.apache.org/job/maven-box/job/maven-resolver/job/master/30/ > Download dependency POMs in parallel > > > Key: MRESOLVER-7 > URL: https://issues.apache.org/jira/browse/MRESOLVER-7 > Project: Maven Resolver > Issue Type: Improvement >Affects Versions: Aether 1.0.2 >Reporter: Harald Wellmann >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > h3. Background > When building a project with dependencies not yet available in the local > repository, I noticed that Maven 3.3.9/Aether 1.0.2 first downloads the > dependency POMs _sequentially_ and then proceeds downloading the dependency > JARs with up to 5 threads _in parallel_. > Due to this, when first building a project with a large number of > dependencies, downloading a large number of small POMs may take a lot longer > than downloading the much larger JARs, or even longer than building the > project itself, especially when a repository manager is used which increases > the download latency. > h3. Enhancement > Download POMs of (transitive) dependencies in parallel to significantly speed > up initial builds of large projects. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (MRESOLVER-92) Revert MRESOLVER-7
[ https://issues.apache.org/jira/browse/MRESOLVER-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907626#comment-16907626 ] Hudson commented on MRESOLVER-92: - Build succeeded in Jenkins: Maven TLP » maven-resolver » master #30 See https://builds.apache.org/job/maven-box/job/maven-resolver/job/master/30/ > Revert MRESOLVER-7 > -- > > Key: MRESOLVER-92 > URL: https://issues.apache.org/jira/browse/MRESOLVER-92 > Project: Maven Resolver > Issue Type: Task > Components: resolver >Affects Versions: 1.4.0 >Reporter: Michael Osipov >Assignee: Tibor Digana >Priority: Major > Fix For: 1.4.1 > > Time Spent: 20m > Remaining Estimate: 0h > > MRESOLVER-7 introduced subtile bugs which need to be fixed first. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Closed] (MNG-6731) Jetty getLocalPort() returns -1 resulting in build failures
[
https://issues.apache.org/jira/browse/MNG-6731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana closed MNG-6731.
-
Resolution: Fixed
https://gitbox.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=95fd13d670137fee44381139dbe3655b69fafe39
> Jetty getLocalPort() returns -1 resulting in build failures
> ---
>
> Key: MNG-6731
> URL: https://issues.apache.org/jira/browse/MNG-6731
> Project: Maven
> Issue Type: Bug
> Components: Integration Tests
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.6.2, 3.6.x-candidate
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> We observed sporadic errors [1] fir the project {{core-its}} on Jenkins.
> So I started haveing a look and I say the JavaDoc of the method
> {{getlocalPort}} saying that {{-1}} is returned if the connector is not open.
> So I decided to use [2] and wait until the server is up. This was of course
> wrong because the status of the server is set to {{STARTED}} immediatelly
> after the method {{Server.start()}}. So therefore I was googling a little bit
> and I found that Hadoop [3] had this problem too in 2010. Whole problem was
> with a bug in Jetty server which is {{race condition}}. The article has a
> link to Jetty's Jira with reported bug {{JETTY-748}}. According to the
> annoucements [4] from Eclipse/Jetty, the bug "{{JETTY-748 Prevent race close
> of socket by old acceptor threads}}" was fixed in the version
> {{jetty-7.2.1.v2010}}. So I decided to use that version but I found that
> the class {{HashUserRealm}} was deleted and there is no support and no
> further development of {{org.mortbay}}. Eclipse continues with the
> development of Jerry 9.
> All I did in this issue was to rewrite 38 integration tests to Jetty 9 API
> and the fix for {{JETTY-748}} is right there.
> [1]:
> Error message in logs: [WARNING] Could not transfer metadata
> org.apache.maven.its.mng4554/maven-metadata.xml from/to central
> (http://localhost:-1/repo-1): Connect to localhost:80 [localhost/127.0.0.1,
> localhost/0:0:0:0:0:0:0:1] failed: Connection refused: connect
> [2]:
> {code:java}
> while ( !server.isRunning() || !server.isStarted() )
> {
> if ( server.isFailed() )
> {
> fail( "Couldn't bind the server socket to a free port!" );
> }
> Thread.sleep( 100L );
> }
> {code}
> [3]:
> https://www.bountysource.com/issues/987313-jetty-returns-1-resulting-in-hadoop-masters-slaves-to-fail-during-startup
> [4]:
> https://www.eclipse.org/lists/jetty-dev/msg00537.html
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [maven-integration-testing] Tibor17 merged pull request #46: [MNG-6731] Jetty getLocalPort() returns -1 resulting in build failures
Tibor17 merged pull request #46: [MNG-6731] Jetty getLocalPort() returns -1 resulting in build failures URL: https://github.com/apache/maven-integration-testing/pull/46 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (MRESOLVER-92) Revert MRESOLVER-7
[ https://issues.apache.org/jira/browse/MRESOLVER-92?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed MRESOLVER-92. - Resolution: Done https://gitbox.apache.org/repos/asf?p=maven-resolver.git;a=commit;h=18dd2b5cde851256a9f44db25097efee0691d6b4 > Revert MRESOLVER-7 > -- > > Key: MRESOLVER-92 > URL: https://issues.apache.org/jira/browse/MRESOLVER-92 > Project: Maven Resolver > Issue Type: Task > Components: resolver >Affects Versions: 1.4.0 >Reporter: Michael Osipov >Assignee: Tibor Digana >Priority: Major > Fix For: 1.4.1 > > Time Spent: 20m > Remaining Estimate: 0h > > MRESOLVER-7 introduced subtile bugs which need to be fixed first. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [maven-resolver] Tibor17 merged pull request #38: [MRESOLVER-92] Revert MRESOLVER-7
Tibor17 merged pull request #38: [MRESOLVER-92] Revert MRESOLVER-7 URL: https://github.com/apache/maven-resolver/pull/38 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-integration-testing] Tibor17 commented on issue #46: [MNG-6731] Jetty getLocalPort() returns -1 resulting in build failures
Tibor17 commented on issue #46: [MNG-6731] Jetty getLocalPort() returns -1 resulting in build failures URL: https://github.com/apache/maven-integration-testing/pull/46#issuecomment-521405274 No. At least it was not me! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-integration-testing] Tibor17 removed a comment on issue #46: [MNG-6731] Jetty getLocalPort() returns -1 resulting in build failures
Tibor17 removed a comment on issue #46: [MNG-6731] Jetty getLocalPort() returns -1 resulting in build failures URL: https://github.com/apache/maven-integration-testing/pull/46#issuecomment-521404831 not yet. I was watching TV ;-) Let me merge it. Thx This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-integration-testing] Tibor17 commented on issue #46: [MNG-6731] Jetty getLocalPort() returns -1 resulting in build failures
Tibor17 commented on issue #46: [MNG-6731] Jetty getLocalPort() returns -1 resulting in build failures URL: https://github.com/apache/maven-integration-testing/pull/46#issuecomment-521404831 not yet. I was watching TV ;-) Let me merge it. Thx This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-resolver] Tibor17 commented on a change in pull request #38: [MRESOLVER-92] Revert MRESOLVER-7
Tibor17 commented on a change in pull request #38: [MRESOLVER-92] Revert
MRESOLVER-7
URL: https://github.com/apache/maven-resolver/pull/38#discussion_r314063690
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java
##
@@ -86,12 +79,13 @@
implements DependencyCollector, Service
{
-static final String CONFIG_PROP_MAX_EXCEPTIONS =
"aether.dependencyCollector.maxExceptions";
+private static final String CONFIG_PROP_MAX_EXCEPTIONS =
"aether.dependencyCollector.maxExceptions";
+
+private static final int CONFIG_PROP_MAX_EXCEPTIONS_DEFAULT = 50;
Review comment:
It's from checkstyle failure. When I was building the project the
`maven-checkstyle-plugin` wanted me to declare a constant for unknown number
and string.
No idea how this project could be built without it till now.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-resolver] Tibor17 commented on a change in pull request #38: [MRESOLVER-92] Revert MRESOLVER-7
Tibor17 commented on a change in pull request #38: [MRESOLVER-92] Revert
MRESOLVER-7
URL: https://github.com/apache/maven-resolver/pull/38#discussion_r314063803
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java
##
@@ -86,12 +79,13 @@
implements DependencyCollector, Service
{
-static final String CONFIG_PROP_MAX_EXCEPTIONS =
"aether.dependencyCollector.maxExceptions";
+private static final String CONFIG_PROP_MAX_EXCEPTIONS =
"aether.dependencyCollector.maxExceptions";
+
+private static final int CONFIG_PROP_MAX_EXCEPTIONS_DEFAULT = 50;
-static final String CONFIG_PROP_MAX_CYCLES =
"aether.dependencyCollector.maxCycles";
+private static final String CONFIG_PROP_MAX_CYCLES =
"aether.dependencyCollector.maxCycles";
-private static final String CONFIG_PROP_THREADS =
"aether.artifactDescriptor.threads";
-private static final int DEFAULT_THREADS = 5;
+private static final int CONFIG_PROP_MAX_CYCLES_DEFAULT = 10;
Review comment:
The same as before.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-resolver] Tibor17 commented on a change in pull request #38: [MRESOLVER-92] Revert MRESOLVER-7
Tibor17 commented on a change in pull request #38: [MRESOLVER-92] Revert
MRESOLVER-7
URL: https://github.com/apache/maven-resolver/pull/38#discussion_r314063690
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java
##
@@ -86,12 +79,13 @@
implements DependencyCollector, Service
{
-static final String CONFIG_PROP_MAX_EXCEPTIONS =
"aether.dependencyCollector.maxExceptions";
+private static final String CONFIG_PROP_MAX_EXCEPTIONS =
"aether.dependencyCollector.maxExceptions";
+
+private static final int CONFIG_PROP_MAX_EXCEPTIONS_DEFAULT = 50;
Review comment:
It's from checkstyle failure. When I was building the project the
`maven-checkstyle-plugin` was wanted be to declare a constant for unknown
number and string.
No idea how this project could be built without it till now.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-integration-testing] michael-o commented on issue #46: [MNG-6731] Jetty getLocalPort() returns -1 resulting in build failures
michael-o commented on issue #46: [MNG-6731] Jetty getLocalPort() returns -1 resulting in build failures URL: https://github.com/apache/maven-integration-testing/pull/46#issuecomment-521400549 Didn't you merge this already? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-resolver] michael-o commented on a change in pull request #38: [MRESOLVER-92] Revert MRESOLVER-7
michael-o commented on a change in pull request #38: [MRESOLVER-92] Revert
MRESOLVER-7
URL: https://github.com/apache/maven-resolver/pull/38#discussion_r314058831
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java
##
@@ -86,12 +79,13 @@
implements DependencyCollector, Service
{
-static final String CONFIG_PROP_MAX_EXCEPTIONS =
"aether.dependencyCollector.maxExceptions";
+private static final String CONFIG_PROP_MAX_EXCEPTIONS =
"aether.dependencyCollector.maxExceptions";
+
+private static final int CONFIG_PROP_MAX_EXCEPTIONS_DEFAULT = 50;
-static final String CONFIG_PROP_MAX_CYCLES =
"aether.dependencyCollector.maxCycles";
+private static final String CONFIG_PROP_MAX_CYCLES =
"aether.dependencyCollector.maxCycles";
-private static final String CONFIG_PROP_THREADS =
"aether.artifactDescriptor.threads";
-private static final int DEFAULT_THREADS = 5;
+private static final int CONFIG_PROP_MAX_CYCLES_DEFAULT = 10;
Review comment:
Where does this one come from?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-resolver] michael-o commented on a change in pull request #38: [MRESOLVER-92] Revert MRESOLVER-7
michael-o commented on a change in pull request #38: [MRESOLVER-92] Revert
MRESOLVER-7
URL: https://github.com/apache/maven-resolver/pull/38#discussion_r314058812
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java
##
@@ -86,12 +79,13 @@
implements DependencyCollector, Service
{
-static final String CONFIG_PROP_MAX_EXCEPTIONS =
"aether.dependencyCollector.maxExceptions";
+private static final String CONFIG_PROP_MAX_EXCEPTIONS =
"aether.dependencyCollector.maxExceptions";
+
+private static final int CONFIG_PROP_MAX_EXCEPTIONS_DEFAULT = 50;
Review comment:
Where does this one come from?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-integration-testing] Tibor17 opened a new pull request #46: [MNG-6731] Jetty getLocalPort() returns -1 resulting in build failures
Tibor17 opened a new pull request #46: [MNG-6731] Jetty getLocalPort() returns -1 resulting in build failures URL: https://github.com/apache/maven-integration-testing/pull/46 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-resolver] Tibor17 opened a new pull request #38: [MRESOLVER-92] Revert MRESOLVER-7
Tibor17 opened a new pull request #38: [MRESOLVER-92] Revert MRESOLVER-7 URL: https://github.com/apache/maven-resolver/pull/38 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (SUREFIRE-1679) Caching of provider classpath with module-specific changes may break test bootstrapping in subsequent modules
[
https://issues.apache.org/jira/browse/SUREFIRE-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana closed SUREFIRE-1679.
--
Resolution: Fixed
https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=f7d43102173568f4272325ad71e334279b91db17
> Caching of provider classpath with module-specific changes may break test
> bootstrapping in subsequent modules
> -
>
> Key: SUREFIRE-1679
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1679
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.22.2, 3.0.0-M3
>Reporter: Andy Wilkinson
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M4
>
> Attachments: surefire-pollution-problem.zip
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I believe I've identified a bug in the caching that's performed by
> {{AbstractSurefireMojo}}. The problem that I am seeing is a failure to
> bootstrap Surefire:
>
> {noformat}
> [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: There
> was an error in the forked process
> [ERROR] java.lang.NoClassDefFoundError:
> org/junit/platform/launcher/core/LauncherFactory
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:657)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:283)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:246)
> [ERROR] at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1161)
> [ERROR] at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1002)
> [ERROR] at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:848)
> [ERROR] at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
> [ERROR] at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
> [ERROR] at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
> [ERROR] at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
> [ERROR] at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
> [ERROR] at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
> [ERROR] at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56)
> [ERROR] at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> [ERROR] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305)
> [ERROR] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192)
> [ERROR] at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105)
> [ERROR] at org.apache.maven.cli.MavenCli.execute(MavenCli.java:954)
> [ERROR] at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> [ERROR] at org.apache.maven.cli.MavenCli.main(MavenCli.java:192)
> [ERROR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> [ERROR] at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> [ERROR] at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> [ERROR] at java.lang.reflect.Method.invoke(Method.java:498)
> [ERROR] at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> [ERROR] at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> [ERROR] at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> [ERROR] at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356){noformat}
>
> This is in a module that uses Surefire and JUnit Jupiter 5.5:
>
> {noformat}
>
>
> org.junit.jupiter
> junit-jupiter
> 5.5.0
> test
>
>
>
>
>
> org.apache.maven.plugins
> maven-surefire-plugin
> 2.22.2
>
>
>
> {noformat}
>
> Earlier in the reactor, another project is built which depends on
> {{junit-platform-launcher}}:
>
> {noformat}
>
>
> org.junit.platform
> junit-platform-launcher
> 1.5.0
>
>
> org.junit.jupiter
> junit-jupiter
> 5.5.0
> test
>
>
>
>
>
>
[jira] [Assigned] (SUREFIRE-1679) Caching of provider classpath with module-specific changes may break test bootstrapping in subsequent modules
[
https://issues.apache.org/jira/browse/SUREFIRE-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana reassigned SUREFIRE-1679:
--
Assignee: Tibor Digana
> Caching of provider classpath with module-specific changes may break test
> bootstrapping in subsequent modules
> -
>
> Key: SUREFIRE-1679
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1679
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.22.2, 3.0.0-M3
>Reporter: Andy Wilkinson
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M4
>
> Attachments: surefire-pollution-problem.zip
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I believe I've identified a bug in the caching that's performed by
> {{AbstractSurefireMojo}}. The problem that I am seeing is a failure to
> bootstrap Surefire:
>
> {noformat}
> [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: There
> was an error in the forked process
> [ERROR] java.lang.NoClassDefFoundError:
> org/junit/platform/launcher/core/LauncherFactory
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:657)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:283)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:246)
> [ERROR] at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1161)
> [ERROR] at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1002)
> [ERROR] at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:848)
> [ERROR] at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
> [ERROR] at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
> [ERROR] at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
> [ERROR] at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
> [ERROR] at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
> [ERROR] at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
> [ERROR] at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56)
> [ERROR] at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> [ERROR] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305)
> [ERROR] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192)
> [ERROR] at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105)
> [ERROR] at org.apache.maven.cli.MavenCli.execute(MavenCli.java:954)
> [ERROR] at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> [ERROR] at org.apache.maven.cli.MavenCli.main(MavenCli.java:192)
> [ERROR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> [ERROR] at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> [ERROR] at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> [ERROR] at java.lang.reflect.Method.invoke(Method.java:498)
> [ERROR] at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> [ERROR] at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> [ERROR] at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> [ERROR] at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356){noformat}
>
> This is in a module that uses Surefire and JUnit Jupiter 5.5:
>
> {noformat}
>
>
> org.junit.jupiter
> junit-jupiter
> 5.5.0
> test
>
>
>
>
>
> org.apache.maven.plugins
> maven-surefire-plugin
> 2.22.2
>
>
>
> {noformat}
>
> Earlier in the reactor, another project is built which depends on
> {{junit-platform-launcher}}:
>
> {noformat}
>
>
> org.junit.platform
> junit-platform-launcher
> 1.5.0
>
>
> org.junit.jupiter
> junit-jupiter
> 5.5.0
> test
>
>
>
>
>
> org.apache.maven.plugins
> maven-surefire-plugin
>
[GitHub] [maven-surefire] Tibor17 merged pull request #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution
Tibor17 merged pull request #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution URL: https://github.com/apache/maven-surefire/pull/243 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution
Tibor17 commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution URL: https://github.com/apache/maven-surefire/pull/243#issuecomment-521377284 @wilkinsona Thx for contributing! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] rfscholte closed pull request #278: jump to version 3.7 for development to allow patch for 3.6
rfscholte closed pull request #278: jump to version 3.7 for development to allow patch for 3.6 URL: https://github.com/apache/maven/pull/278 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] rfscholte commented on issue #278: jump to version 3.7 for development to allow patch for 3.6
rfscholte commented on issue #278: jump to version 3.7 for development to allow patch for 3.6 URL: https://github.com/apache/maven/pull/278#issuecomment-521340945 I'm going to close this PR, next release will be 3.6.2 which should happen soon. We're not going to maintain multiple branches for this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-wagon] erikhakansson commented on issue #49: [MNG-2802] Concurrent-safe access to local Maven repository
erikhakansson commented on issue #49: [MNG-2802] Concurrent-safe access to local Maven repository URL: https://github.com/apache/maven-wagon/pull/49#issuecomment-521336418 I'll keep the issue open for now then. If you open up discussions elsewhere it might be good to link them from here so people who end up here can find them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution
Tibor17 commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution URL: https://github.com/apache/maven-surefire/pull/243#issuecomment-521304306 @wilkinsona thx, the build is in progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] wilkinsona edited a comment on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution
wilkinsona edited a comment on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution URL: https://github.com/apache/maven-surefire/pull/243#issuecomment-521295465 I've force-pushed the switch to a `HashMap` and the addition of a unit test. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] wilkinsona commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution
wilkinsona commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution URL: https://github.com/apache/maven-surefire/pull/243#issuecomment-521295465 I've forced pushed the switch to a `HashMap` and the addition of a unit test. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-6642) Tycho-based modules do not build with 3.6.1 (works with 3.6.0)
[
https://issues.apache.org/jira/browse/MNG-6642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907317#comment-16907317
]
Enrico Olivelli commented on MNG-6642:
--
I agree with Mickael.
I hope we can roll 3.6.2 out soon
> Tycho-based modules do not build with 3.6.1 (works with 3.6.0)
> --
>
> Key: MNG-6642
> URL: https://issues.apache.org/jira/browse/MNG-6642
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.6.1
>Reporter: Francesco Chicchiriccò
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.2
>
>
> Build does not work with Maven 3.6.1 (works fine with Maven 3.6.0).
> How to reproduce:
> # git clone https://github.com/apache/syncope.git
> # git checkout 2_1_X
> # $M2_HOME/bin/mvn clean
> When {{M2_HOME}} points to 3.6.0, build goes fine.
> When {{M2_HOME}} points to 3.6.1, the following output is reported:
> {code}
> [INFO] Scanning for projects...
> [INFO] Computing target platform for MavenProject:
> org.apache.syncope.ide.eclipse:org.apache.syncope.ide.eclipse.plugin:2.1.4-SNAPSHOT
> @
> /home/ilgrosso/work/syncope/syncope/ide/eclipse/bundles/org.apache.syncope.ide.eclipse.plugin/pom.xml
> [INFO] Resolving dependencies of MavenProject:
> org.apache.syncope.ide.eclipse:org.apache.syncope.ide.eclipse.plugin:2.1.4-SNAPSHOT
> @
> /home/ilgrosso/work/syncope/syncope/ide/eclipse/bundles/org.apache.syncope.ide.eclipse.plugin/pom.xml
> [INFO] {osgi.os=linux, osgi.ws=gtk, org.eclipse.update.install.features=true,
> osgi.arch=x86}
> [ERROR] Cannot resolve project dependencies:
> [ERROR] Software being installed: org.apache.syncope.ide.eclipse.plugin
> 2.1.4.qualifier
> [ERROR] Missing requirement: org.apache.syncope.ide.eclipse.plugin
> 2.1.4.qualifier requires 'osgi.bundle; org.eclipse.ui 0.0.0' but it could not
> be found
> [ERROR]
> [ERROR] See
> http://wiki.eclipse.org/Tycho/Dependency_Resolution_Troubleshooting for help.
> [ERROR] Cannot resolve dependencies of MavenProject:
> org.apache.syncope.ide.eclipse:org.apache.syncope.ide.eclipse.plugin:2.1.4-SNAPSHOT
> @
> /home/ilgrosso/work/syncope/syncope/ide/eclipse/bundles/org.apache.syncope.ide.eclipse.plugin/pom.xml:
> See log for details -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MavenExecutionException
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (MNG-6642) Tycho-based modules do not build with 3.6.1 (works with 3.6.0)
[
https://issues.apache.org/jira/browse/MNG-6642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907288#comment-16907288
]
Mickael Istria commented on MNG-6642:
-
FWIW, I think maintenance branches really add a lot of complexity and cost to
the project maintenance.
As a consumer and user, I would rather see Maven project getting more into a
rolling 1-click release process, just answering the question "is the current
state any better than previous release" and be ready to release whenever there
is a request and state is not worth (ie all test pass). That would IMO provide
much more value to everyone and once setup, it wouldn't cost anything to run a
release. For example, although there are still known bugs on master, if those
are not regressions, I don't really get why they would be blocking a highly
requested release.
The Eclipse SDK (Platform, JDT, PDE) recently dropped intensive usage of
maintenance branch, and it was a huge relief for the contributors, maintainers,
users... as more effort were put in master and value was delivered much faster
and the project attracted new contributors thanks to that.
> Tycho-based modules do not build with 3.6.1 (works with 3.6.0)
> --
>
> Key: MNG-6642
> URL: https://issues.apache.org/jira/browse/MNG-6642
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.6.1
>Reporter: Francesco Chicchiriccò
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.2
>
>
> Build does not work with Maven 3.6.1 (works fine with Maven 3.6.0).
> How to reproduce:
> # git clone https://github.com/apache/syncope.git
> # git checkout 2_1_X
> # $M2_HOME/bin/mvn clean
> When {{M2_HOME}} points to 3.6.0, build goes fine.
> When {{M2_HOME}} points to 3.6.1, the following output is reported:
> {code}
> [INFO] Scanning for projects...
> [INFO] Computing target platform for MavenProject:
> org.apache.syncope.ide.eclipse:org.apache.syncope.ide.eclipse.plugin:2.1.4-SNAPSHOT
> @
> /home/ilgrosso/work/syncope/syncope/ide/eclipse/bundles/org.apache.syncope.ide.eclipse.plugin/pom.xml
> [INFO] Resolving dependencies of MavenProject:
> org.apache.syncope.ide.eclipse:org.apache.syncope.ide.eclipse.plugin:2.1.4-SNAPSHOT
> @
> /home/ilgrosso/work/syncope/syncope/ide/eclipse/bundles/org.apache.syncope.ide.eclipse.plugin/pom.xml
> [INFO] {osgi.os=linux, osgi.ws=gtk, org.eclipse.update.install.features=true,
> osgi.arch=x86}
> [ERROR] Cannot resolve project dependencies:
> [ERROR] Software being installed: org.apache.syncope.ide.eclipse.plugin
> 2.1.4.qualifier
> [ERROR] Missing requirement: org.apache.syncope.ide.eclipse.plugin
> 2.1.4.qualifier requires 'osgi.bundle; org.eclipse.ui 0.0.0' but it could not
> be found
> [ERROR]
> [ERROR] See
> http://wiki.eclipse.org/Tycho/Dependency_Resolution_Troubleshooting for help.
> [ERROR] Cannot resolve dependencies of MavenProject:
> org.apache.syncope.ide.eclipse:org.apache.syncope.ide.eclipse.plugin:2.1.4-SNAPSHOT
> @
> /home/ilgrosso/work/syncope/syncope/ide/eclipse/bundles/org.apache.syncope.ide.eclipse.plugin/pom.xml:
> See log for details -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MavenExecutionException
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (MNG-6642) Tycho-based modules do not build with 3.6.1 (works with 3.6.0)
[
https://issues.apache.org/jira/browse/MNG-6642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907262#comment-16907262
]
Felix Otto commented on MNG-6642:
-
Can't we simply release a patch containing only the required correction from a
maintenance branch [1] and increase the version in master to 3.7 [2]? In the
past there have been dedicated maintenance branches. [3]
[1] [https://github.com/apache/maven/pull/278]
[2] https://github.com/FelixOtto/maven/commits/maven-3.6.x
[3] https://github.com/apache/maven/branches/all?utf8=%E2%9C%93&query=maven-3
> Tycho-based modules do not build with 3.6.1 (works with 3.6.0)
> --
>
> Key: MNG-6642
> URL: https://issues.apache.org/jira/browse/MNG-6642
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.6.1
>Reporter: Francesco Chicchiriccò
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.2
>
>
> Build does not work with Maven 3.6.1 (works fine with Maven 3.6.0).
> How to reproduce:
> # git clone https://github.com/apache/syncope.git
> # git checkout 2_1_X
> # $M2_HOME/bin/mvn clean
> When {{M2_HOME}} points to 3.6.0, build goes fine.
> When {{M2_HOME}} points to 3.6.1, the following output is reported:
> {code}
> [INFO] Scanning for projects...
> [INFO] Computing target platform for MavenProject:
> org.apache.syncope.ide.eclipse:org.apache.syncope.ide.eclipse.plugin:2.1.4-SNAPSHOT
> @
> /home/ilgrosso/work/syncope/syncope/ide/eclipse/bundles/org.apache.syncope.ide.eclipse.plugin/pom.xml
> [INFO] Resolving dependencies of MavenProject:
> org.apache.syncope.ide.eclipse:org.apache.syncope.ide.eclipse.plugin:2.1.4-SNAPSHOT
> @
> /home/ilgrosso/work/syncope/syncope/ide/eclipse/bundles/org.apache.syncope.ide.eclipse.plugin/pom.xml
> [INFO] {osgi.os=linux, osgi.ws=gtk, org.eclipse.update.install.features=true,
> osgi.arch=x86}
> [ERROR] Cannot resolve project dependencies:
> [ERROR] Software being installed: org.apache.syncope.ide.eclipse.plugin
> 2.1.4.qualifier
> [ERROR] Missing requirement: org.apache.syncope.ide.eclipse.plugin
> 2.1.4.qualifier requires 'osgi.bundle; org.eclipse.ui 0.0.0' but it could not
> be found
> [ERROR]
> [ERROR] See
> http://wiki.eclipse.org/Tycho/Dependency_Resolution_Troubleshooting for help.
> [ERROR] Cannot resolve dependencies of MavenProject:
> org.apache.syncope.ide.eclipse:org.apache.syncope.ide.eclipse.plugin:2.1.4-SNAPSHOT
> @
> /home/ilgrosso/work/syncope/syncope/ide/eclipse/bundles/org.apache.syncope.ide.eclipse.plugin/pom.xml:
> See log for details -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MavenExecutionException
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Comment Edited] (MNG-6642) Tycho-based modules do not build with 3.6.1 (works with 3.6.0)
[
https://issues.apache.org/jira/browse/MNG-6642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907262#comment-16907262
]
Felix Otto edited comment on MNG-6642 at 8/14/19 1:31 PM:
--
Can't we simply release a patch containing only the required correction from a
maintenance branch [1] and increase the version in master to 3.7 [2]? In the
past there have been dedicated maintenance branches. [3]
[1] https://github.com/FelixOtto/maven/commits/maven-3.6.x
[2] [https://github.com/apache/maven/pull/278]
[3] https://github.com/apache/maven/branches/all?utf8=%E2%9C%93&query=maven-3
was (Author: fotto):
Can't we simply release a patch containing only the required correction from a
maintenance branch [1] and increase the version in master to 3.7 [2]? In the
past there have been dedicated maintenance branches. [3]
[1] [https://github.com/apache/maven/pull/278]
[2] https://github.com/FelixOtto/maven/commits/maven-3.6.x
[3] https://github.com/apache/maven/branches/all?utf8=%E2%9C%93&query=maven-3
> Tycho-based modules do not build with 3.6.1 (works with 3.6.0)
> --
>
> Key: MNG-6642
> URL: https://issues.apache.org/jira/browse/MNG-6642
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.6.1
>Reporter: Francesco Chicchiriccò
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.2
>
>
> Build does not work with Maven 3.6.1 (works fine with Maven 3.6.0).
> How to reproduce:
> # git clone https://github.com/apache/syncope.git
> # git checkout 2_1_X
> # $M2_HOME/bin/mvn clean
> When {{M2_HOME}} points to 3.6.0, build goes fine.
> When {{M2_HOME}} points to 3.6.1, the following output is reported:
> {code}
> [INFO] Scanning for projects...
> [INFO] Computing target platform for MavenProject:
> org.apache.syncope.ide.eclipse:org.apache.syncope.ide.eclipse.plugin:2.1.4-SNAPSHOT
> @
> /home/ilgrosso/work/syncope/syncope/ide/eclipse/bundles/org.apache.syncope.ide.eclipse.plugin/pom.xml
> [INFO] Resolving dependencies of MavenProject:
> org.apache.syncope.ide.eclipse:org.apache.syncope.ide.eclipse.plugin:2.1.4-SNAPSHOT
> @
> /home/ilgrosso/work/syncope/syncope/ide/eclipse/bundles/org.apache.syncope.ide.eclipse.plugin/pom.xml
> [INFO] {osgi.os=linux, osgi.ws=gtk, org.eclipse.update.install.features=true,
> osgi.arch=x86}
> [ERROR] Cannot resolve project dependencies:
> [ERROR] Software being installed: org.apache.syncope.ide.eclipse.plugin
> 2.1.4.qualifier
> [ERROR] Missing requirement: org.apache.syncope.ide.eclipse.plugin
> 2.1.4.qualifier requires 'osgi.bundle; org.eclipse.ui 0.0.0' but it could not
> be found
> [ERROR]
> [ERROR] See
> http://wiki.eclipse.org/Tycho/Dependency_Resolution_Troubleshooting for help.
> [ERROR] Cannot resolve dependencies of MavenProject:
> org.apache.syncope.ide.eclipse:org.apache.syncope.ide.eclipse.plugin:2.1.4-SNAPSHOT
> @
> /home/ilgrosso/work/syncope/syncope/ide/eclipse/bundles/org.apache.syncope.ide.eclipse.plugin/pom.xml:
> See log for details -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MavenExecutionException
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [maven] FelixOtto opened a new pull request #278: jump to version 3.7 for development to allow patch for 3.6
FelixOtto opened a new pull request #278: jump to version 3.7 for development to allow patch for 3.6 URL: https://github.com/apache/maven/pull/278 To provide a maven version working properly with with tycho, I propose to increase the minor version for the next one including new features. Afterwards the current minor version can be used to provide a patch for 3.6. https://issues.apache.org/jira/browse/MNG-6642 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution
Tibor17 commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution URL: https://github.com/apache/maven-surefire/pull/243#issuecomment-521220085 @wilkinsona The cache has `ConcurrentHashMap`. If you agree, this Map can be turned to the pure `HashMap`. At least I do not see any multithreading in this MOJO class. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] olamy commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution
olamy commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution URL: https://github.com/apache/maven-surefire/pull/243#issuecomment-521198136 @wilkinsona read this one https://stackoverflow.blog/2017/06/15/developers-use-spaces-make-money-use-tabs/ :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] wilkinsona commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution
wilkinsona commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution URL: https://github.com/apache/maven-surefire/pull/243#issuecomment-521186877 Oops. Sorry. I've force-pushed a fix for that. I'll take a look at unit tests shortly. Given that the old `ClasspathCache` is now unused (as far as I can tell), I'm not sure that it'll be possible to maintain the same level of coverage. However, I can at least try to add a test that verifies the pollution has been fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] Tibor17 edited a comment on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution
Tibor17 edited a comment on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution URL: https://github.com/apache/maven-surefire/pull/243#issuecomment-521164814 @wilkinsona Can you please add unit tests and fully cover your cache? I want to keep the code coverage on current level at least or higher. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution
Tibor17 commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution URL: https://github.com/apache/maven-surefire/pull/243#issuecomment-521168378 @wilkinsona There is checkstyle errors. You can see this if you build the project locally `mvn install`. ``` 11:05:39 [INFO] --- maven-checkstyle-plugin:3.0.0:check (checkstyle-check) @ maven-surefire-common --- 11:05:41 [INFO] There are 5 errors reported by Checkstyle 6.18 with config/maven_checks.xml ruleset. 11:05:41 [ERROR] src\main\java\org\apache\maven\plugin\surefire\AbstractSurefireMojo.java:[3856,9] (whitespace) FileTabCharacter: Line contains a tab character. 11:05:41 [INFO] Ignored 4 errors, 1 violation remaining. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution
Tibor17 commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution URL: https://github.com/apache/maven-surefire/pull/243#issuecomment-521164814 @wilkinsona Can you please add unit tests and fully core your cache? I want to keep the code coverage on current level at least or higher. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution
Tibor17 commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution URL: https://github.com/apache/maven-surefire/pull/243#issuecomment-521163824 The build is currently running https://builds.apache.org/job/maven-box/job/maven-surefire/job/SUREFIRE-1679/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MSHADE-306) Log all duplicates, not only classes
[ https://issues.apache.org/jira/browse/MSHADE-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907023#comment-16907023 ] Hudson commented on MSHADE-306: --- Build succeeded in Jenkins: Maven TLP » maven-shade-plugin » master #19 See https://builds.apache.org/job/maven-box/job/maven-shade-plugin/job/master/19/ > Log all duplicates, not only classes > > > Key: MSHADE-306 > URL: https://issues.apache.org/jira/browse/MSHADE-306 > Project: Maven Shade Plugin > Issue Type: New Feature >Reporter: Romain Manni-Bucau >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Issue to silently swallow duplicated resources is that you don't see, even in > debug, that there is a choice done by the plugin. This breaks the final app > in a lot of cases (all SPI-like cases, OSGi for the MANIFEST.MF etc...). So > let's log it as for classes. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (MSHADE-322) Provide a transformer for properties files
[ https://issues.apache.org/jira/browse/MSHADE-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907022#comment-16907022 ] Hudson commented on MSHADE-322: --- Build succeeded in Jenkins: Maven TLP » maven-shade-plugin » master #19 See https://builds.apache.org/job/maven-box/job/maven-shade-plugin/job/master/19/ > Provide a transformer for properties files > -- > > Key: MSHADE-322 > URL: https://issues.apache.org/jira/browse/MSHADE-322 > Project: Maven Shade Plugin > Issue Type: Task >Affects Versions: 3.2.1 >Reporter: Romain Manni-Bucau >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > The goal is to be able to merge properties deterministicly and respecting > ordinal common practise. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [maven-surefire] Tibor17 commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution
Tibor17 commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution URL: https://github.com/apache/maven-surefire/pull/243#issuecomment-521147055 @wilkinsona Thx, LGTM I will make ASF branch and trigger Jenkins. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (MCOMPILER-395) annotationProcessorPaths should accept exclusions
Olivier Grégoire created MCOMPILER-395: -- Summary: annotationProcessorPaths should accept exclusions Key: MCOMPILER-395 URL: https://issues.apache.org/jira/browse/MCOMPILER-395 Project: Maven Compiler Plugin Issue Type: Wish Affects Versions: 3.8.1 Reporter: Olivier Grégoire Similar to MCOMPILER-391, as a user, I should be able to add exclusions to the dependency coordinates in annotationProcessorPaths. Rationale: not everyone uses `dependencyManagement`, and would expect to describe the compile-time dependency directly in `annotationProcessorPaths.path`, just like a usual runtime dependency. Use case: https://stackoverflow.com/q/57490437/180719 -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [maven-surefire] wilkinsona opened a new pull request #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution
wilkinsona opened a new pull request #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution URL: https://github.com/apache/maven-surefire/pull/243 This PR should fix [SUREFIRE-1679](https://issues.apache.org/jira/browse/SUREFIRE-1679). Once the changes have been reviewed and approved, I'll open another PR to backport them to 2.x. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
