[GitHub] [maven] hboutemy commented on issue #274: [MNG-6716] Test and fix erroneous compileRoots

2019-08-18 Thread GitBox
hboutemy commented on issue #274: [MNG-6716] Test and fix erroneous compileRoots
URL: https://github.com/apache/maven/pull/274#issuecomment-522418232
 
 
   @michael-o you asked (on the Jira issue) the user to check that the PR fixed 
the issue: I did it
   Robert wanted to see a green build: it is there
   I personally don't get more the content of the fix than you and Robert: I'm 
ok with you on "merge when ev erything is green"


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-indexer] eolivelli commented on issue #39: Add getName() to Record.EntryKey

2019-08-18 Thread GitBox
eolivelli commented on issue #39: Add getName() to Record.EntryKey
URL: https://github.com/apache/maven-indexer/pull/39#issuecomment-522411442
 
 
   Thanks.
   I forgot to link the guide for you
   https://maven.apache.org/developers/conventions/git.html
   
   The only missing part is to cite the ticket at the beginning of the message. 
I can do it
   
   We use JIRA to organize the release notes and keep track of want is 
delivered on each version.
   Maven project is made of about 100 subprojects and we need some paperwork in 
order not to forget or to follow the wrong way


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-indexer] sixcorners commented on issue #39: Add getName() to Record.EntryKey

2019-08-18 Thread GitBox
sixcorners commented on issue #39: Add getName() to Record.EntryKey
URL: https://github.com/apache/maven-indexer/pull/39#issuecomment-522368391
 
 
   I went ahead and added some stuff to the commit message.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-indexer] sixcorners commented on issue #38: Change indexer-reader's Utils to call read() once

2019-08-18 Thread GitBox
sixcorners commented on issue #38: Change indexer-reader's Utils to call read() 
once
URL: https://github.com/apache/maven-indexer/pull/38#issuecomment-522367108
 
 
   By resource leak I don't mean an instance of the resource class. I mean an 
InputStream that doesn't get closed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-indexer] sixcorners edited a comment on issue #39: Add getName() to Record.EntryKey

2019-08-18 Thread GitBox
sixcorners edited a comment on issue #39: Add getName() to Record.EntryKey
URL: https://github.com/apache/maven-indexer/pull/39#issuecomment-522366852
 
 
   Are you saying I should remove "I don't want to parse the output from 
toString()" or add more detail to the commit message? "I don't want to parse 
the output from toString()" is only added to the pull request. I didn't put it 
in the commit message.
   
   I made this: https://issues.apache.org/jira/browse/MINDEXER-122 Do all 
public API changes have to have a JIRA ticket?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-indexer] sixcorners edited a comment on issue #39: Add getName() to Record.EntryKey

2019-08-18 Thread GitBox
sixcorners edited a comment on issue #39: Add getName() to Record.EntryKey
URL: https://github.com/apache/maven-indexer/pull/39#issuecomment-522366852
 
 
   Are you saying I should remove "I don't want to parse the output from 
toString()" or add more detail to the commit message? "I don't want to parse 
the output from toString()" is only added to the pull request. I didn't put it 
in the commit message.
   
   I made this: https://issues.apache.org/jira/browse/MINDEXER-122 Do all pull 
requests have to have a JIRA ticket?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (MINDEXER-122) Add getName() to Record.EntryKey

2019-08-18 Thread Stephen Buergler (JIRA)
Stephen Buergler created MINDEXER-122:
-

 Summary: Add getName() to Record.EntryKey
 Key: MINDEXER-122
 URL: https://issues.apache.org/jira/browse/MINDEXER-122
 Project: Maven Indexer
  Issue Type: Improvement
Reporter: Stephen Buergler


Currently I'm doing this to pull the name field out of EntryKey
{code:java}
  @SneakyThrows
  private static MethodHandle entryKeyNameField() {
return MethodHandles.privateLookupIn(EntryKey.class, MethodHandles.lookup())
.findGetter(EntryKey.class, "name", String.class);
  }

  private static final MethodHandle entryKeyNameField = entryKeyNameField();

  @SneakyThrows
  static String getName(EntryKey entryKey) {
return (String) entryKeyNameField.invokeExact(entryKey);
  }
{code}
It would be nice if getName() was a method on EntryKey itself.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [maven-indexer] sixcorners commented on issue #39: Add getName() to Record.EntryKey

2019-08-18 Thread GitBox
sixcorners commented on issue #39: Add getName() to Record.EntryKey
URL: https://github.com/apache/maven-indexer/pull/39#issuecomment-522366852
 
 
   Are you saying I should remove "I don't want to parse the output from 
toString()" or add more detail to the commit message? "I don't want to parse 
the output from toString()" is only added to the pull request. I didn't put it 
in the commit message.
   
   I made this: https://issues.apache.org/jira/browse/MINDEXER-122


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MINDEXER-121) ChunkReaderIterator leaks InputStreams

2019-08-18 Thread Stephen Buergler (JIRA)


[ 
https://issues.apache.org/jira/browse/MINDEXER-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910081#comment-16910081
 ] 

Stephen Buergler commented on MINDEXER-121:
---

I think the javadoc should be changed so that the consumer is required to close 
their ChunkReaders. It's not that hard to do. I kind of don't like that 
ChunkReaderIterator closes these things in the first place.

> ChunkReaderIterator leaks InputStreams
> --
>
> Key: MINDEXER-121
> URL: https://issues.apache.org/jira/browse/MINDEXER-121
> Project: Maven Indexer
>  Issue Type: Bug
>Reporter: Stephen Buergler
>Priority: Minor
>
> ChunkReaderIterator closes ChunkReaders when you call next(). The last 
> ChunkReader never gets closed because next() doesn't get called after the 
> last element has been returned.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (MINDEXER-121) ChunkReaderIterator leaks InputStreams

2019-08-18 Thread Stephen Buergler (JIRA)


 [ 
https://issues.apache.org/jira/browse/MINDEXER-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stephen Buergler updated MINDEXER-121:
--
Description: ChunkReaderIterator closes ChunkReaders when you call next(). 
The last ChunkReader never gets closed because next() doesn't get called after 
the last element has been returned.  (was: ChunkReaderIterator closes 
ChunkReaders when you call next(). The last ChunkReader never gets closed 
because next() doesn't get called after the last element has been returned. 
Even if you did call ChunkReaderIterator.next() again it would throw an 
exception before it could get around to closing the last ChunkReader.)

> ChunkReaderIterator leaks InputStreams
> --
>
> Key: MINDEXER-121
> URL: https://issues.apache.org/jira/browse/MINDEXER-121
> Project: Maven Indexer
>  Issue Type: Bug
>Reporter: Stephen Buergler
>Priority: Minor
>
> ChunkReaderIterator closes ChunkReaders when you call next(). The last 
> ChunkReader never gets closed because next() doesn't get called after the 
> last element has been returned.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [maven-integration-testing] Tibor17 commented on a change in pull request #46: [MNG-6731] Jetty getLocalPort() returns -1 resulting in build failures

2019-08-18 Thread GitBox
Tibor17 commented on a change in pull request #46: [MNG-6731] Jetty 
getLocalPort() returns -1 resulting in build failures
URL: 
https://github.com/apache/maven-integration-testing/pull/46#discussion_r315005991
 
 

 ##
 File path: 
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng2305MultipleProxiesTest.java
 ##
 @@ -71,20 +78,16 @@ public void testit()
 String keyPwd = "key-passwd";
 
 Server server = new Server( 0 );
-server.addConnector( newHttpsConnector( storePath, storePwd, keyPwd ) 
);
+addHttpsConnector( server, storePath, storePwd, keyPwd );
 server.setHandler( new RepoHandler() );
 server.start();
-while ( !server.isRunning() || !server.isStarted() )
+if ( server.isFailed() )
 {
-if ( server.isFailed() )
-{
-fail( "Couldn't bind the server socket to a free port!" );
-}
-Thread.sleep( 100L );
+fail( "Couldn't bind the server socket to a free port!" );
 }
-int httpPort = server.getConnectors()[0].getLocalPort();
+int httpPort = ( (NetworkConnector) server.getConnectors()[0] 
).getLocalPort();
 System.out.println( "Bound server socket to HTTP port " + httpPort );
-int httpsPort = server.getConnectors()[1].getLocalPort();
+int httpsPort = ( (NetworkConnector) server.getConnectors()[1] 
).getLocalPort();
 
 Review comment:
   @joakime
   I am convinced your advice is right. Can you improve these tests and publish 
a new PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-archetype] Tibor17 commented on issue #30: [ARCHETYPE-569] Update to latest version of plexus utils

2019-08-18 Thread GitBox
Tibor17 commented on issue #30: [ARCHETYPE-569] Update to latest version of 
plexus utils
URL: https://github.com/apache/maven-archetype/pull/30#issuecomment-522364210
 
 
   @mbooth101 
   Can you rebase this PR to master?
   I want to start a new release today.
   The build is hopefully stable, so we can continue with your commit.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Closed] (ARCHETYPE-578) Deleted unnecessary calls ".flush()" on I/O streams

2019-08-18 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARCHETYPE-578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana closed ARCHETYPE-578.
--
Resolution: Fixed

https://gitbox.apache.org/repos/asf?p=maven-archetype.git;a=commit;h=010f512d0609ca0c65beb7f08c7f37546eff5ec8

> Deleted unnecessary calls ".flush()" on I/O streams
> ---
>
> Key: ARCHETYPE-578
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-578
> Project: Maven Archetype
>  Issue Type: Dependency upgrade
>  Components: Archetypes, Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.1.2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Closed] (ARCHETYPE-582) Additional module in generated POM should keep line indentation 2 chars

2019-08-18 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARCHETYPE-582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana closed ARCHETYPE-582.
--
Resolution: Fixed

https://gitbox.apache.org/repos/asf?p=maven-archetype.git;a=commit;h=764145b4625f946cf4c3607aab668d2a6ab36dd8

> Additional module in generated POM should keep line indentation 2 chars
> ---
>
> Key: ARCHETYPE-582
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-582
> Project: Maven Archetype
>  Issue Type: Improvement
>  Components: Archetypes, Generator
>Affects Versions: 3.1.1
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.1.2
>
>
> Fixed this problem:
> {code:java}
>   
>   module1
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Closed] (ARCHETYPE-579) Missing try-with-resources and createNewFile() before new FileOutputStream(f)

2019-08-18 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARCHETYPE-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana closed ARCHETYPE-579.
--
Resolution: Fixed

https://gitbox.apache.org/repos/asf?p=maven-archetype.git;a=commit;h=18c6eef1122f3f23466eab7b45f62e1c96cfb8b7

> Missing try-with-resources and createNewFile() before new FileOutputStream(f)
> -
>
> Key: ARCHETYPE-579
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-579
> Project: Maven Archetype
>  Issue Type: Improvement
>  Components: Archetypes, Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.1.2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (ARCHETYPE-579) Missing try-with-resources and createNewFile() before new FileOutputStream(f)

2019-08-18 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARCHETYPE-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana updated ARCHETYPE-579:
---
Issue Type: Improvement  (was: Dependency upgrade)

> Missing try-with-resources and createNewFile() before new FileOutputStream(f)
> -
>
> Key: ARCHETYPE-579
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-579
> Project: Maven Archetype
>  Issue Type: Improvement
>  Components: Archetypes, Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.1.2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (ARCHETYPE-582) Additional module in generated POM should keep line indentation 2 chars

2019-08-18 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARCHETYPE-582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana updated ARCHETYPE-582:
---
Summary: Additional module in generated POM should keep line indentation 2 
chars  (was: Additional module in generated POM should should keep line 
indentation 2 chars)

> Additional module in generated POM should keep line indentation 2 chars
> ---
>
> Key: ARCHETYPE-582
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-582
> Project: Maven Archetype
>  Issue Type: Improvement
>  Components: Archetypes, Generator
>Affects Versions: 3.1.1
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.1.2
>
>
> Fixed this problem:
> {code:java}
>   
>   module1
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (ARCHETYPE-582) Additional module in generated POM should should keep line indentation 2 chars

2019-08-18 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARCHETYPE-582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana updated ARCHETYPE-582:
---
Summary: Additional module in generated POM should should keep line 
indentation 2 chars  (was: Modules in generated POM should should keep line 
indentation 2 chars)

> Additional module in generated POM should should keep line indentation 2 chars
> --
>
> Key: ARCHETYPE-582
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-582
> Project: Maven Archetype
>  Issue Type: Improvement
>  Components: Archetypes, Generator
>Affects Versions: 3.1.1
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.1.2
>
>
> Fixed this problem:
> {code:java}
>   
>   module1
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Created] (ARCHETYPE-582) Modules in generated POM should should keep line indentation 2 chars

2019-08-18 Thread Tibor Digana (JIRA)
Tibor Digana created ARCHETYPE-582:
--

 Summary: Modules in generated POM should should keep line 
indentation 2 chars
 Key: ARCHETYPE-582
 URL: https://issues.apache.org/jira/browse/ARCHETYPE-582
 Project: Maven Archetype
  Issue Type: Improvement
  Components: Archetypes, Generator
Affects Versions: 3.1.1
Reporter: Tibor Digana
Assignee: Tibor Digana
 Fix For: 3.1.2


Fixed this problem:

{code:java}
  
  module1
{code}




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Closed] (ARCHETYPE-575) Upgrade maven-artifact-transfer to 0.11.0

2019-08-18 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARCHETYPE-575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana closed ARCHETYPE-575.
--
Resolution: Fixed

https://gitbox.apache.org/repos/asf?p=maven-archetype.git;a=commit;h=8bc922a92cef014c791f50cb2d004c8d4552fba2

> Upgrade maven-artifact-transfer to 0.11.0
> -
>
> Key: ARCHETYPE-575
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-575
> Project: Maven Archetype
>  Issue Type: Dependency upgrade
>  Components: Archetypes, Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.1.2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [maven] michael-o edited a comment on issue #277: [MNG-6732] - DefaultArtifactDescriptorReader.loadPom to check IGNORE_MISSING policy upon ArtifactTransferException

2019-08-18 Thread GitBox
michael-o edited a comment on issue #277: [MNG-6732] - 
DefaultArtifactDescriptorReader.loadPom to check IGNORE_MISSING policy upon 
ArtifactTransferException
URL: https://github.com/apache/maven/pull/277#issuecomment-522345477
 
 
   I need will some time to better understand this issue, so a review won't 
happen before end of this month. Maybe some other committer knows better.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] michael-o commented on issue #277: [MNG-6732] - DefaultArtifactDescriptorReader.loadPom to check IGNORE_MISSING policy upon ArtifactTransferException

2019-08-18 Thread GitBox
michael-o commented on issue #277: [MNG-6732] - 
DefaultArtifactDescriptorReader.loadPom to check IGNORE_MISSING policy upon 
ArtifactTransferException
URL: https://github.com/apache/maven/pull/277#issuecomment-522345477
 
 
   I will some time to better understand this issue, so a review won't happen 
before end of this month. Maybe some other committer knows better.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] eolivelli commented on issue #277: [MNG-6732] - DefaultArtifactDescriptorReader.loadPom to check IGNORE_MISSING policy upon ArtifactTransferException

2019-08-18 Thread GitBox
eolivelli commented on issue #277: [MNG-6732] - 
DefaultArtifactDescriptorReader.loadPom to check IGNORE_MISSING policy upon 
ArtifactTransferException
URL: https://github.com/apache/maven/pull/277#issuecomment-522345371
 
 
   Okay. I feel I don't have enough context to sponsor this change, I am not 
saying I am -1
   
   Any other committer with more insight on this kind of error?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Closed] (ARCHETYPE-577) Upgrade Wagon to 3.3.3

2019-08-18 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARCHETYPE-577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana closed ARCHETYPE-577.
--
Resolution: Fixed
  Assignee: Tibor Digana

https://gitbox.apache.org/repos/asf?p=maven-archetype.git;a=commit;h=fa87892f9722f6c1011c50700a75eaa091a104a5

> Upgrade Wagon to 3.3.3
> --
>
> Key: ARCHETYPE-577
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-577
> Project: Maven Archetype
>  Issue Type: Dependency upgrade
>  Components: Archetypes
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.1.2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (MSITE-849) Unable to inject MavenProject when using `mvn site:run`

2019-08-18 Thread Michael Osipov (JIRA)


[ 
https://issues.apache.org/jira/browse/MSITE-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910029#comment-16910029
 ] 

Michael Osipov commented on MSITE-849:
--

[~hboutemy], what is your opinion?

> Unable to inject MavenProject when using `mvn site:run`
> ---
>
> Key: MSITE-849
> URL: https://issues.apache.org/jira/browse/MSITE-849
> Project: Maven Site Plugin
>  Issue Type: New Feature
>Affects Versions: 3.7.1, 3.8.2
>Reporter: Abel Salgado Romero
>Assignee: Michael Osipov
>Priority: Major
>
> In https://github.com/asciidoctor/asciidoctor-maven-plugin we inject a 
> MavenProject to obtain addition configurations from the pom.xml 
> (https://github.com/asciidoctor/asciidoctor-maven-plugin/blob/a4d86a949643ab68c124fd4c1b9b936412637d93/src/main/java/org/asciidoctor/maven/site/AsciidoctorDoxiaParser.java#L54).
> This works fine with {{site:site}}, but when using {{site:run}} and accessing 
> one of the Asciidoc generated pages we get the error below.
> I saw that:
> * The error occurs when trying to retrieve the instance of the MavenProject.
> * Behavior is the same if I directly inject the MavenProject instead of using 
> a provider. That is, {{site:site}} works, {{site:run}} fails because it 
> cannot find the instance.
> {code:java}
> HTTP ERROR 500
> Problem accessing /hello.html. Reason:
> Server Error
> Caused by:
> com.google.inject.ProvisionException: Unable to provision, see the following 
> errors:
> 1) Error in custom provider, com.google.inject.OutOfScopeException: Cannot 
> access Key[type=org.apache.maven.project.MavenProject, annotation=[none]] 
> outside of a scoping block
>   at 
> org.apache.maven.execution.scope.internal.MojoExecutionScopeModule.configure(MojoExecutionScopeModule.java:55)
>  (via modules: org.eclipse.sisu.wire.WireModule -> 
> org.apache.maven.execution.scope.internal.MojoExecutionScopeModule)
>   while locating org.apache.maven.project.MavenProject
> 1 error
>   at 
> com.google.inject.internal.InternalProvisionException.toProvisionException(InternalProvisionException.java:226)
>   at com.google.inject.internal.InjectorImpl$1.get(InjectorImpl.java:1053)
>   at 
> org.asciidoctor.maven.site.AsciidoctorDoxiaParser.parse(AsciidoctorDoxiaParser.java:78)
>   at org.apache.maven.doxia.DefaultDoxia.parse(DefaultDoxia.java:65)
> {code}
> * How to reproduce:
> # clone https://github.com/asciidoctor/asciidoctor-maven-examples
> # cd asciidoc-maven-site-example
> # mvn site:run
> # Access {{http://localhost:8080/hello.html}}
> * Env:
> {code}
> $ mvn -v
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
> 2019-04-04T21:00:29+02:00)
> Maven home: /home//.sdkman/candidates/maven/current
> Java version: 1.8.0_222, vendor: AdoptOpenJDK, runtime: 
> /home/-/.sdkman/candidates/java/8.0.222.hs-adpt/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.1.21-1-manjaro", arch: "amd64", family: "unix
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Comment Edited] (MSITE-849) Unable to inject MavenProject when using `mvn site:run`

2019-08-18 Thread Abel Salgado Romero (JIRA)


[ 
https://issues.apache.org/jira/browse/MSITE-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910019#comment-16910019
 ] 

Abel Salgado Romero edited comment on MSITE-849 at 8/18/19 6:13 PM:


{quote}I don't think that Doxia should be tied to MavenProject. It can be used 
and shall be used w/o Maven.{quote}
There's no other way to add additional configurations to custom converters, so 
we just rolled with it.
If it should be in another way, that's definitely a question to the Doxia 
Leads. Imho it's a bit too restrictive with what information it makes available 
to converters.

{quote}If you say that the Asciidoc parser ist not init'ed. Are you sure that 
this component is handled properly at all?{quote}
The no initialization is because (I assume) uses some lazy init. And since it 
works fine with {{site:site}}, I assume it's correct.


was (Author: abel s.romero):
{quote}I don't think that Doxia should be tied to MavenProject. It can be used 
and shall be used w/o Maven.{quote}
There's no other way to add additional configurations to custom converters, so 
we just rolled with it.
If it should be in another way, that's definitely a question to the Doxia 
Leads. Imho it's a bit too restrictive with what information it makes available 
to converters.

{quote}If you say that the Asciidoc parser ist not init'ed. Are you sure that 
this component is handled properly at all?{quote}
The no initialization is because -I assume- uses some lazy init. And since it 
works fine with {{site:site}}, I assume it's correct.

> Unable to inject MavenProject when using `mvn site:run`
> ---
>
> Key: MSITE-849
> URL: https://issues.apache.org/jira/browse/MSITE-849
> Project: Maven Site Plugin
>  Issue Type: New Feature
>Affects Versions: 3.7.1, 3.8.2
>Reporter: Abel Salgado Romero
>Assignee: Michael Osipov
>Priority: Major
>
> In https://github.com/asciidoctor/asciidoctor-maven-plugin we inject a 
> MavenProject to obtain addition configurations from the pom.xml 
> (https://github.com/asciidoctor/asciidoctor-maven-plugin/blob/a4d86a949643ab68c124fd4c1b9b936412637d93/src/main/java/org/asciidoctor/maven/site/AsciidoctorDoxiaParser.java#L54).
> This works fine with {{site:site}}, but when using {{site:run}} and accessing 
> one of the Asciidoc generated pages we get the error below.
> I saw that:
> * The error occurs when trying to retrieve the instance of the MavenProject.
> * Behavior is the same if I directly inject the MavenProject instead of using 
> a provider. That is, {{site:site}} works, {{site:run}} fails because it 
> cannot find the instance.
> {code:java}
> HTTP ERROR 500
> Problem accessing /hello.html. Reason:
> Server Error
> Caused by:
> com.google.inject.ProvisionException: Unable to provision, see the following 
> errors:
> 1) Error in custom provider, com.google.inject.OutOfScopeException: Cannot 
> access Key[type=org.apache.maven.project.MavenProject, annotation=[none]] 
> outside of a scoping block
>   at 
> org.apache.maven.execution.scope.internal.MojoExecutionScopeModule.configure(MojoExecutionScopeModule.java:55)
>  (via modules: org.eclipse.sisu.wire.WireModule -> 
> org.apache.maven.execution.scope.internal.MojoExecutionScopeModule)
>   while locating org.apache.maven.project.MavenProject
> 1 error
>   at 
> com.google.inject.internal.InternalProvisionException.toProvisionException(InternalProvisionException.java:226)
>   at com.google.inject.internal.InjectorImpl$1.get(InjectorImpl.java:1053)
>   at 
> org.asciidoctor.maven.site.AsciidoctorDoxiaParser.parse(AsciidoctorDoxiaParser.java:78)
>   at org.apache.maven.doxia.DefaultDoxia.parse(DefaultDoxia.java:65)
> {code}
> * How to reproduce:
> # clone https://github.com/asciidoctor/asciidoctor-maven-examples
> # cd asciidoc-maven-site-example
> # mvn site:run
> # Access {{http://localhost:8080/hello.html}}
> * Env:
> {code}
> $ mvn -v
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
> 2019-04-04T21:00:29+02:00)
> Maven home: /home//.sdkman/candidates/maven/current
> Java version: 1.8.0_222, vendor: AdoptOpenJDK, runtime: 
> /home/-/.sdkman/candidates/java/8.0.222.hs-adpt/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.1.21-1-manjaro", arch: "amd64", family: "unix
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (MNG-6739) JSR 330 not picking up Guice Custom Bindings

2019-08-18 Thread Jose Montoya (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910025#comment-16910025
 ] 

Jose Montoya commented on MNG-6739:
---

[~j...@kafsemo.org] I saw you were migrating maven-core from plexus to JSR 330. 
Sorry to pull you in, but thought maybe you could point me in the right 
direction?

> JSR 330 not picking up Guice Custom Bindings
> 
>
> Key: MNG-6739
> URL: https://issues.apache.org/jira/browse/MNG-6739
> Project: Maven
>  Issue Type: Bug
>  Components: Plugins and Lifecycle
>Affects Versions: 3.6.0
>Reporter: Jose Montoya
>Priority: Major
>
> See: [https://maven.apache.org/maven-jsr330.html] and 
> [https://wiki.eclipse.org/Sisu/PlexusMigration]
> These docs state that Guice Modules annotated with `@Named` will be loaded 
> and configured automatically by Sisu. I think the actual loading is done by 
> `org.eclipse.sisu.space.QualifiedTypeBinder` but it only seems to work when 
> running tests via the `maven-plugin-testing-harness` and not when actually 
> running the plugin.
> I've tried to add various different artifacts to compilation including 
> `sisu.inject`, `sisu.inject.extender` and `plexus-container-default` but 
> cannot get the Modules to be loaded, and consequently the Mojo fails to 
> instantiate with com.google.inject.ProvisionException: Unable to provision.
> I'm working on a simple project to reproduce, I'll update the ticket with a 
> link to it. If I can provide more information, or if I'm just missing 
> something simple please let me know. Thanks
> EDIT: Here's the repo [https://github.com/jam01/maven-plugin-jsr330-issue]
>  ```
>  mvn clean install
>  mvn com.jam01.test:printer-maven-plugin:print
>  ```



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (MNG-6739) JSR 330 not picking up Guice Custom Bindings

2019-08-18 Thread Jose Montoya (JIRA)


 [ 
https://issues.apache.org/jira/browse/MNG-6739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jose Montoya updated MNG-6739:
--
Description: 
See: [https://maven.apache.org/maven-jsr330.html] and 
[https://wiki.eclipse.org/Sisu/PlexusMigration]

These docs state that Guice Modules annotated with `@Named` will be loaded and 
configured automatically by Sisu. I think the actual loading is done by 
`org.eclipse.sisu.space.QualifiedTypeBinder` but it only seems to work when 
running tests via the `maven-plugin-testing-harness` and not when actually 
running the plugin.

I've tried to add various different artifacts to compilation including 
`sisu.inject`, `sisu.inject.extender` and `plexus-container-default` but cannot 
get the Modules to be loaded, and consequently the Mojo fails to instantiate 
with com.google.inject.ProvisionException: Unable to provision.

I'm working on a simple project to reproduce, I'll update the ticket with a 
link to it. If I can provide more information, or if I'm just missing something 
simple please let me know. Thanks


EDIT: Here's the repo [https://github.com/jam01/maven-plugin-jsr330-issue]
 ```
 mvn clean install
 mvn com.jam01.test:printer-maven-plugin:print
 ```

  was:
See: [https://maven.apache.org/maven-jsr330.html] and 
[https://wiki.eclipse.org/Sisu/PlexusMigration]

These docs state that Guice Modules annotated with `@Named` will be loaded and 
configured automatically by Sisu. I think the actual loading is done by 
`org.eclipse.sisu.space.QualifiedTypeBinder` but it only seems to work when 
running tests via the `maven-plugin-testing-harness` and not when actually 
running the plugin.

 

I've tried to add various different artifacts to compilation including 
`sisu.inject`, `sisu.inject.extender` and `plexus-container-default` but cannot 
get the Modules to be loaded, and consequently the Mojo fails to instantiate 
with com.google.inject.ProvisionException: Unable to provision.

 

I'm working on a simple project to reproduce, I'll update the ticket with a 
link to it. If I can provide more information, or if I'm just missing something 
simple please let me know. Thanks


> JSR 330 not picking up Guice Custom Bindings
> 
>
> Key: MNG-6739
> URL: https://issues.apache.org/jira/browse/MNG-6739
> Project: Maven
>  Issue Type: Bug
>  Components: Plugins and Lifecycle
>Affects Versions: 3.6.0
>Reporter: Jose Montoya
>Priority: Major
>
> See: [https://maven.apache.org/maven-jsr330.html] and 
> [https://wiki.eclipse.org/Sisu/PlexusMigration]
> These docs state that Guice Modules annotated with `@Named` will be loaded 
> and configured automatically by Sisu. I think the actual loading is done by 
> `org.eclipse.sisu.space.QualifiedTypeBinder` but it only seems to work when 
> running tests via the `maven-plugin-testing-harness` and not when actually 
> running the plugin.
> I've tried to add various different artifacts to compilation including 
> `sisu.inject`, `sisu.inject.extender` and `plexus-container-default` but 
> cannot get the Modules to be loaded, and consequently the Mojo fails to 
> instantiate with com.google.inject.ProvisionException: Unable to provision.
> I'm working on a simple project to reproduce, I'll update the ticket with a 
> link to it. If I can provide more information, or if I'm just missing 
> something simple please let me know. Thanks
> EDIT: Here's the repo [https://github.com/jam01/maven-plugin-jsr330-issue]
>  ```
>  mvn clean install
>  mvn com.jam01.test:printer-maven-plugin:print
>  ```



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Created] (MNG-6739) JSR 330 not picking up Guice Custom Bindings

2019-08-18 Thread Jose Montoya (JIRA)
Jose Montoya created MNG-6739:
-

 Summary: JSR 330 not picking up Guice Custom Bindings
 Key: MNG-6739
 URL: https://issues.apache.org/jira/browse/MNG-6739
 Project: Maven
  Issue Type: Bug
  Components: Plugins and Lifecycle
Affects Versions: 3.6.0
Reporter: Jose Montoya


See: [https://maven.apache.org/maven-jsr330.html] and 
[https://wiki.eclipse.org/Sisu/PlexusMigration]

These docs state that Guice Modules annotated with `@Named` will be loaded and 
configured automatically by Sisu. I think the actual loading is done by 
`org.eclipse.sisu.space.QualifiedTypeBinder` but it only seems to work when 
running tests via the `maven-plugin-testing-harness` and not when actually 
running the plugin.

 

I've tried to add various different artifacts to compilation including 
`sisu.inject`, `sisu.inject.extender` and `plexus-container-default` but cannot 
get the Modules to be loaded, and consequently the Mojo fails to instantiate 
with com.google.inject.ProvisionException: Unable to provision.

 

I'm working on a simple project to reproduce, I'll update the ticket with a 
link to it. If I can provide more information, or if I'm just missing something 
simple please let me know. Thanks



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (MSITE-849) Unable to inject MavenProject when using `mvn site:run`

2019-08-18 Thread Abel Salgado Romero (JIRA)


[ 
https://issues.apache.org/jira/browse/MSITE-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910019#comment-16910019
 ] 

Abel Salgado Romero commented on MSITE-849:
---

{quote}I don't think that Doxia should be tied to MavenProject. It can be used 
and shall be used w/o Maven.{quote}
There's no other way to add additional configurations to custom converters, so 
we just rolled with it.
If it should be in another way, that's definitely a question to the Doxia 
Leads. Imho it's a bit too restrictive with what information it makes available 
to converters.

{quote}If you say that the Asciidoc parser ist not init'ed. Are you sure that 
this component is handled properly at all?{quote}
The no initialization is because -I assume- uses some lazy init. And since it 
works fine with {{site:site}}, I assume it's correct.

> Unable to inject MavenProject when using `mvn site:run`
> ---
>
> Key: MSITE-849
> URL: https://issues.apache.org/jira/browse/MSITE-849
> Project: Maven Site Plugin
>  Issue Type: New Feature
>Affects Versions: 3.7.1, 3.8.2
>Reporter: Abel Salgado Romero
>Assignee: Michael Osipov
>Priority: Major
>
> In https://github.com/asciidoctor/asciidoctor-maven-plugin we inject a 
> MavenProject to obtain addition configurations from the pom.xml 
> (https://github.com/asciidoctor/asciidoctor-maven-plugin/blob/a4d86a949643ab68c124fd4c1b9b936412637d93/src/main/java/org/asciidoctor/maven/site/AsciidoctorDoxiaParser.java#L54).
> This works fine with {{site:site}}, but when using {{site:run}} and accessing 
> one of the Asciidoc generated pages we get the error below.
> I saw that:
> * The error occurs when trying to retrieve the instance of the MavenProject.
> * Behavior is the same if I directly inject the MavenProject instead of using 
> a provider. That is, {{site:site}} works, {{site:run}} fails because it 
> cannot find the instance.
> {code:java}
> HTTP ERROR 500
> Problem accessing /hello.html. Reason:
> Server Error
> Caused by:
> com.google.inject.ProvisionException: Unable to provision, see the following 
> errors:
> 1) Error in custom provider, com.google.inject.OutOfScopeException: Cannot 
> access Key[type=org.apache.maven.project.MavenProject, annotation=[none]] 
> outside of a scoping block
>   at 
> org.apache.maven.execution.scope.internal.MojoExecutionScopeModule.configure(MojoExecutionScopeModule.java:55)
>  (via modules: org.eclipse.sisu.wire.WireModule -> 
> org.apache.maven.execution.scope.internal.MojoExecutionScopeModule)
>   while locating org.apache.maven.project.MavenProject
> 1 error
>   at 
> com.google.inject.internal.InternalProvisionException.toProvisionException(InternalProvisionException.java:226)
>   at com.google.inject.internal.InjectorImpl$1.get(InjectorImpl.java:1053)
>   at 
> org.asciidoctor.maven.site.AsciidoctorDoxiaParser.parse(AsciidoctorDoxiaParser.java:78)
>   at org.apache.maven.doxia.DefaultDoxia.parse(DefaultDoxia.java:65)
> {code}
> * How to reproduce:
> # clone https://github.com/asciidoctor/asciidoctor-maven-examples
> # cd asciidoc-maven-site-example
> # mvn site:run
> # Access {{http://localhost:8080/hello.html}}
> * Env:
> {code}
> $ mvn -v
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
> 2019-04-04T21:00:29+02:00)
> Maven home: /home//.sdkman/candidates/maven/current
> Java version: 1.8.0_222, vendor: AdoptOpenJDK, runtime: 
> /home/-/.sdkman/candidates/java/8.0.222.hs-adpt/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.1.21-1-manjaro", arch: "amd64", family: "unix
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (MNG-6738) Upgrade maven-resolver to 1.4.1

2019-08-18 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910016#comment-16910016
 ] 

Hudson commented on MNG-6738:
-

Build succeeded in Jenkins: Maven TLP » maven » master #276

See https://builds.apache.org/job/maven-box/job/maven/job/master/276/

> Upgrade maven-resolver to 1.4.1
> ---
>
> Key: MNG-6738
> URL: https://issues.apache.org/jira/browse/MNG-6738
> Project: Maven
>  Issue Type: Dependency upgrade
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.6.2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (MSITE-849) Unable to inject MavenProject when using `mvn site:run`

2019-08-18 Thread Michael Osipov (JIRA)


[ 
https://issues.apache.org/jira/browse/MSITE-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910013#comment-16910013
 ] 

Michael Osipov commented on MSITE-849:
--

I don't think that Doxia should be tied to {{MavenProject}}. It can be used and 
shall be used w/o Maven.

If you say that the Asciidoc parser ist not init'ed. Are you sure that this 
component is handled properly at all?

> Unable to inject MavenProject when using `mvn site:run`
> ---
>
> Key: MSITE-849
> URL: https://issues.apache.org/jira/browse/MSITE-849
> Project: Maven Site Plugin
>  Issue Type: New Feature
>Affects Versions: 3.7.1, 3.8.2
>Reporter: Abel Salgado Romero
>Assignee: Michael Osipov
>Priority: Major
>
> In https://github.com/asciidoctor/asciidoctor-maven-plugin we inject a 
> MavenProject to obtain addition configurations from the pom.xml 
> (https://github.com/asciidoctor/asciidoctor-maven-plugin/blob/a4d86a949643ab68c124fd4c1b9b936412637d93/src/main/java/org/asciidoctor/maven/site/AsciidoctorDoxiaParser.java#L54).
> This works fine with {{site:site}}, but when using {{site:run}} and accessing 
> one of the Asciidoc generated pages we get the error below.
> I saw that:
> * The error occurs when trying to retrieve the instance of the MavenProject.
> * Behavior is the same if I directly inject the MavenProject instead of using 
> a provider. That is, {{site:site}} works, {{site:run}} fails because it 
> cannot find the instance.
> {code:java}
> HTTP ERROR 500
> Problem accessing /hello.html. Reason:
> Server Error
> Caused by:
> com.google.inject.ProvisionException: Unable to provision, see the following 
> errors:
> 1) Error in custom provider, com.google.inject.OutOfScopeException: Cannot 
> access Key[type=org.apache.maven.project.MavenProject, annotation=[none]] 
> outside of a scoping block
>   at 
> org.apache.maven.execution.scope.internal.MojoExecutionScopeModule.configure(MojoExecutionScopeModule.java:55)
>  (via modules: org.eclipse.sisu.wire.WireModule -> 
> org.apache.maven.execution.scope.internal.MojoExecutionScopeModule)
>   while locating org.apache.maven.project.MavenProject
> 1 error
>   at 
> com.google.inject.internal.InternalProvisionException.toProvisionException(InternalProvisionException.java:226)
>   at com.google.inject.internal.InjectorImpl$1.get(InjectorImpl.java:1053)
>   at 
> org.asciidoctor.maven.site.AsciidoctorDoxiaParser.parse(AsciidoctorDoxiaParser.java:78)
>   at org.apache.maven.doxia.DefaultDoxia.parse(DefaultDoxia.java:65)
> {code}
> * How to reproduce:
> # clone https://github.com/asciidoctor/asciidoctor-maven-examples
> # cd asciidoc-maven-site-example
> # mvn site:run
> # Access {{http://localhost:8080/hello.html}}
> * Env:
> {code}
> $ mvn -v
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
> 2019-04-04T21:00:29+02:00)
> Maven home: /home//.sdkman/candidates/maven/current
> Java version: 1.8.0_222, vendor: AdoptOpenJDK, runtime: 
> /home/-/.sdkman/candidates/java/8.0.222.hs-adpt/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.1.21-1-manjaro", arch: "amd64", family: "unix
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Closed] (MNG-6738) Upgrade maven-resolver to 1.4.1

2019-08-18 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/MNG-6738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana closed MNG-6738.
-
Resolution: Fixed

https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=88b632cf3d727c7d003a8a36f1b39bffb2f790f3

> Upgrade maven-resolver to 1.4.1
> ---
>
> Key: MNG-6738
> URL: https://issues.apache.org/jira/browse/MNG-6738
> Project: Maven
>  Issue Type: Dependency upgrade
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.6.2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [maven] michael-o commented on issue #274: [MNG-6716] Test and fix erroneous compileRoots

2019-08-18 Thread GitBox
michael-o commented on issue #274: [MNG-6716] Test and fix erroneous 
compileRoots
URL: https://github.com/apache/maven/pull/274#issuecomment-522334667
 
 
   @hboutemy, I trust your judgement. If you bless, I'll do it too.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MNG-6738) Upgrade maven-resolver to 1.4.1

2019-08-18 Thread Tibor Digana (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909993#comment-16909993
 ] 

Tibor Digana commented on MNG-6738:
---

The current build process 
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6738/ is in progress.

> Upgrade maven-resolver to 1.4.1
> ---
>
> Key: MNG-6738
> URL: https://issues.apache.org/jira/browse/MNG-6738
> Project: Maven
>  Issue Type: Dependency upgrade
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.6.2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Comment Edited] (MSITE-849) Unable to inject MavenProject when using `mvn site:run`

2019-08-18 Thread Abel Salgado Romero (JIRA)


[ 
https://issues.apache.org/jira/browse/MSITE-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909978#comment-16909978
 ] 

Abel Salgado Romero edited comment on MSITE-849 at 8/18/19 2:25 PM:


As a note to self. Directly injecting MavenProject I could narrow it to 
{{org.apache.maven.doxia.parser.manager.DefaultParserManager::getParser( String 
id)}}.
This holds a set of available Parsers, in this case the "asciidoc" parser is 
not initialized (null in the internal map), so when trying retrieve it Guice 
kicks in and initializes it, failing cause it cannot find the MavenProject in 
the context.

When running {{mvn site:site}} it is correctly retrieved.


was (Author: abel s.romero):
As a note to self. Directly injecting MavenProject I could narrow it to 
{{org.apache.maven.doxia.parser.manager.DefaultParserManager::getParser( String 
id)}}.
This holds a set of available Parsers, in this case the "asciidoc" parser is 
not initialized (null in the internal map), so when trying retrieve it Guice 
kicks in and initializes it, failing cause it cannot find the MavenProject in 
the context.

> Unable to inject MavenProject when using `mvn site:run`
> ---
>
> Key: MSITE-849
> URL: https://issues.apache.org/jira/browse/MSITE-849
> Project: Maven Site Plugin
>  Issue Type: New Feature
>Affects Versions: 3.7.1, 3.8.2
>Reporter: Abel Salgado Romero
>Assignee: Michael Osipov
>Priority: Major
>
> In https://github.com/asciidoctor/asciidoctor-maven-plugin we inject a 
> MavenProject to obtain addition configurations from the pom.xml 
> (https://github.com/asciidoctor/asciidoctor-maven-plugin/blob/a4d86a949643ab68c124fd4c1b9b936412637d93/src/main/java/org/asciidoctor/maven/site/AsciidoctorDoxiaParser.java#L54).
> This works fine with {{site:site}}, but when using {{site:run}} and accessing 
> one of the Asciidoc generated pages we get the error below.
> I saw that:
> * The error occurs when trying to retrieve the instance of the MavenProject.
> * Behavior is the same if I directly inject the MavenProject instead of using 
> a provider. That is, {{site:site}} works, {{site:run}} fails because it 
> cannot find the instance.
> {code:java}
> HTTP ERROR 500
> Problem accessing /hello.html. Reason:
> Server Error
> Caused by:
> com.google.inject.ProvisionException: Unable to provision, see the following 
> errors:
> 1) Error in custom provider, com.google.inject.OutOfScopeException: Cannot 
> access Key[type=org.apache.maven.project.MavenProject, annotation=[none]] 
> outside of a scoping block
>   at 
> org.apache.maven.execution.scope.internal.MojoExecutionScopeModule.configure(MojoExecutionScopeModule.java:55)
>  (via modules: org.eclipse.sisu.wire.WireModule -> 
> org.apache.maven.execution.scope.internal.MojoExecutionScopeModule)
>   while locating org.apache.maven.project.MavenProject
> 1 error
>   at 
> com.google.inject.internal.InternalProvisionException.toProvisionException(InternalProvisionException.java:226)
>   at com.google.inject.internal.InjectorImpl$1.get(InjectorImpl.java:1053)
>   at 
> org.asciidoctor.maven.site.AsciidoctorDoxiaParser.parse(AsciidoctorDoxiaParser.java:78)
>   at org.apache.maven.doxia.DefaultDoxia.parse(DefaultDoxia.java:65)
> {code}
> * How to reproduce:
> # clone https://github.com/asciidoctor/asciidoctor-maven-examples
> # cd asciidoc-maven-site-example
> # mvn site:run
> # Access {{http://localhost:8080/hello.html}}
> * Env:
> {code}
> $ mvn -v
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
> 2019-04-04T21:00:29+02:00)
> Maven home: /home//.sdkman/candidates/maven/current
> Java version: 1.8.0_222, vendor: AdoptOpenJDK, runtime: 
> /home/-/.sdkman/candidates/java/8.0.222.hs-adpt/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.1.21-1-manjaro", arch: "amd64", family: "unix
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (MSITE-849) Unable to inject MavenProject when using `mvn site:run`

2019-08-18 Thread Abel Salgado Romero (JIRA)


[ 
https://issues.apache.org/jira/browse/MSITE-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909978#comment-16909978
 ] 

Abel Salgado Romero commented on MSITE-849:
---

As a note to self. Directly injecting MavenProject I could narrow it to 
{{org.apache.maven.doxia.parser.manager.DefaultParserManager::getParser( String 
id)}}.
This holds a set of available Parsers, in this case the "asciidoc" parser is 
not initialized (null in the internal map), so when trying retrieve it Guice 
kicks in and initializes it, failing cause it cannot find the MavenProject in 
the context.

> Unable to inject MavenProject when using `mvn site:run`
> ---
>
> Key: MSITE-849
> URL: https://issues.apache.org/jira/browse/MSITE-849
> Project: Maven Site Plugin
>  Issue Type: New Feature
>Affects Versions: 3.7.1, 3.8.2
>Reporter: Abel Salgado Romero
>Assignee: Michael Osipov
>Priority: Major
>
> In https://github.com/asciidoctor/asciidoctor-maven-plugin we inject a 
> MavenProject to obtain addition configurations from the pom.xml 
> (https://github.com/asciidoctor/asciidoctor-maven-plugin/blob/a4d86a949643ab68c124fd4c1b9b936412637d93/src/main/java/org/asciidoctor/maven/site/AsciidoctorDoxiaParser.java#L54).
> This works fine with {{site:site}}, but when using {{site:run}} and accessing 
> one of the Asciidoc generated pages we get the error below.
> I saw that:
> * The error occurs when trying to retrieve the instance of the MavenProject.
> * Behavior is the same if I directly inject the MavenProject instead of using 
> a provider. That is, {{site:site}} works, {{site:run}} fails because it 
> cannot find the instance.
> {code:java}
> HTTP ERROR 500
> Problem accessing /hello.html. Reason:
> Server Error
> Caused by:
> com.google.inject.ProvisionException: Unable to provision, see the following 
> errors:
> 1) Error in custom provider, com.google.inject.OutOfScopeException: Cannot 
> access Key[type=org.apache.maven.project.MavenProject, annotation=[none]] 
> outside of a scoping block
>   at 
> org.apache.maven.execution.scope.internal.MojoExecutionScopeModule.configure(MojoExecutionScopeModule.java:55)
>  (via modules: org.eclipse.sisu.wire.WireModule -> 
> org.apache.maven.execution.scope.internal.MojoExecutionScopeModule)
>   while locating org.apache.maven.project.MavenProject
> 1 error
>   at 
> com.google.inject.internal.InternalProvisionException.toProvisionException(InternalProvisionException.java:226)
>   at com.google.inject.internal.InjectorImpl$1.get(InjectorImpl.java:1053)
>   at 
> org.asciidoctor.maven.site.AsciidoctorDoxiaParser.parse(AsciidoctorDoxiaParser.java:78)
>   at org.apache.maven.doxia.DefaultDoxia.parse(DefaultDoxia.java:65)
> {code}
> * How to reproduce:
> # clone https://github.com/asciidoctor/asciidoctor-maven-examples
> # cd asciidoc-maven-site-example
> # mvn site:run
> # Access {{http://localhost:8080/hello.html}}
> * Env:
> {code}
> $ mvn -v
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
> 2019-04-04T21:00:29+02:00)
> Maven home: /home//.sdkman/candidates/maven/current
> Java version: 1.8.0_222, vendor: AdoptOpenJDK, runtime: 
> /home/-/.sdkman/candidates/java/8.0.222.hs-adpt/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.1.21-1-manjaro", arch: "amd64", family: "unix
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Comment Edited] (MSITE-849) Unable to inject MavenProject when using `mvn site:run`

2019-08-18 Thread Abel Salgado Romero (JIRA)


[ 
https://issues.apache.org/jira/browse/MSITE-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909970#comment-16909970
 ] 

Abel Salgado Romero edited comment on MSITE-849 at 8/18/19 1:50 PM:


I did debug the {{SiteRunMojo}} and the MavenProject instance gets injected but 
the thing is my class extends {{XhtmlParser}} which is a Doxia component. Which 
has no getProject().

Should I address this issue with them? There are 3 projects "Maven Doxia", 
"Maven Doxia Sitetools", "Maven Doxia Tools".


was (Author: abel s.romero):
I did debug the {{SiteRunMojo}} and the MavenProject instance gets injected but 
the thing is my class extends {{XhtmlParser}} which is a Doxia component.
Should I address this issue with them? There are 3 projects "Maven Doxia", 
"Maven Doxia Sitetools", "Maven Doxia Tools".

> Unable to inject MavenProject when using `mvn site:run`
> ---
>
> Key: MSITE-849
> URL: https://issues.apache.org/jira/browse/MSITE-849
> Project: Maven Site Plugin
>  Issue Type: New Feature
>Affects Versions: 3.7.1, 3.8.2
>Reporter: Abel Salgado Romero
>Assignee: Michael Osipov
>Priority: Major
>
> In https://github.com/asciidoctor/asciidoctor-maven-plugin we inject a 
> MavenProject to obtain addition configurations from the pom.xml 
> (https://github.com/asciidoctor/asciidoctor-maven-plugin/blob/a4d86a949643ab68c124fd4c1b9b936412637d93/src/main/java/org/asciidoctor/maven/site/AsciidoctorDoxiaParser.java#L54).
> This works fine with {{site:site}}, but when using {{site:run}} and accessing 
> one of the Asciidoc generated pages we get the error below.
> I saw that:
> * The error occurs when trying to retrieve the instance of the MavenProject.
> * Behavior is the same if I directly inject the MavenProject instead of using 
> a provider. That is, {{site:site}} works, {{site:run}} fails because it 
> cannot find the instance.
> {code:java}
> HTTP ERROR 500
> Problem accessing /hello.html. Reason:
> Server Error
> Caused by:
> com.google.inject.ProvisionException: Unable to provision, see the following 
> errors:
> 1) Error in custom provider, com.google.inject.OutOfScopeException: Cannot 
> access Key[type=org.apache.maven.project.MavenProject, annotation=[none]] 
> outside of a scoping block
>   at 
> org.apache.maven.execution.scope.internal.MojoExecutionScopeModule.configure(MojoExecutionScopeModule.java:55)
>  (via modules: org.eclipse.sisu.wire.WireModule -> 
> org.apache.maven.execution.scope.internal.MojoExecutionScopeModule)
>   while locating org.apache.maven.project.MavenProject
> 1 error
>   at 
> com.google.inject.internal.InternalProvisionException.toProvisionException(InternalProvisionException.java:226)
>   at com.google.inject.internal.InjectorImpl$1.get(InjectorImpl.java:1053)
>   at 
> org.asciidoctor.maven.site.AsciidoctorDoxiaParser.parse(AsciidoctorDoxiaParser.java:78)
>   at org.apache.maven.doxia.DefaultDoxia.parse(DefaultDoxia.java:65)
> {code}
> * How to reproduce:
> # clone https://github.com/asciidoctor/asciidoctor-maven-examples
> # cd asciidoc-maven-site-example
> # mvn site:run
> # Access {{http://localhost:8080/hello.html}}
> * Env:
> {code}
> $ mvn -v
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
> 2019-04-04T21:00:29+02:00)
> Maven home: /home//.sdkman/candidates/maven/current
> Java version: 1.8.0_222, vendor: AdoptOpenJDK, runtime: 
> /home/-/.sdkman/candidates/java/8.0.222.hs-adpt/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.1.21-1-manjaro", arch: "amd64", family: "unix
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (MSITE-849) Unable to inject MavenProject when using `mvn site:run`

2019-08-18 Thread Abel Salgado Romero (JIRA)


[ 
https://issues.apache.org/jira/browse/MSITE-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909970#comment-16909970
 ] 

Abel Salgado Romero commented on MSITE-849:
---

I did debug the {{SiteRunMojo}} and the MavenProject instance gets injected but 
the thing is my class extends {{XhtmlParser}} which is a Doxia component.
Should I address this issue with them? There are 3 projects "Maven Doxia", 
"Maven Doxia Sitetools", "Maven Doxia Tools".

> Unable to inject MavenProject when using `mvn site:run`
> ---
>
> Key: MSITE-849
> URL: https://issues.apache.org/jira/browse/MSITE-849
> Project: Maven Site Plugin
>  Issue Type: New Feature
>Affects Versions: 3.7.1, 3.8.2
>Reporter: Abel Salgado Romero
>Assignee: Michael Osipov
>Priority: Major
>
> In https://github.com/asciidoctor/asciidoctor-maven-plugin we inject a 
> MavenProject to obtain addition configurations from the pom.xml 
> (https://github.com/asciidoctor/asciidoctor-maven-plugin/blob/a4d86a949643ab68c124fd4c1b9b936412637d93/src/main/java/org/asciidoctor/maven/site/AsciidoctorDoxiaParser.java#L54).
> This works fine with {{site:site}}, but when using {{site:run}} and accessing 
> one of the Asciidoc generated pages we get the error below.
> I saw that:
> * The error occurs when trying to retrieve the instance of the MavenProject.
> * Behavior is the same if I directly inject the MavenProject instead of using 
> a provider. That is, {{site:site}} works, {{site:run}} fails because it 
> cannot find the instance.
> {code:java}
> HTTP ERROR 500
> Problem accessing /hello.html. Reason:
> Server Error
> Caused by:
> com.google.inject.ProvisionException: Unable to provision, see the following 
> errors:
> 1) Error in custom provider, com.google.inject.OutOfScopeException: Cannot 
> access Key[type=org.apache.maven.project.MavenProject, annotation=[none]] 
> outside of a scoping block
>   at 
> org.apache.maven.execution.scope.internal.MojoExecutionScopeModule.configure(MojoExecutionScopeModule.java:55)
>  (via modules: org.eclipse.sisu.wire.WireModule -> 
> org.apache.maven.execution.scope.internal.MojoExecutionScopeModule)
>   while locating org.apache.maven.project.MavenProject
> 1 error
>   at 
> com.google.inject.internal.InternalProvisionException.toProvisionException(InternalProvisionException.java:226)
>   at com.google.inject.internal.InjectorImpl$1.get(InjectorImpl.java:1053)
>   at 
> org.asciidoctor.maven.site.AsciidoctorDoxiaParser.parse(AsciidoctorDoxiaParser.java:78)
>   at org.apache.maven.doxia.DefaultDoxia.parse(DefaultDoxia.java:65)
> {code}
> * How to reproduce:
> # clone https://github.com/asciidoctor/asciidoctor-maven-examples
> # cd asciidoc-maven-site-example
> # mvn site:run
> # Access {{http://localhost:8080/hello.html}}
> * Env:
> {code}
> $ mvn -v
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
> 2019-04-04T21:00:29+02:00)
> Maven home: /home//.sdkman/candidates/maven/current
> Java version: 1.8.0_222, vendor: AdoptOpenJDK, runtime: 
> /home/-/.sdkman/candidates/java/8.0.222.hs-adpt/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.1.21-1-manjaro", arch: "amd64", family: "unix
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Created] (MNG-6738) Upgrade maven-resolver to 1.4.1

2019-08-18 Thread Tibor Digana (JIRA)
Tibor Digana created MNG-6738:
-

 Summary: Upgrade maven-resolver to 1.4.1
 Key: MNG-6738
 URL: https://issues.apache.org/jira/browse/MNG-6738
 Project: Maven
  Issue Type: Dependency upgrade
Reporter: Tibor Digana
Assignee: Tibor Digana
 Fix For: 3.6.2






--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (MNG-6712) Downgrade maven-resolver:1.4.0 to 1.3.3

2019-08-18 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/MNG-6712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MNG-6712:
---
Affects Version/s: 3.6.1

> Downgrade maven-resolver:1.4.0 to 1.3.3
> ---
>
> Key: MNG-6712
> URL: https://issues.apache.org/jira/browse/MNG-6712
> Project: Maven
>  Issue Type: Dependency upgrade
>Affects Versions: 3.6.1
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.6.2
>
>
> Version 1.4.0 was found as unstable due to used parallelism.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (MNG-6712) Downgrade maven-resolver:1.4.0 to 1.3.3

2019-08-18 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/MNG-6712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MNG-6712:
---
Issue Type: Bug  (was: Dependency upgrade)

> Downgrade maven-resolver:1.4.0 to 1.3.3
> ---
>
> Key: MNG-6712
> URL: https://issues.apache.org/jira/browse/MNG-6712
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.6.1
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.6.2
>
>
> Version 1.4.0 was found as unstable due to used parallelism.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [maven] hboutemy commented on issue #274: [MNG-6716] Test and fix erroneous compileRoots

2019-08-18 Thread GitBox
hboutemy commented on issue #274: [MNG-6716] Test and fix erroneous compileRoots
URL: https://github.com/apache/maven/pull/274#issuecomment-522323070
 
 
   1. I was able to reproduce the issue (on a Mac),
   2. I was able to check that the PR fixes the issue,
   3. I re-launched the build; and it now passes: 
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6716/
   
   everything looks ok to merge to master (and be able to launch 3.6.2 release 
process), isn't it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MNG-6731) Jetty getLocalPort() returns -1 resulting in build failures

2019-08-18 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909964#comment-16909964
 ] 

Hudson commented on MNG-6731:
-

Build succeeded in Jenkins: Maven TLP » maven » MNG-6716 #2

See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6716/2/

> Jetty getLocalPort() returns -1 resulting in build failures
> ---
>
> Key: MNG-6731
> URL: https://issues.apache.org/jira/browse/MNG-6731
> Project: Maven
>  Issue Type: Bug
>  Components: Integration Tests
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> We observed sporadic errors [1] fir the project {{core-its}} on Jenkins.
> So I started haveing a look and I say the JavaDoc of the method 
> {{getlocalPort}} saying that {{-1}} is returned if the connector is not open. 
> So I decided to use [2] and wait until the server is up. This was of course 
> wrong because the status of the server is set to {{STARTED}} immediatelly 
> after the method {{Server.start()}}. So therefore I was googling a little bit 
> and I found that Hadoop [3] had this problem too in 2010. Whole problem was 
> with a bug in Jetty server which is {{race condition}}. The article has a 
> link to Jetty's Jira with reported bug {{JETTY-748}}. According to the 
> annoucements [4] from Eclipse/Jetty, the bug  "{{JETTY-748 Prevent race close 
> of socket by old acceptor threads}}" was fixed in the version 
> {{jetty-7.2.1.v2010}}. So I decided to use that version but I found that 
> the class {{HashUserRealm}} was deleted and there is no support and no 
> further development of {{org.mortbay}}. Eclipse continues with the 
> development of Jerry 9.
> All I did in this issue was to rewrite 38 integration tests to Jetty 9 API 
> and the fix for {{JETTY-748}} is right there.
> [1]:
> Error message in logs: [WARNING] Could not transfer metadata 
> org.apache.maven.its.mng4554/maven-metadata.xml from/to central 
> (http://localhost:-1/repo-1): Connect to localhost:80 [localhost/127.0.0.1, 
> localhost/0:0:0:0:0:0:0:1] failed: Connection refused: connect
> [2]:
> {code:java}
> while ( !server.isRunning() || !server.isStarted() )
> {
> if ( server.isFailed() )
> {
> fail( "Couldn't bind the server socket to a free port!" );
> }
> Thread.sleep( 100L );
> }
> {code}
> [3]:
> https://www.bountysource.com/issues/987313-jetty-returns-1-resulting-in-hadoop-masters-slaves-to-fail-during-startup
> [4]:
> https://www.eclipse.org/lists/jetty-dev/msg00537.html



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (MSITE-849) Unable to inject MavenProject when using `mvn site:run`

2019-08-18 Thread Michael Osipov (JIRA)


[ 
https://issues.apache.org/jira/browse/MSITE-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909961#comment-16909961
 ] 

Michael Osipov commented on MSITE-849:
--

{{SiteRunMojo}} inherits from {{AbstractSiteMojo}} which has:

{noformat}
74  /**
75   * The Maven project.
76   */
77  @Parameter( defaultValue = "${project}", readonly = true )
78  protected MavenProject project;
79
{noformat}

Did you call {{#getProject()}}? I wonder why this does not work.

> Unable to inject MavenProject when using `mvn site:run`
> ---
>
> Key: MSITE-849
> URL: https://issues.apache.org/jira/browse/MSITE-849
> Project: Maven Site Plugin
>  Issue Type: New Feature
>Affects Versions: 3.7.1, 3.8.2
>Reporter: Abel Salgado Romero
>Assignee: Michael Osipov
>Priority: Major
>
> In https://github.com/asciidoctor/asciidoctor-maven-plugin we inject a 
> MavenProject to obtain addition configurations from the pom.xml 
> (https://github.com/asciidoctor/asciidoctor-maven-plugin/blob/a4d86a949643ab68c124fd4c1b9b936412637d93/src/main/java/org/asciidoctor/maven/site/AsciidoctorDoxiaParser.java#L54).
> This works fine with {{site:site}}, but when using {{site:run}} and accessing 
> one of the Asciidoc generated pages we get the error below.
> I saw that:
> * The error occurs when trying to retrieve the instance of the MavenProject.
> * Behavior is the same if I directly inject the MavenProject instead of using 
> a provider. That is, {{site:site}} works, {{site:run}} fails because it 
> cannot find the instance.
> {code:java}
> HTTP ERROR 500
> Problem accessing /hello.html. Reason:
> Server Error
> Caused by:
> com.google.inject.ProvisionException: Unable to provision, see the following 
> errors:
> 1) Error in custom provider, com.google.inject.OutOfScopeException: Cannot 
> access Key[type=org.apache.maven.project.MavenProject, annotation=[none]] 
> outside of a scoping block
>   at 
> org.apache.maven.execution.scope.internal.MojoExecutionScopeModule.configure(MojoExecutionScopeModule.java:55)
>  (via modules: org.eclipse.sisu.wire.WireModule -> 
> org.apache.maven.execution.scope.internal.MojoExecutionScopeModule)
>   while locating org.apache.maven.project.MavenProject
> 1 error
>   at 
> com.google.inject.internal.InternalProvisionException.toProvisionException(InternalProvisionException.java:226)
>   at com.google.inject.internal.InjectorImpl$1.get(InjectorImpl.java:1053)
>   at 
> org.asciidoctor.maven.site.AsciidoctorDoxiaParser.parse(AsciidoctorDoxiaParser.java:78)
>   at org.apache.maven.doxia.DefaultDoxia.parse(DefaultDoxia.java:65)
> {code}
> * How to reproduce:
> # clone https://github.com/asciidoctor/asciidoctor-maven-examples
> # cd asciidoc-maven-site-example
> # mvn site:run
> # Access {{http://localhost:8080/hello.html}}
> * Env:
> {code}
> $ mvn -v
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
> 2019-04-04T21:00:29+02:00)
> Maven home: /home//.sdkman/candidates/maven/current
> Java version: 1.8.0_222, vendor: AdoptOpenJDK, runtime: 
> /home/-/.sdkman/candidates/java/8.0.222.hs-adpt/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.1.21-1-manjaro", arch: "amd64", family: "unix
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (MSITE-849) Unable to inject MavenProject when using `mvn site:run`

2019-08-18 Thread Abel Salgado Romero (JIRA)


[ 
https://issues.apache.org/jira/browse/MSITE-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909959#comment-16909959
 ] 

Abel Salgado Romero commented on MSITE-849:
---

Exact same as with @Inject :(
I am not a Guice expert by far, but seems to me the Maven instances is not 
added to the context. If you can point me in some direction I can delve deeper. 
But I don't know where to start looking.

> Unable to inject MavenProject when using `mvn site:run`
> ---
>
> Key: MSITE-849
> URL: https://issues.apache.org/jira/browse/MSITE-849
> Project: Maven Site Plugin
>  Issue Type: New Feature
>Affects Versions: 3.7.1, 3.8.2
>Reporter: Abel Salgado Romero
>Assignee: Michael Osipov
>Priority: Major
>
> In https://github.com/asciidoctor/asciidoctor-maven-plugin we inject a 
> MavenProject to obtain addition configurations from the pom.xml 
> (https://github.com/asciidoctor/asciidoctor-maven-plugin/blob/a4d86a949643ab68c124fd4c1b9b936412637d93/src/main/java/org/asciidoctor/maven/site/AsciidoctorDoxiaParser.java#L54).
> This works fine with {{site:site}}, but when using {{site:run}} and accessing 
> one of the Asciidoc generated pages we get the error below.
> I saw that:
> * The error occurs when trying to retrieve the instance of the MavenProject.
> * Behavior is the same if I directly inject the MavenProject instead of using 
> a provider. That is, {{site:site}} works, {{site:run}} fails because it 
> cannot find the instance.
> {code:java}
> HTTP ERROR 500
> Problem accessing /hello.html. Reason:
> Server Error
> Caused by:
> com.google.inject.ProvisionException: Unable to provision, see the following 
> errors:
> 1) Error in custom provider, com.google.inject.OutOfScopeException: Cannot 
> access Key[type=org.apache.maven.project.MavenProject, annotation=[none]] 
> outside of a scoping block
>   at 
> org.apache.maven.execution.scope.internal.MojoExecutionScopeModule.configure(MojoExecutionScopeModule.java:55)
>  (via modules: org.eclipse.sisu.wire.WireModule -> 
> org.apache.maven.execution.scope.internal.MojoExecutionScopeModule)
>   while locating org.apache.maven.project.MavenProject
> 1 error
>   at 
> com.google.inject.internal.InternalProvisionException.toProvisionException(InternalProvisionException.java:226)
>   at com.google.inject.internal.InjectorImpl$1.get(InjectorImpl.java:1053)
>   at 
> org.asciidoctor.maven.site.AsciidoctorDoxiaParser.parse(AsciidoctorDoxiaParser.java:78)
>   at org.apache.maven.doxia.DefaultDoxia.parse(DefaultDoxia.java:65)
> {code}
> * How to reproduce:
> # clone https://github.com/asciidoctor/asciidoctor-maven-examples
> # cd asciidoc-maven-site-example
> # mvn site:run
> # Access {{http://localhost:8080/hello.html}}
> * Env:
> {code}
> $ mvn -v
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
> 2019-04-04T21:00:29+02:00)
> Maven home: /home//.sdkman/candidates/maven/current
> Java version: 1.8.0_222, vendor: AdoptOpenJDK, runtime: 
> /home/-/.sdkman/candidates/java/8.0.222.hs-adpt/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.1.21-1-manjaro", arch: "amd64", family: "unix
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Closed] (ARCHETYPE-581) The build fails in the integration tests because 'build.log' is being copied and failed

2019-08-18 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARCHETYPE-581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana closed ARCHETYPE-581.
--
Resolution: Fixed

https://gitbox.apache.org/repos/asf?p=maven-archetype.git;a=commit;h=d5d527a7372214b916a3bac3d7b953f2a4e2441b

> The build fails in the integration tests because 'build.log' is being copied 
> and failed
> ---
>
> Key: ARCHETYPE-581
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-581
> Project: Maven Archetype
>  Issue Type: Test
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.1.2
>
>
> Archetype ITs should exclude copying unnecessary file {{build.log}} (open 
> file with ongoing writes), otherwise the copy of the file content fails.
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-archetype-plugin:3.1.2-SNAPSHOT:create-from-project
>  (default-cli) on project include-file-with-no-extension: 
> {noformat}
> {noformat}
> Failed to copy full contents from 
> F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\build.log
>  to 
> F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\target\generated-sources\archetype\src\main\resources\archetype-resources\build.log
>  -> [Help 1]
> {noformat}
> {noformat}
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal 
> org.apache.maven.plugins:maven-archetype-plugin:3.1.2-SNAPSHOT:create-from-project
>  (default-cli) on project include-file-with-no-extension: 
> {noformat}
> {noformat}
> Failed to copy full contents from 
> F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\build.log
>  to 
> F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\target\generated-sources\archetype\src\main\resources\archetype-resources\build.log
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (ARCHETYPE-581) The build fails in the integration tests because 'build.log' is being copied and failed

2019-08-18 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARCHETYPE-581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana updated ARCHETYPE-581:
---
Description: 
Archetype ITs should exclude copying unnecessary file {{build.log}} (open file 
with ongoing writes), otherwise the copy of the file content fails.

{noformat}
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-archetype-plugin:3.1.2-SNAPSHOT:create-from-project
 (default-cli) on project include-file-with-no-extension: 
{noformat}


{noformat}
Failed to copy full contents from 
F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\build.log
 to 
F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\target\generated-sources\archetype\src\main\resources\archetype-resources\build.log
 -> [Help 1]
{noformat}

{noformat}
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal 
org.apache.maven.plugins:maven-archetype-plugin:3.1.2-SNAPSHOT:create-from-project
 (default-cli) on project include-file-with-no-extension: 
{noformat}


{noformat}
Failed to copy full contents from 
F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\build.log
 to 
F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\target\generated-sources\archetype\src\main\resources\archetype-resources\build.log
{noformat}

  was:
Archetype ITs should exclude copying unnecessary file {{build.log}} (open file 
with ongoing writes), otherwise the copy of the file content fails with 
IOException.

{noformat}
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-archetype-plugin:3.1.2-SNAPSHOT:create-from-project
 (default-cli) on project include-file-with-no-extension: 
{noformat}


{noformat}
Failed to copy full contents from 
F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\build.log
 to 
F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\target\generated-sources\archetype\src\main\resources\archetype-resources\build.log
 -> [Help 1]
{noformat}

{noformat}
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal 
org.apache.maven.plugins:maven-archetype-plugin:3.1.2-SNAPSHOT:create-from-project
 (default-cli) on project include-file-with-no-extension: 
{noformat}


{noformat}
Failed to copy full contents from 
F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\build.log
 to 
F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\target\generated-sources\archetype\src\main\resources\archetype-resources\build.log
{noformat}


> The build fails in the integration tests because 'build.log' is being copied 
> and failed
> ---
>
> Key: ARCHETYPE-581
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-581
> Project: Maven Archetype
>  Issue Type: Test
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.1.2
>
>
> Archetype ITs should exclude copying unnecessary file {{build.log}} (open 
> file with ongoing writes), otherwise the copy of the file content fails.
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-archetype-plugin:3.1.2-SNAPSHOT:create-from-project
>  (default-cli) on project include-file-with-no-extension: 
> {noformat}
> {noformat}
> Failed to copy full contents from 
> F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\build.log
>  to 
> F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\target\generated-sources\archetype\src\main\resources\archetype-resources\build.log
>  -> [Help 1]
> {noformat}
> {noformat}
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal 
> org.apache.maven.plugins:maven-archetype-plugin:3.1.2-SNAPSHOT:create-from-project
>  (default-cli) on project include-file-with-no-extension: 
> {noformat}
> {noformat}
> Failed to copy full contents from 
> F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\build.log
>  to 
> 

[jira] [Updated] (ARCHETYPE-581) The build fails in the integration tests because 'build.log' is being copied and failed

2019-08-18 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARCHETYPE-581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana updated ARCHETYPE-581:
---
Description: 
Archetype ITs should exclude copying unnecessary file {{build.log}} (open file 
with ongoing writes), otherwise the copy of the file content fails with 
IOException.

{noformat}
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-archetype-plugin:3.1.2-SNAPSHOT:create-from-project
 (default-cli) on project include-file-with-no-extension: 
{noformat}


{noformat}
Failed to copy full contents from 
F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\build.log
 to 
F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\target\generated-sources\archetype\src\main\resources\archetype-resources\build.log
 -> [Help 1]
{noformat}

{noformat}
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal 
org.apache.maven.plugins:maven-archetype-plugin:3.1.2-SNAPSHOT:create-from-project
 (default-cli) on project include-file-with-no-extension: 
{noformat}


{noformat}
Failed to copy full contents from 
F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\build.log
 to 
F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\target\generated-sources\archetype\src\main\resources\archetype-resources\build.log
{noformat}

  was:
{noformat}
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-archetype-plugin:3.1.2-SNAPSHOT:create-from-project
 (default-cli) on project include-file-with-no-extension: 
{noformat}


{noformat}
Failed to copy full contents from 
F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\build.log
 to 
F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\target\generated-sources\archetype\src\main\resources\archetype-resources\build.log
 -> [Help 1]
{noformat}

{noformat}
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal 
org.apache.maven.plugins:maven-archetype-plugin:3.1.2-SNAPSHOT:create-from-project
 (default-cli) on project include-file-with-no-extension: 
{noformat}


{noformat}
Failed to copy full contents from 
F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\build.log
 to 
F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\target\generated-sources\archetype\src\main\resources\archetype-resources\build.log
{noformat}


> The build fails in the integration tests because 'build.log' is being copied 
> and failed
> ---
>
> Key: ARCHETYPE-581
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-581
> Project: Maven Archetype
>  Issue Type: Test
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.1.2
>
>
> Archetype ITs should exclude copying unnecessary file {{build.log}} (open 
> file with ongoing writes), otherwise the copy of the file content fails with 
> IOException.
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-archetype-plugin:3.1.2-SNAPSHOT:create-from-project
>  (default-cli) on project include-file-with-no-extension: 
> {noformat}
> {noformat}
> Failed to copy full contents from 
> F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\build.log
>  to 
> F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\target\generated-sources\archetype\src\main\resources\archetype-resources\build.log
>  -> [Help 1]
> {noformat}
> {noformat}
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal 
> org.apache.maven.plugins:maven-archetype-plugin:3.1.2-SNAPSHOT:create-from-project
>  (default-cli) on project include-file-with-no-extension: 
> {noformat}
> {noformat}
> Failed to copy full contents from 
> F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\build.log
>  to 
> 

[jira] [Created] (ARCHETYPE-581) The build fails in the integration tests because 'build.log' is being copied and failed

2019-08-18 Thread Tibor Digana (JIRA)
Tibor Digana created ARCHETYPE-581:
--

 Summary: The build fails in the integration tests because 
'build.log' is being copied and failed
 Key: ARCHETYPE-581
 URL: https://issues.apache.org/jira/browse/ARCHETYPE-581
 Project: Maven Archetype
  Issue Type: Test
Reporter: Tibor Digana
Assignee: Tibor Digana
 Fix For: 3.1.2


{noformat}
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-archetype-plugin:3.1.2-SNAPSHOT:create-from-project
 (default-cli) on project include-file-with-no-extension: 
{noformat}


{noformat}
Failed to copy full contents from 
F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\build.log
 to 
F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\target\generated-sources\archetype\src\main\resources\archetype-resources\build.log
 -> [Help 1]
{noformat}

{noformat}
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal 
org.apache.maven.plugins:maven-archetype-plugin:3.1.2-SNAPSHOT:create-from-project
 (default-cli) on project include-file-with-no-extension: 
{noformat}


{noformat}
Failed to copy full contents from 
F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\build.log
 to 
F:\short\jenkins-maven-box-maven-archetype-master-50@3\j13m3.6.xb\maven-archetype-plugin\target\it\projects\include-file-with-no-extension\target\generated-sources\archetype\src\main\resources\archetype-resources\build.log
{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (MSITE-849) Unable to inject MavenProject when using `mvn site:run`

2019-08-18 Thread Michael Osipov (JIRA)


[ 
https://issues.apache.org/jira/browse/MSITE-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909949#comment-16909949
 ] 

Michael Osipov commented on MSITE-849:
--

What about {{@Requirement}}?

> Unable to inject MavenProject when using `mvn site:run`
> ---
>
> Key: MSITE-849
> URL: https://issues.apache.org/jira/browse/MSITE-849
> Project: Maven Site Plugin
>  Issue Type: New Feature
>Affects Versions: 3.7.1, 3.8.2
>Reporter: Abel Salgado Romero
>Assignee: Michael Osipov
>Priority: Major
>
> In https://github.com/asciidoctor/asciidoctor-maven-plugin we inject a 
> MavenProject to obtain addition configurations from the pom.xml 
> (https://github.com/asciidoctor/asciidoctor-maven-plugin/blob/a4d86a949643ab68c124fd4c1b9b936412637d93/src/main/java/org/asciidoctor/maven/site/AsciidoctorDoxiaParser.java#L54).
> This works fine with {{site:site}}, but when using {{site:run}} and accessing 
> one of the Asciidoc generated pages we get the error below.
> I saw that:
> * The error occurs when trying to retrieve the instance of the MavenProject.
> * Behavior is the same if I directly inject the MavenProject instead of using 
> a provider. That is, {{site:site}} works, {{site:run}} fails because it 
> cannot find the instance.
> {code:java}
> HTTP ERROR 500
> Problem accessing /hello.html. Reason:
> Server Error
> Caused by:
> com.google.inject.ProvisionException: Unable to provision, see the following 
> errors:
> 1) Error in custom provider, com.google.inject.OutOfScopeException: Cannot 
> access Key[type=org.apache.maven.project.MavenProject, annotation=[none]] 
> outside of a scoping block
>   at 
> org.apache.maven.execution.scope.internal.MojoExecutionScopeModule.configure(MojoExecutionScopeModule.java:55)
>  (via modules: org.eclipse.sisu.wire.WireModule -> 
> org.apache.maven.execution.scope.internal.MojoExecutionScopeModule)
>   while locating org.apache.maven.project.MavenProject
> 1 error
>   at 
> com.google.inject.internal.InternalProvisionException.toProvisionException(InternalProvisionException.java:226)
>   at com.google.inject.internal.InjectorImpl$1.get(InjectorImpl.java:1053)
>   at 
> org.asciidoctor.maven.site.AsciidoctorDoxiaParser.parse(AsciidoctorDoxiaParser.java:78)
>   at org.apache.maven.doxia.DefaultDoxia.parse(DefaultDoxia.java:65)
> {code}
> * How to reproduce:
> # clone https://github.com/asciidoctor/asciidoctor-maven-examples
> # cd asciidoc-maven-site-example
> # mvn site:run
> # Access {{http://localhost:8080/hello.html}}
> * Env:
> {code}
> $ mvn -v
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
> 2019-04-04T21:00:29+02:00)
> Maven home: /home//.sdkman/candidates/maven/current
> Java version: 1.8.0_222, vendor: AdoptOpenJDK, runtime: 
> /home/-/.sdkman/candidates/java/8.0.222.hs-adpt/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.1.21-1-manjaro", arch: "amd64", family: "unix
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (MINDEXER-104) Migrate the indexer to Lucene 6.1

2019-08-18 Thread Sylwester Lachiewicz (JIRA)


 [ 
https://issues.apache.org/jira/browse/MINDEXER-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sylwester Lachiewicz updated MINDEXER-104:
--
Fix Version/s: 7.0.0

> Migrate the indexer to Lucene 6.1
> -
>
> Key: MINDEXER-104
> URL: https://issues.apache.org/jira/browse/MINDEXER-104
> Project: Maven Indexer
>  Issue Type: Improvement
>Reporter: Sopot Cela
>Priority: Minor
> Fix For: 7.0.0
>
>
> See summary. There is PR already in place for it: 
> [https://github.com/apache/maven-indexer/pull/17]
> Lucene changelogs: 
> [http://archive.apache.org/dist/lucene/java/8.0.0/changes/Changes.html] 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (MINDEXER-116) Move to Java 8 as minimum Java version

2019-08-18 Thread Sylwester Lachiewicz (JIRA)


 [ 
https://issues.apache.org/jira/browse/MINDEXER-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sylwester Lachiewicz updated MINDEXER-116:
--
Fix Version/s: 7.0.0

> Move to Java 8 as minimum Java version
> --
>
> Key: MINDEXER-116
> URL: https://issues.apache.org/jira/browse/MINDEXER-116
> Project: Maven Indexer
>  Issue Type: Improvement
>Reporter: Sylwester Lachiewicz
>Priority: Major
> Fix For: 7.0.0
>
>
> We should start updating our minimal Java version because Lucene 5.5.5 is the 
> last version based on Java 7. All subsequent versions, starting from version 
> 6.0.0, require Java 8
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (MSITE-849) Unable to inject MavenProject when using `mvn site:run`

2019-08-18 Thread Abel Salgado Romero (JIRA)


[ 
https://issues.apache.org/jira/browse/MSITE-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909940#comment-16909940
 ] 

Abel Salgado Romero commented on MSITE-849:
---

Just tried injecting MavenProject with {{@Component}} as in the Mojo, but it's 
null :/


> Unable to inject MavenProject when using `mvn site:run`
> ---
>
> Key: MSITE-849
> URL: https://issues.apache.org/jira/browse/MSITE-849
> Project: Maven Site Plugin
>  Issue Type: New Feature
>Affects Versions: 3.7.1, 3.8.2
>Reporter: Abel Salgado Romero
>Assignee: Michael Osipov
>Priority: Major
>
> In https://github.com/asciidoctor/asciidoctor-maven-plugin we inject a 
> MavenProject to obtain addition configurations from the pom.xml 
> (https://github.com/asciidoctor/asciidoctor-maven-plugin/blob/a4d86a949643ab68c124fd4c1b9b936412637d93/src/main/java/org/asciidoctor/maven/site/AsciidoctorDoxiaParser.java#L54).
> This works fine with {{site:site}}, but when using {{site:run}} and accessing 
> one of the Asciidoc generated pages we get the error below.
> I saw that:
> * The error occurs when trying to retrieve the instance of the MavenProject.
> * Behavior is the same if I directly inject the MavenProject instead of using 
> a provider. That is, {{site:site}} works, {{site:run}} fails because it 
> cannot find the instance.
> {code:java}
> HTTP ERROR 500
> Problem accessing /hello.html. Reason:
> Server Error
> Caused by:
> com.google.inject.ProvisionException: Unable to provision, see the following 
> errors:
> 1) Error in custom provider, com.google.inject.OutOfScopeException: Cannot 
> access Key[type=org.apache.maven.project.MavenProject, annotation=[none]] 
> outside of a scoping block
>   at 
> org.apache.maven.execution.scope.internal.MojoExecutionScopeModule.configure(MojoExecutionScopeModule.java:55)
>  (via modules: org.eclipse.sisu.wire.WireModule -> 
> org.apache.maven.execution.scope.internal.MojoExecutionScopeModule)
>   while locating org.apache.maven.project.MavenProject
> 1 error
>   at 
> com.google.inject.internal.InternalProvisionException.toProvisionException(InternalProvisionException.java:226)
>   at com.google.inject.internal.InjectorImpl$1.get(InjectorImpl.java:1053)
>   at 
> org.asciidoctor.maven.site.AsciidoctorDoxiaParser.parse(AsciidoctorDoxiaParser.java:78)
>   at org.apache.maven.doxia.DefaultDoxia.parse(DefaultDoxia.java:65)
> {code}
> * How to reproduce:
> # clone https://github.com/asciidoctor/asciidoctor-maven-examples
> # cd asciidoc-maven-site-example
> # mvn site:run
> # Access {{http://localhost:8080/hello.html}}
> * Env:
> {code}
> $ mvn -v
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
> 2019-04-04T21:00:29+02:00)
> Maven home: /home//.sdkman/candidates/maven/current
> Java version: 1.8.0_222, vendor: AdoptOpenJDK, runtime: 
> /home/-/.sdkman/candidates/java/8.0.222.hs-adpt/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.1.21-1-manjaro", arch: "amd64", family: "unix
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [maven-indexer] eolivelli edited a comment on issue #39: Add getName() to Record.EntryKey

2019-08-18 Thread GitBox
eolivelli edited a comment on issue #39: Add getName() to Record.EntryKey
URL: https://github.com/apache/maven-indexer/pull/39#issuecomment-522232313
 
 
   Can you please open a JIRA and change the commit message?
   I will be happy to merge, the change is trivial an useful, but it is a 
public API change


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (ARCHETYPE-580) The build fails with integration test (build-and-run-its) to find expected text in 'build.log'

2019-08-18 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARCHETYPE-580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana updated ARCHETYPE-580:
---
Summary: The build fails with integration test (build-and-run-its) to find 
expected text in 'build.log'  (was: The build fails with integration test 
(build-and-run-its) to find expected test in 'build.log')

> The build fails with integration test (build-and-run-its) to find expected 
> text in 'build.log'
> --
>
> Key: ARCHETYPE-580
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-580
> Project: Maven Archetype
>  Issue Type: Test
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.1.2
>
>
> {{CommandLineUtils}} may not catch up with written stream of a sub-process 
> while the sub-process is about to exit.
> The stream is written by 
> {{maven-archetype-plugin\target\it\projects\build-and-run-its\target\test-classes\projects\basic/verify.groovy}}
> and read in
> {{maven-archetype-plugin\target\it\projects\build-and-run-its\verify.bsh}}.
> Error in {{build.log}}:
> {noformat}
> Running post-build script: 
> C:\vcs\github\maven-archetype\maven-archetype-plugin\target\it\projects\build-and-run-its\verify.bsh
> java.lang.Exception: build.log missing System.out.println from verify.groovy
>   at 
> java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native
>  Method)
>   at 
> java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>   at 
> java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>   at 
> java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
>   at 
> java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
>   at bsh.Reflect.constructObject(Unknown Source)
>   at bsh.BSHAllocationExpression.constructObject(Unknown Source)
>   at bsh.BSHAllocationExpression.objectAllocation(Unknown Source)
>   at bsh.BSHAllocationExpression.eval(Unknown Source)
>   at bsh.BSHPrimaryExpression.eval(Unknown Source)
>   at bsh.BSHPrimaryExpression.eval(Unknown Source)
>   at bsh.BSHThrowStatement.eval(Unknown Source)
>   at bsh.BSHBlock.evalBlock(Unknown Source)
>   at bsh.BSHBlock.eval(Unknown Source)
>   at bsh.BSHBlock.eval(Unknown Source)
>   at bsh.BSHIfStatement.eval(Unknown Source)
>   at bsh.Interpreter.eval(Unknown Source)
>   at bsh.Interpreter.eval(Unknown Source)
>   at bsh.Interpreter.eval(Unknown Source)
>   at 
> org.apache.maven.shared.scriptinterpreter.BeanShellScriptInterpreter.evaluateScript(BeanShellScriptInterpreter.java:116)
>   at 
> org.apache.maven.shared.scriptinterpreter.ScriptRunner.executeRun(ScriptRunner.java:256)
>   at 
> org.apache.maven.shared.scriptinterpreter.ScriptRunner.run(ScriptRunner.java:180)
>   at 
> org.apache.maven.plugins.invoker.AbstractInvokerMojo.runPostBuildHook(AbstractInvokerMojo.java:2051)
>   at 
> org.apache.maven.plugins.invoker.AbstractInvokerMojo.runBuild(AbstractInvokerMojo.java:2036)
>   at 
> org.apache.maven.plugins.invoker.AbstractInvokerMojo.runBuild(AbstractInvokerMojo.java:1649)
>   at 
> org.apache.maven.plugins.invoker.AbstractInvokerMojo.runBuilds(AbstractInvokerMojo.java:1358)
>   at 
> org.apache.maven.plugins.invoker.AbstractInvokerMojo.execute(AbstractInvokerMojo.java:768)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:210)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:156)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:956)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
>   at 

[jira] [Closed] (ARCHETYPE-580) The build fails with integration test (build-and-run-its) to find expected test in 'build.log'

2019-08-18 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARCHETYPE-580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana closed ARCHETYPE-580.
--
Resolution: Fixed

https://gitbox.apache.org/repos/asf?p=maven-archetype.git;a=commit;h=dc16c713e442fbf932c8f92ca657d1e642bcd7ca

> The build fails with integration test (build-and-run-its) to find expected 
> test in 'build.log'
> --
>
> Key: ARCHETYPE-580
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-580
> Project: Maven Archetype
>  Issue Type: Test
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.1.2
>
>
> {{CommandLineUtils}} may not catch up with written stream of a sub-process 
> while the sub-process is about to exit.
> The stream is written by 
> {{maven-archetype-plugin\target\it\projects\build-and-run-its\target\test-classes\projects\basic/verify.groovy}}
> and read in
> {{maven-archetype-plugin\target\it\projects\build-and-run-its\verify.bsh}}.
> Error in {{build.log}}:
> {noformat}
> Running post-build script: 
> C:\vcs\github\maven-archetype\maven-archetype-plugin\target\it\projects\build-and-run-its\verify.bsh
> java.lang.Exception: build.log missing System.out.println from verify.groovy
>   at 
> java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native
>  Method)
>   at 
> java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>   at 
> java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>   at 
> java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
>   at 
> java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
>   at bsh.Reflect.constructObject(Unknown Source)
>   at bsh.BSHAllocationExpression.constructObject(Unknown Source)
>   at bsh.BSHAllocationExpression.objectAllocation(Unknown Source)
>   at bsh.BSHAllocationExpression.eval(Unknown Source)
>   at bsh.BSHPrimaryExpression.eval(Unknown Source)
>   at bsh.BSHPrimaryExpression.eval(Unknown Source)
>   at bsh.BSHThrowStatement.eval(Unknown Source)
>   at bsh.BSHBlock.evalBlock(Unknown Source)
>   at bsh.BSHBlock.eval(Unknown Source)
>   at bsh.BSHBlock.eval(Unknown Source)
>   at bsh.BSHIfStatement.eval(Unknown Source)
>   at bsh.Interpreter.eval(Unknown Source)
>   at bsh.Interpreter.eval(Unknown Source)
>   at bsh.Interpreter.eval(Unknown Source)
>   at 
> org.apache.maven.shared.scriptinterpreter.BeanShellScriptInterpreter.evaluateScript(BeanShellScriptInterpreter.java:116)
>   at 
> org.apache.maven.shared.scriptinterpreter.ScriptRunner.executeRun(ScriptRunner.java:256)
>   at 
> org.apache.maven.shared.scriptinterpreter.ScriptRunner.run(ScriptRunner.java:180)
>   at 
> org.apache.maven.plugins.invoker.AbstractInvokerMojo.runPostBuildHook(AbstractInvokerMojo.java:2051)
>   at 
> org.apache.maven.plugins.invoker.AbstractInvokerMojo.runBuild(AbstractInvokerMojo.java:2036)
>   at 
> org.apache.maven.plugins.invoker.AbstractInvokerMojo.runBuild(AbstractInvokerMojo.java:1649)
>   at 
> org.apache.maven.plugins.invoker.AbstractInvokerMojo.runBuilds(AbstractInvokerMojo.java:1358)
>   at 
> org.apache.maven.plugins.invoker.AbstractInvokerMojo.execute(AbstractInvokerMojo.java:768)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:210)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:156)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:956)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:192)
>   at 
> 

[jira] [Updated] (ARCHETYPE-580) The build fails with integration test (build-and-run-its) to find expected test in 'build.log'

2019-08-18 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARCHETYPE-580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana updated ARCHETYPE-580:
---
Description: 
{{CommandLineUtils}} may not catch up with written stream of a sub-process 
while the sub-process is about to exit.

The stream is written by 
{{maven-archetype-plugin\target\it\projects\build-and-run-its\target\test-classes\projects\basic/verify.groovy}}
and read in
{{maven-archetype-plugin\target\it\projects\build-and-run-its\verify.bsh}}.


Error in {{build.log}}:

{noformat}
Running post-build script: 
C:\vcs\github\maven-archetype\maven-archetype-plugin\target\it\projects\build-and-run-its\verify.bsh
java.lang.Exception: build.log missing System.out.println from verify.groovy
at 
java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native
 Method)
at 
java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at 
java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at 
java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
at 
java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
at bsh.Reflect.constructObject(Unknown Source)
at bsh.BSHAllocationExpression.constructObject(Unknown Source)
at bsh.BSHAllocationExpression.objectAllocation(Unknown Source)
at bsh.BSHAllocationExpression.eval(Unknown Source)
at bsh.BSHPrimaryExpression.eval(Unknown Source)
at bsh.BSHPrimaryExpression.eval(Unknown Source)
at bsh.BSHThrowStatement.eval(Unknown Source)
at bsh.BSHBlock.evalBlock(Unknown Source)
at bsh.BSHBlock.eval(Unknown Source)
at bsh.BSHBlock.eval(Unknown Source)
at bsh.BSHIfStatement.eval(Unknown Source)
at bsh.Interpreter.eval(Unknown Source)
at bsh.Interpreter.eval(Unknown Source)
at bsh.Interpreter.eval(Unknown Source)
at 
org.apache.maven.shared.scriptinterpreter.BeanShellScriptInterpreter.evaluateScript(BeanShellScriptInterpreter.java:116)
at 
org.apache.maven.shared.scriptinterpreter.ScriptRunner.executeRun(ScriptRunner.java:256)
at 
org.apache.maven.shared.scriptinterpreter.ScriptRunner.run(ScriptRunner.java:180)
at 
org.apache.maven.plugins.invoker.AbstractInvokerMojo.runPostBuildHook(AbstractInvokerMojo.java:2051)
at 
org.apache.maven.plugins.invoker.AbstractInvokerMojo.runBuild(AbstractInvokerMojo.java:2036)
at 
org.apache.maven.plugins.invoker.AbstractInvokerMojo.runBuild(AbstractInvokerMojo.java:1649)
at 
org.apache.maven.plugins.invoker.AbstractInvokerMojo.runBuilds(AbstractInvokerMojo.java:1358)
at 
org.apache.maven.plugins.invoker.AbstractInvokerMojo.execute(AbstractInvokerMojo.java:768)
at 
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:210)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:156)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56)
at 
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:956)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:192)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:567)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:282)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:225)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:406)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:347)