[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r334773548 ## File path: maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java ## @@ -238,9 +263,83 @@ else if ( request.isUpdateSnapshots() ) mavenRepositorySystem.injectProxy( session, request.getPluginArtifactRepositories() ); mavenRepositorySystem.injectAuthentication( session, request.getPluginArtifactRepositories() ); +if ( Boolean.getBoolean( "maven.experimental.buildconsumer" ) ) Review comment: The number of locations went beyond 4, so something had to be improved. Introduced a Features class, where you can easily switch the default value. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base
for build/consumer process
URL: https://github.com/apache/maven/pull/286#discussion_r334773151
##
File path:
maven-xml/src/main/java/org/apache/maven/xml/filter/DependencyKey.java
##
@@ -0,0 +1,88 @@
+package org.apache.maven.xml.filter;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.Objects;
+
+/**
+ *
+ * @author Robert Scholte
+ * @since 3.7.0
+ */
+public class DependencyKey
+{
+private final String groupId;
+
+private final String artifactId;
+
+public DependencyKey( String groupId, String artifactId )
+{
+this.groupId = groupId;
+this.artifactId = artifactId;
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base
for build/consumer process
URL: https://github.com/apache/maven/pull/286#discussion_r334772817
##
File path:
maven-xml/src/test/java/org/apache/maven/xml/filter/ConsumerPomXMLFilterTest.java
##
@@ -0,0 +1,168 @@
+package org.apache.maven.xml.filter;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import static org.xmlunit.assertj.XmlAssert.assertThat;
+
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.Optional;
+import java.util.function.Function;
+
+import javax.inject.Provider;
+import javax.xml.parsers.ParserConfigurationException;
+
+import org.junit.Test;
+import org.xml.sax.SAXException;
+import org.xml.sax.XMLFilter;
+
+public class ConsumerPomXMLFilterTest extends AbstractXMLFilterTests
+{
+@Override
+protected XMLFilter getFilter() throws SAXException,
ParserConfigurationException
+{
+final BuildPomXMLFilterFactory buildPomXMLFilterFactory = new
BuildPomXMLFilterFactory()
+{
+@Override
+protected Optional getSha1()
+{
+return Optional.empty();
+}
+
+@Override
+protected Optional getRevision()
+{
+return Optional.empty();
+}
+
+@Override
+protected Optional getChangelist()
+{
+return Optional.of( "CL" );
+}
+
+@Override
+protected Function>
getRelativePathMapper()
+{
+return null;
+}
+
+@Override
+protected Function
getDependencyKeyToVersionMapper()
+{
+return null;
+}
+};
+
+Provider provider = new
Provider()
+{
+
+@Override
+public BuildPomXMLFilterFactory get()
+{
+return buildPomXMLFilterFactory;
+}
+};
+
+XMLFilter filter = new ConsumerPomXMLFilterFactory( provider )
+{
+}.get( Paths.get( "pom.xml" ) );
+filter.setFeature( "http://xml.org/sax/features/namespaces";, true );
+return filter;
+}
+
+@Test
+public void testAllFilters() throws Exception {
+String input = "\n"
+ + " \n"
+ + "GROUPID\n"
+ + "PARENT\n"
+ + "VERSION\n"
+ + "../pom.xml\n"
+ + " \n"
+ + " PROJECT\n"
+ + " \n"
+ + "ab\n"
+ + "../cd\n"
+ + " \n"
+ + "";
+String expected = "\n"
++ " \n"
++ "GROUPID\n"
++ "PARENT\n"
++ "VERSION\n"
++ "\n"
++ " \n"
++ " PROJECT\n"
++ "";
+String actual = transform( input );
+assertThat( actual ).and( expected ).ignoreWhitespace().areIdentical();
+}
+
+@Test
+public void testMe() throws Exception {
+String input = "\r\n" +
+"http://maven.apache.org/POM/4.0.0\"; \r\n" +
+"
xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"\r\n"; +
+" xsi:schemaLocation=\"http://maven.apache.org/POM/4.0.0
\r\n" +
+"
http://maven.apache.org/maven-v4_0_0.xsd\";>\r\n" +
Review comment:
I've created https://issues.apache.org/jira/browse/MNG-6778 to fix that in
the official poms.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base
for build/consumer process
URL: https://github.com/apache/maven/pull/286#discussion_r334772348
##
File path:
maven-core/src/test/java/org/apache/maven/xml/filter/ConsumerPomXMLFilterTest.java
##
@@ -0,0 +1,64 @@
+package org.apache.maven.xml.filter;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import static org.xmlunit.assertj.XmlAssert.assertThat;
+
+import org.junit.Before;
+import org.junit.Test;
+
+public class ConsumerPomXMLFilterTest extends AbstractXMLFilterTests
+{
+private ConsumerPomXMLFilter filter;
+
+@Before
+public void setup() throws Exception {
+filter = new ConsumerPomXMLFilter();
+}
+
+@Test
+public void testAllFilters() throws Exception {
+String input = "\n"
+ + " \n"
+ + "GROUPID\n"
+ + "PARENT\n"
+ + "VERSION\n"
+ + "../pom.xml\n"
+ + " \n"
+ + " PROJECT\n"
+ + " \n"
+ + "ab\n"
+ + "../cd\n"
+ + " \n"
+ + "";
+String expected = "\n"
++ " \n"
++ "GROUPID\n"
++ "PARENT\n"
++ "VERSION\n"
++ "\n"
Review comment:
Okay, let's drop relativePath, so the XML looks as expected. We can always
decide to optimize the ModelBuilders for this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (MNG-6777) Remove duplicate resolveFile methods
[ https://issues.apache.org/jira/browse/MNG-6777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951649#comment-16951649 ] Hudson commented on MNG-6777: - Build failed in Jenkins: Maven TLP » maven » MNG-6656 #18 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6656/18/ > Remove duplicate resolveFile methods > > > Key: MNG-6777 > URL: https://issues.apache.org/jira/browse/MNG-6777 > Project: Maven > Issue Type: Task > Components: Embedding >Affects Versions: 3.6.3 >Reporter: Anatoly Zaretsky >Priority: Trivial > Time Spent: 20m > Remaining Estimate: 0h > > Both org.apache.maven.cli.MavenCli and > org.apache.maven.cli.configuration.SettingsXmlConfigurationProcessor contain > identical package-private static methods called resolveFile - they can be > replaced with the new public class org.apache.maven.cli.ResolveFile with the > single public static method resolveFile. Also it would be more appropriate to > rename workingDirectory parameter to baseDirectory. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-6656) Introduce base for build/consumer process
[
https://issues.apache.org/jira/browse/MNG-6656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951650#comment-16951650
]
Hudson commented on MNG-6656:
-
Build failed in Jenkins: Maven TLP » maven » MNG-6656 #18
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6656/18/
> Introduce base for build/consumer process
> -
>
> Key: MNG-6656
> URL: https://issues.apache.org/jira/browse/MNG-6656
> Project: Maven
> Issue Type: New Feature
> Components: POM
>Reporter: Robert Scholte
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 3.7.0-candidate
>
> Attachments: MNG-6656.zip
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The pom.xml as we know it has reached it limits, but it is quite hard to do
> improvements as long as the local pom (as part of the sources) is exactly the
> same as the file being published.
> For the Maven eco system it is important that the published file will still
> be a model 4.0.0 to ensure other projects can still depend on these artifacts.
> This will be a first step to separate the local pom from the remote pom. The
> process to come to the effective pom will change a little bit
> pre-build
> pom.xml (raw model) -> BuildPomXMLFilter -> inheritence -> effective pom/model
> This means that we can enrich the pom to make it a valid effective pom again.
> In this case we can do the following:
> - resolve the [cifriendly
> placeholders|https://maven.apache.org/maven-ci-friendly.html], so it will
> work in multimodules too.
> - resolve parent-version. By removing the version from the parent, the filter
> will get the version based on the relativePath. If the groupId and artifactId
> don't match, the version can't be solved and Maven will fail with a missing
> version for the parent.
> - resolve reactor versions. By removing the versions from reactor
> dependencies, the filter will look up the matching version. If there's no
> version for the groupId+artifactId, the version can't be solved and Maven
> will fail with a missing version for the dependency.
> pre-distribution (install/deploy)
> pom.xml -> BuildPomXMLFilter -> ConsumerPomXMLFilter -> consumer pom
> This means that the XML used to build build the effective pom is used, and
> can be adjusted during copy/upload.
> In this case we can do the following:
> - Remove the modules -elements, since this is local path information and not
> useful after building
> - Remove the relativePath-element, since this is local path information and
> not useful after building
> This PoC has the following goals:
> - It will give us experience with manipuating files before build AND during
> install/deploy.
> - We can see IDEs and CI servers can handle this and how we can move forward.
> This feature will at first be disabled by default and can be activated with
> the System property {{maven.experimental.buildconsumer=true}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SUREFIRE-1584) Rerun Failing Tests with JUnit 5
[
https://issues.apache.org/jira/browse/SUREFIRE-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951379#comment-16951379
]
Tibor Digana commented on SUREFIRE-1584:
[~quiram]
Did you build surefire project locally or you used deployed snapshot version
{{3.0.0-SNAPSHOT}}?
Pls try it again with surefire and let me know if it is nok. Both plugins are
99% same in principle.
> Rerun Failing Tests with JUnit 5
>
>
> Key: SUREFIRE-1584
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1584
> Project: Maven Surefire
> Issue Type: New Feature
> Components: JUnit 5.x support, Maven Surefire Report Plugin
>Affects Versions: 2.22.0
>Reporter: Tic Tac
>Assignee: Tibor Digana
>Priority: Major
> Labels: junit5
> Fix For: 3.0.0-M4
>
> Attachments: FlakyReruns.png
>
>
> The very useful feature for integration tests ¨[Rerun Failing
> Tests|https://maven.apache.org/surefire/maven-surefire-plugin/examples/rerun-failing-tests.html]¨
> is currently only supported for the very outdated JUnit 4.
> The documentation says: ¨This feature is supported only for JUnit 4.x.¨
> Can you please support this feature for JUnit 5.3 or later?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (MNG-6785) Fail to deploy on Sonatype OSS since maven 3.5.4
Stephane Landelle created MNG-6785:
--
Summary: Fail to deploy on Sonatype OSS since maven 3.5.4
Key: MNG-6785
URL: https://issues.apache.org/jira/browse/MNG-6785
Project: Maven
Issue Type: Bug
Components: Deployment
Affects Versions: 3.6.2, 3.5.4
Environment: 17.7.0 Darwin Kernel Version 17.7.0: Thu Jun 21 22:53:14
PDT 2018; root:xnu-4570.71.2~1/RELEASE_X86_64 x86_64
openjdk version "1.8.0_202"
OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_202-b08)
OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.202-b08, mixed mode)
Reporter: Stephane Landelle
I've been trying to release AsyncHttpClient for days and deployment was always
super slow until it ultimately failed or completely stalled.
The issue seems to be that maven-deploy-plugin wants to upload checksum files.
I have no idea where those would come from, as far as I know, those are
generated by the maven repository.
{code:java}
[INFO] --- maven-deploy-plugin:2.8.2:deploy (default-deploy) @
async-http-client-project ---
Uploading to sonatype-nexus-staging:
http://oss.sonatype.org/service/local/staging/deploy/maven2/org/asynchttpclient/async-http-client-project/2.0.40/async-http-client-project-2.0.40.pom
[WARNING] Failed to upload checksum
org/asynchttpclient/async-http-client-project/2.0.40/async-http-client-project-2.0.40.pom.sha1:
null{code}
For each actual file, maven-deploy-plugin tries to upload a sha1 and a md5
files and this takes forever to ultimately fail.
I tried upgrading plugins but nothing worked.
I finally found [this
ticket|[https://issues.sonatype.org/browse/OSSRH-43371?focusedCommentId=610865&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-610865]]
against Sonatype OSS describing the exact same behavior and stating
downgrading to maven 3.5.3 fixed the issue.
Indeed, downgrading did the trick!
I'm opening an issue here and not against OSS Sonatype as it looks like a maven
regression to me.
* maven 3.6.2: fails
* maven 3.5.4: fails
* maven 3.5.3: works like a charm
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MCHECKSTYLE-382) Add option to generate suppression xml file
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Gupta updated MCHECKSTYLE-382:
-
Description:
The checkstyle CLI has an option to generate a suppressions file
{{-g, --generate-xpath-suppression - generate to output a suppression xml to
use to suppress all violations from user's config. Instead of printing every
violation, all violations will be catched and single suppressions xml file will
be printed out. Used only with -c option. Output location can be specified with
-o option.}}{{This should also be exposed in the maven checkstyle plugin.}}
was:
The checkstyle CLI has an option to generate a suppressions file
-g,--generate-xpath-suppression - generate to output a suppression xml to use
to suppress all violations from user's config. Instead of printing every
violation, all violations will be catched and single suppressions xml file will
be printed out. Used only with -c option. Output location can be specified with
-o option.
This should also be exposed in the maven checkstyle plugin.
> Add option to generate suppression xml file
> ---
>
> Key: MCHECKSTYLE-382
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-382
> Project: Maven Checkstyle Plugin
> Issue Type: New Feature
>Reporter: Apoorv Gupta
>Priority: Major
>
> The checkstyle CLI has an option to generate a suppressions file
> {{-g, --generate-xpath-suppression - generate to output a suppression xml to
> use to suppress all violations from user's config. Instead of printing every
> violation, all violations will be catched and single suppressions xml file
> will be printed out. Used only with -c option. Output location can be
> specified with -o option.}}{{This should also be exposed in the maven
> checkstyle plugin.}}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MCHECKSTYLE-382) Add option to generate suppression xml file
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Gupta updated MCHECKSTYLE-382:
-
Description:
The checkstyle CLI has an option to generate a suppressions file
{{-g, --generate-xpath-suppression - generate to output a suppression xml to
use to suppress all violations from user's config. Instead of printing every
violation, all violations will be catched and single suppressions xml file will
be printed out. Used only with -c option. Output location can be specified with
-o option.}}
This should also be exposed in the maven checkstyle plugin.
was:
The checkstyle CLI has an option to generate a suppressions file
{{-g, --generate-xpath-suppression - generate to output a suppression xml to
use to suppress all violations from user's config. Instead of printing every
violation, all violations will be catched and single suppressions xml file will
be printed out. Used only with -c option. Output location can be specified with
-o option.}}{{This should also be exposed in the maven checkstyle plugin.}}
> Add option to generate suppression xml file
> ---
>
> Key: MCHECKSTYLE-382
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-382
> Project: Maven Checkstyle Plugin
> Issue Type: New Feature
>Reporter: Apoorv Gupta
>Priority: Major
>
> The checkstyle CLI has an option to generate a suppressions file
> {{-g, --generate-xpath-suppression - generate to output a suppression xml to
> use to suppress all violations from user's config. Instead of printing every
> violation, all violations will be catched and single suppressions xml file
> will be printed out. Used only with -c option. Output location can be
> specified with -o option.}}
> This should also be exposed in the maven checkstyle plugin.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (MCHECKSTYLE-382) Add option to generate suppression xml file
Apoorv Gupta created MCHECKSTYLE-382: Summary: Add option to generate suppression xml file Key: MCHECKSTYLE-382 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-382 Project: Maven Checkstyle Plugin Issue Type: New Feature Reporter: Apoorv Gupta The checkstyle CLI has an option to generate a suppressions file -g,--generate-xpath-suppression - generate to output a suppression xml to use to suppress all violations from user's config. Instead of printing every violation, all violations will be catched and single suppressions xml file will be printed out. Used only with -c option. Output location can be specified with -o option. This should also be exposed in the maven checkstyle plugin. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-dependency-plugin] khmarbaise commented on issue #22: [MDEP-626] Upgrade maven-reporting-impl
khmarbaise commented on issue #22: [MDEP-626] Upgrade maven-reporting-impl URL: https://github.com/apache/maven-dependency-plugin/pull/22#issuecomment-541891969 Unfortunately there is an integration test which has failedI think there is something to do ;-) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-dependency-plugin] khmarbaise commented on issue #22: [MDEP-626] Upgrade maven-reporting-impl
khmarbaise commented on issue #22: [MDEP-626] Upgrade maven-reporting-impl URL: https://github.com/apache/maven-dependency-plugin/pull/22#issuecomment-541878734 I don't expect any issue but lets see what CI says https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven-dependency-plugin/job/mthmulders-MDEP-626-mthmulders/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MPOM-223) Introduce parent for extensions
[ https://issues.apache.org/jira/browse/MPOM-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951130#comment-16951130 ] Hudson commented on MPOM-223: - Build failed in Jenkins: Maven TLP » maven-parent » master #17 See https://builds.apache.org/job/maven-box/job/maven-parent/job/master/17/ > Introduce parent for extensions > --- > > Key: MPOM-223 > URL: https://issues.apache.org/jira/browse/MPOM-223 > Project: Maven POMs > Issue Type: New Feature >Reporter: Robert Scholte >Assignee: Robert Scholte >Priority: Major > Fix For: MAVEN-34 > > > Extensions are like plugins, but with a different purpose. So beside plugins > it makes sense to also maintain extensions, which deserve their own parent. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SUREFIRE-1584) Rerun Failing Tests with JUnit 5
[
https://issues.apache.org/jira/browse/SUREFIRE-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951052#comment-16951052
]
Abraham commented on SUREFIRE-1584:
---
Hi, is this meant to be available for failsafe as well as part of 3.0.0-M4? I
have tried to use {{-Dfailsafe.rerunFailingTestsCount}} as indicated
[here|https://maven.apache.org/surefire/maven-failsafe-plugin/examples/rerun-failing-tests.html],
but no luck.
> Rerun Failing Tests with JUnit 5
>
>
> Key: SUREFIRE-1584
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1584
> Project: Maven Surefire
> Issue Type: New Feature
> Components: JUnit 5.x support, Maven Surefire Report Plugin
>Affects Versions: 2.22.0
>Reporter: Tic Tac
>Assignee: Tibor Digana
>Priority: Major
> Labels: junit5
> Fix For: 3.0.0-M4
>
> Attachments: FlakyReruns.png
>
>
> The very useful feature for integration tests ¨[Rerun Failing
> Tests|https://maven.apache.org/surefire/maven-surefire-plugin/examples/rerun-failing-tests.html]¨
> is currently only supported for the very outdated JUnit 4.
> The documentation says: ¨This feature is supported only for JUnit 4.x.¨
> Can you please support this feature for JUnit 5.3 or later?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
