[jira] [Commented] (MNG-6800) 在执行 writePlugin 时 发生 ClassCastException

2019-11-07 Thread glmapper (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969743#comment-16969743
 ] 

glmapper commented on MNG-6800:
---

h2. Background:

Write an ide plugin for maven project structure conversion
h2. Issue

I encountered a ClassCastException when I tried to use the API provided by 
maven-model to add a plugin element in pom

 

details:

 
{code:java}
//代码占位符
Plugin plugin = new Plugin();
plugin.setGroupId("com.alipay.sofa");
plugin.setArtifactId("sofa-ark-maven-plugin");
plugin.setVersion("1.1.0-SNAPSHOT");
//1
final Xpp3Dom config = createPluginConfiguration();
plugin.setConfiguration(config);

model.getBuild().getPlugins().add(plugin);
FileWriter fileWriter = new FileWriter(pomPath);
//2
writer.write(fileWriter,model);
{code}
1.here, config object is loaded by PluginClassLoader(idea provided)

 

2.org.apache.maven.model.io.xpp3.MavenXpp3Writer#writePlugin:1417 version is 
3.3.9, 

 
{code:java}
//代码占位符
if ( plugin.getConfiguration() != null )
{
// 3
((Xpp3Dom) plugin.getConfiguration()).writeToSerializer( NAMESPACE, 
serializer );
}
{code}
 

3. Xpp3Dom is loaded by URLClassLoader, so there will be throw 
ClassCastException

 

In the ConfigurationContainer class, the configuration property type is Object, 
But in actual processing, it will be converted to Xpp3Dom, why not directly use 
Xpp3Dom as the type description of configuration

 

 

 

> 在执行 writePlugin 时 发生 ClassCastException 
> 
>
> Key: MNG-6800
> URL: https://issues.apache.org/jira/browse/MNG-6800
> Project: Maven
>  Issue Type: Improvement
>  Components: Artifacts and Repositories
>Affects Versions: 3.3.9
>Reporter: glmapper
>Priority: Blocker
> Fix For: waiting-for-feedback
>
>
> {code:java}
> //代码占位符
> java.lang.ClassCastException: org.codehaus.plexus.util.xml.Xpp3Dom cannot be 
> cast to org.codehaus.plexus.util.xml.Xpp3Domjava.lang.ClassCastException: 
> org.codehaus.plexus.util.xml.Xpp3Dom cannot be cast to 
> org.codehaus.plexus.util.xml.Xpp3Dom at 
> org.apache.maven.model.io.xpp3.MavenXpp3Writer.writePlugin(MavenXpp3Writer.java:1417)
>  at 
> org.apache.maven.model.io.xpp3.MavenXpp3Writer.writeBuild(MavenXpp3Writer.java:329)
>  at 
> org.apache.maven.model.io.xpp3.MavenXpp3Writer.writeModel(MavenXpp3Writer.java:1115)
>  at 
> org.apache.maven.model.io.xpp3.MavenXpp3Writer.write(MavenXpp3Writer.java:100)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (MNG-6800) 在执行 writePlugin 时 发生 ClassCastException

2019-11-07 Thread glmapper (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969743#comment-16969743
 ] 

glmapper edited comment on MNG-6800 at 11/8/19 2:01 AM:


h2. Background:

Write an idea plugin for maven project structure conversion
h2. Issue

I encountered a ClassCastException when I tried to use the API provided by 
maven-model to add a plugin element in pom

 

details:

 
{code:java}
//代码占位符
Plugin plugin = new Plugin();
plugin.setGroupId("com.alipay.sofa");
plugin.setArtifactId("sofa-ark-maven-plugin");
plugin.setVersion("1.1.0-SNAPSHOT");
//1
final Xpp3Dom config = createPluginConfiguration();
plugin.setConfiguration(config);

model.getBuild().getPlugins().add(plugin);
FileWriter fileWriter = new FileWriter(pomPath);
//2
writer.write(fileWriter,model);
{code}
1.here, config object is loaded by PluginClassLoader(idea provided)

 

2.org.apache.maven.model.io.xpp3.MavenXpp3Writer#writePlugin:1417 version is 
3.3.9, 

 
{code:java}
//代码占位符
if ( plugin.getConfiguration() != null )
{
// 3
((Xpp3Dom) plugin.getConfiguration()).writeToSerializer( NAMESPACE, 
serializer );
}
{code}
 

3. Xpp3Dom is loaded by URLClassLoader, so there will be throw 
ClassCastException

 

In the ConfigurationContainer class, the configuration property type is Object, 
But in actual processing, it will be converted to Xpp3Dom, why not directly use 
Xpp3Dom as the type description of the configuration

 

 

 


was (Author: glmapper):
h2. Background:

Write an ide plugin for maven project structure conversion
h2. Issue

I encountered a ClassCastException when I tried to use the API provided by 
maven-model to add a plugin element in pom

 

details:

 
{code:java}
//代码占位符
Plugin plugin = new Plugin();
plugin.setGroupId("com.alipay.sofa");
plugin.setArtifactId("sofa-ark-maven-plugin");
plugin.setVersion("1.1.0-SNAPSHOT");
//1
final Xpp3Dom config = createPluginConfiguration();
plugin.setConfiguration(config);

model.getBuild().getPlugins().add(plugin);
FileWriter fileWriter = new FileWriter(pomPath);
//2
writer.write(fileWriter,model);
{code}
1.here, config object is loaded by PluginClassLoader(idea provided)

 

2.org.apache.maven.model.io.xpp3.MavenXpp3Writer#writePlugin:1417 version is 
3.3.9, 

 
{code:java}
//代码占位符
if ( plugin.getConfiguration() != null )
{
// 3
((Xpp3Dom) plugin.getConfiguration()).writeToSerializer( NAMESPACE, 
serializer );
}
{code}
 

3. Xpp3Dom is loaded by URLClassLoader, so there will be throw 
ClassCastException

 

In the ConfigurationContainer class, the configuration property type is Object, 
But in actual processing, it will be converted to Xpp3Dom, why not directly use 
Xpp3Dom as the type description of configuration

 

 

 

> 在执行 writePlugin 时 发生 ClassCastException 
> 
>
> Key: MNG-6800
> URL: https://issues.apache.org/jira/browse/MNG-6800
> Project: Maven
>  Issue Type: Improvement
>  Components: Artifacts and Repositories
>Affects Versions: 3.3.9
>Reporter: glmapper
>Priority: Blocker
> Fix For: waiting-for-feedback
>
>
> {code:java}
> //代码占位符
> java.lang.ClassCastException: org.codehaus.plexus.util.xml.Xpp3Dom cannot be 
> cast to org.codehaus.plexus.util.xml.Xpp3Domjava.lang.ClassCastException: 
> org.codehaus.plexus.util.xml.Xpp3Dom cannot be cast to 
> org.codehaus.plexus.util.xml.Xpp3Dom at 
> org.apache.maven.model.io.xpp3.MavenXpp3Writer.writePlugin(MavenXpp3Writer.java:1417)
>  at 
> org.apache.maven.model.io.xpp3.MavenXpp3Writer.writeBuild(MavenXpp3Writer.java:329)
>  at 
> org.apache.maven.model.io.xpp3.MavenXpp3Writer.writeModel(MavenXpp3Writer.java:1115)
>  at 
> org.apache.maven.model.io.xpp3.MavenXpp3Writer.write(MavenXpp3Writer.java:100)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (MNG-6800) 在执行 writePlugin 时 发生 ClassCastException

2019-11-07 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-6800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-6800:

Fix Version/s: waiting-for-feedback

> 在执行 writePlugin 时 发生 ClassCastException 
> 
>
> Key: MNG-6800
> URL: https://issues.apache.org/jira/browse/MNG-6800
> Project: Maven
>  Issue Type: Improvement
>  Components: Artifacts and Repositories
>Affects Versions: 3.3.9
>Reporter: glmapper
>Priority: Blocker
> Fix For: waiting-for-feedback
>
>
> {code:java}
> //代码占位符
> java.lang.ClassCastException: org.codehaus.plexus.util.xml.Xpp3Dom cannot be 
> cast to org.codehaus.plexus.util.xml.Xpp3Domjava.lang.ClassCastException: 
> org.codehaus.plexus.util.xml.Xpp3Dom cannot be cast to 
> org.codehaus.plexus.util.xml.Xpp3Dom at 
> org.apache.maven.model.io.xpp3.MavenXpp3Writer.writePlugin(MavenXpp3Writer.java:1417)
>  at 
> org.apache.maven.model.io.xpp3.MavenXpp3Writer.writeBuild(MavenXpp3Writer.java:329)
>  at 
> org.apache.maven.model.io.xpp3.MavenXpp3Writer.writeModel(MavenXpp3Writer.java:1115)
>  at 
> org.apache.maven.model.io.xpp3.MavenXpp3Writer.write(MavenXpp3Writer.java:100)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [maven-surefire] Col-E commented on issue #252: [SUREFIRE-1711] Support @ParameterizedTest for JUnit 5 test reruns

2019-11-07 Thread GitBox
Col-E commented on issue #252: [SUREFIRE-1711] Support @ParameterizedTest for 
JUnit 5 test reruns
URL: https://github.com/apache/maven-surefire/pull/252#issuecomment-551276389
 
 
   Yeah, I've just been a bit busy recently with coursework. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (WAGON-567) Provide request retry strategy on transient client and server side errors

2019-11-07 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/WAGON-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969527#comment-16969527
 ] 

Michael Osipov commented on WAGON-567:
--

[~hboutemy], looking into your question: no default behavior change has been 
applied. If you don't specifiy 
{{maven.wagon.http.serviceUnavailableRetryStrategy.class != none}}, nothing 
will change.

I agree that the names are a bit irritating, but the refer to 
{{DefaultServiceUnavailableRetryStrategy}} and 
{{StandardServiceUnavailableRetryStrategy}} provided by the {{HttpClient}}, no 
custom implementations. This will be merged with the retry handler as soon as 
HTTPCLIENT-2019 is solved in 5.0 and we switch to 5.0.

> Provide request retry strategy on transient client and server side errors
> -
>
> Key: WAGON-567
> URL: https://issues.apache.org/jira/browse/WAGON-567
> Project: Maven Wagon
>  Issue Type: New Feature
>  Components: wagon-http
>Reporter: xueqian zhang
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.3.4
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently wagon has a retry mechanism when there are connections issues with 
> repository manager like maven central, artifactory or nexus, see [wagon 
> source|https://github.com/apache/maven-wagon/blob/dfd22586b6b934aa5a652ca32d57ed26067432fd/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java#L393]
>  and [httpclient 
> source|https://github.com/apache/httpcomponents-client/blob/4.5.x/httpclient/src/main/java/org/apache/http/impl/execchain/RetryExec.java#L90],
>  [httpclient default retry 
> handler|https://github.com/apache/httpcomponents-client/blob/4.5.x/httpclient/src/main/java/org/apache/http/impl/client/DefaultHttpRequestRetryHandler.java#L154].
>  However,  it only captures low level connection issues. When the repo 
> returns errors like 500 or 503, it does not retry. The 5xx response from the 
> repo might be a blip and maven should retry before giving up.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [maven-surefire] Tibor17 commented on issue #252: [SUREFIRE-1711] Support @ParameterizedTest for JUnit 5 test reruns

2019-11-07 Thread GitBox
Tibor17 commented on issue #252: [SUREFIRE-1711] Support @ParameterizedTest for 
JUnit 5 test reruns
URL: https://github.com/apache/maven-surefire/pull/252#issuecomment-551237886
 
 
   @Col-E 
   Can we continue on making the test unique?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] cwansart edited a comment on issue #299: [MNG-6778] - Use https for maven schemaLocations

2019-11-07 Thread GitBox
cwansart edited a comment on issue #299: [MNG-6778] - Use https for maven 
schemaLocations
URL: https://github.com/apache/maven/pull/299#issuecomment-551128571
 
 
   ~~Still need to run core-its.~~ done


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MNG-6800) 在执行 writePlugin 时 发生 ClassCastException

2019-11-07 Thread Herve Boutemy (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969353#comment-16969353
 ] 

Herve Boutemy commented on MNG-6800:


what issue are you facing? What do you do to get such unusual result?

> 在执行 writePlugin 时 发生 ClassCastException 
> 
>
> Key: MNG-6800
> URL: https://issues.apache.org/jira/browse/MNG-6800
> Project: Maven
>  Issue Type: Improvement
>  Components: Artifacts and Repositories
>Affects Versions: 3.3.9
>Reporter: glmapper
>Priority: Blocker
>
> {code:java}
> //代码占位符
> java.lang.ClassCastException: org.codehaus.plexus.util.xml.Xpp3Dom cannot be 
> cast to org.codehaus.plexus.util.xml.Xpp3Domjava.lang.ClassCastException: 
> org.codehaus.plexus.util.xml.Xpp3Dom cannot be cast to 
> org.codehaus.plexus.util.xml.Xpp3Dom at 
> org.apache.maven.model.io.xpp3.MavenXpp3Writer.writePlugin(MavenXpp3Writer.java:1417)
>  at 
> org.apache.maven.model.io.xpp3.MavenXpp3Writer.writeBuild(MavenXpp3Writer.java:329)
>  at 
> org.apache.maven.model.io.xpp3.MavenXpp3Writer.writeModel(MavenXpp3Writer.java:1115)
>  at 
> org.apache.maven.model.io.xpp3.MavenXpp3Writer.write(MavenXpp3Writer.java:100)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (WAGON-567) Provide request retry strategy on transient client and server side errors

2019-11-07 Thread Herve Boutemy (Jira)


[ 
https://issues.apache.org/jira/browse/WAGON-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969350#comment-16969350
 ] 

Herve Boutemy commented on WAGON-567:
-

ok, thanks

> Provide request retry strategy on transient client and server side errors
> -
>
> Key: WAGON-567
> URL: https://issues.apache.org/jira/browse/WAGON-567
> Project: Maven Wagon
>  Issue Type: New Feature
>  Components: wagon-http
>Reporter: xueqian zhang
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.3.4
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently wagon has a retry mechanism when there are connections issues with 
> repository manager like maven central, artifactory or nexus, see [wagon 
> source|https://github.com/apache/maven-wagon/blob/dfd22586b6b934aa5a652ca32d57ed26067432fd/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java#L393]
>  and [httpclient 
> source|https://github.com/apache/httpcomponents-client/blob/4.5.x/httpclient/src/main/java/org/apache/http/impl/execchain/RetryExec.java#L90],
>  [httpclient default retry 
> handler|https://github.com/apache/httpcomponents-client/blob/4.5.x/httpclient/src/main/java/org/apache/http/impl/client/DefaultHttpRequestRetryHandler.java#L154].
>  However,  it only captures low level connection issues. When the repo 
> returns errors like 500 or 503, it does not retry. The 5xx response from the 
> repo might be a blip and maven should retry before giving up.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [maven] cwansart commented on issue #299: [MNG-6778] - Use https for maven schemaLocations

2019-11-07 Thread GitBox
cwansart commented on issue #299: [MNG-6778] - Use https for maven 
schemaLocations
URL: https://github.com/apache/maven/pull/299#issuecomment-551128571
 
 
   Still need to run core-its.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MNG-6778) Use https for schemaLocations

2019-11-07 Thread Christian Wansart (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969348#comment-16969348
 ] 

Christian Wansart commented on MNG-6778:


Please have a look at https://github.com/apache/maven/pull/299
I did not change the other xsds. If you want, I can change them as well.

> Use https for schemaLocations
> -
>
> Key: MNG-6778
> URL: https://issues.apache.org/jira/browse/MNG-6778
> Project: Maven
>  Issue Type: Improvement
>Reporter: Robert Scholte
>Priority: Major
>  Labels: up-for-grabs
> Fix For: 3.7.0-candidate
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> All poms start with the following roottag:
> {code:xml}
> http://maven.apache.org/POM/4.0.0; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd;>
> {code}
> The schemaLocation VALUE should be updated to 
> {{https://maven.apache.org/xsd/maven-4.0.0.xsd}}; the key is just a constant 
> String, even though it looks like a URL, better to keep this the same.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [maven] cwansart opened a new pull request #299: [MNG-6778] - Use https for maven schemaLocations

2019-11-07 Thread GitBox
cwansart opened a new pull request #299: [MNG-6778] - Use https for maven 
schemaLocations
URL: https://github.com/apache/maven/pull/299
 
 
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MNG) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[MNG-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MNG-XXX` with the appropriate JIRA issue. Best 
practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   
   
   
   This pull request changes the maven xsd urls from http to https according to 
https://issues.apache.org/jira/browse/MNG-6778. It *does not* change the urls 
for other xsds `core-extension`, `settings`, `profiles`, `paramdoc`, 
`lifecycle`, `profiles`, `metadata` and `toolchains`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (WAGON-567) Provide request retry strategy on transient client and server side errors

2019-11-07 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/WAGON-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969308#comment-16969308
 ] 

Michael Osipov commented on WAGON-567:
--

[~hboutemy], I will go on detail on this later this day as soon as I have 
access to my dev machine. But right away, as {{none}} is the default impl no 
retried are retried. Though, we have a retry handler in place for transport 
errors. See also HTTPCLIENT-2019. I plan to rework this in HttpClient and have 
constent handling.

> Provide request retry strategy on transient client and server side errors
> -
>
> Key: WAGON-567
> URL: https://issues.apache.org/jira/browse/WAGON-567
> Project: Maven Wagon
>  Issue Type: New Feature
>  Components: wagon-http
>Reporter: xueqian zhang
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.3.4
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently wagon has a retry mechanism when there are connections issues with 
> repository manager like maven central, artifactory or nexus, see [wagon 
> source|https://github.com/apache/maven-wagon/blob/dfd22586b6b934aa5a652ca32d57ed26067432fd/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java#L393]
>  and [httpclient 
> source|https://github.com/apache/httpcomponents-client/blob/4.5.x/httpclient/src/main/java/org/apache/http/impl/execchain/RetryExec.java#L90],
>  [httpclient default retry 
> handler|https://github.com/apache/httpcomponents-client/blob/4.5.x/httpclient/src/main/java/org/apache/http/impl/client/DefaultHttpRequestRetryHandler.java#L154].
>  However,  it only captures low level connection issues. When the repo 
> returns errors like 500 or 503, it does not retry. The 5xx response from the 
> repo might be a blip and maven should retry before giving up.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MNG-6800) 在执行 writePlugin 时 发生 ClassCastException

2019-11-07 Thread glmapper (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969250#comment-16969250
 ] 

glmapper commented on MNG-6800:
---

在 ConfigurationContainer 类中, configuration 属性类型是 Object,在 执行 writePlugin 时 
,会强制转换成 

org.codehaus.plexus.util.xml.Xpp3Dom 类型。既然已知是 
org.codehaus.plexus.util.xml.Xpp3Dom ,为什么还定义其类型为 Object 呢?

> 在执行 writePlugin 时 发生 ClassCastException 
> 
>
> Key: MNG-6800
> URL: https://issues.apache.org/jira/browse/MNG-6800
> Project: Maven
>  Issue Type: Improvement
>  Components: Artifacts and Repositories
>Affects Versions: 3.3.9
>Reporter: glmapper
>Priority: Blocker
>
> {code:java}
> //代码占位符
> java.lang.ClassCastException: org.codehaus.plexus.util.xml.Xpp3Dom cannot be 
> cast to org.codehaus.plexus.util.xml.Xpp3Domjava.lang.ClassCastException: 
> org.codehaus.plexus.util.xml.Xpp3Dom cannot be cast to 
> org.codehaus.plexus.util.xml.Xpp3Dom at 
> org.apache.maven.model.io.xpp3.MavenXpp3Writer.writePlugin(MavenXpp3Writer.java:1417)
>  at 
> org.apache.maven.model.io.xpp3.MavenXpp3Writer.writeBuild(MavenXpp3Writer.java:329)
>  at 
> org.apache.maven.model.io.xpp3.MavenXpp3Writer.writeModel(MavenXpp3Writer.java:1115)
>  at 
> org.apache.maven.model.io.xpp3.MavenXpp3Writer.write(MavenXpp3Writer.java:100)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (MNG-6800) 在执行 writePlugin 时 发生 ClassCastException

2019-11-07 Thread glmapper (Jira)
glmapper created MNG-6800:
-

 Summary: 在执行 writePlugin 时 发生 ClassCastException 
 Key: MNG-6800
 URL: https://issues.apache.org/jira/browse/MNG-6800
 Project: Maven
  Issue Type: Improvement
  Components: Artifacts and Repositories
Affects Versions: 3.3.9
Reporter: glmapper


{code:java}
//代码占位符
java.lang.ClassCastException: org.codehaus.plexus.util.xml.Xpp3Dom cannot be 
cast to org.codehaus.plexus.util.xml.Xpp3Domjava.lang.ClassCastException: 
org.codehaus.plexus.util.xml.Xpp3Dom cannot be cast to 
org.codehaus.plexus.util.xml.Xpp3Dom at 
org.apache.maven.model.io.xpp3.MavenXpp3Writer.writePlugin(MavenXpp3Writer.java:1417)
 at 
org.apache.maven.model.io.xpp3.MavenXpp3Writer.writeBuild(MavenXpp3Writer.java:329)
 at 
org.apache.maven.model.io.xpp3.MavenXpp3Writer.writeModel(MavenXpp3Writer.java:1115)
 at 
org.apache.maven.model.io.xpp3.MavenXpp3Writer.write(MavenXpp3Writer.java:100)
{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (WAGON-567) Provide request retry strategy on transient client and server side errors

2019-11-07 Thread Herve Boutemy (Jira)


[ 
https://issues.apache.org/jira/browse/WAGON-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969245#comment-16969245
 ] 

Herve Boutemy commented on WAGON-567:
-

[~michael-o] just had a look at this commit
Can you confirm that by default (= no configuration anywhere, like in Maven 
core by default), no new retry will be added vs the previous behaviour?
then IIUC, additionnal behaviour (for those who know...) can be configured via 
system properties (names can be found in code)

I'm confused:
1. between "none" vs "default" vs "standard" names of the predefined strategies
2. and the default choice that looks to be "none"

> Provide request retry strategy on transient client and server side errors
> -
>
> Key: WAGON-567
> URL: https://issues.apache.org/jira/browse/WAGON-567
> Project: Maven Wagon
>  Issue Type: New Feature
>  Components: wagon-http
>Reporter: xueqian zhang
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.3.4
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently wagon has a retry mechanism when there are connections issues with 
> repository manager like maven central, artifactory or nexus, see [wagon 
> source|https://github.com/apache/maven-wagon/blob/dfd22586b6b934aa5a652ca32d57ed26067432fd/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java#L393]
>  and [httpclient 
> source|https://github.com/apache/httpcomponents-client/blob/4.5.x/httpclient/src/main/java/org/apache/http/impl/execchain/RetryExec.java#L90],
>  [httpclient default retry 
> handler|https://github.com/apache/httpcomponents-client/blob/4.5.x/httpclient/src/main/java/org/apache/http/impl/client/DefaultHttpRequestRetryHandler.java#L154].
>  However,  it only captures low level connection issues. When the repo 
> returns errors like 500 or 503, it does not retry. The 5xx response from the 
> repo might be a blip and maven should retry before giving up.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MNG-6799) avoid model interpolation instability risk: ensure StringVisitorModelInterpolator replaces StringSearchModelInterpolator

2019-11-07 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969237#comment-16969237
 ] 

Hudson commented on MNG-6799:
-

Build succeeded in Jenkins: Maven TLP » maven » master #300

See https://builds.apache.org/job/maven-box/job/maven/job/master/300/

> avoid model interpolation instability risk: ensure 
> StringVisitorModelInterpolator replaces StringSearchModelInterpolator
> 
>
> Key: MNG-6799
> URL: https://issues.apache.org/jira/browse/MNG-6799
> Project: Maven
>  Issue Type: Improvement
>  Components: Inheritance and Interpolation
>Affects Versions: 3.6.2
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.6.3
>
>
> as discovered recently and [shared on dev 
> ML|https://lists.apache.org/thread.html/efab59150580f27de386386730e3816188ea2d27faa5fa4c96934149@%3Cdev.maven.apache.org%3E],
>  in maven-model-builder, 
> [StringVisitorModelInterpolator|http://maven.apache.org/ref/3.6.2/maven-model-builder/apidocs/org/apache/maven/model/interpolation/StringVisitorModelInterpolator.html]
>  introduced by MNG-6697 in Maven 3.6.2 is meant to replace 
> [StringSearchModelInterpolator|http://maven.apache.org/ref/3.6.2/maven-model-builder/apidocs/org/apache/maven/model/interpolation/StringSearchModelInterpolator.html]
> but currently, both can be injected and the selection of one against the 
> other depends on the order of generated CDI descriptors: if you're lucky, 
> StringVisitorModelInterpolator appear first, but if you're not, 
> StringSearchModelInterpolator will do instead.
> In addition, with Reproducible Builds being introduced in MNG-6789, the order 
> that is introduced is String lexical order: StringSearchModelInterpolator is 
> then before StringVisitorModelInterpolator then with Reproducible Builds we 
> get the unwanted result in a reproducible way...
> we need to ensure that StringVisitorModelInterpolator will be used instead of 
> StringSearchModelInterpolator



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MNG-6789) Make Maven distribution build Reproducible

2019-11-07 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969238#comment-16969238
 ] 

Hudson commented on MNG-6789:
-

Build succeeded in Jenkins: Maven TLP » maven » master #300

See https://builds.apache.org/job/maven-box/job/maven/job/master/300/

> Make Maven distribution build Reproducible
> --
>
> Key: MNG-6789
> URL: https://issues.apache.org/jira/browse/MNG-6789
> Project: Maven
>  Issue Type: Task
>  Components: Bootstrap  Build
>Affects Versions: 3.6.2
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.6.3
>
>
> with [Maven native Reproducible 
> Builds|https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=74682318]
>  near available, it would be great to have Maven itself being the first Maven 
> project that gets Reproducible Builds
> there is already a proof of concept available in reproducible branch: 
> https://github.com/apache/maven/tree/reproducible with corresponding Jenkins 
> build 
> https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/reproducible/
> once maven-jar-plugin, maven-assembly-plugin and maven-source-plugin have a 
> reproducible release available, the last 2 plugins that bring non 
> reproducible result in this build are plexus-component-metadata 2.0.0 and 
> sisu-maven-plugin



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (MNG-6789) Make Maven distribution build Reproducible

2019-11-07 Thread Herve Boutemy (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-6789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Herve Boutemy closed MNG-6789.
--
Resolution: Fixed

fixed in 
[bd10f00b68eb766cd239275e8504acedc2818d69|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=bd10f00b68eb766cd239275e8504acedc2818d69]

> Make Maven distribution build Reproducible
> --
>
> Key: MNG-6789
> URL: https://issues.apache.org/jira/browse/MNG-6789
> Project: Maven
>  Issue Type: Task
>  Components: Bootstrap  Build
>Affects Versions: 3.6.2
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.6.3
>
>
> with [Maven native Reproducible 
> Builds|https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=74682318]
>  near available, it would be great to have Maven itself being the first Maven 
> project that gets Reproducible Builds
> there is already a proof of concept available in reproducible branch: 
> https://github.com/apache/maven/tree/reproducible with corresponding Jenkins 
> build 
> https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/reproducible/
> once maven-jar-plugin, maven-assembly-plugin and maven-source-plugin have a 
> reproducible release available, the last 2 plugins that bring non 
> reproducible result in this build are plexus-component-metadata 2.0.0 and 
> sisu-maven-plugin



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (MNG-6799) avoid model interpolation instability risk: ensure StringVisitorModelInterpolator replaces StringSearchModelInterpolator

2019-11-07 Thread Herve Boutemy (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-6799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Herve Boutemy closed MNG-6799.
--
  Assignee: Herve Boutemy
Resolution: Fixed

fixed in 
[3a80ae08aac785deb61e417f82560cb06209d5bc|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=3a80ae08aac785deb61e417f82560cb06209d5bc]

> avoid model interpolation instability risk: ensure 
> StringVisitorModelInterpolator replaces StringSearchModelInterpolator
> 
>
> Key: MNG-6799
> URL: https://issues.apache.org/jira/browse/MNG-6799
> Project: Maven
>  Issue Type: Improvement
>  Components: Inheritance and Interpolation
>Affects Versions: 3.6.2
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.6.3
>
>
> as discovered recently and [shared on dev 
> ML|https://lists.apache.org/thread.html/efab59150580f27de386386730e3816188ea2d27faa5fa4c96934149@%3Cdev.maven.apache.org%3E],
>  in maven-model-builder, 
> [StringVisitorModelInterpolator|http://maven.apache.org/ref/3.6.2/maven-model-builder/apidocs/org/apache/maven/model/interpolation/StringVisitorModelInterpolator.html]
>  introduced by MNG-6697 in Maven 3.6.2 is meant to replace 
> [StringSearchModelInterpolator|http://maven.apache.org/ref/3.6.2/maven-model-builder/apidocs/org/apache/maven/model/interpolation/StringSearchModelInterpolator.html]
> but currently, both can be injected and the selection of one against the 
> other depends on the order of generated CDI descriptors: if you're lucky, 
> StringVisitorModelInterpolator appear first, but if you're not, 
> StringSearchModelInterpolator will do instead.
> In addition, with Reproducible Builds being introduced in MNG-6789, the order 
> that is introduced is String lexical order: StringSearchModelInterpolator is 
> then before StringVisitorModelInterpolator then with Reproducible Builds we 
> get the unwanted result in a reproducible way...
> we need to ensure that StringVisitorModelInterpolator will be used instead of 
> StringSearchModelInterpolator



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (MCOMPILER-403) Spring Lombok -Werror [ERROR] An unknown compilation problem occurred

2019-11-07 Thread Igor Rybak (Jira)
Igor Rybak created MCOMPILER-403:


 Summary: Spring Lombok -Werror [ERROR] An unknown compilation 
problem occurred
 Key: MCOMPILER-403
 URL: https://issues.apache.org/jira/browse/MCOMPILER-403
 Project: Maven Compiler Plugin
  Issue Type: Bug
Affects Versions: 3.8.1
 Environment: Windows 10 Apache Maven 3.6.1, Java 1.8.0_231 or 11.0.4
Reporter: Igor Rybak
 Attachments: spring-lombok-werror-bug-demo.zip

Compilation fails with -Werror and Lombok in Spring Boot project with the 
message "An unknown compilation problem occurred"

Steps to reproduce:

1. Open the sample project spring-lombok-werror-bug-demo.zip
2. run {{mvn clean package}} in the root of the project (Apache Maven 3.6.1, 
Java 1.8.0_231 or 11.0.4)

Here is the same issue on Lombok GitHub repository:
[https://github.com/rzwitserloot/lombok/issues/2285]


{code:java}
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time: 5.698 s
[INFO] Finished at: 2019-11-07T14:48:32+02:00
[INFO] 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) 
on project spring-lombok-demo: Compilation failure -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) 
on project spring-lombok-demo: Compilation failure
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:215)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:156)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:148)
 at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
 at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:81)
 at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
 (SingleThreadedBuilder.java:56)
 at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
(LifecycleStarter.java:128)
 at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
 at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
 at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
 at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
 at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
 at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
 at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
 at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
 at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
 at java.lang.reflect.Method.invoke (Method.java:498)
 at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:282)
 at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
 at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
(Launcher.java:406)
 at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
Caused by: org.apache.maven.plugin.compiler.CompilationFailureException: 
Compilation failure
 at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute 
(AbstractCompilerMojo.java:1224)
 at org.apache.maven.plugin.compiler.CompilerMojo.execute 
(CompilerMojo.java:187)
 at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:137)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:210)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:156)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:148)
 at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
 at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:81)
 at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
 (SingleThreadedBuilder.java:56)
 at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
(LifecycleStarter.java:128)
 at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
 at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
 at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
 at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
 at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
 at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
 at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
 at sun.reflect.NativeMethodAccessorImpl.invoke 

[jira] [Commented] (MNG-6789) Make Maven distribution build Reproducible

2019-11-07 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969220#comment-16969220
 ] 

Hudson commented on MNG-6789:
-

Build succeeded in Jenkins: Maven TLP » maven » reproducible #56

See https://builds.apache.org/job/maven-box/job/maven/job/reproducible/56/

> Make Maven distribution build Reproducible
> --
>
> Key: MNG-6789
> URL: https://issues.apache.org/jira/browse/MNG-6789
> Project: Maven
>  Issue Type: Task
>  Components: Bootstrap  Build
>Affects Versions: 3.6.2
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.6.3
>
>
> with [Maven native Reproducible 
> Builds|https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=74682318]
>  near available, it would be great to have Maven itself being the first Maven 
> project that gets Reproducible Builds
> there is already a proof of concept available in reproducible branch: 
> https://github.com/apache/maven/tree/reproducible with corresponding Jenkins 
> build 
> https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/reproducible/
> once maven-jar-plugin, maven-assembly-plugin and maven-source-plugin have a 
> reproducible release available, the last 2 plugins that bring non 
> reproducible result in this build are plexus-component-metadata 2.0.0 and 
> sisu-maven-plugin



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MNG-6799) avoid model interpolation instability risk: ensure StringVisitorModelInterpolator replaces StringSearchModelInterpolator

2019-11-07 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969219#comment-16969219
 ] 

Hudson commented on MNG-6799:
-

Build succeeded in Jenkins: Maven TLP » maven » reproducible #56

See https://builds.apache.org/job/maven-box/job/maven/job/reproducible/56/

> avoid model interpolation instability risk: ensure 
> StringVisitorModelInterpolator replaces StringSearchModelInterpolator
> 
>
> Key: MNG-6799
> URL: https://issues.apache.org/jira/browse/MNG-6799
> Project: Maven
>  Issue Type: Improvement
>  Components: Inheritance and Interpolation
>Affects Versions: 3.6.2
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.6.3
>
>
> as discovered recently and [shared on dev 
> ML|https://lists.apache.org/thread.html/efab59150580f27de386386730e3816188ea2d27faa5fa4c96934149@%3Cdev.maven.apache.org%3E],
>  in maven-model-builder, 
> [StringVisitorModelInterpolator|http://maven.apache.org/ref/3.6.2/maven-model-builder/apidocs/org/apache/maven/model/interpolation/StringVisitorModelInterpolator.html]
>  introduced by MNG-6697 in Maven 3.6.2 is meant to replace 
> [StringSearchModelInterpolator|http://maven.apache.org/ref/3.6.2/maven-model-builder/apidocs/org/apache/maven/model/interpolation/StringSearchModelInterpolator.html]
> but currently, both can be injected and the selection of one against the 
> other depends on the order of generated CDI descriptors: if you're lucky, 
> StringVisitorModelInterpolator appear first, but if you're not, 
> StringSearchModelInterpolator will do instead.
> In addition, with Reproducible Builds being introduced in MNG-6789, the order 
> that is introduced is String lexical order: StringSearchModelInterpolator is 
> then before StringVisitorModelInterpolator then with Reproducible Builds we 
> get the unwanted result in a reproducible way...
> we need to ensure that StringVisitorModelInterpolator will be used instead of 
> StringSearchModelInterpolator



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [maven-archetype] ptahchiev commented on issue #32: ARCHETYPE-548 Filter files with no extension.

2019-11-07 Thread GitBox
ptahchiev commented on issue #32: ARCHETYPE-548 Filter files with no extension.
URL: https://github.com/apache/maven-archetype/pull/32#issuecomment-551064877
 
 
   Hey @rfscholte can you have a look at my PR? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (SUREFIRE-1712) Running tests with JDK13 fails with Unsupported class file major version 57

2019-11-07 Thread Karl Heinz Marbaise (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969171#comment-16969171
 ] 

Karl Heinz Marbaise commented on SUREFIRE-1712:
---

Could you simply check the given project(github repository). If you just do a 
{{mvn clean test}} on this project it works in the given state.
If you simply remove the dependency to org.ow2.asm  from maven-surefire-plugin 
the project fails with the given exception which is based on the usage of jdk 
13. 
And yes this application is a modular app ...and it's not related to running 
with higher version compiled than running with it... furthermore the stacktrace 
shows exactly:
{code}
Caused by: java.lang.IllegalArgumentException: Unsupported class file major 
version 57
at org.objectweb.asm.ClassReader. (ClassReader.java:184)
at org.objectweb.asm.ClassReader. (ClassReader.java:166)
at org.objectweb.asm.ClassReader. (ClassReader.java:152)
at org.objectweb.asm.ClassReader. (ClassReader.java:273)
at 
org.apache.maven.plugin.surefire.booterclient.ModularClasspathForkConfiguration.toModuleName
 (ModularClasspathForkConfiguration.java:230)
{code}
which is trying to get the module names via ASM ...and you need higher version 
of ASM is needed cause as you see in this example it simply fails.




> Running tests with JDK13 fails with Unsupported class file major version 57
> ---
>
> Key: SUREFIRE-1712
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1712
> Project: Maven Surefire
>  Issue Type: Bug
>Affects Versions: 2.22.2, 3.0.0-M2, 3.0.0-M1, 3.0.0-M3
> Environment: JDK 13+
>Reporter: Karl Heinz Marbaise
>Priority: Blocker
>
> I have a example project from [so|https://github.com/khmarbaise/so58710751] 
> the following exception occurs:
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test (default-test) 
> on project oot: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test failed: 
> Unsupported class file major version 57 -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test 
> (default-test) on project oot: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test failed: 
> Unsupported class file major version 57
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:215)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:567)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution 
> default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test failed: 
> Unsupported class file major version 57
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:148)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:210)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> 

[jira] [Comment Edited] (SUREFIRE-1712) Running tests with JDK13 fails with Unsupported class file major version 57

2019-11-07 Thread Tibor Digana (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969100#comment-16969100
 ] 

Tibor Digana edited comment on SUREFIRE-1712 at 11/7/19 9:51 AM:
-

[~khmarbaise] You could ping me on Slack. This is your private project? Because 
{{Unsupported class file major version 57}} is related to situations when some 
classes are compiled with higher version than running. I do not know what you 
do. Ask Robert, he will tell what i already asked him, that ASM here is used 
only for modular apps with JDK 8 or 7 and no higher versions of ASM are needed. 
We run the ITs with JDK 13 and JDK 14 with no problems.


was (Author: tibor17):
[~khmarbaise] You could bing me on Slack. This is your private project? Because 
{{Unsupported class file major version 57}} is related to situations when some 
classes are compiled with higher version than running. I do not know what you 
do. Ask Robert, he will tell what i already asked him, that ASM here is used 
only for modular apps with JDK 8 or 7 and no higher versions of ASM are needed. 
We run the ITs with JDK 13 and JDK 14 with no problems.

> Running tests with JDK13 fails with Unsupported class file major version 57
> ---
>
> Key: SUREFIRE-1712
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1712
> Project: Maven Surefire
>  Issue Type: Bug
>Affects Versions: 2.22.2, 3.0.0-M2, 3.0.0-M1, 3.0.0-M3
> Environment: JDK 13+
>Reporter: Karl Heinz Marbaise
>Priority: Blocker
>
> I have a example project from [so|https://github.com/khmarbaise/so58710751] 
> the following exception occurs:
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test (default-test) 
> on project oot: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test failed: 
> Unsupported class file major version 57 -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test 
> (default-test) on project oot: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test failed: 
> Unsupported class file major version 57
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:215)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:567)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution 
> default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test failed: 
> Unsupported class file major version 57
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:148)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:210)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
> at 
> 

[jira] [Comment Edited] (SUREFIRE-1712) Running tests with JDK13 fails with Unsupported class file major version 57

2019-11-07 Thread Tibor Digana (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969100#comment-16969100
 ] 

Tibor Digana edited comment on SUREFIRE-1712 at 11/7/19 9:48 AM:
-

[~khmarbaise] You could bing me on Slack. This is your private project? Because 
{{Unsupported class file major version 57}} is related to situations when some 
classes are compiled with higher version than running. I do not know what you 
do. Ask Robert, he will tell what i already asked him, that ASM here is used 
only for modular apps with JDK 8 or 7 and no higher versions of ASM are needed. 
We run the ITs with JDK 13 and JDK 14 with no problems.


was (Author: tibor17):
[~khmarbaise] PYou could bing me on Slack. This is you private project? Because 
{{Unsupported class file major version 57}} is related to when some classes are 
compiled with higher version than running. I donot know what you do. Ask 
Robert, he will tell what i already asked him, that ASM here s used only for 
modular apps with JDK 8 or 7. We run the ITs with JDK 13 and JDK 14 with no 
problems.

> Running tests with JDK13 fails with Unsupported class file major version 57
> ---
>
> Key: SUREFIRE-1712
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1712
> Project: Maven Surefire
>  Issue Type: Bug
>Affects Versions: 2.22.2, 3.0.0-M2, 3.0.0-M1, 3.0.0-M3
> Environment: JDK 13+
>Reporter: Karl Heinz Marbaise
>Priority: Blocker
>
> I have a example project from [so|https://github.com/khmarbaise/so58710751] 
> the following exception occurs:
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test (default-test) 
> on project oot: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test failed: 
> Unsupported class file major version 57 -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test 
> (default-test) on project oot: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test failed: 
> Unsupported class file major version 57
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:215)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:567)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution 
> default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test failed: 
> Unsupported class file major version 57
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:148)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:210)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> 

[jira] [Commented] (SUREFIRE-1712) Running tests with JDK13 fails with Unsupported class file major version 57

2019-11-07 Thread Tibor Digana (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969100#comment-16969100
 ] 

Tibor Digana commented on SUREFIRE-1712:


[~khmarbaise] PYou could bing me on Slack. This is you private project? Because 
{{Unsupported class file major version 57}} is related to when some classes are 
compiled with higher version than running. I donot know what you do. Ask 
Robert, he will tell what i already asked him, that ASM here s used only for 
modular apps with JDK 8 or 7. We run the ITs with JDK 13 and JDK 14 with no 
problems.

> Running tests with JDK13 fails with Unsupported class file major version 57
> ---
>
> Key: SUREFIRE-1712
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1712
> Project: Maven Surefire
>  Issue Type: Bug
>Affects Versions: 2.22.2, 3.0.0-M2, 3.0.0-M1, 3.0.0-M3
> Environment: JDK 13+
>Reporter: Karl Heinz Marbaise
>Priority: Blocker
>
> I have a example project from [so|https://github.com/khmarbaise/so58710751] 
> the following exception occurs:
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test (default-test) 
> on project oot: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test failed: 
> Unsupported class file major version 57 -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test 
> (default-test) on project oot: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test failed: 
> Unsupported class file major version 57
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:215)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:567)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution 
> default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test failed: 
> Unsupported class file major version 57
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:148)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:210)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>