[GitHub] [maven-site-plugin] michael-o opened a new pull request, #122: [MSITE-220] site:run mojo will not display Javadoc or JXR report results

2023-01-14 Thread GitBox
michael-o opened a new pull request, #122: URL: https://github.com/apache/maven-site-plugin/pull/122 This closes #122 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jir

[GitHub] [maven-site-plugin] michael-o opened a new pull request, #121: [MSITE-920] Remove Maven 2 compat code

2023-01-14 Thread GitBox
michael-o opened a new pull request, #121: URL: https://github.com/apache/maven-site-plugin/pull/121 This closes #121 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jir

[GitHub] [maven-enforcer] slawekjaranowski merged pull request #232: [MENFORCER-458] Move Require Java, Maven Version to new API

2023-01-14 Thread GitBox
slawekjaranowski merged PR #232: URL: https://github.com/apache/maven-enforcer/pull/232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [maven-integration-testing] michael-o commented on pull request #232: Remove a few system properties before initializing the maven verifier

2023-01-14 Thread GitBox
michael-o commented on PR #232: URL: https://github.com/apache/maven-integration-testing/pull/232#issuecomment-1382882323 > > I consider this wrong because they should be at most managed from within Verifier. Those are _system_ properties and when these are required then a _forked_ verifie

[GitHub] [maven] gnodet closed pull request #912: [MNG-7629] Improve resolution of modules within a multi-module build

2023-01-14 Thread GitBox
gnodet closed pull request #912: [MNG-7629] Improve resolution of modules within a multi-module build URL: https://github.com/apache/maven/pull/912 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [maven] gnodet commented on pull request #912: [MNG-7629] Improve resolution of modules within a multi-module build

2023-01-14 Thread GitBox
gnodet commented on PR #912: URL: https://github.com/apache/maven/pull/912#issuecomment-1382845069 Closing this PR in favour of #954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [maven-integration-testing] gnodet commented on pull request #232: Remove a few system properties before initializing the maven verifier

2023-01-14 Thread GitBox
gnodet commented on PR #232: URL: https://github.com/apache/maven-integration-testing/pull/232#issuecomment-1382840257 > I consider this wrong because they should be at most managed from within Verifier. Those are _system_ properties and when these are required then a _forked_ verifier mus

[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #232: Remove a few system properties before initializing the maven verifier

2023-01-14 Thread GitBox
slawekjaranowski commented on PR #232: URL: https://github.com/apache/maven-integration-testing/pull/232#issuecomment-1382792150 > I consider this wrong because they should be at most managed from within Verifier. Those are _system_ properties and when these are required then a _forked_ ve

[GitHub] [maven-compiler-plugin] psiroky commented on a diff in pull request #167: [MCOMPILER-520] Upgrade parent to version 39 + reformat code

2023-01-14 Thread GitBox
psiroky commented on code in PR #167: URL: https://github.com/apache/maven-compiler-plugin/pull/167#discussion_r1068748398 ## pom.xml: ## @@ -208,6 +193,19 @@ under the License. + + + +false + + +true + + plexus.sna

[GitHub] [maven-archetypes] nitind commented on pull request #6: [MARCHETYPES-75] Bump web archetype deployment descriptor to v4, portlet to v3

2023-01-13 Thread GitBox
nitind commented on PR #6: URL: https://github.com/apache/maven-archetypes/pull/6#issuecomment-1382670270 @slawekjaranowski Opened [MARCHETYPES-75](https://issues.apache.org/jira/browse/MARCHETYPES-75) -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [maven-archetypes] nitind commented on pull request #6: Bump web archetype deployment descriptor to v4, portlet to v3

2023-01-13 Thread GitBox
nitind commented on PR #6: URL: https://github.com/apache/maven-archetypes/pull/6#issuecomment-1382670147 Servlet 5 involved API breakages, so still putting forth this change to 4.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [maven-jlink-plugin] bmarwell commented on a diff in pull request #78: [MJLINK-64] Fix addOptions arguments passing

2023-01-13 Thread GitBox
bmarwell commented on code in PR #78: URL: https://github.com/apache/maven-jlink-plugin/pull/78#discussion_r1070024403 ## src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java: ## @@ -108,6 +108,8 @@ * * The command line equivalent is: {@code jlink --add-optio

[GitHub] [maven] michael-o closed pull request #957: Swcurity policy

2023-01-13 Thread GitBox
michael-o closed pull request #957: Swcurity policy URL: https://github.com/apache/maven/pull/957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issue

[GitHub] [maven-wrapper] bmarwell commented on pull request #84: [BUILD] add prettier config for shell

2023-01-13 Thread GitBox
bmarwell commented on PR #84: URL: https://github.com/apache/maven-wrapper/pull/84#issuecomment-1382351592 You might want to talk about: https://github.com/apache/maven-wrapper/pull/84/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R110-R111 `onlymvnw` u

[GitHub] [maven-wrapper] bmarwell opened a new pull request, #84: [BUILD] add prettier config for shell

2023-01-13 Thread GitBox
bmarwell opened a new pull request, #84: URL: https://github.com/apache/maven-wrapper/pull/84 Signed-off-by: Benjamin Marwell Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apach

[GitHub] [maven-wrapper] bmarwell merged pull request #83: Bump junit-bom from 5.9.1 to 5.9.2

2023-01-13 Thread GitBox
bmarwell merged PR #83: URL: https://github.com/apache/maven-wrapper/pull/83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.ap

[GitHub] [maven-wrapper] bmarwell merged pull request #79: [MWRAPPER-88] fix shellcheck findings / POSIX compatiblity

2023-01-13 Thread GitBox
bmarwell merged PR #79: URL: https://github.com/apache/maven-wrapper/pull/79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.ap

[GitHub] [maven-integration-testing] psiroky opened a new pull request, #233: [MNG-7661] Replace deprecated 'verifier.newDefaultFilterProperties()'

2023-01-13 Thread GitBox
psiroky opened a new pull request, #233: URL: https://github.com/apache/maven-integration-testing/pull/233 * this should be the last _big_ PR. * these three calls are basically identical (at least with the current version of the Verifier): ```java (1) verifier.filterFile( "settings

[GitHub] [maven-build-cache-extension] ahus1 commented on pull request #37: [MBUILDCACHE-37] Allow disabled-by-default configuration to be enabled on the CLI

2023-01-13 Thread GitBox
ahus1 commented on PR #37: URL: https://github.com/apache/maven-build-cache-extension/pull/37#issuecomment-1382182236 I'm looking forward to have this feature in a patch release as it would allow me to use this extension "opt in" for the developers of the Keycloak project. Thanks! -- Th

[GitHub] [maven-build-cache-extension] ahus1 opened a new pull request, #37: [MBUILDCACHE-37] Allow disabled-by-default configuration to be enabled on the CLI

2023-01-13 Thread GitBox
ahus1 opened a new pull request, #37: URL: https://github.com/apache/maven-build-cache-extension/pull/37 This allows this plugin to be enabled on the CLI with ``` -Dmaven.build.cache.enabled=true ``` when it is disabled by default in the XML. --- Following t

[GitHub] [maven-reporting-impl] michael-o commented on pull request #15: [MSHARED-480] Use maven-site-plugin's site.xml to use site's skin instead of default when run as mojo

2023-01-13 Thread GitBox
michael-o commented on PR #15: URL: https://github.com/apache/maven-reporting-impl/pull/15#issuecomment-1382143266 @hboutemy ping... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [maven] samkenxstream opened a new pull request, #957: Swcurity policy

2023-01-13 Thread GitBox
samkenxstream opened a new pull request, #957: URL: https://github.com/apache/maven/pull/957 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for

[GitHub] [maven-doxia] michael-o commented on pull request #135: [DOXIA-685] Replace SinkEventAttributes#BOXED and clearly separate between regular verbatim and verbatim source (code)

2023-01-13 Thread GitBox
michael-o commented on PR #135: URL: https://github.com/apache/maven-doxia/pull/135#issuecomment-1382142481 @hboutemy Please review on the weekend. This is the last change I want to merge for M5 and perform a release. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #232: Remove a few system properties before initializing the maven verifier

2023-01-13 Thread GitBox
slawekjaranowski commented on code in PR #232: URL: https://github.com/apache/maven-integration-testing/pull/232#discussion_r1069688846 ## core-it-suite/src/test/java/org/apache/maven/it/TestSuiteOrdering.java: ## @@ -50,6 +50,9 @@ private static void infoProperty( PrintStream

[GitHub] [maven-integration-testing] slawekjaranowski merged pull request #226: [MNG-7661] Replace deprecated 'verifier.addCliOption()'

2023-01-13 Thread GitBox
slawekjaranowski merged PR #226: URL: https://github.com/apache/maven-integration-testing/pull/226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issue

[GitHub] [maven-doxia] michael-o merged pull request #140: [DOXIA-687] Introduce Sink#verbatim(void) method

2023-01-13 Thread GitBox
michael-o merged PR #140: URL: https://github.com/apache/maven-doxia/pull/140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.a

[GitHub] [maven-enforcer] slawekjaranowski merged pull request #231: [MENFORCER-458] Move Require Property,Environment to new API

2023-01-13 Thread GitBox
slawekjaranowski merged PR #231: URL: https://github.com/apache/maven-enforcer/pull/231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [maven-doxia] michael-o opened a new pull request, #140: [DOXIA-687] Introduce Sink#verbatim(void) method

2023-01-13 Thread GitBox
michael-o opened a new pull request, #140: URL: https://github.com/apache/maven-doxia/pull/140 This closes #140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [maven-integration-testing] gnodet commented on pull request #232: Remove a few system properties before initializing the maven verifier

2023-01-13 Thread GitBox
gnodet commented on PR #232: URL: https://github.com/apache/maven-integration-testing/pull/232#issuecomment-1381765022 The `maven.conf` is only used as a default in the `m2.conf`, so when using a non forked verifier, the current system property is set. It points to the maven home from the

[GitHub] [maven] slawekjaranowski merged pull request #953: Jenkinsfile: pickup results from ITs and Maven 3.8.x for build

2023-01-13 Thread GitBox
slawekjaranowski merged PR #953: URL: https://github.com/apache/maven/pull/953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.

[GitHub] [maven-mvnd] meiMingle commented on issue #773: The built-in 4.0.0 version of maven will invalidate the flatten-maven-plugin plugin

2023-01-13 Thread GitBox
meiMingle commented on issue #773: URL: https://github.com/apache/maven-mvnd/issues/773#issuecomment-138152 Now the relevant PR has been merged into the main branch of maven, maybe this problem will disappear in the next version of maven [Restore compatibility with flatten-maven-plugi

[GitHub] [maven-mvnd] gnodet commented on issue #773: The built-in 4.0.0 version of maven will invalidate the flatten-maven-plugin plugin

2023-01-13 Thread GitBox
gnodet commented on issue #773: URL: https://github.com/apache/maven-mvnd/issues/773#issuecomment-1381520092 Please provide a reproducer, as the short description won't be sufficient to understand what the problem is. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [maven] psiroky commented on pull request #953: Jenkinsfile: pickup results from ITs and Maven 3.8.x for build

2023-01-13 Thread GitBox
psiroky commented on PR #953: URL: https://github.com/apache/maven/pull/953#issuecomment-1381488197 Looks good to me (my Jenkins knowledge is little rusty these days though). I can't approve the PR formally, so at least commenting here. -- This is an automated message from the Apache Git

[GitHub] [maven] slawekjaranowski commented on pull request #953: Jenkinsfile: pickup results from ITs and Maven 3.8.x for build

2023-01-13 Thread GitBox
slawekjaranowski commented on PR #953: URL: https://github.com/apache/maven/pull/953#issuecomment-1381470900 Failed jenkins build is from branch, when we create PR, jenkins not build branch any more and wrong status stay for ever 😄 -- This is an automated message from the Apache Git Serv

[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #226: [MNG-7661] Replace deprecated 'verifier.addCliOption()'

2023-01-13 Thread GitBox
slawekjaranowski commented on PR #226: URL: https://github.com/apache/maven-integration-testing/pull/226#issuecomment-1381466894 First I want to merge: https://github.com/apache/maven/pull/953 to be sure that tests are ok. -- This is an automated message from the Apache Git Service. To r

[GitHub] [maven-integration-testing] psiroky commented on pull request #226: [MNG-7661] Replace deprecated 'verifier.addCliOption()'

2023-01-13 Thread GitBox
psiroky commented on PR #226: URL: https://github.com/apache/maven-integration-testing/pull/226#issuecomment-1381463498 @cstamas no worries, the conflict was trivial to resolve. Should be ready now. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [maven-integration-testing] slawekjaranowski merged pull request #231: Fix MavenITmng5669ReadPomsOnce

2023-01-13 Thread GitBox
slawekjaranowski merged PR #231: URL: https://github.com/apache/maven-integration-testing/pull/231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issue

[GitHub] [maven-integration-testing] cstamas commented on pull request #226: [MNG-7661] Replace deprecated 'verifier.addCliOption()'

2023-01-12 Thread GitBox
cstamas commented on PR #226: URL: https://github.com/apache/maven-integration-testing/pull/226#issuecomment-1381428841 @psiroky sorry for causing inconvenience, and I am aware this is 2nd time, but please can you fix the conflict? :smile: and then let's merge @slawekjaranowski -- This

[GitHub] [maven-mvnd] naosense opened a new issue, #772: Timeout when connecting maven daemon

2023-01-12 Thread GitBox
naosense opened a new issue, #772: URL: https://github.com/apache/maven-mvnd/issues/772 ``` ❯ mvd8 -Dmaven.test.skip=true -Dmvnd.jvmArgs=-XX:-MaxFDLimit clean package Exception in thread "main" org.mvndaemon.mvnd.common.DaemonException$ConnectException: Could not connect to the Maven

[GitHub] [maven-enforcer] slawekjaranowski opened a new pull request, #232: [MENFORCER-458] Move Require Java, Maven Version to new API

2023-01-12 Thread GitBox
slawekjaranowski opened a new pull request, #232: URL: https://github.com/apache/maven-enforcer/pull/232 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER)

[GitHub] [maven-compiler-plugin] psiroky commented on a diff in pull request #167: [MCOMPILER-520] Upgrade parent to version 39 + reformat code

2023-01-12 Thread GitBox
psiroky commented on code in PR #167: URL: https://github.com/apache/maven-compiler-plugin/pull/167#discussion_r1068748398 ## pom.xml: ## @@ -208,6 +193,19 @@ under the License. + + + +false + + +true + + plexus.sna

[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #231: Fix MavenITmng5669ReadPomsOnce

2023-01-12 Thread GitBox
slawekjaranowski commented on code in PR #231: URL: https://github.com/apache/maven-integration-testing/pull/231#discussion_r1068701908 ## core-it-suite/src/test/resources-filtered/bootstrap.txt: ## @@ -79,13 +79,15 @@ org.apache.maven.plugins:maven-dependency-plugin:3.3.0 org

[GitHub] [maven-integration-testing] cstamas merged pull request #230: [MNG-7667] Fix Bootstrap IT

2023-01-12 Thread GitBox
cstamas merged PR #230: URL: https://github.com/apache/maven-integration-testing/pull/230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [maven-plugin-tools] cstamas merged pull request #190: [MPLUGIN-452] Maven scope and module name logs at wrong level

2023-01-12 Thread GitBox
cstamas merged PR #190: URL: https://github.com/apache/maven-plugin-tools/pull/190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ma

[GitHub] [maven-compiler-plugin] psiroky commented on pull request #162: Bump maven-plugins from 37 to 39

2023-01-12 Thread GitBox
psiroky commented on PR #162: URL: https://github.com/apache/maven-compiler-plugin/pull/162#issuecomment-1380991854 This can be closed as the upgrade is done as part of https://github.com/apache/maven-compiler-plugin/pull/167 (plus the formatting changes). -- This is an automated messag

[GitHub] [maven-compiler-plugin] psiroky opened a new pull request, #167: [MCOMPILER-520] Upgrade parent to version 39 + reformat code

2023-01-12 Thread GitBox
psiroky opened a new pull request, #167: URL: https://github.com/apache/maven-compiler-plugin/pull/167 * I reformatted also the IT projects so that the code there is somewhat consistent with the main code base. That makes the PR i bit bigger, so I could possibly split that up if needed

[GitHub] [maven-integration-testing] cstamas commented on a diff in pull request #231: Fix MavenITmng5669ReadPomsOnce

2023-01-12 Thread GitBox
cstamas commented on code in PR #231: URL: https://github.com/apache/maven-integration-testing/pull/231#discussion_r1068637910 ## core-it-suite/src/test/resources-filtered/bootstrap.txt: ## @@ -79,13 +79,15 @@ org.apache.maven.plugins:maven-dependency-plugin:3.3.0 org.apache.m

[GitHub] [maven-enforcer] slawekjaranowski opened a new pull request, #231: [MENFORCER-458] Move Require Property,Environment to new API

2023-01-12 Thread GitBox
slawekjaranowski opened a new pull request, #231: URL: https://github.com/apache/maven-enforcer/pull/231 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER)

[GitHub] [maven-integration-testing] cstamas commented on a diff in pull request #230: [MNG-7667] Fix Bootstrap IT

2023-01-12 Thread GitBox
cstamas commented on code in PR #230: URL: https://github.com/apache/maven-integration-testing/pull/230#discussion_r1068636861 ## core-it-support/maven-it-plugin-bootstrap/src/main/java/org/apache/maven/its/bootstrap/DownloadMojo.java: ## @@ -82,8 +86,10 @@ @Override

[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #230: [MNG-7667] Fix Bootstrap IT

2023-01-12 Thread GitBox
slawekjaranowski commented on code in PR #230: URL: https://github.com/apache/maven-integration-testing/pull/230#discussion_r1068636121 ## core-it-support/maven-it-plugin-bootstrap/src/main/java/org/apache/maven/its/bootstrap/DownloadMojo.java: ## @@ -82,8 +86,10 @@ @Overr

[GitHub] [maven-enforcer] slawekjaranowski merged pull request #230: [MENFORCER-458] Move Require*Checksum to new API

2023-01-12 Thread GitBox
slawekjaranowski merged PR #230: URL: https://github.com/apache/maven-enforcer/pull/230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [maven-integration-testing] slawekjaranowski opened a new pull request, #231: Fix MavenITmng5669ReadPomsOnce

2023-01-12 Thread GitBox
slawekjaranowski opened a new pull request, #231: URL: https://github.com/apache/maven-integration-testing/pull/231 In test, we check if pom files are read only once. When we update plugin or dependencies in test, number of read items can change again. So should be good enoug

[GitHub] [maven-plugin-tools] cstamas opened a new pull request, #190: [MPLUGIN-452] Maven scope and module name warning should WARN

2023-01-12 Thread GitBox
cstamas opened a new pull request, #190: URL: https://github.com/apache/maven-plugin-tools/pull/190 Should be logged at WARN level, and not ERROR level. When Mojo logs ERROR, it is expected that it fails the build. And this also confuses the Verifier. --- https://issues.apache.

[GitHub] [maven-fluido-skin] michael-o merged pull request #44: [MSKINS-204] Make MSKINS-76 ITs more tolerant

2023-01-12 Thread GitBox
michael-o merged PR #44: URL: https://github.com/apache/maven-fluido-skin/pull/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mav

[GitHub] [maven-integration-testing] cstamas commented on pull request #230: [MNG-7667] Partial fix that "works for me"

2023-01-12 Thread GitBox
cstamas commented on PR #230: URL: https://github.com/apache/maven-integration-testing/pull/230#issuecomment-1380591738 This fixes the original issue, but now we face other issue: all the ITs that use maven-plugin packaging and do verifier.verifyErrorFreeLog will fail, as m-plugin-p emits

[GitHub] [maven-integration-testing] cstamas commented on a diff in pull request #230: [MNG-7667] Partial fix that "works for me"

2023-01-12 Thread GitBox
cstamas commented on code in PR #230: URL: https://github.com/apache/maven-integration-testing/pull/230#discussion_r1068281989 ## core-it-support/maven-it-plugin-bootstrap/src/main/java/org/apache/maven/its/bootstrap/DownloadMojo.java: ## @@ -104,6 +105,21 @@ public void execut

[GitHub] [maven-integration-testing] cstamas commented on a diff in pull request #230: [MNG-7667] Partial fix that "works for me"

2023-01-12 Thread GitBox
cstamas commented on code in PR #230: URL: https://github.com/apache/maven-integration-testing/pull/230#discussion_r1068281989 ## core-it-support/maven-it-plugin-bootstrap/src/main/java/org/apache/maven/its/bootstrap/DownloadMojo.java: ## @@ -104,6 +105,21 @@ public void execut

[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on pull request #30: [MBUILDCACHE-24] - Fixes IllegalArgumentException in forked executions

2023-01-12 Thread GitBox
AlexanderAshitkin commented on PR #30: URL: https://github.com/apache/maven-build-cache-extension/pull/30#issuecomment-1380520600 > reproduce -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven-integration-testing] cstamas opened a new pull request, #230: [MNG-7667] Partial fix that "works for me"

2023-01-12 Thread GitBox
cstamas opened a new pull request, #230: URL: https://github.com/apache/maven-integration-testing/pull/230 This change hunts down m-install-p and m-deploy-p versions from tested Maven (the one bound in default lifecycle) and resolves them and their dependencies. This makes IT pass for me wi

[GitHub] [maven-mvnd] gzm55 commented on a diff in pull request #717: Try native image then fallback to pure java version

2023-01-12 Thread GitBox
gzm55 commented on code in PR #717: URL: https://github.com/apache/maven-mvnd/pull/717#discussion_r1068210162 ## dist/src/main/distro/bin/mvnd.cmd: ## @@ -25,6 +25,11 @@ @REM MAVEN_BATCH_PAUSE (Optional) set to 'on' to wait for a key stroke before ending. @REM MAVEN_OPTS

[GitHub] [maven-mvnd] gzm55 commented on pull request #726: Add property 'mvnd.preserveProjectLog' to not decorate the stdout/stderr stream

2023-01-12 Thread GitBox
gzm55 commented on PR #726: URL: https://github.com/apache/maven-mvnd/pull/726#issuecomment-1380434752 @ppalaga this option is used to keep the logging behavior the same as the original maven: Expected from maven (no new-line char at the end): ```bash $ mvn -DforceStdout -q help

[GitHub] [maven-build-cache-extension] athkalia commented on pull request #30: [MBUILDCACHE-24] - Fixes IllegalArgumentException in forked executions

2023-01-12 Thread GitBox
athkalia commented on PR #30: URL: https://github.com/apache/maven-build-cache-extension/pull/30#issuecomment-1380409800 Hi, I am stumbling on this issue when using either the `1.0.0` or the `1.0.0-SNAPSHOT` version of the maven build cache extension. I have created a small sample project

[GitHub] [maven] cstamas commented on pull request #955: [maven-3.9.x] [MNG-7666] Update default binding and lifecycle plugin versions

2023-01-12 Thread GitBox
cstamas commented on PR #955: URL: https://github.com/apache/maven/pull/955#issuecomment-1380307949 Reason of IT failure: ``` Caused by: org.eclipse.aether.transfer.ArtifactNotFoundException: Could not find artifact org.apache.maven.plugins:maven-surefire-plugin:jar:3.0.0-M8 in centra

[GitHub] [maven] cstamas commented on pull request #956: [MNG-7666] Update default binding and lifecycle plugin versions

2023-01-12 Thread GitBox
cstamas commented on PR #956: URL: https://github.com/apache/maven/pull/956#issuecomment-1380306097 Reason of IT failure: ``` Caused by: org.eclipse.aether.transfer.ArtifactNotFoundException: Could not find artifact org.apache.maven.plugins:maven-surefire-plugin:jar:3.0.0-M8 in centra

[GitHub] [maven] cstamas commented on pull request #956: [MNG-7666] Update default binding and lifecycle plugin versions

2023-01-12 Thread GitBox
cstamas commented on PR #956: URL: https://github.com/apache/maven/pull/956#issuecomment-1380253700 Also lowered the _ID constants visibility -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [maven] cstamas commented on a diff in pull request #956: [MNG-7666] Update default binding and lifecycle plugin versions

2023-01-12 Thread GitBox
cstamas commented on code in PR #956: URL: https://github.com/apache/maven/pull/956#discussion_r1068060689 ## maven-core/src/main/java/org/apache/maven/lifecycle/providers/SiteLifecycleProvider.java: ## @@ -34,8 +34,8 @@ public final class SiteLifecycleProvider extends Abstract

[GitHub] [maven-integration-testing] cstamas merged pull request #229: Fix plexus-component-metadata plugin version

2023-01-12 Thread GitBox
cstamas merged PR #229: URL: https://github.com/apache/maven-integration-testing/pull/229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [maven-doxia] dependabot[bot] closed pull request #129: Bump annotations from 15.0 to 23.1.0

2023-01-12 Thread GitBox
dependabot[bot] closed pull request #129: Bump annotations from 15.0 to 23.1.0 URL: https://github.com/apache/maven-doxia/pull/129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [maven-doxia] dependabot[bot] commented on pull request #129: Bump annotations from 15.0 to 23.1.0

2023-01-12 Thread GitBox
dependabot[bot] commented on PR #129: URL: https://github.com/apache/maven-doxia/pull/129#issuecomment-1380224836 Superseded by #139. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [maven-doxia] dependabot[bot] opened a new pull request, #139: Bump annotations from 15.0 to 24.0.0

2023-01-12 Thread GitBox
dependabot[bot] opened a new pull request, #139: URL: https://github.com/apache/maven-doxia/pull/139 Bumps [annotations](https://github.com/JetBrains/java-annotations) from 15.0 to 24.0.0. Release notes Sourced from https://github.com/JetBrains/java-annotations/releases";>annotatio

[GitHub] [maven-integration-testing] cstamas opened a new pull request, #229: Fix plexus-component-metadata plugin version

2023-01-12 Thread GitBox
cstamas opened a new pull request, #229: URL: https://github.com/apache/maven-integration-testing/pull/229 A parent POM have it removed, but the plgMgmt does not have this entry of IT project. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [maven] michael-o commented on a diff in pull request #956: [MNG-7666] Update default binding and lifecycle plugin versions

2023-01-12 Thread GitBox
michael-o commented on code in PR #956: URL: https://github.com/apache/maven/pull/956#discussion_r1068026566 ## maven-core/src/main/java/org/apache/maven/lifecycle/providers/WrapperLifecycleProvider.java: ## @@ -33,7 +33,7 @@ public final class WrapperLifecycleProvider extends

[GitHub] [maven] cstamas opened a new pull request, #956: [MNG-7666] Update default binding and lifecycle plugin versions

2023-01-12 Thread GitBox
cstamas opened a new pull request, #956: URL: https://github.com/apache/maven/pull/956 Finally use 3.x plugins for all. --- https://issues.apache.org/jira/browse/MNG-7666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [maven-mvnd] oehme commented on a diff in pull request #764: Fix core export provider

2023-01-12 Thread GitBox
oehme commented on code in PR #764: URL: https://github.com/apache/maven-mvnd/pull/764#discussion_r1068014719 ## integration-tests/src/test/java/org/mvndaemon/mvnd/it/ExtensionWithApiTest.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [maven] cstamas opened a new pull request, #955: [maven-3.9.x] [MNG-7666] Update default binding and lifecycle plugin versions

2023-01-12 Thread GitBox
cstamas opened a new pull request, #955: URL: https://github.com/apache/maven/pull/955 Finally use 3.x plugins for all. --- https://issues.apache.org/jira/browse/MNG-7666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [maven-mvnd] ppalaga commented on a diff in pull request #717: Try native image then fallback to pure java version

2023-01-12 Thread GitBox
ppalaga commented on code in PR #717: URL: https://github.com/apache/maven-mvnd/pull/717#discussion_r1067958247 ## dist/src/main/distro/bin/mvnd.cmd: ## @@ -25,6 +25,11 @@ @REM MAVEN_BATCH_PAUSE (Optional) set to 'on' to wait for a key stroke before ending. @REM MAVEN_OPT

[GitHub] [maven-integration-testing] dependabot[bot] closed pull request #185: Bump jetty-server from 9.0.4.v20130625 to 10.0.10 in /core-it-suite

2023-01-12 Thread GitBox
dependabot[bot] closed pull request #185: Bump jetty-server from 9.0.4.v20130625 to 10.0.10 in /core-it-suite URL: https://github.com/apache/maven-integration-testing/pull/185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [maven-integration-testing] dependabot[bot] commented on pull request #185: Bump jetty-server from 9.0.4.v20130625 to 10.0.10 in /core-it-suite

2023-01-12 Thread GitBox
dependabot[bot] commented on PR #185: URL: https://github.com/apache/maven-integration-testing/pull/185#issuecomment-1380112216 Looks like org.eclipse.jetty:jetty-server is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [maven-integration-testing] cstamas merged pull request #228: [MNG-7665] Update Jetty to latest Java8 capable version

2023-01-12 Thread GitBox
cstamas merged PR #228: URL: https://github.com/apache/maven-integration-testing/pull/228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [maven-resolver] cstamas merged pull request #235: [MRESOLVER-298] Make javax.inject optional again

2023-01-12 Thread GitBox
cstamas merged PR #235: URL: https://github.com/apache/maven-resolver/pull/235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.

[GitHub] [maven-mvnd] ppalaga commented on pull request #764: Fix core export provider

2023-01-12 Thread GitBox
ppalaga commented on PR #764: URL: https://github.com/apache/maven-mvnd/pull/764#issuecomment-1380098894 > The test infrastructure assumes that every test case is a single project, but for my case I had to install the extension first before using it in the consuming build. I hacked around t

[GitHub] [maven-mvnd] ppalaga commented on a diff in pull request #764: Fix core export provider

2023-01-12 Thread GitBox
ppalaga commented on code in PR #764: URL: https://github.com/apache/maven-mvnd/pull/764#discussion_r1067934585 ## integration-tests/src/test/java/org/mvndaemon/mvnd/it/ExtensionWithApiTest.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [maven-mvnd] ppalaga commented on pull request #726: Add property 'mvnd.preserveProjectLog' to not decorate the stdout/stderr stream

2023-01-12 Thread GitBox
ppalaga commented on PR #726: URL: https://github.com/apache/maven-mvnd/pull/726#issuecomment-1380084656 I must say I have hard time figuring out how this combines with `--raw-streams`. It sounds like you need some additional fine tuning of how the system streams are set up and which is cur

[GitHub] [maven-mvnd] ppalaga commented on pull request #726: Add property 'mvnd.preserveProjectLog' to not decorate the stdout/stderr stream

2023-01-12 Thread GitBox
ppalaga commented on PR #726: URL: https://github.com/apache/maven-mvnd/pull/726#issuecomment-1380028652 Could you please explain what are the possible motivations for this change? In which situations does it help? Why would user want to have this? -- This is an automated message from the

[GitHub] [maven] slawekjaranowski closed pull request #951: Jenkinsfile: pickup results from ITs

2023-01-11 Thread GitBox
slawekjaranowski closed pull request #951: Jenkinsfile: pickup results from ITs URL: https://github.com/apache/maven/pull/951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [maven] slawekjaranowski commented on pull request #951: Jenkinsfile: pickup results from ITs

2023-01-11 Thread GitBox
slawekjaranowski commented on PR #951: URL: https://github.com/apache/maven/pull/951#issuecomment-1379901954 Suppressed by #953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [maven] gnodet opened a new pull request, #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-11 Thread GitBox
gnodet opened a new pull request, #954: URL: https://github.com/apache/maven/pull/954 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the ch

[GitHub] [maven-jlink-plugin] dependabot[bot] closed pull request #118: Bump maven-project-info-reports-plugin from 3.1.2 to 3.4.1

2023-01-11 Thread GitBox
dependabot[bot] closed pull request #118: Bump maven-project-info-reports-plugin from 3.1.2 to 3.4.1 URL: https://github.com/apache/maven-jlink-plugin/pull/118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [maven-jlink-plugin] dependabot[bot] commented on pull request #118: Bump maven-project-info-reports-plugin from 3.1.2 to 3.4.1

2023-01-11 Thread GitBox
dependabot[bot] commented on PR #118: URL: https://github.com/apache/maven-jlink-plugin/pull/118#issuecomment-1379782200 Superseded by #132. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [maven-apache-parent] dependabot[bot] opened a new pull request, #124: Bump maven-dependency-plugin from 3.4.0 to 3.5.0

2023-01-11 Thread GitBox
dependabot[bot] opened a new pull request, #124: URL: https://github.com/apache/maven-apache-parent/pull/124 Bumps [maven-dependency-plugin](https://github.com/apache/maven-dependency-plugin) from 3.4.0 to 3.5.0. Commits https://github.com/apache/maven-dependency-plugin/commit

[GitHub] [maven-jlink-plugin] dependabot[bot] opened a new pull request, #132: Bump maven-project-info-reports-plugin from 3.1.2 to 3.4.2

2023-01-11 Thread GitBox
dependabot[bot] opened a new pull request, #132: URL: https://github.com/apache/maven-jlink-plugin/pull/132 Bumps [maven-project-info-reports-plugin](https://github.com/apache/maven-project-info-reports-plugin) from 3.1.2 to 3.4.2. Commits https://github.com/apache/maven-proje

[GitHub] [maven-apache-parent] dependabot[bot] opened a new pull request, #123: Bump maven-project-info-reports-plugin from 3.4.1 to 3.4.2

2023-01-11 Thread GitBox
dependabot[bot] opened a new pull request, #123: URL: https://github.com/apache/maven-apache-parent/pull/123 Bumps [maven-project-info-reports-plugin](https://github.com/apache/maven-project-info-reports-plugin) from 3.4.1 to 3.4.2. Commits https://github.com/apache/maven-proj

[GitHub] [maven-indexer] dependabot[bot] opened a new pull request, #288: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1

2023-01-11 Thread GitBox
dependabot[bot] opened a new pull request, #288: URL: https://github.com/apache/maven-indexer/pull/288 Bumps [maven-checkstyle-plugin](https://github.com/apache/maven-checkstyle-plugin) from 3.2.0 to 3.2.1. Commits https://github.com/apache/maven-checkstyle-plugin/commit/9f6a7

[GitHub] [maven-indexer] dependabot[bot] closed pull request #283: Bump version.spring from 5.3.23 to 6.0.3

2023-01-11 Thread GitBox
dependabot[bot] closed pull request #283: Bump version.spring from 5.3.23 to 6.0.3 URL: https://github.com/apache/maven-indexer/pull/283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [maven-indexer] dependabot[bot] opened a new pull request, #287: Bump version.spring from 5.3.23 to 6.0.4

2023-01-11 Thread GitBox
dependabot[bot] opened a new pull request, #287: URL: https://github.com/apache/maven-indexer/pull/287 Bumps `version.spring` from 5.3.23 to 6.0.4. Updates `spring-beans` from 5.3.23 to 6.0.4 Release notes Sourced from https://github.com/spring-projects/spring-framework/releases"

[GitHub] [maven-indexer] dependabot[bot] commented on pull request #283: Bump version.spring from 5.3.23 to 6.0.3

2023-01-11 Thread GitBox
dependabot[bot] commented on PR #283: URL: https://github.com/apache/maven-indexer/pull/283#issuecomment-1379781698 Superseded by #287. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [maven-parent] dependabot[bot] opened a new pull request, #103: Bump maven-pmd-plugin from 3.19.0 to 3.20.0

2023-01-11 Thread GitBox
dependabot[bot] opened a new pull request, #103: URL: https://github.com/apache/maven-parent/pull/103 Bumps [maven-pmd-plugin](https://github.com/apache/maven-pmd-plugin) from 3.19.0 to 3.20.0. Commits https://github.com/apache/maven-pmd-plugin/commit/55c4d404a1109eded89ae760c9

[GitHub] [maven-parent] dependabot[bot] opened a new pull request, #102: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1

2023-01-11 Thread GitBox
dependabot[bot] opened a new pull request, #102: URL: https://github.com/apache/maven-parent/pull/102 Bumps [maven-checkstyle-plugin](https://github.com/apache/maven-checkstyle-plugin) from 3.2.0 to 3.2.1. Commits https://github.com/apache/maven-checkstyle-plugin/commit/9f6a75

[GitHub] [maven-mvnd] gzm55 commented on pull request #726: Add property 'mvnd.preserveProjectLog' to not decorate the stdout/stderr stream

2023-01-11 Thread GitBox
gzm55 commented on PR #726: URL: https://github.com/apache/maven-mvnd/pull/726#issuecomment-1379712196 @gnodet @ppalaga what about this pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [maven-site] dependabot[bot] closed pull request #352: Bump plantuml from 1.2022.13 to 1.2022.14

2023-01-11 Thread GitBox
dependabot[bot] closed pull request #352: Bump plantuml from 1.2022.13 to 1.2022.14 URL: https://github.com/apache/maven-site/pull/352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

<    1   2   3   4   5   6   7   8   9   10   >