[GitHub] [maven] laeubi commented on pull request #948: MNG-7662 - Allow Graphbuilder to use session scoped components

2023-01-04 Thread GitBox
laeubi commented on PR #948: URL: https://github.com/apache/maven/pull/948#issuecomment-1371283602 @michael-o can you probably take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [maven-enforcer] slawekjaranowski commented on pull request #216: [MENFORCER-455] New Enforcer API

2023-01-04 Thread GitBox
slawekjaranowski commented on PR #216: URL: https://github.com/apache/maven-enforcer/pull/216#issuecomment-1371282744 @kwin Do you accept my responses? Can I do anything more with this PR? Anybody else has any more remarks? I would like to merge and go forward. -- This is an a

[GitHub] [maven-surefire] andpab commented on pull request #571: [SUREFIRE-2121] JUnitException: Failed to parse version of junit:junit: 4.13.2

2023-01-04 Thread GitBox
andpab commented on PR #571: URL: https://github.com/apache/maven-surefire/pull/571#issuecomment-1371271421 I've updated the versions in SUREFIRE-2138 (PR #590), so once the next release is made, the examples on the website will show up-to-date versions. -- This is an automated message f

[GitHub] [maven-surefire] andpab commented on pull request #590: [SUREFIRE-2138] Update Junit4/5 version in docs and ITs

2023-01-04 Thread GitBox
andpab commented on PR #590: URL: https://github.com/apache/maven-surefire/pull/590#issuecomment-1371268106 That's great news. Looking forward to it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven-surefire] slawekjaranowski commented on pull request #590: [SUREFIRE-2138] Update Junit4/5 version in docs and ITs

2023-01-04 Thread GitBox
slawekjaranowski commented on PR #590: URL: https://github.com/apache/maven-surefire/pull/590#issuecomment-1371211261 @andpab site is updated during release with new version. I'm looking into current changes, I think that new release will be appreciated. So I will try to take

[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #224: [MNG-7661] Fix deprecated verifier calls

2023-01-04 Thread GitBox
slawekjaranowski commented on PR #224: URL: https://github.com/apache/maven-integration-testing/pull/224#issuecomment-1371201704 Great job, can you split each commit as separate PR 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #224: [MNG-7661] Fix deprecated verifier calls

2023-01-04 Thread GitBox
slawekjaranowski commented on code in PR #224: URL: https://github.com/apache/maven-integration-testing/pull/224#discussion_r1061707521 ## core-it-suite/src/test/java/org/apache/maven/it/MavenITmng2199ParentVersionRangeTest.java: ## @@ -65,7 +65,6 @@ public void testValidParen

[GitHub] [maven-resolver] cstamas opened a new pull request, #233: [MRESOLVER-309] Do not kill the build when unkown remote layout

2023-01-04 Thread GitBox
cstamas opened a new pull request, #233: URL: https://github.com/apache/maven-resolver/pull/233 In case remote repository defines unsupported layout, filter should just let it pass (as resolver will gracefully fail with it anyway), while throwing RuntimeException caused abruptly stopped bui

[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #224: [MNG-7661] Fix deprecated verifier calls

2023-01-04 Thread GitBox
slawekjaranowski commented on code in PR #224: URL: https://github.com/apache/maven-integration-testing/pull/224#discussion_r1061706611 ## core-it-suite/src/test/java/org/apache/maven/it/MavenITmng1803PomValidationErrorIncludesLineNumberTest.java: ## @@ -64,7 +64,6 @@ public vo

[GitHub] [maven-surefire] andpab commented on pull request #590: [SUREFIRE-2138] Update Junit4/5 version in docs and ITs

2023-01-04 Thread GitBox
andpab commented on PR #590: URL: https://github.com/apache/maven-surefire/pull/590#issuecomment-1371188852 @slawekjaranowski Thanks for reviewing and merging. Is there anything else that needs to be triggered so that the website is updated or is it only updated when a new release is made?

[GitHub] [maven-integration-testing] psiroky opened a new pull request, #224: [MNG-7661] Fix deprecated verifier calls

2023-01-04 Thread GitBox
psiroky opened a new pull request, #224: URL: https://github.com/apache/maven-integration-testing/pull/224 * I know the change looks huge, but in fact it is just a couple of find & replace calls in IDE. 99% were of the changes were done automatically, just had to manually adjust some edge c

[GitHub] [maven-doxia] hboutemy merged pull request #132: [DOXIA-617] support yaml metadata

2023-01-04 Thread GitBox
hboutemy merged PR #132: URL: https://github.com/apache/maven-doxia/pull/132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.ap

[GitHub] [maven-integration-testing] psiroky commented on a diff in pull request #223: [MNG-7661] Use provided scope for Maven deps in IT plugins

2023-01-04 Thread GitBox
psiroky commented on code in PR #223: URL: https://github.com/apache/maven-integration-testing/pull/223#discussion_r1061572431 ## core-it-support/core-it-plugins/maven-it-plugin-site/pom.xml: ## @@ -67,6 +68,40 @@ under the License. org.apache.maven.reporting mave

[GitHub] [maven-integration-testing] psiroky commented on a diff in pull request #223: [MNG-7661] Use provided scope for Maven deps in IT plugins

2023-01-04 Thread GitBox
psiroky commented on code in PR #223: URL: https://github.com/apache/maven-integration-testing/pull/223#discussion_r1061572431 ## core-it-support/core-it-plugins/maven-it-plugin-site/pom.xml: ## @@ -67,6 +68,40 @@ under the License. org.apache.maven.reporting mave

[GitHub] [maven-integration-testing] psiroky commented on pull request #223: [MNG-7661] Use provided scope for Maven deps in IT plugins

2023-01-04 Thread GitBox
psiroky commented on PR #223: URL: https://github.com/apache/maven-integration-testing/pull/223#issuecomment-1371036304 Yeah, that is the case in one of the plugins here as well, hence the exclusions. The `dependencyManagement` solution is quite elegant though as it means way less c

[GitHub] [maven] laeubi opened a new pull request, #948: MNG-7662 - Allow Graphbuilder to use session scoped components

2023-01-04 Thread GitBox
laeubi opened a new pull request, #948: URL: https://github.com/apache/maven/pull/948 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG-7662) filed for t

[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #223: [MNG-7661] Use provided scope for Maven deps in IT plugins

2023-01-04 Thread GitBox
slawekjaranowski commented on PR #223: URL: https://github.com/apache/maven-integration-testing/pull/223#issuecomment-1370951680 I used `dependencyManagement` in maven-enforcer because one Maven core artifact from transitive dependencies was in compile scope. -- This is an autom

[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #223: [MNG-7661] Use provided scope for Maven deps in IT plugins

2023-01-04 Thread GitBox
slawekjaranowski commented on code in PR #223: URL: https://github.com/apache/maven-integration-testing/pull/223#discussion_r1061495477 ## core-it-support/core-it-plugins/maven-it-plugin-site/pom.xml: ## @@ -67,6 +68,40 @@ under the License. org.apache.maven.reporting

[GitHub] [maven-shared-utils] tisonkun commented on pull request #45: [MSHARED-898] prefer JDK classes to DirectoryScanner

2023-01-04 Thread GitBox
tisonkun commented on PR #45: URL: https://github.com/apache/maven-shared-utils/pull/45#issuecomment-1370894007 @elharo do we have a migration example? It seems that `DirectoryScanner` is still far more fruitful then bare `java.nio.file.DirectoryStream`. -- This is an automated message f

[GitHub] [maven] gnodet commented on pull request #947: [MNG-7642] Restore compatibility with flatten-maven-plugin

2023-01-04 Thread GitBox
gnodet commented on PR #947: URL: https://github.com/apache/maven/pull/947#issuecomment-1370889590 > I think I can see that now. > Thanks @gnodet. Yes, it's really just for binary compatibility with the existing stuff. -- This is an automated message from the Apache Git Service.

[GitHub] [maven] pzygielo commented on pull request #947: [MNG-7642] Restore compatibility with flatten-maven-plugin

2023-01-04 Thread GitBox
pzygielo commented on PR #947: URL: https://github.com/apache/maven/pull/947#issuecomment-1370872944 I think I can see that now. Thanks @gnodet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven] pzygielo commented on pull request #947: [MNG-7642] Restore compatibility with flatten-maven-plugin

2023-01-04 Thread GitBox
pzygielo commented on PR #947: URL: https://github.com/apache/maven/pull/947#issuecomment-1370861376 So it will be passed in https://github.com/apache/maven/blob/aab448546326da99fd8f2fc5d15ff08dd79bae8e/src/main/java/org/codehaus/mojo/flatten/ModelBuilderThreadSafetyWorkaround.java#L131

[GitHub] [maven] gnodet commented on a diff in pull request #947: [MNG-7642] Restore compatibility with flatten-maven-plugin

2023-01-04 Thread GitBox
gnodet commented on code in PR #947: URL: https://github.com/apache/maven/pull/947#discussion_r1061415474 ## maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java: ## @@ -625,6 +626,15 @@ public DefaultModelBuilder setProfileActivationFilePa

[GitHub] [maven] gnodet commented on pull request #947: [MNG-7642] Restore compatibility with flatten-maven-plugin

2023-01-04 Thread GitBox
gnodet commented on PR #947: URL: https://github.com/apache/maven/pull/947#issuecomment-1370845771 > Not sure about _Restore compatibility_. This just restores as no-op methods. If flatten called them - didn't it do it for some purpose? Will flatten behave as expected or just not throw API

[GitHub] [maven] pzygielo commented on pull request #947: [MNG-7642] Restore compatibility with flatten-maven-plugin

2023-01-04 Thread GitBox
pzygielo commented on PR #947: URL: https://github.com/apache/maven/pull/947#issuecomment-1370802637 Not sure about _Restore compatibility_. This just restores as no-op methods. If flatten called them - didn't it do it for some purpose? Will flatten behave as expected or just not throw

[GitHub] [maven] pzygielo commented on a diff in pull request #947: [MNG-7642] Restore compatibility with flatten-maven-plugin

2023-01-04 Thread GitBox
pzygielo commented on code in PR #947: URL: https://github.com/apache/maven/pull/947#discussion_r1061375606 ## maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java: ## @@ -625,6 +626,15 @@ public DefaultModelBuilder setProfileActivationFile

[GitHub] [maven-surefire] andpab commented on pull request #387: [SUREFIRE-1939] Fix NPE in SystemUtils.toJdkHomeFromJvmExec if java home has 2 components

2023-01-04 Thread GitBox
andpab commented on PR #387: URL: https://github.com/apache/maven-surefire/pull/387#issuecomment-1370776730 @CMoH are you available to make the requested changes to the tests? Otherwise I can also make a new pull request. -- This is an automated message from the Apache Git Service. To res

[GitHub] [maven-surefire] andpab commented on a diff in pull request #387: [SUREFIRE-1939] Fix NPE in SystemUtils.toJdkHomeFromJvmExec if java home has 2 components

2023-01-04 Thread GitBox
andpab commented on code in PR #387: URL: https://github.com/apache/maven-surefire/pull/387#discussion_r1059803389 ## surefire-booter/src/test/java/org/apache/maven/surefire/booter/SystemUtilsTest.java: ## @@ -98,6 +98,15 @@ public void incorrectJdkPath() assertThat

[GitHub] [maven] gnodet opened a new pull request, #947: [MNG-7642] Restore compatibility with flatten-maven-plugin

2023-01-04 Thread GitBox
gnodet opened a new pull request, #947: URL: https://github.com/apache/maven/pull/947 Revert "[MNG-7505] Remove ReportingConverter (#906)" This reverts commit adf89ef63ffca07e490f5cc550f9411bad1a7bd6. Following this checklist to help us incorporate your contribution quickly and e

[GitHub] [maven] gnodet commented on a diff in pull request #866: [MNG-7596] Upgrade to plexus 3.5.0

2023-01-04 Thread GitBox
gnodet commented on code in PR #866: URL: https://github.com/apache/maven/pull/866#discussion_r1061225506 ## maven-xml-impl/src/main/java/org/apache/maven/internal/xml/Xpp3Dom.java: ## @@ -180,8 +181,6 @@ public void writeToSerializer(String namespace, XmlSerializer serializer)

[GitHub] [maven-doxia] bertysentry commented on pull request #132: [DOXIA-617] support yaml metadata

2023-01-04 Thread GitBox
bertysentry commented on PR #132: URL: https://github.com/apache/maven-doxia/pull/132#issuecomment-1370595428 @hboutemy Fair enough! It's easier to make random suggestions in a PR than actually implementing it. I'll try my own implementation, and if I get something with less code in total,

[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #221: Upgrade Groovy in one of the ITs to support JDK 19

2023-01-04 Thread GitBox
slawekjaranowski commented on PR #221: URL: https://github.com/apache/maven-integration-testing/pull/221#issuecomment-1370593889 > Just thinking out loud: would it make sense to add a Github build running with latest released JDK? So 19 at this moment, and 20 once it gets released (and onc

[GitHub] [maven-integration-testing] slawekjaranowski merged pull request #221: Upgrade Groovy in one of the ITs to support JDK 19

2023-01-03 Thread GitBox
slawekjaranowski merged PR #221: URL: https://github.com/apache/maven-integration-testing/pull/221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issue

[GitHub] [maven-surefire] slawekjaranowski merged pull request #554: [SUREFIRE-2109] Add suffix derived from current user to Surefire temp directory name

2023-01-03 Thread GitBox
slawekjaranowski merged PR #554: URL: https://github.com/apache/maven-surefire/pull/554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [maven] hboutemy commented on a diff in pull request #866: [MNG-7596] Upgrade to plexus 3.5.0

2023-01-03 Thread GitBox
hboutemy commented on code in PR #866: URL: https://github.com/apache/maven/pull/866#discussion_r1061205771 ## maven-xml-impl/src/main/java/org/apache/maven/internal/xml/Xpp3Dom.java: ## @@ -180,8 +181,6 @@ public void writeToSerializer(String namespace, XmlSerializer serialize

[GitHub] [maven-doxia] hboutemy commented on pull request #132: [DOXIA-617] support yaml metadata

2023-01-03 Thread GitBox
hboutemy commented on PR #132: URL: https://github.com/apache/maven-doxia/pull/132#issuecomment-1370556912 I don't get what benefit you get from this complex regexp to add the markers vs the simple marker removal code that keeps all existing code in place without needing to reimplement the

[GitHub] [maven-doxia] hboutemy commented on a diff in pull request #132: [DOXIA-617] support yaml metadata

2023-01-03 Thread GitBox
hboutemy commented on code in PR #132: URL: https://github.com/apache/maven-doxia/pull/132#discussion_r1061185557 ## doxia-modules/doxia-module-markdown/src/test/resources/metadata-yaml.md: ## @@ -0,0 +1,14 @@ +--- +title: A Title & a 'Test' +author: Somebody 'Nickname' Great +

[GitHub] [maven-surefire] slawekjaranowski commented on pull request #554: [SUREFIRE-2109] Add suffix derived from current user to Surefire temp directory name

2023-01-03 Thread GitBox
slawekjaranowski commented on PR #554: URL: https://github.com/apache/maven-surefire/pull/554#issuecomment-1370318893 Looks good enough ... I see one another issue - what when JVM not exit immediately ... like in mvnd - classes are loaded once and can be reused. But it can be next issue

[GitHub] [maven-surefire] slawekjaranowski merged pull request #445: [SUREFIRE-1962] Unit test for ProviderInfo#isApplicable

2023-01-03 Thread GitBox
slawekjaranowski merged PR #445: URL: https://github.com/apache/maven-surefire/pull/445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [maven-wrapper] hazendaz commented on pull request #44: [MWRAPPER-67] Remove invalid line endings from wrapperUrl when used with git bash with mvnw script

2023-01-03 Thread GitBox
hazendaz commented on PR #44: URL: https://github.com/apache/maven-wrapper/pull/44#issuecomment-1370262620 @michael-o Ping, any possibility of this being merged before next release happens? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [maven-integration-testing] psiroky commented on pull request #223: [MNG-7661] Use provided scope for Maven deps in IT plugins

2023-01-03 Thread GitBox
psiroky commented on PR #223: URL: https://github.com/apache/maven-integration-testing/pull/223#issuecomment-1370261138 Once I had these changes done I noticed @slawekjaranowski solved this a bit differently in `maven-enforcer` (https://github.com/apache/maven-enforcer/commit/74228deccd43e

[GitHub] [maven-integration-testing] psiroky commented on a diff in pull request #223: [MNG-7661] Use provided scope for Maven deps in IT plugins

2023-01-03 Thread GitBox
psiroky commented on code in PR #223: URL: https://github.com/apache/maven-integration-testing/pull/223#discussion_r1060979574 ## core-it-support/maven-it-plugin-bootstrap/src/main/java/org/apache/maven/its/bootstrap/DownloadMojo.java: ## @@ -132,7 +131,7 @@ static Dependency t

[GitHub] [maven-integration-testing] psiroky commented on a diff in pull request #223: [MNG-7661] Use provided scope for Maven deps in IT plugins

2023-01-03 Thread GitBox
psiroky commented on code in PR #223: URL: https://github.com/apache/maven-integration-testing/pull/223#discussion_r1060979196 ## core-it-support/core-it-plugins/maven-it-plugin-site/pom.xml: ## @@ -67,6 +68,40 @@ under the License. org.apache.maven.reporting mave

[GitHub] [maven-integration-testing] psiroky commented on a diff in pull request #223: [MNG-7661] Use provided scope for Maven deps in IT plugins

2023-01-03 Thread GitBox
psiroky commented on code in PR #223: URL: https://github.com/apache/maven-integration-testing/pull/223#discussion_r1060978463 ## core-it-support/core-it-plugins/maven-it-plugin-settings/src/main/java/org/apache/maven/plugin/coreit/SettingsReadItMojo.java: ## @@ -59,22 +58,14 @

[GitHub] [maven-integration-testing] psiroky opened a new pull request, #223: [MNG-7661] Use provided scope for Maven deps in IT plugins

2023-01-03 Thread GitBox
psiroky opened a new pull request, #223: URL: https://github.com/apache/maven-integration-testing/pull/223 This fixes these kinds of warnings: ``` [INFO] --- maven-plugin-plugin:3.6.4:descriptor (default-descriptor) @ maven-it-plugin-bootstrap --- [ERROR] Some dependencies of Maven

[GitHub] [maven] hboutemy merged pull request #944: [MNG-7652] switch to Modello Velocity

2023-01-03 Thread GitBox
hboutemy merged PR #944: URL: https://github.com/apache/maven/pull/944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #216: [MENFORCER-455] New Enforcer API

2023-01-03 Thread GitBox
slawekjaranowski commented on code in PR #216: URL: https://github.com/apache/maven-enforcer/pull/216#discussion_r1060884704 ## maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/internal/EnforcerRuleManager.java: ## @@ -25,33 +25,52 @@ import java.util.Arr

[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #216: [MENFORCER-455] New Enforcer API

2023-01-03 Thread GitBox
slawekjaranowski commented on code in PR #216: URL: https://github.com/apache/maven-enforcer/pull/216#discussion_r1060884107 ## maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/internal/EnforcerRuleManager.java: ## @@ -93,6 +112,16 @@ public List createRule

[GitHub] [maven-surefire] slawekjaranowski merged pull request #590: [SUREFIRE-2138] Update Junit4/5 version in docs and ITs

2023-01-03 Thread GitBox
slawekjaranowski merged PR #590: URL: https://github.com/apache/maven-surefire/pull/590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [maven] gnodet merged pull request #946: [MNG-7660] Rename Dom to XmlNode in the v4 api

2023-01-03 Thread GitBox
gnodet merged PR #946: URL: https://github.com/apache/maven/pull/946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

[GitHub] [maven] michael-o commented on a diff in pull request #944: [MNG-7652] switch to Modello Velocity

2023-01-03 Thread GitBox
michael-o commented on code in PR #944: URL: https://github.com/apache/maven/pull/944#discussion_r1060715950 ## api/maven-api-model/pom.xml: ## @@ -63,26 +63,26 @@ under the License. -org.apache.maven -modello-plugin-velocity - -

[GitHub] [maven] hboutemy commented on a diff in pull request #944: [MNG-7652] switch to Modello Velocity

2023-01-03 Thread GitBox
hboutemy commented on code in PR #944: URL: https://github.com/apache/maven/pull/944#discussion_r1060691858 ## api/maven-api-model/pom.xml: ## @@ -63,26 +63,26 @@ under the License. -org.apache.maven -modello-plugin-velocity - -

[GitHub] [maven] hboutemy commented on a diff in pull request #944: [MNG-7652] switch to Modello Velocity

2023-01-03 Thread GitBox
hboutemy commented on code in PR #944: URL: https://github.com/apache/maven/pull/944#discussion_r1060691858 ## api/maven-api-model/pom.xml: ## @@ -63,26 +63,26 @@ under the License. -org.apache.maven -modello-plugin-velocity - -

[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #216: [MENFORCER-455] New Enforcer API

2023-01-03 Thread GitBox
slawekjaranowski commented on code in PR #216: URL: https://github.com/apache/maven-enforcer/pull/216#discussion_r1060686023 ## enforcer-api/src/main/java/org/apache/maven/enforcer/rule/api/AbstractEnforcerRule.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [maven-enforcer] kwin commented on a diff in pull request #216: [MENFORCER-455] New Enforcer API

2023-01-03 Thread GitBox
kwin commented on code in PR #216: URL: https://github.com/apache/maven-enforcer/pull/216#discussion_r1060575511 ## enforcer-api/src/main/java/org/apache/maven/enforcer/rule/api/AbstractEnforcerRule.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [maven-surefire] slawekjaranowski merged pull request #588: [SUREFIRE-2137] Run JUnitPlatform ITs with latest 5.8.x/5.9.x as well

2023-01-03 Thread GitBox
slawekjaranowski merged PR #588: URL: https://github.com/apache/maven-surefire/pull/588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #216: [MENFORCER-455] New Enforcer API

2023-01-03 Thread GitBox
slawekjaranowski commented on code in PR #216: URL: https://github.com/apache/maven-enforcer/pull/216#discussion_r1060550808 ## enforcer-api/src/main/java/org/apache/maven/enforcer/rule/api/AbstractEnforcerRule.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #216: [MENFORCER-455] New Enforcer API

2023-01-03 Thread GitBox
slawekjaranowski commented on code in PR #216: URL: https://github.com/apache/maven-enforcer/pull/216#discussion_r1060542315 ## enforcer-api/src/main/java/org/apache/maven/enforcer/rule/api/AbstractEnforcerRule.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [maven-artifact-transfer] dependabot[bot] commented on pull request #85: Bump apiMaven.version from 3.0 to 3.8.7

2023-01-03 Thread GitBox
dependabot[bot] commented on PR #85: URL: https://github.com/apache/maven-artifact-transfer/pull/85#issuecomment-1369705092 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a

[GitHub] [maven-artifact-transfer] slawekjaranowski closed pull request #85: Bump apiMaven.version from 3.0 to 3.8.7

2023-01-03 Thread GitBox
slawekjaranowski closed pull request #85: Bump apiMaven.version from 3.0 to 3.8.7 URL: https://github.com/apache/maven-artifact-transfer/pull/85 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [maven-artifact-transfer] dependabot[bot] opened a new pull request, #85: Bump apiMaven.version from 3.0 to 3.8.7

2023-01-03 Thread GitBox
dependabot[bot] opened a new pull request, #85: URL: https://github.com/apache/maven-artifact-transfer/pull/85 Bumps `apiMaven.version` from 3.0 to 3.8.7. Updates `maven-core` from 3.0 to 3.8.7 Release notes Sourced from https://github.com/apache/maven/releases";>maven-core's re

[GitHub] [maven-enforcer] kwin commented on a diff in pull request #216: [MENFORCER-455] New Enforcer API

2023-01-03 Thread GitBox
kwin commented on code in PR #216: URL: https://github.com/apache/maven-enforcer/pull/216#discussion_r1060512105 ## enforcer-api/src/main/java/org/apache/maven/enforcer/rule/api/AbstractEnforcerRule.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [maven-surefire] andpab commented on pull request #554: [SUREFIRE-2109] Add suffix derived from current user to Surefire temp directory name

2023-01-03 Thread GitBox
andpab commented on PR #554: URL: https://github.com/apache/maven-surefire/pull/554#issuecomment-1369670644 @olamy Can you merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [maven-surefire] sman-81 commented on pull request #554: [SUREFIRE-2109] Add suffix derived from current user to Surefire temp directory name

2023-01-03 Thread GitBox
sman-81 commented on PR #554: URL: https://github.com/apache/maven-surefire/pull/554#issuecomment-1369647504 This is ready to ship now. Who can merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [maven-pmd-plugin] dependabot[bot] opened a new pull request, #110: Bump release-drafter/release-drafter from 5.21.1 to 5.22.0

2023-01-03 Thread GitBox
dependabot[bot] opened a new pull request, #110: URL: https://github.com/apache/maven-pmd-plugin/pull/110 Bumps [release-drafter/release-drafter](https://github.com/release-drafter/release-drafter) from 5.21.1 to 5.22.0. Release notes Sourced from https://github.com/release-drafte

[GitHub] [maven-wrapper] timtebeek commented on a diff in pull request #61: Switch to JUnit Jupiter

2023-01-03 Thread GitBox
timtebeek commented on code in PR #61: URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1060445903 ## maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java: ## @@ -31,23 +31,23 @@ import java.util.Map; import java.util.Properties

[GitHub] [maven-wrapper] timtebeek commented on a diff in pull request #61: Switch to JUnit Jupiter

2023-01-03 Thread GitBox
timtebeek commented on code in PR #61: URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1060443396 ## maven-wrapper/src/test/java/org/apache/maven/wrapper/WrapperExecutorTest.java: ## @@ -222,27 +226,27 @@ public void testEnvironmentVariableOverwrite_mvnwRepoUrl

[GitHub] [maven-wrapper] bmarwell commented on a diff in pull request #61: Switch to JUnit Jupiter

2023-01-03 Thread GitBox
bmarwell commented on code in PR #61: URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1060406639 ## maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java: ## @@ -31,23 +31,23 @@ import java.util.Map; import java.util.Properties;

[GitHub] [maven-gh-actions-shared] slawekjaranowski merged pull request #64: Bump release-drafter/release-drafter from 5.21.1 to 5.22.0

2023-01-03 Thread GitBox
slawekjaranowski merged PR #64: URL: https://github.com/apache/maven-gh-actions-shared/pull/64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [maven-gh-actions-shared] slawekjaranowski merged pull request #65: Bump release-drafter/release-drafter from 5.21.1 to 5.22.0

2023-01-03 Thread GitBox
slawekjaranowski merged PR #65: URL: https://github.com/apache/maven-gh-actions-shared/pull/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [maven-surefire] andpab commented on a diff in pull request #516: [SUREFIRE-2065] Test Reports Inconsistencies with Parameterized and junit4

2023-01-03 Thread GitBox
andpab commented on code in PR #516: URL: https://github.com/apache/maven-surefire/pull/516#discussion_r1060357685 ## surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java: ## @@ -314,28 +313,26 @@ private String

[GitHub] [maven] gnodet commented on a diff in pull request #944: [MNG-7652] switch to Modello Velocity

2023-01-03 Thread GitBox
gnodet commented on code in PR #944: URL: https://github.com/apache/maven/pull/944#discussion_r1060357689 ## api/pom.xml: ## @@ -45,6 +44,27 @@ api + + + + + org.codehaus.modello + modello-maven-plugin + + +

[GitHub] [maven] gnodet commented on a diff in pull request #944: [MNG-7652] switch to Modello Velocity

2023-01-03 Thread GitBox
gnodet commented on code in PR #944: URL: https://github.com/apache/maven/pull/944#discussion_r1060357689 ## api/pom.xml: ## @@ -45,6 +44,27 @@ api + + + + + org.codehaus.modello + modello-maven-plugin + + +

[GitHub] [maven] michael-o commented on a diff in pull request #944: [MNG-7652] switch to Modello Velocity

2023-01-02 Thread GitBox
michael-o commented on code in PR #944: URL: https://github.com/apache/maven/pull/944#discussion_r1060327463 ## api/pom.xml: ## @@ -45,6 +44,27 @@ api + + + + + org.codehaus.modello + modello-maven-plugin + +

[GitHub] [maven] michael-o commented on a diff in pull request #944: [MNG-7652] switch to Modello Velocity

2023-01-02 Thread GitBox
michael-o commented on code in PR #944: URL: https://github.com/apache/maven/pull/944#discussion_r1060327152 ## api/maven-api-model/pom.xml: ## @@ -63,26 +63,26 @@ under the License. -org.apache.maven -modello-plugin-velocity - -

[GitHub] [maven] michael-o commented on a diff in pull request #944: [MNG-7652] switch to Modello Velocity

2023-01-02 Thread GitBox
michael-o commented on code in PR #944: URL: https://github.com/apache/maven/pull/944#discussion_r1060326967 ## api/maven-api-model/src/main/mdo/model.vm: ## @@ -85,7 +85,7 @@ #end #end // === DO NOT EDIT THIS FILE -// Generate

[GitHub] [maven] hboutemy commented on a diff in pull request #944: [MNG-7652] switch to Modello Velocity

2023-01-02 Thread GitBox
hboutemy commented on code in PR #944: URL: https://github.com/apache/maven/pull/944#discussion_r1060324331 ## api/pom.xml: ## @@ -45,6 +44,27 @@ api + + + + + org.codehaus.modello + modello-maven-plugin + +

[GitHub] [maven] hboutemy commented on a diff in pull request #944: [MNG-7652] switch to Modello Velocity

2023-01-02 Thread GitBox
hboutemy commented on code in PR #944: URL: https://github.com/apache/maven/pull/944#discussion_r1060323593 ## api/maven-api-model/src/main/mdo/model.vm: ## @@ -85,7 +85,7 @@ #end #end // === DO NOT EDIT THIS FILE -// Generated

[GitHub] [maven] hboutemy commented on a diff in pull request #944: [MNG-7652] switch to Modello Velocity

2023-01-02 Thread GitBox
hboutemy commented on code in PR #944: URL: https://github.com/apache/maven/pull/944#discussion_r1060323593 ## api/maven-api-model/src/main/mdo/model.vm: ## @@ -85,7 +85,7 @@ #end #end // === DO NOT EDIT THIS FILE -// Generated

[GitHub] [maven-parent] dependabot[bot] opened a new pull request, #101: Bump spotless-maven-plugin from 2.28.0 to 2.29.0

2023-01-02 Thread GitBox
dependabot[bot] opened a new pull request, #101: URL: https://github.com/apache/maven-parent/pull/101 Bumps [spotless-maven-plugin](https://github.com/diffplug/spotless) from 2.28.0 to 2.29.0. Changelog Sourced from https://github.com/diffplug/spotless/blob/main/CHANGES.md";>spotle

[GitHub] [maven-gh-actions-shared] dependabot[bot] opened a new pull request, #65: Bump release-drafter/release-drafter from 5.21.1 to 5.22.0

2023-01-02 Thread GitBox
dependabot[bot] opened a new pull request, #65: URL: https://github.com/apache/maven-gh-actions-shared/pull/65 Bumps [release-drafter/release-drafter](https://github.com/release-drafter/release-drafter) from 5.21.1 to 5.22.0. Release notes Sourced from https://github.com/release-d

[GitHub] [maven-gh-actions-shared] dependabot[bot] opened a new pull request, #64: Bump release-drafter/release-drafter from 5.21.1 to 5.22.0

2023-01-02 Thread GitBox
dependabot[bot] opened a new pull request, #64: URL: https://github.com/apache/maven-gh-actions-shared/pull/64 Bumps [release-drafter/release-drafter](https://github.com/release-drafter/release-drafter) from 5.21.1 to 5.22.0. Release notes Sourced from https://github.com/release-d

[GitHub] [maven-surefire] olamy closed pull request #565: add jdk 19

2023-01-02 Thread GitBox
olamy closed pull request #565: add jdk 19 URL: https://github.com/apache/maven-surefire/pull/565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues

[GitHub] [maven] gnodet commented on a diff in pull request #944: [MNG-7652] switch to Modello Velocity

2023-01-02 Thread GitBox
gnodet commented on code in PR #944: URL: https://github.com/apache/maven/pull/944#discussion_r1060203571 ## api/maven-api-model/src/main/mdo/model.vm: ## @@ -85,7 +85,7 @@ #end #end // === DO NOT EDIT THIS FILE -// Generated b

[GitHub] [maven-dependency-plugin] dependabot[bot] opened a new pull request, #278: Bump plexus-archiver from 4.6.0 to 4.6.1

2023-01-02 Thread GitBox
dependabot[bot] opened a new pull request, #278: URL: https://github.com/apache/maven-dependency-plugin/pull/278 Bumps [plexus-archiver](https://github.com/codehaus-plexus/plexus-archiver) from 4.6.0 to 4.6.1. Release notes Sourced from https://github.com/codehaus-plexus/plexus-arc

[GitHub] [maven-dependency-plugin] pzygielo commented on pull request #274: Remove unused local variable

2023-01-02 Thread GitBox
pzygielo commented on PR #274: URL: https://github.com/apache/maven-dependency-plugin/pull/274#issuecomment-1369230380 May I ask for review, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven-shade-plugin] dependabot[bot] commented on pull request #172: Bump mavenVersion from 3.1.1 to 3.8.7

2023-01-02 Thread GitBox
dependabot[bot] commented on PR #172: URL: https://github.com/apache/maven-shade-plugin/pull/172#issuecomment-1369177603 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dep

[GitHub] [maven-shade-plugin] slawekjaranowski closed pull request #172: Bump mavenVersion from 3.1.1 to 3.8.7

2023-01-02 Thread GitBox
slawekjaranowski closed pull request #172: Bump mavenVersion from 3.1.1 to 3.8.7 URL: https://github.com/apache/maven-shade-plugin/pull/172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [maven-integration-testing] asfgit closed pull request #220: [MNG-7640] Investigate which ITs really need to set system properties

2023-01-02 Thread GitBox
asfgit closed pull request #220: [MNG-7640] Investigate which ITs really need to set system properties URL: https://github.com/apache/maven-integration-testing/pull/220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [maven-integration-testing] psiroky commented on pull request #221: Upgrade Groovy in one of the ITs to support JDK 19

2023-01-02 Thread GitBox
psiroky commented on PR #221: URL: https://github.com/apache/maven-integration-testing/pull/221#issuecomment-1369147107 Just thinking out loud: would it make sense to add a Github build running with latest released JDK? So 19 at this moment, and 20 once it gets released (and once the build

[GitHub] [maven-wrapper] slawekjaranowski commented on a diff in pull request #61: Switch to JUnit Jupiter

2023-01-02 Thread GitBox
slawekjaranowski commented on code in PR #61: URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1060162000 ## maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java: ## @@ -31,23 +31,23 @@ import java.util.Map; import java.util.Pro

[GitHub] [maven-wrapper] bmarwell commented on a diff in pull request #61: Switch to JUnit Jupiter

2023-01-02 Thread GitBox
bmarwell commented on code in PR #61: URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1060158666 ## maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java: ## @@ -31,23 +31,23 @@ import java.util.Map; import java.util.Properties;

[GitHub] [maven-wrapper] bmarwell commented on a diff in pull request #61: Switch to JUnit Jupiter

2023-01-02 Thread GitBox
bmarwell commented on code in PR #61: URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1060158379 ## maven-wrapper/src/test/java/org/apache/maven/wrapper/WrapperExecutorTest.java: ## @@ -222,27 +226,27 @@ public void testEnvironmentVariableOverwrite_mvnwRepoUrl_

[GitHub] [maven-integration-testing] psiroky commented on pull request #221: Upgrade Groovy in one of the ITs to support JDK 19

2023-01-02 Thread GitBox
psiroky commented on PR #221: URL: https://github.com/apache/maven-integration-testing/pull/221#issuecomment-1369134660 @slawekjaranowski thanks for looking at the PR / approving the workflow (at least I hope it was you). I rebased on top of latest master, which contains your fix to run th

[GitHub] [maven-surefire] andpab commented on pull request #565: add jdk 19

2023-01-02 Thread GitBox
andpab commented on PR #565: URL: https://github.com/apache/maven-surefire/pull/565#issuecomment-1369098737 @olamy The changes from this pull request are [included](https://github.com/apache/maven-surefire/pull/591/commits/92749e3013d2e9bd3de53796fed2b16b8388c4c3) in the pull request #591 f

[GitHub] [maven] gnodet commented on a diff in pull request #944: [MNG-7652] switch to Modello Velocity

2023-01-02 Thread GitBox
gnodet commented on code in PR #944: URL: https://github.com/apache/maven/pull/944#discussion_r1060060788 ## api/maven-api-model/pom.xml: ## @@ -63,26 +63,26 @@ under the License. -org.apache.maven -modello-plugin-velocity - -

[GitHub] [maven-surefire] slawekjaranowski merged pull request #591: [SUREFIRE-2139] Raise plexus-java to 1.1.2 for proper Java 19/20 bytecode support

2023-01-02 Thread GitBox
slawekjaranowski merged PR #591: URL: https://github.com/apache/maven-surefire/pull/591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [maven-doxia] bertysentry commented on pull request #132: [DOXIA-617] support yaml metadata

2023-01-02 Thread GitBox
bertysentry commented on PR #132: URL: https://github.com/apache/maven-doxia/pull/132#issuecomment-1368957114 Actually, the regexp should be: `^\v*((?:[a-zA-Z0-9_\-]+\h*:.*\R)+)\R`. It will match with the header if present. Using Java 8's [Matcher](https://docs.oracle.com/javase/8/do

[GitHub] [maven-artifact-transfer] slawekjaranowski closed pull request #84: Bump apiMaven.version from 3.0 to 3.8.7

2023-01-02 Thread GitBox
slawekjaranowski closed pull request #84: Bump apiMaven.version from 3.0 to 3.8.7 URL: https://github.com/apache/maven-artifact-transfer/pull/84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [maven-artifact-transfer] dependabot[bot] commented on pull request #84: Bump apiMaven.version from 3.0 to 3.8.7

2023-01-02 Thread GitBox
dependabot[bot] commented on PR #84: URL: https://github.com/apache/maven-artifact-transfer/pull/84#issuecomment-1368951234 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a

<    3   4   5   6   7   8   9   10   11   12   >