[GitHub] [maven-pmd-plugin] adangel merged pull request #109: [MPMD-360] - Upgrade to PMD 6.53.0

adangel merged PR #109: URL: https://github.com/apache/maven-pmd-plugin/pull/109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-pmd-plugin] adangel opened a new pull request, #109: [MPMD-360] - Upgrade to PMD 6.53.0

adangel opened a new pull request, #109: URL: https://github.com/apache/maven-pmd-plugin/pull/109 https://issues.apache.org/jira/browse/MPMD-360 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA

[GitHub] [maven-site] elharo opened a new pull request, #360: fix markup

elharo opened a new pull request, #360: URL: https://github.com/apache/maven-site/pull/360 @slawekjaranowski -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [maven] hboutemy merged pull request #830: [MNG-7571] add Maven API javadoc

hboutemy merged PR #830: URL: https://github.com/apache/maven/pull/830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven] hboutemy commented on pull request #830: [MNG-7571] add Maven API javadoc

hboutemy commented on PR #830: URL: https://github.com/apache/maven/pull/830#issuecomment-1368247595 I'll merge this PR regarding basic documentation improvements on the renaming ideas (`Dom` interface to `XmlNode`, `maven-api-meta` to `maven-api-annotations`), we'll do that

[GitHub] [maven] hboutemy opened a new pull request, #944: [MNG-7652] swtich to Modello Velocity

hboutemy opened a new pull request, #944: URL: https://github.com/apache/maven/pull/944 https://issues.apache.org/jira/browse/MNG-7652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-surefire] andpab commented on pull request #591: [SUREFIRE-2139] Raise asm to 9.4 for proper Java 19/20 bytecode support

andpab commented on PR #591: URL: https://github.com/apache/maven-surefire/pull/591#issuecomment-1368237994 Well, it's good I did that, because silly me forgot to add the import scope to the asm-bom dependency at first. Now we should be good. -- This is an automated message from

[GitHub] [maven-surefire] sman-81 commented on a diff in pull request #554: [SUREFIRE-2109] Add suffix derived from current user to Surefire temp directory name and make directory writable for all

sman-81 commented on code in PR #554: URL: https://github.com/apache/maven-surefire/pull/554#discussion_r1059654803 ## surefire-api/src/main/java/org/apache/maven/surefire/api/util/TempFileManager.java: ## @@ -180,6 +180,8 @@ public synchronized File createTempFile( String

[GitHub] [maven-surefire] sman-81 commented on pull request #554: [SUREFIRE-2109] Add suffix derived from current user to Surefire temp directory name and make directory writable for all

sman-81 commented on PR #554: URL: https://github.com/apache/maven-surefire/pull/554#issuecomment-1368229596 Thanks for your input! I'll amend and rebase the PR early next week. Until then: Happy New Year! -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [maven-surefire] andpab commented on a diff in pull request #554: [SUREFIRE-2109] Add suffix derived from current user to Surefire temp directory name and make directory writable for all

andpab commented on code in PR #554: URL: https://github.com/apache/maven-surefire/pull/554#discussion_r1059654222 ## surefire-api/src/main/java/org/apache/maven/surefire/api/util/TempFileManager.java: ## @@ -180,6 +180,8 @@ public synchronized File createTempFile( String

[GitHub] [maven-surefire] cpfeiffer commented on a diff in pull request #554: [SUREFIRE-2109] Add suffix derived from current user to Surefire temp directory name and make directory writable for all

cpfeiffer commented on code in PR #554: URL: https://github.com/apache/maven-surefire/pull/554#discussion_r1059640012 ## surefire-api/src/main/java/org/apache/maven/surefire/api/util/TempFileManager.java: ## @@ -180,6 +180,8 @@ public synchronized File createTempFile( String

[GitHub] [maven-surefire] cpfeiffer commented on a diff in pull request #554: [SUREFIRE-2109] Add suffix derived from current user to Surefire temp directory name and make directory writable for all

cpfeiffer commented on code in PR #554: URL: https://github.com/apache/maven-surefire/pull/554#discussion_r1059640012 ## surefire-api/src/main/java/org/apache/maven/surefire/api/util/TempFileManager.java: ## @@ -180,6 +180,8 @@ public synchronized File createTempFile( String

[GitHub] [maven-surefire] andpab commented on pull request #591: [SUREFIRE-2139] Raise asm to 9.4 for proper Java 19/20 bytecode support

andpab commented on PR #591: URL: https://github.com/apache/maven-surefire/pull/591#issuecomment-1368206317 > We could/should change to use the asm bom. Done. I've also added a commit to replace JDK18 which is EOL by now with JDK19 in the builds, partly to demonstrate that it

[GitHub] [maven-enforcer] slawekjaranowski merged pull request #214: MENFORCER-435: Fixing unit tests

slawekjaranowski merged PR #214: URL: https://github.com/apache/maven-enforcer/pull/214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-resolver] kwin commented on a diff in pull request #232: [MRESOLVER-302] Introduce onSessionClose hooks

kwin commented on code in PR #232: URL: https://github.com/apache/maven-resolver/pull/232#discussion_r1059609246 ## maven-resolver-api/src/main/java/org/eclipse/aether/RepositorySystem.java: ## @@ -302,4 +302,39 @@ List newResolutionRepositories( RepositorySystemSession sessio

[GitHub] [maven-surefire] andpab opened a new pull request, #591: [SUREFIRE-2139] Raise asm to 9.4 for proper Java 19/20 bytecode support

andpab opened a new pull request, #591: URL: https://github.com/apache/maven-surefire/pull/591 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed

[GitHub] [maven-site] michael-o merged pull request #359: Fix formatting to have XML rendered correctly

michael-o merged PR #359: URL: https://github.com/apache/maven-site/pull/359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-site] michael-o merged pull request #357: Fix formatting to have XML rendered correctly

michael-o merged PR #357: URL: https://github.com/apache/maven-site/pull/357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-site] asfgit merged pull request #356: Add release notes for Maven 3.8.7

asfgit merged PR #356: URL: https://github.com/apache/maven-site/pull/356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-surefire] andpab commented on pull request #565: add jdk 19

andpab commented on PR #565: URL: https://github.com/apache/maven-surefire/pull/565#issuecomment-1368091463 I rebased this branch to master locally and ran the ITs. Most of them are successful except for 6 JPMS-related ITs: - MultiModuleProjectWithJPMSIT -

[GitHub] [maven-surefire] andpab commented on a diff in pull request #554: [SUREFIRE-2109] Add suffix derived from current user to Surefire temp directory name and make directory writable for all

andpab commented on code in PR #554: URL: https://github.com/apache/maven-surefire/pull/554#discussion_r1059513138 ## surefire-api/src/main/java/org/apache/maven/surefire/api/util/TempFileManager.java: ## @@ -180,6 +180,8 @@ public synchronized File createTempFile( String

[GitHub] [maven-enforcer] ajarmoniuk commented on a diff in pull request #214: MENFORCER-435: Fixing unit tests

ajarmoniuk commented on code in PR #214: URL: https://github.com/apache/maven-enforcer/pull/214#discussion_r1059493012 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/BannedDependenciesBase.java: ## @@ -20,12 +20,12 @@ import java.util.List; -import

[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #214: MENFORCER-435: Fixing unit tests

slawekjaranowski commented on code in PR #214: URL: https://github.com/apache/maven-enforcer/pull/214#discussion_r1059488879 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/BannedDependenciesBase.java: ## @@ -20,12 +20,12 @@ import java.util.List; -import

[GitHub] [maven-doxia] michael-o commented on pull request #132: [DOXIA-617] support yaml metadata

michael-o commented on PR #132: URL: https://github.com/apache/maven-doxia/pull/132#issuecomment-1368019605 > @hboutemy This is a very good point. It's better to keep backward compatibility as long as it doesn't make our code too complex. > > In this case, we could use a simple

[GitHub] [maven-shade-plugin] pzygielo commented on pull request #171: Update overlapping resources warning

pzygielo commented on PR #171: URL: https://github.com/apache/maven-shade-plugin/pull/171#issuecomment-1367972060 Thanks for checking. Probably just "file" would be even better indeed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [maven-enforcer] slawekjaranowski merged pull request #213: [MENFORCER-445] Include JAVA_HOME location in the Java rule failure messages

slawekjaranowski merged PR #213: URL: https://github.com/apache/maven-enforcer/pull/213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-enforcer] ajarmoniuk commented on pull request #214: MENFORCER-435: Fixing unit tests

ajarmoniuk commented on PR #214: URL: https://github.com/apache/maven-enforcer/pull/214#issuecomment-1367942567 @slawekjaranowski fixes the unit test problems you spotted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [maven-enforcer] ajarmoniuk opened a new pull request, #214: MENFORCER-435: Fixing unit tests

ajarmoniuk opened a new pull request, #214: URL: https://github.com/apache/maven-enforcer/pull/214 Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER) filed

[GitHub] [maven-shade-plugin] pzygielo opened a new pull request, #171: Update overlapping resources warning

pzygielo opened a new pull request, #171: URL: https://github.com/apache/maven-shade-plugin/pull/171 - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) -- This is an automated

[GitHub] [maven-surefire] sman-81 commented on a diff in pull request #554: [SUREFIRE-2109] Add suffix derived from current user to Surefire temp directory name and make directory writable for all

sman-81 commented on code in PR #554: URL: https://github.com/apache/maven-surefire/pull/554#discussion_r1059393355 ## surefire-api/src/main/java/org/apache/maven/surefire/api/util/TempFileManager.java: ## @@ -180,6 +180,8 @@ public synchronized File createTempFile( String

[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #213: [MENFORCER-445] Include JAVA_HOME location in the Java rule failure messages

slawekjaranowski commented on code in PR #213: URL: https://github.com/apache/maven-enforcer/pull/213#discussion_r1059381501 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireJavaVersion.java: ## @@ -76,6 +76,7 @@ public void execute(EnforcerRuleHelper

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #213: [MENFORCER-445] Include JAVA_HOME location in the Java rule failure messages

psiroky commented on code in PR #213: URL: https://github.com/apache/maven-enforcer/pull/213#discussion_r1059372306 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireJavaVersion.java: ## @@ -76,6 +76,7 @@ public void execute(EnforcerRuleHelper helper)

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #213: [MENFORCER-445] Include JAVA_HOME location in the Java rule failure messages

psiroky commented on code in PR #213: URL: https://github.com/apache/maven-enforcer/pull/213#discussion_r1059372306 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireJavaVersion.java: ## @@ -76,6 +76,7 @@ public void execute(EnforcerRuleHelper helper)

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #213: [MENFORCER-445] Include JAVA_HOME location in the Java rule failure messages

psiroky commented on code in PR #213: URL: https://github.com/apache/maven-enforcer/pull/213#discussion_r1059372306 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireJavaVersion.java: ## @@ -76,6 +76,7 @@ public void execute(EnforcerRuleHelper helper)

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #213: [MENFORCER-445] Include JAVA_HOME location in the Java rule failure messages

psiroky commented on code in PR #213: URL: https://github.com/apache/maven-enforcer/pull/213#discussion_r1059372306 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireJavaVersion.java: ## @@ -76,6 +76,7 @@ public void execute(EnforcerRuleHelper helper)

[GitHub] [maven-doxia] bertysentry commented on pull request #132: [DOXIA-617] support yaml metadata

bertysentry commented on PR #132: URL: https://github.com/apache/maven-doxia/pull/132#issuecomment-1367895354 @hboutemy This is a very good point. It's better to keep backward compatibility as long as it doesn't make our code too complex. In this case, we could use a simple replace

[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #213: [MENFORCER-445] Include JAVA_HOME location in the Java rule failure messages

slawekjaranowski commented on code in PR #213: URL: https://github.com/apache/maven-enforcer/pull/213#discussion_r1059370417 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireJavaVersion.java: ## @@ -76,6 +76,7 @@ public void execute(EnforcerRuleHelper

[GitHub] [maven] hboutemy commented on pull request #942: [MNG-7655] maven-plexus-utils and maven-plexus-utils-xml (xml-impl)

hboutemy commented on PR #942: URL: https://github.com/apache/maven/pull/942#issuecomment-1367816557 ok, launching some feedback on the Maven dev ML for plexus-xml: this looks simple and wold make things much cleaner = Plexus plexus-utils 4 is used as is (and eventually migrated away), and

[GitHub] [maven-doxia-converter] kwin commented on pull request #32: [DOXIATOOLS-73] Drop support for Converting Confluence documents

kwin commented on PR #32: URL: https://github.com/apache/maven-doxia-converter/pull/32#issuecomment-1367815612 @michael-o @slachiewicz Given that there will be a new release for https://issues.apache.org/jira/browse/DOXIATOOLS-74 should we reopen and merge? -- This is an automated

[GitHub] [maven-enforcer] slawekjaranowski commented on pull request #202: [MENFORCER-435] Remove not needed maven-dependency-tree and maven-compat

slawekjaranowski commented on PR #202: URL: https://github.com/apache/maven-enforcer/pull/202#issuecomment-1367813010 It is valid questions. I added comments on commit ... https://github.com/apache/maven-enforcer/commit/919fe02a0fe92a055a6e24dff04fb9c7618954f4 -- This is an

[GitHub] [maven-resolver] kwin commented on a diff in pull request #232: [MRESOLVER-302] Introduce onSessionClose hooks

kwin commented on code in PR #232: URL: https://github.com/apache/maven-resolver/pull/232#discussion_r1059306441 ## maven-resolver-api/src/main/java/org/eclipse/aether/RepositorySystem.java: ## @@ -302,4 +302,39 @@ List newResolutionRepositories( RepositorySystemSession sessio

[GitHub] [maven-enforcer] ajarmoniuk commented on pull request #202: [MENFORCER-435] Remove not needed maven-dependency-tree and maven-compat

ajarmoniuk commented on PR #202: URL: https://github.com/apache/maven-enforcer/pull/202#issuecomment-1367811899 Can't see them anywhere. I only got a notification about new comments, but there were nowhere to be seen. -- This is an automated message from the Apache Git Service. To

[GitHub] [maven-enforcer] ajarmoniuk commented on pull request #202: [MENFORCER-435] Remove not needed maven-dependency-tree and maven-compat

ajarmoniuk commented on PR #202: URL: https://github.com/apache/maven-enforcer/pull/202#issuecomment-1367811069 > [@ajarmoniuk](https://github.com/ajarmoniuk) - can you check it, looks strange > I also afraid that IT test - require-release-dependencies check nothing - there is no

[GitHub] [maven-enforcer] slawekjaranowski commented on pull request #202: [MENFORCER-435] Remove not needed maven-dependency-tree and maven-compat

slawekjaranowski commented on PR #202: URL: https://github.com/apache/maven-enforcer/pull/202#issuecomment-1367809795 Which comments? I don't remember to remove something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [maven] hboutemy commented on pull request #942: [MNG-7655] maven-plexus-utils and maven-plexus-utils-xml (xml-impl)

hboutemy commented on PR #942: URL: https://github.com/apache/maven/pull/942#issuecomment-1367796459 oh, back to plexus-utils https://codehaus-plexus.github.io/plexus-utils/ vs maven-shared-utils https://maven.apache.org/shared/maven-shared-utils/ discussion I suppose we can split

[GitHub] [maven] rmannibucau commented on pull request #942: [MNG-7655] maven-plexus-utils and maven-plexus-utils-xml (xml-impl)

rmannibucau commented on PR #942: URL: https://github.com/apache/maven/pull/942#issuecomment-1367794025 +1 for maven to ingest used plexus classes rather than working on plexus off radars for the long term (probably lazily, ie each time we need a change we rather import the lib instead of

[GitHub] [maven] hboutemy commented on pull request #942: [MNG-7655] maven-plexus-utils and maven-plexus-utils-xml (xml-impl)

hboutemy commented on PR #942: URL: https://github.com/apache/maven/pull/942#issuecomment-1367793268 yes, splitting Plexus' plexus-utils 4.0.0 https://github.com/codehaus-plexus/plexus-utils into plexus-xml + plexus-utils makes sense because AFAIK Maven core exports plexus-xml only, not

[GitHub] [maven] hboutemy commented on a diff in pull request #942: [MNG-7655] maven-plexus-utils and maven-plexus-utils-xml (xml-impl)

hboutemy commented on code in PR #942: URL: https://github.com/apache/maven/pull/942#discussion_r1059289711 ## maven-plexus-utils-xml/pom.xml: ## @@ -25,9 +25,10 @@ under the License. 4.0.0-alpha-4-SNAPSHOT - maven-xml-impl + maven-plexus-utils-xml - Maven XML

[GitHub] [maven] pavelhoral opened a new pull request, #943: [MNG-7648] Fix locationTracking in DefaultModelBuildingRequest copy constructor

pavelhoral opened a new pull request, #943: URL: https://github.com/apache/maven/pull/943 This is backport / cherry-pick of #940. -- Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #213: [MENFORCER-445] Include JAVA_HOME location in the Java rule failure messages

psiroky commented on code in PR #213: URL: https://github.com/apache/maven-enforcer/pull/213#discussion_r1059280780 ## enforcer-rules/src/test/java/org/apache/maven/plugins/enforcer/TestRequireJavaVersion.java: ## @@ -89,30 +88,36 @@ void

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #213: [MENFORCER-445] Include JAVA_HOME location in the Java rule failure messages

psiroky commented on code in PR #213: URL: https://github.com/apache/maven-enforcer/pull/213#discussion_r1059280557 ## enforcer-rules/src/test/java/org/apache/maven/plugins/enforcer/TestRequireJavaVendor.java: ## @@ -56,25 +54,33 @@ public void matchingInclude() throws

[GitHub] [maven-enforcer] psiroky opened a new pull request, #213: [MENFORCER-445] Include JAVA_HOME location in the Java rule failure messages

psiroky opened a new pull request, #213: URL: https://github.com/apache/maven-enforcer/pull/213 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER) filed

[GitHub] [maven-enforcer] slawekjaranowski merged pull request #212: [MENFORCER-454] Log warning only if the '-Drules' is actually used

slawekjaranowski merged PR #212: URL: https://github.com/apache/maven-enforcer/pull/212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-enforcer] slawekjaranowski commented on pull request #212: [MENFORCER-454] Log warning only if the '-Drules' is actually used

slawekjaranowski commented on PR #212: URL: https://github.com/apache/maven-enforcer/pull/212#issuecomment-1367603881  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [maven-enforcer] psiroky opened a new pull request, #212: [MENFORCER-454] Log warning only if the '-Drules' is actually used

psiroky opened a new pull request, #212: URL: https://github.com/apache/maven-enforcer/pull/212 * the method gets called with empty list if there is no configuration, resulting in WARNing being printed every single time. * it somehow slipped in and I only noticed this after merging the

[GitHub] [maven-enforcer] ajarmoniuk commented on pull request #202: [MENFORCER-435] Remove not needed maven-dependency-tree and maven-compat

ajarmoniuk commented on PR #202: URL: https://github.com/apache/maven-enforcer/pull/202#issuecomment-1367593219 Did you remove your comments from this PR? I can only see them in my email. Are they still valid? @slawekjaranowski -- This is an automated message from the Apache Git

[GitHub] [maven-surefire] andpab commented on pull request #590: [SUREFIRE-2138] Update Junit4/5 version in docs and ITs

andpab commented on PR #590: URL: https://github.com/apache/maven-surefire/pull/590#issuecomment-1367590484 The IT failure on macOS with jdk17 seems to be unrelated. It's Surefire1179IT which is a TestNG test that should be entirely unaffected by my changes. Probably a flaky test of sorts.

[GitHub] [maven] michael-o commented on a diff in pull request #830: [MNG-7571] add Maven API javadoc

michael-o commented on code in PR #830: URL: https://github.com/apache/maven/pull/830#discussion_r1059151429 ## plexus-utils/pom.xml: ## @@ -28,6 +28,8 @@ under the License. org.apache.maven plexus-utils 4.0.0-alpha-4-SNAPSHOT + Apache Maven Plexus-Utils + Apache

[GitHub] [maven] gnodet commented on a diff in pull request #830: [MNG-7571] add Maven API javadoc

gnodet commented on code in PR #830: URL: https://github.com/apache/maven/pull/830#discussion_r1059151219 ## maven-xml-impl/pom.xml: ## @@ -26,8 +26,8 @@ under the License. maven-xml-impl - - Maven XML Implementation + Implementation of Maven API XML Review Comment:

[GitHub] [maven] gnodet commented on a diff in pull request #830: [MNG-7571] add Maven API javadoc

gnodet commented on code in PR #830: URL: https://github.com/apache/maven/pull/830#discussion_r1059150836 ## plexus-utils/pom.xml: ## @@ -28,6 +28,8 @@ under the License. org.apache.maven plexus-utils 4.0.0-alpha-4-SNAPSHOT + Apache Maven Plexus-Utils + Apache Maven

[GitHub] [maven] gnodet commented on a diff in pull request #830: [MNG-7571] add Maven API javadoc

gnodet commented on code in PR #830: URL: https://github.com/apache/maven/pull/830#discussion_r1059149603 ## api/maven-api-xml/pom.xml: ## @@ -27,7 +27,8 @@ maven-api-xml - Maven API XML + Maven 4 API XML Review Comment: It's not helpers, it contains a single

[GitHub] [maven] gnodet commented on a diff in pull request #830: [MNG-7571] add Maven API javadoc

gnodet commented on code in PR #830: URL: https://github.com/apache/maven/pull/830#discussion_r1059147903 ## api/maven-api-settings/pom.xml: ## @@ -28,8 +28,8 @@ under the License. maven-api-settings - Maven API Settings - Maven API Settings model. + Maven 4 API -

[GitHub] [maven] michael-o commented on a diff in pull request #942: [MNG-7655] maven-plexus-utils and maven-plexus-utils-xml (xml-impl)

michael-o commented on code in PR #942: URL: https://github.com/apache/maven/pull/942#discussion_r1059146353 ## maven-plexus-utils-xml/pom.xml: ## @@ -25,9 +25,10 @@ under the License. 4.0.0-alpha-4-SNAPSHOT - maven-xml-impl + maven-plexus-utils-xml - Maven XML

[GitHub] [maven] asfgit closed pull request #939: [MNG-7651] Simplify and document merge of maven.config file and CLI args

asfgit closed pull request #939: [MNG-7651] Simplify and document merge of maven.config file and CLI args URL: https://github.com/apache/maven/pull/939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven-surefire] andpab commented on pull request #580: Bump javassist from 3.29.0-GA to 3.29.2-GA

andpab commented on PR #580: URL: https://github.com/apache/maven-surefire/pull/580#issuecomment-1367573102 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [maven-surefire] andpab commented on pull request #569: Bump log4j-core from 2.13.1 to 2.17.1 in /surefire-its/src/test/resources/surefire-1659-stream-corruption

andpab commented on PR #569: URL: https://github.com/apache/maven-surefire/pull/569#issuecomment-1367572160 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [maven-surefire] andpab commented on pull request #551: Bump commons-email from 1.2 to 1.5 in /surefire-its/src/test/resources/classpath-filtering

andpab commented on PR #551: URL: https://github.com/apache/maven-surefire/pull/551#issuecomment-1367571490 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [maven] michael-o commented on pull request #942: [MNG-7655] maven-plexus-utils and maven-plexus-utils-xml (xml-impl)

michael-o commented on PR #942: URL: https://github.com/apache/maven/pull/942#issuecomment-1367568863 > Actually, a LOT of plexus should be ingested by maven stuff (as it is unused anywhere else), think compiler, think archiver, etc -- we must collapse these, as it is nightmare and just

[GitHub] [maven-enforcer] slawekjaranowski merged pull request #211: [MENFORCER-454] Deprecate 'rules' property and introduce 'enforcer.rules' as a replacement

slawekjaranowski merged PR #211: URL: https://github.com/apache/maven-enforcer/pull/211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #211: [MENFORCER-454] Deprecate 'rules' property and introduce 'enforcer.rules' as a replacement

slawekjaranowski commented on code in PR #211: URL: https://github.com/apache/maven-enforcer/pull/211#discussion_r1059133637 ## maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java: ## @@ -153,6 +147,36 @@ public class EnforceMojo extends

[GitHub] [maven] cstamas commented on pull request #942: [MNG-7655] maven-plexus-utils and maven-plexus-utils-xml (xml-impl)

cstamas commented on PR #942: URL: https://github.com/apache/maven/pull/942#issuecomment-1367566306 Actually, a LOT of plexus should be ingested by maven stuff (as it is unused anywhere else), think compiler, think archiver, etc -- This is an automated message from the Apache Git

[GitHub] [maven] cstamas commented on pull request #942: [MNG-7655] maven-plexus-utils and maven-plexus-utils-xml (xml-impl)

cstamas commented on PR #942: URL: https://github.com/apache/maven/pull/942#issuecomment-1367565802 +1 for 3rd option -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [maven] michael-o commented on pull request #942: [MNG-7655] maven-plexus-utils and maven-plexus-utils-xml (xml-impl)

michael-o commented on PR #942: URL: https://github.com/apache/maven/pull/942#issuecomment-1367565521 Why not move out the XML stuff to `plexus-xml`? Plexus Utils is just too large. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [maven] gnodet commented on pull request #942: [MNG-7655] maven-plexus-utils and maven-plexus-utils-xml (xml-impl)

gnodet commented on PR #942: URL: https://github.com/apache/maven/pull/942#issuecomment-1367565090 > https://issues.apache.org/jira/browse/MNG-7655 > > keeping `plexus-utils` artifactId with `org.apache.maven` vs `org.codehaus.plexus` groupId is confusing: let's name it

[GitHub] [maven-enforcer] psiroky commented on pull request #211: [MENFORCER-454] Deprecate 'rules' property and introduce 'enforcer.rules' as a replacement

psiroky commented on PR #211: URL: https://github.com/apache/maven-enforcer/pull/211#issuecomment-1367538126 @slawekjaranowski I applied your suggestions (hopefully correctly). I also added a `warn` log when using the old property. Please take another look when you get a chance. -- This

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #211: [MENFORCER-454] Deprecate 'rules' property and introduce 'enforcer.rules' as a replacement

psiroky commented on code in PR #211: URL: https://github.com/apache/maven-enforcer/pull/211#discussion_r1059116774 ## maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java: ## @@ -127,10 +127,12 @@ public class EnforceMojo extends AbstractMojo

[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #211: [MENFORCER-454] Deprecate 'rules' property and introduce 'enforcer.rules' as a replacement

slawekjaranowski commented on code in PR #211: URL: https://github.com/apache/maven-enforcer/pull/211#discussion_r1059115421 ## maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java: ## @@ -127,10 +127,12 @@ public class EnforceMojo extends

[GitHub] [maven-surefire] andpab opened a new pull request, #590: [SUREFIRE-2138] Update Junit4/5 version in docs and ITs

andpab opened a new pull request, #590: URL: https://github.com/apache/maven-surefire/pull/590 - Update JUnit versions referenced in configuration examples to 4.13.2 and 5.9.1, the respective latest versions - Add 4.13.1 and 4.13.2 to JUnitVersion and JUnit4VersionsIT - Use 4.13.2

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #211: [MENFORCER-454] Deprecate 'rules' property and introduce 'enforcer.rules' as a replacement

psiroky commented on code in PR #211: URL: https://github.com/apache/maven-enforcer/pull/211#discussion_r1059098261 ## maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java: ## @@ -127,10 +127,12 @@ public class EnforceMojo extends AbstractMojo

[GitHub] [maven-doxia] hboutemy commented on pull request #128: DOXIA-569 add Markdown output (sink)

hboutemy commented on PR #128: URL: https://github.com/apache/maven-doxia/pull/128#issuecomment-1367501098 merged in master in df9353869e6031987533ec2f288eede1f945728a -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #211: [MENFORCER-454] Deprecate 'rules' property and introduce 'enforcer.rules' as a replacement

slawekjaranowski commented on code in PR #211: URL: https://github.com/apache/maven-enforcer/pull/211#discussion_r1059087768 ## maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java: ## @@ -153,6 +155,25 @@ public class EnforceMojo extends

[GitHub] [maven-doxia] hboutemy closed pull request #128: DOXIA-569 add Markdown output (sink)

hboutemy closed pull request #128: DOXIA-569 add Markdown output (sink) URL: https://github.com/apache/maven-doxia/pull/128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [maven-doxia] hboutemy commented on pull request #128: DOXIA-569 add Markdown output (sink)

hboutemy commented on PR #128: URL: https://github.com/apache/maven-doxia/pull/128#issuecomment-1367493126 merged in Doxia 1.x in b174a89b270a12e5871ddaf97c3e39594f284c79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #211: [MENFORCER-454] Deprecate 'rules' property and introduce 'enforcer.rules' as a replacement

psiroky commented on code in PR #211: URL: https://github.com/apache/maven-enforcer/pull/211#discussion_r1059071349 ## maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java: ## @@ -153,6 +155,25 @@ public class EnforceMojo extends AbstractMojo {

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #211: [MENFORCER-454] Deprecate 'rules' property and introduce 'enforcer.rules' as a replacement

psiroky commented on code in PR #211: URL: https://github.com/apache/maven-enforcer/pull/211#discussion_r1059069991 ## maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java: ## @@ -127,11 +127,22 @@ public class EnforceMojo extends AbstractMojo

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #211: [MENFORCER-454] Deprecate 'rules' property and introduce 'enforcer.rules' as a replacement

psiroky commented on code in PR #211: URL: https://github.com/apache/maven-enforcer/pull/211#discussion_r1059056951 ## maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java: ## @@ -127,11 +127,22 @@ public class EnforceMojo extends AbstractMojo

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #211: [MENFORCER-454] Deprecate 'rules' property and introduce 'enforcer.rules' as a replacement

psiroky commented on code in PR #211: URL: https://github.com/apache/maven-enforcer/pull/211#discussion_r1059056748 ## maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java: ## @@ -127,11 +127,22 @@ public class EnforceMojo extends AbstractMojo

[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #211: [MENFORCER-454] Deprecate 'rules' property and introduce 'enforcer.rules' as a replacement

slawekjaranowski commented on code in PR #211: URL: https://github.com/apache/maven-enforcer/pull/211#discussion_r1059047291 ## maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java: ## @@ -127,11 +127,22 @@ public class EnforceMojo extends

[GitHub] [maven-doxia] michael-o commented on a diff in pull request #128: DOXIA-569 add Markdown output (sink)

michael-o commented on code in PR #128: URL: https://github.com/apache/maven-doxia/pull/128#discussion_r1059036758 ## doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownMarkup.java: ## @@ -0,0 +1,144 @@ +package

[GitHub] [maven-enforcer] psiroky opened a new pull request, #211: [MENFORCER-454] Deprecate 'rules' property and introduce 'enforcer.rules' as a replacement

psiroky opened a new pull request, #211: URL: https://github.com/apache/maven-enforcer/pull/211 This aligns the property names to us the `enforcer.` prefix. Also updated the ITs to verify the rules are indeed getting fully replaced with the list from the property Following

[GitHub] [maven-doxia] hboutemy commented on a diff in pull request #128: DOXIA-569 add Markdown output (sink)

hboutemy commented on code in PR #128: URL: https://github.com/apache/maven-doxia/pull/128#discussion_r1059032524 ## doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownMarkup.java: ## @@ -0,0 +1,144 @@ +package

[GitHub] [maven] hboutemy opened a new pull request, #942: [MNG-7655] maven-plexus-utils and maven-plexus-utils-xml (xml-impl)

hboutemy opened a new pull request, #942: URL: https://github.com/apache/maven/pull/942 https://issues.apache.org/jira/browse/MNG-7655 keeping `plexus-utils` artifactId with `org.apache.maven` vs `org.codehaus.plexus` groupId is confusing: let's name it `maven-plexus-utils`

[GitHub] [maven-doxia] michael-o commented on pull request #134: Bump flexmarkVersion from 0.62.2 to 0.64.0

michael-o commented on PR #134: URL: https://github.com/apache/maven-doxia/pull/134#issuecomment-1367400991 > wow, so it went Java 11 between 0.62 and 0.64? wow Yes, that is total bullshit development. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven-doxia] cstamas commented on pull request #134: Bump flexmarkVersion from 0.62.2 to 0.64.0

cstamas commented on PR #134: URL: https://github.com/apache/maven-doxia/pull/134#issuecomment-1367399384 wow, so it went Java 11 between 0.62 and 0.64? wow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [maven-doxia] michael-o commented on pull request #134: Bump flexmarkVersion from 0.62.2 to 0.64.0

michael-o commented on PR #134: URL: https://github.com/apache/maven-doxia/pull/134#issuecomment-1367396206 > > Can't be done. > > Just out of curiosity, why? One of the reasons I consider these bots totally useless:

[GitHub] [maven-doxia] cstamas commented on pull request #134: Bump flexmarkVersion from 0.62.2 to 0.64.0

cstamas commented on PR #134: URL: https://github.com/apache/maven-doxia/pull/134#issuecomment-1367393699 > Can't be done. Just out of curiosity, why? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [maven-doxia] michael-o commented on pull request #132: [DOXIA-617] support yaml metadata

michael-o commented on PR #132: URL: https://github.com/apache/maven-doxia/pull/132#issuecomment-1367391412 > if we use the parsing API for YAML form of metadata, it means we stop supporting metadata without the `---` delimiters > > is it really what you all want? This would

[GitHub] [maven-doxia] dependabot[bot] commented on pull request #134: Bump flexmarkVersion from 0.62.2 to 0.64.0

dependabot[bot] commented on PR #134: URL: https://github.com/apache/maven-doxia/pull/134#issuecomment-1367389466 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency

[GitHub] [maven-doxia] michael-o closed pull request #134: Bump flexmarkVersion from 0.62.2 to 0.64.0

michael-o closed pull request #134: Bump flexmarkVersion from 0.62.2 to 0.64.0 URL: https://github.com/apache/maven-doxia/pull/134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [maven-doxia] michael-o commented on pull request #134: Bump flexmarkVersion from 0.62.2 to 0.64.0

michael-o commented on PR #134: URL: https://github.com/apache/maven-doxia/pull/134#issuecomment-1367389436 Can't be done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

<    5   6   7   8   9   10   11   12   13   14   >