slawekjaranowski closed pull request #85: Bump apiMaven.version from 3.0 to
3.8.7
URL: https://github.com/apache/maven-artifact-transfer/pull/85
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
dependabot[bot] commented on PR #85:
URL:
https://github.com/apache/maven-artifact-transfer/pull/85#issuecomment-1369705092
OK, I won't notify you again about this release, but will get in touch when
a new version is available. You can also ignore all major, minor, or patch
releases for a
slawekjaranowski commented on code in PR #216:
URL: https://github.com/apache/maven-enforcer/pull/216#discussion_r1060542315
##
enforcer-api/src/main/java/org/apache/maven/enforcer/rule/api/AbstractEnforcerRule.java:
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Fo
slawekjaranowski commented on code in PR #216:
URL: https://github.com/apache/maven-enforcer/pull/216#discussion_r1060550808
##
enforcer-api/src/main/java/org/apache/maven/enforcer/rule/api/AbstractEnforcerRule.java:
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Fo
slawekjaranowski merged PR #588:
URL: https://github.com/apache/maven-surefire/pull/588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
kwin commented on code in PR #216:
URL: https://github.com/apache/maven-enforcer/pull/216#discussion_r1060575511
##
enforcer-api/src/main/java/org/apache/maven/enforcer/rule/api/AbstractEnforcerRule.java:
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
slawekjaranowski commented on code in PR #216:
URL: https://github.com/apache/maven-enforcer/pull/216#discussion_r1060686023
##
enforcer-api/src/main/java/org/apache/maven/enforcer/rule/api/AbstractEnforcerRule.java:
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Fo
hboutemy commented on code in PR #944:
URL: https://github.com/apache/maven/pull/944#discussion_r1060691858
##
api/maven-api-model/pom.xml:
##
@@ -63,26 +63,26 @@ under the License.
-org.apache.maven
-modello-plugin-velocity
-
-
hboutemy commented on code in PR #944:
URL: https://github.com/apache/maven/pull/944#discussion_r1060691858
##
api/maven-api-model/pom.xml:
##
@@ -63,26 +63,26 @@ under the License.
-org.apache.maven
-modello-plugin-velocity
-
-
michael-o commented on code in PR #944:
URL: https://github.com/apache/maven/pull/944#discussion_r1060715950
##
api/maven-api-model/pom.xml:
##
@@ -63,26 +63,26 @@ under the License.
-org.apache.maven
-modello-plugin-velocity
-
-
gnodet merged PR #946:
URL: https://github.com/apache/maven/pull/946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
slawekjaranowski merged PR #590:
URL: https://github.com/apache/maven-surefire/pull/590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
slawekjaranowski commented on code in PR #216:
URL: https://github.com/apache/maven-enforcer/pull/216#discussion_r1060884107
##
maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/internal/EnforcerRuleManager.java:
##
@@ -93,6 +112,16 @@ public List
createRule
slawekjaranowski commented on code in PR #216:
URL: https://github.com/apache/maven-enforcer/pull/216#discussion_r1060884704
##
maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/internal/EnforcerRuleManager.java:
##
@@ -25,33 +25,52 @@
import java.util.Arr
hboutemy merged PR #944:
URL: https://github.com/apache/maven/pull/944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o
psiroky opened a new pull request, #223:
URL: https://github.com/apache/maven-integration-testing/pull/223
This fixes these kinds of warnings:
```
[INFO] --- maven-plugin-plugin:3.6.4:descriptor (default-descriptor) @
maven-it-plugin-bootstrap ---
[ERROR] Some dependencies of Maven
psiroky commented on code in PR #223:
URL:
https://github.com/apache/maven-integration-testing/pull/223#discussion_r1060978463
##
core-it-support/core-it-plugins/maven-it-plugin-settings/src/main/java/org/apache/maven/plugin/coreit/SettingsReadItMojo.java:
##
@@ -59,22 +58,14 @
psiroky commented on code in PR #223:
URL:
https://github.com/apache/maven-integration-testing/pull/223#discussion_r1060979196
##
core-it-support/core-it-plugins/maven-it-plugin-site/pom.xml:
##
@@ -67,6 +68,40 @@ under the License.
org.apache.maven.reporting
mave
psiroky commented on code in PR #223:
URL:
https://github.com/apache/maven-integration-testing/pull/223#discussion_r1060979574
##
core-it-support/maven-it-plugin-bootstrap/src/main/java/org/apache/maven/its/bootstrap/DownloadMojo.java:
##
@@ -132,7 +131,7 @@ static Dependency t
psiroky commented on PR #223:
URL:
https://github.com/apache/maven-integration-testing/pull/223#issuecomment-1370261138
Once I had these changes done I noticed @slawekjaranowski solved this a bit
differently in `maven-enforcer`
(https://github.com/apache/maven-enforcer/commit/74228deccd43e
hazendaz commented on PR #44:
URL: https://github.com/apache/maven-wrapper/pull/44#issuecomment-1370262620
@michael-o Ping, any possibility of this being merged before next release
happens?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
slawekjaranowski merged PR #445:
URL: https://github.com/apache/maven-surefire/pull/445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
slawekjaranowski commented on PR #554:
URL: https://github.com/apache/maven-surefire/pull/554#issuecomment-1370318893
Looks good enough ...
I see one another issue - what when JVM not exit immediately ... like in
mvnd - classes are loaded once and can be reused. But it can be next issue
hboutemy commented on code in PR #132:
URL: https://github.com/apache/maven-doxia/pull/132#discussion_r1061185557
##
doxia-modules/doxia-module-markdown/src/test/resources/metadata-yaml.md:
##
@@ -0,0 +1,14 @@
+---
+title: A Title & a 'Test'
+author: Somebody 'Nickname' Great
+
hboutemy commented on PR #132:
URL: https://github.com/apache/maven-doxia/pull/132#issuecomment-1370556912
I don't get what benefit you get from this complex regexp to add the markers
vs the simple marker removal code that keeps all existing code in place without
needing to reimplement the
hboutemy commented on code in PR #866:
URL: https://github.com/apache/maven/pull/866#discussion_r1061205771
##
maven-xml-impl/src/main/java/org/apache/maven/internal/xml/Xpp3Dom.java:
##
@@ -180,8 +181,6 @@ public void writeToSerializer(String namespace,
XmlSerializer serialize
slawekjaranowski merged PR #554:
URL: https://github.com/apache/maven-surefire/pull/554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
slawekjaranowski merged PR #221:
URL: https://github.com/apache/maven-integration-testing/pull/221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issue
slawekjaranowski commented on PR #221:
URL:
https://github.com/apache/maven-integration-testing/pull/221#issuecomment-1370593889
> Just thinking out loud: would it make sense to add a Github build running
with latest released JDK? So 19 at this moment, and 20 once it gets released
(and onc
bertysentry commented on PR #132:
URL: https://github.com/apache/maven-doxia/pull/132#issuecomment-1370595428
@hboutemy Fair enough! It's easier to make random suggestions in a PR than
actually implementing it. I'll try my own implementation, and if I get
something with less code in total,
gnodet commented on code in PR #866:
URL: https://github.com/apache/maven/pull/866#discussion_r1061225506
##
maven-xml-impl/src/main/java/org/apache/maven/internal/xml/Xpp3Dom.java:
##
@@ -180,8 +181,6 @@ public void writeToSerializer(String namespace,
XmlSerializer serializer)
gnodet opened a new pull request, #947:
URL: https://github.com/apache/maven/pull/947
Revert "[MNG-7505] Remove ReportingConverter (#906)"
This reverts commit adf89ef63ffca07e490f5cc550f9411bad1a7bd6.
Following this checklist to help us incorporate your
contribution quickly and e
andpab commented on code in PR #387:
URL: https://github.com/apache/maven-surefire/pull/387#discussion_r1059803389
##
surefire-booter/src/test/java/org/apache/maven/surefire/booter/SystemUtilsTest.java:
##
@@ -98,6 +98,15 @@ public void incorrectJdkPath()
assertThat
andpab commented on PR #387:
URL: https://github.com/apache/maven-surefire/pull/387#issuecomment-1370776730
@CMoH are you available to make the requested changes to the tests?
Otherwise I can also make a new pull request.
--
This is an automated message from the Apache Git Service.
To res
pzygielo commented on code in PR #947:
URL: https://github.com/apache/maven/pull/947#discussion_r1061375606
##
maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java:
##
@@ -625,6 +626,15 @@ public DefaultModelBuilder
setProfileActivationFile
pzygielo commented on PR #947:
URL: https://github.com/apache/maven/pull/947#issuecomment-1370802637
Not sure about _Restore compatibility_.
This just restores as no-op methods. If flatten called them - didn't it do
it for some purpose?
Will flatten behave as expected or just not throw
gnodet commented on PR #947:
URL: https://github.com/apache/maven/pull/947#issuecomment-1370845771
> Not sure about _Restore compatibility_. This just restores as no-op
methods. If flatten called them - didn't it do it for some purpose? Will
flatten behave as expected or just not throw API
gnodet commented on code in PR #947:
URL: https://github.com/apache/maven/pull/947#discussion_r1061415474
##
maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java:
##
@@ -625,6 +626,15 @@ public DefaultModelBuilder
setProfileActivationFilePa
pzygielo commented on PR #947:
URL: https://github.com/apache/maven/pull/947#issuecomment-1370861376
So it will be passed in
https://github.com/apache/maven/blob/aab448546326da99fd8f2fc5d15ff08dd79bae8e/src/main/java/org/codehaus/mojo/flatten/ModelBuilderThreadSafetyWorkaround.java#L131
pzygielo commented on PR #947:
URL: https://github.com/apache/maven/pull/947#issuecomment-1370872944
I think I can see that now.
Thanks @gnodet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
gnodet commented on PR #947:
URL: https://github.com/apache/maven/pull/947#issuecomment-1370889590
> I think I can see that now.
> Thanks @gnodet.
Yes, it's really just for binary compatibility with the existing stuff.
--
This is an automated message from the Apache Git Service.
tisonkun commented on PR #45:
URL:
https://github.com/apache/maven-shared-utils/pull/45#issuecomment-1370894007
@elharo do we have a migration example? It seems that `DirectoryScanner` is
still far more fruitful then bare `java.nio.file.DirectoryStream`.
--
This is an automated message f
slawekjaranowski commented on code in PR #223:
URL:
https://github.com/apache/maven-integration-testing/pull/223#discussion_r1061495477
##
core-it-support/core-it-plugins/maven-it-plugin-site/pom.xml:
##
@@ -67,6 +68,40 @@ under the License.
org.apache.maven.reporting
slawekjaranowski commented on PR #223:
URL:
https://github.com/apache/maven-integration-testing/pull/223#issuecomment-1370951680
I used `dependencyManagement` in maven-enforcer because one Maven core
artifact from transitive dependencies was in compile scope.
--
This is an autom
laeubi opened a new pull request, #948:
URL: https://github.com/apache/maven/pull/948
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG-7662) filed
for t
psiroky commented on PR #223:
URL:
https://github.com/apache/maven-integration-testing/pull/223#issuecomment-1371036304
Yeah, that is the case in one of the plugins here as well, hence the
exclusions.
The `dependencyManagement` solution is quite elegant though as it means way
less c
psiroky commented on code in PR #223:
URL:
https://github.com/apache/maven-integration-testing/pull/223#discussion_r1061572431
##
core-it-support/core-it-plugins/maven-it-plugin-site/pom.xml:
##
@@ -67,6 +68,40 @@ under the License.
org.apache.maven.reporting
mave
psiroky commented on code in PR #223:
URL:
https://github.com/apache/maven-integration-testing/pull/223#discussion_r1061572431
##
core-it-support/core-it-plugins/maven-it-plugin-site/pom.xml:
##
@@ -67,6 +68,40 @@ under the License.
org.apache.maven.reporting
mave
hboutemy merged PR #132:
URL: https://github.com/apache/maven-doxia/pull/132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.ap
psiroky opened a new pull request, #224:
URL: https://github.com/apache/maven-integration-testing/pull/224
* I know the change looks huge, but in fact it is just a couple of find &
replace calls in IDE. 99% were of the changes were done automatically, just had
to manually adjust some edge c
andpab commented on PR #590:
URL: https://github.com/apache/maven-surefire/pull/590#issuecomment-1371188852
@slawekjaranowski Thanks for reviewing and merging. Is there anything else
that needs to be triggered so that the website is updated or is it only updated
when a new release is made?
slawekjaranowski commented on code in PR #224:
URL:
https://github.com/apache/maven-integration-testing/pull/224#discussion_r1061706611
##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng1803PomValidationErrorIncludesLineNumberTest.java:
##
@@ -64,7 +64,6 @@ public vo
cstamas opened a new pull request, #233:
URL: https://github.com/apache/maven-resolver/pull/233
In case remote repository defines unsupported layout, filter should just let
it pass (as resolver will gracefully fail with it anyway), while throwing
RuntimeException caused abruptly stopped bui
slawekjaranowski commented on code in PR #224:
URL:
https://github.com/apache/maven-integration-testing/pull/224#discussion_r1061707521
##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng2199ParentVersionRangeTest.java:
##
@@ -65,7 +65,6 @@ public void
testValidParen
slawekjaranowski commented on PR #224:
URL:
https://github.com/apache/maven-integration-testing/pull/224#issuecomment-1371201704
Great job, can you split each commit as separate PR 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
slawekjaranowski commented on PR #590:
URL: https://github.com/apache/maven-surefire/pull/590#issuecomment-1371211261
@andpab site is updated during release with new version.
I'm looking into current changes, I think that new release will be
appreciated.
So I will try to take
andpab commented on PR #590:
URL: https://github.com/apache/maven-surefire/pull/590#issuecomment-1371268106
That's great news. Looking forward to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
andpab commented on PR #571:
URL: https://github.com/apache/maven-surefire/pull/571#issuecomment-1371271421
I've updated the versions in SUREFIRE-2138 (PR #590), so once the next
release is made, the examples on the website will show up-to-date versions.
--
This is an automated message f
slawekjaranowski commented on PR #216:
URL: https://github.com/apache/maven-enforcer/pull/216#issuecomment-1371282744
@kwin Do you accept my responses?
Can I do anything more with this PR?
Anybody else has any more remarks?
I would like to merge and go forward.
--
This is an a
laeubi commented on PR #948:
URL: https://github.com/apache/maven/pull/948#issuecomment-1371283602
@michael-o can you probably take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
cstamas commented on PR #948:
URL: https://github.com/apache/maven/pull/948#issuecomment-1371286830
Um, this looks wrong to me I guess this is to have injected some
components that are session scoped? But why not use `Provider` for
components that are session scoped instead, as that wil
laeubi commented on PR #948:
URL: https://github.com/apache/maven/pull/948#issuecomment-1371290310
> Um, this looks wrong to me I guess this is to have injected some
components that are session scoped?
Yes as described in the JIRA ticket
> But why not use `Provider` for com
asfgit closed pull request #41: [MSKINS-200] Remove deprecated Piwik integration
URL: https://github.com/apache/maven-fluido-skin/pull/41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
asfgit closed pull request #42: [MSKINS-201] Replace deprecated
DecorationModel#getGoogleAnalyticsAccountId() with custom value
URL: https://github.com/apache/maven-fluido-skin/pull/42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
asfgit closed pull request #43: [MSKINS-202] Support Maven report standalone
mode
URL: https://github.com/apache/maven-fluido-skin/pull/43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
psiroky commented on code in PR #224:
URL:
https://github.com/apache/maven-integration-testing/pull/224#discussion_r1061809167
##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng1803PomValidationErrorIncludesLineNumberTest.java:
##
@@ -64,7 +64,6 @@ public void testit
psiroky commented on PR #224:
URL:
https://github.com/apache/maven-integration-testing/pull/224#issuecomment-1371323243
I will leave this PR for the first change (remvoing `resetStreams()`) and
will create two more PR with the other changes.
--
This is an automated message from the Apach
psiroky commented on code in PR #224:
URL:
https://github.com/apache/maven-integration-testing/pull/224#discussion_r1061811833
##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng2199ParentVersionRangeTest.java:
##
@@ -100,7 +89,6 @@ public void
testValidParentVersion
psiroky commented on code in PR #224:
URL:
https://github.com/apache/maven-integration-testing/pull/224#discussion_r1061817082
##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3331ModulePathNormalizationTest.java:
##
@@ -68,7 +68,6 @@ public void testitMNG3331a ()
psiroky commented on PR #224:
URL:
https://github.com/apache/maven-integration-testing/pull/224#issuecomment-1371351037
I went through the diff (as best as I could considering the number of
changed files), found couple more discrepancies and fixed them. Please take
another look. Hopefully
psiroky commented on code in PR #224:
URL:
https://github.com/apache/maven-integration-testing/pull/224#discussion_r1061832128
##
core-it-suite/src/test/java/org/apache/maven/it/ItUtils.java:
##
@@ -19,7 +19,6 @@
* under the License.
*/
-import org.junit.jupiter.api.Test;
cstamas merged PR #233:
URL: https://github.com/apache/maven-resolver/pull/233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.
slawekjaranowski merged PR #216:
URL: https://github.com/apache/maven-enforcer/pull/216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
CMoH commented on code in PR #387:
URL: https://github.com/apache/maven-surefire/pull/387#discussion_r1061962311
##
surefire-booter/src/test/java/org/apache/maven/surefire/booter/SystemUtilsTest.java:
##
@@ -98,6 +98,15 @@ public void incorrectJdkPath()
assertThat(
CMoH commented on PR #387:
URL: https://github.com/apache/maven-surefire/pull/387#issuecomment-1371540416
> @CMoH are you available to make the requested changes to the tests?
Otherwise I can also make a new pull request.
Well, this may silently disable the test without notice due to
gnodet commented on PR #948:
URL: https://github.com/apache/maven/pull/948#issuecomment-1371831631
Would it be possible to have scopes behave in a usual CDI way ? I.e. you
should be able to inject a `@SessionScoped` bean into a `@Singleton` and the DI
framework should wrap it in a proxy and
laeubi commented on PR #948:
URL: https://github.com/apache/maven/pull/948#issuecomment-1371842124
@gnodet if you have an idea how to rewrite `DefaultMaven` that way it would
be fine I think, I just don't know if it is possible as `DefaultMaven` is
"special" in the way how it setup the sess
gnodet commented on PR #948:
URL: https://github.com/apache/maven/pull/948#issuecomment-1371873677
> > Um, this looks wrong to me I guess this is to have injected some
components that are session scoped?
>
> Yes as described in the JIRA ticket
>
> > But why not use `Provide
laeubi commented on PR #948:
URL: https://github.com/apache/maven/pull/948#issuecomment-1371875965
> Fwiw, I've just tested the injection of
`javax.inject.Provider` on master and it seems to work well...
Do you like to submit a PR for this? This seems to be the easiest solution I
thi
bmarwell commented on PR #74:
URL: https://github.com/apache/maven-wrapper/pull/74#issuecomment-1371954691
Will add another PR which fixes the failed checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
bmarwell opened a new pull request, #78:
URL: https://github.com/apache/maven-wrapper/pull/78
Enables links to JIRA
---
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apach
bmarwell merged PR #78:
URL: https://github.com/apache/maven-wrapper/pull/78
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.ap
pzygielo commented on code in PR #74:
URL: https://github.com/apache/maven-wrapper/pull/74#discussion_r1062266573
##
.github/workflows/shellcheck-posix.yml:
##
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreement
pzygielo commented on code in PR #74:
URL: https://github.com/apache/maven-wrapper/pull/74#discussion_r1062266573
##
.github/workflows/shellcheck-posix.yml:
##
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreement
bmarwell commented on code in PR #74:
URL: https://github.com/apache/maven-wrapper/pull/74#discussion_r1062272774
##
.github/workflows/shellcheck-posix.yml:
##
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreement
bmarwell opened a new pull request, #79:
URL: https://github.com/apache/maven-wrapper/pull/79
Fix shellcheck warnings
---
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA
issue](https://issues.apa
bmarwell merged PR #74:
URL: https://github.com/apache/maven-wrapper/pull/74
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.ap
bmarwell commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1062317792
##
maven-wrapper-distribution/src/resources/mvnw:
##
@@ -71,38 +71,38 @@ esac
if [ -z "$JAVA_HOME" ] ; then
if [ -r /etc/gentoo-release ] ; then
-JAVA_HOME
michael-o commented on PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#issuecomment-1372039127
Put this into consideration:
https://issues.apache.org/jira/browse/MWRAPPER-45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
timtebeek opened a new pull request, #80:
URL: https://github.com/apache/maven-wrapper/pull/80
Java 8 brought some possible code improvements over the previous Java 7.
These have been applied through:
```
mvn org.openrewrite.maven:rewrite-maven-plugin:4.38.2:run
-DactiveRecipes=or
timtebeek commented on PR #80:
URL: https://github.com/apache/maven-wrapper/pull/80#issuecomment-1372066485
And a small note perhaps that [the recent shellcheck
step](https://github.com/apache/maven-wrapper/commit/ccaa27d6e7db433e6c3e71b3a74985d28bbfcf03)
also runs (and fails) on forks, so
bmarwell commented on code in PR #67:
URL: https://github.com/apache/maven-wrapper/pull/67#discussion_r1062378797
##
maven-wrapper-distribution/src/resources/mvnw:
##
@@ -160,7 +160,7 @@ find_maven_basedir() {
# concatenates all lines of a file
concat_lines() {
if [ -f "$1"
bmarwell opened a new pull request, #81:
URL: https://github.com/apache/maven-wrapper/pull/81
We need (should use) v38+ for this PR:
https://github.com/apache/maven-wrapper/pull/61
However, v39 requires the new style to be applied.
---
Following this checklist to help us
bmarwell commented on code in PR #61:
URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1062387739
##
maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java:
##
@@ -31,23 +31,23 @@
import java.util.Map;
import java.util.Properties;
timtebeek commented on code in PR #61:
URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1062395101
##
maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java:
##
@@ -31,23 +31,23 @@
import java.util.Map;
import java.util.Properties
bmarwell commented on code in PR #61:
URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1062397142
##
maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java:
##
@@ -31,23 +31,23 @@
import java.util.Map;
import java.util.Properties;
slawekjaranowski commented on PR #81:
URL: https://github.com/apache/maven-wrapper/pull/81#issuecomment-1372125545
Please create two commits - one with upgrade and one with refactor
Second commit with refactor can be added to excluded from git blame
https://maven.apache.org/pom/mave
timtebeek commented on code in PR #61:
URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1062399837
##
maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java:
##
@@ -31,23 +31,23 @@
import java.util.Map;
import java.util.Properties
bmarwell commented on PR #81:
URL: https://github.com/apache/maven-wrapper/pull/81#issuecomment-1372137154
> Please create two commits - one with upgrade and one with refactor Second
commit with refactor can be added to excluded from git blame
>
> https://maven.apache.org/pom/maven/#t
ppalaga commented on issue #763:
URL: https://github.com/apache/maven-mvnd/issues/763#issuecomment-1372140007
See https://youtrack.jetbrains.com/issue/IDEA-264396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
501 - 600 of 37749 matches
Mail list logo
