[GitHub] michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable

michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r211385288 ## File path:

[GitHub] michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable

michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r211383488 ## File path:

[GitHub] michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable

michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r211383797 ## File path:

[GitHub] michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable

michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r211385033 ## File path:

[GitHub] michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable

michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r211385757 ## File path:

[GitHub] michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable

michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r211385251 ## File path:

[GitHub] michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable

michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r211380849 ## File path:

[GitHub] michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable

michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r211380988 ## File path:

[GitHub] michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable

michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r211385112 ## File path:

[GitHub] michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable

michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r211385725 ## File path:

[GitHub] michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable

michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r211385162 ## File path:

[GitHub] michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable

michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r211385850 ## File path:

[GitHub] michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable

michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r211384332 ## File path: wagon-providers/wagon-http/src/site/apt/index.apt ## @@ -57,3 +57,22

[GitHub] michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable

michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r211383035 ## File path:

[GitHub] michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable

michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r211385327 ## File path:

[GitHub] michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable

michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r211385369 ## File path:

[GitHub] michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable

michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r211385270 ## File path:

[GitHub] michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable

michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r211385912 ## File path:

[GitHub] michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable

michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r211384950 ## File path:

[GitHub] michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable

michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r211385080 ## File path:

[GitHub] michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable

michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r211385010 ## File path:

[GitHub] michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable

michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r211385807 ## File path:

[GitHub] michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable

michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r211384576 ## File path: wagon-providers/wagon-http/src/site/apt/index.apt ## @@ -57,3 +57,22

[GitHub] michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable

michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r211384615 ## File path: wagon-providers/wagon-http/src/site/apt/index.apt ## @@ -57,3 +57,22

[GitHub] michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable

michael-o commented on a change in pull request #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r211385200 ## File path:

[GitHub] sebthom commented on issue #28: Add support for detecting and using of KiTTY's klink.exe and kscp.exe

sebthom commented on issue #28: Add support for detecting and using of KiTTY's klink.exe and kscp.exe URL: https://github.com/apache/maven-wagon/pull/28#issuecomment-413962566 At last: https://issues.apache.org/jira/browse/WAGON-525

[GitHub] jean-philippe-martin commented on a change in pull request #4: (doc) - mention include tag

jean-philippe-martin commented on a change in pull request #4: (doc) - mention include tag URL: https://github.com/apache/maven-shade-plugin/pull/4#discussion_r210976084 ## File path: src/site/apt/examples/class-relocation.apt.vm ## @@ -70,3 +70,20 @@ Relocating Classes

[GitHub] khmarbaise commented on issue #4: (doc) - mention include tag

khmarbaise commented on issue #4: (doc) - mention include tag URL: https://github.com/apache/maven-shade-plugin/pull/4#issuecomment-413941663 Could you do another favour and squash those two commits into a single onewould greatly help me...afterwards I appreciate to merge this...

[GitHub] mattnelson opened a new pull request #3: [MDEP-425] - Add list-plugin-repositories goal

mattnelson opened a new pull request #3: [MDEP-425] - Add list-plugin-repositories goal URL: https://github.com/apache/maven-dependency-plugin/pull/3 https://issues.apache.org/jira/browse/MDEP-425 Replacement PR for https://github.com/apache/maven-plugins/pull/113 Add

[GitHub] asfgit closed pull request #192: [SUREFIRE-1550] The surefire XSD published on maven site lacks of some

asfgit closed pull request #192: [SUREFIRE-1550] The surefire XSD published on maven site lacks of some URL: https://github.com/apache/maven-surefire/pull/192 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] michael-o commented on issue #37: [WAGON-526] making the retry handle of http client configurable

michael-o commented on issue #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#issuecomment-414580688 Looks very good now. I run push a test branch later this day.

[GitHub] michael-o commented on issue #37: [WAGON-526] making the retry handle of http client configurable

michael-o commented on issue #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#issuecomment-414341589 Alright, I will have at this later this day. I think there is still room for some improvement.

[GitHub] michael-o edited a comment on issue #37: [WAGON-526] making the retry handle of http client configurable

michael-o edited a comment on issue #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#issuecomment-414341589 Alright, I will have at this later this day. I think there is still room for some improvement, but I like the

[GitHub] khmarbaise commented on issue #3: Fix test class name.

khmarbaise commented on issue #3: Fix test class name. URL: https://github.com/apache/maven-jlink-plugin/pull/3#issuecomment-414740445 Many thanks for the contribution. The change has been merged to master see

[GitHub] khmarbaise closed pull request #3: Fix test class name.

khmarbaise closed pull request #3: Fix test class name. URL: https://github.com/apache/maven-jlink-plugin/pull/3 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] khmarbaise commented on issue #4: [MJLINK-3] Improve verbose output during build.

khmarbaise commented on issue #4: [MJLINK-3] Improve verbose output during build. URL: https://github.com/apache/maven-jlink-plugin/pull/4#issuecomment-414969042 Many thanks for your contribution. The CI has shows everything Ok so far

[GitHub] khmarbaise closed pull request #4: [MJLINK-3] Improve verbose output during build.

khmarbaise closed pull request #4: [MJLINK-3] Improve verbose output during build. URL: https://github.com/apache/maven-jlink-plugin/pull/4 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] Tibor17 commented on issue #190: [SUREFIRE-1535] Surefire unable to run testng suites in parallel

Tibor17 commented on issue #190: [SUREFIRE-1535] Surefire unable to run testng suites in parallel URL: https://github.com/apache/maven-surefire/pull/190#issuecomment-415539109 @andreybpanfilov Pls rebase this branch.

[GitHub] Tibor17 commented on issue #190: [SUREFIRE-1535] Surefire unable to run testng suites in parallel

Tibor17 commented on issue #190: [SUREFIRE-1535] Surefire unable to run testng suites in parallel URL: https://github.com/apache/maven-surefire/pull/190#issuecomment-415528689 @andreybpanfilov I will push this to master because here is a chance that the integration test 1177 will pass

[GitHub] andreybpanfilov commented on issue #190: [SUREFIRE-1535] Surefire unable to run testng suites in parallel

andreybpanfilov commented on issue #190: [SUREFIRE-1535] Surefire unable to run testng suites in parallel URL: https://github.com/apache/maven-surefire/pull/190#issuecomment-415541476 Done. This is an automated message from

[GitHub] cloorc commented on issue #52: add --cached option for git rm

cloorc commented on issue #52: add --cached option for git rm URL: https://github.com/apache/maven-scm/pull/52#issuecomment-415673868 Hi @michael-o , you are right. And I've already updated my PR. I thought scm should only remove paths from the index instead of removing these files

[GitHub] erikhakansson commented on a change in pull request #49: [MNG-2802] Concurrent-safe access to local Maven repository

erikhakansson commented on a change in pull request #49: [MNG-2802] Concurrent-safe access to local Maven repository URL: https://github.com/apache/maven-wagon/pull/49#discussion_r212562988 ## File path:

[GitHub] michael-o commented on issue #18: Implemented mkdirs method to use the webdav MKCOL HTTP verb to create directories

michael-o commented on issue #18: Implemented mkdirs method to use the webdav MKCOL HTTP verb to create directories URL: https://github.com/apache/maven-wagon/pull/18#issuecomment-415860479 Any response? This is an automated

[GitHub] michael-o commented on issue #37: [WAGON-526] making the retry handle of http client configurable

michael-o commented on issue #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#issuecomment-415832866 I have pushed a cleaned up branch. Please have a look. If all is fine, I will merge.

[GitHub] andretadeu opened a new pull request #4: [MJLINK-3] Improve verbose output during build.

andretadeu opened a new pull request #4: [MJLINK-3] Improve verbose output during build. URL: https://github.com/apache/maven-jlink-plugin/pull/4 Hi people! I composed a fix for the bug MJLINK-3. The solution done was simply split the output string by '\n' and log each line. This

[GitHub] michael-o commented on issue #52: add --cached option for git rm

michael-o commented on issue #52: add --cached option for git rm URL: https://github.com/apache/maven-scm/pull/52#issuecomment-415873011 This change will break the contract from `ScmProvider#remove()`. This can be at most a config parameter. What is your real usecase for this?

[GitHub] cloorc commented on issue #52: add --cached option for git rm

cloorc commented on issue #52: add --cached option for git rm URL: https://github.com/apache/maven-scm/pull/52#issuecomment-415963792 Just leave me a chance to keep the files this plugin is going to remove. It was a long period since the last time I posted this PR. Without this chance,

[GitHub] cloorc closed pull request #52: add --cached option for git rm

cloorc closed pull request #52: add --cached option for git rm URL: https://github.com/apache/maven-scm/pull/52 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] turbanoff opened a new pull request #6: Use java7 features

turbanoff opened a new pull request #6: Use java7 features URL: https://github.com/apache/maven-assembly-plugin/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] michael-o commented on issue #52: add --cached option for git rm

michael-o commented on issue #52: add --cached option for git rm URL: https://github.com/apache/maven-scm/pull/52#issuecomment-415974342 I did not intend to close, but merely wanted to point out that if you really need it, a command param is the way to go. There is a sample commit you can

[GitHub] michael-o commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena…

michael-o commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena… URL: https://github.com/apache/maven-fluido-skin/pull/1#issuecomment-415996525 Cam someone rebase this? I will review and merge then.

[GitHub] michael-o commented on issue #28: Fix for SCM-695 : Mvn release plugin problems with too many - in name

michael-o commented on issue #28: Fix for SCM-695 : Mvn release plugin problems with too many - in name URL: https://github.com/apache/maven-scm/pull/28#issuecomment-415998499 Can someone please rebase and drop unaffected changes even if they are correct? We also need a proper IT which

[GitHub] asfgit closed pull request #190: [SUREFIRE-1535] Surefire unable to run testng suites in parallel

asfgit closed pull request #190: [SUREFIRE-1535] Surefire unable to run testng suites in parallel URL: https://github.com/apache/maven-surefire/pull/190 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] asfgit closed pull request #4: Correct link to Jenkins builds

asfgit closed pull request #4: Correct link to Jenkins builds URL: https://github.com/apache/maven-fluido-skin/pull/4 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] asfgit closed pull request #5: Correct link to Github edit Fork me link

asfgit closed pull request #5: Correct link to Github edit Fork me link URL: https://github.com/apache/maven-fluido-skin/pull/5 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] khmarbaise commented on issue #10: [JXR-110] Use equivalent css/images of javadoc

khmarbaise commented on issue #10: [JXR-110] Use equivalent css/images of javadoc URL: https://github.com/apache/maven-jxr/pull/10#issuecomment-416034616 It looks like you have made accidentally a merge into your branch instead of rebasing it against master...

[GitHub] judby commented on a change in pull request #10: [JXR-110] Use equivalent css/images of javadoc

judby commented on a change in pull request #10: [JXR-110] Use equivalent css/images of javadoc URL: https://github.com/apache/maven-jxr/pull/10#discussion_r212824934 ## File path: maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java ## @@

[GitHub] judby commented on a change in pull request #10: [JXR-110] Use equivalent css/images of javadoc

judby commented on a change in pull request #10: [JXR-110] Use equivalent css/images of javadoc URL: https://github.com/apache/maven-jxr/pull/10#discussion_r212824953 ## File path: maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java ## @@

[GitHub] joergsesterhenn opened a new pull request #1: (doc) fix page title: help -> ejb

joergsesterhenn opened a new pull request #1: (doc) fix page title: help -> ejb URL: https://github.com/apache/maven-ejb-plugin/pull/1 see title This is an automated message from the Apache Git Service. To

[GitHub] rfscholte closed pull request #1: (doc) fix page title: help -> ejb

rfscholte closed pull request #1: (doc) fix page title: help -> ejb URL: https://github.com/apache/maven-ejb-plugin/pull/1 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] forax edited a comment on issue #14: [MPLUGIN-336] Upgrade ASM to 6.2 for Java 10, 11 support

forax edited a comment on issue #14: [MPLUGIN-336] Upgrade ASM to 6.2 for Java 10,11 support URL: https://github.com/apache/maven-plugin-tools/pull/14#issuecomment-414087721 ASM 6.2.1 (and ASM 6.2) are nestmate ready, but you have to opt-in using the api ASM7_EXPERIMENTAL instead of the

[GitHub] forax commented on issue #14: [MPLUGIN-336] Upgrade ASM to 6.2 for Java 10, 11 support

forax commented on issue #14: [MPLUGIN-336] Upgrade ASM to 6.2 for Java 10,11 support URL: https://github.com/apache/maven-plugin-tools/pull/14#issuecomment-416558641 The ClassReader reads a class attribute named NestHost because javac 11 now emits such attribute, but because the

[GitHub] docrjp commented on issue #14: [MPLUGIN-336] Upgrade ASM to 6.2 for Java 10, 11 support

docrjp commented on issue #14: [MPLUGIN-336] Upgrade ASM to 6.2 for Java 10,11 support URL: https://github.com/apache/maven-plugin-tools/pull/14#issuecomment-416577342 @forax that makes a lot of sense, thanks. I can see that Jacoco and cglib adopted ASM7_EXPERIMENTAL, which bodes

[GitHub] docrjp commented on issue #14: [MPLUGIN-336] Upgrade ASM to 6.2 for Java 10, 11 support

docrjp commented on issue #14: [MPLUGIN-336] Upgrade ASM to 6.2 for Java 10,11 support URL: https://github.com/apache/maven-plugin-tools/pull/14#issuecomment-416547216 So how is the visitNestHostExperimental() call coming about, if it's an experimental feature that needs opting in? The

[GitHub] asfgit closed pull request #37: [WAGON-526] making the retry handle of http client configurable

asfgit closed pull request #37: [WAGON-526] making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] judby commented on a change in pull request #10: [JXR-110] Use equivalent css/images of javadoc

judby commented on a change in pull request #10: [JXR-110] Use equivalent css/images of javadoc URL: https://github.com/apache/maven-jxr/pull/10#discussion_r212834067 ## File path: maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java ## @@

[GitHub] rfscholte commented on a change in pull request #10: [JXR-110] Use equivalent css/images of javadoc

rfscholte commented on a change in pull request #10: [JXR-110] Use equivalent css/images of javadoc URL: https://github.com/apache/maven-jxr/pull/10#discussion_r212832298 ## File path: maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java ##

[GitHub] rfscholte commented on a change in pull request #10: [JXR-110] Use equivalent css/images of javadoc

rfscholte commented on a change in pull request #10: [JXR-110] Use equivalent css/images of javadoc URL: https://github.com/apache/maven-jxr/pull/10#discussion_r212832172 ## File path: maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java ##

[GitHub] docrjp commented on issue #14: [MPLUGIN-336] Upgrade ASM to 6.2 for Java 10, 11 support

docrjp commented on issue #14: [MPLUGIN-336] Upgrade ASM to 6.2 for Java 10,11 support URL: https://github.com/apache/maven-plugin-tools/pull/14#issuecomment-416643028 @rfscholte indeed but it's not about experimenting with ASM or doing releases on demand. Rather it is Maven blocking

[GitHub] rfscholte commented on issue #14: [MPLUGIN-336] Upgrade ASM to 6.2 for Java 10, 11 support

rfscholte commented on issue #14: [MPLUGIN-336] Upgrade ASM to 6.2 for Java 10,11 support URL: https://github.com/apache/maven-plugin-tools/pull/14#issuecomment-416623370 The Java Release Train comes with a lot of challenges, whereas staying in line with ASM is a clear example. I

[GitHub] jdillon opened a new pull request #39: [MENFORCER-315] - Add thirdparty-rules page to site

jdillon opened a new pull request #39: [MENFORCER-315] - Add thirdparty-rules page to site URL: https://github.com/apache/maven-enforcer/pull/39 * Adds thirdparty-rules page to the generated site * Add link to Sonatype OSS Index rules documentation Following this

[GitHub] docrjp commented on issue #14: [MPLUGIN-336] Upgrade ASM to 6.2 for Java 10, 11 support

docrjp commented on issue #14: [MPLUGIN-336] Upgrade ASM to 6.2 for Java 10,11 support URL: https://github.com/apache/maven-plugin-tools/pull/14#issuecomment-416688877 That would be good! But are the different use cases for ASM in Maven sufficiently similar to do so? Probably

[GitHub] forax commented on issue #14: [MPLUGIN-336] Upgrade ASM to 6.2 for Java 10, 11 support

forax commented on issue #14: [MPLUGIN-336] Upgrade ASM to 6.2 for Java 10,11 support URL: https://github.com/apache/maven-plugin-tools/pull/14#issuecomment-416662709 A better solution IMO is to move all ASM related codes (codes that deals with classfiles) into one new module so you only

[GitHub] rfscholte commented on issue #14: [MPLUGIN-336] Upgrade ASM to 6.2 for Java 10, 11 support

rfscholte commented on issue #14: [MPLUGIN-336] Upgrade ASM to 6.2 for Java 10,11 support URL: https://github.com/apache/maven-plugin-tools/pull/14#issuecomment-416657591 @forax told me I should not solve this as done by cglib, see https://gitlab.ow2.org/asm/asm/issues/317849

[GitHub] docrjp edited a comment on issue #14: [MPLUGIN-336] Upgrade ASM to 6.2 for Java 10, 11 support

docrjp edited a comment on issue #14: [MPLUGIN-336] Upgrade ASM to 6.2 for Java 10,11 support URL: https://github.com/apache/maven-plugin-tools/pull/14#issuecomment-416688877 That would be good! But are the different use cases for ASM in Maven sufficiently similar to do so?

[GitHub] forax commented on issue #14: [MPLUGIN-336] Upgrade ASM to 6.2 for Java 10, 11 support

forax commented on issue #14: [MPLUGIN-336] Upgrade ASM to 6.2 for Java 10,11 support URL: https://github.com/apache/maven-plugin-tools/pull/14#issuecomment-416746616 @docrjp, yes the idea is just to consolidate all use cases inside one module, to enumerate all maven plugins that are

[GitHub] Maastiff opened a new pull request #1: [MJAR-254] - Fixes filename conflict when producing 2 jars without classifier

Maastiff opened a new pull request #1: [MJAR-254] - Fixes filename conflict when producing 2 jars without classifier URL: https://github.com/apache/maven-jar-plugin/pull/1 Hello, I provided a failing test for this issue, I will try to going further to develop the fix. Done

[GitHub] rfscholte commented on issue #14: [MPLUGIN-336] Upgrade ASM to 6.2 for Java 10, 11 support

rfscholte commented on issue #14: [MPLUGIN-336] Upgrade ASM to 6.2 for Java 10,11 support URL: https://github.com/apache/maven-plugin-tools/pull/14#issuecomment-416893061 I've been able to reduce the need for ASM in plexus-java. First implementations always used ASM to read the module

[GitHub] forax commented on issue #14: [MPLUGIN-336] Upgrade ASM to 6.2 for Java 10, 11 support

forax commented on issue #14: [MPLUGIN-336] Upgrade ASM to 6.2 for Java 10,11 support URL: https://github.com/apache/maven-plugin-tools/pull/14#issuecomment-416900228 @rfscholte, there is a slight difference between using ASM or ModuleDescriptor.read is that ModuleDescriptor.read only

[GitHub] michael-o commented on a change in pull request #51: fix SCM-835 collision

michael-o commented on a change in pull request #51: fix SCM-835 collision URL: https://github.com/apache/maven-scm/pull/51#discussion_r23794 ## File path:

[GitHub] asfgit closed pull request #51: fix SCM-835 collision

asfgit closed pull request #51: fix SCM-835 collision URL: https://github.com/apache/maven-scm/pull/51 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] Tibor17 commented on issue #192: [SUREFIRE-1550] The surefire XSD published on maven site lacks of some

Tibor17 commented on issue #192: [SUREFIRE-1550] The surefire XSD published on maven site lacks of some URL: https://github.com/apache/maven-surefire/pull/192#issuecomment-414151673 @nfalco79 Ths for introducing the missing elements but I have to remove the `time` because the code

[GitHub] shvar commented on issue #51: fix SCM-835 collision

shvar commented on issue #51: fix SCM-835 collision URL: https://github.com/apache/maven-scm/pull/51#issuecomment-414146512 Rebased, @michael-o The context of the problem, if I remember correctly, was that the status consumer reported affected files, that were in

[GitHub] asfgit closed pull request #44: [WAGON-500] re-enable ScmCvsExeWagonTest

asfgit closed pull request #44: [WAGON-500] re-enable ScmCvsExeWagonTest URL: https://github.com/apache/maven-wagon/pull/44 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] michael-o commented on issue #51: fix SCM-835 collision

michael-o commented on issue #51: fix SCM-835 collision URL: https://github.com/apache/maven-scm/pull/51#issuecomment-414153426 Just checked `SvnCheckInCommand` and it looks fine to me. `createCommandLine` does `SvnCommandLineUtils.addTarget( cl, fileSet.getFileList() );`. `svn st` is

[GitHub] michael-o commented on a change in pull request #51: fix SCM-835 collision

michael-o commented on a change in pull request #51: fix SCM-835 collision URL: https://github.com/apache/maven-scm/pull/51#discussion_r23794 ## File path:

[GitHub] michael-o commented on issue #79: [SCM-318] Untag command, with Git implementations

michael-o commented on issue #79: [SCM-318] Untag command, with Git implementations URL: https://github.com/apache/maven-scm/pull/79#issuecomment-414156073 Please revise formatting. It does not fully correspond to our format.

[GitHub] michael-o commented on issue #51: fix SCM-835 collision

michael-o commented on issue #51: fix SCM-835 collision URL: https://github.com/apache/maven-scm/pull/51#issuecomment-414146910 Have you actually checked with other providers? JGit, SvnExe? I'd expect the exact same behavior across providers. I don't care for the remaining ones for now.

[GitHub] shvar commented on issue #51: fix SCM-835 collision

shvar commented on issue #51: fix SCM-835 collision URL: https://github.com/apache/maven-scm/pull/51#issuecomment-414149652 It's an interesting question. I checked now SvnExe and JGit and it looks like: 1) on SvnExe we don't have `fileSet` at all, only `workingDirectory`, so it

[GitHub] michael-o commented on a change in pull request #37: making the retry handle of http client configurable

michael-o commented on a change in pull request #37: making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r22644 ## File path:

[GitHub] michael-o commented on a change in pull request #37: making the retry handle of http client configurable

michael-o commented on a change in pull request #37: making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r22754 ## File path:

[GitHub] michael-o commented on a change in pull request #37: making the retry handle of http client configurable

michael-o commented on a change in pull request #37: making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r22658 ## File path:

[GitHub] michael-o commented on a change in pull request #37: making the retry handle of http client configurable

michael-o commented on a change in pull request #37: making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r22855 ## File path:

[GitHub] michael-o commented on a change in pull request #37: making the retry handle of http client configurable

michael-o commented on a change in pull request #37: making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r22884 ## File path:

[GitHub] michael-o commented on a change in pull request #37: making the retry handle of http client configurable

michael-o commented on a change in pull request #37: making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r22974 ## File path: wagon-providers/wagon-http/src/site/apt/index.apt ## @@ -57,3 +57,22 @@ Features

[GitHub] michael-o commented on a change in pull request #37: making the retry handle of http client configurable

michael-o commented on a change in pull request #37: making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r23025 ## File path:

[GitHub] michael-o commented on a change in pull request #37: making the retry handle of http client configurable

michael-o commented on a change in pull request #37: making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r22760 ## File path:

[GitHub] michael-o commented on a change in pull request #37: making the retry handle of http client configurable

michael-o commented on a change in pull request #37: making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r22986 ## File path: wagon-providers/wagon-http/src/site/apt/index.apt ## @@ -57,3 +57,22 @@ Features

[GitHub] michael-o commented on a change in pull request #37: making the retry handle of http client configurable

michael-o commented on a change in pull request #37: making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r23013 ## File path:

[GitHub] michael-o commented on a change in pull request #37: making the retry handle of http client configurable

michael-o commented on a change in pull request #37: making the retry handle of http client configurable URL: https://github.com/apache/maven-wagon/pull/37#discussion_r22918 ## File path:

<    3   4   5   6   7   8   9   10   11   12   >