[jira] [Updated] (SUREFIRE-1720) JUnit 5 @Nested classes are not excluded when name ends in Tests

2019-11-15 Thread Dmitry Timofeev (Jira)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dmitry Timofeev updated SUREFIRE-1720:
--
Description: 
{color:#808080}`` {color}over source file names does not exclude the 
{color:#808080}`@Nested` {color}test classes, defined inside the matching 
source files, if they end with {color:#808080}`Tests`{color}.
h3. Minimal reproducing project

[https://github.com/dmitry-timofeev/surefire-bug] (contains the instrutctions 
to run)

See AppIntegrationTest.
h3. Surefire Configuration
{code:java}

  maven-surefire-plugin
  ${surefire.version}
  

  
  **/*IntegrationTest.java



  

{code}
h3. {color:#9876aa}Expected Behaviour{color}

When a pattern over source file names is used 
({color:#808080}`*Pattern.java`{color}),
 it must apply to all classes inside that file (including @Nested with any 
name).
h3. {color:#9876aa}Actual Behaviour{color}

The exclusion does not apply to some @Nested classes inside the matching source 
file (e.g, ending with {color:#808080}`Tests`{color}).
h3. Workaround

Also add a pattern, operating on _classes:_ 
{{%regex[.*IntegrationTest\$.*]}}

  was:
{color:#808080}`` {color}over source file names does not exclude the 
{color:#808080}`@Nested` {color}test classes, defined inside the matching 
source files, if they end with {color:#808080}`Tests`{color}.
h3. Minimal reproducing project

[https://github.com/dmitry-timofeev/surefire-bug] (contains the instrutctions 
to run)

See AppIntegrationTest.
h3. Surefire Configuration
{code:java}

  maven-surefire-plugin
  ${surefire.version}
  

  
  **/*IntegrationTest.java



  

{code}
h3. {color:#9876aa}Expected Behaviour{color}

When a pattern over source file names is used 
({color:#808080}`*Pattern.java`{color}),
it must apply to all classes inside that file (including @Nested with any name).
h3. {color:#9876aa}Actual Behaviour{color}

The exclusion does not apply to some @Nested classes inside the matching source 
file (e.g, ending with {color:#808080}`Tests`{color}).


> JUnit 5 @Nested classes are not excluded when name ends in Tests
> 
>
> Key: SUREFIRE-1720
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1720
> Project: Maven Surefire
>  Issue Type: Bug
>Affects Versions: 2.22.2, 3.0.0-M3
>Reporter: Dmitry Timofeev
>Priority: Minor
>
> {color:#808080}`` {color}over source file names does not exclude the 
> {color:#808080}`@Nested` {color}test classes, defined inside the matching 
> source files, if they end with {color:#808080}`Tests`{color}.
> h3. Minimal reproducing project
> [https://github.com/dmitry-timofeev/surefire-bug] (contains the instrutctions 
> to run)
> See AppIntegrationTest.
> h3. Surefire Configuration
> {code:java}
> 
>   maven-surefire-plugin
>   ${surefire.version}
>   
> 
>   
>   **/*IntegrationTest.java
> 
> 
> 
>   
> 
> {code}
> h3. {color:#9876aa}Expected Behaviour{color}
> When a pattern over source file names is used 
> ({color:#808080}`*Pattern.java`{color}),
>  it must apply to all classes inside that file (including @Nested with any 
> name).
> h3. {color:#9876aa}Actual Behaviour{color}
> The exclusion does not apply to some @Nested classes inside the matching 
> source file (e.g, ending with {color:#808080}`Tests`{color}).
> h3. Workaround
> Also add a pattern, operating on _classes:_ 
> {{%regex[.*IntegrationTest\$.*]}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (SUREFIRE-1720) JUnit 5 @Nested classes are not excluded when name ends in Tests

2019-11-15 Thread Dmitry Timofeev (Jira)
Dmitry Timofeev created SUREFIRE-1720:
-

 Summary: JUnit 5 @Nested classes are not excluded when name ends 
in Tests
 Key: SUREFIRE-1720
 URL: https://issues.apache.org/jira/browse/SUREFIRE-1720
 Project: Maven Surefire
  Issue Type: Bug
Affects Versions: 3.0.0-M3, 2.22.2
Reporter: Dmitry Timofeev


{color:#808080}`` {color}over source file names does not exclude the 
{color:#808080}`@Nested` {color}test classes, defined inside the matching 
source files, if they end with {color:#808080}`Tests`{color}.
h3. Minimal reproducing project

[https://github.com/dmitry-timofeev/surefire-bug] (contains the instrutctions 
to run)

See AppIntegrationTest.
h3. Surefire Configuration
{code:java}

  maven-surefire-plugin
  ${surefire.version}
  

  
  **/*IntegrationTest.java



  

{code}
h3. {color:#9876aa}Expected Behaviour{color}

When a pattern over source file names is used 
({color:#808080}`*Pattern.java`{color}),
it must apply to all classes inside that file (including @Nested with any name).
h3. {color:#9876aa}Actual Behaviour{color}

The exclusion does not apply to some @Nested classes inside the matching source 
file (e.g, ending with {color:#808080}`Tests`{color}).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (SUREFIRE-1648) Failsafe does not pass LD_LIBRARY_PATH to JVM on Mac with SIP enabled

2019-03-13 Thread Dmitry Timofeev (JIRA)
Dmitry Timofeev created SUREFIRE-1648:
-

 Summary: Failsafe does not pass LD_LIBRARY_PATH to JVM on Mac with 
SIP enabled
 Key: SUREFIRE-1648
 URL: https://issues.apache.org/jira/browse/SUREFIRE-1648
 Project: Maven Surefire
  Issue Type: Bug
Affects Versions: 2.22.1
 Environment: OS: macOS Mojave with SIP enabled (default)
JVM: OpenJDK 11.0.2
Reporter: Dmitry Timofeev


Hi,

We encountered a problem with using maven-failsafe-plugin on Mac with SIP 
(System Integrity Protection) enabled. We’re using failsafe to run our 
integration tests that depend on a native library that also requires 
LD_LIBRARY_PATH to be set. Failsafe plugin does not pass LD_LIBRARY_PATH to the 
process which leads to tests failures. According to the documentation [1] we 
can use environmentVariables parameter like this:
{code:java}

  ${myLdLibraryPath}
{code}
This configuration works perfectly with Exec Maven Plugin, but it doesn't in 
failsafe.

Is it desired behaviour? Do you have any ideas how to pass necessary 
LD_LIBRARY_PATH to the integration tests?

[1]: 
http://maven.apache.org/surefire/maven-failsafe-plugin/integration-test-mojo.html#environmentVariables



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MARCHETYPES-61) Update quickstart to use JUnit 5

2018-10-13 Thread Dmitry Timofeev (JIRA)


[ 
https://issues.apache.org/jira/browse/MARCHETYPES-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648883#comment-16648883
 ] 

Dmitry Timofeev commented on MARCHETYPES-61:


Surefire will need to be updated first to support junit 5 properly: 
https://github.com/apache/maven-archetypes/pull/1

> Update quickstart to use JUnit 5
> 
>
> Key: MARCHETYPES-61
> URL: https://issues.apache.org/jira/browse/MARCHETYPES-61
> Project: Maven Archetype Bundles
>  Issue Type: Improvement
>  Components: Maven Quickstart Archetype
>Affects Versions: 1.3
>Reporter: Dmitry Timofeev
>Priority: Minor
>
> Update quickstart archetype to generate a project using JUnit 5, the next 
> version of the most popular testing framework.
> Currently one has to include _at least_ two dependencies on JUnit 5 artefacts 
> to enable surefire to run them: junit-jupiter-api and junit-jupiter-engine.
> Possible structure of dependencies:
> {code:java}
> 
>   
> 
>   org.junit
>   junit-bom
>   5.3.1
>   pom
>   import
> 
>   
> 
> 
>   
> org.junit.jupiter
> junit-jupiter-api
> test
>   
>   
> org.junit.jupiter
> junit-jupiter-engine
> test
>   
>   
>   
> org.junit.jupiter
> junit-jupiter-params
> test
>   
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MARCHETYPES-61) Update quickstart to use JUnit 5

2018-10-13 Thread Dmitry Timofeev (JIRA)


 [ 
https://issues.apache.org/jira/browse/MARCHETYPES-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dmitry Timofeev updated MARCHETYPES-61:
---
Affects Version/s: 1.3

> Update quickstart to use JUnit 5
> 
>
> Key: MARCHETYPES-61
> URL: https://issues.apache.org/jira/browse/MARCHETYPES-61
> Project: Maven Archetype Bundles
>  Issue Type: Improvement
>  Components: Maven Quickstart Archetype
>Affects Versions: 1.3
>Reporter: Dmitry Timofeev
>Priority: Minor
>
> Update quickstart archetype to generate a project using JUnit 5, the next 
> version of the most popular testing framework.
> Currently one has to include _at least_ two dependencies on JUnit 5 artefacts 
> to enable surefire to run them: junit-jupiter-api and junit-jupiter-engine.
> Possible structure of dependencies:
> {code:java}
> 
>   
> 
>   org.junit
>   junit-bom
>   5.3.1
>   pom
>   import
> 
>   
> 
> 
>   
> org.junit.jupiter
> junit-jupiter-api
> test
>   
>   
> org.junit.jupiter
> junit-jupiter-engine
> test
>   
>   
>   
> org.junit.jupiter
> junit-jupiter-params
> test
>   
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MARCHETYPES-61) Update quickstart to use JUnit 5

2018-10-13 Thread Dmitry Timofeev (JIRA)


 [ 
https://issues.apache.org/jira/browse/MARCHETYPES-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dmitry Timofeev updated MARCHETYPES-61:
---
Component/s: Maven Quickstart Archetype

> Update quickstart to use JUnit 5
> 
>
> Key: MARCHETYPES-61
> URL: https://issues.apache.org/jira/browse/MARCHETYPES-61
> Project: Maven Archetype Bundles
>  Issue Type: Improvement
>  Components: Maven Quickstart Archetype
>Affects Versions: 1.3
>Reporter: Dmitry Timofeev
>Priority: Minor
>
> Update quickstart archetype to generate a project using JUnit 5, the next 
> version of the most popular testing framework.
> Currently one has to include _at least_ two dependencies on JUnit 5 artefacts 
> to enable surefire to run them: junit-jupiter-api and junit-jupiter-engine.
> Possible structure of dependencies:
> {code:java}
> 
>   
> 
>   org.junit
>   junit-bom
>   5.3.1
>   pom
>   import
> 
>   
> 
> 
>   
> org.junit.jupiter
> junit-jupiter-api
> test
>   
>   
> org.junit.jupiter
> junit-jupiter-engine
> test
>   
>   
>   
> org.junit.jupiter
> junit-jupiter-params
> test
>   
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MARCHETYPES-61) Update quickstart to use JUnit 5

2018-10-13 Thread Dmitry Timofeev (JIRA)


 [ 
https://issues.apache.org/jira/browse/MARCHETYPES-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dmitry Timofeev updated MARCHETYPES-61:
---
Priority: Minor  (was: Major)

> Update quickstart to use JUnit 5
> 
>
> Key: MARCHETYPES-61
> URL: https://issues.apache.org/jira/browse/MARCHETYPES-61
> Project: Maven Archetype Bundles
>  Issue Type: Improvement
>  Components: Maven Quickstart Archetype
>Affects Versions: 1.3
>Reporter: Dmitry Timofeev
>Priority: Minor
>
> Update quickstart archetype to generate a project using JUnit 5, the next 
> version of the most popular testing framework.
> Currently one has to include _at least_ two dependencies on JUnit 5 artefacts 
> to enable surefire to run them: junit-jupiter-api and junit-jupiter-engine.
> Possible structure of dependencies:
> {code:java}
> 
>   
> 
>   org.junit
>   junit-bom
>   5.3.1
>   pom
>   import
> 
>   
> 
> 
>   
> org.junit.jupiter
> junit-jupiter-api
> test
>   
>   
> org.junit.jupiter
> junit-jupiter-engine
> test
>   
>   
>   
> org.junit.jupiter
> junit-jupiter-params
> test
>   
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MARCHETYPES-61) Update quickstart to use JUnit 5

2018-10-13 Thread Dmitry Timofeev (JIRA)


 [ 
https://issues.apache.org/jira/browse/MARCHETYPES-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dmitry Timofeev updated MARCHETYPES-61:
---
Description: 
Update quickstart archetype to generate a project using JUnit 5, the next 
version of the most popular testing framework.

Currently one has to include _at least_ two dependencies on JUnit 5 artefacts 
to enable surefire to run them: junit-jupiter-api and junit-jupiter-engine.

Possible structure of dependencies:
{code:java}

  

  org.junit
  junit-bom
  5.3.1
  pom
  import

  



  
org.junit.jupiter
junit-jupiter-api
test
  

  
org.junit.jupiter
junit-jupiter-engine
test
  

  
  
org.junit.jupiter
junit-jupiter-params
test
  
{code}

> Update quickstart to use JUnit 5
> 
>
> Key: MARCHETYPES-61
> URL: https://issues.apache.org/jira/browse/MARCHETYPES-61
> Project: Maven Archetype Bundles
>  Issue Type: Improvement
>Reporter: Dmitry Timofeev
>Priority: Major
>
> Update quickstart archetype to generate a project using JUnit 5, the next 
> version of the most popular testing framework.
> Currently one has to include _at least_ two dependencies on JUnit 5 artefacts 
> to enable surefire to run them: junit-jupiter-api and junit-jupiter-engine.
> Possible structure of dependencies:
> {code:java}
> 
>   
> 
>   org.junit
>   junit-bom
>   5.3.1
>   pom
>   import
> 
>   
> 
> 
>   
> org.junit.jupiter
> junit-jupiter-api
> test
>   
>   
> org.junit.jupiter
> junit-jupiter-engine
> test
>   
>   
>   
> org.junit.jupiter
> junit-jupiter-params
> test
>   
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MARCHETYPES-61) Update quickstart to use JUnit 5

2018-10-13 Thread Dmitry Timofeev (JIRA)
Dmitry Timofeev created MARCHETYPES-61:
--

 Summary: Update quickstart to use JUnit 5
 Key: MARCHETYPES-61
 URL: https://issues.apache.org/jira/browse/MARCHETYPES-61
 Project: Maven Archetype Bundles
  Issue Type: Improvement
Reporter: Dmitry Timofeev






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)