[GitHub] [maven-deploy-plugin] khmarbaise commented on issue #8: Typo: customed → customized

2019-10-19 Thread GitBox
khmarbaise commented on issue #8: Typo: customed → customized 
URL: https://github.com/apache/maven-deploy-plugin/pull/8#issuecomment-544129503
 
 
   Merged into master. Thanks for your contribution.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-deploy-plugin] khmarbaise closed pull request #8: Typo: customed → customized

2019-10-19 Thread GitBox
khmarbaise closed pull request #8: Typo: customed → customized 
URL: https://github.com/apache/maven-deploy-plugin/pull/8
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-deploy-plugin] khmarbaise commented on issue #8: Typo: customed → customized

2019-10-19 Thread GitBox
khmarbaise commented on issue #8: Typo: customed → customized 
URL: https://github.com/apache/maven-deploy-plugin/pull/8#issuecomment-544122855
 
 
   I'll merge this...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-integration-testing] srdo commented on issue #50: [MNG-6759] - Add test demonstrating the issue where the wrong reposit…

2019-10-18 Thread GitBox
srdo commented on issue #50: [MNG-6759] - Add test demonstrating the issue 
where the wrong reposit…
URL: 
https://github.com/apache/maven-integration-testing/pull/50#issuecomment-544013139
 
 
   Fixed so the test now has no external dependencies.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-javadoc-plugin] michael-o commented on issue #32: [MJAVADOC-625] Support for multiple stylesheets

2019-10-18 Thread GitBox
michael-o commented on issue #32: [MJAVADOC-625] Support for multiple 
stylesheets
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/32#issuecomment-543942457
 
 
   I understand that, but if the original option can be called multiple times, 
it feels natural that this plugin supports this too.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-surefire] Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-18 Thread GitBox
Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing 
tests for JUnit5 
URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-543901329
 
 
   @quiram 
   If I understood the bug right in our code, it should be possible to 
reproduce it even without Spring Boot. You are trying to use the original 
commercial project and then you are reducing it somehow?
   Take your time, no worries, I will wait because this issue is important for 
reliability of this feature.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-surefire] quiram commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-18 Thread GitBox
quiram commented on issue #245: Surefire-1584: Add option to rerun failing 
tests for JUnit5 
URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-543898178
 
 
   I can't provide the exact case because that's internal code, and when I 
tried to produce a sample project I didn't manage to reproduce it, but I'll 
keep trying. @Col-E if you do create a new issue please let me know to continue 
the conversation there. Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-surefire] Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-18 Thread GitBox
Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing 
tests for JUnit5 
URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-543869144
 
 
   @Col-E 
   ok, :-) thx, but do it in a new PR and new branch. Delete the old branch 
because I modified yours (added tests and `restart()`) and now it is in master.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-surefire] Col-E commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-18 Thread GitBox
Col-E commented on issue #245: Surefire-1584: Add option to rerun failing tests 
for JUnit5 
URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-543864271
 
 
   I'll happily work on a fix for this bug as soon as an offending test case is 
produced :+1: 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-install-plugin] khmarbaise commented on issue #5: Fix typo in InstallMojo.java

2019-10-18 Thread GitBox
khmarbaise commented on issue #5: Fix typo in InstallMojo.java
URL: 
https://github.com/apache/maven-install-plugin/pull/5#issuecomment-543815266
 
 
   Is merged into master. Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-install-plugin] khmarbaise closed pull request #5: Fix typo in InstallMojo.java

2019-10-18 Thread GitBox
khmarbaise closed pull request #5: Fix typo in InstallMojo.java
URL: https://github.com/apache/maven-install-plugin/pull/5
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-install-plugin] dNhax commented on issue #5: Fix typo in InstallMojo.java

2019-10-18 Thread GitBox
dNhax commented on issue #5: Fix typo in InstallMojo.java
URL: 
https://github.com/apache/maven-install-plugin/pull/5#issuecomment-543806304
 
 
   You're welcome, glad that I could help. :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-install-plugin] khmarbaise commented on issue #5: Fix typo in InstallMojo.java

2019-10-18 Thread GitBox
khmarbaise commented on issue #5: Fix typo in InstallMojo.java
URL: 
https://github.com/apache/maven-install-plugin/pull/5#issuecomment-543804658
 
 
   Good catch.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-install-plugin] khmarbaise commented on issue #5: Fix typo in InstallMojo.java

2019-10-18 Thread GitBox
khmarbaise commented on issue #5: Fix typo in InstallMojo.java
URL: 
https://github.com/apache/maven-install-plugin/pull/5#issuecomment-543804884
 
 
   I will merge that. Thanks for your contribution.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-install-plugin] dNhax opened a new pull request #5: Fix typo in InstallMojo.java

2019-10-18 Thread GitBox
dNhax opened a new pull request #5: Fix typo in InstallMojo.java
URL: https://github.com/apache/maven-install-plugin/pull/5
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-surefire] Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-18 Thread GitBox
Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing 
tests for JUnit5 
URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-543774689
 
 
   > 
   > 
   > > @quiram
   > > An exception or assertion failure does not crash the code in Surefire 
and JUnit. These exceptions are properly handled by the JUnit.
   > 
   > Sorry, did you mean exception or extension? I was talking about JUnit 
Jupiter Extensions, not exceptions. I thought maybe the extension interacts 
with the test lifecycle in a way that clashes with surefire. However, it seems 
you have found the likely root cause, so I guess the extension is not a problem.
   
   I understood `exception`, sorry.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-surefire] quiram edited a comment on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-18 Thread GitBox
quiram edited a comment on issue #245: Surefire-1584: Add option to rerun 
failing tests for JUnit5 
URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-543758352
 
 
   > @quiram
   > An exception or assertion failure does not crash the code in Surefire and 
JUnit. These exceptions are properly handled by the JUnit.
   
   @Tibor17 
   Sorry, did you mean exception or extension? I was talking about JUnit 
Jupiter Extensions, not exceptions. I thought maybe the extension interacts 
with the test lifecycle in a way that clashes with surefire. However, it seems 
you have found the likely root cause, so I guess the extension is not a problem.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-surefire] quiram commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-18 Thread GitBox
quiram commented on issue #245: Surefire-1584: Add option to rerun failing 
tests for JUnit5 
URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-543758352
 
 
   > @quiram
   > An exception or assertion failure does not crash the code in Surefire and 
JUnit. These exceptions are properly handled by the JUnit.
   
   Sorry, did you mean exception or extension? I was talking about JUnit 
Jupiter Extensions, not exceptions. I thought maybe the extension interacts 
with the test lifecycle in a way that clashes with surefire. However, it seems 
you have found the likely root cause, so I guess the extension is not a problem.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-surefire] Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-18 Thread GitBox
Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing 
tests for JUnit5 
URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-543745287
 
 
   @quiram I will wait for @Col-E because i have investigated an issue in the 
code, see 
https://github.com/apache/maven-surefire/pull/245#issuecomment-543712421. After 
@Col-E would confirm the bug, we would fix it and prove it with a test from 
@quiram . Then we would be able to cute a new release version.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-surefire] Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-18 Thread GitBox
Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing 
tests for JUnit5 
URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-543742706
 
 
   @quiram 
   An exception or assertion failure does not crash the code in Surefire and 
JUnit. These exceptions are properly handled by the JUnit.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-surefire] quiram commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-18 Thread GitBox
quiram commented on issue #245: Surefire-1584: Add option to rerun failing 
tests for JUnit5 
URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-543741432
 
 
   One thing I can tell, in case it helps, is that the tests where I have 
witnessed this are Spring Boot tests that use the `SpringExtension`, maybe 
that's somehow causing some interaction?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-surefire] quiram commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-18 Thread GitBox
quiram commented on issue #245: Surefire-1584: Add option to rerun failing 
tests for JUnit5 
URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-543727605
 
 
   Hi @Col-E, I'm trying to create a repository with a sample project that 
demonstrates this but I haven't been able to do it yet. The feature does work 
correctly on a simple setting, so maybe something about the complexity on my 
project is triggering the failure. I'll try a few things to see if I can spot 
the error.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-surefire] Tibor17 edited a comment on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-18 Thread GitBox
Tibor17 edited a comment on issue #245: Surefire-1584: Add option to rerun 
failing tests for JUnit5 
URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-543712421
 
 
   @Col-E 
   I think I understand the problem. We consider the `adapter` been `stateless` 
in every loop.
   In reality we modify the collection of failures from the first set of 
failure and the adapter is `stateful`.
   
https://github.com/apache/maven-surefire/pull/245/commits/fe17751602f597d7b694ec8a65fc389aee0bac25#diff-b3a2904e92be87f11f2622fbfd122e31R152
   So my proposal is to grap the collection of failures and make a copy, and 
then iterate over the elements.
   I hope I got it right.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-surefire] Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-18 Thread GitBox
Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing 
tests for JUnit5 
URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-543712421
 
 
   @Col-E 
   I think I nderstand the problem. We consider the `adapter` been `stateless` 
in every loop.
   In reality we modify the collection of failures from the first set of 
failure and the adapter is `stateful`.
   
https://github.com/apache/maven-surefire/pull/245/commits/fe17751602f597d7b694ec8a65fc389aee0bac25#diff-b3a2904e92be87f11f2622fbfd122e31R152
   So my proposal is to grap the collection of failures and make a copy, and 
then iterate over the elements.
   I hope I got it right.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-surefire] Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-18 Thread GitBox
Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing 
tests for JUnit5 
URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-543702810
 
 
   Hi @Col-E  Matt,
   How are you.
   We have some issue with our feature. Can you pls talk with one of our user, 
for more information see his comment 
https://issues.apache.org/jira/browse/SUREFIRE-1584?focusedCommentId=16954490=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16954490
   Perhaps you already know what's going on. Thx


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-javadoc-plugin] schelldorfer commented on issue #32: [MJAVADOC-625] Support for multiple stylesheets

2019-10-18 Thread GitBox
schelldorfer commented on issue #32: [MJAVADOC-625] Support for multiple 
stylesheets
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/32#issuecomment-543676082
 
 
   When using "stylesheet" / "stylesheetfile", this overwrites the default 
javadoc stylesheet. There is no possibility with the current Maven Javadoc 
plugin to keep the default javadoc stylesheet and have an additional custom 
stylesheet.
   With this PR, this is possible (keep the default javadoc stylesheet and 
provide an additional custom stylesheet).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-javadoc-plugin] michael-o commented on issue #32: [MJAVADOC-625] Support for multiple stylesheets

2019-10-18 Thread GitBox
michael-o commented on issue #32: [MJAVADOC-625] Support for multiple 
stylesheets
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/32#issuecomment-543581574
 
 
   You won't lose the default one. The JIRA issue says that this adds 
additional ones to the main stylesheet. Did I misread the JIRA issue?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-javadoc-plugin] schelldorfer commented on issue #32: [MJAVADOC-625] Support for multiple stylesheets

2019-10-18 Thread GitBox
schelldorfer commented on issue #32: [MJAVADOC-625] Support for multiple 
stylesheets
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/32#issuecomment-543574817
 
 
   The main idea of this PR is to have an additional stylesheet without loosing 
the default stylesheet.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-wagon] michael-o commented on issue #57: WAGON-567: support retry on server side errors

2019-10-18 Thread GitBox
michael-o commented on issue #57: WAGON-567: support retry on server side errors
URL: https://github.com/apache/maven-wagon/pull/57#issuecomment-543542441
 
 
   Way better now, I will try to have a look at this this week.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-javadoc-plugin] michael-o commented on issue #32: [MJAVADOC-625] Support for multiple stylesheets

2019-10-18 Thread GitBox
michael-o commented on issue #32: [MJAVADOC-625] Support for multiple 
stylesheets
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/32#issuecomment-543540261
 
 
   Then I don't see the purpose of this incomplete PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-javadoc-plugin] schelldorfer commented on issue #32: [MJAVADOC-625] Support for multiple stylesheets

2019-10-17 Thread GitBox
schelldorfer commented on issue #32: [MJAVADOC-625] Support for multiple 
stylesheets
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/32#issuecomment-543312038
 
 
   Javadoc command line supports multiple additional stylesheets.
   This change here allows to configure one additional stylesheet in maven 
plugin.
   
   Since the normal configuration "stylesheet" / "stylesheetfile" overrides the 
default javadoc stylesheet, this configuration here allows to set one 
additional custom stylesheet without loosing default stylesheet.
   But yes, it's only one additional stylesheet and not multiple.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-javadoc-plugin] michael-o commented on issue #32: [MJAVADOC-625] Support for multiple stylesheets

2019-10-17 Thread GitBox
michael-o commented on issue #32: [MJAVADOC-625] Support for multiple 
stylesheets
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/32#issuecomment-543173925
 
 
   I am confused. [This](https://bugs.openjdk.java.net/browse/JDK-8189217) says 
it can be called multiples times, yet you have defined it as string?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-javadoc-plugin] schelldorfer opened a new pull request #32: [MJAVADOC-625] Support for multiple stylesheets

2019-10-17 Thread GitBox
schelldorfer opened a new pull request #32: [MJAVADOC-625] Support for multiple 
stylesheets
URL: https://github.com/apache/maven-javadoc-plugin/pull/32
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-wagon] michael-o commented on a change in pull request #57: WAGON-567: support retry on server side errors

2019-10-17 Thread GitBox
michael-o commented on a change in pull request #57: WAGON-567: support retry 
on server side errors
URL: https://github.com/apache/maven-wagon/pull/57#discussion_r335953078
 
 

 ##
 File path: 
wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
 ##
 @@ -451,6 +453,55 @@ private static HttpRequestRetryHandler 
createRetryHandler()
 }
 }
 
+/**
+ * The type of the serviceUnavailableRetryStrategy, defaults to {@code 
null}.
+ * Values can be {@link default DefaultServiceUnavailableRetryStrategy},
+ * or {@link standard StandardServiceUnavailableRetryStrategy},
 
 Review comment:
   put the "or" after that.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-wagon] michael-o commented on a change in pull request #57: WAGON-567: support retry on server side errors

2019-10-17 Thread GitBox
michael-o commented on a change in pull request #57: WAGON-567: support retry 
on server side errors
URL: https://github.com/apache/maven-wagon/pull/57#discussion_r335953176
 
 

 ##
 File path: 
wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
 ##
 @@ -451,6 +453,55 @@ private static HttpRequestRetryHandler 
createRetryHandler()
 }
 }
 
+/**
+ * The type of the serviceUnavailableRetryStrategy, defaults to {@code 
null}.
+ * Values can be {@link default DefaultServiceUnavailableRetryStrategy},
+ * or {@link standard StandardServiceUnavailableRetryStrategy},
+ * a fully qualified name class with a no-arg or null to not use a 
ServiceUnavailableRetryStrategy.
 
 Review comment:
   null > none


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-wagon] michael-o commented on a change in pull request #57: WAGON-567: support retry on server side errors

2019-10-17 Thread GitBox
michael-o commented on a change in pull request #57: WAGON-567: support retry 
on server side errors
URL: https://github.com/apache/maven-wagon/pull/57#discussion_r335952932
 
 

 ##
 File path: 
wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
 ##
 @@ -451,6 +453,55 @@ private static HttpRequestRetryHandler 
createRetryHandler()
 }
 }
 
+/**
+ * The type of the serviceUnavailableRetryStrategy, defaults to {@code 
null}.
 
 Review comment:
   Please update.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-wagon] michael-o commented on a change in pull request #57: WAGON-567: support retry on server side errors

2019-10-17 Thread GitBox
michael-o commented on a change in pull request #57: WAGON-567: support retry 
on server side errors
URL: https://github.com/apache/maven-wagon/pull/57#discussion_r335953719
 
 

 ##
 File path: 
wagon-providers/wagon-http/src/test/java/org/apache/maven/wagon/providers/http/AbstractHttpClientWagonTest.java
 ##
 @@ -58,7 +58,7 @@
 {
 @Ignore("This test is validating nothing and require internet connection 
which we should avoid so ignore it")
 public void test()
-throws Exception
+throws Exception
 
 Review comment:
   Please drop formattting changes in this class, they are unrelated


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-wagon] michael-o commented on a change in pull request #57: WAGON-567: support retry on server side errors

2019-10-17 Thread GitBox
michael-o commented on a change in pull request #57: WAGON-567: support retry 
on server side errors
URL: https://github.com/apache/maven-wagon/pull/57#discussion_r335438630
 
 

 ##
 File path: 
wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
 ##
 @@ -451,6 +453,54 @@ private static HttpRequestRetryHandler 
createRetryHandler()
 }
 }
 
+/**
+ * The type of the serviceUnavailableRetryStrategy, defaults to {@code 
null}.
+ * Values can be {@link default DefaultServiceUnavailableRetryStrategy},
+ * or {@link standard SimpleHttpRequestRetryHandler},
+ * a fully qualified name class with a no-arg or null to not use a 
ServiceUnavailableRetryStrategy.
+ */
+private static final String SERVICE_UNAVAILABLE_RETRY_STRATEGY_CLASS =
+System.getProperty( 
"maven.wagon.http.serviceUnavailableRetryStrategy.class", "null" );
+
+/**
+ * Interval in milliseconds between retries when using a 
serviceUnavailableRetryStrategy.
+ * 1000 by default
+ */
+private static final int SERVICE_UNAVAILABLE_RETRY_STRATEGY_RETRY_INTERVAL 
=
+Integer.parseInt( System.getProperty( 
"maven.wagon.http.serviceUnavailableRetryStrategy.retryInterval", "1000" ) );
+
+/**
+ * Maximum number of retries when using a serviceUnavailableRetryStrategy.
+ * 5 by default
+ */
+private static final int SERVICE_UNAVAILABLE_RETRY_STRATEGY_MAX_RETRIES =
 
 Review comment:
   Use `Integer.getInteger()` for that.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-surefire] Tibor17 merged pull request #244: [SUREFIRE-1679] Prevent classpath caching from causing pollution

2019-10-17 Thread GitBox
Tibor17 merged pull request #244: [SUREFIRE-1679] Prevent classpath caching 
from causing pollution
URL: https://github.com/apache/maven-surefire/pull/244
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-javadoc-plugin] schelldorfer opened a new pull request #31: [MJAVADOC-624] tagletArtifacts throws exception in case artifact is a Java 9+ module

2019-10-17 Thread GitBox
schelldorfer opened a new pull request #31: [MJAVADOC-624] tagletArtifacts 
throws exception in case artifact is a Java 9+ module
URL: https://github.com/apache/maven-javadoc-plugin/pull/31
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-wagon] zymzxq commented on issue #57: WAGON-567: support retry on server side errors

2019-10-16 Thread GitBox
zymzxq commented on issue #57: WAGON-567: support retry on server side errors
URL: https://github.com/apache/maven-wagon/pull/57#issuecomment-542952547
 
 
   Agree >=500 is too coarse grained. I'd also like to check 500 and 502 as 
well. AWS s3, which we redirect our maven download requests to,  returns 500 
when it has problems and expects client to retry. We also experienced s3 
returned 502 when it had issues. AWS document: 
https://stash.atlassian.com/projects/BUILDENG/repos/buildeng-plan-templates/pull-requests/1024/overview
   
   Happy to remove the non standard 420 check.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-16 Thread GitBox
eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base 
for build/consumer process
URL: https://github.com/apache/maven/pull/286#discussion_r335714696
 
 

 ##
 File path: maven-xml/src/main/java/org/apache/maven/xml/Factories.java
 ##
 @@ -0,0 +1,118 @@
+package org.apache.maven.xml;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import javax.xml.XMLConstants;
+import javax.xml.parsers.ParserConfigurationException;
+import javax.xml.parsers.SAXParser;
+import javax.xml.parsers.SAXParserFactory;
+import javax.xml.transform.TransformerFactory;
+
+import org.xml.sax.SAXException;
+import org.xml.sax.SAXNotRecognizedException;
+import org.xml.sax.SAXNotSupportedException;
+import org.xml.sax.XMLReader;
+
+/**
+ * Creates XML related factories with OWASP advices applied
+ * 
+ * @author Robert Scholte
+ * @since 3.7.0
+ */
+public final class Factories
 
 Review comment:
Very good!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-16 Thread GitBox
eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base 
for build/consumer process
URL: https://github.com/apache/maven/pull/286#discussion_r335714225
 
 

 ##
 File path: 
maven-model-builder/src/main/java/org/apache/maven/feature/Features.java
 ##
 @@ -0,0 +1,63 @@
+package org.apache.maven.feature;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/**
+ * Centralized class for feature information
+ * 
+ * @author Robert Scholte
+ * @since 3.7.0
+ */
+public final class Features
 
 Review comment:
   Cool


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-16 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base 
for build/consumer process
URL: https://github.com/apache/maven/pull/286#discussion_r335708221
 
 

 ##
 File path: maven-xml/src/main/java/org/apache/maven/xml/SAXEventUtils.java
 ##
 @@ -0,0 +1,38 @@
+package org.apache.maven.xml;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/**
+ * Utility class for SAXEvents
+ * 
+ * @author Robert Scholte
+ * @since 4.0.0
+ */
+public final class SAXEventUtils
+{
+private SAXEventUtils()
+{
+}
+
+public static String renameQName( String oldQName, String newLocalName )
+{
+return oldQName.replaceFirst( "[^:]+$", newLocalName );
 
 Review comment:
   Fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-dependency-plugin] mthmulders commented on issue #22: [MDEP-626] Upgrade maven-reporting-impl

2019-10-16 Thread GitBox
mthmulders commented on issue #22: [MDEP-626] Upgrade maven-reporting-impl
URL: 
https://github.com/apache/maven-dependency-plugin/pull/22#issuecomment-542871275
 
 
   You're welcome, happy to be able to contribute :-)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-dependency-plugin] khmarbaise closed pull request #22: [MDEP-626] Upgrade maven-reporting-impl

2019-10-16 Thread GitBox
khmarbaise closed pull request #22: [MDEP-626] Upgrade maven-reporting-impl
URL: https://github.com/apache/maven-dependency-plugin/pull/22
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-dependency-plugin] khmarbaise commented on issue #22: [MDEP-626] Upgrade maven-reporting-impl

2019-10-16 Thread GitBox
khmarbaise commented on issue #22: [MDEP-626] Upgrade maven-reporting-impl
URL: 
https://github.com/apache/maven-dependency-plugin/pull/22#issuecomment-542869458
 
 
   So I have merged your PR to master and close the appropriate jira issue as 
well. Many thanks for your contribution.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-dependency-plugin] khmarbaise commented on issue #22: [MDEP-626] Upgrade maven-reporting-impl

2019-10-16 Thread GitBox
khmarbaise commented on issue #22: [MDEP-626] Upgrade maven-reporting-impl
URL: 
https://github.com/apache/maven-dependency-plugin/pull/22#issuecomment-542824519
 
 
   So rebased and squashed the commits into a single one...waiting for CI 
afterwards I will merge them into master. Thanks for your contribution.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-surefire] Tibor17 edited a comment on issue #233: [SUREFIRE-1494] default provider for JUnit4 integration tests is changed (from 'surefire-junit4' to 'surefire-junit47')

2019-10-16 Thread GitBox
Tibor17 edited a comment on issue #233: [SUREFIRE-1494] default provider for 
JUnit4 integration tests is changed (from 'surefire-junit4' to 
'surefire-junit47')
URL: https://github.com/apache/maven-surefire/pull/233#issuecomment-542715553
 
 
   @dejan2609 
   I had to concentrate mostly on my private life and concentrate only on ASF 
issues which must be solved at right time. This issue we are talking about in 
this PR is important but it has time to finish later in a version where the 
breaking behavior would make sense. So therefore I relaxed with this issue a 
bit and worked on the issues which cannot be postponed. There is a list of PRs 
which need to be seen at later time but it does not mean that they will be 
ignored.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-surefire] Tibor17 commented on issue #233: [SUREFIRE-1494] default provider for JUnit4 integration tests is changed (from 'surefire-junit4' to 'surefire-junit47')

2019-10-16 Thread GitBox
Tibor17 commented on issue #233: [SUREFIRE-1494] default provider for JUnit4 
integration tests is changed (from 'surefire-junit4' to 'surefire-junit47')
URL: https://github.com/apache/maven-surefire/pull/233#issuecomment-542715553
 
 
   @dejan2609 
   I had to concentrate mostly on my private life and concentrate only on ASF 
issues which must be solved at right time. This issue we are talking about in 
this PR is important but it has time to finish later in a version where the 
breaking the behavior would make sense. So therefore I relaxed with this issue 
a bit and worked on the issues which cannot be postponed. There is a list of 
PRs which need to be seen at later time but it does not mean that they will be 
ignored.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-surefire] dejan2609 commented on issue #233: [SUREFIRE-1494] default provider for JUnit4 integration tests is changed (from 'surefire-junit4' to 'surefire-junit47')

2019-10-16 Thread GitBox
dejan2609 commented on issue #233: [SUREFIRE-1494] default provider for JUnit4 
integration tests is changed (from 'surefire-junit4' to 'surefire-junit47')
URL: https://github.com/apache/maven-surefire/pull/233#issuecomment-542712625
 
 
   @Tibor17 Just a reminder for this (I guess you are all over the place and 
hence this is not in your sight).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-wagon] michael-o commented on a change in pull request #57: WAGON-567: support retry on server side errors

2019-10-16 Thread GitBox
michael-o commented on a change in pull request #57: WAGON-567: support retry 
on server side errors
URL: https://github.com/apache/maven-wagon/pull/57#discussion_r335438630
 
 

 ##
 File path: 
wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
 ##
 @@ -451,6 +453,54 @@ private static HttpRequestRetryHandler 
createRetryHandler()
 }
 }
 
+/**
+ * The type of the serviceUnavailableRetryStrategy, defaults to {@code 
null}.
+ * Values can be {@link default DefaultServiceUnavailableRetryStrategy},
+ * or {@link standard SimpleHttpRequestRetryHandler},
+ * a fully qualified name class with a no-arg or null to not use a 
ServiceUnavailableRetryStrategy.
+ */
+private static final String SERVICE_UNAVAILABLE_RETRY_STRATEGY_CLASS =
+System.getProperty( 
"maven.wagon.http.serviceUnavailableRetryStrategy.class", "null" );
+
+/**
+ * Interval in milliseconds between retries when using a 
serviceUnavailableRetryStrategy.
+ * 1000 by default
+ */
+private static final int SERVICE_UNAVAILABLE_RETRY_STRATEGY_RETRY_INTERVAL 
=
+Integer.parseInt( System.getProperty( 
"maven.wagon.http.serviceUnavailableRetryStrategy.retryInterval", "1000" ) );
+
+/**
+ * Maximum number of retries when using a serviceUnavailableRetryStrategy.
+ * 5 by default
+ */
+private static final int SERVICE_UNAVAILABLE_RETRY_STRATEGY_MAX_RETRIES =
 
 Review comment:
   Use `Integer.getIntger()` for that.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-wagon] michael-o commented on a change in pull request #57: WAGON-567: support retry on server side errors

2019-10-16 Thread GitBox
michael-o commented on a change in pull request #57: WAGON-567: support retry 
on server side errors
URL: https://github.com/apache/maven-wagon/pull/57#discussion_r335445557
 
 

 ##
 File path: 
wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/StandardServiceUnavailableRetryStrategy.java
 ##
 @@ -28,17 +28,13 @@
 import org.apache.http.util.Args;
 
 /**
- * An implementation of the {@link SimpleServiceUnavailableRetryStrategy} 
interface.
+ * An implementation of the {@link ServiceUnavailableRetryStrategy} interface.
  * that retries {@code 408} (Request Timeout), {@code 420} (Method Failure), 
{@code 429} (Too Many Requests),
  * and {@code 500} (Server side error) responses for a fixed number of times 
at a fixed interval.
  */
 @Contract( threading = ThreadingBehavior.IMMUTABLE )
-public class SimpleServiceUnavailableRetryStrategy implements 
ServiceUnavailableRetryStrategy
+public class StandardServiceUnavailableRetryStrategy implements 
ServiceUnavailableRetryStrategy
 
 Review comment:
   I am not convinced that this should be really called standard because of >= 
500 and there seems to many intepretations of 420 and all of them are 
deprecated or not present: 
https://www.whoishostingthis.com/resources/http-status-codes/#method-failure-400.
   
   I am fine with 408, 421, 503 and 504. 
   
   Please tell me why all 5xy are necessary.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-wagon] michael-o commented on a change in pull request #57: WAGON-567: support retry on server side errors

2019-10-16 Thread GitBox
michael-o commented on a change in pull request #57: WAGON-567: support retry 
on server side errors
URL: https://github.com/apache/maven-wagon/pull/57#discussion_r335438573
 
 

 ##
 File path: 
wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
 ##
 @@ -451,6 +453,54 @@ private static HttpRequestRetryHandler 
createRetryHandler()
 }
 }
 
+/**
+ * The type of the serviceUnavailableRetryStrategy, defaults to {@code 
null}.
+ * Values can be {@link default DefaultServiceUnavailableRetryStrategy},
+ * or {@link standard SimpleHttpRequestRetryHandler},
+ * a fully qualified name class with a no-arg or null to not use a 
ServiceUnavailableRetryStrategy.
+ */
+private static final String SERVICE_UNAVAILABLE_RETRY_STRATEGY_CLASS =
+System.getProperty( 
"maven.wagon.http.serviceUnavailableRetryStrategy.class", "null" );
 
 Review comment:
   Why not use a real `null`? Or better `none`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-wagon] michael-o commented on a change in pull request #57: WAGON-567: support retry on server side errors

2019-10-16 Thread GitBox
michael-o commented on a change in pull request #57: WAGON-567: support retry 
on server side errors
URL: https://github.com/apache/maven-wagon/pull/57#discussion_r335438381
 
 

 ##
 File path: 
wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
 ##
 @@ -451,6 +453,54 @@ private static HttpRequestRetryHandler 
createRetryHandler()
 }
 }
 
+/**
+ * The type of the serviceUnavailableRetryStrategy, defaults to {@code 
null}.
+ * Values can be {@link default DefaultServiceUnavailableRetryStrategy},
+ * or {@link standard SimpleHttpRequestRetryHandler},
+ * a fully qualified name class with a no-arg or null to not use a 
ServiceUnavailableRetryStrategy.
+ */
+private static final String SERVICE_UNAVAILABLE_RETRY_STRATEGY_CLASS =
+System.getProperty( 
"maven.wagon.http.serviceUnavailableRetryStrategy.class", "null" );
+
+/**
+ * Interval in milliseconds between retries when using a 
serviceUnavailableRetryStrategy.
+ * 1000 by default
+ */
+private static final int SERVICE_UNAVAILABLE_RETRY_STRATEGY_RETRY_INTERVAL 
=
+Integer.parseInt( System.getProperty( 
"maven.wagon.http.serviceUnavailableRetryStrategy.retryInterval", "1000" ) );
 
 Review comment:
   Use `Integer.getIntger()` for that.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] rfscholte commented on issue #286: [MNG-6656] Introduce base for build/consumer process

2019-10-15 Thread GitBox
rfscholte commented on issue #286: [MNG-6656] Introduce base for build/consumer 
process
URL: https://github.com/apache/maven/pull/286#issuecomment-542386341
 
 
   I've moved the second read of the `pom.xml` with the additional 
BuildPomXMLFilters directly after the initial read of the pom, but before 
inheritence, filtering, etc. . This also means that right now the rawModel is 
the result of the second read, and does not represent the original pom.
   I'm still considering this choice. Which one is more important? When is the 
rawModel used and why? Do we need both results?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-15 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base 
for build/consumer process
URL: https://github.com/apache/maven/pull/286#discussion_r335150201
 
 

 ##
 File path: 
maven-xml/src/test/java/org/apache/maven/xml/filter/AbstractXMLFilterTests.java
 ##
 @@ -0,0 +1,95 @@
+package org.apache.maven.xml.filter;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.Reader;
+import java.io.StringReader;
+import java.io.StringWriter;
+import java.io.Writer;
+
+import javax.xml.parsers.ParserConfigurationException;
+import javax.xml.parsers.SAXParserFactory;
+import javax.xml.transform.OutputKeys;
+import javax.xml.transform.Transformer;
+import javax.xml.transform.TransformerException;
+import javax.xml.transform.TransformerFactory;
+import javax.xml.transform.sax.SAXSource;
+import javax.xml.transform.stream.StreamResult;
+
+import org.xml.sax.InputSource;
+import org.xml.sax.SAXException;
+import org.xml.sax.XMLFilter;
+
+public abstract class AbstractXMLFilterTests
+{
+public AbstractXMLFilterTests()
+{
+super();
+}
+
+protected abstract XMLFilter getFilter() throws TransformerException, 
SAXException, ParserConfigurationException;
+
+private void setParent( XMLFilter filter ) throws SAXException, 
ParserConfigurationException
+{
+if( filter.getParent() == null )
+{
+filter.setParent( 
SAXParserFactory.newInstance().newSAXParser().getXMLReader() );
+filter.setFeature( "http://xml.org/sax/features/namespaces;, true 
);
+}
+}
+
+protected String transform( String input )
+throws TransformerException, SAXException, ParserConfigurationException
+{
+return transform( new StringReader( input ) );
+}
+
+protected String transform( Reader input ) throws TransformerException, 
SAXException, ParserConfigurationException
+{
+XMLFilter filter = getFilter();
+setParent( filter );
+return transform( input, filter );
+}
+
+protected String transform( String input, XMLFilter filter ) 
+throws TransformerException, SAXException, ParserConfigurationException
+{
+setParent( filter );
+return transform( new StringReader( input ), filter );
+}
+
+protected String transform( Reader input, XMLFilter filter )
+throws TransformerException, SAXException, ParserConfigurationException
+{
+
+Writer writer = new StringWriter();
+StreamResult result = new StreamResult( writer );
+
+TransformerFactory transformerFactory = 
TransformerFactory.newInstance();
 
 Review comment:
   See `org.apache.maven.xml.Factories`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-15 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base 
for build/consumer process
URL: https://github.com/apache/maven/pull/286#discussion_r335149892
 
 

 ##
 File path: maven-xml/src/main/java/org/apache/maven/xml/SAXEventFactory.java
 ##
 @@ -0,0 +1,111 @@
+package org.apache.maven.xml;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.xml.sax.Attributes;
+import org.xml.sax.ContentHandler;
+import org.xml.sax.Locator;
+
+/**
+ * Factory for SAXEvents
+ * 
+ * @author Robert Scholte
+ * @since 4.0.0
 
 Review comment:
   Version fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-15 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base 
for build/consumer process
URL: https://github.com/apache/maven/pull/286#discussion_r335149716
 
 

 ##
 File path: maven-xml/src/main/java/org/apache/maven/xml/SAXEventUtils.java
 ##
 @@ -0,0 +1,38 @@
+package org.apache.maven.xml;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/**
+ * Utility class for SAXEvents
+ * 
+ * @author Robert Scholte
+ * @since 4.0.0
 
 Review comment:
   Fixed version


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-15 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base 
for build/consumer process
URL: https://github.com/apache/maven/pull/286#discussion_r335149584
 
 

 ##
 File path: 
maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
 ##
 @@ -733,12 +758,81 @@ private void checkPluginVersions( List 
lineage, ModelBuildingRequest
 private void assembleInheritance( List lineage, 
ModelBuildingRequest request,
   ModelProblemCollector problems )
 {
-for ( int i = lineage.size() - 2; i >= 0; i-- )
+for ( int i = lineage.size() - 2; i >= 1; i-- )
 {
 Model parent = lineage.get( i + 1 ).getModel();
 Model child = lineage.get( i ).getModel();
 inheritanceAssembler.assembleModelInheritance( child, parent, 
request, problems );
 }
+
+// re-read model from file
+if ( Boolean.getBoolean( "maven.experimental.buildconsumer" ) && 
request.isTransformPom() )
+{
+try
+{
+// TODO: parent might be part of reactor... better read all 
lineage items like this?
+Model parent = lineage.get( 1 ).getModel();
+
+Model child = modelProcessor.read( transformData( lineage.get( 
0 ) ), null );
+inheritanceAssembler.assembleModelInheritance( child, parent, 
request, problems );
+
+// sync pomfile, is transient
+child.setPomFile( lineage.get( 0 ).getModel().getPomFile() );
+// overwrite child
+lineage.get( 0 ).setModel( child );
+}
+catch ( IOException | TransformException | SAXException | 
ParserConfigurationException e )
+{
+// this is second read, should not happen
+e.printStackTrace();
 
 Review comment:
   This has been replaced. I noticed that the ModelBuilder doesn't contain a 
dependency on a logging framework. Assuming the modelbuilder artifact is used 
by other tools too, I can imagine that logging here is not preferred. Instead 
the ProblemCollector should be used.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-15 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base 
for build/consumer process
URL: https://github.com/apache/maven/pull/286#discussion_r335147909
 
 

 ##
 File path: 
maven-core/src/main/java/org/apache/maven/xml/internal/DefaultBuildPomXMLFilterFactory.java
 ##
 @@ -0,0 +1,117 @@
+package org.apache.maven.xml.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+
+import java.nio.file.Path;
+import java.util.Optional;
+import java.util.function.Function;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import org.apache.maven.execution.MavenSession;
+import org.apache.maven.model.Model;
+import org.apache.maven.model.building.ModelCacheManager;
+import org.apache.maven.xml.filter.BuildPomXMLFilterFactory;
+import org.apache.maven.xml.filter.DependencyKey;
+import org.apache.maven.xml.filter.RelativeProject;
+
+/**
+ * 
+ * @author Robert Scholte
+ * @since 3.7.0
+ */
+@Named
+@Singleton
+public class DefaultBuildPomXMLFilterFactory extends BuildPomXMLFilterFactory
+{
+private MavenSession session;
+
+@Inject
+private ModelCacheManager rawModelCache; 
+
+@Inject
+public DefaultBuildPomXMLFilterFactory( MavenSession session )
+{
+this.session = session;
+}
+
+@Override
+protected Optional getChangelist()
+{
+return Optional.ofNullable( session.getUserProperties().getProperty( 
"changelist" ) );
+}
+
+@Override
+protected Optional getRevision()
+{
+return Optional.ofNullable( session.getUserProperties().getProperty( 
"revision" ) );
+}
+
+@Override
+protected Optional getSha1()
+{
+return Optional.ofNullable( session.getUserProperties().getProperty( 
"sha1" ) );
+}
+
+@Override
+protected Function> getRelativePathMapper()
+{
+return p -> Optional.ofNullable( rawModelCache.get( p ) ).map( m -> 
toRelativeProject( m ) );
+}
+
+@Override
+protected Function getDependencyKeyToVersionMapper()
+{
+return k -> Optional.ofNullable( rawModelCache.get( k ) )
+.map( m -> toVersion( m ) )
+.orElse( null );
+}
+
+private RelativeProject toRelativeProject( final Model m )
 
 Review comment:
   Fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-15 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base 
for build/consumer process
URL: https://github.com/apache/maven/pull/286#discussion_r335147791
 
 

 ##
 File path: 
maven-core/src/main/java/org/apache/maven/xml/internal/DefaultBuildPomXMLFilterFactory.java
 ##
 @@ -0,0 +1,117 @@
+package org.apache.maven.xml.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+
+import java.nio.file.Path;
+import java.util.Optional;
+import java.util.function.Function;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import org.apache.maven.execution.MavenSession;
+import org.apache.maven.model.Model;
+import org.apache.maven.model.building.ModelCacheManager;
+import org.apache.maven.xml.filter.BuildPomXMLFilterFactory;
+import org.apache.maven.xml.filter.DependencyKey;
+import org.apache.maven.xml.filter.RelativeProject;
+
+/**
+ * 
+ * @author Robert Scholte
+ * @since 3.7.0
+ */
+@Named
+@Singleton
+public class DefaultBuildPomXMLFilterFactory extends BuildPomXMLFilterFactory
+{
+private MavenSession session;
+
+@Inject
+private ModelCacheManager rawModelCache; 
+
+@Inject
+public DefaultBuildPomXMLFilterFactory( MavenSession session )
+{
+this.session = session;
+}
+
+@Override
+protected Optional getChangelist()
+{
+return Optional.ofNullable( session.getUserProperties().getProperty( 
"changelist" ) );
+}
+
+@Override
+protected Optional getRevision()
+{
+return Optional.ofNullable( session.getUserProperties().getProperty( 
"revision" ) );
+}
+
+@Override
+protected Optional getSha1()
+{
+return Optional.ofNullable( session.getUserProperties().getProperty( 
"sha1" ) );
+}
+
+@Override
+protected Function> getRelativePathMapper()
+{
+return p -> Optional.ofNullable( rawModelCache.get( p ) ).map( m -> 
toRelativeProject( m ) );
+}
+
+@Override
+protected Function getDependencyKeyToVersionMapper()
+{
+return k -> Optional.ofNullable( rawModelCache.get( k ) )
+.map( m -> toVersion( m ) )
+.orElse( null );
+}
+
+private RelativeProject toRelativeProject( final Model m )
+{
+String groupId = m.getGroupId();
+if ( groupId == null && m.getParent() != null )
+{
+groupId = m.getParent().getGroupId();
+}
+
+String version = m.getVersion();
+if ( version == null && m.getParent() != null )
+{
+version = m.getParent().getVersion();
+}
+
+return new RelativeProject( groupId, m.getArtifactId(), version );
+}
+
+private String toVersion( final Model m )
 
 Review comment:
   Fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-15 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base 
for build/consumer process
URL: https://github.com/apache/maven/pull/286#discussion_r335147360
 
 

 ##
 File path: 
maven-core/src/main/java/org/apache/maven/xml/filter/FastForwardFilter.java
 ##
 @@ -0,0 +1,128 @@
+package org.apache.maven.xml.filter;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.ArrayDeque;
+import java.util.Deque;
+
+import org.xml.sax.Attributes;
+import org.xml.sax.ContentHandler;
+import org.xml.sax.SAXException;
+import org.xml.sax.XMLFilter;
+import org.xml.sax.XMLReader;
+import org.xml.sax.helpers.XMLFilterImpl;
+
+/**
+ * This filter will skip all following filters and write directly to the 
output.
+ * Should be used in case of a DOM that should not be effected by other 
filters, even though the elements match 
+ * 
+ * @author Robert Scholte
+ * @since 4.0.0
 
 Review comment:
   Fixed version


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-15 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base 
for build/consumer process
URL: https://github.com/apache/maven/pull/286#discussion_r335147203
 
 

 ##
 File path: 
maven-core/src/main/java/org/apache/maven/xml/filter/ConsumerPomXMLFilter.java
 ##
 @@ -0,0 +1,73 @@
+package org.apache.maven.xml.filter;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import javax.xml.parsers.ParserConfigurationException;
+import javax.xml.parsers.SAXParserFactory;
+
+import org.xml.sax.SAXException;
+import org.xml.sax.XMLFilter;
+import org.xml.sax.XMLReader;
+
+import org.xml.sax.helpers.XMLFilterImpl;
+
+/**
+ * XML Filter to transform pom.xml to consumer pom.
+ * This often means stripping of build-specific information.
+ * 
+ * This filter is used at 2 locations:
+ * - {@link 
org.apache.maven.internal.aether.DefaultRepositorySystemSessionFactory} when 
publishing pom files.
+ * - TODO ???Class when a reactor module is used as dependency. This ensures 
consistency of dependency handling
 
 Review comment:
   Fixed javadoc


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-15 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base 
for build/consumer process
URL: https://github.com/apache/maven/pull/286#discussion_r335146663
 
 

 ##
 File path: 
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java
 ##
 @@ -238,9 +263,83 @@ else if ( request.isUpdateSnapshots() )
 mavenRepositorySystem.injectProxy( session, 
request.getPluginArtifactRepositories() );
 mavenRepositorySystem.injectAuthentication( session, 
request.getPluginArtifactRepositories() );
 
+if ( Boolean.getBoolean( "maven.experimental.buildconsumer" ) )
+{
+session.setFileTransformerManager( newFileTransformerManager() );
+}
 return session;
 }
 
+private FileTransformerManager newFileTransformerManager()
+{
+return new FileTransformerManager()
+{
+@Override
+public Collection getTransformersForArtifact( 
final Artifact artifact )
+{
+Collection transformers = new ArrayList<>();
+if ( "pom".equals( artifact.getExtension() ) )
+{
+final TransformerFactory transformerFactory = 
TransformerFactory.newInstance();
 
 Review comment:
   Introduced the class `org.apache.maven.xml.Factories`, which contain methods 
to create new instances with preferred properties.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-dependency-plugin] khmarbaise commented on issue #22: [MDEP-626] Upgrade maven-reporting-impl

2019-10-15 Thread GitBox
khmarbaise commented on issue #22: [MDEP-626] Upgrade maven-reporting-impl
URL: 
https://github.com/apache/maven-dependency-plugin/pull/22#issuecomment-542323632
 
 
   Ok pulled the changed and pushed to the branch so lets take break and see 
what CI says now 
https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven-dependency-plugin/job/mthmulders-MDEP-626-mthmulders/


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-scm] michael-o merged pull request #93: add closing slash to scm tag

2019-10-15 Thread GitBox
michael-o merged pull request #93: add closing slash to scm tag
URL: https://github.com/apache/maven-scm/pull/93
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-scm] mkultra329 opened a new pull request #93: add closing slash to scm tag

2019-10-15 Thread GitBox
mkultra329 opened a new pull request #93: add closing slash to scm tag
URL: https://github.com/apache/maven-scm/pull/93
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-dependency-plugin] mthmulders commented on issue #22: [MDEP-626] Upgrade maven-reporting-impl

2019-10-15 Thread GitBox
mthmulders commented on issue #22: [MDEP-626] Upgrade maven-reporting-impl
URL: 
https://github.com/apache/maven-dependency-plugin/pull/22#issuecomment-542085970
 
 
   That's right! I've upgraded Doxia and added the doxia-core module. 
Integration tests succeeded on my machine.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-15 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base 
for build/consumer process
URL: https://github.com/apache/maven/pull/286#discussion_r334773548
 
 

 ##
 File path: 
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java
 ##
 @@ -238,9 +263,83 @@ else if ( request.isUpdateSnapshots() )
 mavenRepositorySystem.injectProxy( session, 
request.getPluginArtifactRepositories() );
 mavenRepositorySystem.injectAuthentication( session, 
request.getPluginArtifactRepositories() );
 
+if ( Boolean.getBoolean( "maven.experimental.buildconsumer" ) )
 
 Review comment:
   The number of locations went beyond 4, so something had to be improved. 
Introduced a Features class, where you can easily switch the default value.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-15 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base 
for build/consumer process
URL: https://github.com/apache/maven/pull/286#discussion_r334773151
 
 

 ##
 File path: 
maven-xml/src/main/java/org/apache/maven/xml/filter/DependencyKey.java
 ##
 @@ -0,0 +1,88 @@
+package org.apache.maven.xml.filter;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.Objects;
+
+/**
+ * 
+ * @author Robert Scholte
+ * @since 3.7.0
+ */
+public class DependencyKey
+{
+private final String groupId;
+
+private final String artifactId;
+
+public DependencyKey( String groupId, String artifactId )
+{
+this.groupId = groupId;
+this.artifactId = artifactId;
 
 Review comment:
   Done


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-15 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base 
for build/consumer process
URL: https://github.com/apache/maven/pull/286#discussion_r334772817
 
 

 ##
 File path: 
maven-xml/src/test/java/org/apache/maven/xml/filter/ConsumerPomXMLFilterTest.java
 ##
 @@ -0,0 +1,168 @@
+package org.apache.maven.xml.filter;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import static org.xmlunit.assertj.XmlAssert.assertThat;
+
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.Optional;
+import java.util.function.Function;
+
+import javax.inject.Provider;
+import javax.xml.parsers.ParserConfigurationException;
+
+import org.junit.Test;
+import org.xml.sax.SAXException;
+import org.xml.sax.XMLFilter;
+
+public class ConsumerPomXMLFilterTest extends AbstractXMLFilterTests
+{
+@Override
+protected XMLFilter getFilter() throws SAXException, 
ParserConfigurationException
+{
+final BuildPomXMLFilterFactory buildPomXMLFilterFactory = new 
BuildPomXMLFilterFactory()
+{
+@Override
+protected Optional getSha1()
+{
+return Optional.empty();
+}
+
+@Override
+protected Optional getRevision()
+{
+return Optional.empty();
+}
+
+@Override
+protected Optional getChangelist()
+{
+return Optional.of( "CL" );
+}
+
+@Override
+protected Function> 
getRelativePathMapper()
+{
+return null;
+}
+
+@Override
+protected Function 
getDependencyKeyToVersionMapper()
+{
+return null;
+}
+};
+
+Provider provider = new 
Provider()
+{
+
+@Override
+public BuildPomXMLFilterFactory get()
+{
+return buildPomXMLFilterFactory;
+}
+};
+
+XMLFilter filter = new ConsumerPomXMLFilterFactory( provider )
+{
+}.get( Paths.get( "pom.xml" ) );
+filter.setFeature( "http://xml.org/sax/features/namespaces;, true );
+return filter;
+}
+
+@Test
+public void testAllFilters() throws Exception {
+String input = "\n"
+ + "  \n"
+ + "GROUPID\n"
+ + "PARENT\n"
+ + "VERSION\n"
+ + "../pom.xml\n"
+ + "  \n"
+ + "  PROJECT\n"
+ + "  \n"
+ + "ab\n"
+ + "../cd\n"
+ + "  \n"
+ + "";
+String expected = "\n"
++ "  \n"
++ "GROUPID\n"
++ "PARENT\n"
++ "VERSION\n"
++ "\n"
++ "  \n"
++ "  PROJECT\n"
++ "";
+String actual = transform( input );
+assertThat( actual ).and( expected ).ignoreWhitespace().areIdentical();
+}
+
+@Test
+public void testMe() throws Exception {
+String input = "\r\n" + 
+"http://maven.apache.org/POM/4.0.0\; \r\n" + 
+" 
xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"\r\n; + 
+" xsi:schemaLocation=\"http://maven.apache.org/POM/4.0.0 
\r\n" + 
+" 
http://maven.apache.org/maven-v4_0_0.xsd\;>\r\n" + 
 
 Review comment:
   I've created https://issues.apache.org/jira/browse/MNG-6778 to fix that in 
the official poms.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-15 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base 
for build/consumer process
URL: https://github.com/apache/maven/pull/286#discussion_r334772348
 
 

 ##
 File path: 
maven-core/src/test/java/org/apache/maven/xml/filter/ConsumerPomXMLFilterTest.java
 ##
 @@ -0,0 +1,64 @@
+package org.apache.maven.xml.filter;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import static org.xmlunit.assertj.XmlAssert.assertThat;
+
+import org.junit.Before;
+import org.junit.Test;
+
+public class ConsumerPomXMLFilterTest extends AbstractXMLFilterTests
+{
+private ConsumerPomXMLFilter filter;
+
+@Before
+public void setup() throws Exception {
+filter = new ConsumerPomXMLFilter();
+}
+
+@Test
+public void testAllFilters() throws Exception {
+String input = "\n"
+ + "  \n"
+ + "GROUPID\n"
+ + "PARENT\n"
+ + "VERSION\n"
+ + "../pom.xml\n"
+ + "  \n"
+ + "  PROJECT\n"
+ + "  \n"
+ + "ab\n"
+ + "../cd\n"
+ + "  \n"
+ + "";
+String expected = "\n"
++ "  \n"
++ "GROUPID\n"
++ "PARENT\n"
++ "VERSION\n"
++ "\n"
 
 Review comment:
   Okay, let's drop relativePath, so the XML looks as expected. We can always 
decide to optimize the ModelBuilders for this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-dependency-plugin] khmarbaise commented on issue #22: [MDEP-626] Upgrade maven-reporting-impl

2019-10-14 Thread GitBox
khmarbaise commented on issue #22: [MDEP-626] Upgrade maven-reporting-impl
URL: 
https://github.com/apache/maven-dependency-plugin/pull/22#issuecomment-541891969
 
 
   Unfortunately there is an integration test which has failedI think there 
is something to do ;-)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-dependency-plugin] khmarbaise commented on issue #22: [MDEP-626] Upgrade maven-reporting-impl

2019-10-14 Thread GitBox
khmarbaise commented on issue #22: [MDEP-626] Upgrade maven-reporting-impl
URL: 
https://github.com/apache/maven-dependency-plugin/pull/22#issuecomment-541878734
 
 
   I don't expect any issue but lets see what CI says 
https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven-dependency-plugin/job/mthmulders-MDEP-626-mthmulders/


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] alex1989hu edited a comment on issue #148: [MNG-5600] Dependency management import should support exclusions.

2019-10-13 Thread GitBox
alex1989hu edited a comment on issue #148: [MNG-5600] Dependency management 
import should support exclusions.
URL: https://github.com/apache/maven/pull/148#issuecomment-541403352
 
 
   @olamy  @rfscholte -  Could we get this patch being merged? If any help is 
needed don't hesitate to ping me.
   
   Here is @ChristianSchulte's updated patch without conflict:
   ```patch
   diff --git 
a/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
 
b/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
   index 
f981944f940fcbc912959752d3cff4bc1586519f..2a65bbe9ac14a01dac0c49d900c3fbeef052f6a3
 100644
   --- 
a/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
   +++ 
b/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
   @@ -27,6 +27,7 @@
import org.apache.maven.model.Build;
import org.apache.maven.model.Dependency;
import org.apache.maven.model.DependencyManagement;
   +import org.apache.maven.model.Exclusion;
import org.apache.maven.model.InputLocation;
import org.apache.maven.model.InputSource;
import org.apache.maven.model.Model;
   @@ -1316,7 +1317,40 @@ private void importDependencyManagement( Model model, 
ModelBuildingRequest reque
importMgmt = new DependencyManagement();
}

   -putCache( request.getModelCache(), groupId, artifactId, 
version, ModelCacheTag.IMPORT, importMgmt );
   +// [MNG-5600] Dependency management import should support 
exclusions.
   +if ( !dependency.getExclusions().isEmpty() )
   +{
   +for ( final Exclusion exclusion : 
dependency.getExclusions() )
   +{
   +if ( exclusion.getGroupId() != null && 
exclusion.getArtifactId() != null )
   +{
   +for ( final Iterator dependencies = 
importMgmt.getDependencies().iterator();
   +dependencies.hasNext(); )
   +{
   +final Dependency candidate = 
dependencies.next();
   +
   +if ( ( exclusion.getGroupId().equals( "*" )
   +|| exclusion.getGroupId().equals( 
candidate.getGroupId() ) )
   +&& ( exclusion.getArtifactId().equals( 
"*" )
   +|| exclusion.getArtifactId().equals( 
candidate.getArtifactId() ) ) )
   +{
   +// Dependency excluded from import.
   +dependencies.remove();
   +}
   +}
   +}
   +}
   +
   +for ( final Dependency includedDependency : 
importMgmt.getDependencies() )
   +{
   +includedDependency.getExclusions().addAll( 
dependency.getExclusions() );
   +}
   +}
   +else
   +{
   +// Only dependency managements without exclusion 
processing applied can be cached.
   +putCache( request.getModelCache(), groupId, artifactId, 
version, ModelCacheTag.IMPORT, importMgmt );
   +}
}

if ( importMgmts == null )
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] alex1989hu opened a new pull request #295: [MNG-5600] Dependency management import should support exclusions

2019-10-13 Thread GitBox
alex1989hu opened a new pull request #295: [MNG-5600] Dependency management 
import should support exclusions
URL: https://github.com/apache/maven/pull/295
 
 
   The original patch is made by: Christian Schulte 
   @ChristianSchulte
   
   For more information kindly ask you to visit the original pull request  #148


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] tolikz closed pull request #292: [MNG-6762] - Multimodule project with .mvn/settings.xml not working properly

2019-10-13 Thread GitBox
tolikz closed pull request #292: [MNG-6762] - Multimodule project with 
.mvn/settings.xml not working properly
URL: https://github.com/apache/maven/pull/292
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] olamy commented on issue #148: [MNG-5600] Dependency management import should support exclusions.

2019-10-13 Thread GitBox
olamy commented on issue #148: [MNG-5600] Dependency management import should 
support exclusions.
URL: https://github.com/apache/maven/pull/148#issuecomment-541407835
 
 
   @alex1989hu  please provide another pr


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] alex1989hu commented on issue #148: [MNG-5600] Dependency management import should support exclusions.

2019-10-13 Thread GitBox
alex1989hu commented on issue #148: [MNG-5600] Dependency management import 
should support exclusions.
URL: https://github.com/apache/maven/pull/148#issuecomment-541403352
 
 
   @olamy  @rfscholte -  Could we get this patch being merged? If any help is 
needed don't hesitate to ping me.
   
   Here is @ChristianSchulte's updated patch without conflict:
   ```patch
   diff --git 
a/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
 
b/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
   index 
f981944f940fcbc912959752d3cff4bc1586519f..616859c60c71aa22f1af9e386c86f7167f19d794
 100644
   --- 
a/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
   +++ 
b/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
   @@ -27,6 +27,7 @@
import org.apache.maven.model.Build;
import org.apache.maven.model.Dependency;
import org.apache.maven.model.DependencyManagement;
   +import org.apache.maven.model.Exclusion;
import org.apache.maven.model.InputLocation;
import org.apache.maven.model.InputSource;
import org.apache.maven.model.Model;
   @@ -1316,6 +1317,41 @@ private void importDependencyManagement( Model model, 
ModelBuildingRequest reque
importMgmt = new DependencyManagement();
}

   +// [MNG-5600] Dependency management import should support 
exclusions.
   +if ( !dependency.getExclusions().isEmpty() )
   +{
   +for ( final Exclusion exclusion : 
dependency.getExclusions() )
   +{
   +if ( exclusion.getGroupId() != null && 
exclusion.getArtifactId() != null )
   +{
   +for ( final Iterator dependencies = 
importMgmt.getDependencies().iterator();
   +dependencies.hasNext(); )
   +{
   +final Dependency candidate = 
dependencies.next();
   +
   +if ( ( exclusion.getGroupId().equals( "*" )
   +|| exclusion.getGroupId().equals( 
candidate.getGroupId() ) )
   +&& ( exclusion.getArtifactId().equals( 
"*" )
   +|| exclusion.getArtifactId().equals( 
candidate.getArtifactId() ) ) )
   +{
   +// Dependency excluded from import.
   +dependencies.remove();
   +}
   +}
   +}
   +}
   +
   +for ( final Dependency includedDependency : 
importMgmt.getDependencies() )
   +{
   +includedDependency.getExclusions().addAll( 
dependency.getExclusions() );
   +}
   +}
   +else
   +{
   +// Only dependency managements without exclusion 
processing applied can be cached.
   +putCache( request.getModelCache(), groupId, artifactId, 
version, ModelCacheTag.IMPORT, importMgmt );
   +}
   +
putCache( request.getModelCache(), groupId, artifactId, 
version, ModelCacheTag.IMPORT, importMgmt );
}
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-12 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base 
for build/consumer process
URL: https://github.com/apache/maven/pull/286#discussion_r334255176
 
 

 ##
 File path: 
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java
 ##
 @@ -238,9 +268,82 @@ else if ( request.isUpdateSnapshots() )
 mavenRepositorySystem.injectProxy( session, 
request.getPluginArtifactRepositories() );
 mavenRepositorySystem.injectAuthentication( session, 
request.getPluginArtifactRepositories() );
 
+if ( Boolean.getBoolean( "maven.experimental.buildconsumer" ) )
+{
+session.setFileTransformerManager( newFileTransformerManager() );
+}
 return session;
 }
 
+private FileTransformerManager newFileTransformerManager()
+{
+return new FileTransformerManager()
+{
+@Override
+public Collection getTransformersForArtifact( 
final Artifact artifact )
+{
+Collection transformers = new ArrayList<>();
+if ( "pom".equals( artifact.getExtension() ) )
+{
+final TransformerFactory transformerFactory = 
Factories.newTransformerFactory();
+
+transformers.add( new FileTransformer()
+{
+@Override
+public InputStream transformData( File file )
+throws IOException, TransformException
+{
+final PipedOutputStream pipedOutputStream  = new 
PipedOutputStream();
+final PipedInputStream pipedInputStream  = new 
PipedInputStream( pipedOutputStream );
+
+final SAXSource transformSource;
+try
+{
+transformSource =
+new SAXSource( 
consumerPomXMLFilterFactory.get().get( file.toPath() ),
+   new InputSource( new 
FileReader( file ) ) );
+}
+catch ( SAXException | 
ParserConfigurationException | TransformerConfigurationException e )
+{   
+throw new TransformException( "Failed to 
create a consumerPomXMLFilter", e );
+}
+
+final StreamResult result = new StreamResult( 
pipedOutputStream );
+
+final Callable callable = () ->
+{
+try ( PipedOutputStream out = 
pipedOutputStream )
+{
+
transformerFactory.newTransformer().transform( transformSource, result );
+}
+return null;
+};
+
+ExecutorService executorService = 
Executors.newSingleThreadExecutor();
 
 Review comment:
   Yes, please read 
https://docs.oracle.com/en/java/javase/13/docs/api/java.base/java/io/PipedInputStream.html.
   I don't want to buffer the streams, that can consume too much memory. And it 
is quite easy to get the deadlock: fork, switch to this branch, change default 
value in Features to `true`  and run `mvn test`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] rmannibucau commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-12 Thread GitBox
rmannibucau commented on a change in pull request #286: [MNG-6656] Introduce 
base for build/consumer process
URL: https://github.com/apache/maven/pull/286#discussion_r334254430
 
 

 ##
 File path: 
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java
 ##
 @@ -238,9 +268,82 @@ else if ( request.isUpdateSnapshots() )
 mavenRepositorySystem.injectProxy( session, 
request.getPluginArtifactRepositories() );
 mavenRepositorySystem.injectAuthentication( session, 
request.getPluginArtifactRepositories() );
 
+if ( Boolean.getBoolean( "maven.experimental.buildconsumer" ) )
+{
+session.setFileTransformerManager( newFileTransformerManager() );
+}
 return session;
 }
 
+private FileTransformerManager newFileTransformerManager()
+{
+return new FileTransformerManager()
+{
+@Override
+public Collection getTransformersForArtifact( 
final Artifact artifact )
+{
+Collection transformers = new ArrayList<>();
+if ( "pom".equals( artifact.getExtension() ) )
+{
+final TransformerFactory transformerFactory = 
Factories.newTransformerFactory();
+
+transformers.add( new FileTransformer()
+{
+@Override
+public InputStream transformData( File file )
+throws IOException, TransformException
+{
+final PipedOutputStream pipedOutputStream  = new 
PipedOutputStream();
+final PipedInputStream pipedInputStream  = new 
PipedInputStream( pipedOutputStream );
+
+final SAXSource transformSource;
+try
+{
+transformSource =
+new SAXSource( 
consumerPomXMLFilterFactory.get().get( file.toPath() ),
+   new InputSource( new 
FileReader( file ) ) );
+}
+catch ( SAXException | 
ParserConfigurationException | TransformerConfigurationException e )
+{   
+throw new TransformException( "Failed to 
create a consumerPomXMLFilter", e );
+}
+
+final StreamResult result = new StreamResult( 
pipedOutputStream );
+
+final Callable callable = () ->
+{
+try ( PipedOutputStream out = 
pipedOutputStream )
+{
+
transformerFactory.newTransformer().transform( transformSource, result );
+}
+return null;
+};
+
+ExecutorService executorService = 
Executors.newSingleThreadExecutor();
 
 Review comment:
   Do you need a thread at all? Seems you sublit the task to wait for it, why 
not just chaining transformers streams? Swizzle does that with success.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-shade-plugin] rfscholte merged pull request #29: upgrade to asm 7.2

2019-10-12 Thread GitBox
rfscholte merged pull request #29: upgrade to asm 7.2
URL: https://github.com/apache/maven-shade-plugin/pull/29
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-shade-plugin] Tibor17 commented on issue #29: upgrade to asm 7.2

2019-10-12 Thread GitBox
Tibor17 commented on issue #29: upgrade to asm 7.2
URL: https://github.com/apache/maven-shade-plugin/pull/29#issuecomment-541350476
 
 
   It's simple. I mentioned plexus-java because surefire is dependent on it and 
thus transitive dep ASM. So we have a common problem, updates due to new J13 
and J14.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] srdo edited a comment on issue #294: WIP MNG-6759: Fix issue where MavenMetadataSource failed to set the right…

2019-10-12 Thread GitBox
srdo edited a comment on issue #294: WIP MNG-6759: Fix issue where 
MavenMetadataSource failed to set the right…
URL: https://github.com/apache/maven/pull/294#issuecomment-541343600
 
 
   There's another issue related to this one, which is also introduced in the 
linked commit. I don't know if it's a big deal. Would appreciate if someone 
more familiar with Maven would consider it.
   
   When the optimized path is hit, the `relocatedArtifact` variable at 
https://github.com/apache/maven/pull/294/files#diff-e24970dce03124cc7d88af538539cf07R181
 does not get set. I'm uncertain what kind of impact this may have.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] srdo commented on issue #294: WIP MNG-6759: Fix issue where MavenMetadataSource failed to set the right…

2019-10-12 Thread GitBox
srdo commented on issue #294: WIP MNG-6759: Fix issue where MavenMetadataSource 
failed to set the right…
URL: https://github.com/apache/maven/pull/294#issuecomment-541343600
 
 
   There's another issue related to this one, which is also introduced in the 
linked commit. I don't know if it's a big deal.
   
   When the optimized path is hit, the `relocatedArtifact` variable at 
https://github.com/apache/maven/pull/294/files#diff-e24970dce03124cc7d88af538539cf07R181
 does not get set. I'm uncertain what kind of impact this may have.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-integration-testing] srdo opened a new pull request #50: [MNG-6759] - Add test demonstrating the issue where the wrong reposit…

2019-10-12 Thread GitBox
srdo opened a new pull request #50: [MNG-6759] - Add test demonstrating the 
issue where the wrong reposit…
URL: https://github.com/apache/maven-integration-testing/pull/50
 
 
   …ories are used for resolving transitive dependencies
   
   Test for https://github.com/apache/maven/pull/294.
   
   Advice on improving these would be appreciated. It's not good to be 
depending on an external plugin or an external repository. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] srdo opened a new pull request #294: WIP MNG-6759: Fix issue where MavenMetadataSource failed to set the right…

2019-10-12 Thread GitBox
srdo opened a new pull request #294: WIP MNG-6759: Fix issue where 
MavenMetadataSource failed to set the right…
URL: https://github.com/apache/maven/pull/294
 
 
   … repositories when preparing artifact metadata
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [x ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
   Please see the issue description at 
https://issues.apache.org/jira/browse/MNG-6759. The basic issue is that when 
there's a dependency graph like A -> B -> C, and C is in some non-Central 
repository listed by B's POM, Maven is supposed to look for it in the 
repositories listed by B. As of 3.6.2, this doesn't always happen.
   
   The issue is caused by an oversight in 
https://github.com/apache/maven/commit/d3ace78602405079d6416a63c13216568ba97995.
 When the optimization is triggered, the "pomRepositories" variable is not set. 
In the slow path, it will be set to the remoteRepositories of the parent 
artifact in the dependency trail. 
   
   I'd like advice on improving this fix, as I'm using a deprecated method 
which is probably not a good idea. The optimized path gets the Model of the 
artifact. I need a list of ArtifactRepository, but the Model only contains a 
list of Repository. Should I use a RepositorySystem to map them? It feels like 
a waste, as they already exist in the session's set of MavenProject. I'd get 
them from the ReactorReader, but it unfortunately only exposes the Model.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-12 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base 
for build/consumer process
URL: https://github.com/apache/maven/pull/286#discussion_r334242784
 
 

 ##
 File path: 
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java
 ##
 @@ -238,9 +268,82 @@ else if ( request.isUpdateSnapshots() )
 mavenRepositorySystem.injectProxy( session, 
request.getPluginArtifactRepositories() );
 mavenRepositorySystem.injectAuthentication( session, 
request.getPluginArtifactRepositories() );
 
+if ( Boolean.getBoolean( "maven.experimental.buildconsumer" ) )
+{
+session.setFileTransformerManager( newFileTransformerManager() );
+}
 return session;
 }
 
+private FileTransformerManager newFileTransformerManager()
+{
+return new FileTransformerManager()
+{
+@Override
+public Collection getTransformersForArtifact( 
final Artifact artifact )
+{
+Collection transformers = new ArrayList<>();
+if ( "pom".equals( artifact.getExtension() ) )
+{
+final TransformerFactory transformerFactory = 
Factories.newTransformerFactory();
+
+transformers.add( new FileTransformer()
+{
+@Override
+public InputStream transformData( File file )
+throws IOException, TransformException
+{
+final PipedOutputStream pipedOutputStream  = new 
PipedOutputStream();
+final PipedInputStream pipedInputStream  = new 
PipedInputStream( pipedOutputStream );
+
+final SAXSource transformSource;
+try
+{
+transformSource =
+new SAXSource( 
consumerPomXMLFilterFactory.get().get( file.toPath() ),
+   new InputSource( new 
FileReader( file ) ) );
+}
+catch ( SAXException | 
ParserConfigurationException | TransformerConfigurationException e )
+{   
+throw new TransformException( "Failed to 
create a consumerPomXMLFilter", e );
+}
+
+final StreamResult result = new StreamResult( 
pipedOutputStream );
+
+final Callable callable = () ->
+{
+try ( PipedOutputStream out = 
pipedOutputStream )
+{
+
transformerFactory.newTransformer().transform( transformSource, result );
+}
+return null;
+};
+
+ExecutorService executorService = 
Executors.newSingleThreadExecutor();
 
 Review comment:
   @rmannibucau it seems like this implementation can cause deadlocks (as 
mentioned in the PipedInputStream/PipedOutputStream Javadocs). I see this 
happening when trying to active this feature by default, some unittests start 
to hang. Anyone knows how to solve this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-ear-plugin] khmarbaise commented on issue #5: [MEAR-277] - Upgrade maven-invoker-plugin to 3.2.1

2019-10-12 Thread GitBox
khmarbaise commented on issue #5: [MEAR-277] - Upgrade maven-invoker-plugin to 
3.2.1
URL: https://github.com/apache/maven-ear-plugin/pull/5#issuecomment-541327237
 
 
   PR is now on master. Thanks for your contribution.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-ear-plugin] khmarbaise closed pull request #5: [MEAR-277] - Upgrade maven-invoker-plugin to 3.2.1

2019-10-12 Thread GitBox
khmarbaise closed pull request #5: [MEAR-277] - Upgrade maven-invoker-plugin to 
3.2.1
URL: https://github.com/apache/maven-ear-plugin/pull/5
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-ear-plugin] HeinrichHueppe opened a new pull request #5: [MEAR-277] - Upgrade maven-invoker-plugin to 3.2.1

2019-10-12 Thread GitBox
HeinrichHueppe opened a new pull request #5: [MEAR-277] - Upgrade 
maven-invoker-plugin to 3.2.1
URL: https://github.com/apache/maven-ear-plugin/pull/5
 
 
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MEAR) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[MEAR-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MEAR-XXX` with the appropriate JIRA issue. Best 
practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-ear-plugin] HeinrichHueppe commented on issue #4: [MEAR-277] - Upgrade maven-invoker-plugin to 3.2.0

2019-10-12 Thread GitBox
HeinrichHueppe commented on issue #4: [MEAR-277] - Upgrade maven-invoker-plugin 
to 3.2.0
URL: https://github.com/apache/maven-ear-plugin/pull/4#issuecomment-541323356
 
 
   Wrong version number


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-ear-plugin] HeinrichHueppe closed pull request #4: [MEAR-277] - Upgrade maven-invoker-plugin to 3.2.0

2019-10-12 Thread GitBox
HeinrichHueppe closed pull request #4: [MEAR-277] - Upgrade 
maven-invoker-plugin to 3.2.0
URL: https://github.com/apache/maven-ear-plugin/pull/4
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-ear-plugin] HeinrichHueppe opened a new pull request #4: [MEAR-277] - Upgrade maven-invoker-plugin to 3.2.0

2019-10-12 Thread GitBox
HeinrichHueppe opened a new pull request #4: [MEAR-277] - Upgrade 
maven-invoker-plugin to 3.2.0
URL: https://github.com/apache/maven-ear-plugin/pull/4
 
 
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MEAR) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MEAR-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MEAR-XXX` with the appropriate JIRA issue. Best 
practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-shade-plugin] rfscholte commented on issue #29: upgrade to asm 7.2

2019-10-12 Thread GitBox
rfscholte commented on issue #29: upgrade to asm 7.2
URL: https://github.com/apache/maven-shade-plugin/pull/29#issuecomment-541317539
 
 
   > Do you agree with updating plexus-java and cutting a new version 1.0.4?
   
   ASM is a direct dependency of maven-shade plugin, so this PR is correct. No 
need to worry about plexus-java, the ASM code won't be used.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] khmarbaise closed pull request #293: [MNG-6777] - Remove duplicate resolveFile methods

2019-10-12 Thread GitBox
khmarbaise closed pull request #293: [MNG-6777] - Remove duplicate resolveFile 
methods
URL: https://github.com/apache/maven/pull/293
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] khmarbaise commented on issue #293: [MNG-6777] - Remove duplicate resolveFile methods

2019-10-12 Thread GitBox
khmarbaise commented on issue #293: [MNG-6777] - Remove duplicate resolveFile 
methods
URL: https://github.com/apache/maven/pull/293#issuecomment-541303598
 
 
   This PR has been merged into master. Thanks for your contribution.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-shade-plugin] Tibor17 commented on issue #29: upgrade to asm 7.2

2019-10-12 Thread GitBox
Tibor17 commented on issue #29: upgrade to asm 7.2
URL: https://github.com/apache/maven-shade-plugin/pull/29#issuecomment-541299295
 
 
   @sullis pls create Jira ticket and rewrite the commit message, thx.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-shade-plugin] Tibor17 commented on issue #29: upgrade to asm 7.2

2019-10-12 Thread GitBox
Tibor17 commented on issue #29: upgrade to asm 7.2
URL: https://github.com/apache/maven-shade-plugin/pull/29#issuecomment-541295128
 
 
   @eolivelli Let's merge this fix and release this plugin. The Plexus Java is 
used in Surefire but it is Codehaus, not Maven gid.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


  1   2   3   4   5   6   7   8   9   10   >