[jira] [Created] (MSHARED-1315) PR template references non-existing maven profile for verification
Michael Keppler created MSHARED-1315: Summary: PR template references non-existing maven profile for verification Key: MSHARED-1315 URL: https://issues.apache.org/jira/browse/MSHARED-1315 Project: Maven Shared Components Issue Type: Bug Reporter: Michael Keppler [https://github.com/apache/maven-filtering/blob/master/.github/pull_request_template.md] asks contributors to verify with a specific profile. The profile doesn't exist in that project. Might be a copy-paste error, if that was taken from another component. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-7902) sort plugins in validation report
Michael Keppler created MNG-7902: Summary: sort plugins in validation report Key: MNG-7902 URL: https://issues.apache.org/jira/browse/MNG-7902 Project: Maven Issue Type: Improvement Components: Core Reporter: Michael Keppler Attachments: image-2023-10-07-13-33-27-762.png Please don't ever output the content of a Set for consumption by humans without sorting it first. The order is otherwise "random". Sorting (case insensitive) makes the same output easier to read, especially when trying to find one specific entry (e.g. "Did we fix plugin foo already?") !image-2023-10-07-13-33-27-762.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-7846) endless loop in DefaultExceptionHandler.getMessage()
Michael Keppler created MNG-7846:
Summary: endless loop in DefaultExceptionHandler.getMessage()
Key: MNG-7846
URL: https://issues.apache.org/jira/browse/MNG-7846
Project: Maven
Issue Type: Bug
Components: Core
Affects Versions: 3.9.3
Reporter: Michael Keppler
Attachments: image-2023-07-19-13-59-02-398.png
The default exception handler iterates all nested exceptions in a loop that's
only left when exception.cause == null
See
[https://github.com/apache/maven/blob/4a5b6c5f2b662fbf356f86ffe44d99d3d52f9fa9/maven-core/src/main/java/org/apache/maven/exception/DefaultExceptionHandler.java#L228C56-L228C64]
Unfortunately there can be exceptions where the cause is a reference to the
containing exception, e.g. exception.cause == exception. That code then becomes
an endless loop. I just experienced such an endless loop and was able to find a
JRubyException pointing to itself in the heap dump of the thread:
!image-2023-07-19-13-59-02-398.png!
The loop cancelation condition should therefore be changed to
{code:java}
t != null && t != t.getCause(){code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MENFORCER-465) Superfluous blanks in BanDuplicatePomDependencyVersions
Michael Keppler created MENFORCER-465:
-
Summary: Superfluous blanks in BanDuplicatePomDependencyVersions
Key: MENFORCER-465
URL: https://issues.apache.org/jira/browse/MENFORCER-465
Project: Maven Enforcer Plugin
Issue Type: Bug
Reporter: Michael Keppler
The blanks in "( 2 times )" should be removed. English language and typography
don't use blanks there. It also doesn't fit all the remaining Maven output
(like the execution id next to each goal in the console log).
{code:java}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-enforcer-plugin:3.2.1:enforce
(enforce-plugin-versions) on project com.etas.ascet.application.edit.test:
[ERROR] Rule 1:
org.apache.maven.enforcer.rules.BanDuplicatePomDependencyVersions failed with
message:
[ERROR] Found 1 duplicate dependency declaration in this project:
[ERROR] -
dependencies.dependency[p2.eclipse.plugin:org.objectweb.asm:eclipse-plugin] ( 2
times ) {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MWRAPPER-92) Use https in license links of generated files
Michael Keppler created MWRAPPER-92: --- Summary: Use https in license links of generated files Key: MWRAPPER-92 URL: https://issues.apache.org/jira/browse/MWRAPPER-92 Project: Maven Wrapper Issue Type: Bug Components: Maven Wrapper Plugin Affects Versions: 3.1.1 Reporter: Michael Keppler The generated scripts mvnw and mvnw.cmd contain links to the Apache license texts. Please make them use https instead of http. https is already used for the same links in other generated files, like maven-wrapper.properties (and should generally be the default nowadays). Found because we monitor our own repositories with https://github.com/spring-io/nohttp -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SUREFIRE-2094) Leaked file descriptors
Michael Keppler created SUREFIRE-2094:
-
Summary: Leaked file descriptors
Key: SUREFIRE-2094
URL: https://issues.apache.org/jira/browse/SUREFIRE-2094
Project: Maven Surefire
Issue Type: Bug
Reporter: Michael Keppler
Issue https://issues.apache.org/jira/browse/SUREFIRE-1845 with change
[https://github.com/apache/maven-surefire/commit/32bd56b4ea908147592ef92c71c4e7936e070993#diff-c634b539151b4b76bde50d93d5a6cd2b0f51aa411281398cc295cc721bdfa1d5]
removed
{code:java}
utf8RecodingDeferredFileOutputStream.close();{code}
from StatelessXmlReporter.java. That change seems reasonable, since that exact
stream is still used 2 lines deeper. However, this seems to cause leaked file
descriptors, one per test, see
[https://github.com/eclipse/tycho/issues/965|https://github.com/eclipse/tycho/issues/965.]
Might it be useful to NOT remove the close() call, but just to move it down
some lines instead?
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Created] (MNG-7352) org.apache.maven.toolchain.java.JavaToolchainImpl should be public
Michael Keppler created MNG-7352: Summary: org.apache.maven.toolchain.java.JavaToolchainImpl should be public Key: MNG-7352 URL: https://issues.apache.org/jira/browse/MNG-7352 Project: Maven Issue Type: Bug Components: Core Affects Versions: 3.8.4 Reporter: Michael Keppler org.apache.maven.toolchain.java.JavaToolchainImpl has been created as replacement for the now deprecated org.apache.maven.toolchain.java.DefaultJavaToolChain. However, the deprecated class was public, the new one isn't. That makes it impossible to follow the deprecation note to use the new class (outside of Maven core). I'm trying to fix this deprecation in Maven Tycho. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (MNG-6907) endless loop in StringSearchModelInterpolator
Michael Keppler created MNG-6907: Summary: endless loop in StringSearchModelInterpolator Key: MNG-6907 URL: https://issues.apache.org/jira/browse/MNG-6907 Project: Maven Issue Type: Bug Components: Inheritance and Interpolation Affects Versions: 3.6.3 Reporter: Michael Keppler I have some company confidential projects (therefore no reproduction pom), which cause an endless loop when running mvn versions:display-plugin-updates The endless loop happens in [StringSearchModelInterpolator.traverseObjectWithParents|https://github.com/apache/maven/blob/5397fb66e7ea45dd756cd48c18f7dc476e2a06a6/maven-model-builder/src/main/java/org/apache/maven/model/interpolation/StringSearchModelInterpolator.java#L176] calling itself (which I can see by attaching a profiler to the process). Please add a check for whether the superClass is identical to the class, before entering the recursion. -- This message was sent by Atlassian Jira (v8.3.4#803005)
