[jira] [Commented] (MSHADE-275) Maven Shade Plugin does not work under Java 10

2018-06-12 Thread Philip Aston (JIRA)


[ 
https://issues.apache.org/jira/browse/MSHADE-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509948#comment-16509948
 ] 

Philip Aston commented on MSHADE-275:
-

Thanks for the response. Done: MSHADE-289.

> Maven Shade Plugin does not work under Java 10
> --
>
> Key: MSHADE-275
> URL: https://issues.apache.org/jira/browse/MSHADE-275
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.1.0
> Environment: Windows 10, 64 Bit; Java 10, 64 Bit
> Maven 3.3.9, Shade Plugin 3.1.0
>Reporter: Markus Grech
>Assignee: Karl Heinz Marbaise
>Priority: Major
> Fix For: 3.1.1
>
>
> Creating an uber-jar works fine for my project under Java 9, fails under Java 
> 10 with the following Exception:
>  
> {code:java}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-shade-plugin:3.1.0:shade (default) on project 
> compiler: Error creating shaded jar: null: IllegalArgumentException -> [Help 
> 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-shade-plugin:3.1.0:shade (default) on 
> project compiler: Error creating shaded jar: null
>     at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
>     at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>     at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>     at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
>     at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
>     at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
>     at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
>     at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
>     at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
>     at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
>     at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native 
> Method)
>     at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>     at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>     at java.base/java.lang.reflect.Method.invoke(Method.java:564)
>     at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
>     at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
>     at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
>     at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
>     at org.codehaus.classworlds.Launcher.main(Launcher.java:47)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error creating 
> shaded jar: null
>     at 
> org.apache.maven.plugins.shade.mojo.ShadeMojo.execute(ShadeMojo.java:546)
>     at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
>     at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
>     ... 21 more
> Caused by: java.lang.IllegalArgumentException
>     at org.objectweb.asm.ClassReader.(Unknown Source)
>     at org.objectweb.asm.ClassReader.(Unknown Source)
>     at org.objectweb.asm.ClassReader.(Unknown Source)
>     at org.vafer.jdependency.Clazzpath.addClazzpathUnit(Clazzpath.java:201)
>     at org.vafer.jdependency.Clazzpath.addClazzpathUnit(Clazzpath.java:132)
>     at 
> org.apache.maven.plugins.shade.filter.MinijarFilter.(MinijarFilter.java:97)
>     at 
> org.apache.maven.plugins.shade.mojo.ShadeMojo.getFilters(ShadeMojo.java:834)
>     at 
> org.apache.maven.plugins.shade.mojo.ShadeMojo.execute(ShadeMojo.java:434)
>     ... 23 more{code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MSHADE-289) Maven Shade Plugin does not work under Java 10

2018-06-12 Thread Philip Aston (JIRA)
Philip Aston created MSHADE-289:
---

 Summary: Maven Shade Plugin does not work under Java 10
 Key: MSHADE-289
 URL: https://issues.apache.org/jira/browse/MSHADE-289
 Project: Maven Shade Plugin
  Issue Type: Bug
Affects Versions: 3.1.1
Reporter: Philip Aston


I'm seeing the same symptoms as MSHADE-275 but with 3.1.1.

My build works with Java 9, but Java 10 gives:

 
{code:java}
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-shade-plugin:3.1.1:shade (default) on project 
client-bootstrap: Error creating shaded jar: null: IllegalArgumentException -> 
[Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal 
org.apache.maven.plugins:maven-shade-plugin:3.1.1:shade (default) on project 
client-bootstrap: Error creating shaded jar: null
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:213)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:154)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:146)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:81)
at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
 (SingleThreadedBuilder.java:51)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:309)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:194)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:107)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:564)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
(Launcher.java:229)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
(Launcher.java:415)
at org.codehaus.plexus.classworlds.launcher.Launcher.main 
(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoExecutionException: Error creating 
shaded jar: null
at org.apache.maven.plugins.shade.mojo.ShadeMojo.execute 
(ShadeMojo.java:546)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:134)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:208)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:154)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:146)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:81)
at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
 (SingleThreadedBuilder.java:51)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:309)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:194)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:107)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:564)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
(Launcher.java:229)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
(Launcher.java:415)
at org.codehaus.plexus.classworlds.launcher.Launcher.main 
(Launcher.java:356)
Caused by: java.lang.IllegalArgumentException
at org.objectweb.asm.ClassReader. (ClassReader.java:160)
at org.objectweb.asm.ClassReader. (ClassReader.java:143)
at 

[jira] [Commented] (MSHADE-275) Maven Shade Plugin does not work under Java 10

2018-06-12 Thread Philip Aston (JIRA)


[ 
https://issues.apache.org/jira/browse/MSHADE-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509656#comment-16509656
 ] 

Philip Aston commented on MSHADE-275:
-

I'm seeing the same symptoms with 3.1.1. As above, it works with Java 9, but 
Java 10 gives:

 
{code:java}
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-shade-plugin:3.1.1:shade (default) on project 
client-bootstrap: Error creating shaded jar: null: IllegalArgumentException -> 
[Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal 
org.apache.maven.plugins:maven-shade-plugin:3.1.1:shade (default) on project 
client-bootstrap: Error creating shaded jar: null
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:213)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:154)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:146)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:81)
at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
 (SingleThreadedBuilder.java:51)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:309)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:194)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:107)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:564)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
(Launcher.java:229)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
(Launcher.java:415)
at org.codehaus.plexus.classworlds.launcher.Launcher.main 
(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoExecutionException: Error creating 
shaded jar: null
at org.apache.maven.plugins.shade.mojo.ShadeMojo.execute 
(ShadeMojo.java:546)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:134)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:208)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:154)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:146)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:81)
at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
 (SingleThreadedBuilder.java:51)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:309)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:194)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:107)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:564)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
(Launcher.java:229)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
(Launcher.java:415)
at org.codehaus.plexus.classworlds.launcher.Launcher.main 
(Launcher.java:356)
Caused by: java.lang.IllegalArgumentException
at org.objectweb.asm.ClassReader. (ClassReader.java:160)
at org.objectweb.asm.ClassReader. (ClassReader.java:143)
at org.objectweb.asm.ClassReader. (ClassReader.java:418)
at org.vafer.jdependency.Clazzpath.addClazzpathUnit (Clazzpath.java:201)
at 

[jira] [Created] (MSHADE-272) Option to preserve source timestamps

2018-02-10 Thread Philip Aston (JIRA)
Philip Aston created MSHADE-272:
---

 Summary: Option to preserve source timestamps
 Key: MSHADE-272
 URL: https://issues.apache.org/jira/browse/MSHADE-272
 Project: Maven Shade Plugin
  Issue Type: Wish
Affects Versions: 3.1.0
Reporter: Philip Aston


Please add an option to preserve the source timestamps of files.

Not doing so causes a significant issue when packaging Clojure projects, since 
Clojure uses the timestamps to determine whether to dynamically recompile code. 
See:

- 
[http://mail-archives.apache.org/mod_mbox/maven-users/201310.mbox/%3ccaaub-epb4cdpuymgepu7thsb2bqcujmgmnm1b4h1ucmyr+u...@mail.gmail.com%3E]

- [https://groups.google.com/d/msg/clojure/12BOjg1KsWA/8DIobmb2EwAJ]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] (MJAVADOC-399) resourceArtifact should allow a classifier to be specified.

2014-07-07 Thread Philip Aston (JIRA)
Philip Aston created MJAVADOC-399:
-

 Summary: resourceArtifact should allow a classifier to be 
specified.
 Key: MJAVADOC-399
 URL: https://jira.codehaus.org/browse/MJAVADOC-399
 Project: Maven Javadoc Plugin
  Issue Type: Improvement
Reporter: Philip Aston
Priority: Minor


resourceArtifact should allow a classifier to be specified.

This would be particularly useful when using the assembly plugin to package up 
Javadoc resources.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)


[jira] (MJAVADOC-400) aggregate-jar does nothing if called as part of a reactor build

2014-07-07 Thread Philip Aston (JIRA)
Philip Aston created MJAVADOC-400:
-

 Summary: aggregate-jar does nothing if called as part of a reactor 
build
 Key: MJAVADOC-400
 URL: https://jira.codehaus.org/browse/MJAVADOC-400
 Project: Maven Javadoc Plugin
  Issue Type: Bug
Affects Versions: 2.9.1
 Environment: Reproduced with Oracle Java 1.7.0_45, Maven 3.0.5. Also 
reproduced with Maven 3.2.2.
Reporter: Philip Aston


The attached {{reproduction.tgz}} contains a multi-module project 
_com.repo:parent_, and two child modules, _com.repo:module_a_ and 
_com.repo:module_b_. _com.repo:module-a_ is a jar module that contains a Java 
class. _com.repo:module-b_ depends on _com.repo:module-a_ and has uses 
{{javadoc:aggregate-jar}} to create a javadoc attachment.

If I change into the {{module_b}} directory and run {{mvn clean install}}, a 
{{com.repo:module-b:javadoc}} attachment is not created.

However, if I run {{mvn clean install}} from the top level, a 
{{com.repo:module-b:javadoc}} attachment is *not* created. I believe this to be 
a bug.

Running with -X shows that the aggregate-jar mojo is configured, but never 
executed.

If I change to {{module-b}} and run with -X, I see an 
MultipleArtifactsNotFoundException, but it otherwise behaves as I would expect. 
This looks similar to the symptoms of MVN-4618.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)