[GitHub] [maven-plugin-testing] rfscholte commented on issue #8: MPLUGINTESTING-61 MPLUGINTESTING-62 target JDK 7 and maven 3.6.0
rfscholte commented on issue #8: MPLUGINTESTING-61 MPLUGINTESTING-62 target JDK 7 and maven 3.6.0 URL: https://github.com/apache/maven-plugin-testing/pull/8#issuecomment-521756916 For this PR I don't see the need for changing the Maven version, it should be picked up by the direct as direct dependency of the plugin you're testing. Bumping `java.version` + some other dependencies is good enough. Add that list to jira and adjust the title, because that's what we use for the release notes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-plugin-testing] rfscholte commented on issue #8: MPLUGINTESTING-61 MPLUGINTESTING-62 target JDK 7 and maven 3.6.0
rfscholte commented on issue #8: MPLUGINTESTING-61 MPLUGINTESTING-62 target JDK 7 and maven 3.6.0 URL: https://github.com/apache/maven-plugin-testing/pull/8#issuecomment-520251983 > protected T lookupMojo( String goal, String pluginPom, Class type) This is just moving the cast to an argument. If you really want to change this, you should change it to protected T lookupMojo( Class type, String pluginPom ) and extract the name (=goal) from its Mojo Annotation. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
