[GitHub] [maven-surefire] wilkinsona commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution
wilkinsona commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution URL: https://github.com/apache/maven-surefire/pull/243#issuecomment-521604924 Thanks, @sormuras. I've opened a PR using that branch as its base: https://github.com/apache/maven-surefire/pull/244. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] wilkinsona commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution
wilkinsona commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution URL: https://github.com/apache/maven-surefire/pull/243#issuecomment-521577398 My pleasure. Thanks for the review and merge. I'd like to work on an equivalent 2.22.x fix now. What branch should I use as the base for that? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] wilkinsona commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution
wilkinsona commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution URL: https://github.com/apache/maven-surefire/pull/243#issuecomment-521295465 I've forced pushed the switch to a `HashMap` and the addition of a unit test. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] wilkinsona commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution
wilkinsona commented on issue #243: [SUREFIRE-1679] Prevent classpath caching from causing pollution URL: https://github.com/apache/maven-surefire/pull/243#issuecomment-521186877 Oops. Sorry. I've force-pushed a fix for that. I'll take a look at unit tests shortly. Given that the old `ClasspathCache` is now unused (as far as I can tell), I'm not sure that it'll be possible to maintain the same level of coverage. However, I can at least try to add a test that verifies the pollution has been fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services