[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-388533450 Restarting the build didn't help... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-388529278 What happend on the [`linux-jdk7-maven3.5.x`](https://builds.apache.org/job/maven-box/job/maven-surefire/job/1330/) build? ``` [linux-jdk7-maven3.5.x] Tests run: 58, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.858 sec [linux-jdk7-maven3.5.x] [linux-jdk7-maven3.5.x] Results : [linux-jdk7-maven3.5.x] [linux-jdk7-maven3.5.x] Tests run: 58, Failures: 0, Errors: 0, Skipped: 0 [linux-jdk7-maven3.5.x] [linux-jdk7-maven3.5.x] [INFO] [linux-jdk7-maven3.5.x] [INFO] --- maven-jar-plugin:3.0.0:jar (default-jar) @ surefire-booter --- [linux-jdk7-maven3.5.x] [INFO] Building jar: /home/jenkins/jenkins-slave/workspace/ven-box_maven-surefire_1330-TSMLOBV5ENRMCK6YV52ANAULUWOG4OYEMBRTFOGSINEWTK45IYLQ/surefire-booter/target/surefire-booter-3.0.0-SNAPSHOT.jar [linux-jdk7-maven3.5.x] [INFO] [linux-jdk7-maven3.5.x] [INFO] --- maven-site-plugin:3.4:attach-descriptor (attach-descriptor) @ surefire-booter --- [linux-jdk7-maven3.5.x] [INFO] [linux-jdk7-maven3.5.x] [INFO] --- maven-shade-plugin:3.1.0:shade (default) @ surefire-booter --- [linux-jdk7-maven3.5.x] [INFO] Excluding org.apache.maven.surefire:surefire-api:jar:3.0.0-SNAPSHOT from the shaded jar. [linux-jdk7-maven3.5.x] [INFO] Excluding org.apache.maven.surefire:surefire-logger-api:jar:3.0.0-SNAPSHOT from the shaded jar. [linux-jdk7-maven3.5.x] [INFO] Including org.apache.commons:commons-lang3:jar:3.5 in the shaded jar. [linux-jdk7-maven3.5.x] [INFO] Including commons-io:commons-io:jar:2.5 in the shaded jar. [linux-jdk7-maven3.5.x] [INFO] Minimizing jar org.apache.maven.surefire:surefire-booter:jar:3.0.0-SNAPSHOT [linux-jdk7-maven3.5.x] [INFO] [linux-jdk7-maven3.5.x] [INFO] Reactor Summary: [linux-jdk7-maven3.5.x] [INFO] [linux-jdk7-maven3.5.x] [INFO] Apache Maven Surefire .. SUCCESS [ 13.605 s] [linux-jdk7-maven3.5.x] [INFO] SureFire Logger API SUCCESS [ 3.933 s] [linux-jdk7-maven3.5.x] [INFO] SureFire API ... SUCCESS [ 12.695 s] [linux-jdk7-maven3.5.x] [INFO] ShadeFire JUnit3 Provider .. SUCCESS [ 1.921 s] [linux-jdk7-maven3.5.x] [INFO] SureFire Booter FAILURE [ 10.408 s] [linux-jdk7-maven3.5.x] [INFO] Maven Surefire Test-Grouping Support ... SKIPPED [...] ``` `windows-jdk7-maven3.5.x` build was doing fine. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-388527807 No, didn't do it yet. Just wanted get the changes I made on gitbox-1330 to show up here as "Polishing". Will reset 1330 to this branch (github-184) and squash all commits into a single one there. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-388527807 No, didn't do it yet. Just wanted get the changes I made on bitbox-1330 to show up here as "Polishing". Will reset 1330 to this branch (github-184) and squash all commits into a single one there. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-388186209 Rebased onto https://github.com/apache/maven-surefire/commits/master and merged gitbox-1330 changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-387449015 I may look into the JDK 11 issues later... but as it is still early-access state, we and other tools have some months time to adopt. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386862997 > [...] JUnit5 should guarantee backwards compatibility of platform engine for long time. That's exactly the plan of @junit-team! The platform is the stable part that build tools depend on. What a test is and how to execute it, is defined by an engine implementation. Like "Jupiter" now and _"Saturn"_ (JUnit 6) in a few years... or any other flavor. See the list of well-known engine implementations at https://github.com/junit-team/junit5/wiki/Third-party-Extensions#junit-platform-test-engines ...so, if a build tool supports the JUnit Platform it doesn't have to care about new testing frameworks, as long as they implement `TestEngine`. The `junit-platform-engine-jqwik` IT in 1330 shows how and that it works. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386861135 > I think it will work even without is( greaterThanOrEqualTo( "1.8" ) ). Okay. Removed the `setUp` method. Let's see what Jenkins reports. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider
sormuras commented on issue #184: Donate current sources from
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386859383
> Did you also have a problem with JaCoCO:0.7.9 on JDK10?
According to https://github.com/jacoco/jacoco/releases 0.8.1 introduced JDK
10 support. Thus, 0.7.9 had to fail.
> Do we need to have scope=compile on the dependency
junit-platform-launcher in our provider POM? What will
happen if it would be scope provided?
99% yes, the provider needs it at compile time. That's what JUnit Platform
is all about. It's the API for tools (build tools, IDEs, ...) to get "JUnit 5"
_(technically, there's no JUnit 5)_ running. See this import statements in
`org.apache.maven.surefire.junitplatform.JUnitPlatformProvider`:
```java
import org.junit.platform.launcher.Launcher;
import org.junit.platform.launcher.LauncherDiscoveryRequest;
import org.junit.platform.launcher.TagFilter;
import org.junit.platform.launcher.core.LauncherDiscoveryRequestBuilder;
import org.junit.platform.launcher.core.LauncherFactory;
```
And recall the "JUnit 5" architecture layout:
Just move the **junit-platform-surefire-provider** from the bottom-left out
off the red **PLATFORM** box into the **IDEs/Build Tool** bubble at the bottom.
Here be dragons, Gradle, Surefire, IDEA, Eclipse, etc...
1% no, perhaps there's some Maven-trick to achieve the same with `provided`
scope?
> How did you skip tests on surefire-junit-platform with JDK 1.7?
Mh, if it is because of `${java.home}/bin/java` then @britter did
it.
At test runtime, the assumption declared in `JUnitPlatformIT` ensures that a
JDK 1.8+ is at work:
```java
@Before
public void setUp()
{
assumeThat( "java.specification.version: ",
getProperty( "java.specification.version" ),
is( greaterThanOrEqualTo( "1.8" ) ) );
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386828650 JDK 10 seems okay now. JDK 7 still chokes on "--target 1.8" options... https://builds.apache.org/job/maven-box/job/maven-surefire/job/1330/8/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386828650 JDK 10 seems okay now. JDK 7 still chokes on "--target 1.8" options... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386827017 Why are they banned? [linux-jdk10-maven3.5.x] Found Banned Dependency: org.apache.commons:commons-lang3:jar:3.7 [linux-jdk10-maven3.5.x] Found Banned Dependency: commons-io:commons-io:jar:2.6 Reverting to old versions... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386825239 > ... You have to squash all commits ... Losing history and reasoning is okay? Done. https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=fb1188b6b45e7a2d71e9d9807c67775a9595031d This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386825239 > ... You have to squash all commits ... Losing history and reasoning is okay? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386799705 I think, we may get rid of integration test class `JUnit5IT` as it refers to the soon deprecated `org.junit.platform:junit-platform-surefire-provider`. Or should we keep it for the sake of completeness? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386793374 Make it three commits. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386728323 @Tibor17 Can you please integrate the last two commits as well? The build was successful on my machine and before I write more integration tests, I'd like to know whether I'm on the right track. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386521173 Working-around it for now by ``` [...] org.junit.platform.commons.* ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386519453 Nice. But `animal-sniffer-maven-plugin` still fails either by not finding a bunch of methods, like: ``` surefire-providers\surefire-junit-platform\src\main\java\org\apache\maven\surefire\junitplatform\JUnitPlatformProvider.java:213: Undefined reference: boolean org.junit.platform.commons.util.StringUtils.isNotBlank(String) surefire-providers\surefire-junit-platform\src\main\java\org\apache\maven\surefire\junitplatform\JUnitPlatformProvider.java:228: Undefined reference: void org.junit.platform.commons.util.Preconditions.condition(boolean, String) ``` or if I comment the exclude for `org.junit.platform:junit-platform-commons` out, it seems to choke due to an out-dated ASM version: ``` org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.codehaus.mojo:animal-sniffer-maven-plugin:1.15:check (signature-check) on project surefire-junit-platform: Execution signature-check of goal org.codehaus.mojo:animal-sniffer-maven-plugin:1.15:check failed. [...] Caused by: java.lang.IllegalArgumentException at org.objectweb.asm.ClassReader.(Unknown Source) at org.objectweb.asm.ClassReader.(Unknown Source) at org.objectweb.asm.ClassReader.(Unknown Source) at org.codehaus.mojo.animal_sniffer.ClassListBuilder.process(ClassListBuilder.java:71) ``` How do I fix those build errors? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386519453 Nice. But `animal-sniffer-maven-plugin` still fails either by not finding a bunch of methods, like: ``` surefire-providers\surefire-junit-platform\src\main\java\org\apache\maven\surefire\junitplatform\JUnitPlatformProvider.java:213: Undefined reference: boolean org.junit.platform.commons.util.StringUtils.isNotBlank(String) surefire-providers\surefire-junit-platform\src\main\java\org\apache\maven\surefire\junitplatform\JUnitPlatformProvider.java:228: Undefined reference: void org.junit.platform.commons.util.Preconditions.condition(boolean, String) ``` or if I comment the exclude for `` out, it seems to choke due to an out-dated ASM version: ``` org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.codehaus.mojo:animal-sniffer-maven-plugin:1.15:check (signature-check) on project surefire-junit-platform: Execution signature-check of goal org.codehaus.mojo:animal-sniffer-maven-plugin:1.15:check failed. [...] Caused by: java.lang.IllegalArgumentException at org.objectweb.asm.ClassReader.(Unknown Source) at org.objectweb.asm.ClassReader.(Unknown Source) at org.objectweb.asm.ClassReader.(Unknown Source) at org.codehaus.mojo.animal_sniffer.ClassListBuilder.process(ClassListBuilder.java:71) ``` How do I fix those build errors? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386411693 Sure. Go ahead. I am still waiting for the ASF git permissions. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
