[
http://jira.codehaus.org/browse/MASSEMBLY-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=174911#action_174911
]
Benjamin Bentmann commented on MASSEMBLY-382:
-
While the IT is now passing on Windows, too, I feel there's still something
wrong with the SimpleAggregatingDescriptorHandler whose purpose seems to be to
replace one or more files with a single file holding their concatenated
contents.
It seems essential that {{isSelected()}} gets called before
{{finalizeArchiveCreation()}}. However, in {{AbstractArchiver.createArchive()}}
the control flow (basically) is
- validate()
- runArchiveFinalizers()
- execute()
- close()
- cleanUp()
Due to lack of interest I haven't investigated further but sponteneously it
seems {{runArchiveFinalizers()}} and {{execute()}} are executed in the wrong
order for the {{SimpleAggregatingDescriptorHandler}} to work. Indeed, the
aggregated file
{{custom-containerDescriptorHandler/assembly/target/assembly-1-bin/file.txt}}
is empty [0].
This discrepancy is not checked by the corresponding {{verify.bsh}} because it
has some broken logic:
start with result=true
read the lines of the aggregated file
if contents matches, set result=true
but if the contents does not match, the test still passes because result was
already initialized with true.
[0]
https://grid.sonatype.org/ci/job/plugins-IT-with-maven-2.1.x/jdk=1.5,label=ubuntu/ws/trunk/maven-assembly-plugin/target/it/projects/container-descriptors/custom-containerDescriptorHandler/assembly/target/assembly-1-bin/file.txt/*view*/
Review IT failure on Windows
Key: MASSEMBLY-382
URL: http://jira.codehaus.org/browse/MASSEMBLY-382
Project: Maven 2.x Assembly Plugin
Issue Type: Task
Affects Versions: 2.2-beta-3
Reporter: Benjamin Bentmann
Priority: Minor
Attachments: build.log
I observe the following IT failure on my WinXP box as well as on [Hudson's
Vista
box|https://grid.sonatype.org/ci/job/plugins-IT-with-maven-2.0.x/jdk=1.5,label=windows/53/console]:
{noformat}
[INFO] Building:
container-descriptors\custom-containerDescriptorHandler\pom.xml
[INFO] ...FAILED. The post-build script returned false.
{noformat}
Attached is the {{build.log}} of this IT.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
