[jira] [Commented] (MRESOLVER-96) Dependency Injection fails after upgrading to Maven 3.6.2
[
https://issues.apache.org/jira/browse/MRESOLVER-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339064#comment-17339064
]
Michael Osipov commented on MRESOLVER-96:
-
This needs to be reviewed because a lot has happened on master recently.
> Dependency Injection fails after upgrading to Maven 3.6.2
> -
>
> Key: MRESOLVER-96
> URL: https://issues.apache.org/jira/browse/MRESOLVER-96
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Affects Versions: 1.4.1
>Reporter: Marek Neumann
>Priority: Minor
>
> When using Maven Resolver 1.4.1 in combination with Maven 3.6.2 (also 3.6.3)
> we face the following errors when we bootstrap our application:
> {code:java}
> Exception in thread "main" com.google.inject.CreationException: Unable to
> create injector, see the following errors:1) No implementation for
> org.apache.maven.model.composition.DependencyManagementImporter was bound.
> while locating
> org.apache.maven.model.composition.DependencyManagementImporter
> for field at
> org.apache.maven.model.building.DefaultModelBuilder.dependencyManagementImporter(DefaultModelBuilder.java:207)
> at
> org.apache.maven.repository.internal.MavenResolverModule.configure(MavenResolverModule.java:58)
> (via modules: build.development.boot.Bootstrap$ResolverModule ->
> org.apache.maven.repository.internal.MavenResolverModule)2) No implementation
> for org.apache.maven.model.management.DependencyManagementInjector was bound.
> while locating
> org.apache.maven.model.management.DependencyManagementInjector
> for field at
> org.apache.maven.model.building.DefaultModelBuilder.dependencyManagementInjector(DefaultModelBuilder.java:213)
> at
> org.apache.maven.repository.internal.MavenResolverModule.configure(MavenResolverModule.java:58)
> (via modules: build.development.boot.Bootstrap$ResolverModule ->
> org.apache.maven.repository.internal.MavenResolverModule)
> ...
> 17 errors
> at
> com.google.inject.internal.Errors.throwCreationExceptionIfErrorsExist(Errors.java:470)
> at
> com.google.inject.internal.InternalInjectorCreator.initializeStatically(InternalInjectorCreator.java:155)
> at
> com.google.inject.internal.InternalInjectorCreator.build(InternalInjectorCreator.java:107)
> at com.google.inject.Guice.createInjector(Guice.java:99)
> at com.google.inject.Guice.createInjector(Guice.java:73)
> at com.google.inject.Guice.createInjector(Guice.java:62){code}
> The relevant code part is:
> {code:java}
> Guice.createInjector(new
> ResolverModule()).getInstance(RepositorySystem.class);
> static class ResolverModule extends AbstractModule {
> @Override
> protected void configure() {
> install(new MavenResolverModule());
>
> bind(RepositoryConnectorFactory.class).annotatedWith(Names.named("basic")).to(BasicRepositoryConnectorFactory.class);
>
> bind(TransporterFactory.class).annotatedWith(Names.named("file")).to(FileTransporterFactory.class);
>
> bind(TransporterFactory.class).annotatedWith(Names.named("http")).to(HttpTransporterFactory.class);
> }
> @Provides
> @Singleton
> Set
> provideRepositoryConnectorFactories(@Named("basic")
> RepositoryConnectorFactory basic) {
> Set factories = new HashSet<>();
> factories.add(basic);
> return Collections.unmodifiableSet(factories);
> }
> @Provides
> @Singleton
> Set provideTransporterFactories(@Named("file")
> TransporterFactory file, @Named("http") TransporterFactory http) {
> Set factories = new HashSet<>();
> factories.add(file);
> factories.add(http);
> return Collections.unmodifiableSet(factories);
> }
> } {code}
> This works with either maven-resolver-provider 3.6.0 or downgrading all
> org.apache.maven.resolver artifacts to 1.3.1.
> It seems as if a similar problem occurred in Idea when setting used Maven
> version to 3.6.2:
> [https://youtrack.jetbrains.com/issue/IDEA-221882]
> Is this a regression introduced in one of the recent maven-resolver versions?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MRESOLVER-96) Dependency Injection fails after upgrading to Maven 3.6.2
[
https://issues.apache.org/jira/browse/MRESOLVER-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120641#comment-17120641
]
Michael Osipov commented on MRESOLVER-96:
-
[~slachiewicz], thanks see the error now. I have no idea how this can be fixed.
Never used Guice directly.
> Dependency Injection fails after upgrading to Maven 3.6.2
> -
>
> Key: MRESOLVER-96
> URL: https://issues.apache.org/jira/browse/MRESOLVER-96
> Project: Maven Resolver
> Issue Type: Bug
> Components: resolver
>Affects Versions: 1.4.1
>Reporter: Marek Neumann
>Priority: Minor
> Fix For: waiting-for-feedback
>
>
> When using Maven Resolver 1.4.1 in combination with Maven 3.6.2 (also 3.6.3)
> we face the following errors when we bootstrap our application:
> {code:java}
> Exception in thread "main" com.google.inject.CreationException: Unable to
> create injector, see the following errors:1) No implementation for
> org.apache.maven.model.composition.DependencyManagementImporter was bound.
> while locating
> org.apache.maven.model.composition.DependencyManagementImporter
> for field at
> org.apache.maven.model.building.DefaultModelBuilder.dependencyManagementImporter(DefaultModelBuilder.java:207)
> at
> org.apache.maven.repository.internal.MavenResolverModule.configure(MavenResolverModule.java:58)
> (via modules: build.development.boot.Bootstrap$ResolverModule ->
> org.apache.maven.repository.internal.MavenResolverModule)2) No implementation
> for org.apache.maven.model.management.DependencyManagementInjector was bound.
> while locating
> org.apache.maven.model.management.DependencyManagementInjector
> for field at
> org.apache.maven.model.building.DefaultModelBuilder.dependencyManagementInjector(DefaultModelBuilder.java:213)
> at
> org.apache.maven.repository.internal.MavenResolverModule.configure(MavenResolverModule.java:58)
> (via modules: build.development.boot.Bootstrap$ResolverModule ->
> org.apache.maven.repository.internal.MavenResolverModule)
> ...
> 17 errors
> at
> com.google.inject.internal.Errors.throwCreationExceptionIfErrorsExist(Errors.java:470)
> at
> com.google.inject.internal.InternalInjectorCreator.initializeStatically(InternalInjectorCreator.java:155)
> at
> com.google.inject.internal.InternalInjectorCreator.build(InternalInjectorCreator.java:107)
> at com.google.inject.Guice.createInjector(Guice.java:99)
> at com.google.inject.Guice.createInjector(Guice.java:73)
> at com.google.inject.Guice.createInjector(Guice.java:62){code}
> The relevant code part is:
> {code:java}
> Guice.createInjector(new
> ResolverModule()).getInstance(RepositorySystem.class);
> static class ResolverModule extends AbstractModule {
> @Override
> protected void configure() {
> install(new MavenResolverModule());
>
> bind(RepositoryConnectorFactory.class).annotatedWith(Names.named("basic")).to(BasicRepositoryConnectorFactory.class);
>
> bind(TransporterFactory.class).annotatedWith(Names.named("file")).to(FileTransporterFactory.class);
>
> bind(TransporterFactory.class).annotatedWith(Names.named("http")).to(HttpTransporterFactory.class);
> }
> @Provides
> @Singleton
> Set
> provideRepositoryConnectorFactories(@Named("basic")
> RepositoryConnectorFactory basic) {
> Set factories = new HashSet<>();
> factories.add(basic);
> return Collections.unmodifiableSet(factories);
> }
> @Provides
> @Singleton
> Set provideTransporterFactories(@Named("file")
> TransporterFactory file, @Named("http") TransporterFactory http) {
> Set factories = new HashSet<>();
> factories.add(file);
> factories.add(http);
> return Collections.unmodifiableSet(factories);
> }
> } {code}
> This works with either maven-resolver-provider 3.6.0 or downgrading all
> org.apache.maven.resolver artifacts to 1.3.1.
> It seems as if a similar problem occurred in Idea when setting used Maven
> version to 3.6.2:
> [https://youtrack.jetbrains.com/issue/IDEA-221882]
> Is this a regression introduced in one of the recent maven-resolver versions?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MRESOLVER-96) Dependency Injection fails after upgrading to Maven 3.6.2
[
https://issues.apache.org/jira/browse/MRESOLVER-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120638#comment-17120638
]
Sylwester Lachiewicz commented on MRESOLVER-96:
---
In org.apache.maven.resolver.examples.util.Booter#newRepositorySystem please
uncomment _GuiceRepositorySystemFactory_ and run one of examples from
_maven-resolver-demo-snippets_
> Dependency Injection fails after upgrading to Maven 3.6.2
> -
>
> Key: MRESOLVER-96
> URL: https://issues.apache.org/jira/browse/MRESOLVER-96
> Project: Maven Resolver
> Issue Type: Bug
> Components: resolver
>Affects Versions: 1.4.1
>Reporter: Marek Neumann
>Priority: Minor
> Fix For: waiting-for-feedback
>
>
> When using Maven Resolver 1.4.1 in combination with Maven 3.6.2 (also 3.6.3)
> we face the following errors when we bootstrap our application:
> {code:java}
> Exception in thread "main" com.google.inject.CreationException: Unable to
> create injector, see the following errors:1) No implementation for
> org.apache.maven.model.composition.DependencyManagementImporter was bound.
> while locating
> org.apache.maven.model.composition.DependencyManagementImporter
> for field at
> org.apache.maven.model.building.DefaultModelBuilder.dependencyManagementImporter(DefaultModelBuilder.java:207)
> at
> org.apache.maven.repository.internal.MavenResolverModule.configure(MavenResolverModule.java:58)
> (via modules: build.development.boot.Bootstrap$ResolverModule ->
> org.apache.maven.repository.internal.MavenResolverModule)2) No implementation
> for org.apache.maven.model.management.DependencyManagementInjector was bound.
> while locating
> org.apache.maven.model.management.DependencyManagementInjector
> for field at
> org.apache.maven.model.building.DefaultModelBuilder.dependencyManagementInjector(DefaultModelBuilder.java:213)
> at
> org.apache.maven.repository.internal.MavenResolverModule.configure(MavenResolverModule.java:58)
> (via modules: build.development.boot.Bootstrap$ResolverModule ->
> org.apache.maven.repository.internal.MavenResolverModule)
> ...
> 17 errors
> at
> com.google.inject.internal.Errors.throwCreationExceptionIfErrorsExist(Errors.java:470)
> at
> com.google.inject.internal.InternalInjectorCreator.initializeStatically(InternalInjectorCreator.java:155)
> at
> com.google.inject.internal.InternalInjectorCreator.build(InternalInjectorCreator.java:107)
> at com.google.inject.Guice.createInjector(Guice.java:99)
> at com.google.inject.Guice.createInjector(Guice.java:73)
> at com.google.inject.Guice.createInjector(Guice.java:62){code}
> The relevant code part is:
> {code:java}
> Guice.createInjector(new
> ResolverModule()).getInstance(RepositorySystem.class);
> static class ResolverModule extends AbstractModule {
> @Override
> protected void configure() {
> install(new MavenResolverModule());
>
> bind(RepositoryConnectorFactory.class).annotatedWith(Names.named("basic")).to(BasicRepositoryConnectorFactory.class);
>
> bind(TransporterFactory.class).annotatedWith(Names.named("file")).to(FileTransporterFactory.class);
>
> bind(TransporterFactory.class).annotatedWith(Names.named("http")).to(HttpTransporterFactory.class);
> }
> @Provides
> @Singleton
> Set
> provideRepositoryConnectorFactories(@Named("basic")
> RepositoryConnectorFactory basic) {
> Set factories = new HashSet<>();
> factories.add(basic);
> return Collections.unmodifiableSet(factories);
> }
> @Provides
> @Singleton
> Set provideTransporterFactories(@Named("file")
> TransporterFactory file, @Named("http") TransporterFactory http) {
> Set factories = new HashSet<>();
> factories.add(file);
> factories.add(http);
> return Collections.unmodifiableSet(factories);
> }
> } {code}
> This works with either maven-resolver-provider 3.6.0 or downgrading all
> org.apache.maven.resolver artifacts to 1.3.1.
> It seems as if a similar problem occurred in Idea when setting used Maven
> version to 3.6.2:
> [https://youtrack.jetbrains.com/issue/IDEA-221882]
> Is this a regression introduced in one of the recent maven-resolver versions?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MRESOLVER-96) Dependency Injection fails after upgrading to Maven 3.6.2
[
https://issues.apache.org/jira/browse/MRESOLVER-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120623#comment-17120623
]
Michael Osipov commented on MRESOLVER-96:
-
[~slachiewicz], I have updated {{mavenVersion}} in the mentioned POM and cannot
reproduce this case. Can someone tell me how to reproduce properly?
> Dependency Injection fails after upgrading to Maven 3.6.2
> -
>
> Key: MRESOLVER-96
> URL: https://issues.apache.org/jira/browse/MRESOLVER-96
> Project: Maven Resolver
> Issue Type: Bug
> Components: resolver
>Affects Versions: 1.4.1
>Reporter: Marek Neumann
>Priority: Minor
>
> When using Maven Resolver 1.4.1 in combination with Maven 3.6.2 (also 3.6.3)
> we face the following errors when we bootstrap our application:
> {code:java}
> Exception in thread "main" com.google.inject.CreationException: Unable to
> create injector, see the following errors:1) No implementation for
> org.apache.maven.model.composition.DependencyManagementImporter was bound.
> while locating
> org.apache.maven.model.composition.DependencyManagementImporter
> for field at
> org.apache.maven.model.building.DefaultModelBuilder.dependencyManagementImporter(DefaultModelBuilder.java:207)
> at
> org.apache.maven.repository.internal.MavenResolverModule.configure(MavenResolverModule.java:58)
> (via modules: build.development.boot.Bootstrap$ResolverModule ->
> org.apache.maven.repository.internal.MavenResolverModule)2) No implementation
> for org.apache.maven.model.management.DependencyManagementInjector was bound.
> while locating
> org.apache.maven.model.management.DependencyManagementInjector
> for field at
> org.apache.maven.model.building.DefaultModelBuilder.dependencyManagementInjector(DefaultModelBuilder.java:213)
> at
> org.apache.maven.repository.internal.MavenResolverModule.configure(MavenResolverModule.java:58)
> (via modules: build.development.boot.Bootstrap$ResolverModule ->
> org.apache.maven.repository.internal.MavenResolverModule)
> ...
> 17 errors
> at
> com.google.inject.internal.Errors.throwCreationExceptionIfErrorsExist(Errors.java:470)
> at
> com.google.inject.internal.InternalInjectorCreator.initializeStatically(InternalInjectorCreator.java:155)
> at
> com.google.inject.internal.InternalInjectorCreator.build(InternalInjectorCreator.java:107)
> at com.google.inject.Guice.createInjector(Guice.java:99)
> at com.google.inject.Guice.createInjector(Guice.java:73)
> at com.google.inject.Guice.createInjector(Guice.java:62){code}
> The relevant code part is:
> {code:java}
> Guice.createInjector(new
> ResolverModule()).getInstance(RepositorySystem.class);
> static class ResolverModule extends AbstractModule {
> @Override
> protected void configure() {
> install(new MavenResolverModule());
>
> bind(RepositoryConnectorFactory.class).annotatedWith(Names.named("basic")).to(BasicRepositoryConnectorFactory.class);
>
> bind(TransporterFactory.class).annotatedWith(Names.named("file")).to(FileTransporterFactory.class);
>
> bind(TransporterFactory.class).annotatedWith(Names.named("http")).to(HttpTransporterFactory.class);
> }
> @Provides
> @Singleton
> Set
> provideRepositoryConnectorFactories(@Named("basic")
> RepositoryConnectorFactory basic) {
> Set factories = new HashSet<>();
> factories.add(basic);
> return Collections.unmodifiableSet(factories);
> }
> @Provides
> @Singleton
> Set provideTransporterFactories(@Named("file")
> TransporterFactory file, @Named("http") TransporterFactory http) {
> Set factories = new HashSet<>();
> factories.add(file);
> factories.add(http);
> return Collections.unmodifiableSet(factories);
> }
> } {code}
> This works with either maven-resolver-provider 3.6.0 or downgrading all
> org.apache.maven.resolver artifacts to 1.3.1.
> It seems as if a similar problem occurred in Idea when setting used Maven
> version to 3.6.2:
> [https://youtrack.jetbrains.com/issue/IDEA-221882]
> Is this a regression introduced in one of the recent maven-resolver versions?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MRESOLVER-96) Dependency Injection fails after upgrading to Maven 3.6.2
[
https://issues.apache.org/jira/browse/MRESOLVER-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088641#comment-17088641
]
Marek Neumann commented on MRESOLVER-96:
We had to add a lot of code to make it work with Maven 3.6.2. It would be nice
if it could be fixed.
> Dependency Injection fails after upgrading to Maven 3.6.2
> -
>
> Key: MRESOLVER-96
> URL: https://issues.apache.org/jira/browse/MRESOLVER-96
> Project: Maven Resolver
> Issue Type: Bug
> Components: resolver
>Affects Versions: 1.4.1
>Reporter: Marek Neumann
>Priority: Minor
>
> When using Maven Resolver 1.4.1 in combination with Maven 3.6.2 (also 3.6.3)
> we face the following errors when we bootstrap our application:
> {code:java}
> Exception in thread "main" com.google.inject.CreationException: Unable to
> create injector, see the following errors:1) No implementation for
> org.apache.maven.model.composition.DependencyManagementImporter was bound.
> while locating
> org.apache.maven.model.composition.DependencyManagementImporter
> for field at
> org.apache.maven.model.building.DefaultModelBuilder.dependencyManagementImporter(DefaultModelBuilder.java:207)
> at
> org.apache.maven.repository.internal.MavenResolverModule.configure(MavenResolverModule.java:58)
> (via modules: build.development.boot.Bootstrap$ResolverModule ->
> org.apache.maven.repository.internal.MavenResolverModule)2) No implementation
> for org.apache.maven.model.management.DependencyManagementInjector was bound.
> while locating
> org.apache.maven.model.management.DependencyManagementInjector
> for field at
> org.apache.maven.model.building.DefaultModelBuilder.dependencyManagementInjector(DefaultModelBuilder.java:213)
> at
> org.apache.maven.repository.internal.MavenResolverModule.configure(MavenResolverModule.java:58)
> (via modules: build.development.boot.Bootstrap$ResolverModule ->
> org.apache.maven.repository.internal.MavenResolverModule)
> ...
> 17 errors
> at
> com.google.inject.internal.Errors.throwCreationExceptionIfErrorsExist(Errors.java:470)
> at
> com.google.inject.internal.InternalInjectorCreator.initializeStatically(InternalInjectorCreator.java:155)
> at
> com.google.inject.internal.InternalInjectorCreator.build(InternalInjectorCreator.java:107)
> at com.google.inject.Guice.createInjector(Guice.java:99)
> at com.google.inject.Guice.createInjector(Guice.java:73)
> at com.google.inject.Guice.createInjector(Guice.java:62){code}
> The relevant code part is:
> {code:java}
> Guice.createInjector(new
> ResolverModule()).getInstance(RepositorySystem.class);
> static class ResolverModule extends AbstractModule {
> @Override
> protected void configure() {
> install(new MavenResolverModule());
>
> bind(RepositoryConnectorFactory.class).annotatedWith(Names.named("basic")).to(BasicRepositoryConnectorFactory.class);
>
> bind(TransporterFactory.class).annotatedWith(Names.named("file")).to(FileTransporterFactory.class);
>
> bind(TransporterFactory.class).annotatedWith(Names.named("http")).to(HttpTransporterFactory.class);
> }
> @Provides
> @Singleton
> Set
> provideRepositoryConnectorFactories(@Named("basic")
> RepositoryConnectorFactory basic) {
> Set factories = new HashSet<>();
> factories.add(basic);
> return Collections.unmodifiableSet(factories);
> }
> @Provides
> @Singleton
> Set provideTransporterFactories(@Named("file")
> TransporterFactory file, @Named("http") TransporterFactory http) {
> Set factories = new HashSet<>();
> factories.add(file);
> factories.add(http);
> return Collections.unmodifiableSet(factories);
> }
> } {code}
> This works with either maven-resolver-provider 3.6.0 or downgrading all
> org.apache.maven.resolver artifacts to 1.3.1.
> It seems as if a similar problem occurred in Idea when setting used Maven
> version to 3.6.2:
> [https://youtrack.jetbrains.com/issue/IDEA-221882]
> Is this a regression introduced in one of the recent maven-resolver versions?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MRESOLVER-96) Dependency Injection fails after upgrading to Maven 3.6.2
[
https://issues.apache.org/jira/browse/MRESOLVER-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088070#comment-17088070
]
Michael Osipov commented on MRESOLVER-96:
-
Can someone provide a PR with a test? I'be happy to merge this.
> Dependency Injection fails after upgrading to Maven 3.6.2
> -
>
> Key: MRESOLVER-96
> URL: https://issues.apache.org/jira/browse/MRESOLVER-96
> Project: Maven Resolver
> Issue Type: Bug
> Components: resolver
>Affects Versions: 1.4.1
>Reporter: Marek Neumann
>Priority: Minor
>
> When using Maven Resolver 1.4.1 in combination with Maven 3.6.2 (also 3.6.3)
> we face the following errors when we bootstrap our application:
> {code:java}
> Exception in thread "main" com.google.inject.CreationException: Unable to
> create injector, see the following errors:1) No implementation for
> org.apache.maven.model.composition.DependencyManagementImporter was bound.
> while locating
> org.apache.maven.model.composition.DependencyManagementImporter
> for field at
> org.apache.maven.model.building.DefaultModelBuilder.dependencyManagementImporter(DefaultModelBuilder.java:207)
> at
> org.apache.maven.repository.internal.MavenResolverModule.configure(MavenResolverModule.java:58)
> (via modules: build.development.boot.Bootstrap$ResolverModule ->
> org.apache.maven.repository.internal.MavenResolverModule)2) No implementation
> for org.apache.maven.model.management.DependencyManagementInjector was bound.
> while locating
> org.apache.maven.model.management.DependencyManagementInjector
> for field at
> org.apache.maven.model.building.DefaultModelBuilder.dependencyManagementInjector(DefaultModelBuilder.java:213)
> at
> org.apache.maven.repository.internal.MavenResolverModule.configure(MavenResolverModule.java:58)
> (via modules: build.development.boot.Bootstrap$ResolverModule ->
> org.apache.maven.repository.internal.MavenResolverModule)
> ...
> 17 errors
> at
> com.google.inject.internal.Errors.throwCreationExceptionIfErrorsExist(Errors.java:470)
> at
> com.google.inject.internal.InternalInjectorCreator.initializeStatically(InternalInjectorCreator.java:155)
> at
> com.google.inject.internal.InternalInjectorCreator.build(InternalInjectorCreator.java:107)
> at com.google.inject.Guice.createInjector(Guice.java:99)
> at com.google.inject.Guice.createInjector(Guice.java:73)
> at com.google.inject.Guice.createInjector(Guice.java:62){code}
> The relevant code part is:
> {code:java}
> Guice.createInjector(new
> ResolverModule()).getInstance(RepositorySystem.class);
> static class ResolverModule extends AbstractModule {
> @Override
> protected void configure() {
> install(new MavenResolverModule());
>
> bind(RepositoryConnectorFactory.class).annotatedWith(Names.named("basic")).to(BasicRepositoryConnectorFactory.class);
>
> bind(TransporterFactory.class).annotatedWith(Names.named("file")).to(FileTransporterFactory.class);
>
> bind(TransporterFactory.class).annotatedWith(Names.named("http")).to(HttpTransporterFactory.class);
> }
> @Provides
> @Singleton
> Set
> provideRepositoryConnectorFactories(@Named("basic")
> RepositoryConnectorFactory basic) {
> Set factories = new HashSet<>();
> factories.add(basic);
> return Collections.unmodifiableSet(factories);
> }
> @Provides
> @Singleton
> Set provideTransporterFactories(@Named("file")
> TransporterFactory file, @Named("http") TransporterFactory http) {
> Set factories = new HashSet<>();
> factories.add(file);
> factories.add(http);
> return Collections.unmodifiableSet(factories);
> }
> } {code}
> This works with either maven-resolver-provider 3.6.0 or downgrading all
> org.apache.maven.resolver artifacts to 1.3.1.
> It seems as if a similar problem occurred in Idea when setting used Maven
> version to 3.6.2:
> [https://youtrack.jetbrains.com/issue/IDEA-221882]
> Is this a regression introduced in one of the recent maven-resolver versions?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MRESOLVER-96) Dependency Injection fails after upgrading to Maven 3.6.2
[
https://issues.apache.org/jira/browse/MRESOLVER-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015761#comment-17015761
]
Marek Neumann commented on MRESOLVER-96:
Thanks for having a glance and for the workaround. We found another easier way
to include the resolver without having the need for the Guice dependency. Will
there be a fix in the next release for the regression with Maven >=3.6.2?
> Dependency Injection fails after upgrading to Maven 3.6.2
> -
>
> Key: MRESOLVER-96
> URL: https://issues.apache.org/jira/browse/MRESOLVER-96
> Project: Maven Resolver
> Issue Type: Bug
> Components: resolver
>Affects Versions: 1.4.1
>Reporter: Marek Neumann
>Priority: Minor
>
> When using Maven Resolver 1.4.1 in combination with Maven 3.6.2 (also 3.6.3)
> we face the following errors when we bootstrap our application:
> {code:java}
> Exception in thread "main" com.google.inject.CreationException: Unable to
> create injector, see the following errors:1) No implementation for
> org.apache.maven.model.composition.DependencyManagementImporter was bound.
> while locating
> org.apache.maven.model.composition.DependencyManagementImporter
> for field at
> org.apache.maven.model.building.DefaultModelBuilder.dependencyManagementImporter(DefaultModelBuilder.java:207)
> at
> org.apache.maven.repository.internal.MavenResolverModule.configure(MavenResolverModule.java:58)
> (via modules: build.development.boot.Bootstrap$ResolverModule ->
> org.apache.maven.repository.internal.MavenResolverModule)2) No implementation
> for org.apache.maven.model.management.DependencyManagementInjector was bound.
> while locating
> org.apache.maven.model.management.DependencyManagementInjector
> for field at
> org.apache.maven.model.building.DefaultModelBuilder.dependencyManagementInjector(DefaultModelBuilder.java:213)
> at
> org.apache.maven.repository.internal.MavenResolverModule.configure(MavenResolverModule.java:58)
> (via modules: build.development.boot.Bootstrap$ResolverModule ->
> org.apache.maven.repository.internal.MavenResolverModule)
> ...
> 17 errors
> at
> com.google.inject.internal.Errors.throwCreationExceptionIfErrorsExist(Errors.java:470)
> at
> com.google.inject.internal.InternalInjectorCreator.initializeStatically(InternalInjectorCreator.java:155)
> at
> com.google.inject.internal.InternalInjectorCreator.build(InternalInjectorCreator.java:107)
> at com.google.inject.Guice.createInjector(Guice.java:99)
> at com.google.inject.Guice.createInjector(Guice.java:73)
> at com.google.inject.Guice.createInjector(Guice.java:62){code}
> The relevant code part is:
> {code:java}
> Guice.createInjector(new
> ResolverModule()).getInstance(RepositorySystem.class);
> static class ResolverModule extends AbstractModule {
> @Override
> protected void configure() {
> install(new MavenResolverModule());
>
> bind(RepositoryConnectorFactory.class).annotatedWith(Names.named("basic")).to(BasicRepositoryConnectorFactory.class);
>
> bind(TransporterFactory.class).annotatedWith(Names.named("file")).to(FileTransporterFactory.class);
>
> bind(TransporterFactory.class).annotatedWith(Names.named("http")).to(HttpTransporterFactory.class);
> }
> @Provides
> @Singleton
> Set
> provideRepositoryConnectorFactories(@Named("basic")
> RepositoryConnectorFactory basic) {
> Set factories = new HashSet<>();
> factories.add(basic);
> return Collections.unmodifiableSet(factories);
> }
> @Provides
> @Singleton
> Set provideTransporterFactories(@Named("file")
> TransporterFactory file, @Named("http") TransporterFactory http) {
> Set factories = new HashSet<>();
> factories.add(file);
> factories.add(http);
> return Collections.unmodifiableSet(factories);
> }
> } {code}
> This works with either maven-resolver-provider 3.6.0 or downgrading all
> org.apache.maven.resolver artifacts to 1.3.1.
> It seems as if a similar problem occurred in Idea when setting used Maven
> version to 3.6.2:
> [https://youtrack.jetbrains.com/issue/IDEA-221882]
> Is this a regression introduced in one of the recent maven-resolver versions?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MRESOLVER-96) Dependency Injection fails after upgrading to Maven 3.6.2
[
https://issues.apache.org/jira/browse/MRESOLVER-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015529#comment-17015529
]
Sylwester Lachiewicz commented on MRESOLVER-96:
---
Looks we missed adding Guice "Maven Model Module" while refactoring to JSR 330
Quick fix for your code oud be to manually add missing bindings
{{bind( DependencyManagementImporter.class ).to(
DefaultDependencyManagementImporter.class );}}
{{bind( DependencyManagementInjector.class ).to(
DefaultDependencyManagementInjector.class );}}
{{...}}
> Dependency Injection fails after upgrading to Maven 3.6.2
> -
>
> Key: MRESOLVER-96
> URL: https://issues.apache.org/jira/browse/MRESOLVER-96
> Project: Maven Resolver
> Issue Type: Bug
> Components: resolver
>Affects Versions: 1.4.1
>Reporter: Marek Neumann
>Priority: Minor
>
> When using Maven Resolver 1.4.1 in combination with Maven 3.6.2 (also 3.6.3)
> we face the following errors when we bootstrap our application:
> {code:java}
> Exception in thread "main" com.google.inject.CreationException: Unable to
> create injector, see the following errors:1) No implementation for
> org.apache.maven.model.composition.DependencyManagementImporter was bound.
> while locating
> org.apache.maven.model.composition.DependencyManagementImporter
> for field at
> org.apache.maven.model.building.DefaultModelBuilder.dependencyManagementImporter(DefaultModelBuilder.java:207)
> at
> org.apache.maven.repository.internal.MavenResolverModule.configure(MavenResolverModule.java:58)
> (via modules: build.development.boot.Bootstrap$ResolverModule ->
> org.apache.maven.repository.internal.MavenResolverModule)2) No implementation
> for org.apache.maven.model.management.DependencyManagementInjector was bound.
> while locating
> org.apache.maven.model.management.DependencyManagementInjector
> for field at
> org.apache.maven.model.building.DefaultModelBuilder.dependencyManagementInjector(DefaultModelBuilder.java:213)
> at
> org.apache.maven.repository.internal.MavenResolverModule.configure(MavenResolverModule.java:58)
> (via modules: build.development.boot.Bootstrap$ResolverModule ->
> org.apache.maven.repository.internal.MavenResolverModule)
> ...
> 17 errors
> at
> com.google.inject.internal.Errors.throwCreationExceptionIfErrorsExist(Errors.java:470)
> at
> com.google.inject.internal.InternalInjectorCreator.initializeStatically(InternalInjectorCreator.java:155)
> at
> com.google.inject.internal.InternalInjectorCreator.build(InternalInjectorCreator.java:107)
> at com.google.inject.Guice.createInjector(Guice.java:99)
> at com.google.inject.Guice.createInjector(Guice.java:73)
> at com.google.inject.Guice.createInjector(Guice.java:62){code}
> The relevant code part is:
> {code:java}
> Guice.createInjector(new
> ResolverModule()).getInstance(RepositorySystem.class);
> static class ResolverModule extends AbstractModule {
> @Override
> protected void configure() {
> install(new MavenResolverModule());
>
> bind(RepositoryConnectorFactory.class).annotatedWith(Names.named("basic")).to(BasicRepositoryConnectorFactory.class);
>
> bind(TransporterFactory.class).annotatedWith(Names.named("file")).to(FileTransporterFactory.class);
>
> bind(TransporterFactory.class).annotatedWith(Names.named("http")).to(HttpTransporterFactory.class);
> }
> @Provides
> @Singleton
> Set
> provideRepositoryConnectorFactories(@Named("basic")
> RepositoryConnectorFactory basic) {
> Set factories = new HashSet<>();
> factories.add(basic);
> return Collections.unmodifiableSet(factories);
> }
> @Provides
> @Singleton
> Set provideTransporterFactories(@Named("file")
> TransporterFactory file, @Named("http") TransporterFactory http) {
> Set factories = new HashSet<>();
> factories.add(file);
> factories.add(http);
> return Collections.unmodifiableSet(factories);
> }
> } {code}
> This works with either maven-resolver-provider 3.6.0 or downgrading all
> org.apache.maven.resolver artifacts to 1.3.1.
> It seems as if a similar problem occurred in Idea when setting used Maven
> version to 3.6.2:
> [https://youtrack.jetbrains.com/issue/IDEA-221882]
> Is this a regression introduced in one of the recent maven-resolver versions?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MRESOLVER-96) Dependency Injection fails after upgrading to Maven 3.6.2
[
https://issues.apache.org/jira/browse/MRESOLVER-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015515#comment-17015515
]
Sylwester Lachiewicz commented on MRESOLVER-96:
---
To reproduce: use
_org.apache.maven.resolver.examples.guice.GuiceRepositorySystemFactory_ class
and adjust maven version in _maven-resolver-demo-snippets_ module.
Works ok for 3.6.1(/), failed for 3.6.2/3(x)
> Dependency Injection fails after upgrading to Maven 3.6.2
> -
>
> Key: MRESOLVER-96
> URL: https://issues.apache.org/jira/browse/MRESOLVER-96
> Project: Maven Resolver
> Issue Type: Bug
> Components: resolver
>Affects Versions: 1.4.1
>Reporter: Marek Neumann
>Priority: Minor
>
> When using Maven Resolver 1.4.1 in combination with Maven 3.6.2 (also 3.6.3)
> we face the following errors when we bootstrap our application:
> {code:java}
> Exception in thread "main" com.google.inject.CreationException: Unable to
> create injector, see the following errors:1) No implementation for
> org.apache.maven.model.composition.DependencyManagementImporter was bound.
> while locating
> org.apache.maven.model.composition.DependencyManagementImporter
> for field at
> org.apache.maven.model.building.DefaultModelBuilder.dependencyManagementImporter(DefaultModelBuilder.java:207)
> at
> org.apache.maven.repository.internal.MavenResolverModule.configure(MavenResolverModule.java:58)
> (via modules: build.development.boot.Bootstrap$ResolverModule ->
> org.apache.maven.repository.internal.MavenResolverModule)2) No implementation
> for org.apache.maven.model.management.DependencyManagementInjector was bound.
> while locating
> org.apache.maven.model.management.DependencyManagementInjector
> for field at
> org.apache.maven.model.building.DefaultModelBuilder.dependencyManagementInjector(DefaultModelBuilder.java:213)
> at
> org.apache.maven.repository.internal.MavenResolverModule.configure(MavenResolverModule.java:58)
> (via modules: build.development.boot.Bootstrap$ResolverModule ->
> org.apache.maven.repository.internal.MavenResolverModule)
> ...
> 17 errors
> at
> com.google.inject.internal.Errors.throwCreationExceptionIfErrorsExist(Errors.java:470)
> at
> com.google.inject.internal.InternalInjectorCreator.initializeStatically(InternalInjectorCreator.java:155)
> at
> com.google.inject.internal.InternalInjectorCreator.build(InternalInjectorCreator.java:107)
> at com.google.inject.Guice.createInjector(Guice.java:99)
> at com.google.inject.Guice.createInjector(Guice.java:73)
> at com.google.inject.Guice.createInjector(Guice.java:62){code}
> The relevant code part is:
> {code:java}
> Guice.createInjector(new
> ResolverModule()).getInstance(RepositorySystem.class);
> static class ResolverModule extends AbstractModule {
> @Override
> protected void configure() {
> install(new MavenResolverModule());
>
> bind(RepositoryConnectorFactory.class).annotatedWith(Names.named("basic")).to(BasicRepositoryConnectorFactory.class);
>
> bind(TransporterFactory.class).annotatedWith(Names.named("file")).to(FileTransporterFactory.class);
>
> bind(TransporterFactory.class).annotatedWith(Names.named("http")).to(HttpTransporterFactory.class);
> }
> @Provides
> @Singleton
> Set
> provideRepositoryConnectorFactories(@Named("basic")
> RepositoryConnectorFactory basic) {
> Set factories = new HashSet<>();
> factories.add(basic);
> return Collections.unmodifiableSet(factories);
> }
> @Provides
> @Singleton
> Set provideTransporterFactories(@Named("file")
> TransporterFactory file, @Named("http") TransporterFactory http) {
> Set factories = new HashSet<>();
> factories.add(file);
> factories.add(http);
> return Collections.unmodifiableSet(factories);
> }
> } {code}
> This works with either maven-resolver-provider 3.6.0 or downgrading all
> org.apache.maven.resolver artifacts to 1.3.1.
> It seems as if a similar problem occurred in Idea when setting used Maven
> version to 3.6.2:
> [https://youtrack.jetbrains.com/issue/IDEA-221882]
> Is this a regression introduced in one of the recent maven-resolver versions?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
