[jira] [Commented] (SCM-869) gitexe list() implemented incorrectly

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499967#comment-16499967
 ] 

Michael Osipov commented on SCM-869:


Done. I have applied the same {{.gitattributes}} as in Maven SCM and corrected 
the line endings of the given files.

> gitexe list() implemented incorrectly
> -
>
> Key: SCM-869
> URL: https://issues.apache.org/jira/browse/SCM-869
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5, 1.10.0
>Reporter: Ilya Basin
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.10.0
>
>
> Taking the Svn implementation as a model, ScmProvider.list() should be 
> implemented as follows:
>  * The command must directly query the remote repository for files
>  * A local working copy is unnecessary and if it doesn't exist, the remote 
> repository must not be checked out.
>  * fileSet.getBasedir() indicates where to run the scm binary. The 
> recommended value is ".".
>  * fileSet.getFileList() indicates the files to list
>  * repository indicates the repo URL
> Git (among other SCMs) does not support listing remote files, so the command 
> should just fail.
> For listing files in a working copy, users should call the 
> ScmProvider.status() method instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-869) gitexe list() implemented incorrectly

[Ilya Basin (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499827#comment-16499827
 ] 

Ilya Basin commented on SCM-869:


Yeah, they look good. I have a minor request though. Please ensure that the 
files "HEAD" and "refs/heads/master" in test-repo-git have LF and not CRLF. 
It's strange that my .gitattributes didn't help. Sorry for being paranoid.

> gitexe list() implemented incorrectly
> -
>
> Key: SCM-869
> URL: https://issues.apache.org/jira/browse/SCM-869
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5, 1.10.0
>Reporter: Ilya Basin
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.10.0
>
>
> Taking the Svn implementation as a model, ScmProvider.list() should be 
> implemented as follows:
>  * The command must directly query the remote repository for files
>  * A local working copy is unnecessary and if it doesn't exist, the remote 
> repository must not be checked out.
>  * fileSet.getBasedir() indicates where to run the scm binary. The 
> recommended value is ".".
>  * fileSet.getFileList() indicates the files to list
>  * repository indicates the repo URL
> Git (among other SCMs) does not support listing remote files, so the command 
> should just fail.
> For listing files in a working copy, users should call the 
> ScmProvider.status() method instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-869) gitexe list() implemented incorrectly

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499586#comment-16499586
 ] 

Michael Osipov commented on SCM-869:


I have updated the branch and consolidated all of your PRs. Please have a look. 
Tests look good now.

> gitexe list() implemented incorrectly
> -
>
> Key: SCM-869
> URL: https://issues.apache.org/jira/browse/SCM-869
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5, 1.10.0
>Reporter: Ilya Basin
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.10.0
>
>
> Taking the Svn implementation as a model, ScmProvider.list() should be 
> implemented as follows:
>  * The command must directly query the remote repository for files
>  * A local working copy is unnecessary and if it doesn't exist, the remote 
> repository must not be checked out.
>  * fileSet.getBasedir() indicates where to run the scm binary. The 
> recommended value is ".".
>  * fileSet.getFileList() indicates the files to list
>  * repository indicates the repo URL
> Git (among other SCMs) does not support listing remote files, so the command 
> should just fail.
> For listing files in a working copy, users should call the 
> ScmProvider.status() method instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-869) gitexe list() implemented incorrectly

[Ilya Basin (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499559#comment-16499559
 ] 

Ilya Basin commented on SCM-869:


They will solve it, because these tests no longer will call list().

> gitexe list() implemented incorrectly
> -
>
> Key: SCM-869
> URL: https://issues.apache.org/jira/browse/SCM-869
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5, 1.10.0
>Reporter: Ilya Basin
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.10.0
>
>
> Taking the Svn implementation as a model, ScmProvider.list() should be 
> implemented as follows:
>  * The command must directly query the remote repository for files
>  * A local working copy is unnecessary and if it doesn't exist, the remote 
> repository must not be checked out.
>  * fileSet.getBasedir() indicates where to run the scm binary. The 
> recommended value is ".".
>  * fileSet.getFileList() indicates the files to list
>  * repository indicates the repo URL
> Git (among other SCMs) does not support listing remote files, so the command 
> should just fail.
> For listing files in a working copy, users should call the 
> ScmProvider.status() method instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-869) gitexe list() implemented incorrectly

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499558#comment-16499558
 ] 

Michael Osipov commented on SCM-869:


But they won't solve the failures for the missing list command, will they? I 
have disabled those tests in a subsequent commit.

> gitexe list() implemented incorrectly
> -
>
> Key: SCM-869
> URL: https://issues.apache.org/jira/browse/SCM-869
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5, 1.10.0
>Reporter: Ilya Basin
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.10.0
>
>
> Taking the Svn implementation as a model, ScmProvider.list() should be 
> implemented as follows:
>  * The command must directly query the remote repository for files
>  * A local working copy is unnecessary and if it doesn't exist, the remote 
> repository must not be checked out.
>  * fileSet.getBasedir() indicates where to run the scm binary. The 
> recommended value is ".".
>  * fileSet.getFileList() indicates the files to list
>  * repository indicates the repo URL
> Git (among other SCMs) does not support listing remote files, so the command 
> should just fail.
> For listing files in a working copy, users should call the 
> ScmProvider.status() method instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-869) gitexe list() implemented incorrectly

[Ilya Basin (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499544#comment-16499544
 ] 

Ilya Basin commented on SCM-869:


You're right. GitExe requires several other patches that already exist as pull 
requests. Please consider them in the following order:
WAGON-497, WAGON-498, WAGON-495

> gitexe list() implemented incorrectly
> -
>
> Key: SCM-869
> URL: https://issues.apache.org/jira/browse/SCM-869
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5, 1.10.0
>Reporter: Ilya Basin
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.10.0
>
>
> Taking the Svn implementation as a model, ScmProvider.list() should be 
> implemented as follows:
>  * The command must directly query the remote repository for files
>  * A local working copy is unnecessary and if it doesn't exist, the remote 
> repository must not be checked out.
>  * fileSet.getBasedir() indicates where to run the scm binary. The 
> recommended value is ".".
>  * fileSet.getFileList() indicates the files to list
>  * repository indicates the repo URL
> Git (among other SCMs) does not support listing remote files, so the command 
> should just fail.
> For listing files in a working copy, users should call the 
> ScmProvider.status() method instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-869) gitexe list() implemented incorrectly

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499533#comment-16499533
 ] 

Michael Osipov commented on SCM-869:


I have remerge and rebased. Down to four failures.

> gitexe list() implemented incorrectly
> -
>
> Key: SCM-869
> URL: https://issues.apache.org/jira/browse/SCM-869
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5, 1.10.0
>Reporter: Ilya Basin
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.10.0
>
>
> Taking the Svn implementation as a model, ScmProvider.list() should be 
> implemented as follows:
>  * The command must directly query the remote repository for files
>  * A local working copy is unnecessary and if it doesn't exist, the remote 
> repository must not be checked out.
>  * fileSet.getBasedir() indicates where to run the scm binary. The 
> recommended value is ".".
>  * fileSet.getFileList() indicates the files to list
>  * repository indicates the repo URL
> Git (among other SCMs) does not support listing remote files, so the command 
> should just fail.
> For listing files in a working copy, users should call the 
> ScmProvider.status() method instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-869) gitexe list() implemented incorrectly

[Ilya Basin (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499525#comment-16499525
 ] 

Ilya Basin commented on SCM-869:


Your copy of the WAGON-501 branch seems outdated. Please pull.

> gitexe list() implemented incorrectly
> -
>
> Key: SCM-869
> URL: https://issues.apache.org/jira/browse/SCM-869
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5, 1.10.0
>Reporter: Ilya Basin
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.10.0
>
>
> Taking the Svn implementation as a model, ScmProvider.list() should be 
> implemented as follows:
>  * The command must directly query the remote repository for files
>  * A local working copy is unnecessary and if it doesn't exist, the remote 
> repository must not be checked out.
>  * fileSet.getBasedir() indicates where to run the scm binary. The 
> recommended value is ".".
>  * fileSet.getFileList() indicates the files to list
>  * repository indicates the repo URL
> Git (among other SCMs) does not support listing remote files, so the command 
> should just fail.
> For listing files in a working copy, users should call the 
> ScmProvider.status() method instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-869) gitexe list() implemented incorrectly

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499516#comment-16499516
 ] 

Michael Osipov commented on SCM-869:


I have pushed a branch {{wagon-scm-git}}, but tests still fail. What else do I 
need to do. I guess the tests are broken, aren't they?

> gitexe list() implemented incorrectly
> -
>
> Key: SCM-869
> URL: https://issues.apache.org/jira/browse/SCM-869
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5, 1.10.0
>Reporter: Ilya Basin
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.10.0
>
>
> Taking the Svn implementation as a model, ScmProvider.list() should be 
> implemented as follows:
>  * The command must directly query the remote repository for files
>  * A local working copy is unnecessary and if it doesn't exist, the remote 
> repository must not be checked out.
>  * fileSet.getBasedir() indicates where to run the scm binary. The 
> recommended value is ".".
>  * fileSet.getFileList() indicates the files to list
>  * repository indicates the repo URL
> Git (among other SCMs) does not support listing remote files, so the command 
> should just fail.
> For listing files in a working copy, users should call the 
> ScmProvider.status() method instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-869) gitexe list() implemented incorrectly

[Ilya Basin (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499503#comment-16499503
 ] 

Ilya Basin commented on SCM-869:


To enable gitexe test, you need to apply WAGON-498 and WAGON-501. WAGON-501 
disables particularly 
[testWagonGetFileListWhenDirectoryDoesNotExist|https://github.com/basinilya/maven-wagon/blob/WAGON-501/wagon-providers/wagon-scm/src/test/java/org/apache/maven/wagon/providers/scm/ScmGitExeWagonTest.java#L53].
 

> gitexe list() implemented incorrectly
> -
>
> Key: SCM-869
> URL: https://issues.apache.org/jira/browse/SCM-869
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5, 1.10.0
>Reporter: Ilya Basin
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.10.0
>
>
> Taking the Svn implementation as a model, ScmProvider.list() should be 
> implemented as follows:
>  * The command must directly query the remote repository for files
>  * A local working copy is unnecessary and if it doesn't exist, the remote 
> repository must not be checked out.
>  * fileSet.getBasedir() indicates where to run the scm binary. The 
> recommended value is ".".
>  * fileSet.getFileList() indicates the files to list
>  * repository indicates the repo URL
> Git (among other SCMs) does not support listing remote files, so the command 
> should just fail.
> For listing files in a working copy, users should call the 
> ScmProvider.status() method instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-869) gitexe list() implemented incorrectly

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499386#comment-16499386
 ] 

Michael Osipov commented on SCM-869:


This change makes now Wagon fail:

{noformat}
[INFO] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14 s - 
i   
  n 
org.apache.maven.wagon.providers.scm.ScmSvnExeWagonTest
[INFO] Running org.apache.maven.wagon.providers.scm.ScmGitExeWagonTest
[ERROR] Tests run: 14, Failures: 0, Errors: 5, Skipped: 0, Time elapsed: 1.86 s 

 
<<< FAILURE! - in org.apache.maven.wagon.providers.scm.ScmGitExeWagonTest
[ERROR] 
testWagonPutDirectoryDeepDestination(org.apache.maven.wagon.providers.sc

 
m.ScmGitExeWagonTest)  Time elapsed: 0.117 s  <<< ERROR!
org.apache.maven.wagon.TransferFailedException: Error listing repository: No 
suc 

h command 'list'.
Caused by: org.apache.maven.scm.NoSuchCommandScmException: No such command 
'list   

  '.

[ERROR] 
testWagonGetFileListWhenDirectoryDoesNotExist(org.apache.maven.wagon.pro

 
viders.scm.ScmGitExeWagonTest)  Time elapsed: 0.044 s  <<< ERROR!
org.apache.maven.wagon.TransferFailedException: Error getting filelist from SCM
Caused by: org.apache.maven.scm.NoSuchCommandScmException: No such command 
'list   

  '.

[ERROR] 
testWagonPutDirectoryForDot(org.apache.maven.wagon.providers.scm.ScmGitE

 
xeWagonTest)  Time elapsed: 0.091 s  <<< ERROR!
org.apache.maven.wagon.TransferFailedException: Error listing repository: No 
suc 

h command 'list'.
Caused by: org.apache.maven.scm.NoSuchCommandScmException: No such command 
'list   

  '.

[ERROR] 
testWagonPutDirectoryWhenDirectoryAlreadyExists(org.apache.maven.wagon.p

 
roviders.scm.ScmGitExeWagonTest)  Time elapsed: 0.075 s  <<< ERROR!
org.apache.maven.wagon.TransferFailedException: Error listing repository: No 
suc 

h command 'list'.
Caused by: org.apache.maven.scm.NoSuchCommandScmException: No such command 
'list   

  '.

[ERROR] 
testWagonPutDirectory(org.apache.maven.wagon.providers.scm.ScmGitExeWago

 nTest)  
Time elapsed: 0.107 s  <<< ERROR!
org.apache.maven.wagon.TransferFailedException: Error listing repository: No 
suc 

h command 'list'.
Caused by: org.apache.maven.scm.NoSuchCommandScmException: No such command 
'list   

  '.

[INFO]
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR]   
ScmGitExeWagonTest>WagonTestCase.testWagonGetFileListWhenDirectoryDoes  

  

[jira] [Commented] (SCM-869) gitexe list() implemented incorrectly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464371#comment-16464371
 ] 

ASF GitHub Bot commented on SCM-869:


asfgit closed pull request #67: [SCM-869] fix gitexe list() implemented 
incorrectly
URL: https://github.com/apache/maven-scm/pull/67
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-git-commons/src/main/java/org/apache/maven/scm/provider/git/AbstractGitScmProvider.java
 
b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-git-commons/src/main/java/org/apache/maven/scm/provider/git/AbstractGitScmProvider.java
index 3609335cd..b26f2688c 100644
--- 
a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-git-commons/src/main/java/org/apache/maven/scm/provider/git/AbstractGitScmProvider.java
+++ 
b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-git-commons/src/main/java/org/apache/maven/scm/provider/git/AbstractGitScmProvider.java
@@ -291,17 +291,6 @@ protected ScmResult executeCommand( GitCommand command, 
ScmProviderRepository re
 return command.execute( repository, fileSet, parameters );
 }
 
-protected abstract GitCommand getListCommand();
-
-/** {@inheritDoc} */
-public ListScmResult list( ScmProviderRepository repository, ScmFileSet 
fileSet, CommandParameters parameters )
-throws ScmException
-{
-GitCommand cmd = getListCommand();
-
-return (ListScmResult) executeCommand( cmd, repository, fileSet, 
parameters );
-}
-
 protected abstract GitCommand getInfoCommand();
 
 public InfoScmResult info( ScmProviderRepository repository, ScmFileSet 
fileSet, CommandParameters parameters )
diff --git 
a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-git-commons/src/test/java/org/apache/maven/scm/provider/git/TestGitScmProvider.java
 
b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-git-commons/src/test/java/org/apache/maven/scm/provider/git/TestGitScmProvider.java
index 2f596b8b5..3f07e9a31 100644
--- 
a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-git-commons/src/test/java/org/apache/maven/scm/provider/git/TestGitScmProvider.java
+++ 
b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-git-commons/src/test/java/org/apache/maven/scm/provider/git/TestGitScmProvider.java
@@ -81,11 +81,6 @@ protected GitCommand getUpdateCommand()
 return null;
 }
 
-protected GitCommand getListCommand()
-{
-return null;
-}
-
 protected GitCommand getInfoCommand()
 {
 return null;
diff --git 
a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/GitExeScmProvider.java
 
b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/GitExeScmProvider.java
index 24283772f..8f61e86d0 100644
--- 
a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/GitExeScmProvider.java
+++ 
b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/GitExeScmProvider.java
@@ -117,12 +117,6 @@ protected GitCommand getUpdateCommand()
 return new GitUpdateCommand();
 }
 
-/** {@inheritDoc} */
-protected GitCommand getListCommand()
-{
-return new GitListCommand();
-}
-
 /** {@inheritDoc} */
 public GitCommand getInfoCommand()
 {
diff --git 
a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/list/GitListCommand.java
 
b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/list/GitListCommand.java
index 27a90f84e..ffe573347 100644
--- 
a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/list/GitListCommand.java
+++ 
b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/list/GitListCommand.java
@@ -19,63 +19,18 @@
  * under the License.
  */
 
-import org.apache.maven.scm.ScmException;
-import org.apache.maven.scm.ScmFileSet;
-import org.apache.maven.scm.ScmFileStatus;
-import org.apache.maven.scm.ScmVersion;
-import org.apache.maven.scm.command.list.AbstractListCommand;
-import org.apache.maven.scm.command.list.ListScmResult;
-import 

[jira] [Commented] (SCM-869) gitexe list() implemented incorrectly

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459710#comment-16459710
 ] 

Michael Osipov commented on SCM-869:


Deployed a slighly improved test branch for. More tests pending.

> gitexe list() implemented incorrectly
> -
>
> Key: SCM-869
> URL: https://issues.apache.org/jira/browse/SCM-869
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5, 1.9.6
>Reporter: Ilya Basin
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.6
>
>
> Taking the Svn implementation as a model, ScmProvider.list() should be 
> implemented as follows:
>  * The command must directly query the remote repository for files
>  * A local working copy is unnecessary and if it doesn't exist, the remote 
> repository must not be checked out.
>  * fileSet.getBasedir() indicates where to run the scm binary. The 
> recommended value is ".".
>  * fileSet.getFileList() indicates the files to list
>  * repository indicates the repo URL
> Git (among other SCMs) does not support listing remote files, so the command 
> should just fail.
> For listing files in a working copy, users should call the 
> ScmProvider.status() method instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-869) gitexe list() implemented incorrectly

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459708#comment-16459708
 ] 

Michael Osipov commented on SCM-869:


If there is JIRA and PR for that, I'd be happy to pull that in.

> gitexe list() implemented incorrectly
> -
>
> Key: SCM-869
> URL: https://issues.apache.org/jira/browse/SCM-869
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5, 1.9.6
>Reporter: Ilya Basin
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.6
>
>
> Taking the Svn implementation as a model, ScmProvider.list() should be 
> implemented as follows:
>  * The command must directly query the remote repository for files
>  * A local working copy is unnecessary and if it doesn't exist, the remote 
> repository must not be checked out.
>  * fileSet.getBasedir() indicates where to run the scm binary. The 
> recommended value is ".".
>  * fileSet.getFileList() indicates the files to list
>  * repository indicates the repo URL
> Git (among other SCMs) does not support listing remote files, so the command 
> should just fail.
> For listing files in a working copy, users should call the 
> ScmProvider.status() method instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-869) gitexe list() implemented incorrectly

[Ilya Basin (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459705#comment-16459705
 ] 

Ilya Basin commented on SCM-869:


First of all, the JGit provider needs to be upgraded for the newer jgit, 
because the current version requires the git binary for some operations.

> gitexe list() implemented incorrectly
> -
>
> Key: SCM-869
> URL: https://issues.apache.org/jira/browse/SCM-869
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5, 1.9.6
>Reporter: Ilya Basin
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.6
>
>
> Taking the Svn implementation as a model, ScmProvider.list() should be 
> implemented as follows:
>  * The command must directly query the remote repository for files
>  * A local working copy is unnecessary and if it doesn't exist, the remote 
> repository must not be checked out.
>  * fileSet.getBasedir() indicates where to run the scm binary. The 
> recommended value is ".".
>  * fileSet.getFileList() indicates the files to list
>  * repository indicates the repo URL
> Git (among other SCMs) does not support listing remote files, so the command 
> should just fail.
> For listing files in a working copy, users should call the 
> ScmProvider.status() method instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-869) gitexe list() implemented incorrectly

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459667#comment-16459667
 ] 

Michael Osipov commented on SCM-869:


The JGit command needs update too.

> gitexe list() implemented incorrectly
> -
>
> Key: SCM-869
> URL: https://issues.apache.org/jira/browse/SCM-869
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5, 1.9.6
>Reporter: Ilya Basin
>Priority: Major
>
> Taking the Svn implementation as a model, ScmProvider.list() should be 
> implemented as follows:
>  * The command must directly query the remote repository for files
>  * A local working copy is unnecessary and if it doesn't exist, the remote 
> repository must not be checked out.
>  * fileSet.getBasedir() indicates where to run the scm binary. The 
> recommended value is ".".
>  * fileSet.getFileList() indicates the files to list
>  * repository indicates the repo URL
> Git (among other SCMs) does not support listing remote files, so the command 
> should just fail.
> For listing files in a working copy, users should call the 
> ScmProvider.status() method instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-869) gitexe list() implemented incorrectly

[Chris Graham (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443880#comment-16443880
 ] 

Chris Graham commented on SCM-869:
--

I just checked the Jazz provider I wrote (and I looked at most of the others to 
see what they were actually doing). The Jazz provider does a remote file list, 
which is what the docs wanted.

 

[https://www.ibm.com/support/knowledgecenter/SSYMRC_4.0.0/com.ibm.team.scm.doc/topics/list_remotefiles.html]

 

> gitexe list() implemented incorrectly
> -
>
> Key: SCM-869
> URL: https://issues.apache.org/jira/browse/SCM-869
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5, 1.9.6
>Reporter: Ilya Basin
>Priority: Major
>
> Taking the Svn implementation as a model, ScmProvider.list() should be 
> implemented as follows:
>  * The command must directly query the remote repository for files
>  * A local working copy is unnecessary and if it doesn't exist, the remote 
> repository must not be checked out.
>  * fileSet.getBasedir() indicates where to run the scm binary. The 
> recommended value is ".".
>  * fileSet.getFileList() indicates the files to list
>  * repository indicates the repo URL
> Git (among other SCMs) does not support listing remote files, so the command 
> should just fail.
> For listing files in a working copy, users should call the 
> ScmProvider.status() method instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-869) gitexe list() implemented incorrectly

[Ilya Basin (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433793#comment-16433793
 ] 

Ilya Basin commented on SCM-869:


I've updated the pull request to completely unimplement the list() method. Now 
the default implementation in AbstractScmProvider will throw 
NoSuchCommandScmException

> gitexe list() implemented incorrectly
> -
>
> Key: SCM-869
> URL: https://issues.apache.org/jira/browse/SCM-869
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5, 1.9.6
>Reporter: Ilya Basin
>Priority: Major
>
> Taking the Svn implementation as a model, ScmProvider.list() should be 
> implemented as follows:
>  * The command must directly query the remote repository for files
>  * A local working copy is unnecessary and if it doesn't exist, the remote 
> repository must not be checked out.
>  * fileSet.getBasedir() indicates where to run the scm binary. The 
> recommended value is ".".
>  * fileSet.getFileList() indicates the files to list
>  * repository indicates the repo URL
> Git (among other SCMs) does not support listing remote files, so the command 
> should just fail.
> For listing files in a working copy, users should call the 
> ScmProvider.status() method instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-869) gitexe list() implemented incorrectly

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419757#comment-16419757
 ] 

Michael Osipov commented on SCM-869:


The {{list}} function has been introduced with SCM-183 12 years ago with 
b158cf35d05271942a10bbef564366ab6a3059ad. I have checked few other providers. 
They have been incorrectly implemented also. The Git provider has been 
incorrectly implemented eversince with {{git ls-files}}.

I think this birth issue can only be properly resolved with 2.0.0.

Can you actually raise this general issue on the dev mailing list? I'd be 
interested in other devs opinion. I don't might incorrect code altogether or 
change the Javadoc if this is a better way.

> gitexe list() implemented incorrectly
> -
>
> Key: SCM-869
> URL: https://issues.apache.org/jira/browse/SCM-869
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5, 1.9.6
>Reporter: Ilya Basin
>Priority: Major
>
> Taking the Svn implementation as a model, ScmProvider.list() should be 
> implemented as follows:
>  * The command must directly query the remote repository for files
>  * A local working copy is unnecessary and if it doesn't exist, the remote 
> repository must not be checked out.
>  * fileSet.getBasedir() indicates where to run the scm binary. The 
> recommended value is ".".
>  * fileSet.getFileList() indicates the files to list
>  * repository indicates the repo URL
> Git (among other SCMs) does not support listing remote files, so the command 
> should just fail.
> For listing files in a working copy, users should call the 
> ScmProvider.status() method instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-869) gitexe list() implemented incorrectly

[Ilya Basin (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419730#comment-16419730
 ] 

Ilya Basin commented on SCM-869:


I checked the CVS provider. It uses the command "rls" (remote ls), which does 
what needed, but not widely supported. (IMO, it should parse the rlog response, 
although it's harder to parse). I have no experience in other SCMs.

> gitexe list() implemented incorrectly
> -
>
> Key: SCM-869
> URL: https://issues.apache.org/jira/browse/SCM-869
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5, 1.9.6
>Reporter: Ilya Basin
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Taking the Svn implementation as a model, ScmProvider.list() should be 
> implemented as follows:
>  * The command must directly query the remote repository for files
>  * A local working copy is unnecessary and if it doesn't exist, the remote 
> repository must not be checked out.
>  * fileSet.getBasedir() indicates where to run the scm binary. The 
> recommended value is ".".
>  * fileSet.getFileList() indicates the files to list
>  * repository indicates the repo URL
> Git (among other SCMs) does not support listing remote files, so the command 
> should just fail.
> For listing files in a working copy, users should call the 
> ScmProvider.status() method instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-869) gitexe list() implemented incorrectly

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419716#comment-16419716
 ] 

Michael Osipov commented on SCM-869:


Have you actually checked the remaining providers what they do?

> gitexe list() implemented incorrectly
> -
>
> Key: SCM-869
> URL: https://issues.apache.org/jira/browse/SCM-869
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5, 1.9.6
>Reporter: Ilya Basin
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Taking the Svn implementation as a model, ScmProvider.list() should be 
> implemented as follows:
>  * The command must directly query the remote repository for files
>  * A local working copy is unnecessary and if it doesn't exist, the remote 
> repository must not be checked out.
>  * fileSet.getBasedir() indicates where to run the scm binary. The 
> recommended value is ".".
>  * fileSet.getFileList() indicates the files to list
>  * repository indicates the repo URL
> Git (among other SCMs) does not support listing remote files, so the command 
> should just fail.
> For listing files in a working copy, users should call the 
> ScmProvider.status() method instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-869) gitexe list() implemented incorrectly

[Ilya Basin (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419703#comment-16419703
 ] 

Ilya Basin commented on SCM-869:


Maybe it should explicitly state "without checking it out".

> gitexe list() implemented incorrectly
> -
>
> Key: SCM-869
> URL: https://issues.apache.org/jira/browse/SCM-869
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5, 1.9.6
>Reporter: Ilya Basin
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Taking the Svn implementation as a model, ScmProvider.list() should be 
> implemented as follows:
>  * The command must directly query the remote repository for files
>  * A local working copy is unnecessary and if it doesn't exist, the remote 
> repository must not be checked out.
>  * fileSet.getBasedir() indicates where to run the scm binary. The 
> recommended value is ".".
>  * fileSet.getFileList() indicates the files to list
>  * repository indicates the repo URL
> Git (among other SCMs) does not support listing remote files, so the command 
> should just fail.
> For listing files in a working copy, users should call the 
> ScmProvider.status() method instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-869) gitexe list() implemented incorrectly

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419690#comment-16419690
 ] 

Michael Osipov commented on SCM-869:


What do you consider to be ambigious with "List contents of the remote 
repository"?

> gitexe list() implemented incorrectly
> -
>
> Key: SCM-869
> URL: https://issues.apache.org/jira/browse/SCM-869
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5, 1.9.6
>Reporter: Ilya Basin
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Taking the Svn implementation as a model, ScmProvider.list() should be 
> implemented as follows:
>  * The command must directly query the remote repository for files
>  * A local working copy is unnecessary and if it doesn't exist, the remote 
> repository must not be checked out.
>  * fileSet.getBasedir() indicates where to run the scm binary. The 
> recommended value is ".".
>  * fileSet.getFileList() indicates the files to list
>  * repository indicates the repo URL
> Git (among other SCMs) does not support listing remote files, so the command 
> should just fail.
> For listing files in a working copy, users should call the 
> ScmProvider.status() method instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-869) gitexe list() implemented incorrectly

[Ilya Basin (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419643#comment-16419643
 ] 

Ilya Basin commented on SCM-869:


[~michael-o] The javadocs are ambiguous, but Svn is the the most widely used 
Scm provider and I think other providers whould behave similarly.

> gitexe list() implemented incorrectly
> -
>
> Key: SCM-869
> URL: https://issues.apache.org/jira/browse/SCM-869
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5, 1.9.6
>Reporter: Ilya Basin
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Taking the Svn implementation as a model, ScmProvider.list() should be 
> implemented as follows:
>  * The command must directly query the remote repository for files
>  * A local working copy is unnecessary and if it doesn't exist, the remote 
> repository must not be checked out.
>  * fileSet.getBasedir() indicates where to run the scm binary. The 
> recommended value is ".".
>  * fileSet.getFileList() indicates the files to list
>  * repository indicates the repo URL
> Git (among other SCMs) does not support listing remote files, so the command 
> should just fail.
> For listing files in a working copy, users should call the 
> ScmProvider.status() method instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-869) gitexe list() implemented incorrectly

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419632#comment-16419632
 ] 

Michael Osipov commented on SCM-869:


Your fixed is based on the [API 
contract|https://github.com/apache/maven-scm/blob/master/maven-scm-api/src/main/java/org/apache/maven/scm/command/list/AbstractListCommand.java#L39],
 isn't it?

> gitexe list() implemented incorrectly
> -
>
> Key: SCM-869
> URL: https://issues.apache.org/jira/browse/SCM-869
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5, 1.9.6
>Reporter: Ilya Basin
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Taking the Svn implementation as a model, ScmProvider.list() should be 
> implemented as follows:
>  * The command must directly query the remote repository for files
>  * A local working copy is unnecessary and if it doesn't exist, the remote 
> repository must not be checked out.
>  * fileSet.getBasedir() indicates where to run the scm binary. The 
> recommended value is ".".
>  * fileSet.getFileList() indicates the files to list
>  * repository indicates the repo URL
> Git (among other SCMs) does not support listing remote files, so the command 
> should just fail.
> For listing files in a working copy, users should call the 
> ScmProvider.status() method instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-869) gitexe list() implemented incorrectly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372508#comment-16372508
 ] 

ASF GitHub Bot commented on SCM-869:


GitHub user basinilya opened a pull request:

https://github.com/apache/maven-scm/pull/67

[SCM-869] fix gitexe list() implemented incorrectly



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/basinilya/maven-scm SCM-869

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-scm/pull/67.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #67


commit c50c7755d68b8d9c7a4aa46296724969cf58fcf5
Author: Ilya Basin 
Date:   2018-02-22T07:10:20Z

[SCM-869] fix gitexe list() implemented incorrectly




> gitexe list() implemented incorrectly
> -
>
> Key: SCM-869
> URL: https://issues.apache.org/jira/browse/SCM-869
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5, 1.9.6
>Reporter: Ilya Basin
>Priority: Major
>
> Taking the Svn implementation as a model, ScmProvider.list() should be 
> implemented as follows:
>  * The command must directly query the remote repository for files
>  * A local working copy is unnecessary and if it doesn't exist, the remote 
> repository must not be checked out.
>  * fileSet.getBasedir() indicates where to run the scm binary. The 
> recommended value is ".".
>  * fileSet.getFileList() indicates the files to list
>  * repository indicates the repo URL
> Git (among other SCMs) does not support listing remote files, so the command 
> should just fail.
> For listing files in a working copy, users should call the 
> ScmProvider.status() method instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)