[jira] Commented: (MRELEASE-507) Execute tests before tagging
[ http://jira.codehaus.org/browse/MRELEASE-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=206948#action_206948 ] Paul Benedict commented on MRELEASE-507: The reason tests are re-run during perform is because it's part of the site building. Execute tests before tagging Key: MRELEASE-507 URL: http://jira.codehaus.org/browse/MRELEASE-507 Project: Maven 2.x Release Plugin Issue Type: Improvement Components: prepare Affects Versions: 2.0-beta-9 Reporter: Paul Benedict Preparing a release waits to execute tests until after the tag. If the tagging succeeds but the tests fail, the commit created a tag with failing tests, and the build fails altogether. I recommend the test phase should run before the tag... yes, in addition (or as a replacement) after the tagging phase. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-507) Execute tests before tagging
[ http://jira.codehaus.org/browse/MRELEASE-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=204518#action_204518 ] Paul Benedict commented on MRELEASE-507: I also do not like how the SCM information is not validated before tagging/branching. Couldn't this plugin invoke scm:validate automatically? Execute tests before tagging Key: MRELEASE-507 URL: http://jira.codehaus.org/browse/MRELEASE-507 Project: Maven 2.x Release Plugin Issue Type: Improvement Components: prepare Affects Versions: 2.0-beta-9 Reporter: Paul Benedict Preparing a release waits to execute tests until after the tag. If the tagging succeeds but the tests fail, the commit created a tag with failing tests, and the build fails altogether. I recommend the test phase should run before the tag... yes, in addition (or as a replacement) after the tagging phase. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-507) Execute tests before tagging
[ http://jira.codehaus.org/browse/MRELEASE-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=203746#action_203746 ] Dan Tran commented on MRELEASE-507: --- i am -1 on this since it makes the build to run run test twice. The worse case user can always revert the release after tag build fails the test. Execute tests before tagging Key: MRELEASE-507 URL: http://jira.codehaus.org/browse/MRELEASE-507 Project: Maven 2.x Release Plugin Issue Type: Improvement Components: prepare Affects Versions: 2.0-beta-9 Reporter: Paul Benedict Preparing a release waits to execute tests until after the tag. If the tagging succeeds but the tests fail, the commit created a tag with failing tests, and the build fails altogether. I recommend the test phase should run before the tag... yes, in addition (or as a replacement) after the tagging phase. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-507) Execute tests before tagging
[ http://jira.codehaus.org/browse/MRELEASE-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=203757#action_203757 ] Paul Benedict commented on MRELEASE-507: Dan, the worse case is too easily allowed. The tests don't have to be run twice; you could skip them second time around. Execute tests before tagging Key: MRELEASE-507 URL: http://jira.codehaus.org/browse/MRELEASE-507 Project: Maven 2.x Release Plugin Issue Type: Improvement Components: prepare Affects Versions: 2.0-beta-9 Reporter: Paul Benedict Preparing a release waits to execute tests until after the tag. If the tagging succeeds but the tests fail, the commit created a tag with failing tests, and the build fails altogether. I recommend the test phase should run before the tag... yes, in addition (or as a replacement) after the tagging phase. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-507) Execute tests before tagging
[ http://jira.codehaus.org/browse/MRELEASE-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=203760#action_203760 ] Dan Tran commented on MRELEASE-507: --- you are right there, we can configure release:perform to skip the test. However, running a long test before tag can be very long, i dont know what is impact when other people check into the release/branch/trunk while the test is going on. Also, since this change the behavior of plugin, it should be added as an option Execute tests before tagging Key: MRELEASE-507 URL: http://jira.codehaus.org/browse/MRELEASE-507 Project: Maven 2.x Release Plugin Issue Type: Improvement Components: prepare Affects Versions: 2.0-beta-9 Reporter: Paul Benedict Preparing a release waits to execute tests until after the tag. If the tagging succeeds but the tests fail, the commit created a tag with failing tests, and the build fails altogether. I recommend the test phase should run before the tag... yes, in addition (or as a replacement) after the tagging phase. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-507) Execute tests before tagging
[ http://jira.codehaus.org/browse/MRELEASE-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=203778#action_203778 ] Mark Struberg commented on MRELEASE-507: since when does the tests run _after_ the tagging? I remember they always got fired _before_! And I also see no reason why (in the mvn release:prepare stage) they should run after tagging. They will get fired on mvn release:perform anyway, and this has a very good reason. Execute tests before tagging Key: MRELEASE-507 URL: http://jira.codehaus.org/browse/MRELEASE-507 Project: Maven 2.x Release Plugin Issue Type: Improvement Components: prepare Affects Versions: 2.0-beta-9 Reporter: Paul Benedict Preparing a release waits to execute tests until after the tag. If the tagging succeeds but the tests fail, the commit created a tag with failing tests, and the build fails altogether. I recommend the test phase should run before the tag... yes, in addition (or as a replacement) after the tagging phase. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
