[GitHub] [maven] michael-o commented on issue #274: [MNG-6716] Test and fix erroneous compileRoots
michael-o commented on issue #274: [MNG-6716] Test and fix erroneous compileRoots URL: https://github.com/apache/maven/pull/274#issuecomment-522431043 @hboutemy, let's go for it! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] michael-o commented on issue #274: [MNG-6716] Test and fix erroneous compileRoots
michael-o commented on issue #274: [MNG-6716] Test and fix erroneous compileRoots URL: https://github.com/apache/maven/pull/274#issuecomment-522334667 @hboutemy, I trust your judgement. If you bless, I'll do it too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] michael-o commented on issue #274: [MNG-6716] Test and fix erroneous compileRoots
michael-o commented on issue #274: [MNG-6716] Test and fix erroneous compileRoots URL: https://github.com/apache/maven/pull/274#issuecomment-517942206 So all ITs have passed on Jenkins. @mickaelistria Would you be so kind and test this out with the sample project of the reporter since he's offline for some while. If all is well, I will merge. If @rfscholte does not mind. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] michael-o commented on issue #274: [MNG-6716] Test and fix erroneous compileRoots
michael-o commented on issue #274: [MNG-6716] Test and fix erroneous compileRoots URL: https://github.com/apache/maven/pull/274#issuecomment-517906095 It passes locally for me, but does not show up on Jekins. Any idea? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] michael-o commented on issue #274: [MNG-6716] Test and fix erroneous compileRoots
michael-o commented on issue #274: [MNG-6716] Test and fix erroneous compileRoots URL: https://github.com/apache/maven/pull/274#issuecomment-517844055 ITs are running... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] michael-o commented on issue #274: [MNG-6716] Test and fix erroneous compileRoots
michael-o commented on issue #274: [MNG-6716] Test and fix erroneous compileRoots URL: https://github.com/apache/maven/pull/274#issuecomment-517840719 OK, I will push a branch and we'll see how far we get. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] michael-o commented on issue #274: [MNG-6716] Test and fix erroneous compileRoots
michael-o commented on issue #274: [MNG-6716] Test and fix erroneous compileRoots URL: https://github.com/apache/maven/pull/274#issuecomment-517681685 @rfscholte Can you drop some lines? I guess don't know that part of code to apply proper judgement here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] michael-o commented on issue #274: [MNG-6716] Test and fix erroneous compileRoots
michael-o commented on issue #274: [MNG-6716] Test and fix erroneous compileRoots URL: https://github.com/apache/maven/pull/274#issuecomment-517417754 I am trying to understand the fix, but I don't. Although if I look at the bug report the OP add the same path twice in different representations. How does this fix address this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
