kbuntrock commented on PR #91:
URL:
https://github.com/apache/maven-build-cache-extension/pull/91#issuecomment-1739027006
About this PR, I'm still working on it. Even if I couldn't find the time the
last past weeks.
I re-put it in draft @maximilian-novikov-db et @AlexanderAshitkin, I
kbuntrock commented on PR #91:
URL:
https://github.com/apache/maven-build-cache-extension/pull/91#issuecomment-1695606322
> I'm starting to wonder if the use of the JDK `PathMatcher` is sufficient
here. If we want to optimize the file system access and not traverse _all_
files /
kbuntrock commented on PR #91:
URL:
https://github.com/apache/maven-build-cache-extension/pull/91#issuecomment-1690697801
> @kbuntrock nicely done, it would be useful to update the sample config as
well
kbuntrock commented on PR #91:
URL:
https://github.com/apache/maven-build-cache-extension/pull/91#issuecomment-1668279033
Changed the exclude mechanism to use path matchers. A bit more than a bugfix
now, feedbacks appreciated if you see any lack, implementation detail you
disagree with or
kbuntrock commented on PR #91:
URL:
https://github.com/apache/maven-build-cache-extension/pull/91#issuecomment-1665985477
> I'm a bit skeptical about the way which has been chosen to filter files. I
think it would be more intuitive to use a glob `PathMatcher` rather than a
`startsWith()`
kbuntrock commented on PR #91:
URL:
https://github.com/apache/maven-build-cache-extension/pull/91#issuecomment-1664633394
Miss-clicked on the sync button on my repo for this branch (I only wanted to
sync master ...).
So I finished to rebase it on master to keep the tree clean. But it
