[GitHub] [maven-filtering] slachiewicz commented on pull request #14: declare dependencies

2021-01-25 Thread GitBox
slachiewicz commented on pull request #14: URL: https://github.com/apache/maven-filtering/pull/14#issuecomment-766429749 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [maven-filtering] slachiewicz commented on pull request #14: declare dependencies

2021-01-25 Thread GitBox
slachiewicz commented on pull request #14: URL: https://github.com/apache/maven-filtering/pull/14#issuecomment-766874181 real case: https://github.com/GoogleCloudPlatform/cloud-opensource-java/issues/1091 This is an

[GitHub] [maven-filtering] slachiewicz commented on pull request #14: declare dependencies

2021-01-25 Thread GitBox
slachiewicz commented on pull request #14: URL: https://github.com/apache/maven-filtering/pull/14#issuecomment-766872291 With each minimum Maven upgrade, someone needs to review all deps and update the version of aether to match with that will be delivered by Maven installation. No older,

[GitHub] [maven-filtering] slachiewicz commented on pull request #14: declare dependencies

2021-01-25 Thread GitBox
slachiewicz commented on pull request #14: URL: https://github.com/apache/maven-filtering/pull/14#issuecomment-766870955 ``` [INFO] --- maven-dependency-plugin:3.1.1:analyze (default-cli) @ maven-filtering --- [WARNING] Used undeclared dependencies found: [WARNING]

[GitHub] [maven-filtering] slachiewicz commented on pull request #14: declare dependencies

2021-01-25 Thread GitBox
slachiewicz commented on pull request #14: URL: https://github.com/apache/maven-filtering/pull/14#issuecomment-766868911 thx @dennisl - would you be able to sync the maven version to 3.1.1 as try to confirm that this proposed approach works?

[GitHub] [maven-filtering] slachiewicz commented on pull request #14: declare dependencies

2021-01-24 Thread GitBox
slachiewicz commented on pull request #14: URL: https://github.com/apache/maven-filtering/pull/14#issuecomment-766429749 Any reason why we need to declare these dependencies? org.eclipse.sisu.plexus is a transitive dependency from maven plugin API and with each update to minimum