[GitHub] [maven-surefire] Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers
Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers URL: https://github.com/apache/maven-surefire/pull/257#issuecomment-578341085 Closed in favor of #267 . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers
Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers URL: https://github.com/apache/maven-surefire/pull/257#issuecomment-560183773 @t-8ch Do you have time for this? How are you doing with the tests? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers
Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers URL: https://github.com/apache/maven-surefire/pull/257#issuecomment-559434517 @t-8ch no no, it is a class with `@BeforeAll`. Feel free to add a test in this PR. I will open new PR for the second distinct issue because i think these are two different. Additionally, I tried to avoid `if ( isClass || isTest )` successfully and the tests `JUnitPlatformProviderTest` pass successfully but three tests failed in `RunListenerAdapterTest` because the tests missed the `Type` but that's the third distinct PR to open. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers
Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers URL: https://github.com/apache/maven-surefire/pull/257#issuecomment-559317708 @t-8ch We have a similar issue [SUREFIRE-1688](https://issues.apache.org/jira/browse/SUREFIRE-1688) which happens when the method annotated by `@BeforeAll` throws an exception. It is similar to this issue but it is not identical. You can leave your comment, maybe you have opinion about the change needed. It looks simple. IMO the fix should be placed at the [line](https://github.com/apache/maven-surefire/blob/master/surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java#L121) so I would like to work on it and satisfy given unit test in the pullrequest #255 . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers
Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers URL: https://github.com/apache/maven-surefire/pull/257#issuecomment-559186761 no problem. Question: this change you have made includes also the name of method too? So when I see the native report in your JIRA description of the issue there is also the method. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers
Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers URL: https://github.com/apache/maven-surefire/pull/257#issuecomment-559184403 Maybe keep this PR for the future motivation in SUREFIRE-1724 and open a new one PR for SUREFIRE-1727. oki? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers
Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers URL: https://github.com/apache/maven-surefire/pull/257#issuecomment-559183371 @t-8ch I want to make sure that we are on the same line. Is Cucumber exotic engine for you? If it is then we can make a workaround here and then a godd and complex fix in SUREFIRE-1724. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers
Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers URL: https://github.com/apache/maven-surefire/pull/257#issuecomment-559181429 Now i know what you mean but this is the same in JUnit4. It works there. Suppose that the Runner of JUnit4 fails and the test constructor fails too. See the JUnit4Provider, there we fire an event with the only testFailed with class anme but no method name. I think this would be the way. Maybe not nice but having the unit tests will guide us to make it better in SUREFIRE-1724. My guess with the workflow. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers
Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers URL: https://github.com/apache/maven-surefire/pull/257#issuecomment-559179089 @t-8ch but your requirement to support all engines is covered already in https://issues.apache.org/jira/browse/SUREFIRE-1724 I thought that you want to fix only `Failures during test template creation are ignored` as it is in JIRA. So now i do not know why we have another title in this PR with same Jira ID. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
