[GitHub] [maven-wagon] zymzxq commented on issue #57: WAGON-567: support retry on server side errors

2019-10-23 Thread GitBox
zymzxq commented on issue #57: WAGON-567: support retry on server side errors
URL: https://github.com/apache/maven-wagon/pull/57#issuecomment-545671840
 
 
   Note: in httpclient5 
[DefaultServiceUnavailableRetryStrategy](https://github.com/apache/httpcomponents-client/blob/master/httpclient5/src/main/java/org/apache/hc/client5/http/impl/DefaultServiceUnavailableRetryStrategy.java#L84)
 respects retryAfter response header before falling back to default interval. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-wagon] zymzxq commented on issue #57: WAGON-567: support retry on server side errors

2019-10-21 Thread GitBox
zymzxq commented on issue #57: WAGON-567: support retry on server side errors
URL: https://github.com/apache/maven-wagon/pull/57#issuecomment-544781344
 
 
   I like the progressive approach that Colin suggested.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-wagon] zymzxq commented on issue #57: WAGON-567: support retry on server side errors

2019-10-16 Thread GitBox
zymzxq commented on issue #57: WAGON-567: support retry on server side errors
URL: https://github.com/apache/maven-wagon/pull/57#issuecomment-542952547
 
 
   Agree >=500 is too coarse grained. I'd also like to check 500 and 502 as 
well. AWS s3, which we redirect our maven download requests to,  returns 500 
when it has problems and expects client to retry. We also experienced s3 
returned 502 when it had issues. AWS document: 
https://stash.atlassian.com/projects/BUILDENG/repos/buildeng-plan-templates/pull-requests/1024/overview
   
   Happy to remove the non standard 420 check.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services