[GitHub] khmarbaise commented on issue #45: [MENFORCER-319] Handle UTF-8 BOM when parsing pom.xml files

2019-01-27 Thread GitBox
khmarbaise commented on issue #45: [MENFORCER-319] Handle UTF-8 BOM when parsing pom.xml files URL: https://github.com/apache/maven-enforcer/pull/45#issuecomment-457910280 From my point of view looks fine now. This is an

[GitHub] khmarbaise commented on issue #45: [MENFORCER-319] Handle UTF-8 BOM when parsing pom.xml files

2018-11-14 Thread GitBox
khmarbaise commented on issue #45: [MENFORCER-319] Handle UTF-8 BOM when parsing pom.xml files URL: https://github.com/apache/maven-enforcer/pull/45#issuecomment-438667508 Please don't change existing tests...please add a new one!

[GitHub] khmarbaise commented on issue #45: [MENFORCER-319] Handle UTF-8 BOM when parsing pom.xml files

2018-11-13 Thread GitBox
khmarbaise commented on issue #45: [MENFORCER-319] Handle UTF-8 BOM when parsing pom.xml files URL: https://github.com/apache/maven-enforcer/pull/45#issuecomment-438485075 The patch looks good so far but unfortunately I don't see a test case for that..