Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
The path:
```
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
Now there is only one issue to fix related to Windows paths.
Need to investigate.
https://builds.apache.org/job/maven-surefire-pipeline/job/SUREFIRE-1463/121
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
The project has new build script and testing JDK 7-10 in combination of
multiple platforms. That is the main purpose of Version 2.21.0. Sorry that
it takes so long. We are discovering
Github user hemachandraraok commented on the issue:
https://github.com/apache/maven-surefire/pull/150
Sure and let me wait!
Thank you so much for the updates!!!Cheers!
---
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
In that case yes, you only need to wait for the release of surefire.
https://github.com/cucumber/cucumber-jvm/issues/1120 was fixed by
https://github.com/cucumber/cucumber-jvm/pull/1134
Github user hemachandraraok commented on the issue:
https://github.com/apache/maven-surefire/pull/150
Sorry for not giving enough information. the full track trace is here
org.apache.maven.surefire.testset.TestSetFailedException: Unable to create
testclass 'rerun_test'
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
Bit hard to say without the full stack trace, components and version
numbers involved.
To fix this bug I also had to fix cucumber to ensure that the it provided
the proper ids
Github user hemachandraraok commented on the issue:
https://github.com/apache/maven-surefire/pull/150
Hi Guys,
Thanks for helping us by contributing to the open source community...
I am using surefire 2.20.1 and getting the same exception
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
You're welcome!
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@mpkorstanje
Thx for contributing.
---
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
Merged in 0a81c48971e3ee4b79b0858be7b8f4b13ece7287.
---
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
> The build passed successfully. I will refactor little details, I will
squash our commits and then I will push it to master.
Cheers.
> I could not find a documentation
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@mpkorstanje
The build passed successfully. I will refactor little details, I will
squash our commits and then I will push it to master.
I could not find a documentation for
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@Tibor17
`MatchDescriptions` uses `Filter.matchMethodDescription` which does not
exist in junit4. It would make the junit 4 version of `MatchDescriptions`
divergent enough to
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
The fast way would be to give it a try in a copy of your project apart and
run the local build
"mvn install -P run-its -Dcheckstyle.skip=true".
Even if you copied FilterFactory
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
> Can you write the documentation?
Done.
>Fix the checkstyle in your integration test and the classes
FlakeCucumberTest.
I seem to be unable to get checkstyle to
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@Tibor17 that should be doable. Replacing the inner most loop in the
`JUnit4Provider.executeWithRerun` with the code below should do it. This would
require the `FilterFactory` to be
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@mpkorstanje
After seen the code of junit4 provider I have realized that `Filter` also
exists in JUnit4. Therefore maybe using a combination of class/method and using
JUnit's Request
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
> Then try to alter the behavior of the integration test with Maven profile
(junit4 and junit47). We are already doing it, see addGoal( "-P junit4" ),
addGoal( "-P junit47" ).
>
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
Not at this moment. Perhaps the weekend.
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@mpkorstanje
Can we continue? Do you have spare time?
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@mpkorstanje
I saw you typed version `2.21`. It should be `2.21.0`. Pls fix this as
well. Thx.
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@mpkorstanje
Now I understand the Cucumber internals.
Can you write the documentation?
Fix the checkstyle in your integration test and the classes
`FlakeCucumberTest`.
Then
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@mpkorstanje
I do not have questions yet. I am just reading your comments. I would think
of the code combining together with Cucumber internals and then I would have
maybe some notice.
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@Tibor17 please let me know if you have more questions.
---
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
I haven't answered yet is why cucumber creates descriptions with a unique
Id and doesn't just use the method names.
The reason for that is that scenarios in cucumber don't need
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
> Additionally, can you write a separate documentation file cucumber.apt.vm
for Cucumber with your best practices to setup and use cucumber in terms of
maven-surefire-plugin and
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
> Why you have chosen provider surefire-junit47 and not also the
surefire-junit4?
While it would be possible to change surefire-junit4 to filter by
description there is no need
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
> How is Description constructed now by Cucumber?
Executing cucumber while using JUnit creates a tree of Descriptions like so:
```
Cucumber
|- Feature 1
|
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@mpkorstanje
I want to ask you few question because I want to make minimum invasive
changes in the code.
Why you have chosen provider `surefire-junit47` and not also the
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@mpkorstanje
Additionally, can you write a separate documentation file `cucumber.apt.vm`
for Cucumber with your best practices to setup and use cucumber in terms of
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@mpkorstanje
How is `Description` constructed now by Cucumber?
Does it contain the real method name or it is a scenario text?
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
As far as I remember the filter was used in rerun feature where broken
tests were executed several more times after.
Yet let me check your branch because that's better than if you
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@Tibor17 It appears this branch is still up to date with master.
Is the removal of the class the problem or the underlying fundamentals? If
it is just the removal I can restore
Github user naveedriay commented on the issue:
https://github.com/apache/maven-surefire/pull/150
Is it possible to ask the original developer (@mpkorstanje ) to look at
this deleted file changes as it might help get it through quickly. I suppose
quite a number of people are waiting
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@mpkorstanje
@ckurban
@sworisbreathing
I could not merge and release this PR because the class
`FailingMethodFilter.java` in [1] was deleted.
We have to have it back and
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@sworisbreathing
Let me go through these changes again.
---
Github user sworisbreathing commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@Tibor17 have there been any updates for this? I'm pretty keen to start
using the new version if it fixes support for Cucumber tests with
`rerunFailingTestCount` in
38 matches
Mail list logo
