[GitHub] maven-surefire issue #174: https://issues.apache.org/jira/browse/SUREFIRE-14...

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/174
  
@awallgren 
You can close this PR. There is already a branch with dedicated fix:

https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=shortlog;h=refs/heads/SUREFIRE-1475
Thx for contributing!


---

[GitHub] maven-surefire issue #174: https://issues.apache.org/jira/browse/SUREFIRE-14...

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/174
  
@awallgren 
Are you here?


---

[GitHub] maven-surefire issue #174: https://issues.apache.org/jira/browse/SUREFIRE-14...

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/174
  
Of course you should push only single commit in PR.
`git commit --amend`
and the title must be 
`[SUREFIRE-1475] ...here is title as in Jira...`


---

[GitHub] maven-surefire issue #174: https://issues.apache.org/jira/browse/SUREFIRE-14...

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/174
  
First of all do it similar like we do in *NIX.
Resolve `%SystemRoot%\System32\Wbem\wmic.exe` in Java and check that the 
file exists.
If it exists use it, otherwise do it as we did before.


---

[GitHub] maven-surefire issue #174: https://issues.apache.org/jira/browse/SUREFIRE-14...

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/174
  
Logging errors can be added to the dump file, but right now please add the 
Microsoft link, as you said 'yes'.


---

[GitHub] maven-surefire issue #174: https://issues.apache.org/jira/browse/SUREFIRE-14...

[awallgren]

Github user awallgren commented on the issue:

https://github.com/apache/maven-surefire/pull/174
  
And certainly more correct than whatever random wmic.exe is on the path, if
any. Also, it would be great if errors from the ping invocation weren't
suppressed as thoroughly as they currently are.


On Fri, Feb 9, 2018 at 22:59 Anders Wallgren 
wrote:

> Yes and yes.
> On Fri, Feb 9, 2018 at 19:22 Tibor Digana 
> wrote:
>
>> Did we take right path here as well? Did Microsoft mention this link in
>> their documentation?
>>
>> —
>> You are receiving this because you authored the thread.
>> Reply to this email directly, view it on GitHub
>> 
,
>> or mute the thread
>> 

>> .
>>
> --
> anders
>
-- 
anders



---

[GitHub] maven-surefire issue #174: https://issues.apache.org/jira/browse/SUREFIRE-14...

[awallgren]

Github user awallgren commented on the issue:

https://github.com/apache/maven-surefire/pull/174
  
Yes and yes.
On Fri, Feb 9, 2018 at 19:22 Tibor Digana  wrote:

> Did we take right path here as well? Did Microsoft mention this link in
> their documentation?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> 
,
> or mute the thread
> 

> .
>
-- 
anders



---

[GitHub] maven-surefire issue #174: https://issues.apache.org/jira/browse/SUREFIRE-14...

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/174
  
Did we take right path here as well? Did Microsoft mention this link in 
their documentation?


---