[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-12 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-388533450 Restarting the build didn't help... This is an

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-11 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-388529278 What happend on the [`linux-jdk7-maven3.5.x`](https://builds.apache.org/job/maven-box/job/maven-surefire/job/1330/)

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-11 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-388527807 No, didn't do it yet. Just wanted get the changes I made on gitbox-1330 to show up here as "Polishing". Will reset

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-11 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-388527807 No, didn't do it yet. Just wanted get the changes I made on bitbox-1330 to show up here as "Polishing". Will reset

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-10 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-388186209 Rebased onto https://github.com/apache/maven-surefire/commits/master and merged gitbox-1330 changes.

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-08 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-387449015 I may look into the JDK 11 issues later... but as it is still early-access state, we and other tools have some

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-06 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386862997 > [...] JUnit5 should guarantee backwards compatibility of platform engine for long time. That's exactly the

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-06 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386861135 > I think it will work even without is( greaterThanOrEqualTo( "1.8" ) ). Okay. Removed the `setUp` method.

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-06 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386859383 > Did you also have a problem with JaCoCO:0.7.9 on JDK10? According to

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-05 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386828650 JDK 10 seems okay now. JDK 7 still chokes on "--target 1.8" options...

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-05 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386828650 JDK 10 seems okay now. JDK 7 still chokes on "--target 1.8" options...

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-05 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386827017 Why are they banned? [linux-jdk10-maven3.5.x] Found Banned Dependency:

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-05 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386825239 > ... You have to squash all commits ... Losing history and reasoning is okay? Done.

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-05 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386825239 > ... You have to squash all commits ... Losing history and reasoning is okay?

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-05 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386799705 I think, we may get rid of integration test class `JUnit5IT` as it refers to the soon deprecated

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-05 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386793374 Make it three commits.  This is an automated

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-04 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386728323 @Tibor17 Can you please integrate the last two commits as well? The build was successful on my machine and before I

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-04 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386521173 Working-around it for now by ``` [...] org.junit.platform.commons.* ```

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-04 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386519453 Nice. But `animal-sniffer-maven-plugin` still fails either by not finding a bunch of methods, like: ```

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-04 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386519453 Nice. But `animal-sniffer-maven-plugin` still fails either by not finding a bunch of methods, like: ```

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-03 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386411693 Sure. Go ahead. I am still waiting for the ASF git permissions.