[jira] [Comment Edited] (MNG-6415) Project Artifacts Cache does not retain the order of classpath entries.
[ https://issues.apache.org/jira/browse/MNG-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487829#comment-16487829 ] Michael Osipov edited comment on MNG-6415 at 5/23/18 6:44 PM: -- I am fine when this fix is accompanied by a documentation update + an IT. was (Author: michael-o): I am fine when this fix is accompanied by a documentation update. > Project Artifacts Cache does not retain the order of classpath entries. > --- > > Key: MNG-6415 > URL: https://issues.apache.org/jira/browse/MNG-6415 > Project: Maven > Issue Type: Bug > Components: core >Affects Versions: 3.5.2 > Environment: Windows 7, JDK8u144 >Reporter: Seckin Onur SELAMET >Priority: Major > Labels: CLASSPATH > Attachments: > [MNG-6415]_Fixes_Project_Artifact_Cache_classpath_order_retaining_issue_.patch > > > Project artifacts cache does not retain the order of classpath entries. > Wrong Object type used in implementation. HashSet can not guarantee the order > of elements. > In runtime ProjectArtifacts passed as LinkedHashSet already which is safe. > > Possible fix is provided in comments section. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (MNG-6415) Project Artifacts Cache does not retain the order of classpath entries.
[
https://issues.apache.org/jira/browse/MNG-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486809#comment-16486809
]
Rene Vrijsen edited comment on MNG-6415 at 5/23/18 8:48 AM:
{quote}Can you provide a minimal project depicting your issue?
{quote}
See: MDEP-609
(Seckin Onur, Ahmed and myself work on this same problem for our company :))
was (Author: devrem):
{quote}Can you provide a minimal project depicting your issue?
{quote}
See: MDEP-609
> Project Artifacts Cache does not retain the order of classpath entries.
> ---
>
> Key: MNG-6415
> URL: https://issues.apache.org/jira/browse/MNG-6415
> Project: Maven
> Issue Type: Bug
> Components: core
>Affects Versions: 3.5.2
> Environment: Windows 7, JDK8u144
>Reporter: Seckin Onur SELAMET
>Priority: Major
> Labels: CLASSPATH
> Attachments:
> [MNG-6415]_Fixes_Project_Artifact_Cache_classpath_order_retaining_issue_.patch
>
>
> Project artifacts cache does not retain the order of classpath entries.
> Wrong Object type used in implementation. HashSet can not guarantee the order
> of elements.
> In runtime ProjectArtifacts passed as LinkedHashSet already which is safe.
>
> Possible fix is provided in comments section.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (MNG-6415) Project Artifacts Cache does not retain the order of classpath entries.
[ https://issues.apache.org/jira/browse/MNG-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484574#comment-16484574 ] Michael Osipov edited comment on MNG-6415 at 5/22/18 9:08 PM: -- Java makes not guarantees in which order JARs are loaded, especially when you are using wildcard classpaths. Never rely on the order. If you rely on, you seriously have a linkage error in your application. Can you provide a minimal project depicting your issue? was (Author: michael-o): Java makes not guarantees in which order JARs are loaded, especially when you are using wildcard classpaths. Never rely on the order. If you rely on, you seriously have a linkage error in your application. > Project Artifacts Cache does not retain the order of classpath entries. > --- > > Key: MNG-6415 > URL: https://issues.apache.org/jira/browse/MNG-6415 > Project: Maven > Issue Type: Bug > Components: core >Affects Versions: 3.5.2 > Environment: Windows 7, JDK8u144 >Reporter: Seckin Onur SELAMET >Priority: Major > Labels: CLASSPATH > Attachments: > [MNG-6415]_Fixes_Project_Artifact_Cache_classpath_order_retaining_issue_.patch > > > Project artifacts cache does not retain the order of classpath entries. > Wrong Object type used in implementation. HashSet can not guarantee the order > of elements. > In runtime ProjectArtifacts passed as LinkedHashSet already which is safe. > > Possible fix is provided in comments section. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (MNG-6415) Project Artifacts Cache does not retain the order of classpath entries.
[
https://issues.apache.org/jira/browse/MNG-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483775#comment-16483775
]
Seckin Onur SELAMET edited comment on MNG-6415 at 5/22/18 1:13 PM:
---
Rev no : be223808939d75152d7157db33d45f230114555e
Class : DefaultProjectArtifactsCache
Line : 208
{color:#ff}_new CacheRecord( Collections.unmodifiableSet( new HashSet<>(
projectArtifacts ) ) );_{color}
Must be implemented as:
new CacheRecord( Collections.unmodifiableSet( new LinkedHashSet<>(
projectArtifacts ) ) );
Patch is also available in attachments.
was (Author: soselamet):
Rev no : be223808939d75152d7157db33d45f230114555e
Line : 208
{color:#FF}_new CacheRecord( Collections.unmodifiableSet( new HashSet<>(
projectArtifacts ) ) );_{color}
Must be implemented as:
new CacheRecord( Collections.unmodifiableSet( new LinkedHashSet<>(
projectArtifacts ) ) );
> Project Artifacts Cache does not retain the order of classpath entries.
> ---
>
> Key: MNG-6415
> URL: https://issues.apache.org/jira/browse/MNG-6415
> Project: Maven
> Issue Type: Bug
> Components: core
>Affects Versions: 3.5.2
> Environment: Windows 7, JDK8u144
>Reporter: Seckin Onur SELAMET
>Priority: Major
> Labels: CLASSPATH
> Attachments:
> [MNG-6415]_Fixes_Project_Artifact_Cache_classpath_order_retaining_issue_.patch
>
>
> Project artifact cache introduced does not retain the order of classpath
> entries.
> Wrong Object type used in implementation. HashSet can not guarantee the order
> of elements contained.
> In runtime ProjectArtifacts passed as LinkedHashSet already which is safe.
>
> Possible fix is provided in comments section.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
