[jira] [Comment Edited] (MNG-6795) define a replacement for ReasonPhrase to display details about transfert failures

2021-02-15 Thread Daniel Compton (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17284993#comment-17284993
 ] 

Daniel Compton edited comment on MNG-6795 at 2/16/21, 1:31 AM:
---

I'm also a maintainer of clojars.org and separately run 
[Deps|https://www.deps.co], a private Maven repository service. I use the 
reason phrase to help users debug errors more clearly with Deps.

I fully agree that using the HTTP reason phrase to pass this information was a 
gigantic hack. If it was being proposed today as a new feature, I would vote 
against it given that it has been removed in HTTP/2 and was never intended for 
this use. However, it's a vital feature used by many public and private Maven 
repository managers to help users and customers debug problems.

bq. Another problem is that Wagon is protocol agnostic, this means that even if 
we add those information to Wagon exceptions, it remains unused for other Wagon 
implementations except HTTP.

I can see that this is not ideal, but it's also the current situation that 
we're in. I would guess that the majority of Maven users are using HTTP Wagons, 
and the overwhelming majority of errors occurring using Maven would happen with 
an HTTP Wagon.

I don't have any terribly strong feelings about the exact implementation 
details, I'm happy to update my code to use whatever is the new format.


was (Author: danielcompton):
I'm also a maintainer of clojars.org and separately run 
[Deps|https://www.deps.co], a private Maven repository service. I use the 
reason phrase to help users debug errors more clearly with Deps.

I fully agree that using the HTTP reason phrase to pass this information was a 
gigantic hack. If it was being proposed today as a new feature, I would vote 
against it given that it has been removed in HTTP/2 and was never intended for 
this use. However, it's a vital feature used by many public and private Maven 
repository managers to help users and customers debug problems.

> Another problem is that Wagon is protocol agnostic, this means that even if 
> we add those information to Wagon exceptions, it remains unused for other 
> Wagon implementations except HTTP.

I can see that this is not ideal, but it's also the current situation that 
we're in. I would guess that the majority of Maven users are using HTTP Wagons, 
and the overwhelming majority of errors occurring using Maven would happen with 
an HTTP Wagon.

I don't have any terribly strong feelings about the exact implementation 
details, I'm happy to update my code to use whatever is the new format.

> define a replacement for ReasonPhrase to display details about transfert 
> failures
> -
>
> Key: MNG-6795
> URL: https://issues.apache.org/jira/browse/MNG-6795
> Project: Maven
>  Issue Type: Task
>  Components: Artifacts and Repositories
>Affects Versions: 3.3.9, 3.6.3
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> as documented in WAGON-541 
> [372aa52c80c2f7b458c095d837e15ebeafbdf0b7|https://gitbox.apache.org/repos/asf?p=maven-wagon.git&a=commit&h=372aa52c80c2f7b458c095d837e15ebeafbdf0b7],
>  ReasonPhrase has been removed from HTTP/2 and deprecated (optional) in 
> HTTP/1.1 for more than five years. It is useful to give detailed error 
> messages on artifact transfert errors with a repository manager.
> A replacement has to be found



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (MNG-6795) define a replacement for ReasonPhrase to display details about transfert failures

2021-02-07 Thread Tobias Crawley (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280595#comment-17280595
 ] 

Tobias Crawley edited comment on MNG-6795 at 2/7/21, 3:50 PM:
--

I am one of the maintainers of [clojars.org|https://clojars.org], a repository 
of OSS libraries for the Clojure community. We currently use ReasonPhrase to 
return additional context with failed deployments that are intended to be read 
by the user and not parsed programmatically. We currently use [a deprecated 
method in 
Jetty|https://www.eclipse.org/jetty/javadoc/jetty-11/org/eclipse/jetty/server/Response.html#setStatus(int,java.lang.String)]
 to set it. I would much prefer another way to provide this context; a header 
that is treated as a plaintext string and displayed by the wagon in place of 
ReasonPhrase would work well for us.


was (Author: tcrawley):
I am one of the maintainers of clojars.org, a repository of OSS libraries for 
the Clojure community. We currently use ReasonPhrase to return additional 
context with failed deployments that are intended to be read by the user and 
not parsed programmatically. We currently use [a deprecated method in 
Jetty|https://www.eclipse.org/jetty/javadoc/jetty-11/org/eclipse/jetty/server/Response.html#setStatus(int,java.lang.String)]
 to set it. I would much prefer another way to provide this context; a header 
that is treated as a plaintext string and displayed by the wagon in place of 
ReasonPhrase would work well for us.

> define a replacement for ReasonPhrase to display details about transfert 
> failures
> -
>
> Key: MNG-6795
> URL: https://issues.apache.org/jira/browse/MNG-6795
> Project: Maven
>  Issue Type: Task
>  Components: Artifacts and Repositories
>Affects Versions: 3.3.9, 3.6.3
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> as documented in WAGON-541 
> [372aa52c80c2f7b458c095d837e15ebeafbdf0b7|https://gitbox.apache.org/repos/asf?p=maven-wagon.git&a=commit&h=372aa52c80c2f7b458c095d837e15ebeafbdf0b7],
>  ReasonPhrase has been removed from HTTP/2 and deprecated (optional) in 
> HTTP/1.1 for more than five years. It is useful to give detailed error 
> messages on artifact transfert errors with a repository manager.
> A replacement has to be found



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (MNG-6795) define a replacement for ReasonPhrase to display details about transfert failures

2019-10-27 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960679#comment-16960679
 ] 

Michael Osipov edited comment on MNG-6795 at 10/27/19 8:41 PM:
---

It is also to mention that only a few servers allow to set the reason phrase. 
Tomcat never supported it. Other likely neither. See also [Undertow's 
documentation on 
it|http://undertow.io/javadoc/1.3.x/io/undertow/server/HttpServerExchange.html#setReasonPhrase-java.lang.String-].
 I think the resolution of WAGON-541 is just wrong.


was (Author: michael-o):
It is also to mention that only a few servers allow to set the reason phrase. 
Tomcat never supported it. Other likely neither. See also [Undertow's 
documentation on 
it](http://undertow.io/javadoc/1.3.x/io/undertow/server/HttpServerExchange.html#setReasonPhrase-java.lang.String-).
 I think the resolution of WAGON-541 is just wrong.

> define a replacement for ReasonPhrase to display details about transfert 
> failures
> -
>
> Key: MNG-6795
> URL: https://issues.apache.org/jira/browse/MNG-6795
> Project: Maven
>  Issue Type: Task
>  Components: Artifacts and Repositories
>Affects Versions: 3.3.9, 3.6.3
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.7.0-candidate
>
>
> as documented in WAGON-541 
> [372aa52c80c2f7b458c095d837e15ebeafbdf0b7|https://gitbox.apache.org/repos/asf?p=maven-wagon.git&a=commit&h=372aa52c80c2f7b458c095d837e15ebeafbdf0b7],
>  ReasonPhrase has been removed from HTTP/2 and deprecated (optional) in 
> HTTP/1.1 for more than five years. It is useful to give detailed error 
> messages on artifact transfert errors with a repository manager.
> A replacement has to be found



--
This message was sent by Atlassian Jira
(v8.3.4#803005)