[jira] [Comment Edited] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set
[
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486818#comment-16486818
]
Matthieu Brouillard edited comment on SCM-885 at 5/23/18 1:11 PM:
--
Hi Mickael,
* regarding the `.gitattributes`, if I added both the binary and EOL for the
repositories files that I added it is because:
** it happened that some files were recognized as text instead of binary
** some text files, extracted with CR+LF on my windows machine, were causing
troubles and lead to unrecognized git repo. Forcing LF resolved the pb.
* looks like the hooks were not that important ;)
Go ahead otherwise.
was (Author: mcfoggy):
Hi Mickael,
* regarding the `.gitattributes`, if I defined both the binary and EOL for the
repositories I added it is because:
** it happened that some files were recognized as text instead of binary
** some text files, extracted with CR+LF on my windows machine, were causing
troubles and lead to unrecognized git repo. Forcing LF resolved the pb.
* looks like the hooks were not that important ;)
Go ahead otherwise.
> GitChangeLogCommand is wrong when only endVersion is set
>
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.6
>
> Attachments: scm-885-different-behavior-exe-jgit-patch.diff
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso END_REVISION_SHA1 -- PROJECT_PATH}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set
[
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480425#comment-16480425
]
Matthieu Brouillard edited comment on SCM-885 at 5/18/18 9:50 AM:
--
there is not problem ; I fully undertsand you could have been confused. And
finally such confusion & discussions were good because in the end we will get a
better impl because using the cases described in above table we will be
backward compatible (expect for the bug fixes I will provide) and still offer
the possibility to have history fom the beginning of the repository.
I am working on the PR. As I really add more IT tests it takes more time to
me, stay tuned...
was (Author: mcfoggy):
there is not problem ; I fully undertsand you could have been confused. And
finally such confusion & discussions wree good because in the end we will get a
better impl because using the cases described in above table we will be
backward compatible (expect for the bug fixes I will provide) and still offer
the possibility to have history fom the beginning of the repository.
I am working on the PR. As I really add more IT tests it takes more time to me,
stay tuned...
> GitChangeLogCommand is wrong when only endVersion is set
>
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: scm-885-different-behavior-exe-jgit-patch.diff
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso END_REVISION_SHA1 -- PROJECT_PATH}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set
[
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473597#comment-16473597
]
Michael Osipov edited comment on SCM-885 at 5/13/18 8:34 PM:
-
Do you think you could modify the PR to satisfiy the first three cases of [this
spec|https://git-scm.com/docs/gitrevisions#_revision_range_summary]? I am
reluctant to change the current, correct behavior. Git offers to many
representations which cannot be covered by a generic API.
was (Author: michael-o):
Do you think you could modify the PR to satisfiy the first three cases of [this
spec|https://git-scm.com/docs/gitrevisions#_revision_range_summary]? I am
reluctant to change the current, correct behavior. Git offers to many
representations which can be covered by a generic API.
> GitChangeLogCommand is wrong when only endVersion is set
>
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso END_REVISION_SHA1 -- PROJECT_PATH}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set
[
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473597#comment-16473597
]
Michael Osipov edited comment on SCM-885 at 5/13/18 6:26 PM:
-
Do you think you could modify the PR to satisfiy the first three cases of [this
spec|https://git-scm.com/docs/gitrevisions#_revision_range_summary]? I am
reluctant to change the current, correct behavior. Git offers to many
representations which can be covered by a generic API.
was (Author: michael-o):
Do you think you could modify the PR to satisfiy the first three cases of [this
spec|https://git-scm.com/docs/gitrevisions#_revision_range_summary]?
> GitChangeLogCommand is wrong when only endVersion is set
>
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso END_REVISION_SHA1 -- PROJECT_PATH}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set
[
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464228#comment-16464228
]
Michael Osipov edited comment on SCM-885 at 5/4/18 6:18 PM:
You probably misunderstood me. Your patch would take away the ability to do
{{..END}}.
was (Author: michael-o):
You probably misunderstood me. Your patch would take away the ability do do
{{..END}}.
> GitChangeLogCommand is wrong when only endVersion is set
>
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.6
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso END_REVISION_SHA1 -- PROJECT_PATH}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set
[
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464007#comment-16464007
]
Michael Osipov edited comment on SCM-885 at 5/4/18 3:24 PM:
It is not per sé wrong:
bq. You can also leave off one side of the syntax to have Git assume HEAD. For
example, you can get the same results as in the previous example by typing git
log origin/master.. — Git substitutes HEAD if one side is missing.
So this will be wrong? Does it make sense to call {{...END}} at all?
Works for me:
{noformat}
osipovmi@blnn719x:~/var/krb5 (master *%>)
$ git log --date=iso ..origin/krb5-1.8 -- . | head
commit 33af1767f876ff4a13f28513dede75e71544523f
Author: Greg Hudson
Date: 2012-02-21 18:57:44 +
Fix kvno ASN.1 encoding interop with Windows RODCs
RFC 4120 defines the EncryptedData kvno field as an integer in the
range of unsigned 32-bit numbers. Windows encodes and decodes the
field as a signed 32-bit integer. Historically we do the same in our
encoder in 1.6 and prior, and in our decoder through 1.10. (Actually,
{noformat}
was (Author: michael-o):
It is not per sé wrong:
bq. You can also leave off one side of the syntax to have Git assume HEAD. For
example, you can get the same results as in the previous example by typing git
log origin/master.. — Git substitutes HEAD if one side is missing.
So this will be wrong? Does it make sense to call {{...END}} at all?
> GitChangeLogCommand is wrong when only endVersion is set
>
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.6
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso END_REVISION_SHA1 -- PROJECT_PATH}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
