[jira] [Commented] (ARCHETYPE-492) Underscore in filenames problematic due to greedy regex
[
https://issues.apache.org/jira/browse/ARCHETYPE-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376187#comment-16376187
]
Guillaume Boué commented on ARCHETYPE-492:
--
FIxed in
[bb723acb42efcffd335575499ac2569f98dbbaa9|http://git-wip-us.apache.org/repos/asf/maven-archetype/commit/bb723acb42efcffd335575499ac2569f98dbbaa9].
> Underscore in filenames problematic due to greedy regex
> ---
>
> Key: ARCHETYPE-492
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-492
> Project: Maven Archetype
> Issue Type: Bug
> Components: Plugin
>Affects Versions: 2.4
> Environment: Windows 7, Sun JDK
>Reporter: Oliver Dungey
>Priority: Major
> Fix For: 3.0.2
>
>
> If you have a file in a project with an underscore adjacent to a substitution
> variable, the substitution will fail i.e.
> if {{artifactId}} is 'Test' and a target file is to be named
> {{something_test.txt}} the file in the template should be named
> {{somethingartifactId__.txt}} (3 underscores in the middle) but the
> result is an error stating that the property {{_artifactId}} cannot be found.
> This is because the term inside the regex is a greedy .* - a simple fix
> would be to change this to something like __[^_]*___ which would only match
> non-underscore characters.
> Fixing this issue would allow the use of underscores in filenames in all
> circumstances rather than the current situation where you may get lucky. The
> only down side to fixing this issue is that properties with leading or
> trailing underscores will not be valid - this seems a far more preferable
> situation.
> A patch for this issue was put on this bug back in 01//2009 but somehow got
> ignored - see [~maslovalex] patch and comments at the end of this issue:
> https://issues.apache.org/jira/browse/ARCHETYPE-191
> Apologies for the formatting - it appears double underscores are an issue :-)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARCHETYPE-492) Underscore in filenames problematic due to greedy regex
[
https://issues.apache.org/jira/browse/ARCHETYPE-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374383#comment-16374383
]
Giovanni Lovato commented on ARCHETYPE-492:
---
This is an issue also for archetypes which contains Flyway database migration
files, which has a specific filename pattern, e.g. \{{V2__my-schema.sql}} (i.e.
version + _ + _ + description). So if I include in the archetype a file named
{{V2rootArtifactId__-schema.sql}} I would expect it to be created as
{{V2__my-artifact-schema.sql}}.
> Underscore in filenames problematic due to greedy regex
> ---
>
> Key: ARCHETYPE-492
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-492
> Project: Maven Archetype
> Issue Type: Bug
> Components: Plugin
>Affects Versions: 2.4
> Environment: Windows 7, Sun JDK
>Reporter: Oliver Dungey
>Priority: Major
>
> If you have a file in a project with an underscore adjacent to a substitution
> variable, the substitution will fail i.e.
> if {{artifactId}} is 'Test' and a target file is to be named
> {{something_test.txt}} the file in the template should be named
> {{somethingartifactId__.txt}} (3 underscores in the middle) but the
> result is an error stating that the property {{_artifactId}} cannot be found.
> This is because the term inside the regex is a greedy .* - a simple fix
> would be to change this to something like __[^_]*___ which would only match
> non-underscore characters.
> Fixing this issue would allow the use of underscores in filenames in all
> circumstances rather than the current situation where you may get lucky. The
> only down side to fixing this issue is that properties with leading or
> trailing underscores will not be valid - this seems a far more preferable
> situation.
> A patch for this issue was put on this bug back in 01//2009 but somehow got
> ignored - see [~maslovalex] patch and comments at the end of this issue:
> https://issues.apache.org/jira/browse/ARCHETYPE-191
> Apologies for the formatting - it appears double underscores are an issue :-)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARCHETYPE-492) Underscore in filenames problematic due to greedy regex
[
https://issues.apache.org/jira/browse/ARCHETYPE-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292219#comment-16292219
]
Matthias Hanisch commented on ARCHETYPE-492:
Just to let everybody else know my workaround:
In archetype-metadata I created a requiredProperty like this:
{noformat}
_${artifactId}
{noformat}
The above filename can be now written as
errors___underscoreArtifactId___.properties.
This avoids the triple-underscore-problem
> Underscore in filenames problematic due to greedy regex
> ---
>
> Key: ARCHETYPE-492
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-492
> Project: Maven Archetype
> Issue Type: Bug
> Components: Plugin
>Affects Versions: 2.4
> Environment: Windows 7, Sun JDK
>Reporter: Oliver Dungey
>
> If you have a file in a project with an underscore adjacent to a substitution
> variable, the substitution will fail i.e.
> if {{artifactId}} is 'Test' and a target file is to be named
> {{something_test.txt}} the file in the template should be named
> {{somethingartifactId__.txt}} (3 underscores in the middle) but the
> result is an error stating that the property {{_artifactId}} cannot be found.
> This is because the term inside the regex is a greedy .* - a simple fix
> would be to change this to something like __[^_]*___ which would only match
> non-underscore characters.
> Fixing this issue would allow the use of underscores in filenames in all
> circumstances rather than the current situation where you may get lucky. The
> only down side to fixing this issue is that properties with leading or
> trailing underscores will not be valid - this seems a far more preferable
> situation.
> A patch for this issue was put on this bug back in 01//2009 but somehow got
> ignored - see [~maslovalex] patch and comments at the end of this issue:
> https://issues.apache.org/jira/browse/ARCHETYPE-191
> Apologies for the formatting - it appears double underscores are an issue :-)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ARCHETYPE-492) Underscore in filenames problematic due to greedy regex
[
https://issues.apache.org/jira/browse/ARCHETYPE-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290895#comment-16290895
]
Matthias Hanisch commented on ARCHETYPE-492:
Got the same problem today. Wanted to generate a file
errors_${artifactId}.properties, so I chose the filename
errors___artifactId__.properties in the archetype.
The placeholder in the file name was not resolved.
> Underscore in filenames problematic due to greedy regex
> ---
>
> Key: ARCHETYPE-492
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-492
> Project: Maven Archetype
> Issue Type: Bug
> Components: Plugin
>Affects Versions: 2.4
> Environment: Windows 7, Sun JDK
>Reporter: Oliver Dungey
>
> If you have a file in a project with an underscore adjacent to a substitution
> variable, the substitution will fail i.e.
> if {{artifactId}} is 'Test' and a target file is to be named
> {{something_test.txt}} the file in the template should be named
> {{somethingartifactId__.txt}} (3 underscores in the middle) but the
> result is an error stating that the property {{_artifactId}} cannot be found.
> This is because the term inside the regex is a greedy .* - a simple fix
> would be to change this to something like __[^_]*___ which would only match
> non-underscore characters.
> Fixing this issue would allow the use of underscores in filenames in all
> circumstances rather than the current situation where you may get lucky. The
> only down side to fixing this issue is that properties with leading or
> trailing underscores will not be valid - this seems a far more preferable
> situation.
> A patch for this issue was put on this bug back in 01//2009 but somehow got
> ignored - see [~maslovalex] patch and comments at the end of this issue:
> https://issues.apache.org/jira/browse/ARCHETYPE-191
> Apologies for the formatting - it appears double underscores are an issue :-)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
