[jira] [Commented] (MJAR-269) Add Skip Property to Skip Plugin Execution
[ https://issues.apache.org/jira/browse/MJAR-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018693#comment-17018693 ] Robert Scholte commented on MJAR-269: - Maven offers several options you can write by yourself: plugins, extensions and custom lifecycles. Since you want to call several plugins bound to the same phase, a custom lifecycle might be an option. These aren't well described, though. > Add Skip Property to Skip Plugin Execution > -- > > Key: MJAR-269 > URL: https://issues.apache.org/jira/browse/MJAR-269 > Project: Maven JAR Plugin > Issue Type: New Feature >Reporter: Brian Wyka >Assignee: Robert Scholte >Priority: Minor > Labels: skip > Original Estimate: 96h > Time Spent: 20m > Remaining Estimate: 95h 40m > > Expose plugin configuration as well as a user property to allow the plugin > execution to be skipped. > > There are occasions when we do not always want to run jar plugin. > > Example: > In a build pipeline, we run different phases in different stages > > # Run install in isolation (we need jar here) > # Run deploy in isolation (we don't need jar again - so need a way to skip) > > Currently there is only a hack to do this, by overriding the *default-jar* > execution of the plugin and setting the phase to a user property, and then > overriding that to a non-existent phase, to keep it from being attached to > the maven lifecycle. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MJAR-269) Add Skip Property to Skip Plugin Execution
[ https://issues.apache.org/jira/browse/MJAR-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018691#comment-17018691 ] Brian Wyka commented on MJAR-269: - Any ideas other than the one mentioned in the issue description on how to acccomplish this? Honestly, to me, the "solution" in the issue description is more of a hack than anything else. Trying to brainstorm how we can do this better, but not seeing a way since I still want other plugins to be able to tie into the deploy phase and to not by skipped when calling *deploy:deploy* in isolation. > Add Skip Property to Skip Plugin Execution > -- > > Key: MJAR-269 > URL: https://issues.apache.org/jira/browse/MJAR-269 > Project: Maven JAR Plugin > Issue Type: New Feature >Reporter: Brian Wyka >Assignee: Robert Scholte >Priority: Minor > Labels: skip > Original Estimate: 96h > Time Spent: 20m > Remaining Estimate: 95h 40m > > Expose plugin configuration as well as a user property to allow the plugin > execution to be skipped. > > There are occasions when we do not always want to run jar plugin. > > Example: > In a build pipeline, we run different phases in different stages > > # Run install in isolation (we need jar here) > # Run deploy in isolation (we don't need jar again - so need a way to skip) > > Currently there is only a hack to do this, by overriding the *default-jar* > execution of the plugin and setting the phase to a user property, and then > overriding that to a non-existent phase, to keep it from being attached to > the maven lifecycle. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MJAR-269) Add Skip Property to Skip Plugin Execution
[ https://issues.apache.org/jira/browse/MJAR-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018682#comment-17018682 ] Robert Scholte commented on MJAR-269: - I didn't expect these parameters to exist, but it doesn't change my opinion. The description is quite clear, it is no recommended and that's for me a code smell. I won't introduce workarounds if I know we can do better (because once workarounds exist it is very hard to remove them). > Add Skip Property to Skip Plugin Execution > -- > > Key: MJAR-269 > URL: https://issues.apache.org/jira/browse/MJAR-269 > Project: Maven JAR Plugin > Issue Type: New Feature >Reporter: Brian Wyka >Assignee: Robert Scholte >Priority: Minor > Labels: skip > Original Estimate: 96h > Time Spent: 20m > Remaining Estimate: 95h 40m > > Expose plugin configuration as well as a user property to allow the plugin > execution to be skipped. > > There are occasions when we do not always want to run jar plugin. > > Example: > In a build pipeline, we run different phases in different stages > > # Run install in isolation (we need jar here) > # Run deploy in isolation (we don't need jar again - so need a way to skip) > > Currently there is only a hack to do this, by overriding the *default-jar* > execution of the plugin and setting the phase to a user property, and then > overriding that to a non-existent phase, to keep it from being attached to > the maven lifecycle. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MJAR-269) Add Skip Property to Skip Plugin Execution
[ https://issues.apache.org/jira/browse/MJAR-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018678#comment-17018678 ] Brian Wyka commented on MJAR-269: - I guess I don't understand why we wouldn't want to give power to the user to decide? > Add Skip Property to Skip Plugin Execution > -- > > Key: MJAR-269 > URL: https://issues.apache.org/jira/browse/MJAR-269 > Project: Maven JAR Plugin > Issue Type: New Feature >Reporter: Brian Wyka >Assignee: Robert Scholte >Priority: Minor > Labels: skip > Original Estimate: 96h > Time Spent: 20m > Remaining Estimate: 95h 40m > > Expose plugin configuration as well as a user property to allow the plugin > execution to be skipped. > > There are occasions when we do not always want to run jar plugin. > > Example: > In a build pipeline, we run different phases in different stages > > # Run install in isolation (we need jar here) > # Run deploy in isolation (we don't need jar again - so need a way to skip) > > Currently there is only a hack to do this, by overriding the *default-jar* > execution of the plugin and setting the phase to a user property, and then > overriding that to a non-existent phase, to keep it from being attached to > the maven lifecycle. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MJAR-269) Add Skip Property to Skip Plugin Execution
[ https://issues.apache.org/jira/browse/MJAR-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018677#comment-17018677 ] Brian Wyka commented on MJAR-269: - [~rfscholte], both of those plugins already have skip properties enabled: * maven-compiler-plugin: [https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#skipMain] * maven-resources-plgin: [https://maven.apache.org/plugins/maven-resources-plugin/resources-mojo.html#skip] Calling *deploy:deploy* is a partial solution in this case for sure. However, it prevents custom implementations of a pom which tie into the *deploy* phase from executing in this case, so not optimal or idea, unfortunately. > Add Skip Property to Skip Plugin Execution > -- > > Key: MJAR-269 > URL: https://issues.apache.org/jira/browse/MJAR-269 > Project: Maven JAR Plugin > Issue Type: New Feature >Reporter: Brian Wyka >Assignee: Robert Scholte >Priority: Minor > Labels: skip > Original Estimate: 96h > Time Spent: 20m > Remaining Estimate: 95h 40m > > Expose plugin configuration as well as a user property to allow the plugin > execution to be skipped. > > There are occasions when we do not always want to run jar plugin. > > Example: > In a build pipeline, we run different phases in different stages > > # Run install in isolation (we need jar here) > # Run deploy in isolation (we don't need jar again - so need a way to skip) > > Currently there is only a hack to do this, by overriding the *default-jar* > execution of the plugin and setting the phase to a user property, and then > overriding that to a non-existent phase, to keep it from being attached to > the maven lifecycle. -- This message was sent by Atlassian Jira (v8.3.4#803005)
