[jira] [Commented] (MNG-6256) Maven script can break if "-f" path contains special characters

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17069805#comment-17069805
 ] 

Hudson commented on MNG-6256:
-

Build failed in Jenkins: Maven TLP » maven-studies » maven-metrics #4

See 
https://builds.apache.org/job/maven-box/job/maven-studies/job/maven-metrics/4/

> Maven script can break if "-f" path contains special characters 
> 
>
> Key: MNG-6256
> URL: https://issues.apache.org/jira/browse/MNG-6256
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.5.0
> Environment: Windows 10 with PowerShell
>Reporter: Christoph Etzel
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.1
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Executing maven on Windows using the {{\-f}} or {{--file}} parameter to 
> specify an alternate POM file can break the script if the path contains 
> special characters. 
> It was originally discovered on a Windows Jenkins instance with working 
> directory located under C:\Program Files (x86)\Jenkins..
> Example:
> {code:java}mvn -f "folderWithClosing)Bracket/pomFolder"{code}
> Command line output: {{"Bracket/pomFolder" kann syntaktisch an dieser Stelle 
> nicht verarbeitet werden.}}
> Just for fun: Starting calc from maven script using {{\-f}}
> {code:java}mvn -f " ' & start calc"{code}
> Command line output: {{POM file  '}} and a new calculator process
> The bug was introduced with commit 
> https://github.com/apache/maven/commit/f8ab2a650f32d5d87126d341d9bbfccbf99fd0ca
>  for issue MNG-5889.
> Workaround: Use maven 3.3.9 or below
> Possible fix: Escape {{%FILE_ARG%}} and {{%POM_DIR%}} with {{"}} in {{echo}} 
> commands in {{maven.cmd}} (line 120 and 129).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6256) Maven script can break if "-f" path contains special characters

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810375#comment-16810375
 ] 

Hudson commented on MNG-6256:
-

Build unstable in Jenkins: Maven TLP » maven » MNG-6169/MNG-6556 #12

See 
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6169%252FMNG-6556/12/

> Maven script can break if "-f" path contains special characters 
> 
>
> Key: MNG-6256
> URL: https://issues.apache.org/jira/browse/MNG-6256
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.5.0
> Environment: Windows 10 with PowerShell
>Reporter: Christoph Etzel
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.1
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Executing maven on Windows using the {{\-f}} or {{--file}} parameter to 
> specify an alternate POM file can break the script if the path contains 
> special characters. 
> It was originally discovered on a Windows Jenkins instance with working 
> directory located under C:\Program Files (x86)\Jenkins..
> Example:
> {code:java}mvn -f "folderWithClosing)Bracket/pomFolder"{code}
> Command line output: {{"Bracket/pomFolder" kann syntaktisch an dieser Stelle 
> nicht verarbeitet werden.}}
> Just for fun: Starting calc from maven script using {{\-f}}
> {code:java}mvn -f " ' & start calc"{code}
> Command line output: {{POM file  '}} and a new calculator process
> The bug was introduced with commit 
> https://github.com/apache/maven/commit/f8ab2a650f32d5d87126d341d9bbfccbf99fd0ca
>  for issue MNG-5889.
> Workaround: Use maven 3.3.9 or below
> Possible fix: Escape {{%FILE_ARG%}} and {{%POM_DIR%}} with {{"}} in {{echo}} 
> commands in {{maven.cmd}} (line 120 and 129).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6256) Maven script can break if "-f" path contains special characters

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782698#comment-16782698
 ] 

Hudson commented on MNG-6256:
-

Build succeeded in Jenkins: Maven TLP » maven » MNG-6294 #12

See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6294/12/

> Maven script can break if "-f" path contains special characters 
> 
>
> Key: MNG-6256
> URL: https://issues.apache.org/jira/browse/MNG-6256
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.5.0
> Environment: Windows 10 with PowerShell
>Reporter: Christoph Etzel
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.1
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Executing maven on Windows using the {{\-f}} or {{--file}} parameter to 
> specify an alternate POM file can break the script if the path contains 
> special characters. 
> It was originally discovered on a Windows Jenkins instance with working 
> directory located under C:\Program Files (x86)\Jenkins..
> Example:
> {code:java}mvn -f "folderWithClosing)Bracket/pomFolder"{code}
> Command line output: {{"Bracket/pomFolder" kann syntaktisch an dieser Stelle 
> nicht verarbeitet werden.}}
> Just for fun: Starting calc from maven script using {{\-f}}
> {code:java}mvn -f " ' & start calc"{code}
> Command line output: {{POM file  '}} and a new calculator process
> The bug was introduced with commit 
> https://github.com/apache/maven/commit/f8ab2a650f32d5d87126d341d9bbfccbf99fd0ca
>  for issue MNG-5889.
> Workaround: Use maven 3.3.9 or below
> Possible fix: Escape {{%FILE_ARG%}} and {{%POM_DIR%}} with {{"}} in {{echo}} 
> commands in {{maven.cmd}} (line 120 and 129).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6256) Maven script can break if "-f" path contains special characters

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770664#comment-16770664
 ] 

Hudson commented on MNG-6256:
-

Build succeeded in Jenkins: Maven TLP » maven » MNG-6169/MNG-6550 #8

See 
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6169%252FMNG-6550/8/

> Maven script can break if "-f" path contains special characters 
> 
>
> Key: MNG-6256
> URL: https://issues.apache.org/jira/browse/MNG-6256
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.5.0
> Environment: Windows 10 with PowerShell
>Reporter: Christoph Etzel
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.1
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Executing maven on Windows using the {{\-f}} or {{--file}} parameter to 
> specify an alternate POM file can break the script if the path contains 
> special characters. 
> It was originally discovered on a Windows Jenkins instance with working 
> directory located under C:\Program Files (x86)\Jenkins..
> Example:
> {code:java}mvn -f "folderWithClosing)Bracket/pomFolder"{code}
> Command line output: {{"Bracket/pomFolder" kann syntaktisch an dieser Stelle 
> nicht verarbeitet werden.}}
> Just for fun: Starting calc from maven script using {{\-f}}
> {code:java}mvn -f " ' & start calc"{code}
> Command line output: {{POM file  '}} and a new calculator process
> The bug was introduced with commit 
> https://github.com/apache/maven/commit/f8ab2a650f32d5d87126d341d9bbfccbf99fd0ca
>  for issue MNG-5889.
> Workaround: Use maven 3.3.9 or below
> Possible fix: Escape {{%FILE_ARG%}} and {{%POM_DIR%}} with {{"}} in {{echo}} 
> commands in {{maven.cmd}} (line 120 and 129).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6256) Maven script can break if "-f" path contains special characters

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753530#comment-16753530
 ] 

Hudson commented on MNG-6256:
-

Build failed in Jenkins: Maven TLP » maven » MNG-6512-build-11 #9

See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6512-build-11/9/

> Maven script can break if "-f" path contains special characters 
> 
>
> Key: MNG-6256
> URL: https://issues.apache.org/jira/browse/MNG-6256
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.5.0
> Environment: Windows 10 with PowerShell
>Reporter: Christoph Etzel
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.1
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Executing maven on Windows using the {{\-f}} or {{--file}} parameter to 
> specify an alternate POM file can break the script if the path contains 
> special characters. 
> It was originally discovered on a Windows Jenkins instance with working 
> directory located under C:\Program Files (x86)\Jenkins..
> Example:
> {code:java}mvn -f "folderWithClosing)Bracket/pomFolder"{code}
> Command line output: {{"Bracket/pomFolder" kann syntaktisch an dieser Stelle 
> nicht verarbeitet werden.}}
> Just for fun: Starting calc from maven script using {{\-f}}
> {code:java}mvn -f " ' & start calc"{code}
> Command line output: {{POM file  '}} and a new calculator process
> The bug was introduced with commit 
> https://github.com/apache/maven/commit/f8ab2a650f32d5d87126d341d9bbfccbf99fd0ca
>  for issue MNG-5889.
> Workaround: Use maven 3.3.9 or below
> Possible fix: Escape {{%FILE_ARG%}} and {{%POM_DIR%}} with {{"}} in {{echo}} 
> commands in {{maven.cmd}} (line 120 and 129).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6256) Maven script can break if "-f" path contains special characters

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740657#comment-16740657
 ] 

Hudson commented on MNG-6256:
-

Build failed in Jenkins: Maven TLP » maven » MNG-6522 #11

See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6522/11/

> Maven script can break if "-f" path contains special characters 
> 
>
> Key: MNG-6256
> URL: https://issues.apache.org/jira/browse/MNG-6256
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.5.0
> Environment: Windows 10 with PowerShell
>Reporter: Christoph Etzel
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.1
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Executing maven on Windows using the {{\-f}} or {{--file}} parameter to 
> specify an alternate POM file can break the script if the path contains 
> special characters. 
> It was originally discovered on a Windows Jenkins instance with working 
> directory located under C:\Program Files (x86)\Jenkins..
> Example:
> {code:java}mvn -f "folderWithClosing)Bracket/pomFolder"{code}
> Command line output: {{"Bracket/pomFolder" kann syntaktisch an dieser Stelle 
> nicht verarbeitet werden.}}
> Just for fun: Starting calc from maven script using {{\-f}}
> {code:java}mvn -f " ' & start calc"{code}
> Command line output: {{POM file  '}} and a new calculator process
> The bug was introduced with commit 
> https://github.com/apache/maven/commit/f8ab2a650f32d5d87126d341d9bbfccbf99fd0ca
>  for issue MNG-5889.
> Workaround: Use maven 3.3.9 or below
> Possible fix: Escape {{%FILE_ARG%}} and {{%POM_DIR%}} with {{"}} in {{echo}} 
> commands in {{maven.cmd}} (line 120 and 129).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6256) Maven script can break if "-f" path contains special characters

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739467#comment-16739467
 ] 

Hudson commented on MNG-6256:
-

Build unstable in Jenkins: Maven TLP » maven » master #132

See https://builds.apache.org/job/maven-box/job/maven/job/master/132/

> Maven script can break if "-f" path contains special characters 
> 
>
> Key: MNG-6256
> URL: https://issues.apache.org/jira/browse/MNG-6256
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.5.0
> Environment: Windows 10 with PowerShell
>Reporter: Christoph Etzel
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.1
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Executing maven on Windows using the {{\-f}} or {{--file}} parameter to 
> specify an alternate POM file can break the script if the path contains 
> special characters. 
> It was originally discovered on a Windows Jenkins instance with working 
> directory located under C:\Program Files (x86)\Jenkins..
> Example:
> {code:java}mvn -f "folderWithClosing)Bracket/pomFolder"{code}
> Command line output: {{"Bracket/pomFolder" kann syntaktisch an dieser Stelle 
> nicht verarbeitet werden.}}
> Just for fun: Starting calc from maven script using {{\-f}}
> {code:java}mvn -f " ' & start calc"{code}
> Command line output: {{POM file  '}} and a new calculator process
> The bug was introduced with commit 
> https://github.com/apache/maven/commit/f8ab2a650f32d5d87126d341d9bbfccbf99fd0ca
>  for issue MNG-5889.
> Workaround: Use maven 3.3.9 or below
> Possible fix: Escape {{%FILE_ARG%}} and {{%POM_DIR%}} with {{"}} in {{echo}} 
> commands in {{maven.cmd}} (line 120 and 129).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6256) Maven script can break if "-f" path contains special characters

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738799#comment-16738799
 ] 

Hudson commented on MNG-6256:
-

Build failed in Jenkins: Maven TLP » maven » MNG-6069 #23

See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6069/23/

> Maven script can break if "-f" path contains special characters 
> 
>
> Key: MNG-6256
> URL: https://issues.apache.org/jira/browse/MNG-6256
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.5.0
> Environment: Windows 10 with PowerShell
>Reporter: Christoph Etzel
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.1
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Executing maven on Windows using the {{\-f}} or {{--file}} parameter to 
> specify an alternate POM file can break the script if the path contains 
> special characters. 
> It was originally discovered on a Windows Jenkins instance with working 
> directory located under C:\Program Files (x86)\Jenkins..
> Example:
> {code:java}mvn -f "folderWithClosing)Bracket/pomFolder"{code}
> Command line output: {{"Bracket/pomFolder" kann syntaktisch an dieser Stelle 
> nicht verarbeitet werden.}}
> Just for fun: Starting calc from maven script using {{\-f}}
> {code:java}mvn -f " ' & start calc"{code}
> Command line output: {{POM file  '}} and a new calculator process
> The bug was introduced with commit 
> https://github.com/apache/maven/commit/f8ab2a650f32d5d87126d341d9bbfccbf99fd0ca
>  for issue MNG-5889.
> Workaround: Use maven 3.3.9 or below
> Possible fix: Escape {{%FILE_ARG%}} and {{%POM_DIR%}} with {{"}} in {{echo}} 
> commands in {{maven.cmd}} (line 120 and 129).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6256) Maven script can break if "-f" path contains special characters

[Sylwester Lachiewicz (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737685#comment-16737685
 ] 

Sylwester Lachiewicz commented on MNG-6256:
---

Fixed with 
[a939654b765f06b1c1ee811a297b02e83b4ac316|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=a939654b765f06b1c1ee811a297b02e83b4ac316]
 - patch adjusted to add double quotes only aroud parameters in echo command.

> Maven script can break if "-f" path contains special characters 
> 
>
> Key: MNG-6256
> URL: https://issues.apache.org/jira/browse/MNG-6256
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.5.0
> Environment: Windows 10 with PowerShell
>Reporter: Christoph Etzel
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.1
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Executing maven on Windows using the {{\-f}} or {{--file}} parameter to 
> specify an alternate POM file can break the script if the path contains 
> special characters. 
> It was originally discovered on a Windows Jenkins instance with working 
> directory located under C:\Program Files (x86)\Jenkins..
> Example:
> {code:java}mvn -f "folderWithClosing)Bracket/pomFolder"{code}
> Command line output: {{"Bracket/pomFolder" kann syntaktisch an dieser Stelle 
> nicht verarbeitet werden.}}
> Just for fun: Starting calc from maven script using {{\-f}}
> {code:java}mvn -f " ' & start calc"{code}
> Command line output: {{POM file  '}} and a new calculator process
> The bug was introduced with commit 
> https://github.com/apache/maven/commit/f8ab2a650f32d5d87126d341d9bbfccbf99fd0ca
>  for issue MNG-5889.
> Workaround: Use maven 3.3.9 or below
> Possible fix: Escape {{%FILE_ARG%}} and {{%POM_DIR%}} with {{"}} in {{echo}} 
> commands in {{maven.cmd}} (line 120 and 129).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6256) Maven script can break if "-f" path contains special characters

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737684#comment-16737684
 ] 

Hudson commented on MNG-6256:
-

Build succeeded in Jenkins: Maven TLP » maven » MNG-6256 #7

See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6256/7/

> Maven script can break if "-f" path contains special characters 
> 
>
> Key: MNG-6256
> URL: https://issues.apache.org/jira/browse/MNG-6256
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.5.0
> Environment: Windows 10 with PowerShell
>Reporter: Christoph Etzel
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.1
>
>
> Executing maven on Windows using the {{\-f}} or {{--file}} parameter to 
> specify an alternate POM file can break the script if the path contains 
> special characters. 
> It was originally discovered on a Windows Jenkins instance with working 
> directory located under C:\Program Files (x86)\Jenkins..
> Example:
> {code:java}mvn -f "folderWithClosing)Bracket/pomFolder"{code}
> Command line output: {{"Bracket/pomFolder" kann syntaktisch an dieser Stelle 
> nicht verarbeitet werden.}}
> Just for fun: Starting calc from maven script using {{\-f}}
> {code:java}mvn -f " ' & start calc"{code}
> Command line output: {{POM file  '}} and a new calculator process
> The bug was introduced with commit 
> https://github.com/apache/maven/commit/f8ab2a650f32d5d87126d341d9bbfccbf99fd0ca
>  for issue MNG-5889.
> Workaround: Use maven 3.3.9 or below
> Possible fix: Escape {{%FILE_ARG%}} and {{%POM_DIR%}} with {{"}} in {{echo}} 
> commands in {{maven.cmd}} (line 120 and 129).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6256) Maven script can break if "-f" path contains special characters

[Robert Scholte (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358453#comment-16358453
 ] 

Robert Scholte commented on MNG-6256:
-

{noformat}

set FILE_ARG=
:arg_loop
if "%~1" == "-f" (
 setx FILE_ARG="%~2"
 shift
 goto process_file_arg
)
if "%~1" == "--file" (
 setx FILE_ARG="%~2"
 shift
 goto process_file_arg
)

{noformat}

 

switching to {{setx}} seems to work. Not sure what the impact will be, so maybe 
better not do it for 3.5.x

> Maven script can break if "-f" path contains special characters 
> 
>
> Key: MNG-6256
> URL: https://issues.apache.org/jira/browse/MNG-6256
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.5.0
> Environment: Windows 10 with PowerShell
>Reporter: Christoph Etzel
>Priority: Major
> Fix For: 3.5.3-candidate
>
>
> Executing maven on Windows using the {{\-f}} or {{--file}} parameter to 
> specify an alternate POM file can break the script if the path contains 
> special characters. 
> It was originally discovered on a Windows Jenkins instance with working 
> directory located under C:\Program Files (x86)\Jenkins..
> Example:
> {code:java}mvn -f "folderWithClosing)Bracket/pomFolder"{code}
> Command line output: {{"Bracket/pomFolder" kann syntaktisch an dieser Stelle 
> nicht verarbeitet werden.}}
> Just for fun: Starting calc from maven script using {{\-f}}
> {code:java}mvn -f " ' & start calc"{code}
> Command line output: {{POM file  '}} and a new calculator process
> The bug was introduced with commit 
> https://github.com/apache/maven/commit/f8ab2a650f32d5d87126d341d9bbfccbf99fd0ca
>  for issue MNG-5889.
> Workaround: Use maven 3.3.9 or below
> Possible fix: Escape {{%FILE_ARG%}} and {{%POM_DIR%}} with {{"}} in {{echo}} 
> commands in {{maven.cmd}} (line 120 and 129).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6256) Maven script can break if "-f" path contains special characters

[Christoph Etzel (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350117#comment-16350117
 ] 

Christoph Etzel commented on MNG-6256:
--

[~khmarbaise] can you provide a link to the 3.5.3-candidate, so i can test it? 
I have not found a tag or branch in the git repo.

> Maven script can break if "-f" path contains special characters 
> 
>
> Key: MNG-6256
> URL: https://issues.apache.org/jira/browse/MNG-6256
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.5.0
> Environment: Windows 10 with PowerShell
>Reporter: Christoph Etzel
>Priority: Major
> Fix For: 3.5.3-candidate
>
>
> Executing maven on Windows using the {{\-f}} or {{--file}} parameter to 
> specify an alternate POM file can break the script if the path contains 
> special characters. 
> It was originally discovered on a Windows Jenkins instance with working 
> directory located under C:\Program Files (x86)\Jenkins..
> Example:
> {code:java}mvn -f "folderWithClosing)Bracket/pomFolder"{code}
> Command line output: {{"Bracket/pomFolder" kann syntaktisch an dieser Stelle 
> nicht verarbeitet werden.}}
> Just for fun: Starting calc from maven script using {{\-f}}
> {code:java}mvn -f " ' & start calc"{code}
> Command line output: {{POM file  '}} and a new calculator process
> The bug was introduced with commit 
> https://github.com/apache/maven/commit/f8ab2a650f32d5d87126d341d9bbfccbf99fd0ca
>  for issue MNG-5889.
> Workaround: Use maven 3.3.9 or below
> Possible fix: Escape {{%FILE_ARG%}} and {{%POM_DIR%}} with {{"}} in {{echo}} 
> commands in {{maven.cmd}} (line 120 and 129).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6256) Maven script can break if "-f" path contains special characters

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089521#comment-16089521
 ] 

ASF GitHub Bot commented on MNG-6256:
-

Github user etzelc commented on the issue:

https://github.com/apache/maven/pull/128
  
Now in `mvn.cmd` the string parameter of the echo command is surrounded 
with double quotes, like in `mvn`.


> Maven script can break if "-f" path contains special characters 
> 
>
> Key: MNG-6256
> URL: https://issues.apache.org/jira/browse/MNG-6256
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.5.0
> Environment: Windows 10 with PowerShell
>Reporter: Christoph Etzel
>
> Executing maven on Windows using the {{\-f}} or {{--file}} parameter to 
> specify an alternate POM file can break the script if the path contains 
> special characters. 
> It was originally discovered on a Windows Jenkins instance with working 
> directory located under C:\Program Files (x86)\Jenkins..
> Example:
> {code:java}mvn -f "folderWithClosing)Bracket/pomFolder"{code}
> Command line output: {{"Bracket/pomFolder" kann syntaktisch an dieser Stelle 
> nicht verarbeitet werden.}}
> Just for fun: Starting calc from maven script using {{\-f}}
> {code:java}mvn -f " ' & start calc"{code}
> Command line output: {{POM file  '}} and a new calculator process
> The bug was introduced with commit 
> https://github.com/apache/maven/commit/f8ab2a650f32d5d87126d341d9bbfccbf99fd0ca
>  for issue MNG-5889.
> Workaround: Use maven 3.3.9 or below
> Possible fix: Escape {{%FILE_ARG%}} and {{%POM_DIR%}} with {{"}} in {{echo}} 
> commands in {{maven.cmd}} (line 120 and 129).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MNG-6256) Maven script can break if "-f" path contains special characters

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088575#comment-16088575
 ] 

ASF GitHub Bot commented on MNG-6256:
-

Github user etzelc commented on the issue:

https://github.com/apache/maven/pull/128
  
I will have a closer look next week, right now only tested with Windows 
(since only cmd script was modified). In the {{mvn}} script the string of the 
{{echo}} is already completely in double quotes, but I will have a look. 

I have already an IT with three tests (for space, bracket and ampersand), 
but found out that maven has problems with ampersands in folder names. Probably 
I will remove that special case. See 
https://github.com/etzelc/maven-integration-testing/tree/MNG-6256



> Maven script can break if "-f" path contains special characters 
> 
>
> Key: MNG-6256
> URL: https://issues.apache.org/jira/browse/MNG-6256
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.5.0
> Environment: Windows 10 with PowerShell
>Reporter: Christoph Etzel
>
> Executing maven on Windows using the {{\-f}} or {{--file}} parameter to 
> specify an alternate POM file can break the script if the path contains 
> special characters. 
> It was originally discovered on a Windows Jenkins instance with working 
> directory located under C:\Program Files (x86)\Jenkins..
> Example:
> {code:java}mvn -f "folderWithClosing)Bracket/pomFolder"{code}
> Command line output: {{"Bracket/pomFolder" kann syntaktisch an dieser Stelle 
> nicht verarbeitet werden.}}
> Just for fun: Starting calc from maven script using {{\-f}}
> {code:java}mvn -f " ' & start calc"{code}
> Command line output: {{POM file  '}} and a new calculator process
> The bug was introduced with commit 
> https://github.com/apache/maven/commit/f8ab2a650f32d5d87126d341d9bbfccbf99fd0ca
>  for issue MNG-5889.
> Workaround: Use maven 3.3.9 or below
> Possible fix: Escape {{%FILE_ARG%}} and {{%POM_DIR%}} with {{"}} in {{echo}} 
> commands in {{maven.cmd}} (line 120 and 129).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MNG-6256) Maven script can break if "-f" path contains special characters

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088568#comment-16088568
 ] 

ASF GitHub Bot commented on MNG-6256:
-

Github user Tunaki commented on the issue:

https://github.com/apache/maven/pull/128
  
Shouldn't there be the same fix for `mvn`, and not just `mvn.cmd`? 
[`${basedir}`](https://github.com/apache/maven/blob/707cff6ffdecbfb0e0356c70e3a7b490535e7ce4/apache-maven/src/bin/mvn#L150)
 and 
[`${arg}`](https://github.com/apache/maven/blob/707cff6ffdecbfb0e0356c70e3a7b490535e7ce4/apache-maven/src/bin/mvn#L154)
 are not escaped as well.


> Maven script can break if "-f" path contains special characters 
> 
>
> Key: MNG-6256
> URL: https://issues.apache.org/jira/browse/MNG-6256
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.5.0
> Environment: Windows 10 with PowerShell
>Reporter: Christoph Etzel
>
> Executing maven on Windows using the {{\-f}} or {{--file}} parameter to 
> specify an alternate POM file can break the script if the path contains 
> special characters. 
> It was originally discovered on a Windows Jenkins instance with working 
> directory located under C:\Program Files (x86)\Jenkins..
> Example:
> {code:java}mvn -f "folderWithClosing)Bracket/pomFolder"{code}
> Command line output: {{"Bracket/pomFolder" kann syntaktisch an dieser Stelle 
> nicht verarbeitet werden.}}
> Just for fun: Starting calc from maven script using {{\-f}}
> {code:java}mvn -f " ' & start calc"{code}
> Command line output: {{POM file  '}} and a new calculator process
> The bug was introduced with commit 
> https://github.com/apache/maven/commit/f8ab2a650f32d5d87126d341d9bbfccbf99fd0ca
>  for issue MNG-5889.
> Workaround: Use maven 3.3.9 or below
> Possible fix: Escape {{%FILE_ARG%}} and {{%POM_DIR%}} with {{"}} in {{echo}} 
> commands in {{maven.cmd}} (line 120 and 129).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MNG-6256) Maven script can break if "-f" path contains special characters

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087336#comment-16087336
 ] 

ASF GitHub Bot commented on MNG-6256:
-

GitHub user etzelc opened a pull request:

https://github.com/apache/maven/pull/128

[MNG-6256] Surround variables in echo command with double quotes

This is a patch for issue MNG-6256. 
https://issues.apache.org/jira/browse/MNG-6256

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/etzelc/maven MNG-6256

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven/pull/128.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #128


commit f578a733ade77c3d11186c395d1d5199a65f532d
Author: Christoph Etzel 
Date:   2017-07-14T08:26:06Z

[MNG-6256] Surround variables in echo command with double quotes




> Maven script can break if "-f" path contains special characters 
> 
>
> Key: MNG-6256
> URL: https://issues.apache.org/jira/browse/MNG-6256
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.5.0
> Environment: Windows 10 with PowerShell
>Reporter: Christoph Etzel
>
> Executing maven on Windows using the {{\-f}} or {{--file}} parameter to 
> specify an alternate POM file can break the script if the path contains 
> special characters. 
> It was originally discovered on a Windows Jenkins instance with working 
> directory located under C:\Program Files (x86)\Jenkins..
> Example:
> {code:java}mvn -f "folderWithClosing)Bracket/pomFolder"{code}
> Command line output: {{"Bracket/pomFolder" kann syntaktisch an dieser Stelle 
> nicht verarbeitet werden.}}
> Just for fun: Starting calc from maven script using {{\-f}}
> {code:java}mvn -f " ' & start calc"{code}
> Command line output: {{POM file  '}} and a new calculator process
> The bug was introduced with commit 
> https://github.com/apache/maven/commit/f8ab2a650f32d5d87126d341d9bbfccbf99fd0ca
>  for issue MNG-5889.
> Workaround: Use maven 3.3.9 or below
> Possible fix: Escape {{%FILE_ARG%}} and {{%POM_DIR%}} with {{"}} in {{echo}} 
> commands in {{maven.cmd}} (line 120 and 129).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)